] LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids
1 FAILED TEST
```
I am still investigating the failure but thought of putting out the review to
get some comments in the meanwhile (and some possible hints :-)).
Thanks,
Kapil Arya
tps://reviews.apache.org/r/38635/#comment157480>
Do we want to ABORT, or return an Error here (and below)? Not sure, if we
have a policy that I missed.
src/slave/flags.cpp (line 311)
<https://reviews.apache.org/r/38635/#comment157478>
Newline?
- Kapil Arya
On Sept. 23, 20
] LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids
1 FAILED TEST
```
I am still investigating the failure but thought of putting out the review to
get some comments in the meanwhile (and some possible hints :-)).
Thanks,
Kapil Arya
://reviews.apache.org/r/38697/diff/
Testing
---
Viewed in help message as well as markdown viewer.
Thanks,
Kapil Arya
/slave/flags.cpp 6164b4bae3f1b74da87f01a6db934f265e1a0117
Diff: https://reviews.apache.org/r/38697/diff/
Testing
---
Viewed in help message as well as markdown viewer.
Thanks,
Kapil Arya
ews.apache.org/r/38697/
- Kapil
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38660/#review100302
---
On Sept. 23,
> On Sept. 22, 2015, 2:58 p.m., Kapil Arya wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp, line 73
> > <https://reviews.apache.org/r/38639/diff/1/?file=1081455#file1081455line73>
> >
> > We should delete the stack only if CLONE_VM wa
a new thread, not a
new process.
- Kapil Arya
On Sept. 22, 2015, 2:36 p.m., haosdent huang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
in the meanwhile (and some possible hints :-)).
Thanks,
Kapil Arya
.
src/hook/manager.cpp (line 141)
<https://reviews.apache.org/r/38575/#comment156899>
s/slave lost/slave-lost/ (?)
src/tests/hook_tests.cpp (line 243)
<https://reviews.apache.org/r/38575/#comment156901>
s/ yet././
- Kapil Arya
On Sept. 21, 2015, 6:40 p.m., Niklas N
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38574/#review99888
---
Ship it!
Ship It!
- Kapil Arya
On Sept. 21, 2015, 6:38 p.m
tps://reviews.apache.org/r/38564/#comment156906>
Alphabetize please.
- Kapil Arya
On Sept. 21, 2015, 9:27 p.m., Felix Abecassis wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
ot; before
validating the value of "foo"?
- Kapil Arya
On Sept. 21, 2015, 9:26 p.m., Felix Abecassis wrote:
>
> ---
> This is an automatically generated e-mail. To reply, vi
tps://reviews.apache.org/r/38517/#comment156904>
Kill the newline.
- Kapil Arya
On Sept. 18, 2015, 8:59 p.m., Felix Abecassis wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
/slave/containerizer/linux_launcher.cpp (line 199)
<https://reviews.apache.org/r/38535/#comment156687>
We need to free up the memory allocated above. It should be safe to do so
after the clone call returns since it creates a new process.
- Kapil Arya
On Sept. 20, 2015, 12:08 p.m., ha
1b83a8725b35435531038e37188b4c97189cef03
src/tests/containerizer/isolator_tests.cpp
d34c82a7f24da6f60cfb22790f516dc6065b1f6f
Diff: https://reviews.apache.org/r/38365/diff/
Testing
---
make check
Thanks,
Kapil Arya
---
Added new tests and ran make check.
Thanks,
Kapil Arya
ffa371fab69ce5eebe3b02afc2a1724a0f52110f
src/tests/containerizer/isolator_tests.cpp
d34c82a7f24da6f60cfb22790f516dc6065b1f6f
src/tests/containerizer/launcher.hpp 6f020f94b042eef0e6a69ba8c26dfb697f3e81a3
Diff: https://reviews.apache.org/r/38363/diff/
Testing
---
make check.
Thanks,
Kapil Arya
/manager.cpp 754c238fcf728d6aa5b897ed5d9f46c251345334
src/slave/slave.cpp 44865bd2f7ab822829f93780ba1b883ffedb9842
src/tests/hook_tests.cpp deb4343089a30073e8f1f811731b075f7d968846
Diff: https://reviews.apache.org/r/38368/diff/
Testing
---
make check.
Thanks,
Kapil Arya
/r/38364/diff/
Testing
---
make check
Thanks,
Kapil Arya
/executor.cpp 6809e4ac0018f827db27e976164c549e3a0ff823
src/tests/containerizer/docker_containerizer_tests.cpp
a628922cc49b1dc8a37621a6a8b7ef6842cfb051
Diff: https://reviews.apache.org/r/38370/diff/
Testing
---
make check.
Thanks,
Kapil Arya
-------
On Sept. 16, 2015, 3:52 p.m., Kapil Arya wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38370/
> ---
and ran make check.
Thanks,
Kapil Arya
/
Testing
---
make check.
Thanks,
Kapil Arya
------
On Sept. 14, 2015, 4:55 p.m., Kapil Arya wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38363/
> ---
://reviews.apache.org/r/38364/diff/
Testing
---
make check
Thanks,
Kapil Arya
1b83a8725b35435531038e37188b4c97189cef03
src/tests/containerizer/isolator_tests.cpp
d34c82a7f24da6f60cfb22790f516dc6065b1f6f
Diff: https://reviews.apache.org/r/38365/diff/
Testing
---
make check
Thanks,
Kapil Arya
s.apache.org/r/38366/#review99051
---
On Sept. 14, 2015, 4:55 p.m., Kapil Arya wrote:
>
> ---
> This is an automatically generated e-mail. To reply, v
---
Added new tests and ran make check.
Thanks,
Kapil Arya
------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38367/#review98926
---
On Sept. 15, 2015, 5:06 p.m., Kapil Arya wrote:
>
> --
Kapil
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38367/#review98932
---
On Sept. 15, 2015, 5:06 p.m., Kapil Arya wrote:
>
>
/diff/
Testing
---
make check.
Thanks,
Kapil Arya
his up as well?
Fixed.
- Kapil
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38364/#review98938
---
On Sept. 15,
his is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38367/#review98936
-------
On Sept. 15, 2015, 5:06 p.m., Kapil Arya wrote:
>
> ---
> T
)
-
src/docker/executor.cpp 6647075b55e5a79264e3556bb906a1f26a2d673e
src/tests/containerizer/docker_containerizer_tests.cpp
a628922cc49b1dc8a37621a6a8b7ef6842cfb051
Diff: https://reviews.apache.org/r/38370/diff/
Testing
---
make check.
Thanks,
Kapil Arya
://reviews.apache.org/r/38364/diff/
Testing
---
make check
Thanks,
Kapil Arya
check
Thanks,
Kapil Arya
d34c82a7f24da6f60cfb22790f516dc6065b1f6f
src/tests/containerizer/launcher.hpp 6f020f94b042eef0e6a69ba8c26dfb697f3e81a3
Diff: https://reviews.apache.org/r/38363/diff/
Testing
---
make check.
Thanks,
Kapil Arya
src/tests/master_tests.cpp 8a6b98b9f59ead20f537eb60b5084feed069a5b1
src/tests/slave_tests.cpp 5c1a3d36a5f67629aef275eeae12956c524e8102
Diff: https://reviews.apache.org/r/38367/diff/
Testing
---
Added new tests and ran make check.
Thanks,
Kapil Arya
14, 2015, 4:55 p.m., Kapil Arya wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38366/
> ---
>
&g
ommon/http_tests.cpp bf8712b11339b409514ab86c1f32eaf7e9c9a2f1
Diff: https://reviews.apache.org/r/38366/diff/
Testing
---
make check
Thanks,
Kapil Arya
5e5522e1254a5ed6084de36782753f9aad2894c4
src/tests/common/http_tests.cpp bf8712b11339b409514ab86c1f32eaf7e9c9a2f1
src/tests/hook_tests.cpp deb4343089a30073e8f1f811731b075f7d968846
Diff: https://reviews.apache.org/r/38368/diff/
Testing
---
make check.
Thanks,
Kapil Arya
d34c82a7f24da6f60cfb22790f516dc6065b1f6f
Diff: https://reviews.apache.org/r/38365/diff/
Testing
---
make check
Thanks,
Kapil Arya
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37729/#review96214
---
Ship it!
Ship It!
- Kapil Arya
On Aug. 24, 2015, 5:09 p.m
)
https://reviews.apache.org/r/37669/#comment151333
s/version4/version5
- Kapil Arya
On Aug. 22, 2015, 2:10 a.m., haosdent huang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37669
17)
https://reviews.apache.org/r/37669/#comment151331
Since we are using just `std::min`, can't we simple use an `if` or `?:` to
avoid including this file. There were some concerns previously about the build
speed, etc.
- Kapil Arya
On Aug. 22, 2015, 2:10 a.m., haosdent huang wrote
` here as well?
- Kapil Arya
On Aug. 7, 2015, 11:08 a.m., haosdent huang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36819
/#comment150215
Indent by four spaces.
- Kapil Arya
On Aug. 13, 2015, 3:50 p.m., James DeFelice wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37443
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37443/#review95325
---
Ship it!
Ship It!
- Kapil Arya
On Aug. 13, 2015, 4:20 p.m
8153ce4826f94d5771c93d37c59fdc4991352e66
src/hook/manager.cpp 11e6b0a2c0df1d0d7039aaad94e1c6f0e5cc6bc2
src/slave/slave.cpp f181b1b23cec57a9cce6311127f733f17fbd87e4
Diff: https://reviews.apache.org/r/37228/diff/
Testing
---
make check.
Thanks,
Kapil Arya
f181b1b23cec57a9cce6311127f733f17fbd87e4
Diff: https://reviews.apache.org/r/37228/diff/
Testing
---
make check.
Thanks,
Kapil Arya
, 2015, 5:45 a.m.)
Review request for mesos, Bernd Mathiske, Kapil Arya, Marco Massenzio, and
Sebastien Pahl.
Bugs: MESOS-2337
https://issues.apache.org/jira/browse/MESOS-2337
Repository: mesos
Description
---
Let __init__.py getting installed to
$PREFIX/lib/pythonX.Y
/
Testing
---
make check with a couple of added checks that verify that the executor_id is
set in the incoming TaskStatus in Master as well as Scheduler.
Thanks,
Kapil Arya
/tests/scheduler_tests.cpp 98fc70bf43ba99b54064a236795c7e1269004b71
Diff: https://reviews.apache.org/r/37053/diff/
Testing
---
make check with a couple of added checks that verify that the executor_id is
set in the incoming TaskStatus in Master as well as Scheduler.
Thanks,
Kapil Arya
} file be
placed inside `include/mesos/master/` instead since the authorizer is only for
the master. Does it make sense to do that? If it does, then should we also move
src/authorize inside src/master?
- Kapil Arya
On Aug. 3, 2015, 5:47 a.m., Alexander Rojas wrote
(updated)
---
make check.
Thanks,
Kapil Arya
Diff: https://reviews.apache.org/r/37007/diff/
Testing
---
make check.
Thanks,
Kapil Arya
and taskId.
- Kapil
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37007/#review93827
---
On Aug. 1, 2015, 12:24 a.m., Kapil Arya wrote
f3b731542f9db4f966970ecb2bb96eb828350dea
Diff: https://reviews.apache.org/r/32587/diff/
Testing
---
make check
Also ran Nik's test-upgrade.py script (https://reviews.apache.org/r/31645) with
0.23.0 and the current master to verify compatibility checks.
Thanks,
Kapil Arya
f3b731542f9db4f966970ecb2bb96eb828350dea
Diff: https://reviews.apache.org/r/32587/diff/
Testing
---
make check
Also ran Nik's test-upgrade.py script (https://reviews.apache.org/r/31645) with
0.23.0 and the current master to verify compatibility checks.
Thanks,
Kapil Arya
/32587/#review93560
---
On July 30, 2015, 12:18 p.m., Kapil Arya wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32587
` declaration inside the `if`
block as well.
- Kapil Arya
On July 27, 2015, 9:25 p.m., Neil Conway wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36867
://reviews.apache.org/r/32587/diff/
Testing
---
make check
TODO: Test for upgrade path.
Thanks,
Kapil Arya
f3b731542f9db4f966970ecb2bb96eb828350dea
Diff: https://reviews.apache.org/r/32587/diff/
Testing (updated)
---
make check
Also ran Nik's test-upgrade.py script (https://reviews.apache.org/r/31645) with
0.23.0 and the current master to verify compatibility checks.
Thanks,
Kapil Arya
://reviews.apache.org/r/32587/diff/
Testing
---
make check
Also ran Nik's test-upgrade.py script (https://reviews.apache.org/r/31645) with
0.23.0 and the current master to verify compatibility checks.
Thanks,
Kapil Arya
51a4db17d13dd8dbff6a5eb2ceabee269275f6f6
src/tests/containerizer/port_mapping_tests.cpp
778dc8cdfee1fd4098a6332b9219764527cd7b59
Diff: https://reviews.apache.org/r/36831/diff/
Testing
---
make check.
Thanks,
Kapil Arya
51a4db17d13dd8dbff6a5eb2ceabee269275f6f6
src/tests/containerizer/port_mapping_tests.cpp
778dc8cdfee1fd4098a6332b9219764527cd7b59
Diff: https://reviews.apache.org/r/36831/diff/
Testing
---
make check.
Thanks,
Kapil Arya
59f08c0c175ea800ba23d85666d20b6a7b6d07d6
src/tests/containerizer/port_mapping_tests.cpp
45ef97a4822edacd2c2964e63ec624fe4190b3b9
Diff: https://reviews.apache.org/r/36831/diff/
Testing
---
make check.
Thanks,
Kapil Arya
,
Kapil Arya
Diff: https://reviews.apache.org/r/36755/diff/
Testing
---
make check with an added test.
Thanks,
Kapil Arya
59f08c0c175ea800ba23d85666d20b6a7b6d07d6
src/tests/containerizer/port_mapping_tests.cpp
45ef97a4822edacd2c2964e63ec624fe4190b3b9
Diff: https://reviews.apache.org/r/36831/diff/
Testing
---
make check.
Thanks,
Kapil Arya
labels? You can find the example in MasterTest.TaskLabels test in
master_tests.cpp.
- Kapil Arya
On July 27, 2015, 9:25 p.m., Neil Conway wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r
,
Kapil Arya
,
Kapil Arya
://reviews.apache.org/r/36755/diff/
Testing
---
make check with an added test.
Thanks,
Kapil Arya
a44b6e887c37e55213db068a95ab3e73a033e1ea
src/tests/containerizer/isolator_tests.cpp
59f08c0c175ea800ba23d85666d20b6a7b6d07d6
Diff: https://reviews.apache.org/r/36831/diff/
Testing
---
make check.
Thanks,
Kapil Arya
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36763/#review92933
---
Ship it!
Ship It!
- Kapil Arya
On July 24, 2015, 1:26 p.m., Jie
8aaf88c3ea8362950e363d15cbe2b598a12f12d6
src/tests/launcher.hpp 78216e0805eadb8eb425d9d58aae1b102a7817b5
Diff: https://reviews.apache.org/r/36799/diff/
Testing
---
make check
Thanks,
Kapil Arya
check with an added test.
Thanks,
Kapil Arya
/r/36754/diff/
Testing
---
make check with an added test (in the followup review).
Thanks,
Kapil Arya
.
Diffs
-
src/slave/containerizer/mesos/containerizer.cpp
609620c4322e41562597ee682b311cd320bca6d2
src/tests/containerizer_tests.cpp 88c46e7214f4d92b7d6a9b433a3a0497681dc6db
Diff: https://reviews.apache.org/r/36755/diff/
Testing
---
make check with an added test.
Thanks,
Kapil Arya
with an added test (in the followup review).
Thanks,
Kapil Arya
/containerizer.cpp
609620c4322e41562597ee682b311cd320bca6d2
src/tests/containerizer_tests.cpp 88c46e7214f4d92b7d6a9b433a3a0497681dc6db
src/tests/isolator.hpp fd6aec74edf49153d31b559d56e8e06c15836f68
Diff: https://reviews.apache.org/r/36718/diff/
Testing
---
make check
Thanks,
Kapil Arya
790e392645dd62e74b03ff0771f6bf0e9efeb622
src/slave/containerizer/mesos/containerizer.cpp
609620c4322e41562597ee682b311cd320bca6d2
Diff: https://reviews.apache.org/r/36718/diff/
Testing
---
make check
Thanks,
Kapil Arya
/slave_tests.cpp 89cc7f68b33b037626ca6056647c360b5a6d5901
Diff: https://reviews.apache.org/r/36574/diff/
Testing
---
make check
Thanks,
Kapil Arya
,
Kapil Arya
src/tests/docker_containerizer_tests.cpp
6c6f4b7f30cec9b5bba77234b714e96289c82b43
Diff: https://reviews.apache.org/r/36585/diff/
Testing
---
sudo make check
Thanks,
Kapil Arya
/manager.cpp 0108534c1fc527a0c66d201d7a5232e80b9928bf
src/slave/slave.cpp 2119b5176aa7cfb7b0b551d4d4f65ee12818b9e4
src/tests/hook_tests.cpp 09205fb89925c22b1157294a756db87d911a63db
Diff: https://reviews.apache.org/r/36580/diff/
Testing
---
make check with a new hook test.
Thanks,
Kapil
330a95b9a19353029f5b8215d5df735818626218
Diff: https://reviews.apache.org/r/36669/diff/
Testing
---
make check
Thanks,
Kapil Arya
://reviews.apache.org/r/36669/diff/
Testing
---
make check
Thanks,
Kapil Arya
8a4e2c2ecddf268e319b6d33da497fafa9f2fc61
src/tests/mesos.hpp f14b8f721e057efbd93dd38263c22b4b4e3881da
src/tests/slave_tests.cpp 330a95b9a19353029f5b8215d5df735818626218
Diff: https://reviews.apache.org/r/36667/diff/
Testing
---
make check
Thanks,
Kapil Arya
---
See summary
Diffs
-
src/tests/master_tests.cpp 8a4e2c2ecddf268e319b6d33da497fafa9f2fc61
src/tests/slave_tests.cpp 330a95b9a19353029f5b8215d5df735818626218
Diff: https://reviews.apache.org/r/36668/diff/
Testing
---
make check
Thanks,
Kapil Arya
of TaskInfo/TaskStatus
Labels.
2. There can be multiple hooks for label decoration, so we can't simply
return on `result.isSome()`. We need to accumulate all of those.
- Kapil Arya
On July 21, 2015, 12:46 p.m., Kapil Arya wrote
/diff/
Testing
---
make check with added tests.
Thanks,
Kapil Arya
---
make check with new tests to verify state.json output.
Thanks,
Kapil Arya
/
Testing
---
sudo make check
Thanks,
Kapil Arya
: https://reviews.apache.org/r/36580/diff/
Testing
---
make check with a new hook test.
Thanks,
Kapil Arya
/r/36574/diff/
Testing
---
make check
Thanks,
Kapil Arya
/3rdparty/stout/tests/jsonify_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/36596/diff/
Testing
---
make check with added tests.
Thanks,
Kapil Arya
---
On July 18, 2015, 8:38 p.m., Kapil Arya wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36585
601 - 700 of 759 matches
Mail list logo