t__.py
Lines 1 (patched)
<https://reviews.apache.org/r/58394/#comment246699>
I would exclude this from this commit.
It is not used anywhere, therefore it should not be included until the
commit where it is used.
- Kevin Klues
On April 12, 2017, 9:44 p.m., Eric
tps://reviews.apache.org/r/58720/#comment246698>
We should use the `.format` syntax here. Also, we should use `os.path.join`.
- Kevin Klues
On April 25, 2017, 10:18 p.m., Armand Grillet wrote:
>
> ---
> This is an automatica
that Eric Chung is doing to
provide a more sophisticated HTTP library for the CLI. But this should work for
now until that work lands.
- Kevin Klues
On April 25, 2017, 10:18 p.m., Armand Grillet wrote:
>
> ---
> This is an auto
)
<https://reviews.apache.org/r/58137/#comment246685>
You need to check that this file exists and raise an appropriate
CLIException if it does not.
- Kevin Klues
On April 12, 2017, 9:21 a.m., Armand Grillet
ch it can parse from the loaded modules from `PLUGIN_NAME` and `SHORT_HELP`
(edited)
[16:44]
or if there is an error with loading one of the plugins it can raise a
CLIExpection() with a meaningful error message
```
- Kevin Klues
On April 12, 2017, 9:19 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58818/#review173662
---
Ship it!
Ship It!
- Kevin Klues
On April 28, 2017, 4:14 p.m
l isolated
chunks if necessary.
- Kevin Klues
On April 6, 2017, 12:13 a.m., Eric Chung wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revi
(patched)
<https://reviews.apache.org/r/57952/#comment244060>
I would actually leverage the Table abstraction to print th eplugins here.
I think this might be a discarded RR from me that should probably be revived
for this.
- Kevin Klues
On March 27, 2017, noon, Armand Grillet
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57896/#review171179
---
Ship it!
Ship It!
- Kevin Klues
On March 27, 2017, 11:56
to @tillt
- Kevin Klues
On April 3, 2017, 7:32 p.m., Ayanampudi Varsha wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
the parsing of the
plugins array from the TOML file (which isn't in this commit at all yet). We
should move that functionality out of settings.py and into here.
- Kevin Klues
On March 27, 2017, noon, Armand Grillet wrote
apache.org/r/57951/#comment243031>
We should be more descriptive in the error message here:
```
"Unable to parse config file '{}': 'plugins' field must be a
list".format(MESOS_CLI_CONFIG_PATH)
```
> On March 27, 2017, 7:01 p.m., Kevin Klues wrote:
> > src/slave/flags.cpp
> > Lines 152-158 (original), 152-169 (patched)
> > <https://reviews.apache.org/r/55065/diff/1/?file=1592795#file1592795line152>
> >
> > We typically don't create
gs.cpp#L212
- Kevin Klues
On March 27, 2017, 9:25 a.m., Ayanampudi Varsha wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
Is the idea that
we could keep multiple configs in this directory and swap them out based on the
environment variable?
- Kevin Klues
On March 23, 2017, 11:05 p.m., Armand Grillet wrote:
>
> ---
> This is an automatically generated e-
/getting-started.md 268eb29551c6cd9cbea50b2c971f97ca74bab18f
docs/windows.md 38275f30638a0197b41f55b454b7a722bea24b3e
Diff: https://reviews.apache.org/r/57713/diff/3/
Changes: https://reviews.apache.org/r/57713/diff/2-3/
Testing
---
Thanks,
Kevin Klues
)
-
docs/getting-started.md 268eb29551c6cd9cbea50b2c971f97ca74bab18f
docs/windows.md 38275f30638a0197b41f55b454b7a722bea24b3e
Diff: https://reviews.apache.org/r/57713/diff/2/
Changes: https://reviews.apache.org/r/57713/diff/1-2/
Testing
---
Thanks,
Kevin Klues
: https://reviews.apache.org/r/57713/diff/1/
Testing
---
Thanks,
Kevin Klues
/diff/3/
Testing
---
Thanks,
Kevin Klues
is invariant?
Maybe I'm missing something.
- Kevin Klues
On March 14, 2017, 12:04 a.m., Jie Yu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
myself if so.
- Kevin Klues
On March 12, 2017, 11:41 p.m., Kevin Klues wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
/r/52943/diff/2/
Testing
---
Thanks,
Kevin Klues
/52944/diff/2/
Testing
---
Thanks,
Kevin Klues
myself if so.
- Kevin Klues
On March 12, 2017, 11:41 p.m., Kevin Klues wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
myself if so.
- Kevin Klues
On March 12, 2017, 11:41 p.m., Kevin Klues wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
together now. Now it
will error out telling you to deactivate your currnet virtualenv in order to
continue.
- Kevin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53074/#review153832
/r/52942/diff/2/
Testing
---
Thanks,
Kevin Klues
://reviews.apache.org/r/52939/diff/3/
Testing
---
Thanks,
Kevin Klues
)
-
support/mesos-style.py 3a5bec81950ccf8083cbd73577c49b2fb3b910f8
Diff: https://reviews.apache.org/r/53074/diff/2/
Changes: https://reviews.apache.org/r/53074/diff/1-2/
Testing
---
Thanks,
Kevin Klues
src/mesos-tests
...
[--] Global test environment tear-down
[==] 8 tests from 1 test case ran. (13227 ms total)
[ PASSED ] 8 tests.
```
Thanks,
Kevin Klues
://reviews.apache.org/r/57539/diff/1/
Testing
---
```
sudo rm -rf /dev/nvidia-uvm
make -j40 check
sudo GTEST_FILTER="*Nvidia*" src/mesos-tests
...
[--] Global test environment tear-down
[==] 8 tests from 1 test case ran. (13227 ms total)
[ PASSED ] 8 tests.
```
Thanks,
Kevin Klues
the DELETE_NESTED_CONTAINER
API call. Should we separate these into two separate patches?
- Kevin Klues
On March 7, 2017, 5:15 p.m., Gastón Kleiman wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
of this.
Can you fix the summary though -- s/photos/protos/
- Kevin Klues
On March 7, 2017, 5:14 p.m., Gastón Kleiman wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
ent240434>
ditto
- Kevin Klues
On March 7, 2017, 5:13 p.m., Gastón Kleiman wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
lt;https://reviews.apache.org/r/57384/#comment240430>
kill this newline
src/tests/containerizer/nested_mesos_containerizer_tests.cpp
Lines 2089 (patched)
<https://reviews.apache.org/r/57384/#comment240432>
Can you pull this wait out of the AWAIT_READY() call in order to be
consist
: https://reviews.apache.org/r/57176/diff/
Testing
---
GTEST_FILTER="" make -j check
src/mesos-tests
Thanks,
Kevin Klues
j check
sudo src/mesos-tests
```
Thanks,
Kevin Klues
/container_logger.hpp
a3f619b79ca0188df9e231c600dfa396f39ab29a
Diff: https://reviews.apache.org/r/57122/diff/
Testing
---
Thanks,
Kevin Klues
/57121/diff/
Testing
---
Thanks,
Kevin Klues
t:
https://reviews.apache.org/r/57121/#review167143
---
On Feb. 28, 2017, 5:09 a.m., Kevin Klues wrote:
>
> ---
> This is an automatically generated e
akubmarian.com/comma-after-i-e-and-e-g/
- Kevin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57118/#review167045
-------
-http-api.md 94a5477af60de0f9e8e79366fe93adb5299e470c
Diff: https://reviews.apache.org/r/57117/diff/
Testing
---
Thanks,
Kevin Klues
---
Thanks,
Kevin Klues
j check
sudo src/mesos-tests
```
Thanks,
Kevin Klues
/container_logger_tests.cpp 589d6a9df7ce964052355be41597ef11677ca03d
Diff: https://reviews.apache.org/r/57121/diff/
Testing
---
Thanks,
Kevin Klues
://issues.apache.org/jira/browse/MESOS-7188
Repository: mesos
Description
---
Added debugging APIs to agent API docs.
Diffs
-
docs/operator-http-api.md 94a5477af60de0f9e8e79366fe93adb5299e470c
Diff: https://reviews.apache.org/r/57118/diff/
Testing
---
Thanks,
Kevin Klues
/
Testing
---
Thanks,
Kevin Klues
make -j check
sudo src/mesos-tests
```
Thanks,
Kevin Klues
7a7ad2da047ef316f4382e45526d503c87a903a0
src/slave/containerizer/mesos/io/switchboard.cpp
b948f3c44dd2e1af2228ca1579f24ae3a94160b0
Diff: https://reviews.apache.org/r/56814/diff/
Testing
---
GTEST_FILTER="" make -j check
sudo src/mesos-tests
Thanks,
Kevin Klues
io/switchboard.hpp
7a7ad2da047ef316f4382e45526d503c87a903a0
src/slave/containerizer/mesos/io/switchboard.cpp
b948f3c44dd2e1af2228ca1579f24ae3a94160b0
Diff: https://reviews.apache.org/r/56195/diff/
Testing
---
Linux CentOS 7:
```
GTEST_FILTER="" make -j check
sudo src/mesos-tests
```
Thanks,
Kevin Klues
b948f3c44dd2e1af2228ca1579f24ae3a94160b0
Diff: https://reviews.apache.org/r/56814/diff/
Testing
---
GTEST_FILTER="" make -j check
sudo src/mesos-tests
Thanks,
Kevin Klues
ae3a94160b0
Diff: https://reviews.apache.org/r/56195/diff/
Testing (updated)
---
Linux CentOS 7:
```
GTEST_FILTER="" make -j check
sudo src/mesos-tests
```
Thanks,
Kevin Klues
n. (390804 ms total)
[ PASSED ] 1477 tests.
```
Mac OS X (El Capitan)
```
GTEST_FILTER="" make -j check
src/mesos-tests
[ FAILED ] 3 tests, listed below:
[ FAILED ] ExamplesTest.V1JavaFramework
[ FAILED ] ExamplesTest.PythonFramework
```
Thanks,
Kevin Klues
: https://reviews.apache.org/r/56195/diff/
Testing
---
Tests still pending. WIll update when complete.
Thanks,
Kevin Klues
complete.
Thanks,
Kevin Klues
/containerizer/mesos/containerizer.cpp
4f0a773676da45fa40ad1ad9cdfab2a19249247d
Diff: https://reviews.apache.org/r/56195/diff/
Testing
---
Tests still pending. WIll update when complete.
Thanks,
Kevin Klues
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55810/#review162684
---
On Jan. 24, 2017, 10:45 p.m., Kevin Klues wrote:
>
> -
on_failure
Thanks,
Kevin Klues
4b134f8420e1ef5cd139e0e4b8b08b1ff32e3a30
Diff: https://reviews.apache.org/r/55810/diff/
Testing
---
GTEST_FILTER="ContentType/AgentAPITest.LaunchNestedContainerSession/1"
src/mesos-tests --gtest_repeat=-1 --gtest_break_on_failure
Thanks,
Kevin Klues
k
sudo src/mesos-tests
Thanks,
Kevin Klues
che.org/r/55355/#comment232239>
It's probably worth mentioning here why we grab a reference to the accept
(i.e. so that we can discard it in `finalize()` so that they FD associated with
the socket doesn't get leaked).
- Kevin Klues
On Jan. 9, 2017, 8:35 p.m., Gre
> On Jan. 9, 2017, 8:24 p.m., Kevin Klues wrote:
> > What is the reason for this change? It seems much more intuitive for me to
> > have a simple build directive that we simply remove once of the rename is
> > complete, compared to a custom install-hook that creates a syml
for me to have
a simple build directive that we simply remove once of the rename is complete,
compared to a custom install-hook that creates a symlink.
- Kevin Klues
On Jan. 9, 2017, 8:02 p.m., James Peach wrote
going on
with your change (plus we lose the discarded case).
- Kevin Klues
On Dec. 17, 2016, 9:40 p.m., Benjamin Hindman wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
, but what values can be returned
to `ControlFlow`. I'm guessing `Break()`, `Continue()`, and `T`?
- Kevin Klues
On Dec. 17, 2016, 9:39 p.m., Benjamin Hindman wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
it the first time around when
implementing this? Should this be called "DEFAULT_BUFFERED_READ_SIZE"?
- Kevin Klues
On Dec. 17, 2016, 9:35 p.m., Benjamin Hindman wrote:
>
> ---
> This is an automatically generated e-mail. To re
/io_switchboard_tests.cpp
5bd9dc4a776fe8a0d04ed31aa167f10c394984e6
Diff: https://reviews.apache.org/r/54561/diff/
Testing (updated)
---
GTEST_FILTER="" make -j check
GTEST_FILTER="*IOSwitchboard*" src/mesos-tests
Thanks,
Kevin Klues
re
> any plan to fix these?
>
> Jie Yu wrote:
> Yes. I'll fix those. thanks!
Should this be closed now?
- Kevin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.o
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54731/#review159109
---
Ship it!
Ship It!
- Kevin Klues
On Dec. 14, 2016, 4:15 a.m
This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54720/
> ---
>
> (Updated Dec. 13, 2016, 10:20 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Kevin Klues.
>
>
> Repository: mesos
>
>
> Descripti
> On Dec. 14, 2016, 1:10 a.m., Kevin Klues wrote:
> > src/tests/containerizer/io_switchboard_tests.cpp, line 809
> > <https://reviews.apache.org/r/54720/diff/1/?file=1583056#file1583056line809>
> >
> > I think you need the new:
>
che.org/r/54720/#comment230040>
Wait until slvae recovered? Your future is on `slave::Slave::_recover`
- Kevin Klues
On Dec. 13, 2016, 10:20 p.m., Vinod Kone wrote:
>
> ---
> This is an automatically generated e-mail. To
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54727/#review159084
---
Ship it!
Ship It!
- Kevin Klues
On Dec. 14, 2016, 12:46 a.m
with a TTY client to make sure the window resized properly.
Thanks,
Kevin Klues
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54687/#review158945
---
Ship it!
Ship It!
- Kevin Klues
On Dec. 13, 2016, 1:10 a.m
/switchboard.hpp (lines 81 - 99)
<https://reviews.apache.org/r/54686/#comment229784>
Is there a reason not to put the implementation of this in the .cpp file?
Seems weird to have all other functions defined in the cpp file, but define
this one in the header.
- Kevin Klues
On Dec. 13, 2016,
to print all missing flags
at once though so that you don't have to run it mutliple times to catch all of
the missing flags. I think it's fine for now though.
- Kevin Klues
On Dec. 13, 2016, 12:11 a.m., Jie Yu wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54683/#review158930
---
Ship it!
Ship It!
- Kevin Klues
On Dec. 12, 2016, 11:43 p.m
to fix it once we add a
proper dependency check?
- Kevin Klues
On Dec. 12, 2016, 11:42 p.m., Jie Yu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
org/r/54681/#comment229768>
Given these new semantics, I would probably print the whole usage string
and list the exact set of flags that were missing.
As it is written now, it wouldn't be obvious that a flag was missing.
- Kevin Klues
On Dec. 12, 2016, 11:43 p.m., Jie Yu
everything passed).
- Kevin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54561/#review158899
---
On Dec. 12, 2016,
n the same process as the first.
GTEST_FILTER="*SendHeartbeat*" src/mesos-tests
GTEST_FILTER="*ReceiveHeartbeat*" src/mesos-tests
Thanks,
Kevin Klues
3c292bac9394347318865f49782907def6541742
src/slave/flags.cpp a5f5203320ba6657c0a1573447a8ee002172614b
Diff: https://reviews.apache.org/r/54630/diff/
Testing
---
GTEST_FILTER="" make -j 40 check
Thanks,
Kevin Klues
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54671/#review158896
---
Ship it!
Ship It!
- Kevin Klues
On Dec. 12, 2016, 7:21 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54673/#review158895
---
Ship it!
Ship It!
- Kevin Klues
On Dec. 12, 2016, 7:30 p.m
mesos-tests
Thanks,
Kevin Klues
the second test to fail if
run in the same process as the first.
GTEST_FILTER="*SendHeartbeat*" src/mesos-tests
GTEST_FILTER="*ReceiveHeartbeat*" src/mesos-tests
Thanks,
Kevin Klues
/54627/diff/
Testing
---
../configure --enable-ssl --enable-libevent
GTEST_FILTER="" make -j check
src/mesos-tests
sudo src/mesos-tests
../configure
GTEST_FILTER="" make -j check
src/mesos-tests
sudo src/mesos-tests
Thanks,
Kevin Klues
a354188a3656b5c2fd797b214f6c02714d70ce2c
src/tests/containerizer/io_switchboard_tests.cpp
ecadeee179fc2a22967b324928bfb11e140a6987
Diff: https://reviews.apache.org/r/54628/diff/
Testing
---
GTEST_FILTER-"" make -j check
GTEST_FILTER="*IOSwitchboard*" src/mesos-tests
Thanks,
Kevin Klues
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54637/#review158816
---
Ship it!
Do we know why the build failed?
- Kevin Klues
mesos-tests
sudo src/mesos-tests
Thanks,
Kevin Klues
EST_FILTER="*IOSwitchboard*" src/mesos-tests
Thanks,
Kevin Klues
> On Dec. 10, 2016, 10:36 p.m., Kevin Klues wrote:
> > src/slave/containerizer/mesos/io/switchboard.hpp, line 155
> > <https://reviews.apache.org/r/54620/diff/1/?file=1581300#file1581300line155>
> >
> > Shouldn't this be called `isEnabled()`. When I see `
74a6c9936b29d35a72d47a5b7e9939c3e49fc7b3
Diff: https://reviews.apache.org/r/54630/diff/
Testing
---
GTEST_FILTER="" make -j 40 check
Thanks,
Kevin Klues
---
Tests in subsequent patch. Because of a pending unix domain socket reconnect
bug, committing the tests and running them in the standard way would break the
build currently.
Thanks,
Kevin Klues
---
GTEST_FILTER="" make -j 40 check
Thanks,
Kevin Klues
: https://reviews.apache.org/r/54632/diff/
Testing (updated)
---
GTEST_FILTER="" make -j check
GTEST_FILTER="*AgentAPIStreamingTest.AttachInputToNestedContainerSession*"
src/mesos-tests
Thanks,
Kevin Klues
/diff/
Testing
---
GTEST_FILTER="" make -j check
GTEST_FILTER="AgentAPIStreamingTest.AttachInputToNestedContainerSession*"
src/mesos-tests
Thanks,
Kevin Klues
eviews.apache.org/r/54627/#review158778
---
On Dec. 10, 2016, 6:29 p.m., Kevin Klues wrote:
>
> ---
> This is an automatically generated e-mail. To re
che.org/r/54620/#comment229578>
Maybe this belongs in a separate patch, but we should only close stdinFd
here if we are not a pty.
- Kevin Klues
On Dec. 10, 2016, 5:08 a.m., Vinod Kone wrote:
>
> ---
> This is an automatic
201 - 300 of 1309 matches
Mail list logo
