Re: Review Request 72549: Added a workaround for `javah -d java/jni` race for creating `java/jni`.

2020-06-30 Thread Mesos Reviewbot
of rule is unportable src/Makefile.am:2173: error: '#' comment at start of rule is unportable src/Makefile.am:2174: error: '#' comment at start of rule is unportable src/Makefile.am:2175: error: '#' comment at start of rule is unportable src/Makefile.am:2176: error: '#' comment at start o

Re: Review Request 72547: Fixed missing protoc dependencies of compiled protobufs.

2020-07-01 Thread Mesos Reviewbot
ss/ make[4]: Leaving directory '/tmp/SRC/build/3rdparty/libprocess' make[3]: Leaving directory '/tmp/SRC/build/3rdparty/libprocess' make[2]: Leaving directory '/tmp/SRC/build/3rdparty' (cd src && make top_distdir=../mesos-1.11.0 distdir=../mesos-1.11.0/src

Re: Review Request 72654: Added documentation for the TEARDOWN master call.

2020-07-07 Thread Mesos Reviewbot
: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh - Mesos Revie

Re: Review Request 72661: Updated `CSIPluginInfo` for supporting 3rd party CSI plugins.

2020-07-08 Thread Mesos Reviewbot
command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh - Mesos Review

Re: Review Request 72661: Updated `CSIPluginInfo` for supporting 3rd party CSI plugins.

2020-07-09 Thread Mesos Reviewbot
command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh - Mesos Review

Re: Review Request 72661: Updated `CSIPluginInfo` for supporting 3rd party CSI plugins.

2020-07-09 Thread Mesos Reviewbot
command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh - Mesos Reviewb

Re: Review Request 72661: Updated `CSIPluginInfo` for supporting 3rd party CSI plugins.

2020-07-12 Thread Mesos Reviewbot
command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh - Mesos Reviewb

Re: Review Request 72672: Introduced a new agent flag `--csi_plugin_config_dir`.

2020-07-13 Thread Mesos Reviewbot
] Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh - Mesos Reviewb

Re: Review Request 72672: Introduced a new agent flag `--csi_plugin_config_dir`.

2020-07-14 Thread Mesos Reviewbot
] Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh - Mesos Reviewb

Re: Review Request 72448: Fixed operator api event inconsistencies issue.

2020-07-14 Thread Mesos Reviewbot
: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh - Mesos Revie

Re: Review Request 72672: Introduced a new agent flag `--csi_plugin_config_dir`.

2020-07-15 Thread Mesos Reviewbot
] Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh - Mesos Reviewb

Re: Review Request 72683: Improved CSI service manager to support unmanaged CSI plugins.

2020-07-15 Thread Mesos Reviewbot
] Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh - Mesos R

Re: Review Request 72683: Improved CSI service manager to support unmanaged CSI plugins.

2020-07-15 Thread Mesos Reviewbot
; ../3rdparty/protobuf-3.5.0/src/protoc -I../../include -I../../src -I../3rdparty/csi-0.2.0 -I../3rdparty/csi-1.1.0 -I../3rdparty/protobuf-3.5.0/src --cpp_out=. ../../src/tests/common/http_tests.proto /bin/bash: ../3rdparty/protobuf-3.5.0/src/protoc: No such file or directory Makefile:15588: re

Re: Review Request 72681: Enabled pre-provisioned volumes in the volume manager.

2020-07-16 Thread Mesos Reviewbot
: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh - Mesos Rev

Re: Review Request 72690: Implemented the framework and `create` method of "volume/csi" isolator.

2020-07-17 Thread Mesos Reviewbot
/mesos-1.11.0/src \ am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir) make[2]: Entering directory '/tmp/SRC/build/src' ../3rdparty/protobuf-3.5.0/src/protoc -I../../include -I../../src -I../3rdparty/csi-0.2.0 -I../3rdparty/csi-1.1.0 -I../3rdparty/pr

Re: Review Request 72681: Enabled pre-provisioned volumes in the volume manager.

2020-07-17 Thread Mesos Reviewbot
: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh - Mesos Reviewb

Re: Review Request 72690: Implemented the framework and `create` method of "volume/csi" isolator.

2020-07-20 Thread Mesos Reviewbot
, 72690] Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh

Re: Review Request 72690: Implemented the framework and `create` method of "volume/csi" isolator.

2020-07-20 Thread Mesos Reviewbot
, 72690] Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.

Re: Review Request 72681: Enabled pre-provisioned volumes in the volume manager.

2020-07-21 Thread Mesos Reviewbot
: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh - Mesos Review

Re: Review Request 72690: Implemented the framework and `create` method of "volume/csi" isolator.

2020-07-22 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72690/#review221308 --- Bad patch! Reviews applied: [72660, 72661, 72672, 72683, 72690]

Re: Review Request 72448: Fixed operator api event inconsistencies issue.

2020-07-23 Thread Mesos Reviewbot
: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh - Mesos Revie

Re: Review Request 72690: Implemented the framework and `create` method of "volume/csi" isolator.

2020-07-23 Thread Mesos Reviewbot
, 72690] Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.

Re: Review Request 72707: Added interface for the CSI server.

2020-07-24 Thread Mesos Reviewbot
command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh - Mesos Rev

Re: Review Request 72600: Remove credential text format support.

2020-07-24 Thread Mesos Reviewbot
command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh - Mesos Revie

Re: Review Request 72707: Added interface for the CSI server.

2020-07-26 Thread Mesos Reviewbot
/mesos-1.11.0/src \ am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir) make[2]: Entering directory '/tmp/SRC/build/src' ../3rdparty/protobuf-3.5.0/src/protoc -I../../include -I../../src -I../3rdparty/csi-0.2.0 -I../3rdparty/csi-1.1.0 -I../3rdparty/p

Re: Review Request 72709: Fixed the tests warning messages.

2020-07-27 Thread Mesos Reviewbot
: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh - Mesos Revie

Re: Review Request 72716: Added implementation of the CSI server.

2020-07-28 Thread Mesos Reviewbot
, 72715, 72707, 72716] Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins

Re: Review Request 72728: Added a unit test for the CSI server.

2020-07-31 Thread Mesos Reviewbot
, 72715, 72707, 72716, 72726, 72727, 72728] Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOS

Re: Review Request 72728: Added a unit test for the CSI server.

2020-08-03 Thread Mesos Reviewbot
, 72715, 72707, 72716, 72726, 72727, 72728] Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOS

Re: Review Request 72690: Implemented the framework and `create` method of `volume/csi` isolator.

2020-08-03 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72690/#review221456 --- Bad patch! Reviews applied: [72660, 72661, 72672, 72683, 72690]

Re: Review Request 72732: Added support for secrets to the CSI server and volume manager.

2020-08-03 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72732/#review221457 --- Bad patch! Reviews applied: [72660, 72661, 72672, 72681, 72715, 7

Re: Review Request 72709: Fixed the tests warning messages.

2020-08-04 Thread Mesos Reviewbot
: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh - Mesos Revie

Re: Review Request 72733: Implemented the `prepare` method of `volume/csi` isolator.

2020-08-04 Thread Mesos Reviewbot
, 72715, 72707, 72716, 72690, 72733] Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./s

Re: Review Request 72732: Added support for secrets to the CSI server and volume manager.

2020-08-04 Thread Mesos Reviewbot
, 72715, 72707, 72716, 72726, 72727, 72728, 72732] Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOS

Re: Review Request 72733: Implemented the `prepare` method of `volume/csi` isolator.

2020-08-05 Thread Mesos Reviewbot
.11.0 distdir=../mesos-1.11.0/src \ am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir) make[2]: Entering directory '/tmp/SRC/build/src' ../3rdparty/protobuf-3.5.0/src/protoc -I../../include -I../../src -I../3rdparty/csi-0.2.0 -I../3rdparty/csi-1.1.0 -I../3rdparty/p

Re: Review Request 72734: Implemented the `cleanup` method of `volume/csi` isolator.

2020-08-05 Thread Mesos Reviewbot
, 72715, 72707, 72716, 72690, 72733, 72734] Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOS

Re: Review Request 72734: Implemented the `cleanup` method of `volume/csi` isolator.

2020-08-06 Thread Mesos Reviewbot
, 72715, 72707, 72716, 72690, 72733, 72734] Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOS

Re: Review Request 72742: Added basic tests for the offer constraints filter.

2020-08-06 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72742/#review221486 --- Bad patch! Reviews applied: [72738, 72739, 72740, 72741, 72742]

Re: Review Request 72734: Implemented the `cleanup` method of `volume/csi` isolator.

2020-08-06 Thread Mesos Reviewbot
rs/volume/csi/isolator.hpp: patch does not apply - Mesos Reviewbot On Aug. 5, 2020, 9:20 a.m., Qian Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://r

Re: Review Request 72732: Added support for secrets to the CSI volume managers.

2020-08-07 Thread Mesos Reviewbot
d/3rdparty' (cd src && make top_distdir=../mesos-1.11.0 distdir=../mesos-1.11.0/src \ am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir) make[2]: Entering directory '/tmp/SRC/build/src' ../3rdparty/protobuf-3.5.0/src/protoc -I../../include -I../../src -I../3rdparty/csi

Re: Review Request 72734: Implemented the `cleanup` method of `volume/csi` isolator.

2020-08-07 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72734/#review221500 --- Bad patch! Reviews applied: [72660, 72661, 72672, 72681, 72715, 7

Re: Review Request 72734: Implemented the `cleanup` method of `volume/csi` isolator.

2020-08-08 Thread Mesos Reviewbot
rs/volume/csi/isolator.cpp: patch does not apply - Mesos Reviewbot On Aug. 8, 2020, 3:18 p.m., Qian Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://r

Re: Review Request 72754: Enabled the `volume/csi` isolator in `MesosContainerizer`.

2020-08-09 Thread Mesos Reviewbot
sos/isolators/volume/csi/isolator.cpp: patch does not apply - Mesos Reviewbot On Aug. 10, 2020, 9:45 a.m., Qian Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://r

Re: Review Request 72754: Enabled the `volume/csi` isolator in `MesosContainerizer`.

2020-08-09 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72754/#review221518 --- Bad patch! Reviews applied: [72660, 72661, 72672, 72681, 72715, 7

Re: Review Request 72754: Enabled the `volume/csi` isolator in `MesosContainerizer`.

2020-08-10 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72754/#review221532 --- Bad patch! Reviews applied: [72660, 72661, 72672, 72681, 72715, 7

Re: Review Request 72728: Added a unit test for the CSI server.

2020-08-10 Thread Mesos Reviewbot
../3rdparty/csi-1.1.0 -I../3rdparty/protobuf-3.5.0/src --cpp_out=. ../../src/tests/common/http_tests.proto /bin/bash: ../3rdparty/protobuf-3.5.0/src/protoc: No such file or directory Makefile:15608: recipe for target 'tests/common/http_tests.pb.cc' failed make[2]: *** [tests/common/http_t

Re: Review Request 72754: Enabled the `volume/csi` isolator in `MesosContainerizer`.

2020-08-11 Thread Mesos Reviewbot
, 72734, 72753, 72754] Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins

Re: Review Request 72728: Added a unit test for the CSI server.

2020-08-11 Thread Mesos Reviewbot
, 72728] Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.

Re: Review Request 72759: Improved CSI service manager to set node ID for managed CSI plugins.

2020-08-12 Thread Mesos Reviewbot
: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh - Mesos Reviewbo

Re: Review Request 72728: Added a unit test for the CSI server.

2020-08-12 Thread Mesos Reviewbot
OS_VERBOSE=1'; ./support/jenkins/buildbot.sh - Mesos Reviewbot On Aug. 12, 2020, 7:21 p.m., Greg Mann wrote: > > --- > This is an automatically generated e-

Re: Review Request 72728: Added a unit test for the CSI server.

2020-08-13 Thread Mesos Reviewbot
, 72734, 72753, 72754, 72726, 72727, 72761, 72728] Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOS

Re: Review Request 72770: Updated the help message of the agent flag `--csi_plugin_config_dir`.

2020-08-13 Thread Mesos Reviewbot
: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh - Mesos Reviewb

Re: Review Request 72742: Added basic tests for the offer constraints filter.

2020-08-13 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72742/#review221572 --- Bad patch! Reviews applied: [72771, 72738, 72739, 72740, 72741, 7

Re: Review Request 72776: Added basic tests for offer constraints on a string attribute equality.

2020-08-14 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72776/#review221590 --- Bad patch! Reviews applied: [72771, 72738, 72739, 72741, 72742, 7

Re: Review Request 72779: Initialized plugins lazily in the CSI server.

2020-08-15 Thread Mesos Reviewbot
OS_VERBOSE=1'; ./support/jenkins/buildbot.sh - Mesos Reviewbot On Aug. 15, 2020, 3:54 p.m., Greg Mann wrote: > > --- > This is an automatically generated e-

Re: Review Request 72781: Updated volume manager to support user specified target path root.

2020-08-17 Thread Mesos Reviewbot
: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh - Mesos Reviewbo

Re: Review Request 72787: Added basic tests for regexp-based constraints.

2020-08-17 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72787/#review221605 --- Bad patch! Reviews applied: [72771, 72738, 72739, 72741, 72742, 7

Re: Review Request 72779: Initialized plugins lazily in the CSI server.

2020-08-17 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72779/#review221612 --- Bad patch! Reviews applied: [72732, 72716, 72690, 72733, 72734, 7

Re: Review Request 72779: Initialized plugins lazily in the CSI server.

2020-08-17 Thread Mesos Reviewbot
, 72754, 72753, 72734, 72733, 72690, 72716, 72732] Error: 2020-08-18 06:44:21 URL:https://reviews.apache.org/r/72779/diff/raw/ [9841/9841] -> "72779.patch" [1] error: patch failed: src/slave/csi_server.cpp:236 error: src/slave/csi_server.cpp: patch does not apply - Mesos Reviewbot

Re: Review Request 72779: Initialized plugins lazily in the CSI server.

2020-08-18 Thread Mesos Reviewbot
, 72754, 72753, 72734, 72733, 72690, 72716, 72732] Error: 2020-08-18 08:36:49 URL:https://reviews.apache.org/r/72779/diff/raw/ [9841/9841] -> "72779.patch" [1] error: patch failed: src/slave/csi_server.cpp:236 error: src/slave/csi_server.cpp: patch does not apply - Mesos Reviewbot

Re: Review Request 72787: Added basic tests for regexp-based constraints.

2020-08-18 Thread Mesos Reviewbot
r: src/master/allocator/mesos/offer_constraints_filter.cpp: patch does not apply - Mesos Reviewbot On Aug. 17, 2020, 8:24 p.m., Andrei Sekretenko wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > htt

Re: Review Request 72759: Exposed Mesos agent ID to managed CSI plugins.

2020-08-18 Thread Mesos Reviewbot
/mesos-1.11.0/src \ am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir) make[2]: Entering directory '/tmp/SRC/build/src' ../3rdparty/protobuf-3.5.0/src/protoc -I../../include -I../../src -I../3rdparty/csi-0.2.0 -I../3rdparty/csi-1.1.0 -I../3rdparty/pr

Re: Review Request 72787: Added basic tests for regexp-based constraints.

2020-08-18 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72787/#review221630 --- Bad patch! Reviews applied: [72771, 72738, 72739, 72741, 72742, 7

Re: Review Request 72779: Initialized plugins lazily in the CSI server.

2020-08-19 Thread Mesos Reviewbot
OS_VERBOSE=1'; ./support/jenkins/buildbot.sh - Mesos Reviewbot On Aug. 19, 2020, 6:23 a.m., Greg Mann wrote: > > --- > This is an automatically generated e-

Re: Review Request 72787: Added basic tests for regexp-based constraints.

2020-08-19 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72787/#review221639 --- Bad patch! Reviews applied: [72771, 72738, 72739, 72741, 72742, 7

Re: Review Request 72787: Added basic tests for regexp-based constraints.

2020-08-19 Thread Mesos Reviewbot
SRC/build/3rdparty' (cd src && make top_distdir=../mesos-1.11.0 distdir=../mesos-1.11.0/src \ am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir) make[2]: Entering directory '/tmp/SRC/build/src' ../3rdparty/protobuf-3.5.0/src/protoc -I../../inclu

Re: Review Request 72787: Added basic tests for regexp-based constraints.

2020-08-19 Thread Mesos Reviewbot
d/3rdparty' (cd src && make top_distdir=../mesos-1.11.0 distdir=../mesos-1.11.0/src \ am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir) make[2]: Entering directory '/tmp/SRC/build/src' ../3rdparty/protobuf-3.5.0/src/protoc -I../../include -I../../src -I../3r

Re: Review Request 72779: Initialized plugins lazily in the CSI server.

2020-08-19 Thread Mesos Reviewbot
OS_VERBOSE=1'; ./support/jenkins/buildbot.sh - Mesos Reviewbot On Aug. 19, 2020, 7:04 p.m., Greg Mann wrote: > > --- > This is an automatically generated e-

Re: Review Request 72787: Added basic tests for regexp-based constraints.

2020-08-19 Thread Mesos Reviewbot
d/3rdparty' (cd src && make top_distdir=../mesos-1.11.0 distdir=../mesos-1.11.0/src \ am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir) make[2]: Entering directory '/tmp/SRC/build/src' ../3rdparty/protobuf-3.5.0/src/protoc -I../../include -I../../src -I../3rdparty/csi-0.2.0 -I../3rdparty/csi-

Re: Review Request 72787: Added basic tests for regexp-based constraints.

2020-08-20 Thread Mesos Reviewbot
d/3rdparty' (cd src && make top_distdir=../mesos-1.11.0 distdir=../mesos-1.11.0/src \ am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir) make[2]: Entering directory '/tmp/SRC/build/src' ../3rdparty/protobuf-3.5.0/src/protoc -I../../include -I../../src

Re: Review Request 72788: Added a work around in v1 volume manager for Portworx CSI plugin.

2020-08-20 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72788/#review221660 --- Bad patch! Reviews applied: [72788] Failed command: ['bash', '-c

Re: Review Request 72789: Checkpointed CSI volume state in stringified JSON.

2020-08-20 Thread Mesos Reviewbot
de_fix=: distdir) make[2]: Entering directory '/tmp/SRC/build/src' ../3rdparty/protobuf-3.5.0/src/protoc -I../../include -I../../src -I../3rdparty/csi-0.2.0 -I../3rdparty/csi-1.1.0 -I../3rdparty/protobuf-3.5.0/src --cpp_out=. ../../src/tests/common/http_tests.proto /bin/bash: ../3rdparty/protobuf-3.5.0/src/protoc:

Re: Review Request 72787: Added basic tests for regexp-based constraints.

2020-08-20 Thread Mesos Reviewbot
7; ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh - Mesos Reviewbot On Aug. 19, 2020, 12:09 p.m., Andrei Sekretenko wrote: > > --- > This is an automatically generated e-

Re: Review Request 72794: Added a test for discarding image pull on discard of getting image.

2020-08-20 Thread Mesos Reviewbot
, 72794] Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.

Re: Review Request 72779: Initialized plugins lazily in the CSI server.

2020-08-20 Thread Mesos Reviewbot
e. Run git config --global user.email "y...@example.com" git config --global user.name "Your Name" to set your account's default identity. Omit --global to set the identity only in this repository. fatal: empty ident name (for ) not allowed Full log: https://ci-builds.ap

Re: Review Request 72727: Updated the test CSI plugin for CSI server testing.

2020-08-21 Thread Mesos Reviewbot
, 72734, 72753, 72754, 72726, 72727] Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./s

Re: Review Request 72779: Initialized plugins lazily in the CSI server.

2020-08-21 Thread Mesos Reviewbot
git config --global user.email "y...@example.com" git config --global user.name "Your Name" to set your account's default identity. Omit --global to set the identity only in this repository. fatal: empty ident name (for ) not allowed Full log: https://ci-builds.apache.org/

Re: Review Request 72788: Introduced the `CSIPluginInfo.target_path_exists` field.

2020-08-21 Thread Mesos Reviewbot
g --global user.name "Your Name" to set your account's default identity. Omit --global to set the identity only in this repository. fatal: empty ident name (for ) not allowed Full log: https://ci-builds.apache.org/job/Mesos/job/Mesos-Reviewbot-Linux/15/console - Mesos Reviewbot

Re: Review Request 72728: Added unit tests for the CSI server.

2020-08-21 Thread Mesos Reviewbot
g --global user.email "y...@example.com" git config --global user.name "Your Name" to set your account's default identity. Omit --global to set the identity only in this repository. fatal: empty ident name (for ) not allowed Full log: https://ci-builds.apache.org/

Re: Review Request 72789: Read the checkpointed CSI volume state directly in protobuf message way.

2020-08-23 Thread Mesos Reviewbot
g --global user.name "Your Name" to set your account's default identity. Omit --global to set the identity only in this repository. fatal: empty ident name (for ) not allowed Full log: https://ci-builds.apache.org/job/Mesos/job/Mesos-Reviewbot-Linux/63/console - Mesos Reviewbot

Re: Review Request 72785: Introduced a weak_ptr-based cache abstraction.

2020-08-24 Thread Mesos Reviewbot
g: https://ci-builds.apache.org/job/Mesos/job/Mesos-Reviewbot-Linux/88/console - Mesos Reviewbot On Aug. 17, 2020, 8:20 p.m., Andrei Sekretenko wrote: > > --- > This is an automatically generated e-mail

Re: Review Request 72787: Added basic tests for regexp-based constraints.

2020-08-24 Thread Mesos Reviewbot
l log: https://ci-builds.apache.org/job/Mesos/job/Mesos-Reviewbot-Linux/89/console - Mesos Reviewbot On Aug. 19, 2020, 12:09 p.m., Andrei Sekretenko wrote: > > --- > This is an automatically generated e-mail

Re: Review Request 72728: Added unit tests for the CSI server.

2020-08-24 Thread Mesos Reviewbot
g --global user.email "y...@example.com" git config --global user.name "Your Name" to set your account's default identity. Omit --global to set the identity only in this repository. fatal: empty ident name (for ) not allowed Full log: https://ci-builds.apache.org/

Re: Review Request 72785: Introduced a weak_ptr-based cache abstraction.

2020-08-25 Thread Mesos Reviewbot
g --global user.name "Your Name" to set your account's default identity. Omit --global to set the identity only in this repository. fatal: empty ident name (for ) not allowed Full log: https://ci-builds.apache.org/job/Mesos/job/Mesos-Reviewbot-Linux/102/console - Mesos Reviewbot

Re: Review Request 72787: Added basic tests for regexp-based constraints.

2020-08-25 Thread Mesos Reviewbot
d Full log: https://ci-builds.apache.org/job/Mesos/job/Mesos-Reviewbot-Linux/109/console - Mesos Reviewbot On Aug. 19, 2020, 12:09 p.m., Andrei Sekretenko wrote: > > --- > This is an automatically generated e-mail

Re: Review Request 72804: Supported chown CSI volumes in the `volume/csi` isolator.

2020-08-25 Thread Mesos Reviewbot
config --global user.name "Your Name" to set your account's default identity. Omit --global to set the identity only in this repository. fatal: empty ident name (for ) not allowed Full log: https://ci-builds.apache.org/job/Mesos/job/Mesos-Reviewbot-Linux/116/console - Mesos Revie

Re: Review Request 72728: Added tests for the 'volume/csi' isolator.

2020-08-26 Thread Mesos Reviewbot
git config --global user.email "y...@example.com" git config --global user.name "Your Name" to set your account's default identity. Omit --global to set the identity only in this repository. fatal: empty ident name (for ) not allowed Full log: https://ci-builds.apac

Re: Review Request 72787: Added basic tests for regexp-based constraints.

2020-08-26 Thread Mesos Reviewbot
d Full log: https://ci-builds.apache.org/job/Mesos/job/Mesos-Reviewbot-Linux/125/console - Mesos Reviewbot On Aug. 19, 2020, 12:09 p.m., Andrei Sekretenko wrote: > > --- > This is an automatically generated e-mail

Re: Review Request 72728: Added tests for the 'volume/csi' isolator.

2020-08-26 Thread Mesos Reviewbot
git config --global user.email "y...@example.com" git config --global user.name "Your Name" to set your account's default identity. Omit --global to set the identity only in this repository. fatal: empty ident name (for ) not allowed Full log: https://ci-builds.apac

Re: Review Request 72806: Added a test for 'volume/csi' isolator recovery.

2020-08-26 Thread Mesos Reviewbot
e. Run git config --global user.email "y...@example.com" git config --global user.name "Your Name" to set your account's default identity. Omit --global to set the identity only in this repository. fatal: empty ident name (for ) not allowed Full log: https://ci-builds.apac

Re: Review Request 72787: Added basic tests for regexp-based constraints.

2020-08-27 Thread Mesos Reviewbot
d Full log: https://ci-builds.apache.org/job/Mesos/job/Mesos-Reviewbot-Linux/150/console - Mesos Reviewbot On Aug. 19, 2020, 12:09 p.m., Andrei Sekretenko wrote: > > --- > This is an automatically generated e-mail

Re: Review Request 72806: Added a test for 'volume/csi' isolator recovery.

2020-09-01 Thread Mesos Reviewbot
, 72806] Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.s

Re: Review Request 72825: Added a test of UPDATE_FRAMEWORK with the same FrameworkInfo.

2020-09-01 Thread Mesos Reviewbot
_out=. ../../src/tests/common/http_tests.proto /bin/bash: ../3rdparty/protobuf-3.5.0/src/protoc: No such file or directory Makefile:15705: recipe for target 'tests/common/http_tests.pb.cc' failed make[2]: *** [tests/common/http_tests.pb.cc] Error 127 make[2]: Leaving directory '/tmp/SRC/b

Re: Review Request 72829: Moved the `volume/csi` isolator's root dir under work dir.

2020-09-01 Thread Mesos Reviewbot
: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh - Mesos Reviewb

Re: Review Request 72825: Added a test of UPDATE_FRAMEWORK with the same FrameworkInfo.

2020-09-01 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72825/#review221772 --- Bad patch! Reviews applied: [72826, 72823, 72822, 72833, 72824, 7

Re: Review Request 72832: Avoided unnecessary [] map operators in the master.

2020-09-01 Thread Mesos Reviewbot
: Circular dependency detected for review 72830.Please fix the 'depends_on' field. - Mesos Reviewbot On Sept. 1, 2020, 7:50 p.m., Benjamin Mahler wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 72842: Exposed framework offer constraints via the GET_FRAMEWORKS call.

2020-09-08 Thread Mesos Reviewbot
, 72842] Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.

Re: Review Request 72843: Fixed a stale comment about delayed permissions when batching requests.

2020-09-09 Thread Mesos Reviewbot
: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh - Mesos Reviewbot On

Re: Review Request 72830: Added a regression test for MESOS-9609.

2020-09-09 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72830/#review221826 --- Bad patch! Reviews applied: [72831, 72832, 72830] Failed command

Re: Review Request 72845: Added doc for the `volume/csi` isolator.

2020-09-09 Thread Mesos Reviewbot
: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh - Mesos Reviewb

<    1   2   3   4   5   6   7   8   9   10   >