Review Request 43587: Replaced use of *_MESSAGE macros with *_PROTOBUF equivalents.

--- This change involves changing existing macro invocations in testing code, so no additional testing was performed. Thanks, Michael Browning

Review Request 45046: Created URI.filename to name fetched files in sandbox where appropriate.

directly from the specified URI, and the with-cache path, where it copies it from the cache. In both cases, we verify that the file is saved to the sandbox directory with the name specified by the "filename" field in the CommandInfo.URI proto. Thanks, Michael Browning

Re: Review Request 45046: Created URI.filename to name fetched files in sandbox where appropriate.

uot; field in the CommandInfo.URI proto. Thanks, Michael Browning

Re: Review Request 45046: Created URI.filename to name fetched files in sandbox where appropriate.

-- On March 18, 2016, 11:30 p.m., Michael Browning wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45046/ > ---

Re: Review Request 45046: Created URI.filename to name fetched files in sandbox where appropriate.

saved to the sandbox directory with the name specified by the "filename" field in the CommandInfo.URI proto. Thanks, Michael Browning

Re: Review Request 45046: Created URI.filename to name fetched files in sandbox where appropriate.

directly from the specified URI, and the with-cache path, where it copies it from the cache. In both cases, we verify that the file is saved to the sandbox directory with the name specified by the "filename" field in the CommandInfo.URI proto. Thanks, Michael Browning

Re: Review Request 45046: Created URI.filename to name fetched files in sandbox where appropriate.

, we verify that the file is saved to the sandbox directory with the name specified by the "filename" field in the CommandInfo.URI proto. Thanks, Michael Browning

Re: Review Request 45046: Created URI.filename to name fetched files in sandbox where appropriate.

n issue for that? - Michael --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45046/#review124456 --- On March 19, 2016,

Review Request 45461: Create tempfiles in test temporary directory.

was performed. Thanks, Michael Browning

Re: Review Request 46168: Add subdirectory support to URI.filename field.

s rejected. In fetcher_cache_tests.cpp, CachedCustomFilenameWithSubdirectory tests that the same behavior holds when the URI is fetched from the cache. Thanks, Michael Browning

Re: Review Request 46168: Add subdirectory support to URI.filename field.

. In fetcher_cache_tests.cpp, CachedCustomFilenameWithSubdirectory tests that the same behavior holds when the URI is fetched from the cache. Thanks, Michael Browning

Review Request 46717: Added sketch of fetcher cache metrics.

/slave/metrics.cpp 86eb8db644227cb593e52305bfbd05444bb87a6e src/slave/slave.hpp 57b18882e30e44dcc40449b0e3be8ee970c45bc8 Diff: https://reviews.apache.org/r/46717/diff/ Testing --- Thanks, Michael Browning

Re: Review Request 46168: Add subdirectory support to URI.filename field.

in the sandbox, and AbsoluteCustomSubdirectoryFails tests that a custom filename with an absolute path is rejected. In fetcher_cache_tests.cpp, CachedCustomFilenameWithSubdirectory tests that the same behavior holds when the URI is fetched from the cache. Thanks, Michael Browning

Re: Review Request 46168: Add subdirectory support to URI.filename field.

f/1/?file=1343102#file1343102line150> > > > > What does this check against? > > > > Path(filename).basename() never returns an Error(). Ah, got it confused with Fetcher::basename, which can return an Error. - Michael ---------

Re: Review Request 46168: Add subdirectory support to URI.filename field.

he sandbox, and AbsoluteCustomSubdirectoryFails tests that a custom filename with an absolute path is rejected. In fetcher_cache_tests.cpp, CachedCustomFilenameWithSubdirectory tests that the same behavior holds when the URI is fetched from the cache. Thanks, Michael Browning

Review Request 46168: Add subdirectory support to URI.filename field.

_tests.cpp, CachedCustomFilenameWithSubdirectory tests that the same behavior holds when the URI is fetched from the cache. Thanks, Michael Browning

Re: Review Request 46168: Add subdirectory support to URI.filename field.

s rejected. In fetcher_cache_tests.cpp, CachedCustomFilenameWithSubdirectory tests that the same behavior holds when the URI is fetched from the cache. Thanks, Michael Browning