is use case of passing a temporary, we cannot delete
the rvalue reference ctor.
- Michael
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68813/#review208927
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68820/#review208988
---
Ship it!
Ship It!
- Michael Park
On Sept. 23, 2018, 12:32
> On July 20, 2018, 2:29 p.m., Michael Park wrote:
> > Looks good!
> >
> > It might be worth considering using the `OStreamWrapper` stuff for the
> > `ostream` API.
> > I know writing to `StringBuffer` is faster than writing to
> > `OStrea
---
>
> (Updated July 19, 2018, 8:38 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Benno Evers, and Michael Park.
>
>
> Bugs: MESOS-9092
> https://issues.apache.org/jira/browse/MESOS-9092
>
>
> Repository: mesos
>
>
&
` in the
end anyway.
3rdparty/stout/include/stout/jsonify.hpp
Line 137 (original), 95 (patched)
<https://reviews.apache.org/r/67988/#comment289186>
Looks like `GetString` returns a `const char*`. We should provide the
length here: `{buffer.GetString(), buffer.GetSize()}`.
- Michae
), 352-377 (patched)
<https://reviews.apache.org/r/67861/#comment288785>
While we're here, we could also replace these with the pointer versions of
`boost::get`. We might get some better performance: https://godbolt.org/g/B84cLb
- Michael Park
On July 9, 2018, 6:40 p.m., Benjamin Mahler
(patched)
<https://reviews.apache.org/r/67861/#comment288784>
Perhaps leave a small comment + a pointer to
https://github.com/kazuho/picojson/blob/v1.3.0/picojson.h#L820-L870 here.
- Michael Park
On July 9, 2018, 6:40 p.m., Benjamin Mahler
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67861/#review205890
---
Ship it!
Ship It!
- Michael Park
On July 9, 2018, 6:40 p.m
: mesos
Description
---
See summary.
Diffs
-
support/llvm/README.md PRE-CREATION
support/llvm/install.sh PRE-CREATION
Diff: https://reviews.apache.org/r/66114/diff/1/
Testing
---
Thanks,
Michael Park
: mesos
Description
---
See summary.
Diffs
-
support/mesos-tidy.py PRE-CREATION
Diff: https://reviews.apache.org/r/66115/diff/1/
Testing
---
Thanks,
Michael Park
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66007/#review199157
---
Ship it!
Ship It!
- Michael Park
On March 9, 2018, 2:37 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66031/#review199046
---
Ship it!
Ship It!
- Michael Park
On March 12, 2018, 5:08
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65823/#review198360
---
Ship it!
Ship It!
- Michael Park
On Feb. 27, 2018, 3:32 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65683/#review198355
---
Ship it!
Ship It!
- Michael Park
On Feb. 27, 2018, 2:35 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65786/#review198228
---
Ship it!
Ship It!
- Michael Park
On Feb. 23, 2018, 2:37 p.m
would be to do `string(t.error())` and add a `operator
const string&()` to `Error`.
- Michael Park
On Feb. 5, 2018, 2:06 p.m., Benjamin Mahler wrote:
>
> ---
> This is an automatically generated e-mail. To re
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65515/#review197248
---
Ship it!
Ship It!
- Michael Park
On Feb. 5, 2018, 2:08 p.m
decltype(std::forward(self).data.get())
{
if (!self.data.isSome()) {
assert(self.error_.isSome());
ABORT("Try::get() but state == ERROR: " + self.error_->message);
}
return std::forward(self).data
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65512/#review196842
---
Ship it!
Ship It!
- Michael Park
On Feb. 5, 2018, 11:50 a.m
://reviews.apache.org/r/65464/diff/3-4/
Testing (updated)
---
https://builds.apache.org/job/Mesos-Buildbot-Test/103/
Thanks,
Michael Park
/diff/2-3/
Testing (updated)
---
https://builds.apache.org/job/Mesos-Buildbot-Test/101/
Thanks,
Michael Park
environment.
Diffs
-
support/jenkins/buildbot.sh 7f78509699b036df025c314fe913158f54402014
Diff: https://reviews.apache.org/r/65463/diff/1/
Testing
---
Thanks,
Michael Park
-CREATION
support/mesos-build/ubuntu-16.04.dockerfile PRE-CREATION
Diff: https://reviews.apache.org/r/65464/diff/1/
Testing
---
Thanks,
Michael Park
---
Added `examples/flags.hpp` to `src/Makefile.am`.
Diffs
-
src/Makefile.am 155338673e1c23a2cfeab39bdf3ebe14568bfebc
Diff: https://reviews.apache.org/r/65432/diff/1/
Testing
---
Thanks,
Michael Park
---
See summary.
Diffs
-
src/Makefile.am 155338673e1c23a2cfeab39bdf3ebe14568bfebc
Diff: https://reviews.apache.org/r/65428/diff/1/
Testing
---
Thanks,
Michael Park
/stout/protobuf.hpp
7e7659814a5d95c41c4dfabb5669fd061dff4716
Diff: https://reviews.apache.org/r/65376/diff/1/
Testing
---
Thanks,
Michael Park
41c12f61520b2e769e3a1226bf0a767f779c2a75
src/tests/protobuf_io_tests.cpp 4cdf17fd2426159643c719a17fee6e6cedb40f55
src/tests/slave_recovery_tests.cpp 6dcbedb94a2c7b3d65770fc89920c0cad1298d1f
Diff: https://reviews.apache.org/r/65378/diff/1/
Testing
---
Thanks,
Michael Park
186048f159d6ce20d9c5dc65c00012eb5911520b
src/slave/state.hpp dcab4434a0d82efec33f55a1037c892d0a7e9d55
src/slave/state.cpp 41c12f61520b2e769e3a1226bf0a767f779c2a75
Diff: https://reviews.apache.org/r/65377/diff/1/
Testing
---
Thanks,
Michael Park
/future.hpp
Lines 116-117 (patched)
<https://reviews.apache.org/r/65375/#comment276021>
We shouldn't need these, as the copy/move assignment operators will cover
these scenarios already.
For example, we don't define these for `Option` and `Try`.
- Michael Park
On Jan. 28, 2018, 6:
---
Successfully ran:
```bash
OS=ubuntu:16.04 COMPILER=gcc CONFIGURATION="--verbose
--disable-libtool-wrappers" JOBS=32 BUILDTOOL=autotools ENVIRONMENT="GLOG_v=1
MESOS_VERBOSE=1" support/docker-build.sh
```
Thanks,
Michael Park
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65212/#review195742
---
Ship it!
Ship It!
- Michael Park
On Jan. 18, 2018, 5:24 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61811/#review195734
---
Ship it!
Ship It!
- Michael Park
On Jan. 18, 2018, 5:11 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65204/#review195678
---
Ship it!
Ship It!
- Michael Park
On Jan. 17, 2018, 5:19 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65200/#review195663
---
Ship it!
Ship It!
- Michael Park
On Jan. 17, 2018, 3:30 p.m
,
Michael Park
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65063/#review195377
---
Ship it!
Ship It!
- Michael Park
On Jan. 9, 2018, 11:06 p.m
ve an empty file.
In short, these changes are safe.
- Michael
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65022/#review195108
--------
ba8a2a
> src/slave/state.cpp 5428b341b061c8209a5cfe63e17b71467d9f4c48
> src/tests/protobuf_io_tests.cpp 4a2e3a3bc87c1a3394368439e5dd30b410e468a4
> src/tests/slave_recovery_tests.cpp e305d7430b64409fdac84a33ee072707471d2c49
>
>
> Diff: https://reviews.apache.org/r/65022/diff/1/
>
>
> Testing
> ---
>
>
> Thanks,
>
> Michael Park
>
>
---
Fixed the order of parameters of `is_specialization_of` in libprocess.
Diffs
-
3rdparty/libprocess/include/process/future.hpp
54fbbeb9a3378298a71bb569b22ed5dd6d3c39ef
Diff: https://reviews.apache.org/r/65055/diff/1/
Testing
---
Thanks,
Michael Park
<Type, Template>`.
Diffs
-
3rdparty/stout/include/stout/traits.hpp
5dea08404fd12f68af0538a16c5ee1d9734dd8c5
Diff: https://reviews.apache.org/r/65054/diff/1/
Testing
---
Thanks,
Michael Park
149009b07663f530c444d0b7205f23fe4510
Diff: https://reviews.apache.org/r/65031/diff/1/
Testing
---
Thanks,
Michael Park
Diff: https://reviews.apache.org/r/65030/diff/1/
Testing
---
Thanks,
Michael Park
Diff: https://reviews.apache.org/r/65029/diff/1/
Testing
---
Thanks,
Michael Park
d6ea618b20431ac95f880045143d09366f1740bf
src/slave/state.cpp 5428b341b061c8209a5cfe63e17b71467d9f4c48
src/tests/slave_recovery_tests.cpp e305d7430b64409fdac84a33ee072707471d2c49
Diff: https://reviews.apache.org/r/65025/diff/1/
Testing
---
Thanks,
Michael Park
,
Michael Park
5428b341b061c8209a5cfe63e17b71467d9f4c48
src/tests/slave_recovery_tests.cpp e305d7430b64409fdac84a33ee072707471d2c49
Diff: https://reviews.apache.org/r/65026/diff/1/
Testing
---
Thanks,
Michael Park
---
Thanks,
Michael Park
src/tests/slave_recovery_tests.cpp e305d7430b64409fdac84a33ee072707471d2c49
Diff: https://reviews.apache.org/r/65024/diff/1/
Testing
---
Thanks,
Michael Park
5a27f15bac
Diff: https://reviews.apache.org/r/65021/diff/1/
Testing
---
Thanks,
Michael Park
e2608723af0ef9955e46da300254306497d2d6df
Diff: https://reviews.apache.org/r/64924/diff/1/
Testing
---
Thanks,
Michael Park
bd9e025c29fc100121dd187603b2b116207762ba
Diff: https://reviews.apache.org/r/64920/diff/1/
Testing
---
Thanks,
Michael Park
bd9e025c29fc100121dd187603b2b116207762ba
Diff: https://reviews.apache.org/r/64919/diff/1/
Testing
---
Thanks,
Michael Park
an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64739/#review194659
-------
On Jan. 2, 2018, 3:39 p.m., Michael Park wrote:
>
> ---
> This i
8a188a918873eef468a984b80f5ea7ebaa8fb923
Diff: https://reviews.apache.org/r/64739/diff/2/
Changes: https://reviews.apache.org/r/64739/diff/1-2/
Testing
---
Thanks,
Michael Park
`
Thanks,
Michael Park
ps://reviews.apache.org/r/64739/#review194396
---
On Dec. 19, 2017, 4:51 p.m., Michael Park wrote:
>
> ---
> This is an automatically generated e-mail. To reply, vis
,
Michael Park
src/common/resources_utils.hpp 5b74ff2dd3ecb1a0101671d11ea10e29a43524b0
src/common/resources_utils.cpp 47ba885517bdfef4764deb0826e13538ce529902
src/master/http.cpp d7276e45e11f680e909027566b3cf29af10882c9
src/master/master.cpp 03eb178fa1af7d55ae387e6cb42cdc8d721a2196
Diff: https://reviews.apache.org/r/64895/diff/1/
Test
}
}
```
I think the issue is mainly in the way in which we need to treat repeated
fields.
If we were able to get access to a repeated field of `Message`s and pass it to
the recursive call, we could have the check at the top of
`downgradeResourcesImpl`.
But as far as I know, the only
ing with the presence of "downgrade".
- Michael
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64738/#review194205
------
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64686/#review194452
---
Ship it!
Ship It!
- Michael Park
On Dec. 22, 2017, 5:42 a.m
for protobuf reflection-based `downgradeResources`.
Testing
---
Thanks,
Michael Park
---
See summary.
Diffs
-
src/resource_provider/storage/provider.cpp
79d7f602bbc57bce308157dfbb6c2afaef806f23
src/slave/containerizer/mesos/paths.cpp
8a188a918873eef468a984b80f5ea7ebaa8fb923
Diff: https://reviews.apache.org/r/64739/diff/1/
Testing
---
Thanks,
Michael
---
See summary.
Diffs
-
src/common/resources_utils.cpp 1676b72a9ad15bf8b131698a0600a1b0937c00b4
Diff: https://reviews.apache.org/r/64738/diff/1/
Testing
---
Thanks,
Michael Park
validation / normalized resources for storage-related operations.
Diffs
-
src/common/resources_utils.cpp 1676b72a9ad15bf8b131698a0600a1b0937c00b4
Diff: https://reviews.apache.org/r/64737/diff/1/
Testing
---
Thanks,
Michael Park
Lines 101 (patched)
<https://reviews.apache.org/r/63951/#comment271801>
This condition is implied from the constructibility requirement. The
standard doesn't specify these, for example.
- Michael Park
On Nov. 20, 2017, 6:38 a.m., Dmitry Zhuk
<https://reviews.apache.org/r/64428/#comment271720>
Shouldn't need `std::cref` here.
- Michael Park
On Dec. 7, 2017, 12:46 p.m., Benjamin Mahler wrote:
>
> ---
> This is an automatically generated e-mail. To
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64427/#review193183
---
Ship it!
Ship It!
- Michael Park
On Dec. 7, 2017, 12:55 p.m
-
src/webui/master/static/js/jquery.pailer.js
93ff04bac328d72a45317b2f15ccbc5e45c161d4
Diff: https://reviews.apache.org/r/64391/diff/1/
Testing
---
Thanks,
Michael Park
> On Dec. 4, 2017, 11:37 a.m., Michael Park wrote:
> > src/master/master.hpp
> > Line 128 (original), 128 (patched)
> > <https://reviews.apache.org/r/63915/diff/3/?file=1904570#file1904570line128>
> >
> > Maybe we can consider making thi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63761/#review192937
---
Ship it!
Ship It!
- Michael Park
On Dec. 5, 2017, 10:07 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63913/#review192938
---
Ship it!
Ship It!
- Michael Park
On Nov. 21, 2017, 9:52 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63641/#review192917
---
Ship it!
Ship It!
- Michael Park
On Nov. 7, 2017, 9:42 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63638/#review192916
---
Ship it!
Ship It!
- Michael Park
On Nov. 21, 2017, 9:51 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63637/#review192915
---
Ship it!
Ship It!
- Michael Park
On Dec. 5, 2017, 4:20 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64338/#review192910
---
Ship it!
Ship It!
- Michael Park
On Dec. 5, 2017, 4:18 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63635/#review192907
---
Ship it!
Ship It!
- Michael Park
On Nov. 7, 2017, 8:51 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64347/#review192894
---
Ship it!
Ship It!
- Michael Park
On Dec. 5, 2017, 10:06 a.m
o be updated.
3rdparty/libprocess/include/process/event.hpp
Lines 155-158 (original), 178-181 (patched)
<https://reviews.apache.org/r/63631/#comment271210>
Let's clean these up and pull them up and declare them `= delete;`.
Here and below.
- Michael Park
On Dec. 4, 2017, 8:01
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64337/#review192872
---
Ship it!
Ship It!
- Michael Park
On Dec. 5, 2017, 4:13 a.m
---
`std::invoke` is not marked `constexpr`.
Diffs
-
3rdparty/stout/include/stout/cpp17.hpp
3c4cc5345c94270785fa1594d7310af2b4dcf402
Diff: https://reviews.apache.org/r/64332/diff/1/
Testing
---
Thanks,
Michael Park
---
See summary.
Diffs
-
3rdparty/stout/tests/cpp17_tests.cpp 37d817f1af90cc6a17c5d7f17cf0571fd3f4ac7c
Diff: https://reviews.apache.org/r/64331/diff/1/
Testing
---
Thanks,
Michael Park
e-mail. To reply, visit:
https://reviews.apache.org/r/64312/#review192779
-------
On Dec. 4, 2017, 1:58 p.m., Michael Park wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org
docs/upgrades.md 33ba4a69e6e53a313e89a3a24448e3e551443e23
Diff: https://reviews.apache.org/r/64312/diff/2/
Changes: https://reviews.apache.org/r/64312/diff/1-2/
Testing
---
Thanks,
Michael Park
(original), 128 (patched)
<https://reviews.apache.org/r/63915/#comment271003>
Maybe we can consider making this `vector&&` as discussed in
https://reviews.apache.org/r/63914/
- Michael Park
On Nov. 21, 2017, 9:53 a.m., Dmi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63634/#review192745
---
Ship it!
Ship It!
- Michael Park
On Nov. 7, 2017, 8:51 a.m
/resource_provider_manager_tests.cpp
a4c19ca769e66110d9aba0bae4792df9db3fed01
src/v1/mesos.cpp 2c81b37468dc27da863eb8a56a213436b94b73de
Diff: https://reviews.apache.org/r/64312/diff/1/
Testing
---
Thanks,
Michael Park
;`. Maybe
we should make it `vector&&` such that we don't run into this?
Same with `agentCapabilities` and other related data
- Michael Park
On Nov. 21, 2017, 9:53 a.m., Dmitry Zhuk wrote:
>
> ---
> This is an aut
he.org/r/63630/#comment270962>
Is this required for something? I'd prefer to get rid of it if we're not
using it. If we do need it for something, let's make it a `using` declaration.
3rdparty/stout/include/stout/lambda.hpp
Lines 384 (patched)
<https://reviews.apache.org/r/63630/#comment270961>
`f
/tests/lambda_tests.cpp
ad8c2efddb6b64184670d0cfb33188ef843351ab
Diff: https://reviews.apache.org/r/64274/diff/2/
Changes: https://reviews.apache.org/r/64274/diff/1-2/
Testing
---
Thanks,
Michael Park
)
<https://reviews.apache.org/r/63631/#comment270934>
It looks like `consume` in this case happens to not actually move the
`HttpEvent`, but if it were to we'd be in trouble due to the fact that
`HttpEvent` holds a raw pointer and the move ctor is not defined accordingly.
- Michae
: https://reviews.apache.org/r/64274/diff/1/
Testing
---
Thanks,
Michael Park
che.org/r/63636/#comment270713>
We shouldn't need this one.
- Michael Park
On Nov. 22, 2017, 6:13 a.m., Dmitry Zhuk wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
s breadcrumb
for us to know that we need to change code here.
No need to make an extra copy of `MessageEvent`,
here and below.
- Michael Park
On Nov. 7, 2017, 8:51 a.m., Dmitry Zhuk wrote:
>
> ---
> This is an automatic
)
<https://reviews.apache.org/r/63631/#comment270702>
Let's remove this since we're constructing new ones within the `for` loop
now.
- Michael Park
On Nov. 7, 2017, 8:51 a.m., Dmitry Zhuk wrote:
>
> ---
> This is an automati
ent270694>
We recently started to stick to this pattern:
```
tmeplate ::type = 0>
```
- Michael Park
On Nov. 22, 2017, 6:10 a.m., Dmitry Zhuk wrote:
>
> ---
> This is an automatically generated e-mail. To re
: https://reviews.apache.org/r/64248/diff/1/
Testing
---
Addded `cpp17_tests.cpp`
Thanks,
Michael Park
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63628/#review192445
---
Ship it!
Ship It!
- Michael Park
On Nov. 30, 2017, 12:40
be an empty string?
- Michael Park
On Nov. 29, 2017, 5:45 p.m., Benjamin Mahler wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
`Offer`.
src/master/master.cpp
Lines 8143 (patched)
<https://reviews.apache.org/r/64194/#comment270542>
`s/r/resource/`?
- Michael Park
On Nov. 29, 2017, 5:45 p.m., Benjamin Mahler wrote:
>
> ---
&g
1 - 100 of 1831 matches
Mail list logo
