?
- Neil Conway
On Nov. 7, 2015, 7:15 a.m., haosdent huang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
org/r/40118/#comment165138>
Note that this will require changes in the HTTP endpoint patch. (Just
observing that whichever patch gets committed first, the other will need to be
updated.)
- Neil Conway
On Nov. 13, 2015, 1:22 a.m., Greg Mann
169/#comment165140>
Seems like this change shouldn't be included in this review. i.e., the
state of the tree after any patch in a patch chain should still be correct.
- Neil Conway
On Nov. 13, 2015, 1:21 a.m., Greg Mann
fb3
src/tests/slave_tests.cpp 7c9dcc6186a8cccb0eb30ff59914a41961e47293
src/tests/teardown_tests.cpp 96e98bd0d134b2cf093285f37bec4c89c8f3553e
Diff: https://reviews.apache.org/r/40246/diff/
Testing
---
Thanks,
Neil Conway
: https://reviews.apache.org/r/40244/diff/
Testing
---
Thanks,
Neil Conway
/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305
docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a
Diff: https://reviews.apache.org/r/40242/diff/
Testing
---
Thanks,
Neil Conway
ted
Good catch! Thanks.
- Neil
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40243/#review106358
---
On Nov. 13, 20
e/mesos/v1/mesos.proto e71ddda7f23f2272ce8eb00f358c66fce205c13b
Diff: https://reviews.apache.org/r/40243/diff/
Testing
---
Thanks,
Neil Conway
/reservation_endpoints_tests.cpp
1552e4537c4f4d79bfa4bc17ccab2df630bc32a4
src/tests/reservation_tests.cpp ac664ebb49e74aa28551f427ea8f39ac9ce0cfb3
Diff: https://reviews.apache.org/r/40245/diff/
Testing
---
Thanks,
Neil Conway
created/removed persistent volumes via HTTP endpoints + curl.
(3) Previewed docs in Github gist.
Thanks,
Neil Conway
On Aug. 27, 2015, 5:34 a.m., Neil Conway wrote:
include/mesos/mesos.proto, line 102
https://reviews.apache.org/r/37655/diff/2/?file=1049806#file1049806line102
BTW, have you considered using a simpler representation, such as just a
single int64 holding # of nanoseconds
tested building with cmake, although that seems
broken on my machine for reasons unrelated to glog.
Thanks,
Neil Conway
exploring if there's a known data
race/hang...
- Neil Conway
On Aug. 27, 2015, 4:28 a.m., Greg Mann wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37821
# of nanoseconds (or microseconds) since the Unix epoch?
Using nanoseconds you'd be able to express ~292 years -- maybe that's not a
wide enough range?
- Neil Conway
On Aug. 26, 2015, 10:56 p.m., Joseph Wu wrote
82)
<https://reviews.apache.org/r/37945/#comment152830>
This comment seems to contradict the changes made by this patch -- the
comment seems correct (http://stackoverflow.com/a/222314).
- Neil Conway
On Aug. 31, 2015, 10:46 a.m., Guangya Liu
ews.apache.org/r/37903/#review97170
---
On Aug. 28, 2015, 8:02 p.m., Neil Conway wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
Diff: https://reviews.apache.org/r/37876/diff/
Testing
---
make check
Thanks,
Neil Conway
: Update style guide for usage of std::atomic.
Diffs
-
docs/mesos-c++-style-guide.md 5e4d13e0456e577f05631b77349e4b1e6f0945c7
Diff: https://reviews.apache.org/r/38265/diff/
Testing
---
Thanks,
Neil Conway
012af0508eeceeccd168b29f36fa258d20b28c21
Diff: https://reviews.apache.org/r/37878/diff/
Testing
---
Thanks,
Neil Conway
f7d94d92e85c58878d98e13757b6fc37837ca977
3rdparty/libprocess/src/process.cpp 0e5394acff16376809918d583d7aee582cc6da54
3rdparty/libprocess/src/process_reference.hpp
f8df4a6dcf01bb7af750c1ed9e85c64cea2042c5
Diff: https://reviews.apache.org/r/37877/diff/
Testing
---
make check
Thanks,
Neil Conway
is shamelessly copied from Adam B's answer here:
https://stackoverflow.com/a/28493909
Diffs
-
docs/persistent-volume.md b5dd6d8ec68d8ed7dd4787ffc9973bbe6c49965a
Diff: https://reviews.apache.org/r/38325/diff/
Testing
---
Thanks,
Neil Conway
Diff: https://reviews.apache.org/r/37903/diff/
Testing
---
make check
Thanks,
Neil Conway
754a16f9b43630880f0f6c4a8e8e2f5e081b0a87
Diff: https://reviews.apache.org/r/38468/diff/
Testing
---
Thanks,
Neil Conway
6c7f74719a8586f0608eb0f0f77d15c8d534321d
docs/submitting-a-patch.md 754a16f9b43630880f0f6c4a8e8e2f5e081b0a87
Diff: https://reviews.apache.org/r/38468/diff/
Testing
---
Thanks,
Neil Conway
Diff: https://reviews.apache.org/r/37903/diff/
Testing
---
make check
Thanks,
Neil Conway
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37903/#review98301
-------
On Aug. 28, 2015, 8:02 p.m., Neil Conway wrote:
>
> -
: mesos
Description
---
Per style guide, log messages should not end in a period.
Diffs
-
src/authentication/cram_md5/authenticator.cpp
f751ee15a8e8fa47b645d4add0ebe457fa5b49fb
Diff: https://reviews.apache.org/r/38343/diff/
Testing
---
Thanks,
Neil Conway
t.cpp (line 89)
<https://reviews.apache.org/r/38809/#comment158080>
Same as above.
- Neil Conway
On Sept. 28, 2015, 5:25 p.m., Chi Zhang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
Typo
3rdparty/libprocess/include/process/digest.hpp (line 315)
<https://reviews.apache.org/r/38747/#comment158082>
Typo
- Neil Conway
On Sept. 25, 2015, 8:33 p.m., Jojy Varghese wrote:
>
> ---
>
> On Sept. 28, 2015, 6:03 p.m., Neil Conway wrote:
> > 3rdparty/libprocess/src/socket.cpp, line 77
> > <https://reviews.apache.org/r/38809/diff/1/?file=1085970#file1085970line77>
> >
> > Why is this conditional on socketFd?
>
> Chi Zhang wrote:
cadf57314808ade1fe6f25fdbd725f509f0c7d97
Diff: https://reviews.apache.org/r/38937/diff/
Testing
---
Previewed docs in mesos-website-container.
Thanks,
Neil Conway
this piecemeal, why not
do it once across the whole codebase?
Might also be worth adding to the style guide.
- Neil Conway
On Oct. 2, 2015, 1:26 p.m., Alexander Rukletsov wrote:
>
> ---
> This is an automatically generated e-mail. To rep
? If not, might be
worth writing one.
- Neil Conway
On Sept. 25, 2015, 9 p.m., Chi Zhang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
-a-bug.md 6c7f74719a8586f0608eb0f0f77d15c8d534321d
docs/submitting-a-patch.md 754a16f9b43630880f0f6c4a8e8e2f5e081b0a87
Diff: https://reviews.apache.org/r/38468/diff/
Testing (updated)
---
Viewed markdown with https://github.com/mesosphere/mesos-website-container
Thanks,
Neil Conway
> On Sept. 28, 2015, 6:32 p.m., Neil Conway wrote:
> > 3rdparty/libprocess/include/process/digest.hpp, line 222
> > <https://reviews.apache.org/r/38747/diff/7/?file=1084907#file1084907line222>
> >
> > Why do we initialize this to `{0}`?
>
> Jojy Vargh
t; down below.
I'll take a look at this, but can we do it as a separate review?
- Neil
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37877/#review98207
-------
here, though: for example, you could argue that we should
always use the explicit specializations for the sake of consistency.
- Neil
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37876/#rev
://issues.apache.org/jira/browse/MESOS-3591
Repository: mesos
Description
---
Fixed "--help" output for "--master" in mesos-slave.
Diffs
-
src/slave/main.cpp 364dc7fc7ab2e3cef01aea7267dafa014b60e2b9
Diff: https://reviews.apache.org/r/39034/diff/
Testing
-------
Thanks,
Neil Conway
waiting on the
future? Obviously not something we want in the actual patch though.
- Neil Conway
On Sept. 22, 2015, 8:46 p.m., Anand Mazumdar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38645/#review100072
---
Ship it!
Ship It!
- Neil Conway
On Sept. 22, 2015, 9:37 p.m
6c7f74719a8586f0608eb0f0f77d15c8d534321d
docs/submitting-a-patch.md 754a16f9b43630880f0f6c4a8e8e2f5e081b0a87
Diff: https://reviews.apache.org/r/38468/diff/
Testing
---
Thanks,
Neil Conway
d31ce532e0b26569e521b21893ef91d771fc20bc
src/master/detector.cpp d0d10e58cc32f5ba9da1bd35a66dcbf5c204
src/master/main.cpp bafc605d6c20bd264b932e44ee80373a3f692734
Diff: https://reviews.apache.org/r/38734/diff/
Testing
---
make check
Thanks,
Neil Conway
b0cbcb38cfcb923ec7c185bacf139ceb0a28924f
Diff: https://reviews.apache.org/r/37903/diff/
Testing
---
make check
Thanks,
Neil Conway
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38473/#review99616
---
Ship it!
Ship It!
- Neil Conway
On Sept. 18, 2015, 9:53 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37913/#review96952
---
Diff seems weird -- maybe needs a rebase.
- Neil Conway
On Aug
0 and Ubuntu 15.10; `--gtest_repeat=1000` for the more
likely role-related tests.
TODOs:
* Update documentation
* Add tests for allocation behavior for weights + implicit roles
* Add tests for quota + implicit roles?
Thanks,
Neil Conway
src/tests/role_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/41076/diff/
Testing
---
Thanks,
Neil Conway
3fdf5e121840fe99057e917cca48f1425eff6624
src/tests/role_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/40995/diff/
Testing
---
make check.
Thanks,
Neil Conway
ks in
> > mesos, can we consider to remove this parmeter from initialize()? and can
> > initialize role-related information in addFramework().
>
> Neil Conway wrote:
> Hmmm -- I think it is better as written. Right now, weights are static
> and set at initialization-time, so
e this as-is for now though
(making use of unique_ptr is a broader issue).
Thanks,
Neil Conway
ally generated e-mail. To reply, visit:
https://reviews.apache.org/r/41075/#review109287
-------
On Dec. 8, 2015, 5:41 a.m., Neil Conway wrote:
>
> ---
> This is an automatically generated e
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41075/#review109308
-------
On Dec. 8, 2015, 8:33 a.m., Neil Conway wrote:
>
> ---
> Th
ause `delete`-ing
the offer means `offer->id()` is no longer valid).
- Neil
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41075/#review109321
--
u can just review the changes to each file one at a time in the large
commit.
- Neil
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41075/#review109347
--------
b7ba00bc495001380f01737e46e8671ffe1c2ef7
Diff: https://reviews.apache.org/r/41098/diff/
Testing
---
Thanks,
Neil Conway
s (updated)
-
src/tests/role_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/41076/diff/
Testing
---
Thanks,
Neil Conway
t does seem reasonable to me, although with the way the data structures are
organized, it will be somewhat ugly to implement :-\
- Neil
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41075/#review109326
--
allocation interval (although that applies to many other tests as well). I'll
take a look at doing that.
- Neil
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40995/#review109324
----
`
would probably be nicer. I'm inclined to leave this as-is for now though
(making use of unique_ptr is a broader issue).
Thanks,
Neil Conway
eccbb8f8a02b65b26f34e020e736afe0445a6d0d
src/tests/role_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/40995/diff/
Testing
---
make check.
Thanks,
Neil Conway
```
> > Visible = {active} U {weighted} U {quota'ed} U {with-dyn-res}
> > ```
> >
> > Anyway, my point is that we should show all "visible" roles here.
>
> Neil Conway wrote:
> Yeah, this is a good point. Do we think that a user wants to see
> `{active} U
g/r/40271/#comment168138>
"create-volumes" and "destroy-volumes".
- Neil Conway
On Nov. 14, 2015, 12:27 a.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
&
-
"make check" on Linux/AMD64 + GCC 5.2 + ubsan; without fix, ubsan reports an
error. With fix, ubsan does not report (this) error.
Thanks,
Neil Conway
visit:
https://reviews.apache.org/r/40435/#review108773
-------
On Dec. 3, 2015, 6:28 a.m., Neil Conway wrote:
>
> ---
> This is an automatically generat
---
make check.
Thanks,
Neil Conway
> On Nov. 2, 2015, 8:59 p.m., Neil Conway wrote:
> > docs/NewbieQuickStart.md, line 86
> > <https://reviews.apache.org/r/39597/diff/1/?file=1104937#file1104937line86>
> >
> > Links to other docs pages should take the form "(anchor-text)[foo.md]
eccbb8f8a02b65b26f34e020e736afe0445a6d0d
src/tests/role_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/40995/diff/
Testing
---
make check.
Thanks,
Neil Conway
---
src/tests/hierarchical_allocator_tests.cpp
fb214a829a57529d3f5c49730ae9733f53e622ca
src/tests/role_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/41076/diff/
Testing
---
Thanks,
Neil Conway
DRF allocator tests.
Diffs
-
src/tests/hierarchical_allocator_tests.cpp
fb214a829a57529d3f5c49730ae9733f53e622ca
Diff: https://reviews.apache.org/r/41119/diff/
Testing
---
Thanks,
Neil Conway
`
would probably be nicer. I'm inclined to leave this as-is for now though
(making use of unique_ptr is a broader issue).
Thanks,
Neil Conway
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41101/#review109394
---
Ship it!
Nice work -- this is great!
- Neil Conway
On Dec. 8
/stout/tests/protobuf_tests.cpp
7fa06a980b58040f68bf92d217c866f9e48a57d3
3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp
7c0309c41ee5ad18bed30aa31a8361f11bca23a1
Diff: https://reviews.apache.org/r/40988/diff/
Testing
---
make check
Thanks,
Neil Conway
> On Dec. 3, 2015, 4:26 a.m., Michael Park wrote:
> > Could you also create a clean-up patch to get rid of the unnecessary
> > `struct` disambiguators in this file?
>
> Neil Conway wrote:
> I kinda like leaving "struct" as-is, because we're interfacing
est_filter="MasterMaintenanceTest.InverseOffersFilters"
--gtest_repeat=100 # on Ubuntu Wily (slow VM)
Thanks,
Neil Conway
-tests --gtest_filter="MasterMaintenanceTest.InverseOffersFilters"
--gtest_repeat=2000 # on OSX
./src/mesos-tests --gtest_filter="MasterMaintenanceTest.InverseOffersFilters"
--gtest_repeat=100 # on Ubuntu Wily (slow VM)
Thanks,
Neil Conway
rces [7926 kB]
> > Get:18 http://archive.ubuntu.com trusty/main amd64 Packages [1743 kB]
> > Get:19 http://archive.ubuntu.com trusty/restricted amd64 Packages [16.0 kB]
> > Get:20 http://archive.ubuntu.com trusty/universe amd64 Packages [7589 kB]
> > Fetched 21.3 MB in 5s (3835 kB
/authorization.md f5ed75fcd0785fde38058917354fcf6d668dcccb
Diff: https://reviews.apache.org/r/40829/diff/
Testing
---
Previewed using site-docker.
Thanks,
Neil Conway
---
Previewed using site-docker.
Thanks,
Neil Conway
it?
- Neil Conway
On Nov. 7, 2015, 12:20 a.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
g std::vector;
> >
> > using process::Future;
> > using process::PID;
>
> Neil Conway wrote:
> All the test cases I looked at place `process` before `std`: e.g.,
> `fault_tolerance_tests.cpp`, `master_tests.cpp`, `reservation_tests.cpp`.
>
&
exhaustive
though...
- Neil
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40995/#review109217
---
On Dec. 7, 2015
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40995/#review109234
-------
On Dec. 7, 2015, 9:22 p.m., Neil Conway wrote:
>
> ---
3fdf5e121840fe99057e917cca48f1425eff6624
src/tests/role_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/40995/diff/
Testing
---
make check.
Thanks,
Neil Conway
Mann, and Yong Qiao Wang.
Repository: mesos
Description
---
Also added tests for the "/role" HTTP endpoint.
Diffs
-
src/tests/role_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/41076/diff/
Testing
---
Thanks,
Neil Conway
* Update documentation
* I noticed a non-deterministic test failure in
"MasterAllocatorTest/1.FrameworkExited" on Ubuntu 15.10. It repros reliably but
I haven't determined yet whether it is a flakey test or a bug in this patch.
* Add tests for allocation behavior for weights + implicit roles
* Add
without these
changes applied. I'll investigate but for now it seems unrelated -- opened
https://issues.apache.org/jira/browse/MESOS-4095 to track it.
- Neil Conway
On Dec. 8, 2015, 5:31 a.m., Neil Conway wrote
n OSX 10.10 and Ubuntu 15.10; `--gtest_repeat=1000` for the more
likely role-related tests.
TODOs:
* Update documentation
* Add tests for allocation behavior for weights + implicit roles
* Add tests for quota + implicit roles?
Thanks,
Neil Conway
src/tests/role_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/41076/diff/
Testing
---
Thanks,
Neil Conway
views.apache.org/r/40435/diff/
Testing
---
"make check" on Linux/AMD64 + GCC 5.2 + ubsan; without fix, ubsan reports an
error. With fix, ubsan does not report (this) error.
Thanks,
Neil Conway
tps://reviews.apache.org/r/41178/#comment169254>
Comment needs updating.
- Neil Conway
On Dec. 10, 2015, 2:01 a.m., Ben Mahler wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40995/#review109324
-------
On Dec. 9, 2015, 5:53 a.m., Neil Conway wrote:
>
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41159/#review109636
---
Ship it!
Ship It!
- Neil Conway
On Dec. 9, 2015, 11:22 p.m
aking the interface",
is the goal to ensure ABI compatibility or API compatibility? If the former, a
protobuf is not sufficient (you typically need to use the PIML idiom or
something similar).
- Neil Conway
On Dec. 9, 2015, 11:59 p.m., Greg
.
Repository: mesos
Description
---
i.e., roles with no frameworks currently registered.
Diffs
-
src/tests/hierarchical_allocator_tests.cpp
fb214a829a57529d3f5c49730ae9733f53e622ca
Diff: https://reviews.apache.org/r/41215/diff/
Testing
---
make check
Thanks,
Neil Conway
g/r/41075/#comment169539>
AlexR suggested including roles that have any reserved resources here. That
makes sense, but AFAIK there isn't an easy way to find this information (unless
we want to iterate over all the slaves and examine their resources). Thoughts?
- Neil Conway
On Dec. 10, 20
cases for implicit roles.
Diffs
-
src/tests/role_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/41225/diff/
Testing
---
Thanks,
Neil Conway
0a03b5f1ac7dec14bd99c31768f86100f2b60616
src/tests/reservation_endpoints_tests.cpp
d5d2aa7c203aa7357b564ff51cd3b38230195d04
Diff: https://reviews.apache.org/r/41223/diff/
Testing
---
make check
Thanks,
Neil Conway
of the role (as
the map key), and the role's weight is stored in a separate map.
- Neil
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41075/#review109708
-----
54a1b23b22087b5152825125ba146b4cc47af88d
src/tests/role_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/40995/diff/
Testing
---
make check.
Thanks,
Neil Conway
ew`/`delete` where a `unique_ptr`
would probably be nicer. I'm inclined to leave this as-is for now though
(making use of unique_ptr is a broader issue).
Thanks,
Neil Conway
101 - 200 of 2064 matches
Mail list logo
