Review Request 45120: Extended `os::rmdir` in stout to support preserving the root directory.

2016-03-21 Thread Neil Conway
2ec41aaab28ad003 Diff: https://reviews.apache.org/r/45120/diff/ Testing --- make check Thanks, Neil Conway

Review Request 45117: Cleaned up header includes in tests.

2016-03-21 Thread Neil Conway
/teardown_tests.cpp a5f40f991e99ec0d452074a9d3c209b05b317f51 Diff: https://reviews.apache.org/r/45117/diff/ Testing --- make check Thanks, Neil Conway

Review Request 45119: Added TODO.

2016-03-21 Thread Neil Conway
https://issues.apache.org/jira/browse/MESOS-2408 Repository: mesos Description --- Added TODO. Diffs - src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 Diff: https://reviews.apache.org/r/45119/diff/ Testing --- make check Thanks, Neil Conway

Review Request 45118: Fixed various style issues.

2016-03-21 Thread Neil Conway
/persistent_volume_tests.cpp 26fff19daa8b175fdcc06fd9467224d5920a1967 Diff: https://reviews.apache.org/r/45118/diff/ Testing --- make check Thanks, Neil Conway

Review Request 45121: Implemented deletion for persistent volumes.

2016-03-21 Thread Neil Conway
src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697 Diff: https://reviews.apache.org/r/45121/diff/ Testing --- make check Thanks, Neil Conway

Re: Review Request 45122: Updated tests for deletion of persistent volumes.

2016-03-21 Thread Neil Conway
://reviews.apache.org/r/45122/diff/ Testing --- make check Thanks, Neil Conway

Review Request 45122: Updated tests for deletion of persistent volumes.

2016-03-21 Thread Neil Conway
Description --- Updated tests for deletion of persistent volumes. Diffs - src/tests/persistent_volume_tests.cpp 26fff19daa8b175fdcc06fd9467224d5920a1967 Diff: https://reviews.apache.org/r/45122/diff/ Testing --- make check Thanks, Neil Conway

Re: Review Request 45120: Extended `os::rmdir` in stout to support preserving the root directory.

2016-03-25 Thread Neil Conway
8384ba1 3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp 5466991675778c59d8040946717b492cdb1f9b14 Diff: https://reviews.apache.org/r/45120/diff/ Testing --- make check Thanks, Neil Conway

Re: Review Request 45123: Updated docs for deletion of persistent volumes.

2016-03-25 Thread Neil Conway
docs/persistent-volume.md 4b9c59daf6fdcee4a102e19d6eb4df9b5eddfa54 docs/reservation.md 55924adb94028702e15db7e191915157552981d0 docs/upgrades.md 1b683b59b981ec7e4664c751cb57ab848c7506dc Diff: https://reviews.apache.org/r/45123/diff/ Testing --- Thanks, Neil Conway

Re: Review Request 45121: Implemented deletion for persistent volumes.

2016-03-27 Thread Neil Conway
k Thanks, Neil Conway

Re: Review Request 45121: Implemented deletion for persistent volumes.

2016-03-27 Thread Neil Conway
e `rmdir` errors differently? - Neil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45121/#review125492 --- On March

Re: Review Request 45122: Updated tests for deletion of persistent volumes.

2016-03-27 Thread Neil Conway
erated e-mail. To reply, visit: https://reviews.apache.org/r/45122/#review125499 ------- On March 21, 2016, 6:44 p.m., Neil Conway wrote: > > --- > This is an automatica

Re: Review Request 45122: Updated tests for deletion of persistent volumes.

2016-03-27 Thread Neil Conway
26fff19daa8b175fdcc06fd9467224d5920a1967 Diff: https://reviews.apache.org/r/45122/diff/ Testing --- make check Thanks, Neil Conway

Review Request 45038: Fixed email address in Python build file.

2016-03-19 Thread Neil Conway
Description --- Fixed email address in Python build file. Diffs - src/python/setup.py.in 737066952fe72382bcf80ca6d3e8457ea07a65bf Diff: https://reviews.apache.org/r/45038/diff/ Testing --- Thanks, Neil Conway

Review Request 45318: Added a comment to a utility function in libprocess.

2016-03-24 Thread Neil Conway
--- Added a comment to a utility function in libprocess. Diffs - 3rdparty/libprocess/src/process.cpp feaffa4334422ec3964f8d079f570061eaf390d2 Diff: https://reviews.apache.org/r/45318/diff/ Testing --- make check Thanks, Neil Conway

Re: Review Request 45320: Made libprocess return "Accepted" for all libprocess requests.

2016-03-24 Thread Neil Conway
rty/libprocess/src/process.cpp feaffa4334422ec3964f8d079f570061eaf390d2 3rdparty/libprocess/src/tests/process_tests.cpp 6b3aa1bcf20466cdf8f8249988b8b06dec27e5cd Diff: https://reviews.apache.org/r/45320/diff/ Testing --- make check Thanks, Neil Conway

Re: Review Request 45320: Made libprocess return "Accepted" for all libprocess requests.

2016-03-24 Thread Neil Conway
near future. Diffs (updated) - 3rdparty/libprocess/src/process.cpp feaffa4334422ec3964f8d079f570061eaf390d2 3rdparty/libprocess/src/tests/process_tests.cpp 6b3aa1bcf20466cdf8f8249988b8b06dec27e5cd Diff: https://reviews.apache.org/r/45320/diff/ Testing --- make check Thanks, Neil Conway

Review Request 45320: Made libprocess return "Accepted" for all libprocess requests.

2016-03-24 Thread Neil Conway
ss/src/tests/process_tests.cpp 6b3aa1bcf20466cdf8f8249988b8b06dec27e5cd Diff: https://reviews.apache.org/r/45320/diff/ Testing --- make check Thanks, Neil Conway

Review Request 45319: Cleaned up various code in libprocess.

2016-03-24 Thread Neil Conway
6b3aa1bcf20466cdf8f8249988b8b06dec27e5cd Diff: https://reviews.apache.org/r/45319/diff/ Testing --- make check Thanks, Neil Conway

Re: Review Request 44250: Added `Resources::createStrippedScalarQuantity()`.

2016-03-02 Thread Neil Conway
4fa1e78606485d6657d3776e28b78a43cc6449d2 src/tests/resources_tests.cpp e7525a00957e903993f4dd4b73e05c86f84c5c29 src/v1/resources.cpp bca523159577994d5890f832e4f61101b5dbf3bc Diff: https://reviews.apache.org/r/44250/diff/ Testing --- make check Thanks, Neil Conway

Review Request 44280: Removed `FLAGS_v` assignment in test case.

2016-03-02 Thread Neil Conway
Description --- Per discussion with James Peach, this doesn't serve a useful purpose. Diffs - src/tests/hierarchical_allocator_tests.cpp 3e4ad31925e1b815a74d67fa3962d23fa5bc89d1 Diff: https://reviews.apache.org/r/44280/diff/ Testing --- make check Thanks, Neil Conway

Re: Review Request 44251: Improved allocator perf for labeled reservations and volumes.

2016-03-02 Thread Neil Conway
eviews.apache.org/r/44251/#review121633 --- On March 2, 2016, 7:15 p.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 44251: Improved allocator perf for labeled reservations and volumes.

2016-03-02 Thread Neil Conway
2.529951secs to make 200 offers round 10 allocate took 2.460059secs to make 200 offers ``` Performance of `DeclineOffers` without labels is about ~2.1 seconds. Thanks, Neil Conway

Re: Review Request 44251: Improved allocator perf for labeled reservations and volumes.

2016-03-02 Thread Neil Conway
allocate took 2.529951secs to make 200 offers round 10 allocate took 2.460059secs to make 200 offers ``` Performance of `DeclineOffers` without labels is about ~2.1 seconds. Thanks, Neil Conway

Review Request 44371: Added CHANGELOG description for reservation labels.

2016-03-03 Thread Neil Conway
--- Added CHANGELOG description for reservation labels. Diffs - CHANGELOG 4530336b0b5480dc1935cf5fb30a9dd0f003b77c Diff: https://reviews.apache.org/r/44371/diff/ Testing --- Thanks, Neil Conway

Re: Review Request 44252: Update glog-0.3.3.patch to support PowerPC LE platform.

2016-03-03 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44252/#review121983 --- Is this patch in upstream glog? - Neil Conway On March 4, 2016

Re: Review Request 44252: Update glog-0.3.3.patch to support PowerPC LE platform.

2016-03-03 Thread Neil Conway
> On March 4, 2016, 1:40 a.m., Neil Conway wrote: > > Is this patch in upstream glog? > > Zhiwei Chen wrote: > No, this is PowerPC LE porting patch, and this patch can also work on > other platforms. > > As you can see the diff of this patch, it will no

Re: Review Request 44371: Added CHANGELOG description for reservation labels.

2016-03-03 Thread Neil Conway
. Repository: mesos Description --- Added CHANGELOG description for reservation labels. Diffs (updated) - CHANGELOG 4530336b0b5480dc1935cf5fb30a9dd0f003b77c Diff: https://reviews.apache.org/r/44371/diff/ Testing --- Thanks, Neil Conway

Review Request 44407: Fixed a typo in a log message in an example framework.

2016-03-04 Thread Neil Conway
Description --- Fixed a typo in a log message in an example framework. Diffs - src/examples/long_lived_framework.cpp c4c3aa68dc3e6e001f9a746ea5151b8ad958856f Diff: https://reviews.apache.org/r/44407/diff/ Testing --- Visual inspection of log message. Thanks, Neil Conway

Re: Review Request 43685: Refactored test helper code.

2016-03-01 Thread Neil Conway
://reviews.apache.org/r/43685/diff/ Testing --- make check Thanks, Neil Conway

Review Request 44250: Added `Resources::createStrippedScalarQuantity()`.

2016-03-01 Thread Neil Conway
a545100522bf4b1f03e50656d461b3cda6b41e11 src/v1/resources.cpp bca523159577994d5890f832e4f61101b5dbf3bc Diff: https://reviews.apache.org/r/44250/diff/ Testing --- make check Thanks, Neil Conway

Re: Review Request 43686: Added allocator benchmark using labeled resources.

2016-03-01 Thread Neil Conway
2.034805secs to make 200 offers round 12 allocate took 2.053705secs to make 200 offers round 13 allocate took 2.042106secs to make 200 offers round 14 allocate took 2.082704secs to make 200 offers Thanks, Neil Conway

Re: Review Request 43684: Cleaned up allocator benchmark code.

2016-03-01 Thread Neil Conway
--- make check Thanks, Neil Conway

Review Request 44251: Improved allocator perf for labeled reservations and volumes.

2016-03-01 Thread Neil Conway
``` Performance of `DeclineOffers` without labels is about ~2.1 seconds. Thanks, Neil Conway

Re: Review Request 43686: Added allocator benchmark using labeled resources.

2016-03-01 Thread Neil Conway
offers round 14 allocate took 2.082704secs to make 200 offers Thanks, Neil Conway

Re: Review Request 43684: Cleaned up allocator benchmark code.

2016-03-01 Thread Neil Conway
/43684/diff/ Testing --- make check Thanks, Neil Conway

Re: Review Request 44251: Improved allocator perf for labeled reservations and volumes.

2016-03-01 Thread Neil Conway
allocate took 2.529951secs to make 200 offers round 10 allocate took 2.460059secs to make 200 offers ``` Performance of `DeclineOffers` without labels is about ~2.1 seconds. Thanks, Neil Conway

Review Request 44348: Updated CHANGELOG for floating point resource changes.

2016-03-03 Thread Neil Conway
--- Updated CHANGELOG for floating point resource changes. Diffs - CHANGELOG e85669ba815aa25ded3be878be0b799c89e66f2c Diff: https://reviews.apache.org/r/44348/diff/ Testing --- Thanks, Neil Conway

Re: Review Request 44348: Updated CHANGELOG for floating point resource changes.

2016-03-03 Thread Neil Conway
. Changes --- Rebase, reindent. Repository: mesos Description --- Updated CHANGELOG for floating point resource changes. Diffs (updated) - CHANGELOG 7e1354abc3bf35e214d6566ca68124693cb8b8e2 Diff: https://reviews.apache.org/r/44348/diff/ Testing --- Thanks, Neil Conway

Re: Review Request 44433: Added empty line for list in maintenance doc.

2016-03-07 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44433/#review122354 --- Ship it! Ship It! - Neil Conway On March 6, 2016, 3:52 p.m

Re: Review Request 44478: Revised slave recovery documentation.

2016-03-07 Thread Neil Conway
) --- Previewed using site-docker. Thanks, Neil Conway

Review Request 44478: Revised slave recovery documentation.

2016-03-07 Thread Neil Conway
--- Revised slave recovery documentation. Diffs - docs/home.md 821026a12f422385e347e0037d6527efa9ffa2e1 docs/slave-recovery.md 5c148e5a39121f9b5cb7b5a84429551996c1116d Diff: https://reviews.apache.org/r/44478/diff/ Testing --- Thanks, Neil Conway

Review Request 44477: Fixed typo in slave's `--help` output.

2016-03-07 Thread Neil Conway
--- Fixed typo in slave's `--help` output. Diffs - src/slave/flags.cpp 6e3fd69c06eefd40bc0e5c222ea72f34144c5534 Diff: https://reviews.apache.org/r/44477/diff/ Testing --- Thanks, Neil Conway

Review Request 44479: Revised HA framework guide documentation.

2016-03-07 Thread Neil Conway
--- Revised HA framework guide documentation. Diffs - docs/high-availability-framework-guide.md 111d7b9094a7f36fef8cc95232f87c134630c031 Diff: https://reviews.apache.org/r/44479/diff/ Testing --- Thanks, Neil Conway

Review Request 44476: Revised comments about `link` semantics in libprocess.

2016-03-07 Thread Neil Conway
--- Revised comments about `link` semantics in libprocess. Diffs - 3rdparty/libprocess/include/process/process.hpp c9ef4e86a4735c1c0342793b6d5144d80fc853a9 Diff: https://reviews.apache.org/r/44476/diff/ Testing --- Thanks, Neil Conway

Re: Review Request 44474: Improve master tasks metrics.

2016-03-07 Thread Neil Conway
g/r/44474/#comment184371> Seems like we use post-increment elsewhere in this RR? src/master/metrics.cpp (line 327) <https://reviews.apache.org/r/44474/#comment184372> Why not use an iterator / foreach loop over `tasks_stats` instead? - Neil Conway On March 7, 2016, 10:51 p.m

Re: Review Request 44476: Revised comments about `link` semantics in libprocess.

2016-03-07 Thread Neil Conway
/44476/diff/ Testing --- Thanks, Neil Conway

Re: Review Request 44479: Revised HA framework guide documentation.

2016-03-07 Thread Neil Conway
--- Thanks, Neil Conway

Re: Review Request 45039: Updated the comment for launching tasks and accepting offers.

2016-04-01 Thread Neil Conway
ed by tasks that the framework attempted to launch but failed (with TASK_ERROR) due to a malformed task description." - Neil Conway On April 1, 2016, 2:14 p.m., Alexander Rukletsov wrote: > > --- > This is an automatically g

Re: Review Request 45319: Cleaned up various code in libprocess.

2016-04-01 Thread Neil Conway
e8bbc55f0f9aeabe7612a2ced5299cc01202b1f6 3rdparty/libprocess/src/tests/process_tests.cpp 6b3aa1bcf20466cdf8f8249988b8b06dec27e5cd Diff: https://reviews.apache.org/r/45319/diff/ Testing --- make check Thanks, Neil Conway

Re: Review Request 45318: Improved libprocess comments.

2016-04-01 Thread Neil Conway
4cb49680d1304899a4ee675ac07379e51d9c55b1 3rdparty/libprocess/src/process.cpp feaffa4334422ec3964f8d079f570061eaf390d2 Diff: https://reviews.apache.org/r/45318/diff/ Testing --- make check Thanks, Neil Conway

Re: Review Request 42861: Ensure two Mount Disk resources do not have the same root path.

2016-03-28 Thread Neil Conway
s even when you're not "verifying against the mount table entries". src/slave/slave.cpp (line 552) <https://reviews.apache.org/r/42861/#comment188681> Error message shouldn't end in punctuation. - Neil Conway On March 29, 2016, 2:30 a.m.

Re: Review Request 42860: Add paths::overlapping to check whether paths are overlapping.

2016-03-28 Thread Neil Conway
mment188678> Should probably be `const std::vector&`. - Neil Conway On March 29, 2016, 2:30 a.m., haosdent huang wrote: > > --- > This is an automatically generate

Re: Review Request 45489: Replaced reinterpret_cast with dynamic_cast in libprocess.

2016-03-30 Thread Neil Conway
downcasts when the parent class is non-virtual? - Neil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45489/#review126115 --------

Re: Review Request 45318: Added comments to some libprocess functions.

2016-03-30 Thread Neil Conway
feaffa4334422ec3964f8d079f570061eaf390d2 Diff: https://reviews.apache.org/r/45318/diff/ Testing --- make check Thanks, Neil Conway

Re: Review Request 45319: Cleaned up various code in libprocess.

2016-03-30 Thread Neil Conway
/src/tests/process_tests.cpp 6b3aa1bcf20466cdf8f8249988b8b06dec27e5cd Diff: https://reviews.apache.org/r/45319/diff/ Testing --- make check Thanks, Neil Conway

Review Request 45488: Removed an unnecessary `memset` from libprocess.

2016-03-30 Thread Neil Conway
://reviews.apache.org/r/45488/diff/ Testing --- make check Thanks, Neil Conway

Re: Review Request 45466: Removed the redundant `NULL` check when deleting `Credential`.

2016-03-30 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45466/#review126111 --- Ship it! Ship It! - Neil Conway On March 30, 2016, 2:23 a.m

Re: Review Request 45489: Replaced reinterpret_cast with static_cast in libprocess.

2016-03-30 Thread Neil Conway
feaffa4334422ec3964f8d079f570061eaf390d2 Diff: https://reviews.apache.org/r/45489/diff/ Testing (updated) --- make check with GCC 5.3 and recent apple-clang. Thanks, Neil Conway

Re: Review Request 45489: Replaced reinterpret_cast with static_cast in libprocess.

2016-03-30 Thread Neil Conway
_cast` does > > not return `NULL`, or use `static_cast`. > > > > Since `Encoder` seems to implement its own idea of polymorphism it > > seems `static_cast` might fit better. > > Neil Conway wrote: > Hmmm -- I thought `static_cast` was only safe for downca

Re: Review Request 45562: Edited `--work_dir` help strings and docs.

2016-03-31 Thread Neil Conway
the default value _is_ not consistent with this warning. - Neil Conway On March 31, 2016, 8:47 p.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 45122: Updated tests for deletion of persistent volumes.

2016-03-28 Thread Neil Conway
26fff19daa8b175fdcc06fd9467224d5920a1967 Diff: https://reviews.apache.org/r/45122/diff/ Testing --- make check Thanks, Neil Conway

Re: Review Request 45121: Implemented deletion for persistent volumes.

2016-03-28 Thread Neil Conway
eletion fails. Given the TODO above, we could leak disk space anyway. > > Neil Conway wrote: > I used `CHECK_SOME` because we use the same error-handling strategy when > creating the persistent volume fails, or if the slave fails to checkpoint > resources to disk succe

Re: Review Request 45122: Updated tests for deletion of persistent volumes.

2016-03-28 Thread Neil Conway
n the new > > test, you can test the 'creation' of persistent volume as well for PATH > > type disk. > > Neil Conway wrote: > I looked at creating a new test, although it seemed like it would just > duplicate all of the existing `SendingCheckpointResourcesMessage` test. Fo

Re: Review Request 45122: Updated tests for deletion of persistent volumes.

2016-03-28 Thread Neil Conway
> On March 26, 2016, 12:53 a.m., Jie Yu wrote: > > src/tests/persistent_volume_tests.cpp, line 810 > > <https://reviews.apache.org/r/45122/diff/1/?file=1308848#file1308848line810> > > > > What the purpose of adding another file here? > > Nei

Re: Review Request 45423: Added note about preventing resource autodetection to documentation.

2016-03-29 Thread Neil Conway
tps://reviews.apache.org/r/45423/#comment188768> suggested: "manually (via the `--resources` flag)" docs/multiple-disk.md (line 33) <https://reviews.apache.org/r/45423/#comment188769> suggested: "manually specify it using the format described below." - Nei

Re: Review Request 45122: Updated tests for deletion of persistent volumes.

2016-03-28 Thread Neil Conway
> On March 26, 2016, 12:53 a.m., Jie Yu wrote: > > src/tests/persistent_volume_tests.cpp, line 810 > > <https://reviews.apache.org/r/45122/diff/1/?file=1308848#file1308848line810> > > > > What the purpose of adding another file here? > > Nei

Re: Review Request 45122: Updated tests for deletion of persistent volumes.

2016-03-28 Thread Neil Conway
/persistent_volume_tests.cpp 26fff19daa8b175fdcc06fd9467224d5920a1967 Diff: https://reviews.apache.org/r/45122/diff/ Testing --- make check Thanks, Neil Conway

Re: Review Request 45122: Updated tests for deletion of persistent volumes.

2016-03-28 Thread Neil Conway
> On March 26, 2016, 12:53 a.m., Jie Yu wrote: > > src/tests/persistent_volume_tests.cpp, line 810 > > <https://reviews.apache.org/r/45122/diff/1/?file=1308848#file1308848line810> > > > > What the purpose of adding another file here? > > Nei

Re: Review Request 45350: Add `--cgroups_subsystems` in agent flags.

2016-04-04 Thread Neil Conway
g/r/45350/#comment189946> Remove the whitespace before "\n". - Neil Conway On April 4, 2016, 5:14 p.m., haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:

Review Request 46146: Fixed libprocess tests to use smart pointers.

2016-04-13 Thread Neil Conway
/process_tests.cpp 274a76fa61a5cd4b1324be124f73979d4b980660 3rdparty/libprocess/src/tests/sequence_tests.cpp 566393fbf3f19644b86843f07194d1de36a2015e Diff: https://reviews.apache.org/r/46146/diff/ Testing --- make check on OSX and Linux. Thanks, Neil Conway

Re: Review Request 46094: Fixed memory leaks in Encoder/Decoder tests in libprocess.

2016-04-13 Thread Neil Conway
ed an additional RR that makes use of `Owned` in a few other places in the libprocess tests. - Neil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46094/#review128404 --------

Re: Review Request 46094: Fixed memory leaks in Encoder/Decoder tests in libprocess.

2016-04-13 Thread Neil Conway
but at first glance they seem a bit more subtle. Thanks, Neil Conway

Re: Review Request 46593: Added test for containerizer destroy while provisioning race.

2016-04-25 Thread Neil Conway
/mesos_containerizer_tests.cpp (line 958) <https://reviews.apache.org/r/46593/#comment194160> Extra set of parentheses here doesn't seem useful. (Can you fix this where it occurs elsewhere in the test file?) - Neil Conway On April 22, 2016, 11:48 p.m., Gilbert Song

Re: Review Request 40266: Libprocess Reinit: Cleanup SocketManager alongside ProcessManager.

2016-04-25 Thread Neil Conway
tps://reviews.apache.org/r/40266/#comment194255> "each socket" 3rdparty/libprocess/src/process.cpp (line 1357) <https://reviews.apache.org/r/40266/#comment194256> "interdependency" => "a dependency" - Neil Conway

Re: Review Request 40512: Libprocess Reinit: Add a test-only method to reinitialize libprocess.

2016-04-25 Thread Neil Conway
tps://reviews.apache.org/r/40512/#comment194253> Typo. - Neil Conway On April 14, 2016, 8:28 p.m., Joseph Wu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 46471: Updated descriptions for master endpoints which may return redirect.

2016-04-22 Thread Neil Conway
> On April 22, 2016, 3:11 p.m., Neil Conway wrote: > > > > haosdent huang wrote: > Hi, @neilc. Thank you very much for your detail comments! I saw you use > `is xxed` in some comments while use `was xxed` in others. Should I change > all of them to `was xxed` t

Re: Review Request 46471: Updated descriptions for master endpoints which may return redirect.

2016-04-22 Thread Neil Conway
2339) <https://reviews.apache.org/r/46471/#comment193780> "was successful" src/master/http.cpp (line 2455) <https://reviews.apache.org/r/46471/#comment193781> "was successful" - Neil Conway On April 22, 2016,

Re: Review Request 46473: Updated `high-availability` and `operational-guide` docs.

2016-04-22 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46473/#review130113 --- Ship it! Ship It! - Neil Conway On April 22, 2016, 4:10 p.m

Re: Review Request 46471: Updated descriptions for master endpoints which may return redirect.

2016-04-22 Thread Neil Conway
uot; src/master/http.cpp (line 2337) <https://reviews.apache.org/r/46471/#comment193760> "Returns 200 OK when the operation is successful." src/master/http.cpp (line 2453) <https://reviews.apache.org/r/46471/#comment193761> "Returns 200 OK when the operat

Re: Review Request 46391: Clarified several agent log messages.

2016-04-22 Thread Neil Conway
src/slave/slave.cpp a365e8f5f8d63bf80614fccf6adf35a4fee07526 Diff: https://reviews.apache.org/r/46391/diff/ Testing --- make check Thanks, Neil Conway

Re: Review Request 46471: Updated descriptions for master endpoints which may return redirect.

2016-04-22 Thread Neil Conway
> On April 22, 2016, 3:11 p.m., Neil Conway wrote: > > src/master/http.cpp, line 1307 > > <https://reviews.apache.org/r/46471/diff/3/?file=1356457#file1356457line1307> > > > > "Returns 200 OK when the weight update was successful." > > haos

Re: Review Request 46473: Updated `high-availability` and `operational-guide` docs.

2016-04-22 Thread Neil Conway
er, requests made to endpoints at a non-leading master will result in an HTTP 307 redirect to the current leading master." docs/operational-guide.md (line 69) <https://reviews.apache.org/r/46473/#comment193765> Can we link to the endpoint docs for `/state` and `/metrics/snapshot`

Re: Review Request 46828: Fixed newline for `--log_dir` flag usage message.

2016-04-29 Thread Neil Conway
Rukletsov. Repository: mesos Description (updated) --- See summary. Diffs - src/logging/flags.cpp f64ad5eebc4a14ee07796b1a1c273397bdf46cdd Diff: https://reviews.apache.org/r/46828/diff/ Testing --- Visual inspection Thanks, Neil Conway

Review Request 46828: Fixed newline for `--log_dir` flag usage message.

2016-04-29 Thread Neil Conway
Description --- Fixed newline for `--log_dir` flag usage message. Diffs - src/logging/flags.cpp f64ad5eebc4a14ee07796b1a1c273397bdf46cdd Diff: https://reviews.apache.org/r/46828/diff/ Testing --- Visual inspection Thanks, Neil Conway

Review Request 46827: Replaced CHECK with CHECK_READY.

2016-04-29 Thread Neil Conway
Description --- Also removed some unused header includes. Diffs - src/zookeeper/contender.cpp 4b1cc654cb96d3fd87c5f36c93a8ee1e170bea77 Diff: https://reviews.apache.org/r/46827/diff/ Testing --- make check Thanks, Neil Conway

Review Request 46826: Removed unused header include in libprocess.

2016-04-29 Thread Neil Conway
Description --- Removed unused header include in libprocess. Diffs - 3rdparty/libprocess/include/process/future.hpp 9a335d199da2e242ba732ae392e66f86c07cd65d Diff: https://reviews.apache.org/r/46826/diff/ Testing --- make check Thanks, Neil Conway

Re: Review Request 46826: Removed unused header include in libprocess.

2016-04-29 Thread Neil Conway
Rukletsov. Repository: mesos Description (updated) --- See summary. Diffs - 3rdparty/libprocess/include/process/future.hpp 9a335d199da2e242ba732ae392e66f86c07cd65d Diff: https://reviews.apache.org/r/46826/diff/ Testing --- make check Thanks, Neil Conway

Re: Review Request 46827: Replaced CHECK with CHECK_READY.

2016-04-29 Thread Neil Conway
r/46827/#review131066 --- On April 29, 2016, 9:13 a.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46827/ > --

Review Request 46783: Minor clarifications to HA framework guide.

2016-04-28 Thread Neil Conway
--- Minor clarifications to HA framework guide. Diffs - docs/high-availability-framework-guide.md 62f4c565ded28b0d9b5812eecd53b85ec63c2dec Diff: https://reviews.apache.org/r/46783/diff/ Testing --- Thanks, Neil Conway

Review Request 46782: Removed false claim that TEARDOWN can remove persistent volumes.

2016-04-28 Thread Neil Conway
--- Thanks, Neil Conway

Review Request 46779: Clarified and improved maintenance docs.

2016-04-28 Thread Neil Conway
--- Clarified and improved maintenance docs. Diffs - docs/maintenance.md 1f2b14fcbe86b0a2dc1ad59ce1b17d9d07409930 Diff: https://reviews.apache.org/r/46779/diff/ Testing --- Thanks, Neil Conway

Review Request 46781: Fixed invalid JSON in scheduler HTTP API examples.

2016-04-28 Thread Neil Conway
--- Fixed invalid JSON in scheduler HTTP API examples. Diffs - docs/scheduler-http-api.md 6926c272b86a4657f2b6a4836f32722c49da445a Diff: https://reviews.apache.org/r/46781/diff/ Testing --- Thanks, Neil Conway

Review Request 46780: Clarify that slave checkpoint is always enabled.

2016-04-28 Thread Neil Conway
--- Clarify that slave checkpoint is always enabled. Diffs - include/mesos/mesos.proto 9a180304996895e2e003085690a7dff9ec561e9c Diff: https://reviews.apache.org/r/46780/diff/ Testing --- Thanks, Neil Conway

Re: Review Request 46735: Added support for Authorization information to HELP.

2016-04-29 Thread Neil Conway
/help.hpp (line 47) <https://reviews.apache.org/r/46735/#comment195035> I might say "authorization requirements and granularity". - Neil Conway On April 27, 2016, 3:33 p.m., Joerg Schad wrote: > > --- > This is a

Re: Review Request 46736: Added authorization description to quota endpoint help.

2016-04-29 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46736/#review131100 --- Ship it! Ship It! - Neil Conway On April 29, 2016, 2:26 p.m

Re: Review Request 46501: Updated authorization.md to reflect current changes.

2016-04-29 Thread Neil Conway
ld use a single back-tick for that; three back-ticks are for code blocks. I would avoid saying "authorized() should return `false`..." -- authorized() returns a future. I'd say something like "authorized() returns a future that indicates the result of the (asynchronous) au

Re: Review Request 46781: Fixed invalid JSON in scheduler HTTP API examples.

2016-04-28 Thread Neil Conway
. Repository: mesos Description --- Fixed invalid JSON in scheduler HTTP API examples. Diffs (updated) - docs/scheduler-http-api.md 6926c272b86a4657f2b6a4836f32722c49da445a Diff: https://reviews.apache.org/r/46781/diff/ Testing --- Thanks, Neil Conway

Re: Review Request 47463: Added documentation for `network/cni` isolator.

2016-05-19 Thread Neil Conway
uot; docs/cni.md (line 40) <https://reviews.apache.org/r/47463/#comment198615> Saying "network namespace" three times in one sentence seems regrettable. docs/cni.md (line 57) <https://reviews.apache.org/r/47463/#comment198617> "and" twice.

Re: Review Request 46888: Documented that `slaveLost` and `executorLost` are unreliable.

2016-05-12 Thread Neil Conway
1da76ebe577639e8161b16a48a503aa76d568789 Diff: https://reviews.apache.org/r/46888/diff/ Testing --- Thanks, Neil Conway

<    4   5   6   7   8   9   10   11   12   13   >