Re: Review Request 48435: Changed operator API RPC handlers to `http::Response` in agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48435/#review136705 --- same comments as previous review. - Vinod Kone On June 8, 2016

Re: Review Request 48442: Removed redundant expectations for `disconnected` callbacks.

`disconnected` callback is no longer called? - Vinod Kone On June 8, 2016, 7:39 p.m., Anand Mazumdar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 48381: Updated CHANGELOG for 'work_dir' flag changes.

org/r/48381/#comment201798> Keep this. We are now including all issues (even those described up top) here. - Vinod Kone On June 7, 2016, 11:35 p.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 48437: Fixed `Subscribed` events to include heartbeat interval.

g/r/48437/#comment201821> Can you add a TODO to have the master pass the heartbeat interval to the evolve function? Seems a bit unfortunate that evolve.cpp knows about master's logic. - Vinod Kone On June 8, 2016, 6:31 p.m., Anand Mazumdar

Re: Review Request 47700: Added a benchmark for reconciling tasks using the library/driver.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47700/#review136698 --- Ship it! Ship It! - Vinod Kone On June 8, 2016, 5:36 p.m

Re: Review Request 48435: Changed operator API RPC handlers to `http::Response` in agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48435/#review136818 --- Ship it! Ship It! - Vinod Kone On June 9, 2016, 2:01 a.m

Re: Review Request 48449: Add Task proto message to v1/mesos.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48449/#review136821 --- Ship it! Ship It! - Vinod Kone On June 9, 2016, midnight

Re: Review Request 48434: Changed operator API RPC handlers to `http::Response` in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48434/#review136817 --- Ship it! Ship It! - Vinod Kone On June 9, 2016, 2 a.m

Re: Review Request 48400: Extract task collection logic to helper function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48400/#review136820 --- Ship it! Ship It! - Vinod Kone On June 9, 2016, midnight

Re: Review Request 48437: Fixed `Subscribed` events to include heartbeat interval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48437/#review136814 --- Ship it! Ship It! - Vinod Kone On June 8, 2016, 9:46 p.m

Re: Review Request 48299: Updated balloon framework spacing and logging.

(lines 52 - 53) <https://reviews.apache.org/r/48299/#comment201601> IIRC for constructors we use the format on the left. src/examples/balloon_framework.cpp (line 173) <https://reviews.apache.org/r/48299/#comment201602> ..lost on agent.. - Vinod Kone On June 6, 2016, 11:51

Re: Review Request 45604: Updated balloon framework code with flags and better resource math.

;https://reviews.apache.org/r/45604/#comment201608> // If there is an active task, or ... - Vinod Kone On June 6, 2016, 11:55 p.m., Joseph Wu wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Re: Review Request 48051: Expose livereload port in site docker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48051/#review136536 --- Ship it! Ship It! - Vinod Kone On May 31, 2016, 7:23 a.m

Re: Review Request 48303: Split the balloon scheduler into a Process to support metrics.

tps://reviews.apache.org/r/48303/#comment201617> s/behaviors/behavior/ ? src/examples/balloon_framework.cpp (line 231) <https://reviews.apache.org/r/48303/#comment201618> why this change? - Vinod Kone On June 7, 2016, 12:29 a.m., Jos

Re: Review Request 46407: Updated balloon executor.

ad`? because, as it currently stands, `thread` might theoretically send its update before this thread sends TASK_RUNNING. - Vinod Kone On June 6, 2016, 11:48 p.m., Joseph Wu wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 45905: Added metrics to the balloon framework.

(line 256) <https://reviews.apache.org/r/45905/#comment201621> s/allowed_terminations/launch_failures/ ? - Vinod Kone On June 7, 2016, 12:30 a.m., Joseph Wu wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 48264: Added test for optional request.object field.

tps://reviews.apache.org/r/48264/#comment201282> what do you mean by "is only allowed for `ANY`"? did you mean "matches an ACL whose Object is `ANY`" ? src/tests/authorization_tests.cpp (line 2121) <https://reviews.apache.org/r/48264/#comment201281> s/pri

Re: Review Request 48267: Added change of fields `Request` to optional to CHANGELOG.

267/#comment201284> s/these fields/any of these fields/ ? I don't follow what you mean by "the request should be allowed only for ACLs with `ANY` semantics" ? - Vinod Kone On June 6, 2016, 9:54 a.m., J

Re: Review Request 48271: Used tense consistently in 1.0 Changelog.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48271/#review136261 --- Ship it! Ship It! - Vinod Kone On June 6, 2016, 10:45 a.m

Re: Review Request 48263: Fixed documentation for MESOS-5405.

g/r/48263/#comment201289> Is there a place which lists for each of the actions which fields in Object will be set? If not, we should have it. - Vinod Kone On June 6, 2016, 8:22 a.m., Joerg Schad wrote: > > --- > This is a

Re: Review Request 48272: Added 1.0 changed to upgraded.md.

to CHANGELOG? - Vinod Kone On June 6, 2016, 10:46 a.m., Joerg Schad wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 48115: Added maintenance V1 header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48115/#review136279 --- Ship it! Ship It! - Vinod Kone On June 5, 2016, 5:59 p.m

Re: Review Request 48116: Implemented UPDATE_MAINTENANCE_SCHEDULE Call in v1 master API.

> On June 6, 2016, 4:30 p.m., Vinod Kone wrote: > > src/master/http.cpp, line 2951 > > <https://reviews.apache.org/r/48116/diff/1/?file=1406733#file1406733line2951> > > > > why want this function to return `v1::master::Response` instead of > > `http:

Re: Review Request 48248: Fixed typos in comments and log messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48248/#review136471 --- Ship it! Ship It! - Vinod Kone On June 7, 2016, 1:39 p.m

Re: Review Request 48249: Checked metrics after slave removal in partition tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48249/#review136472 --- Ship it! Ship It! - Vinod Kone On June 7, 2016, 1:40 p.m

Re: Review Request 48275: Updated log messages and doc pages for slave -> agent rename.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48275/#review136255 --- Ship it! Ship It! - Vinod Kone On June 6, 2016, 12:37 p.m

Re: Review Request 48263: Fixed documentation for MESOS-5405.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48263/#review136265 --- Ship it! Ship It! - Vinod Kone On June 6, 2016, 8:22 a.m

Re: Review Request 48342: Added checks for `reason` field to task reconciliation tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48342/#review136476 --- Ship it! Ship It! - Vinod Kone On June 7, 2016, 1:43 p.m

Re: Review Request 48344: Parameterized partition tests with registry "strictness".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48344/#review136479 --- Ship it! Ship It! - Vinod Kone On June 7, 2016, 1:45 p.m

Re: Review Request 48250: Cleaned up task state reconciliation tests.

org/r/48250/#comment201518> state is a required field though. so not settting it is a bit weird. i would rather set a dummy state and add a comment saying it's dummy. status.set_state(TASK_KILLED); // Dummy. here and everywhere else. - Vinod Kone On June 7, 2016, 1:

Re: Review Request 48343: Moved two tests from PartitionTest to MasterTest.

g/r/48343/#comment201522> Hmm. Instead of moving them to master_tests.cpp, keep them in partition_tests.cpp and have them inherit from a different testfixture than `PartitionTest`. These are partiton tests after all. - Vinod Kone On June 7, 2016, 1:45 p.m., Neil Conway

Re: Review Request 48046: Implement v1::master::Call::GET_TASKS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48046/#review136495 --- Any updates on this? - Vinod Kone On May 30, 2016, 4:23 p.m

Re: Review Request 47816: Show framework id in log of long-lived-framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47816/#review136494 --- Ship it! Ship It! - Vinod Kone On May 25, 2016, 6:47 a.m

Re: Review Request 48084: Implemented v1::master::Call::GET_MAINTENANCE_STATUS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48084/#review136910 --- Ship it! Ship It! - Vinod Kone On June 9, 2016, 5:49 p.m

Re: Review Request 48257: Implemented GET_MAINTENANCE_SCHEDULE Call in v1 master API.

> On June 9, 2016, 10 p.m., Vinod Kone wrote: > > src/master/http.cpp, line 2874 > > <https://reviews.apache.org/r/48257/diff/2/?file=1412869#file1412869line2874> > > > > to be consistent with how we did others, lets have this function return > > JSON

Re: Review Request 48257: Implemented GET_MAINTENANCE_SCHEDULE Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48257/#review136909 --- Ship it! Ship It! - Vinod Kone On June 9, 2016, 5:49 p.m

Re: Review Request 48286: Implemented STOP_MAINTENANCE Call in v1 master API.

- > > (Updated June 9, 2016, 5:49 p.m.) > > > Review request for mesos, Joseph Wu and Vinod Kone. > > > Bugs: MESOS-5507 > https://issues.apache.org/jira/browse/MESOS-5507 > > > Repository: mesos > > > Description > --- > &

Re: Review Request 48257: Implemented GET_MAINTENANCE_SCHEDULE Call in v1 master API.

g/r/48257/#comment202015> to be consistent with how we did others, lets have this function return JSON::Object, i.e., JSON::Protobuf(schedule) that way the evolve overload can still take JSON::Object. - Vinod Kone On June 9, 2016, 5:49 p.m., haosdent huang

Re: Review Request 48260: Added test case `MasterAPITest.GetMaintenanceStatus`.

tps://reviews.apache.org/r/48260/#comment202028> same comments as previous review. - Vinod Kone On June 9, 2016, 5:49 p.m., haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 48259: Added test case `MasterAPITest.UpdateAndGetMaintenanceSchedule`.

/reviews.apache.org/r/48259/#comment202025> lets just have an evolve function that evolves unversioned schedule to v1::maintenance::schedule? src/tests/api_tests.cpp (lines 295 - 299) <https://reviews.apache.org/r/48259/#comment202027> lets have and use devolve() here. - Vino

Re: Review Request 48046: Implement v1::master::Call::GET_TASKS.

> On June 9, 2016, 9:26 p.m., Vinod Kone wrote: > > src/tests/api_tests.cpp, line 171 > > <https://reviews.apache.org/r/48046/diff/4/?file=1411800#file1411800line171> > > > > What does this comment mean? I didn't follow. > > > > Also

Re: Review Request 48285: Implemented START_MAINTENANCE Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48285/#review136922 --- Ship it! Ship It! - Vinod Kone On June 9, 2016, 5:49 p.m

Re: Review Request 48046: Implement v1::master::Call::GET_TASKS.

i_tests.cpp (line 249) <https://reviews.apache.org/r/48046/#comment202003> ditto. see above. src/tests/api_tests.cpp (line 262) <https://reviews.apache.org/r/48046/#comment202004> align this with first argument. ``` ASSERT_EQ(arg1, arg2);

Re: Review Request 48450: Add unit test for master /tasks endpoint.

tps://reviews.apache.org/r/48450/#comment202008> same comments apply as in the previous review. src/tests/master_tests.cpp (line 2558) <https://reviews.apache.org/r/48450/#comment202009> this is awesome. thanks for going the extra mile to write this test!! - Vinod Kone On June 9, 20

Re: Review Request 48116: Implemented UPDATE_MAINTENANCE_SCHEDULE Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48116/#review136905 --- Ship it! Ship It! - Vinod Kone On June 9, 2016, 5:49 p.m

Re: Review Request 47695: Updated the website generation and development workflows with docker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47695/#review134796 --- Ship it! Ship It! - Vinod Kone On May 24, 2016, 2:38 a.m

Re: Review Request 47702: Added framework role & principal to the Web UI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47702/#review134805 --- Ship it! Ship It! - Vinod Kone On May 23, 2016, 9:08 p.m

Re: Review Request 47804: Fixed a memory leak in SchedulerProcess.decline

> On May 25, 2016, 1:27 a.m., Joseph Wu wrote: > > src/sched/sched.cpp, line 325 > > > > > > On inspection, there's another (rarer) leak that can appear if: > > > > 1) Master sends offers to the framework.

Review Request 47866: Updated committers.md.

Remoortere. Repository: mesos Description --- Added committers that were not updated on the committers doc. Diffs - docs/committers.md bb77ed1c1cf761380a4c7cd281267b342b604f13 Diff: https://reviews.apache.org/r/47866/diff/ Testing --- N/A Thanks, Vinod Kone

Re: Review Request 48595: Exposed the logging process `PID` in libprocess.

/logging.hpp (line 42) <https://reviews.apache.org/r/48595/#comment202698> s/setLevel/set_level/ stout and libprocess use snake case. - Vinod Kone On June 12, 2016, 6:02 p.m., haosdent huang

Re: Review Request 48585: Devolved v1 operator protos to unversioned operator protos in Master.

> On June 13, 2016, 10:07 p.m., Vinod Kone wrote: > > src/master/http.cpp, lines 596-632 > > <https://reviews.apache.org/r/48585/diff/5/?file=1416175#file1416175line596> > > > > s/mesos::// > > Anand Mazumdar wrote: > I guess @haosdent had

Re: Review Request 48524: Moved flag validation after check for required flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48524/#review137380 --- Ship it! Ship It! - Vinod Kone On June 9, 2016, 11:54 p.m

Re: Review Request 48510: Passed `ContentType` enum by value instead of const ref.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48510/#review137381 --- Ship it! Ship It! - Vinod Kone On June 10, 2016, midnight

Re: Review Request 48511: Renamed `responseContentType` to `responseType`.

response type? type could as well refer to status code. or maybe accept type. `responseContentType` is explicit. - Vinod Kone On June 9, 2016, 9:30 p.m., Anand Mazumdar wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 48303: Split the balloon scheduler into a Process to support metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48303/#review137386 --- Ship it! Ship It! - Vinod Kone On June 9, 2016, 11:53 p.m

Re: Review Request 45604: Updated balloon framework code with flags and better resource math.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45604/#review137387 --- Ship it! Ship It! - Vinod Kone On June 9, 2016, 11:48 p.m

Re: Review Request 46407: Updated balloon executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46407/#review137391 --- Ship it! Ship It! - Vinod Kone On June 9, 2016, 11:09 p.m

Re: Review Request 48584: Added unversioned protos for master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48584/#review137402 --- Ship it! Ship It! - Vinod Kone On June 12, 2016, 6:01 p.m

Re: Review Request 48587: Added unversioned protos for agent API.

ent huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48587/ > --- > > (Updated June 12, 2016, 6:01 p.m.) > > > Review request for mesos, Anand

Re: Review Request 48585: Devolved v1 operator protos to unversioned operator protos in Master.

3> s/mesos::// src/master/validation.hpp (line 49) <https://reviews.apache.org/r/48585/#comment202534> s/mesos::// src/master/validation.cpp (lines 57 - 129) <https://reviews.apache.org/r/48585/#comment202535> s/mesos::// - Vinod Kone O

Re: Review Request 48588: Devolved v1 operator protos to unversioned operator protos in Agent.

shouldn't use `slave` keyword per previous review comments. - Vinod Kone On June 12, 2016, 6:01 p.m., haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 48614: Added validation for UUID's to master/agent validation helpers.

016, 6:51 a.m., Deshna Jain wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48614/ > --- > > (Updated June 13, 2016, 6:51 a.m.) > > > Review request

Re: Review Request 48585: Devolved v1 operator protos to unversioned operator protos in Master.

> On June 13, 2016, 10:07 p.m., Vinod Kone wrote: > > src/master/http.cpp, lines 596-632 > > <https://reviews.apache.org/r/48585/diff/5/?file=1416175#file1416175line596> > > > > s/mesos::// > > Anand Mazumdar wrote: > I guess @haosdent had

Re: Review Request 48511: Renamed `responseContentType` to `responseType`.

> On June 13, 2016, 9:29 p.m., Vinod Kone wrote: > > hmm. i dont think `responseType` is that clear. what is a http response > > type? type could as well refer to status code. or maybe accept type. > > `responseContentType` is explicit. > > Anand Mazumdar wro

Re: Review Request 48666: Captured alias variables by const ref in the Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48666/#review137423 --- Ship it! Ship It! - Vinod Kone On June 13, 2016, 11:19 p.m

Re: Review Request 48583: Added `VersionInfo`, `Flag`, `Metrics` to unversioned mesos protos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48583/#review137400 --- Ship it! Ship It! - Vinod Kone On June 12, 2016, 6 p.m

Re: Review Request 48613: Added validation logic for UUID's.

s well. - Vinod Kone On June 13, 2016, 6:51 a.m., Deshna Jain wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48613/ >

Re: Review Request 48116: Implemented UPDATE_MAINTENANCE_SCHEDULE Call in v1 master API.

design doc, it seemed like empty responses should be handled with a 202. > > > > Feel free to drop this is not an issue. > > Vinod Kone wrote: > No response could result in 200 or 202 depending on the semantics of the > request. But looks like `_updateMaintenanceS

Re: Review Request 48299: Updated balloon framework spacing and logging.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48299/#review137389 --- Ship it! Ship It! - Vinod Kone On June 9, 2016, 11:09 p.m

Re: Review Request 48614: Added validation for UUID's to master/agent validation helpers.

.isError()) { return Error("Invalid UUID: " + uuid.error()); } ``` - Vinod Kone On June 13, 2016, 6:51 a.m., Deshna Jain wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 48116: Implemented UPDATE_MAINTENANCE_SCHEDULE Call in v1 master API.

is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48116/ > --- > > (Updated June 12, 2016, 5:46 p.m.) > > > Review request for mesos, Joseph Wu and Vinod Kone. > > > Bugs

Re: Review Request 48272: Added 1.0 changed to upgrades.md.

> On June 6, 2016, 2:52 p.m., Vinod Kone wrote: > > docs/upgrades.md, line 173 > > <https://reviews.apache.org/r/48272/diff/1/?file=1406841#file1406841line173> > > > > This section seems like duplicate of what we have in CHANGELOG. What do > > you t

Re: Review Request 48343: Moved two tests from PartitionTest to MasterTest.

> On June 7, 2016, 3:18 p.m., Vinod Kone wrote: > > src/tests/partition_tests.cpp, line 574 > > <https://reviews.apache.org/r/48343/diff/1/?file=1408804#file1408804line574> > > > > Hmm. Instead of moving them to master_tests.cpp, keep them in > > pa

Re: Review Request 47822: Removed inconsistancy from routing endpoints in agent code.

committing. Thanks. - Vinod Kone On May 25, 2016, 4:27 p.m., Abhishek Dasgupta wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 47822: Removed inconsistancy from routing endpoints in agent code.

-- > > (Updated May 25, 2016, 4:27 p.m.) > > > Review request for mesos, Adam B, Alexander Rukletsov, Anand Mazumdar, > Benjamin Bannier, Greg Mann, Jan Schlicht, Till Toenshoff, and Vinod Kone. > > > Bugs:

Re: Review Request 48008: Added v1 protos for master and agent APIs.

-CREATION include/mesos/v1/mesos.proto af95b5233158c68db356a4c178d9811cf7bf665d Diff: https://reviews.apache.org/r/48008/diff/ Testing --- make check Thanks, Vinod Kone

Review Request 48015: Implemented v1::agent::Call::GET_FLAGS.

64a99d539a0957b92d42c25c8dda298199383018 src/slave/slave.hpp 78a6ecfe29881f1723d7d603a99962afdd5a81a8 src/slave/slave.cpp 97d15da2a20c74d3a502abac68cc7a695e06a189 src/tests/api_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/48015/diff/ Testing --- make check Thanks, Vinod Kone

Review Request 48014: Added the route handler for v1 agent API.

/ Testing --- make check Thanks, Vinod Kone

Re: Review Request 48015: Implemented v1::agent::Call::GET_FLAGS.

PRE-CREATION Diff: https://reviews.apache.org/r/48015/diff/ Testing --- make check Thanks, Vinod Kone

Re: Review Request 48008: Added v1 protos for master and agent APIs.

------- On May 28, 2016, 8:29 p.m., Vinod Kone wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48008/ > -

Re: Review Request 48012: Implemented v1::master::Call::GET_FLAGS.

982b61da5fe34dbe46190477e75ee7a4e4cdce9c src/tests/api_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/48012/diff/ Testing --- make check Thanks, Vinod Kone

Re: Review Request 46373: Request /files/read.json with a negative length value causes error.

> On May 29, 2016, 1:36 a.m., Vinod Kone wrote: > > Can you rebased this? - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46373/#rev

Re: Review Request 46373: Request /files/read.json with a negative length value causes error.

tps://reviews.apache.org/r/46373/#comment200423> Can we fix the pailer to not send -1 length in a follow up patch? - Vinod Kone On May 18, 2016, 4:13 a.m., zhou xing wrote: > > --- > This is an automatically generated e-mail. To reply,

Review Request 48011: Added overload for `http::OK()` that takes ContentType.

/ Testing --- make check Thanks, Vinod Kone

Review Request 48010: Updated Makefile.am to properly build the v1 API protos.

, Vinod Kone

Review Request 48009: Added v1 protos for maintenance, allocator and quota.

. Diffs - include/mesos/v1/maintenance/maintenance.proto PRE-CREATION include/mesos/v1/master/allocator.proto PRE-CREATION include/mesos/v1/quota/quota.proto PRE-CREATION Diff: https://reviews.apache.org/r/48009/diff/ Testing --- make check Thanks, Vinod Kone

Review Request 48008: Added v1 protos for master and agent APIs.

://reviews.apache.org/r/48008/diff/ Testing --- make check Thanks, Vinod Kone

Re: Review Request 48008: Added v1 protos for master and agent APIs.

/v1/mesos.proto af95b5233158c68db356a4c178d9811cf7bf665d Diff: https://reviews.apache.org/r/48008/diff/ Testing --- make check Thanks, Vinod Kone

Review Request 48012: Implemented v1::master::Call::GET_FLAGS.

/diff/ Testing --- make check Thanks, Vinod Kone

Re: Review Request 47988: Added move constructor/assignment to `Try`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47988/#review135413 --- Ship it! Ship It! - Vinod Kone On May 27, 2016, 10:14 p.m

Re: Review Request 47987: Constrained constructible types constructor for `Result`.

tps://reviews.apache.org/r/47987/#comment200425> what does this do? can you add some more info to the description for posterity? - Vinod Kone On May 27, 2016, 10:14 p.m., Anand Mazumdar wrote: > > --- > This is an automati

Re: Review Request 47986: Added move constructor/assignment operator to `Result`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47986/#review135411 --- Ship it! Ship It! - Vinod Kone On May 27, 2016, 10:14 p.m

Re: Review Request 47989: Added move semantics to `Future::set`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47989/#review135414 --- Ship it! Ship It! - Vinod Kone On May 27, 2016, 10:14 p.m

Re: Review Request 47987: Constrained constructible types constructor for `Result`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47987/#review135466 --- Ship it! Ship It! - Vinod Kone On May 29, 2016, 9:05 a.m

Re: Review Request 48029: Implemented v1::agent::Call::GET_LOGGING_LEVEL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48029/#review135471 --- Ship it! Ship It! - Vinod Kone On May 30, 2016, 7:50 a.m

Re: Review Request 47990: Added move semantics to `Pipe::write()`.

- > > (Updated May 27, 2016, 10:14 p.m.) > > > Review request for mesos, Benjamin Mahler, Michael Park, and Vinod Kone. > > > Repository: mesos > > > Description > --- > > Instead of having separate rvalue overload for `write`, > this ch

Review Request 48018: Implemented v1::agent::Call::CHECK_HEALTH.

src/tests/api_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/48018/diff/ Testing --- make check Thanks, Vinod Kone

Re: Review Request 48008: Added v1 protos for master and agent APIs.

/mesos.proto af95b5233158c68db356a4c178d9811cf7bf665d Diff: https://reviews.apache.org/r/48008/diff/ Testing --- make check Thanks, Vinod Kone

Re: Review Request 47991: Passed `Request` object by ptr instead of copying it.

it in owned performs better? - Vinod Kone On May 27, 2016, 10:14 p.m., Anand Mazumdar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Review Request 48017: Implemented v1::master::Call::CHECK_HEALTH.

src/tests/api_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/48017/diff/ Testing --- make check Thanks, Vinod Kone

<    2   3   4   5   6   7   8   9   10   11   >