e447c58bd46ba080529e8f349347eccf5a54110a
Diff: https://reviews.apache.org/r/51009/diff/
Testing
---
Run agent with cfs quota enabled, and observe that throttle related metrics are
in `/containers` and `/monitoring/statistics`
Thanks,
Zhitao Li
/
Testing
---
I am now able to make docker containers launched through mesos-execute have a
cpu quota.
Also making sure `make check` still works on mac os for the linux only flag.
Thanks,
Zhitao Li
Diff: https://reviews.apache.org/r/51052/diff/
Testing
---
I am now able to make docker containers launched through mesos-execute have a
cpu quota.
Also making sure `make check` still works on mac os for the linux only flag.
Thanks,
Zhitao Li
(lines 285 - 286)
<https://reviews.apache.org/r/51124/#comment213408>
Good point. I think symlink will be removed anyway when the entire
`backendDir` is cleaned up, but I think it's better practice to explicitly
remove it here. Will fix.
- Zhitao Li
On Aug. 25, 2016, 4:13 p.m.
c4f55/workdir'
...
(after executor exited)
I0816 01:04:34.859851 46584 overlay.cpp:281] Removed temporary directory
'/tmp/NcmRZt' pointed by
'/var/lib/mesos/provisioner/containers/fd574bbf-4bc0-4538-9ce5-8c2cc93b94c7/backends/overlay/links'
```
Thanks,
Zhitao Li
sos/provisioner/containers/fd574bbf-4bc0-4538-9ce5-8c2cc93b94c7/backends/overlay/links'
```
Thanks,
Zhitao Li
Is there a way to avoid actually calling docker daemon to prepare the mock?
I think we can either override the `getVersion()` call, or override the
`_version()` call by directly returning the `version` in this class.
- Zhitao Li
On Aug. 29, 2016, 5:05 p.m., ha
/
Testing
---
I am now able to make docker containers launched through mesos-execute have a
cpu quota.
Also making sure `make check` still works on mac os for the linux only flag.
Thanks,
Zhitao Li
mac os for the linux only flag.
Thanks,
Zhitao Li
/http.cpp 52dd80b856cf2317c0b73ba54bf501696786088d
src/master/master.cpp d94a8510c4cee9c010706f79caf27ef4a10b41a8
src/tests/api_tests.cpp e440d1b44fb0b40dd1f68209c71e5ca0cd19f4fb
Diff: https://reviews.apache.org/r/51700/diff/
Testing
---
Thanks,
Zhitao Li
://reviews.apache.org/r/51700/diff/
Testing
---
Thanks,
Zhitao Li
/51700/diff/
Testing
---
Thanks,
Zhitao Li
e440d1b44fb0b40dd1f68209c71e5ca0cd19f4fb
Diff: https://reviews.apache.org/r/51752/diff/
Testing
---
Thanks,
Zhitao Li
/tests/api_tests.cpp e440d1b44fb0b40dd1f68209c71e5ca0cd19f4fb
Diff: https://reviews.apache.org/r/51700/diff/
Testing
---
Thanks,
Zhitao Li
src/tests/api_tests.cpp e440d1b44fb0b40dd1f68209c71e5ca0cd19f4fb
Diff: https://reviews.apache.org/r/51752/diff/
Testing
---
Thanks,
Zhitao Li
/
Testing
---
Thanks,
Zhitao Li
src/tests/api_tests.cpp e440d1b44fb0b40dd1f68209c71e5ca0cd19f4fb
Diff: https://reviews.apache.org/r/51752/diff/
Testing
---
Thanks,
Zhitao Li
e440d1b44fb0b40dd1f68209c71e5ca0cd19f4fb
Diff: https://reviews.apache.org/r/51774/diff/
Testing
---
New unit test.
Thanks,
Zhitao Li
better because it keeps mutations to the
`frameworks` variable together above it, so I'd like to keep this as is.
- Zhitao Li
On Sept. 9, 2016, 6:54 a.m., Zhitao Li wrote:
>
> ---
> This is an automatically generated e
tory
'/tmp/NcmRZt' pointed by
'/var/lib/mesos/provisioner/containers/fd574bbf-4bc0-4538-9ce5-8c2cc93b94c7/backends/overlay/links'
```
Thanks,
Zhitao Li
it:
https://reviews.apache.org/r/51124/#review149683
---
On Sept. 20, 2016, 5:28 p.m., Zhitao Li wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
35db198748b8652eb53e17f592f6b40d1e6a3ed9
src/master/quota_handler.cpp bf6a613a7bb3c62fd77d1ffde3170749d6c21fa2
src/tests/master_quota_tests.cpp 48be7406181646c8cc1d169b82a4a4ca71cdf03b
Diff: https://reviews.apache.org/r/52103/diff/
Testing
---
Thanks,
Zhitao Li
ecessary in this patch, and I'll revert to previous
form.
- Zhitao Li
On Sept. 20, 2016, 5:28 p.m., Zhitao Li wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https:
sos/provisioner/containers/fd574bbf-4bc0-4538-9ce5-8c2cc93b94c7/backends/overlay/links'
```
Thanks,
Zhitao Li
--------
On Sept. 22, 2016, 8:52 p.m., Zhitao Li wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51124/
> --
g/r/51623/#comment217901>
Does this work when `--task_group` is not specified? It seems to cause
segfault.
- Zhitao Li
On Sept. 19, 2016, 7:45 p.m., Abhishek Dasgupta wrote:
>
> ---
> This is an automatically generated e
, i suggest we construct a
> > lot of layers (using a for loop), and make sure the test fail without
> > applying this patch and succeed after applying this patch. This better
> > captures the regression.
>
> Zhitao Li wrote:
> +1 for the for loop based test w/ many
---
Thanks,
Zhitao Li
e857b17cfe5f05d59859263c025564d33700a26c
Diff: https://reviews.apache.org/r/52347/diff/
Testing
---
unit test.
Thanks,
Zhitao Li
://reviews.apache.org/r/51052/diff/
Testing
---
I am now able to make docker containers launched through mesos-execute have a
cpu quota.
Also making sure `make check` still works on mac os for the linux only flag.
Thanks,
Zhitao Li
/docker.cpp 1d27761fcb3f310cf954d45ed41f4c89ecbd5982
Diff: https://reviews.apache.org/r/51009/diff/
Testing
---
Run agent with cfs quota enabled, and observe that throttle related metrics are
in `/containers` and `/monitoring/statistics`
Thanks,
Zhitao Li
.
Repository: mesos
Description
---
Add Zhitao Li to contributor.yaml.
Diffs
-
docs/contributors.yaml 578f3fdb3d3c469a2fe1274dcf665850cd1b285d
Diff: https://reviews.apache.org/r/52439/diff/
Testing
---
Thanks,
Zhitao Li
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52438/#review151063
---
Ship it!
Ship It!
- Zhitao Li
On Sept. 30, 2016, 7:17 p.m
Rukletsov, Xiaojian Huang, and Vinod Kone.
Repository: mesos
Description
---
Add Zhitao Li to contributor.yaml.
Diffs (updated)
-
docs/contributors.yaml 578f3fdb3d3c469a2fe1274dcf665850cd1b285d
Diff: https://reviews.apache.org/r/52439/diff/
Testing
---
Thanks,
Zhitao Li
l. To reply, visit:
https://reviews.apache.org/r/52439/#review151064
---
On Sept. 30, 2016, 8:08 p.m., Zhitao Li wrote:
>
> ---
> This is an automatically generated e-mai
://reviews.apache.org/r/51774/diff/
Testing
---
New unit test.
Thanks,
Zhitao Li
1ea79fd7ecd9c2b7e94718fc8c7779d1051583db
include/mesos/v1/master/master.proto 58dc65006658f47bb752ee1c0c1520ee3cc03bd7
Diff: https://reviews.apache.org/r/51774/diff/
Testing
---
New unit test.
Thanks,
Zhitao Li
://reviews.apache.org/r/52515/diff/
Testing
---
Thanks,
Zhitao Li
for `AGENT_ADDED` and `AGENT_REMOVED` events.
Diffs
-
src/tests/api_tests.cpp 7b0ad3c18a38b5ec859a79d09f5707f6958960fb
Diff: https://reviews.apache.org/r/52516/diff/
Testing
---
Thanks,
Zhitao Li
1ea79fd7ecd9c2b7e94718fc8c7779d1051583db
include/mesos/v1/master/master.proto 58dc65006658f47bb752ee1c0c1520ee3cc03bd7
Diff: https://reviews.apache.org/r/51774/diff/
Testing
---
New unit test.
Thanks,
Zhitao Li
Diff: https://reviews.apache.org/r/52516/diff/
Testing
---
Thanks,
Zhitao Li
---
Thanks,
Zhitao Li
Diff: https://reviews.apache.org/r/52516/diff/
Testing
---
Thanks,
Zhitao Li
/api_tests.cpp e440d1b44fb0b40dd1f68209c71e5ca0cd19f4fb
Diff: https://reviews.apache.org/r/51752/diff/
Testing
---
Thanks,
Zhitao Li
1ea79fd7ecd9c2b7e94718fc8c7779d1051583db
include/mesos/v1/master/master.proto 58dc65006658f47bb752ee1c0c1520ee3cc03bd7
Diff: https://reviews.apache.org/r/51774/diff/
Testing
---
New unit test.
Thanks,
Zhitao Li
0c6405f6cfc5a69fa835428fa330d8d63778f469
src/common/protobuf_utils.cpp 1f088684c566f89c85dd72eaece295c5e3d50b23
src/master/master.cpp 756ab546851952bc1de24b1f469d232237b1c01c
Diff: https://reviews.apache.org/r/52515/diff/
Testing
---
Thanks,
Zhitao Li
/api_tests.cpp e440d1b44fb0b40dd1f68209c71e5ca0cd19f4fb
Diff: https://reviews.apache.org/r/51752/diff/
Testing
---
Thanks,
Zhitao Li
1ea79fd7ecd9c2b7e94718fc8c7779d1051583db
include/mesos/v1/master/master.proto 58dc65006658f47bb752ee1c0c1520ee3cc03bd7
Diff: https://reviews.apache.org/r/51774/diff/
Testing
---
New unit test.
Thanks,
Zhitao Li
7b0ad3c18a38b5ec859a79d09f5707f6958960fb
Diff: https://reviews.apache.org/r/52516/diff/
Testing
---
Thanks,
Zhitao Li
0c6405f6cfc5a69fa835428fa330d8d63778f469
src/common/protobuf_utils.cpp 1f088684c566f89c85dd72eaece295c5e3d50b23
src/master/master.cpp 756ab546851952bc1de24b1f469d232237b1c01c
Diff: https://reviews.apache.org/r/52515/diff/
Testing
---
Thanks,
Zhitao Li
/master.proto 1ea79fd7ecd9c2b7e94718fc8c7779d1051583db
include/mesos/v1/master/master.proto 58dc65006658f47bb752ee1c0c1520ee3cc03bd7
Diff: https://reviews.apache.org/r/51774/diff/
Testing
---
New unit test.
Thanks,
Zhitao Li
/52584/diff/
Testing
---
Thanks,
Zhitao Li
1f088684c566f89c85dd72eaece295c5e3d50b23
src/master/http.cpp e9f9d16de803175d4f07e0486674e6150c632b02
Diff: https://reviews.apache.org/r/52584/diff/
Testing
---
Thanks,
Zhitao Li
/
Testing
---
Thanks,
Zhitao Li
/api_tests.cpp 7b0ad3c18a38b5ec859a79d09f5707f6958960fb
Diff: https://reviews.apache.org/r/52516/diff/
Testing
---
Thanks,
Zhitao Li
https://reviews.apache.org/r/52516/#review151528
-------
On Oct. 5, 2016, 11:48 p.m., Zhitao Li wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52516/
> --
3ff37f498d6c830eb2f4b3d9395f9416cb01f5d3
src/master/master.cpp 66a672f6d16233e96b29e330a9e6c474546fa851
src/tests/api_tests.cpp e857b17cfe5f05d59859263c025564d33700a26c
Diff: https://reviews.apache.org/r/52347/diff/
Testing
---
unit test.
Thanks,
Zhitao Li
/api_tests.cpp e857b17cfe5f05d59859263c025564d33700a26c
Diff: https://reviews.apache.org/r/52347/diff/
Testing
---
unit test.
Thanks,
Zhitao Li
66a672f6d16233e96b29e330a9e6c474546fa851
src/tests/api_tests.cpp e857b17cfe5f05d59859263c025564d33700a26c
Diff: https://reviews.apache.org/r/52347/diff/
Testing
---
unit test.
Thanks,
Zhitao Li
66a672f6d16233e96b29e330a9e6c474546fa851
src/tests/api_tests.cpp e857b17cfe5f05d59859263c025564d33700a26c
Diff: https://reviews.apache.org/r/52347/diff/
Testing
---
unit test.
Thanks,
Zhitao Li
66a672f6d16233e96b29e330a9e6c474546fa851
src/tests/api_tests.cpp e857b17cfe5f05d59859263c025564d33700a26c
Diff: https://reviews.apache.org/r/52347/diff/
Testing
---
unit test.
Thanks,
Zhitao Li
)
-
src/common/protobuf_utils.hpp 0c6405f6cfc5a69fa835428fa330d8d63778f469
src/common/protobuf_utils.cpp 1f088684c566f89c85dd72eaece295c5e3d50b23
src/master/http.cpp e9f9d16de803175d4f07e0486674e6150c632b02
Diff: https://reviews.apache.org/r/52584/diff/
Testing
---
Thanks,
Zhitao Li
/diff/
Testing
---
Thanks,
Zhitao Li
`AGENT_REMOVED` events.
Diffs (updated)
-
src/tests/api_tests.cpp 7b0ad3c18a38b5ec859a79d09f5707f6958960fb
Diff: https://reviews.apache.org/r/52516/diff/
Testing
---
Thanks,
Zhitao Li
,
Zhitao Li
/api_tests.cpp e857b17cfe5f05d59859263c025564d33700a26c
Diff: https://reviews.apache.org/r/52347/diff/
Testing
---
unit test.
Thanks,
Zhitao Li
c7e74df71aa31edb490f4f3bd95f2d5aa94b4324
src/tests/api_tests.cpp 39f3f6641cfb4b2e05cbaa1e8156e8a2f480f87a
Diff: https://reviews.apache.org/r/52347/diff/
Testing
---
unit test.
Thanks,
Zhitao Li
0dc6cca367590ea8e9f22b22b85baa4c11e69b13
Diff: https://reviews.apache.org/r/52637/diff/
Testing
---
Thanks,
Zhitao Li
---
Thanks,
Zhitao Li
/
Testing
---
Thanks,
Zhitao Li
/52644/diff/
Testing
---
Thanks,
Zhitao Li
/master/master.proto d2312dce31f56dd65ac4d0e554b680749da61335
include/mesos/v1/master/master.proto 0dc6cca367590ea8e9f22b22b85baa4c11e69b13
Diff: https://reviews.apache.org/r/52637/diff/
Testing
---
Thanks,
Zhitao Li
` response.
Diffs (updated)
-
src/master/http.cpp bb9c87327dfe2161a6f1fd4cded72aa9a5ffaf66
Diff: https://reviews.apache.org/r/52638/diff/
Testing
---
Thanks,
Zhitao Li
Diff: https://reviews.apache.org/r/52639/diff/
Testing
---
Thanks,
Zhitao Li
`recovered_slaves` in master `/state` endpoint.
Diffs
-
src/master/http.cpp bb9c87327dfe2161a6f1fd4cded72aa9a5ffaf66
Diff: https://reviews.apache.org/r/52765/diff/
Testing
---
Thanks,
Zhitao Li
://reviews.apache.org/r/52765/diff/
Testing
---
Thanks,
Zhitao Li
it:
https://reviews.apache.org/r/52638/#review152036
---
On Oct. 12, 2016, 12:18 a.m., Zhitao Li wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https:/
Diff: https://reviews.apache.org/r/52638/diff/
Testing
---
Thanks,
Zhitao Li
/docker.cpp d71386089bf7677872bcb1bd36e07da9263dcf0d
Diff: https://reviews.apache.org/r/51009/diff/
Testing
---
Run agent with cfs quota enabled, and observe that throttle related metrics are
in `/containers` and `/monitoring/statistics`
Thanks,
Zhitao Li
://reviews.apache.org/r/51052/diff/
Testing
---
I am now able to make docker containers launched through mesos-execute have a
cpu quota.
Also making sure `make check` still works on mac os for the linux only flag.
Thanks,
Zhitao Li
d2b4f75a55dbe4746bc2dfc180335fa831a554ef
src/slave/containerizer/mesos/paths.hpp
d85fd34660faacd9c73de2ba7b87b3bbd4b6007b
src/slave/containerizer/mesos/paths.cpp
c1770cefe0287ce994eec6979db41201148ef3fb
Diff: https://reviews.apache.org/r/55334/diff/
Testing
---
Thanks,
Zhitao Li
/55335/diff/
Testing
---
GTEST_FILTER="MesosContainerizer*" make check
Thanks,
Zhitao Li
ntainerizer/docker/pull_ms/max": 26261.613824,
"containerizer/docker/pull_ms/p95": 23649.009536,
"containerizer/docker/pull_ms/min": 103.215872,
"containerizer/docker/pull_ms/p99": 25739.0929664,
"containerizer/docker/pull_ms": 26261.613824,
"containerizer/docker/pull_ms/count": 3
```
Thanks,
Zhitao Li
d86afd2a6ff0bf87e624db1c99255c85068bf6ab
src/slave/containerizer/mesos/provisioner/docker/store.cpp
68ce265a5d0a61f8d9ed55dd14c630dcf893a7d2
Diff: https://reviews.apache.org/r/55727/diff/
Testing
---
Thanks,
Zhitao Li
/containerizer/mock_containerizer.hpp
ca0ae053b1eed01d6c04f581cd08485beec0c5fb
Diff: https://reviews.apache.org/r/56721/diff/
Testing
---
Thanks,
Zhitao Li
a98acb7b0c66f7e17dcecf61ed22bfde70a33651
src/slave/http.cpp ccd489d700a605dc41037e00dbd6a7cb3b6edcc6
src/slave/slave.hpp 3b0aea4e3e9a17501077beccbccaab4abbe11af2
src/slave/validation.cpp 2c5335bc92860be5dd9148e0aa2105c323e1aa8a
Diff: https://reviews.apache.org/r/56722/diff/
Testing
---
Thanks,
Zhitao Li
ral
guideline regardless of versions? (if former, maybe call out the reason; if
latter, maybe move to a different location).
- Zhitao Li
On Feb. 21, 2017, 7:57 a.m., Adam B wrote:
>
> ---
> This is an automatically generated
> On Feb. 21, 2017, 11:20 p.m., Zhitao Li wrote:
> > docs/upgrades.md, lines 252-260
> > <https://reviews.apache.org/r/56867/diff/1/?file=1640650#file1640650line252>
> >
> > 1. Is the order of these actions matter? I recall we specifically say
> > ord
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57624/#review169021
---
Ship it!
Ship It!
- Zhitao Li
On March 14, 2017, 10:27 p.m
g could take minutes for
large image.
- Zhitao Li
On March 15, 2017, 10:41 a.m., Ilya Pronin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
?
src/tests/containerizer/linux_filesystem_isolator_tests.cpp
Lines 842 (patched)
<https://reviews.apache.org/r/58280/#comment244298>
Move this comment before the code block above?
- Zhitao Li
On April 7, 2017, 11:47 p.m., Jie Yu
python.
Thanks,
Zhitao Li
84df21dd6e63653e1a18e700ef904aa3a04b2b45
Diff: https://reviews.apache.org/r/58357/diff/1/
Testing
---
Ran this on all three languages options for cpp, java and python.
Thanks,
Zhitao Li
Testing
---
Thanks,
Zhitao Li
://reviews.apache.org/r/58359/diff/1/
Testing
---
Thanks,
Zhitao Li
/protobuf_utils_tests.cpp 5239182812835b93a28e85146b2df2b20ae77328
Diff: https://reviews.apache.org/r/58360/diff/1/
Testing
---
Thanks,
Zhitao Li
,
Zhitao Li
://reviews.apache.org/r/55334/diff/3-4/
Testing
---
Thanks,
Zhitao Li
.182208,
"containerizer/mesos/docker_store/pull_ms/p999": 12520.426776832,
"containerizer/mesos/docker_store/pull_ms/min": 3167.337984,
"containerizer/mesos/docker_store/pull_ms/p95": 12091.4106496,
"containerizer/mesos/docker_store/pull_ms/p99": 12441.62789632,
"containerizer/mesos/docker_store/layers": 47,
```
Thanks,
Zhitao Li
/tests/containerizer.cpp 548da3a8757c9ad3ab115c6b91f8a1f2f5e37144
src/tests/containerizer/mock_containerizer.hpp
ca0ae053b1eed01d6c04f581cd08485beec0c5fb
Diff: https://reviews.apache.org/r/56721/diff/2/
Changes: https://reviews.apache.org/r/56721/diff/1-2/
Testing
---
Thanks,
Zhitao Li
201 - 300 of 929 matches
Mail list logo
