,
revocable_cpu_low_priority: true,
sandbox_directory: /mnt/mesos/sandbox,
strict: true,
switch_user: true,
version: false,
work_dir: /tmp/mesos/0
}
}
```
Thanks,
haosdent huang
,
work_dir: /tmp/mesos/0
}
}
```
Thanks,
haosdent huang
://issues.apache.org/jira/browse/MESOS-3238
Repository: mesos
Description
---
Fix typos in master endpoint help messages.
Diffs
-
src/master/http.cpp 7d7e562574f3805eef3a4b69c35be29d7dae6c90
Diff: https://reviews.apache.org/r/37252/diff/
Testing
---
Thanks,
haosdent huang
(updated)
---
make check
Thanks,
haosdent huang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37023/#review93952
---
On Aug. 8, 2015, 3:50 a.m., haosdent huang wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37024/#review93947
---
On Aug. 2, 2015, 10:16 a.m., haosdent huang wrote
,
haosdent huang
a.m., haosdent huang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36811/
---
(Updated July 25, 2015, 8:23 a.m.)
Review
/__init__.py 028b0d27fb193bac96f2a6a3201ee4cc8fd369ef
src/cli/python/mesos/cli.py
src/cli/python/mesos/futures.py
src/cli/python/mesos/http.py
src/python/cli/src/mesos/__init__.py PRE-CREATION
Diff: https://reviews.apache.org/r/36819/diff/
Testing
---
Thanks,
haosdent huang
/36819/diff/
Testing (updated)
---
make check
Thanks,
haosdent huang
/src/mesos/__init__.py PRE-CREATION
Diff: https://reviews.apache.org/r/36819/diff/
Testing
---
make check
Thanks,
haosdent huang
8620547148f8a69d5b661eaf08063ca72347b6a4
3rdparty/libprocess/src/process.cpp 6d3609d06d017d8e50d7935b335fda7ebecbd04c
Diff: https://reviews.apache.org/r/36821/diff/
Testing
---
Thanks,
haosdent huang
-CREATION
3rdparty/libprocess/3rdparty/versions.am
97727537778511ca5a10be4f3c25cd21d919
Diff: https://reviews.apache.org/r/36837/diff/
Testing
---
Thanks,
haosdent huang
-CREATION
3rdparty/libprocess/3rdparty/versions.am
97727537778511ca5a10be4f3c25cd21d919
Diff: https://reviews.apache.org/r/36837/diff/
Testing
---
Thanks,
haosdent huang
97727537778511ca5a10be4f3c25cd21d919
Diff: https://reviews.apache.org/r/36837/diff/
Testing
---
Thanks,
haosdent huang
3rdparty/libprocess/3rdparty/versions.am
97727537778511ca5a10be4f3c25cd21d919
Diff: https://reviews.apache.org/r/36837/diff/
Testing (updated)
---
make check
Thanks,
haosdent huang
---
Thanks,
haosdent huang
/containerizer/containerizer.cpp
25c87e9f948b7efe8b9a853c403bee69982d6c4c
Diff: https://reviews.apache.org/r/36838/diff/
Testing
---
Thanks,
haosdent huang
://issues.apache.org/jira/browse/MESOS-3087
Repository: mesos
Description
---
Fix typos in oversubscription doc.
Diffs
-
docs/oversubscription.md f17d4d4dfbf31bdda1a43b6f445ec2082b485d87
Diff: https://reviews.apache.org/r/36839/diff/
Testing
---
Thanks,
haosdent huang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36841/#review93091
---
Ship it!
Ship It!
- haosdent huang
On July 27, 2015, 6:48 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36840/#review93092
---
Ship it!
Ship It!
- haosdent huang
On July 27, 2015, 6:47 a.m
://issues.apache.org/jira/browse/MESOS-2480
Repository: mesos
Description
---
Don't check protobuf jar when --disable-java flag.
Diffs
-
configure.ac 546c9bbf775a4ef481fafb3a58c85c6d80e19500
Diff: https://reviews.apache.org/r/36811/diff/
Testing
---
Thanks,
haosdent huang
://issues.apache.org/jira/browse/MESOS-2480
Repository: mesos
Description
---
Don't check protobuf jar in libprocess.
Diffs
-
3rdparty/libprocess/configure.ac 7d1221bd5ddfc4fa816b0bbea0be5c6b2cbb
Diff: https://reviews.apache.org/r/36810/diff/
Testing
---
Thanks,
haosdent
(updated)
---
../configure --with-protobuf=/usr/local --disable-java
make -j4
make check -j4 GTEST_FILTER=-*
Thanks,
haosdent huang
/
Testing (updated)
---
../configure --with-protobuf=/usr/local --disable-java
make -j4
make check -j4 GTEST_FILTER=-*
Thanks,
haosdent huang
://issues.apache.org/jira/browse/MESOS-527
Repository: mesos
Description
---
Use executor in mesos-execute.
Diffs
-
src/cli/execute.cpp d070164e080cb74ee15d3184487a121f429a29fc
Diff: https://reviews.apache.org/r/36814/diff/
Testing
---
Thanks,
haosdent huang
97b25716335ec5719c1100bd73d06b7fc98036c9
src/tests/health_check_tests.cpp 157a56aa06677d8b7a2cef53b29ed05cb4b5d8ea
Diff: https://reviews.apache.org/r/36816/diff/
Testing (updated)
---
* Add a new unit test: HealthCheckTest.HealthyTaskThroughHttp
make check
Thanks,
haosdent huang
/health_check_tests.cpp 157a56aa06677d8b7a2cef53b29ed05cb4b5d8ea
Diff: https://reviews.apache.org/r/36816/diff/
Testing
---
Thanks,
haosdent huang
stringify.hpp. Just need
```
stringify(url)
```
- haosdent huang
On July 17, 2015, 2:06 p.m., Klaus Ma wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36501
On July 17, 2015, 2:20 p.m., haosdent huang wrote:
Ship It!
3rdparty/libprocess/src/tests/http_tests.cpp have a unit test case
TEST(URLTest, Stringification) show how to use URL and stringify it. Maybe
you could use URL according that.
- haosdent
On July 17, 2015, 2:20 p.m., haosdent huang wrote:
src/tests/fetcher_tests.cpp, line 22
https://reviews.apache.org/r/36501/diff/4/?file=1014441#file1014441line22
Need sort it lexicographically.
```
#include sstream
#include string
```
#include sstream
here. And if
`net::getHostname(process.self().address.ip)` return error, does it make
incorrect url?
src/tests/utils.hpp (line 72)
https://reviews.apache.org/r/36501/#comment145914
How about check path length and use `path[0]` here? Instead of
`*(path.begin())`
- haosdent huang
On July 17, 2015, 2:20 p.m., haosdent huang wrote:
src/tests/fetcher_tests.cpp, line 22
https://reviews.apache.org/r/36501/diff/4/?file=1014441#file1014441line22
Need sort it lexicographically.
```
#include sstream
#include string
haosdent huang wrote
/36501/#comment146048
Because use stringify, could remove it now.
src/tests/fetcher_tests.cpp (line 66)
https://reviews.apache.org/r/36501/#comment146047
Because use stringify, could remove it now.
- haosdent huang
On July 17, 2015, 4:13 p.m., Klaus Ma wrote
)
https://reviews.apache.org/r/36501/#comment146334
It would be better to add ```#include stout/stringify.hpp``` after
```#include stout/protobuf.hpp```
- haosdent huang
On July 18, 2015, 9:47 a.m., Klaus Ma wrote
On July 20, 2015, 4:42 p.m., haosdent huang wrote:
Its a bit difficult to follow the mesos style guide at first. Maybe the
committer could help you reformat it when summit @klausma1982 . :-)
- haosdent
---
This is an automatically
://reviews.apache.org/r/39678/diff/
Testing
---
Add a new test case: DockerTest.ROOT_DOCKER_RunWithEnv
Thanks,
haosdent huang
g/r/39493/#comment162007>
How about add nss through install. Because install also would update if the
package installed.
- haosdent huang
On Oct. 23, 2015, 11:58 p.m., Greg Mann wrote:
>
> ---
> This is an automatically g
> On Oct. 18, 2015, 4:10 a.m., haosdent huang wrote:
> > src/docker/docker.cpp, line 430
> > <https://reviews.apache.org/r/39388/diff/2/?file=1100523#file1100523line430>
> >
> > Seems we already have this env in
> > https://github.com/apache/me
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40107/#review105877
---
Ship it!
Ship It!
- haosdent huang
On Nov. 10, 2015, 1:21 p.m
could do a quick wround in old code. But I think
add a parsing function for URL maybe better, it also could fix the TODO item. I
think we also could update the code in fetcher to use process::http::URL, so
far I only change the Fetcher::basename function.
Thanks,
haosdent huang
for URL maybe better, it also could fix the TODO item. I
think we also could update the code in fetcher to use process::http::URL, so
far I only change the Fetcher::basename function.
Thanks,
haosdent huang
/diff/
Testing
---
# Add `URLTest.Parsing` test case
Thanks,
haosdent huang
https://issues.apache.org/jira/browse/MESOS-3485
Repository: mesos
Description
---
Make hook execution order deterministic.
Diffs
-
src/hook/manager.cpp d9e660a3b6f6d13d9f6b59f53bfc8a4f65af6df4
Diff: https://reviews.apache.org/r/40056/diff/
Testing
---
Thanks,
haosdent huang
/diff/
Testing
---
manually test.
Thanks,
haosdent huang
862/#comment162981>
Could you explain why change to 4891 here? Because slave default port is
5051
- haosdent huang
On Nov. 2, 2015, 4:23 p.m., Bhuvan Arumugam wrote:
>
> ---
> This is an automatically generated e-mail.
nerated e-mail. To reply, visit:
https://reviews.apache.org/r/39837/#review104660
---
On Nov. 1, 2015, 9:38 a.m., haosdent huang wrote:
>
> ---
> This i
lly generated e-mail. To reply, visit:
https://reviews.apache.org/r/39837/#review104665
---
On Nov. 1, 2015, 9:38 a.m., haosdent huang wrote:
>
> ---
> This is an automa
; variables or taskinfo.
> >
> > The fix should be carefully picking the ones we need only.
>
> haosdent huang wrote:
> How about only include `MESOS_` and `LIBPROCESS_` prefix environment
> variables default?
>
> Jojy Varghese wrote:
> In this particu
> On Oct. 18, 2015, 4:10 a.m., haosdent huang wrote:
> > src/docker/docker.cpp, line 430
> > <https://reviews.apache.org/r/39388/diff/2/?file=1100523#file1100523line430>
> >
> > Seems we already have this env in
> > https://github.com/apache/me
automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39944/#review105113
-------
On Nov. 4, 2015, 6:02 p.m., haosdent huang wrote:
>
> ---
> Thi
/include/stout/os/environment.hpp
91d82a8fae27c002458cad0bbdc45b312d2ec70d
3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp
5a1da57f7e27cf8154f0d5f6efd47dcee8a430ff
Diff: https://reviews.apache.org/r/39944/diff/
Testing
---
Thanks,
haosdent huang
eviews.apache.org/r/39945/#review105111
---
On Nov. 5, 2015, 3:19 a.m., haosdent huang wrote:
>
> ---
> This is an automatically generated e-mail. To re
eviews.apache.org/r/39944/#review105114
---
On Nov. 5, 2015, 3:18 a.m., haosdent huang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39944/
> --
/environment.hpp
91d82a8fae27c002458cad0bbdc45b312d2ec70d
3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp
5a1da57f7e27cf8154f0d5f6efd47dcee8a430ff
Diff: https://reviews.apache.org/r/39944/diff/
Testing
---
Thanks,
haosdent huang
://reviews.apache.org/r/39945/diff/
Testing
---
Thanks,
haosdent huang
06753365e2ec7cb59edd1ed6ecfe1a794498ee9b
Diff: https://reviews.apache.org/r/40046/diff/
Testing
---
Thanks,
haosdent huang
1b36e66ded4be8cbe98b751a0816db54be70ad69
src/common/type_utils.cpp 0e11468375af384e1ba4bf9a4e16720db5afeb63
src/tests/master_tests.cpp 856440559de7d58be5bcf2ab6be911b5c67001cd
Diff: https://reviews.apache.org/r/37022/diff/
Testing
---
make check
Thanks,
haosdent huang
/
Testing
---
Thanks,
haosdent huang
)
---
# Add `URLTest.Parsing` test case
Thanks,
haosdent huang
46d0690887b6b6af4c7102753cae8db0a375fa08
Diff: https://reviews.apache.org/r/40054/diff/
Testing
---
Thanks,
haosdent huang
90c9be122ee0c402b806d70fc818e3c03b15101a
3rdparty/libprocess/src/http.cpp 19eca9c718e15d5e7cb32be4bd8a3471299d9311
3rdparty/libprocess/src/tests/http_tests.cpp
7eb4ef187b2cb358c370d0381db65b8e18668bab
Diff: https://reviews.apache.org/r/40053/diff/
Testing
---
Thanks,
haosdent huang
46d0690887b6b6af4c7102753cae8db0a375fa08
Diff: https://reviews.apache.org/r/40054/diff/
Testing (updated)
---
# Add `FetcherTest.OSNetUriWithQueryTest` test case.
Thanks,
haosdent huang
could fix the TODO item. I
think we also could update the code in fetcher to use process::http::URL, so
far I only change the Fetcher::basename function.
Thanks,
haosdent huang
for URL maybe better, it also could fix the TODO item. I
think we also could update the code in fetcher to use process::http::URL, so
far I only change the Fetcher::basename function.
Thanks,
haosdent huang
/diff/
Testing
---
# Add `URLTest.Parsing` test case
Thanks,
haosdent huang
/docker.cpp 4ebca660834492f99815a17e04cef6116654dedb
src/slave/flags.cpp ed9b0b8313f5a5e53f3715af5300d9fcaa936df8
Diff: https://reviews.apache.org/r/39939/diff/
Testing
---
make check
Thanks,
haosdent huang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39940/#review105086
---
Ship it!
Ship It!
- haosdent huang
On Nov. 4, 2015, 5:16 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39938/#review105085
---
Ship it!
Ship It!
- haosdent huang
On Nov. 4, 2015, 5:15 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39941/#review105087
---
Ship it!
Ship It!
- haosdent huang
On Nov. 4, 2015, 5:16 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39799/#review105032
---
Ship it!
Ship It!
- haosdent huang
On Oct. 30, 2015, 2:59 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39800/#review105031
---
Ship it!
Ship It!
- haosdent huang
On Oct. 30, 2015, 3:12 a.m
eviews.apache.org/r/39944/#review105256
---
On Nov. 5, 2015, 8:25 a.m., haosdent huang wrote:
>
> ---
> This is an automatically generated e-mail. To re
card this and create a patch which excalty include environment
variables.
- haosdent
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39944/#review105444
-------
> On Oct. 18, 2015, 4:10 a.m., haosdent huang wrote:
> > src/docker/docker.cpp, line 430
> > <https://reviews.apache.org/r/39388/diff/2/?file=1100523#file1100523line430>
> >
> > Seems we already have this env in
> > https://github.com/apache/me
utomatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39386/#review103005
---
On Oct. 19, 2015, 2:59 a.m., haosdent huang wrote:
>
> ---
> This is an
://reviews.apache.org/r/39386/diff/
Testing
---
* make check
* make install and then test with marathon to check if launcher_dir passes
correctly.
Thanks,
haosdent huang
--------
On Oct. 19, 2015, 2:59 a.m., haosdent huang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39386/
> --
-CREATION
Diff: https://reviews.apache.org/r/38978/diff/
Testing
---
test manually
Thanks,
haosdent huang
support/hooks/post-rewrite PRE-CREATION
Diff: https://reviews.apache.org/r/38978/diff/
Testing
---
test manually
Thanks,
haosdent huang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39323/#review102677
---
Ship it!
Ship It!
- haosdent huang
On Oct. 14, 2015, 6:14 p.m
eviews.apache.org/r/38978/#review102629
---
On Oct. 14, 2015, 4:55 p.m., haosdent huang wrote:
>
> ---
> This is an automatically generated e-mail. To re
ription empty in help information.
>
>
> Diffs
> -
>
> 3rdparty/libprocess/include/process/help.hpp
> e7dc670648e8abd2fef7be79835f0b71e3e91258
> 3rdparty/libprocess/src/help.cpp 822c0844c61c7cabfca2b0534a5fb40001bd7cc7
>
> Diff: https://reviews.apache.org/r/39037/diff/
>
>
> Testing
> ---
>
>
> Thanks,
>
> haosdent huang
>
>
e7dc670648e8abd2fef7be79835f0b71e3e91258
3rdparty/libprocess/src/help.cpp 822c0844c61c7cabfca2b0534a5fb40001bd7cc7
Diff: https://reviews.apache.org/r/39037/diff/
Testing
---
Thanks,
haosdent huang
.26.0",
"git_sha": "4566f05e1c4c82d4d5e1c6ac563ea0fb362324e3",
"git_branch": "refs/heads/MESOS-1841",
"build_user": "haosdent",
"build_time": 1444185166,
"build_date": "2015-10-07 10:32:46"
}
```
Thanks,
haosdent huang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39348/#review102884
---
Ship it!
Ship It!
- haosdent huang
On Oct. 15, 2015, 6:03 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39347/#review102882
---
Ship it!
Ship It!
- haosdent huang
On Oct. 15, 2015, 6:02 p.m
/containerizer/docker.cpp 702295808475c092dff66417f42af89b90e6d50d
Diff: https://reviews.apache.org/r/39386/diff/
Testing
---
* make check
* make install and then test with marathon to check if launcher_dir passes
correctly.
Thanks,
haosdent huang
/health_check_tests.cpp ff6275b19206b49eacb6761f3aeb58dd87651ade
Diff: https://reviews.apache.org/r/39387/diff/
Testing
---
make -j8 check
Thanks,
haosdent huang
/fcntl.hpp (line 103)
<https://reviews.apache.org/r/39347/#comment160694>
Should we split into two function, one for enable, another one for disable.
Because "nosigpipe" for enable looks a bit confuse.
- haosdent huang
On Oct. 15, 2015, 6:02 p.m., J
/pipe.hpp (line 26)
<https://reviews.apache.org/r/39349/#comment160697>
Is it possible to change to "int fildes[2]"
- haosdent huang
On Oct. 15, 2015, 6:03 p.m., James Peach wrote:
>
> ---
> This is an automatically g
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39350/#review102887
---
Ship it!
Ship It!
- haosdent huang
On Oct. 15, 2015, 6:04 p.m
(line 65)
<https://reviews.apache.org/r/39349/#comment160695>
The order here seems not correct. We could follow src/Makefile.am
https://github.com/apache/mesos/blob/master/src/Makefile.am#L512-L515
```
x/a
x/b
x/c
x/a/b
x/a/c
```
- haosdent huang
On O
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39351/#review102890
---
Ship it!
Ship It!
- haosdent huang
On Oct. 15, 2015, 6:05 p.m
erated e-mail. To reply, visit:
> https://reviews.apache.org/r/39494/
> ---
>
> (Updated Oct. 20, 2015, 9:58 p.m.)
>
>
> Review request for mesos, haosdent huang, Joris Van Remoortere, and Neil
> Conway.
>
>
>
eviews.apache.org/r/37024/#review102162
---
On Oct. 8, 2015, 7:01 a.m., haosdent huang wrote:
>
> ---
> This is an automatically generated e-mail. To re
https://issues.apache.org/jira/browse/MESOS-1841
Repository: mesos
Description
---
Add version.cpp to CMakeLists.txt.
Diffs
-
src/CMakeLists.txt 828dbb690841c561816811dfbb044aa3afead89d
Diff: https://reviews.apache.org/r/39212/diff/
Testing
---
Thanks,
haosdent huang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39088/#review102231
---
Ship it!
Ship It!
- haosdent huang
On Oct. 8, 2015, 1:27 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39205/#review102230
---
Ship it!
Ship It!
- haosdent huang
On Oct. 12, 2015, 3:32 a.m
e7dc670648e8abd2fef7be79835f0b71e3e91258
3rdparty/libprocess/src/help.cpp 822c0844c61c7cabfca2b0534a5fb40001bd7cc7
Diff: https://reviews.apache.org/r/39037/diff/
Testing
---
Thanks,
haosdent huang
301 - 400 of 3716 matches
Mail list logo
