Re: Review Request 45852: Added standard metrics for GPU resources.

2016-04-07 Thread haosdent huang
t;mem"] = 0; object.values["disk"] = 0; ``` I saw some field is empty in webui after apply your patch. As you know, if `xxx.resources.gpus` is `undefined`, `+=` would get `NaN`. - haosdent huang On April 7, 2016, 1:54 a.m., Kevin Klues wrote: > > --

Re: Review Request 45852: Added standard metrics for GPU resources.

2016-04-07 Thread haosdent huang
> On April 8, 2016, 2:24 a.m., haosdent huang wrote: > > Do you forgot to update > > ``` > > diff --git a/src/common/http.cpp b/src/common/http.cpp > > index 3748c71..d2f75b0 100644 > > --- a/src/common/http.cpp > > +++ b/src/common/http.cpp > >

Re: Review Request 45083: Added ANY mode to futures collect mechanism.

2016-04-08 Thread haosdent huang
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45083/#review127744 --- On April 7, 2016, 10:36 a.m., haosdent huang wrote: > > ---

Re: Review Request 43523: Speed up SlaveTest.MetricsSlaveLaunchErrors.

2016-04-08 Thread haosdent huang
rd this. - haosdent --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43523/#review127784 --- On Feb. 12, 2016, 8:09 a.m.,

Re: Review Request 43514: Speed up MasterTest.RecoverResources.

2016-04-08 Thread haosdent huang
eviews.apache.org/r/43514/#review127787 --- On Feb. 12, 2016, 6:36 a.m., haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43514/ > ---

Re: Review Request 43515: Speed up MasterTest.MasterInfoOnReElection.

2016-04-08 Thread haosdent huang
8f93fbaf2bfd66bbc144a85c0097f45c55ff3491 Diff: https://reviews.apache.org/r/43515/diff/ Testing (updated) --- Repeat test in CentOS 7.1 ``` sudo ./bin/mesos-tests.sh --gtest_filter="MasterTest.MasterInfoOnReElection" --gtest_repeat=200 --gtest_break_on_failure ``` Thanks, haosdent huang

Re: Review Request 43517: Speed up MasterTest.OfferTimeout.

2016-04-08 Thread haosdent huang
8f93fbaf2bfd66bbc144a85c0097f45c55ff3491 Diff: https://reviews.apache.org/r/43517/diff/ Testing (updated) --- Repeat test in CentOS 7.1 ``` sudo ./bin/mesos-tests.sh --gtest_filter="MasterTest.OfferTimeout" --gtest_repeat=200 --gtest_break_on_failure ``` Thanks, haosdent huang

Re: Review Request 43514: Speed up MasterTest.RecoverResources.

2016-04-08 Thread haosdent huang
8f93fbaf2bfd66bbc144a85c0097f45c55ff3491 Diff: https://reviews.apache.org/r/43514/diff/ Testing (updated) --- Repeat test in CentOS 7.1 ``` sudo ./bin/mesos-tests.sh --gtest_filter="MasterTest.RecoverResources" --gtest_repeat=200 --gtest_break_on_failure ``` Thanks, haosdent huang

Re: Review Request 43516: Speed up MasterTest.LaunchCombinedOfferTest.

2016-04-08 Thread haosdent huang
8f93fbaf2bfd66bbc144a85c0097f45c55ff3491 Diff: https://reviews.apache.org/r/43516/diff/ Testing (updated) --- Repeat test in CentOS 7.1 ``` sudo ./bin/mesos-tests.sh --gtest_filter="MasterTest.LaunchCombinedOfferTest" --gtest_repeat=200 --gtest_break_on_failure ``` Thanks, haosdent huang

Re: Review Request 43515: Speed up MasterTest.MasterInfoOnReElection.

2016-04-08 Thread haosdent huang
Remove it just now. - haosdent --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43515/#review127788 --- On April 8, 2016

Re: Review Request 43516: Speed up MasterTest.LaunchCombinedOfferTest.

2016-04-08 Thread haosdent huang
8f93fbaf2bfd66bbc144a85c0097f45c55ff3491 Diff: https://reviews.apache.org/r/43516/diff/ Testing --- Repeat test in CentOS 7.1 ``` sudo ./bin/mesos-tests.sh --gtest_filter="MasterTest.LaunchCombinedOfferTest" --gtest_repeat=200 --gtest_break_on_failure ``` Thanks, haosdent huang

Re: Review Request 43480: Use in_memory as default registry when testing.

2016-04-08 Thread haosdent huang
enerated e-mail. To reply, visit: https://reviews.apache.org/r/43480/#review127790 --- On Feb. 11, 2016, 4:02 p.m., haosdent huang wrote: > > --- > This is an automatically ge

Re: Review Request 43514: Speed up MasterTest.RecoverResources.

2016-04-08 Thread haosdent huang
s.cpp 8f93fbaf2bfd66bbc144a85c0097f45c55ff3491 Diff: https://reviews.apache.org/r/43514/diff/ Testing --- Repeat test in CentOS 7.1 ``` sudo ./bin/mesos-tests.sh --gtest_filter="MasterTest.RecoverResources" --gtest_repeat=200 --gtest_break_on_failure ``` Thanks, haosdent huang

Re: Review Request 41665: Tests: Use 'in_memory' registry by default for tests.

2016-04-08 Thread haosdent huang
tps://reviews.apache.org/r/41665/#comment191194> Hi, @Joris. I think need update ``` MesosZooKeeperTest::CreateMasterFlags ``` as well. - haosdent huang On Dec. 22, 2015, 10:45 p.m., Joris Van Remoortere wrote: > > ---

Re: Review Request 43522: Speed up OversubscriptionTest.RemoveCapabilitiesOnSchedulerFailover.

2016-04-08 Thread haosdent huang
reak_on_failure ``` Thanks, haosdent huang

Re: Review Request 43514: Speed up MasterTest.RecoverResources.

2016-04-08 Thread haosdent huang
8f93fbaf2bfd66bbc144a85c0097f45c55ff3491 Diff: https://reviews.apache.org/r/43514/diff/ Testing --- Repeat test in CentOS 7.1 ``` sudo ./bin/mesos-tests.sh --gtest_filter="MasterTest.RecoverResources" --gtest_repeat=200 --gtest_break_on_failure ``` Thanks, haosdent huang

Re: Review Request 43516: Speed up MasterTest.LaunchCombinedOfferTest.

2016-04-08 Thread haosdent huang
/master_tests.cpp 8f93fbaf2bfd66bbc144a85c0097f45c55ff3491 Diff: https://reviews.apache.org/r/43516/diff/ Testing --- Repeat test in CentOS 7.1 ``` sudo ./bin/mesos-tests.sh --gtest_filter="MasterTest.LaunchCombinedOfferTest" --gtest_repeat=200 --gtest_break_on_failure ``` Thanks, haosdent huang

Re: Review Request 43522: Speed up OversubscriptionTest.RemoveCapabilitiesOnSchedulerFailover.

2016-04-08 Thread haosdent huang
test_repeat=200 --gtest_break_on_failure ``` Thanks, haosdent huang

Re: Review Request 43521: Speed up OversubscriptionTest.UpdateAllocatorOnSchedulerFailover.

2016-04-08 Thread haosdent huang
erFailover" --gtest_repeat=200 --gtest_break_on_failure ``` Thanks, haosdent huang

Re: Review Request 43520: Speed up GarbageCollectorIntegrationTest.Restart.

2016-04-08 Thread haosdent huang
reak_on_failure ``` Thanks, haosdent huang

Re: Review Request 43522: Speed up OversubscriptionTest.RemoveCapabilitiesOnSchedulerFailover.

2016-04-08 Thread haosdent huang
repeat=200 --gtest_break_on_failure ``` Thanks, haosdent huang

Re: Review Request 43520: Speed up GarbageCollectorIntegrationTest.Restart.

2016-04-08 Thread haosdent huang
on_failure ``` Thanks, haosdent huang

Re: Review Request 43516: Speed up MasterTest.LaunchCombinedOfferTest.

2016-04-08 Thread haosdent huang
/master_tests.cpp 8f93fbaf2bfd66bbc144a85c0097f45c55ff3491 Diff: https://reviews.apache.org/r/43516/diff/ Testing --- Repeat test in CentOS 7.1 ``` sudo ./bin/mesos-tests.sh --gtest_filter="MasterTest.LaunchCombinedOfferTest" --gtest_repeat=200 --gtest_break_on_failure ``` Thanks, haosdent huang

Re: Review Request 43515: Speed up MasterTest.MasterInfoOnReElection.

2016-04-08 Thread haosdent huang
/master_tests.cpp 8f93fbaf2bfd66bbc144a85c0097f45c55ff3491 Diff: https://reviews.apache.org/r/43515/diff/ Testing --- Repeat test in CentOS 7.1 ``` sudo ./bin/mesos-tests.sh --gtest_filter="MasterTest.MasterInfoOnReElection" --gtest_repeat=200 --gtest_break_on_failure ``` Thanks, haosdent huang

Re: Review Request 42441: Speed up ExamplesTest test cases.

2016-04-09 Thread haosdent huang
/diff/ Testing (updated) --- Repeat test in CentOS 7.1 ``` $ sudo ./bin/mesos-tests.sh --gtest_filter="ExamplesTest.*" --gtest_repeat=200 --gtest_break_on_failure ``` Thanks, haosdent huang

Re: Review Request 43558: Speed up ExamplesTest.PersistentVolumeFramework.

2016-04-09 Thread haosdent huang
ilter="ExamplesTest.PersistentVolumeFramework" --gtest_repeat=200 --gtest_break_on_failure ``` Thanks, haosdent huang

Re: Review Request 43472: Speed up ZooKeeperTest.LeaderContender by advance Clock.

2016-04-10 Thread haosdent huang
ure ``` Before ``` [ OK ] ZooKeeperTest.LeaderContender (3385 ms) ``` After ``` [ OK ] ZooKeeperTest.LeaderContender (694 ms) ``` Thanks, haosdent huang

Re: Review Request 43473: Speed up ContenderDetectorShutdownNetwork by advance Clock.

2016-04-10 Thread haosdent huang
ownNetwork " --verbose --gtest_repeat=200 --gtest_break_on_failure ``` Before ``` [ OK ] ZooKeeperMasterContenderDetectorTest.ContenderDetectorShutdownNetwork (3390 ms) ``` After ``` [ OK ] ZooKeeperMasterContenderDetectorTest.ContenderDetectorShutdownNetwork (546 ms) ``` Thanks, haosdent huang

Re: Review Request 43474: Speed up MasterDetectorExpireSlaveZKSession by advance Clock.

2016-04-10 Thread haosdent huang
s) ``` Thanks, haosdent huang

Re: Review Request 43477: Speed up GroupTest.* test cases by advance clock.

2016-04-10 Thread haosdent huang
``` [ OK ] GroupTest.GroupJoinWithDisconnect (405 ms) [ OK ] GroupTest.GroupDataWithDisconnect (192 ms) [ OK ] GroupTest.GroupCancelWithDisconnect (250 ms) [ OK ] GroupTest.GroupPathWithRestrictivePerms (334 ms) [ OK ] GroupTest.RetryableErrors (341 ms) ``` Thanks, haosdent huang

Re: Review Request 43475: Speed up MasterDetectorExpireSlaveZKSessionNewMaster by advance Clock.

2016-04-10 Thread haosdent huang
``` [ OK ] ZooKeeperMasterContenderDetectorTest.MasterDetectorExpireSlaveZKSessionNewMaster (613 ms) ``` Thanks, haosdent huang

Re: Review Request 43471: Add the zookeeper patch for the allow add_auth calls.

2016-04-10 Thread haosdent huang
` Thanks, haosdent huang

Re: Review Request 43471: Add the zookeeper patch for the allow add_auth calls.

2016-04-10 Thread haosdent huang
) [ OK ] ZooKeeperTest.Auth (233 ms) [ OK ] ZooKeeperTest.Create (275 ms) ``` Thanks, haosdent huang

Re: Review Request 43471: Add the zookeeper patch for the allow add_auth calls.

2016-04-10 Thread haosdent huang
` Thanks, haosdent huang

Re: Review Request 45855: Updated docs to include references to GPUs as a first class resource.

2016-04-10 Thread haosdent huang
> On April 7, 2016, 2:13 a.m., haosdent huang wrote: > > docs/attributes-resources.md, line 40 > > <https://reviews.apache.org/r/45855/diff/1/?file=1329266#file1329266line40> > > > > `whole number values` means `natural number` here? > > Kevin Klues

Re: Review Request 43477: Speed up GroupTest.* test cases by advance clock.

2016-04-10 Thread haosdent huang
------ This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43477/#review128032 --- On April 10, 2016, 10:19 a.m., haosdent huang wrote: > > -

Re: Review Request 45084: Add `Subsystem` abstraction for cgroups.

2016-04-10 Thread haosdent huang
he dependencies. - haosdent --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45084/#review127895 --- On April 7, 2016, 10

Re: Review Request 45083: Added ANY mode to futures collect mechanism.

2016-04-10 Thread haosdent huang
ocess/include/process/collect.hpp 5a92b72eb7668494dc832ec446a41b3d673a20cc 3rdparty/libprocess/src/tests/collect_tests.cpp 155e0bb75cf723a0a6c29020f9f767e3ba3d7401 Diff: https://reviews.apache.org/r/45083/diff/ Testing --- Thanks, haosdent huang

Re: Review Request 45086: Enable cgroups unified isolator in isolation.

2016-04-10 Thread haosdent huang
, haosdent huang

Re: Review Request 44893: Remove fetcher header file in containerizer.hpp.

2016-04-10 Thread haosdent huang
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44893/#review127894 --- On April 3, 2016, 2:12 p.m., haosdent huang wrote: > > --

Re: Review Request 45350: Add `--cgroups_subsystems` in agent flags.

2016-04-10 Thread haosdent huang
eviews.apache.org/r/45350/#review127938 --- On April 7, 2016, 10:40 a.m., haosdent huang wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 44379: Use tokens size to parse perf stat format.

2016-04-11 Thread haosdent huang
, this patch should credited by you, please update the description and remove my name. Quite appreciated your great help again so that I could rebase my patches depend on this. - haosdent huang On April 11, 2016, 7:01 a.m., fan du wrote

Re: Review Request 45084: Added stubs for the `Subsystem` abstraction of cgroups unified isolator.

2016-04-11 Thread haosdent huang
ators/cgroups/subsystem.hpp PRE-CREATION src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp PRE-CREATION Diff: https://reviews.apache.org/r/45084/diff/ Testing --- Thanks, haosdent huang

Review Request 46043: Completed default implementation of `Subsystem` abstraction.

2016-04-11 Thread haosdent huang
://reviews.apache.org/r/46043/diff/ Testing --- Thanks, haosdent huang

Re: Review Request 45085: Added stubs for the cgroups unified isolator.

2016-04-11 Thread haosdent huang
rizer/mesos/isolators/cgroups/cgroups.cpp PRE-CREATION Diff: https://reviews.apache.org/r/45085/diff/ Testing --- Thanks, haosdent huang

Review Request 46106: Update RemoveCapabilitiesOnSchedulerFailover to use await exactly.

2016-04-12 Thread haosdent huang
` Thanks, haosdent huang

Re: Review Request 45083: Added ANY mode to futures collect mechanism.

2016-04-13 Thread haosdent huang
/collect.hpp 5a92b72eb7668494dc832ec446a41b3d673a20cc 3rdparty/libprocess/src/tests/collect_tests.cpp 155e0bb75cf723a0a6c29020f9f767e3ba3d7401 Diff: https://reviews.apache.org/r/45083/diff/ Testing --- Thanks, haosdent huang

Re: Review Request 45084: Added stubs for the `Subsystem` abstraction of cgroups unified isolator.

2016-04-13 Thread haosdent huang
://reviews.apache.org/r/45084/diff/ Testing --- Thanks, haosdent huang

Re: Review Request 46043: Completed default implementation of `Subsystem` abstraction.

2016-04-13 Thread haosdent huang
/containerizer/mesos/isolators/cgroups/subsystem.cpp PRE-CREATION Diff: https://reviews.apache.org/r/46043/diff/ Testing --- Thanks, haosdent huang

Re: Review Request 45085: Added stubs for the cgroups unified isolator.

2016-04-13 Thread haosdent huang
--- Thanks, haosdent huang

Re: Review Request 45362: Add `cgroups::memory::pressure::Counter::snapshot` method.

2016-04-13 Thread haosdent huang
5f4010734ed9e3295dcc3a4390123e4f4ce99c16 src/linux/cgroups.cpp b57ec05d3e0bf0bc1bf50fca9a9ede767f204253 Diff: https://reviews.apache.org/r/45362/diff/ Testing --- Thanks, haosdent huang

Re: Review Request 45363: Add `MemorySubsystem` for cgroups unified isolator.

2016-04-13 Thread haosdent huang
/isolators/cgroups/cgroups.cpp PRE-CREATION src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp PRE-CREATION src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp PRE-CREATION Diff: https://reviews.apache.org/r/45363/diff/ Testing --- Thanks, haosdent huang

Review Request 46158: Completed implementation of the cgroups unified isolator.

2016-04-13 Thread haosdent huang
://reviews.apache.org/r/46158/diff/ Testing --- Thanks, haosdent huang

Re: Review Request 45087: Add `CpuSubsystem` for cgroups unified isolator.

2016-04-13 Thread haosdent huang
/isolators/cgroups/cgroups.cpp PRE-CREATION src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp PRE-CREATION src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp PRE-CREATION Diff: https://reviews.apache.org/r/45087/diff/ Testing --- Thanks, haosdent huang

Re: Review Request 45472: Add `NetClsSubsystem` for cgroups unified isolator.

2016-04-13 Thread haosdent huang
, haosdent huang

Re: Review Request 45574: Add `PerfEventSubsystem` for cgroups unified isolator.

2016-04-13 Thread haosdent huang
/r/45574/diff/ Testing --- Thanks, haosdent huang

Re: Review Request 45573: Add `PerfEventHandleManager`.

2016-04-13 Thread haosdent huang
--- Thanks, haosdent huang

Re: Review Request 45352: Add `CpuacctSubsystem` for cgroups unified isolator.

2016-04-13 Thread haosdent huang
/isolators/cgroups/cgroups.cpp PRE-CREATION src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp PRE-CREATION src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp PRE-CREATION Diff: https://reviews.apache.org/r/45352/diff/ Testing --- Thanks, haosdent huang

Re: Review Request 45083: Added ANY mode to futures collect mechanism.

2016-04-16 Thread haosdent huang
/collect.hpp 5a92b72eb7668494dc832ec446a41b3d673a20cc 3rdparty/libprocess/src/tests/collect_tests.cpp 155e0bb75cf723a0a6c29020f9f767e3ba3d7401 Diff: https://reviews.apache.org/r/45083/diff/ Testing --- Thanks, haosdent huang

Re: Review Request 45084: Added stubs for the `Subsystem` abstraction of cgroups unified isolator.

2016-04-16 Thread haosdent huang
://reviews.apache.org/r/45084/diff/ Testing --- Thanks, haosdent huang

Re: Review Request 46043: Completed default implementation of `Subsystem` abstraction.

2016-04-16 Thread haosdent huang
/containerizer/mesos/isolators/cgroups/subsystem.cpp PRE-CREATION Diff: https://reviews.apache.org/r/46043/diff/ Testing --- Thanks, haosdent huang

Re: Review Request 45085: Added stubs for the cgroups unified isolator.

2016-04-16 Thread haosdent huang
--- Thanks, haosdent huang

Re: Review Request 45086: Enable cgroups unified isolator in isolation.

2016-04-16 Thread haosdent huang
c25fa92d2a5fa9c828e77c3c0f8b1f795d1b8440 Diff: https://reviews.apache.org/r/45086/diff/ Testing --- Thanks, haosdent huang

Re: Review Request 46158: Completed implementation of the cgroups unified isolator.

2016-04-16 Thread haosdent huang
/mesos/isolators/cgroups/cgroups.cpp PRE-CREATION Diff: https://reviews.apache.org/r/46158/diff/ Testing --- Thanks, haosdent huang

Re: Review Request 45087: Add `CpuSubsystem` for cgroups unified isolator.

2016-04-16 Thread haosdent huang
/isolators/cgroups/cgroups.cpp PRE-CREATION src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp PRE-CREATION src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp PRE-CREATION Diff: https://reviews.apache.org/r/45087/diff/ Testing --- Thanks, haosdent huang

Re: Review Request 45352: Add `CpuacctSubsystem` for cgroups unified isolator.

2016-04-16 Thread haosdent huang
/cgroups.cpp PRE-CREATION src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp PRE-CREATION src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp PRE-CREATION Diff: https://reviews.apache.org/r/45352/diff/ Testing --- Thanks, haosdent huang

Re: Review Request 45363: Add `MemorySubsystem` for cgroups unified isolator.

2016-04-16 Thread haosdent huang
/isolators/cgroups/cgroups.cpp PRE-CREATION src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp PRE-CREATION src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp PRE-CREATION Diff: https://reviews.apache.org/r/45363/diff/ Testing --- Thanks, haosdent huang

Re: Review Request 45364: Migrate test cases for `memory` subsystem to cgroups unified isolator.

2016-04-16 Thread haosdent huang
/cgroups_isolator_tests.cpp c4e467c8227f9e4129b05d173812592f39a04e06 Diff: https://reviews.apache.org/r/45364/diff/ Testing --- Thanks, haosdent huang

Re: Review Request 45362: Add `cgroups::memory::pressure::Counter::snapshot` method.

2016-04-16 Thread haosdent huang
5f4010734ed9e3295dcc3a4390123e4f4ce99c16 src/linux/cgroups.cpp b57ec05d3e0bf0bc1bf50fca9a9ede767f204253 Diff: https://reviews.apache.org/r/45362/diff/ Testing --- Thanks, haosdent huang

Re: Review Request 45472: Add `NetClsSubsystem` for cgroups unified isolator.

2016-04-16 Thread haosdent huang
, haosdent huang

Re: Review Request 45573: Add `PerfEventHandleManager`.

2016-04-16 Thread haosdent huang
/perf_event.hpp 65e731886b9e5cac07ae3ad6398faf8f50de5650 src/slave/containerizer/mesos/isolators/cgroups/perf_event.cpp 5ef4ae5c468580352cd16e7716b9ca4c0acde659 Diff: https://reviews.apache.org/r/45573/diff/ Testing --- Thanks, haosdent huang

Re: Review Request 45575: Migrate test cases for `perf_event` subsystem to cgroups_isolator_tests.

2016-04-16 Thread haosdent huang
/cgroups_isolator_tests.cpp c4e467c8227f9e4129b05d173812592f39a04e06 Diff: https://reviews.apache.org/r/45575/diff/ Testing --- Thanks, haosdent huang

Re: Review Request 45574: Add `PerfEventSubsystem` for cgroups unified isolator.

2016-04-16 Thread haosdent huang
/r/45574/diff/ Testing --- Thanks, haosdent huang

Re: Review Request 45362: Add `cgroups::memory::pressure::Counter::snapshot` method.

2016-04-16 Thread haosdent huang
5f4010734ed9e3295dcc3a4390123e4f4ce99c16 src/linux/cgroups.cpp b57ec05d3e0bf0bc1bf50fca9a9ede767f204253 Diff: https://reviews.apache.org/r/45362/diff/ Testing --- Thanks, haosdent huang

Re: Review Request 45352: Add `CpuacctSubsystem` for cgroups unified isolator.

2016-04-16 Thread haosdent huang
/mesos/isolators/cgroups/cgroups.cpp PRE-CREATION src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp PRE-CREATION src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp PRE-CREATION Diff: https://reviews.apache.org/r/45352/diff/ Testing --- Thanks, haosdent huang

Re: Review Request 45087: Add `CpuSubsystem` for cgroups unified isolator.

2016-04-16 Thread haosdent huang
/isolators/cgroups/cgroups.cpp PRE-CREATION src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp PRE-CREATION src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp PRE-CREATION Diff: https://reviews.apache.org/r/45087/diff/ Testing --- Thanks, haosdent huang

Re: Review Request 45363: Add `MemorySubsystem` for cgroups unified isolator.

2016-04-16 Thread haosdent huang
/isolators/cgroups/cgroups.cpp PRE-CREATION src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp PRE-CREATION src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp PRE-CREATION Diff: https://reviews.apache.org/r/45363/diff/ Testing --- Thanks, haosdent huang

Review Request 46299: Ignore eventfd caused by hierarchy destruction.

2016-04-16 Thread haosdent huang
/diff/ Testing --- Thanks, haosdent huang

Re: Review Request 45573: Add `PerfEventHandleManager`.

2016-04-16 Thread haosdent huang
/perf_event.hpp 65e731886b9e5cac07ae3ad6398faf8f50de5650 src/slave/containerizer/mesos/isolators/cgroups/perf_event.cpp 5ef4ae5c468580352cd16e7716b9ca4c0acde659 Diff: https://reviews.apache.org/r/45573/diff/ Testing --- Thanks, haosdent huang

Re: Review Request 45574: Add `PerfEventSubsystem` for cgroups unified isolator.

2016-04-16 Thread haosdent huang
/r/45574/diff/ Testing --- Thanks, haosdent huang

Re: Review Request 45472: Add `NetClsSubsystem` for cgroups unified isolator.

2016-04-16 Thread haosdent huang
, haosdent huang

Re: Review Request 45086: Enable cgroups unified isolator in isolation.

2016-04-16 Thread haosdent huang
/containerizer/mesos/containerizer.cpp 1e1a36903f4377497bb72b69e4ead63675d453c0 Diff: https://reviews.apache.org/r/45086/diff/ Testing --- Thanks, haosdent huang

Review Request 46300: Wait for process:reap in CGROUPS_ROOT_PerfRollForward.

2016-04-16 Thread haosdent huang
: https://reviews.apache.org/r/46300/diff/ Testing --- Thanks, haosdent huang

Re: Review Request 43284: Wait for process:reap in PerfEventIsolatorTest.ROOT_CGROUPS_Sample.

2016-04-16 Thread haosdent huang
. Thanks, haosdent huang

Re: Review Request 45574: Add `PerfEventSubsystem` for cgroups unified isolator.

2016-04-16 Thread haosdent huang
/r/45574/diff/ Testing --- Thanks, haosdent huang

Re: Review Request 43284: Wait for process:reap in PerfEventIsolatorTest.ROOT_CGROUPS_Sample.

2016-04-16 Thread haosdent huang
. Thanks, haosdent huang

Re: Review Request 45086: Enable cgroups unified isolator in isolation.

2016-04-16 Thread haosdent huang
/containerizer/mesos/containerizer.cpp 1e1a36903f4377497bb72b69e4ead63675d453c0 Diff: https://reviews.apache.org/r/45086/diff/ Testing --- Thanks, haosdent huang

Re: Review Request 46300: Wait for process:reap in CGROUPS_ROOT_PerfRollForward.

2016-04-16 Thread haosdent huang
/slave_recovery_tests.cpp 79132344be3bcd2bda54357cd5e7e0c59a766fd8 Diff: https://reviews.apache.org/r/46300/diff/ Testing --- Thanks, haosdent huang

Re: Review Request 44379: Use tokens size to parse perf stat format.

2016-04-16 Thread haosdent huang
} else if ((tokens.size() == 4) || (tokens.size() == 6)) { return Sample({tokens[0], internal::normalize(tokens[2]), tokens[3]}); } ``` - haosdent huang On April 11, 2016, 7:01 a.m., fan du wrote: > > ---

Re: Review Request 44379: Use tokens size to parse perf stat format.

2016-04-16 Thread haosdent huang
> On April 16, 2016, 12:23 p.m., haosdent huang wrote: > > src/linux/perf.cpp, line 346 > > <https://reviews.apache.org/r/44379/diff/3/?file=1339029#file1339029line346> > > > > Hi, @fan.du. I believe @bmahler would like to elaborate more details > > h

Re: Review Request 46298: Rejected relative path agent work_dir.

2016-04-16 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46298/#review129247 --- Ship it! Ship It! - haosdent huang On April 16, 2016, 8:29

Re: Review Request 43520: Speeded up GarbageCollectorIntegrationTest.Restart.

2016-04-16 Thread haosdent huang
--- Repeat test in CentOS 7.1 ``` $ sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="GarbageCollectorIntegrationTest.Restart" --verbose --gtest_repeat=200 --gtest_break_on_failure ``` Thanks, haosdent huang

Re: Review Request 34646: Redirect to the leader master when current master is not a leader.

2016-04-16 Thread haosdent huang
307 Temporary Redirect Date: Mon, 01 Jun 2015 06:30:08 GMT Location: http://master2:5050//master/tasks.json Content-Length: 0 ``` Thanks, haosdent huang

Review Request 46306: Add `HealthCheckTest.HealthyTaskShellEscape`.

2016-04-16 Thread haosdent huang
: mesos Description --- Just for demo, please don't submit it. Diffs - src/tests/health_check_tests.cpp 1c4a554ab07731963a4a38e3ae40b0323bf317bb Diff: https://reviews.apache.org/r/46306/diff/ Testing --- Thanks, haosdent huang

Re: Review Request 36816: Supported HTTP in Mesos health check program.

2016-04-17 Thread haosdent huang
, haosdent huang

Review Request 46307: Ignored subsequent status update in HealthStatusChange tests.

2016-04-17 Thread haosdent huang
/ Testing --- Thanks, haosdent huang

Re: Review Request 46307: Ignored subsequent status update in HealthStatusChange tests.

2016-04-17 Thread haosdent huang
://reviews.apache.org/r/46307/diff/ Testing (updated) --- # I still could not reproduce the problem in old code after repeatedly tests. So seems no way to verify whether my assumption is correct or not. Thanks, haosdent huang

Re: Review Request 46307: Ignored subsequent status update in HealthStatusChange tests.

2016-04-17 Thread haosdent huang
://reviews.apache.org/r/46307/diff/ Testing (updated) --- # I still could not reproduce the problem in old code after repeatedly tests. So seems no way to verify whether my assumption is correct or not. Thanks, haosdent huang

Re: Review Request 46307: Ignored subsequent status update in HealthStatusChange tests.

2016-04-17 Thread haosdent huang
, haosdent huang

Re: Review Request 36816: Supported HTTP in Mesos health check program.

2016-04-18 Thread haosdent huang
http check. I think need make it more readable. - haosdent --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/#review129287 --- On Apr

<    1   2   3   4   5   6   7   8   9   10   >