Re: Review Request 56781: Fixed compilation on VS 2017.

2017-02-17 Thread Alex Clemmer
/future.hpp (line 412) <https://reviews.apache.org/r/56781/#comment237757> Should this be `#endif // __WINDOWS__`? - Alex Clemmer On Feb. 17, 2017, 8:12 a.m., Michael Park wrote: > > --- > This is an automatically g

Re: Review Request 56593: Explicitly marked protobuf files as using v2 syntax.

2017-02-16 Thread Alex Clemmer
c93c7a92ec152bd9747a70392adfe6a0e863e839 Diff: https://reviews.apache.org/r/56593/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 56594: Explicitly marked protobuf files as using v2 syntax.

2017-02-16 Thread Alex Clemmer
--- Thanks, Alex Clemmer

Re: Review Request 56591: Stout: Removed MSVC compiler warnings.

2017-02-15 Thread Alex Clemmer
://reviews.apache.org/r/56591/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 56591: Stout: Removed MSVC compiler warnings.

2017-02-15 Thread Alex Clemmer
. To reply, visit: https://reviews.apache.org/r/56591/#review165596 --- On Feb. 14, 2017, 9:05 a.m., Alex Clemmer wrote: > > --- > This is an automatically generat

Review Request 56702: Windows: Handle environment variable inheritance uniformly in Mesos.

2017-02-15 Thread Alex Clemmer
and resolve this issue. Diffs - src/slave/containerizer/docker.cpp 886528f0f706ef2a3c07246406f3ee1ebc45565d src/slave/containerizer/mesos/launch.cpp 4dd81b47ca4654f5e783a4f2227834e938bc8bb3 Diff: https://reviews.apache.org/r/56702/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 56505: Added Windows support for Docker executor.

2017-02-15 Thread Alex Clemmer
cab24162e26be9fe79c0c65f24e35e3c3d735906 Diff: https://reviews.apache.org/r/56505/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 56505: Added Windows support for Docker executor.

2017-02-15 Thread Alex Clemmer
eviews.apache.org/r/56505/#review165583 --- On Feb. 14, 2017, 7:06 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 56505: Added Windows support for Docker executor.

2017-02-15 Thread Alex Clemmer
ed e-mail. To reply, visit: https://reviews.apache.org/r/56505/#review165583 --- On Feb. 14, 2017, 7:06 p.m., Alex Clemmer wrote: > > --- > This is an automatically

Review Request 56689: Windows: Prevented crash if sandbox `stdout` file already exists.

2017-02-14 Thread Alex Clemmer
1b5ae5e3ee3c08d05afa1bc533542f42fe26eed0 Diff: https://reviews.apache.org/r/56689/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 56504: Stout: Made `os::mktemp` fully cross-platform.

2017-02-14 Thread Alex Clemmer
nks for being thorough! - Alex --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56504/#review165582 --- On Feb. 9, 2017, 5:57 p.m., Alex Clemmer wrote: > > ---

Re: Review Request 56505: Added Windows support for Docker executor.

2017-02-14 Thread Alex Clemmer
--- Thanks, Alex Clemmer

Re: Review Request 55547: Windows: Standardize on win32 environment, transition away from CRT.

2017-02-14 Thread Alex Clemmer
rocess. - Alex --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55547/#review162754 --- On Feb. 14, 2017, 6:47 p.m., Alex Clemmer wrote: >

Re: Review Request 55547: Windows: Standardize on win32 environment, transition away from CRT.

2017-02-14 Thread Alex Clemmer
/diff/ Testing --- Thanks, Alex Clemmer

Review Request 56675: Silence MSVC compiler warnings in libmesos.

2017-02-14 Thread Alex Clemmer
b6f76824c20c842d8f1d8afb1f9b81668b6741da src/tests/values_tests.cpp cc17b675d5d3768685b44a1cea64264dcbca80ba src/zookeeper/zookeeper.cpp 5ede4e5c47b30693ef9f296777dea8db2c4a48d8 Diff: https://reviews.apache.org/r/56675/diff/ Testing --- Thanks, Alex Clemmer

Review Request 56652: Windows: Change ZK patch to fix macro redefinition warnings on MSVC.

2017-02-14 Thread Alex Clemmer
, allowing the patches to apply cleanly. Diffs - 3rdparty/zookeeper-06d3f3f.patch be2ceaf529895c92dcf53984d6d88c78fb1d74ec Diff: https://reviews.apache.org/r/56652/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 56591: Stout: Removed MSVC compiler warnings.

2017-02-14 Thread Alex Clemmer
://reviews.apache.org/r/56591/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 56592: Libprocess: Removed MSVC compiler warnings.

2017-02-14 Thread Alex Clemmer
/libprocess/include/process/network.hpp 0590e7a67275b9e37af2a49c050daab5eeaee7a5 3rdparty/libprocess/src/encoder.hpp b019bf90c0aabbce50d90f5ed6f3fd25d725e542 Diff: https://reviews.apache.org/r/56592/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 55749: Added CMake to standard documentation.

2017-02-13 Thread Alex Clemmer
-cmake.md PRE-CREATION docs/configuration.md 656aaa34915eaee91d388febbc7574287b9f51b5 docs/home.md 091dae20b0a26aac03186edaefab93c54b3063b4 Diff: https://reviews.apache.org/r/55749/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 55030: CMake: Added source groups for libprocess build.

2017-02-13 Thread Alex Clemmer
c65c7f5a97817f4a790136e97eb9f02c0bf810b9 Diff: https://reviews.apache.org/r/55030/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 56505: Added Windows support for Docker executor.

2017-02-13 Thread Alex Clemmer
4dd81b47ca4654f5e783a4f2227834e938bc8bb3 src/slave/flags.cpp 71935dea0f898d4594de9a5d8a3d1c7fc1a21606 src/tests/flags.hpp cab24162e26be9fe79c0c65f24e35e3c3d735906 Diff: https://reviews.apache.org/r/56505/diff/ Testing --- Thanks, Alex Clemmer

Review Request 56594: Explicitly marked protobuf files as using v2 syntax.

2017-02-13 Thread Alex Clemmer
- 3rdparty/stout/tests/protobuf_tests.proto 229ac256b087d55ecc95636254261ecd12829187 Diff: https://reviews.apache.org/r/56594/diff/ Testing --- Thanks, Alex Clemmer

Review Request 56593: Explicitly marked protobuf files as using v2 syntax.

2017-02-13 Thread Alex Clemmer
/cni/spec.proto 4b3850037ec01969cabf16b94745c1802bf4de62 src/slave/containerizer/mesos/provisioner/docker/message.proto c93c7a92ec152bd9747a70392adfe6a0e863e839 Diff: https://reviews.apache.org/r/56593/diff/ Testing --- Thanks, Alex Clemmer

Review Request 56592: Libprocess: Removed MSVC compiler warnings.

2017-02-13 Thread Alex Clemmer
. Repository: mesos Description --- Libprocess: Removed MSVC compiler warnings. Diffs - 3rdparty/libprocess/include/process/metrics/counter.hpp a13cc7e18c8b23eae83c326d63874d9d2aaedc0d Diff: https://reviews.apache.org/r/56592/diff/ Testing --- Thanks, Alex Clemmer

Review Request 56591: Stout: Removed MSVC compiler warnings.

2017-02-13 Thread Alex Clemmer
fddaaa54deaea5e6ef3947142870c7fef76e76aa 3rdparty/stout/include/stout/protobuf.hpp c0f03bc547cddba29309c429b34a0c1e6015c8ea 3rdparty/stout/include/stout/windows/os.hpp b5172fca96c4151f4b1ebb6d343022558f45fc34 Diff: https://reviews.apache.org/r/56591/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 55543: Fail the build if %PreferredToolArchitecture% is not set to `x64`.

2017-02-11 Thread Alex Clemmer
gure.cmake 560935b81603dc58c167918d36e2ae0a4060673d src/CMakeLists.txt 3a4ace9c8011ac8eec5067cd085fa7fe4166b9ee src/slave/cmake/AgentConfigure.cmake 8d930d329048440d57b621fe8393b11912cdb27b Diff: https://reviews.apache.org/r/55543/diff/ Testing --- Thanks, Alex Clemmer

Review Request 56504: Stout: Made `os::mktemp` fully cross-platform.

2017-02-09 Thread Alex Clemmer
: mesos Description --- Stout: Made `os::mktemp` fully cross-platform. Diffs - 3rdparty/stout/include/stout/os/mktemp.hpp 231234f7652937e042f49b13fe8fc3c7193d26e1 Diff: https://reviews.apache.org/r/56504/diff/ Testing --- Thanks, Alex Clemmer

Review Request 56505: Added Windows support for Docker executor.

2017-02-09 Thread Alex Clemmer
/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 56364: Windows: Stout: Rewrite Job Object wrappers.

2017-02-07 Thread Alex Clemmer
, 2:31 a.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56364/ > --- > > (Updated Feb. 7, 2017, 2:31 a.m.) > > > Revi

Re: Review Request 56364: Windows: Stout: Rewrite Job Object wrappers.

2017-02-07 Thread Alex Clemmer
erated e-mail. To reply, visit: > https://reviews.apache.org/r/56364/ > --- > > (Updated Feb. 7, 2017, 2:31 a.m.) > > > Review request for mesos, Alex Clemmer and Joseph Wu. > > > Bugs: MESOS-6892 > h

Re: Review Request 56347: Stout: Explicitly delete `SharedHandle` default constructor.

2017-02-07 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56347/#review164634 --- Ship it! Ship It! - Alex Clemmer On Feb. 6, 2017, 10:56 p.m

Re: Review Request 56354: Fixed incorrect `CHECK_EQ`s in `WindowsFD`.

2017-02-06 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56354/#review164425 --- Ship it! Ship It! - Alex Clemmer On Feb. 6, 2017, 11:23 p.m

Re: Review Request 54595: Introduced an `os::dup` abstraction in stout.

2017-02-05 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54595/#review164304 --- Ship it! Ship It! - Alex Clemmer On Feb. 6, 2017, 2:14 a.m

Re: Review Request 54591: Introduced `WindowsFD` class which is analogous to an `int` in POSIX.

2017-02-05 Thread Alex Clemmer
ugh, and accomplishes the goals that are important to the project. - Alex Clemmer On Feb. 6, 2017, 1:04 a.m., Michael Park wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apa

Re: Review Request 54591: Introduced `WindowsFD` class which is analogous to an `int` in POSIX.

2017-02-05 Thread Alex Clemmer
> On Feb. 5, 2017, 8:48 a.m., Alex Clemmer wrote: > > 3rdparty/stout/include/stout/os/windows/fd.hpp, line 59 > > <https://reviews.apache.org/r/54591/diff/7/?file=1624392#file1624392line59> > > > > I'm not super up on the semantics of these newfang

Re: Review Request 54601: Replaced `int` with `int_fd` in stout.

2017-02-05 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54601/#review164280 --- Ship it! Ship It! - Alex Clemmer On Feb. 5, 2017, 1:39 a.m

Re: Review Request 54762: Introduced an `os::pipe` abstraction to stout.

2017-02-05 Thread Alex Clemmer
`ErrnoError` is usually only for CRT functions, while `WindowsError` also captures win32 error codes. - Alex Clemmer On Feb. 5, 2017, 1:38 a.m., Michael Park wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 54592: Introduced an `os::lseek` abstraction in stout.

2017-02-05 Thread Alex Clemmer
os/lseek.hpp (line 26) <https://reviews.apache.org/r/54592/#comment235952> Since the Windows signature uses `long` instead of `off_t`, I wonder if it is appropriate to do a `static_assert` to verify they're appropriately convertable? - Alex Clemmer On Feb. 5, 2017, 1:38 a.m.,

Re: Review Request 54595: Introduced an `os::dup` abstraction in stout.

2017-02-05 Thread Alex Clemmer
_per se_, I think it is probably more correct to write `result == -1`. 3rdparty/stout/include/stout/os/windows/dup.hpp (line 37) <https://reviews.apache.org/r/54595/#comment235949> Tiny, tiny nit: we're prefixing other global-scope functions with `::`. Should this one be, too? - Alex Clemmer

Re: Review Request 54591: Introduced `WindowsFD` class which is analogous to an `int` in POSIX.

2017-02-05 Thread Alex Clemmer
tps://reviews.apache.org/r/54591/#comment235945> Oh, also, don't we need to add all of these headers to the `Makefile.am`? - Alex Clemmer On Feb. 5, 2017, 1:36 a.m., Michael Park wrote: > > --- > This is an automatically generated e

Re: Review Request 54591: Introduced `WindowsFD` class which is analogous to an `int` in POSIX.

2017-02-05 Thread Alex Clemmer
ppropriate to do a `static_assert` to make sure `HANDLE` is unsigned in the future, too? 3rdparty/stout/include/stout/os/windows/fd.hpp (line 311) <https://reviews.apache.org/r/54591/#comment235943> Just for my own education, we are doing a `reinterpret_cast` here? Can we not just `static

Re: Review Request 54601: Replaced `int` with `int_fd` in stout.

2017-02-02 Thread Alex Clemmer
s also seems to be not a correct comparison? See the comment in `io::read` in https://reviews.apache.org/r/54602/ - Alex Clemmer On Jan. 10, 2017, 2:49 a.m., Michael Park wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 54602: Replaced `int` with `int_fd` in libprocess.

2017-02-02 Thread Alex Clemmer
1457) <https://reviews.apache.org/r/54602/#comment235525> This also seems to be not a correct comparison? See the comment in `io::read`. - Alex Clemmer On Jan. 10, 2017, 2:50 a.m., Michael Park wrote: > > --- > This is an aut

Re: Review Request 55749: Added CMake to standard documentation.

2017-01-28 Thread Alex Clemmer
2113d06f58dddc0a28ae1241a24096266fe39801 Diff: https://reviews.apache.org/r/55749/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 55546: Added platform-independent constants `DEV_NULL` and `TRUE_COMMAND`.

2017-01-28 Thread Alex Clemmer
/stout/include/stout/os/constants.hpp c71d52e1bc0433f9922f26a6eb486235bb9880d4 Diff: https://reviews.apache.org/r/55546/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 55543: Fail the build if %PreferredToolArchitecture% is not set to `x64`.

2017-01-28 Thread Alex Clemmer
gure.cmake 560935b81603dc58c167918d36e2ae0a4060673d Diff: https://reviews.apache.org/r/55543/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 55162: Stout: Added style fixes and some useful error messages.

2017-01-28 Thread Alex Clemmer
/stout/include/stout/windows/os.hpp 5cd92545a49648e39e8eb7cf131895e9cfc97902 Diff: https://reviews.apache.org/r/55162/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 55030: CMake: Added source groups for libprocess build.

2017-01-28 Thread Alex Clemmer
n automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55030/#review162883 --- On Jan. 29, 2017, 7:18 a.m., Alex Clemmer wrote: > > --- > This is an auto

Re: Review Request 55030: CMake: Added source groups for libprocess build.

2017-01-28 Thread Alex Clemmer
b298bbe042cabcb18169da1923562e9956374232 Diff: https://reviews.apache.org/r/55030/diff/ Testing --- Thanks, Alex Clemmer

Review Request 56037: CMake: Bumped CMake version on Windows, and enforce with check.

2017-01-27 Thread Alex Clemmer
/ Testing --- Thanks, Alex Clemmer

Re: Review Request 55600: CMake: Transitioned Stout to automatic source grouping.

2017-01-27 Thread Alex Clemmer
> On Jan. 25, 2017, 12:27 a.m., Joseph Wu wrote: > > 3rdparty/stout/cmake/StoutConfigure.cmake, line 47 > > <https://reviews.apache.org/r/55600/diff/2/?file=1606435#file1606435line47> > > > > Why not use `*.hpp` instead? > > Alex Clemmer wrote: >

Re: Review Request 55607: CMake: Added configuration of test scripts in the bin/ directory.

2017-01-26 Thread Alex Clemmer
ce127e1e8c5c33ad8badef6fb3ac9f50ade9056f Diff: https://reviews.apache.org/r/55607/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 55607: CMake: Added configuration of test scripts in the bin/ directory.

2017-01-26 Thread Alex Clemmer
e files when the underlying ones get > > changed. It does suck, but I'm not sure what the alternatives are. - Alex --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55607

Re: Review Request 55599: CMake: Added `GroupSource` function to automate IDE source grouping.

2017-01-26 Thread Alex Clemmer
://reviews.apache.org/r/55599/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 55599: CMake: Added `GroupSource` function to automate IDE source grouping.

2017-01-26 Thread Alex Clemmer
Here, though, you are right, it's not necessary. It is sufficient to have 4, which will evaluate to 2 literal backslash characters. [1] https://issues.apache.org/jira/browse/MESOS-6736 - Alex --- This is an automaticall

Re: Review Request 55600: CMake: Transitioned Stout to automatic source grouping.

2017-01-26 Thread Alex Clemmer
one pattern everywhere. - Alex --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55600/#review162882 --- On Jan. 17, 20

Re: Review Request 55549: Windows: Added health checker to build.

2017-01-26 Thread Alex Clemmer
/55549/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 55549: Windows: Added health checker to build.

2017-01-26 Thread Alex Clemmer
To reply, visit: https://reviews.apache.org/r/55549/#review162853 ------- On Jan. 15, 2017, 9:35 p.m., Alex Clemmer wrote: > > --- > This is an automatica

Re: Review Request 55037: Added default PATH value in `launch.cpp` for Windows case.

2017-01-20 Thread Alex Clemmer
---- On Jan. 19, 2017, 2:13 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55037/ > -

Review Request 55749: Added CMake to standard documentation.

2017-01-19 Thread Alex Clemmer
--- Thanks, Alex Clemmer

Review Request 55748: CMake: Deleted spurious configuration settings in agent and master.

2017-01-19 Thread Alex Clemmer
: https://reviews.apache.org/r/55748/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 55037: Added default PATH value in `launch.cpp` for Windows case.

2017-01-18 Thread Alex Clemmer
--- Thanks, Alex Clemmer

Re: Review Request 55037: Added default PATH value in `launch.cpp` for Windows case.

2017-01-18 Thread Alex Clemmer
a54106dc4893bb222f42ede936ac9029e817faf9 Diff: https://reviews.apache.org/r/55037/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 55037: Added default PATH value in `launch.cpp` for Windows case.

2017-01-18 Thread Alex Clemmer
/containerizer/mesos/utils.hpp a54106dc4893bb222f42ede936ac9029e817faf9 Diff: https://reviews.apache.org/r/55037/diff/ Testing --- Thanks, Alex Clemmer

Review Request 55699: Stout: Added `host_default_path`.

2017-01-18 Thread Alex Clemmer
/r/55699/diff/ Testing --- Thanks, Alex Clemmer

Review Request 55694: CMake: Separated Stout system headers from Stout API headers.

2017-01-18 Thread Alex Clemmer
bc27ac687bae4e1798eece562027ba33c6b32348 3rdparty/stout/cmake/StoutTestsConfigure.cmake d3bd72e8eba77213095da6cabb3a6d6f4d30941c 3rdparty/stout/tests/CMakeLists.txt a8a3ac772aa243c848a6fd8d7a0d45acfe1b98ae Diff: https://reviews.apache.org/r/55694/diff/ Testing --- Thanks, Alex Clemmer

Review Request 55695: CMake: Separated Libprocess system headers from Libprocess API headers.

2017-01-18 Thread Alex Clemmer
/libprocess/src/CMakeLists.txt 60f0e76dfd237d9a12a366b413802d1a96892b55 Diff: https://reviews.apache.org/r/55695/diff/ Testing --- Thanks, Alex Clemmer

Review Request 55696: CMake: Separated Mesos system headers from Mesos API headers.

2017-01-18 Thread Alex Clemmer
src/tests/cmake/MesosTestsConfigure.cmake 8d416388a8e45a2832ae3841b58541ba5b0613bc Diff: https://reviews.apache.org/r/55696/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 55637: CMake: Added `test` target.

2017-01-18 Thread Alex Clemmer
c6b1eb6a7c7e6ed3650847acbec0ddd3101bb96f Diff: https://reviews.apache.org/r/55637/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 55637: CMake: Added `test` target.

2017-01-18 Thread Alex Clemmer
> On Jan. 17, 2017, 8:46 p.m., Ilya Pronin wrote: > > I think the name "test" can confuse people because it's usually expected to > > be used for CTest. Maybe it would better be leave old {{tests}} and > > {{check}} targets? https://cmake.org/Wiki/CMakeEmulateMa

Re: Review Request 55313: Windows: Fixed the unkillable task bug, lit up executor tests.

2017-01-18 Thread Alex Clemmer
should have caught that. - Alex --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55313/#review162200 --- On Jan. 18, 20

Re: Review Request 55311: Added `process::initialize` to default executor's `main`.

2017-01-18 Thread Alex Clemmer
> > here, as we want the socket stack to be cleaned up afterwards as well. > > Either than, or you should add a `process::finalize(true)` befow. > > Alex Clemmer wrote: > Tearing down winsock before libprocess is terminated will cause ugly > failures as the test

Re: Review Request 55024: Windows: Start the socket stack in `process::initialize`.

2017-01-18 Thread Alex Clemmer
/ Testing --- Thanks, Alex Clemmer

Re: Review Request 55024: Windows: Start the socket stack in `process::initialize`.

2017-01-18 Thread Alex Clemmer
> `EXIT(EXIT_FAILURE)` is preferable. If it does, it seems like a severe > > enough error (as the docs suggest most errors are due to programmer error). > > > > See: > > https://msdn.microsoft.com/en-us/library/windows/desktop/ms741549(v=vs.85).aspx > > Alex

Re: Review Request 55327: Windows: Fixed hanging symlink bug in `os::rmdir`.

2017-01-18 Thread Alex Clemmer
os/windows/rmdir.hpp 4437484c068e9ef046e0be14683c97db447f2da1 3rdparty/stout/tests/os/rmdir_tests.cpp 988d41b7fdd11cc96ce005671a7c62d1b5a3615d Diff: https://reviews.apache.org/r/55327/diff/ Testing ------- Thanks, Alex Clemmer

Re: Review Request 55023: Windows: Fixed malformatted containerizer command in launcher.

2017-01-18 Thread Alex Clemmer
immediately upon invocation in all executor tests. This commit will fix this command. Diffs (updated) - src/slave/containerizer/mesos/containerizer.cpp 8bf8a7774a38131c53f6d91c7f09f5dedd9d4cb4 Diff: https://reviews.apache.org/r/55023/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 55313: Windows: Fixed the unkillable task bug, lit up executor tests.

2017-01-18 Thread Alex Clemmer
ec3e854ed58a0fbb3bfad0bd21eb0e2974548865 Diff: https://reviews.apache.org/r/55313/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 55312: Windows: Added parent hooks to subprocess.

2017-01-18 Thread Alex Clemmer
/libprocess/include/process/windows/subprocess.hpp 3bc7f1992d9c38dac2ec23d5bc57415f37d0318a 3rdparty/libprocess/src/subprocess.cpp ad19b0896b4a2e9c60f573cc854c10c69e909e86 Diff: https://reviews.apache.org/r/55312/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 55637: CMake: Added `test` target.

2017-01-18 Thread Alex Clemmer
> On Jan. 17, 2017, 8:46 p.m., Ilya Pronin wrote: > > I think the name "test" can confuse people because it's usually expected to > > be used for CTest. Maybe it would better be leave old {{tests}} and > > {{check}} targets? https://cmake.org/Wiki/CMakeEmulateMa

Re: Review Request 55327: Windows: Fixed hanging symlink bug in `os::rmdir`.

2017-01-18 Thread Alex Clemmer
hable. :| Embarrassing. - Alex --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55327/#review162019 --- On Jan. 15, 20

Re: Review Request 55311: Added `process::initialize` to default executor's `main`.

2017-01-18 Thread Alex Clemmer
57e4799e750f8f5352a9fec58af40efe432ea865 Diff: https://reviews.apache.org/r/55311/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 55313: Windows: Fixed the unkillable task bug, lit up executor tests.

2017-01-18 Thread Alex Clemmer
s is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55313/#review162016 --- On Jan. 8, 2017, 6:30 a.m., Alex Clemmer wrote: > > ---

Re: Review Request 55311: Added `process::initialize` to default executor's `main`.

2017-01-18 Thread Alex Clemmer
call to `process::finalize(true)`. - Alex --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55311/#review162013 ------- O

Re: Review Request 55024: Windows: Start the socket stack in `process::initialize`.

2017-01-18 Thread Alex Clemmer
--- Thanks, Alex Clemmer

Re: Review Request 55024: Windows: Start the socket stack in `process::initialize`.

2017-01-18 Thread Alex Clemmer
ng possibility of an error condition that I'm missing? - Alex --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55024/#review162008 ------

Re: Review Request 55023: Windows: Fixed malformatted containerizer command in launcher.

2017-01-18 Thread Alex Clemmer
is a no-op. So this call is likely to change when we refactor `subprocess`. We can still delete it if you want, though, but I think it's reasonable to keep it. - Alex --- This is an automatically generated e-mail. To reply, visit: https://re

Re: Review Request 55637: CMake: Added `test` target.

2017-01-17 Thread Alex Clemmer
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55637/#review161940 --- On Jan. 17, 2017, 7:33 p.m., Alex Clemmer wrote: > > --- &

Review Request 55636: Libprocess: Removed usage of CTest.

2017-01-17 Thread Alex Clemmer
Libprocess. Diffs - 3rdparty/libprocess/src/tests/CMakeLists.txt 0b2660cb16f5d8d8dc66e6995061d0b832182351 Diff: https://reviews.apache.org/r/55636/diff/ Testing --- Thanks, Alex Clemmer

Review Request 55637: CMake: Added `test` target.

2017-01-17 Thread Alex Clemmer
src/tests/CMakeLists.txt b7adf4f3126611a57baf4f62b62b208bc0236da5 Diff: https://reviews.apache.org/r/55637/diff/ Testing --- Thanks, Alex Clemmer

Review Request 55635: Stout: Removed usage of CTest.

2017-01-17 Thread Alex Clemmer
Stout. Diffs - 3rdparty/stout/tests/CMakeLists.txt a8a3ac772aa243c848a6fd8d7a0d45acfe1b98ae Diff: https://reviews.apache.org/r/55635/diff/ Testing --- Thanks, Alex Clemmer

Review Request 55632: CMake: Disabled rpath to silence CMake warning on OS X.

2017-01-17 Thread Alex Clemmer
. Repository: mesos Description --- CMake: Disabled rpath to silence CMake warning on OS X. Diffs - cmake/MesosConfigure.cmake 6a9ed9dc02f5c9a6d1fce0866f19ffeafec35cdc Diff: https://reviews.apache.org/r/55632/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 55607: CMake: Added configuration of test scripts in the bin/ directory.

2017-01-17 Thread Alex Clemmer
6a9ed9dc02f5c9a6d1fce0866f19ffeafec35cdc Diff: https://reviews.apache.org/r/55607/diff/ Testing --- Thanks, Alex Clemmer

Review Request 55607: CMake: Added configuration of test scripts in the bin/ directory.

2017-01-17 Thread Alex Clemmer
, Alex Clemmer

Re: Review Request 55604: CMake: Transitioned Libprocess to automatic source grouping.

2017-01-16 Thread Alex Clemmer
873f41d844faa0d442f77411e94314a89be5f046 3rdparty/libprocess/src/CMakeLists.txt 60f0e76dfd237d9a12a366b413802d1a96892b55 3rdparty/libprocess/src/tests/CMakeLists.txt 0b2660cb16f5d8d8dc66e6995061d0b832182351 Diff: https://reviews.apache.org/r/55604/diff/ Testing --- Thanks, Alex

Re: Review Request 55601: CMake: Added source groups for agent.

2017-01-16 Thread Alex Clemmer
://reviews.apache.org/r/55601/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 55602: CMake: Added source groups for master.

2017-01-16 Thread Alex Clemmer
/diff/ Testing --- Thanks, Alex Clemmer

Re: Review Request 55600: CMake: Transitioned Stout to automatic source grouping.

2017-01-16 Thread Alex Clemmer
a8a3ac772aa243c848a6fd8d7a0d45acfe1b98ae Diff: https://reviews.apache.org/r/55600/diff/ Testing --- Thanks, Alex Clemmer

Review Request 55604: CMake: Transitioned Libprocess to automatic source grouping.

2017-01-16 Thread Alex Clemmer
60f0e76dfd237d9a12a366b413802d1a96892b55 3rdparty/libprocess/src/tests/CMakeLists.txt 0b2660cb16f5d8d8dc66e6995061d0b832182351 Diff: https://reviews.apache.org/r/55604/diff/ Testing --- Thanks, Alex Clemmer

Review Request 55602: CMake: Added source groups for master.

2017-01-16 Thread Alex Clemmer
in a hierarchical directory structure. Diffs - src/CMakeLists.txt ce71afc73f85a70cd8f97a6e913662ff7ef0d94c src/master/cmake/MasterSourceList.cmake PRE-CREATION Diff: https://reviews.apache.org/r/55602/diff/ Testing --- Thanks, Alex Clemmer

Review Request 55601: CMake: Added source groups for agent.

2017-01-16 Thread Alex Clemmer
-CREATION src/slave/container_loggers/CMakeLists.txt b46360fb1ced188102c285c914cc0d146c6db5e1 src/slave/qos_controllers/CMakeLists.txt 65ab338a71276a77e43af962fbc9b76e050efca6 Diff: https://reviews.apache.org/r/55601/diff/ Testing --- Thanks, Alex Clemmer

  1   2   3   4   5   6   7   8   9   10   >