Re: Review Request 69405: Refactored createAuthorizationCallbacks into common/authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69405/#review210750 --- Ship it! Thanks for the clean up work! - Alexander Rojas

Review Request 69412: Fixed thread safety issue in jwt signature validation.

--- make test Thanks, Alexander Rojas

Re: Review Request 69369: Added collectAuthorizations helper to master.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69369/#review210598 --- Ship it! Ship It! - Alexander Rojas On Nov. 16, 2018, 2:54

Re: Review Request 69368: Added test reproducing crash on authorization failure.

(patched) <https://reviews.apache.org/r/69368/#comment295309> Feel free to ignore, but I prefer to use `Authorization` instead of `Authz` in the codebase, even if informally we call it authz. - Alexander Rojas On Nov. 16, 2018, 2:53 a.m., Till Toenshoff

Re: Review Request 68919: Removed unbundling by default for libevent on macOS when using CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68919/#review209218 --- Ship it! Ship It! - Alexander Rojas On Oct. 3, 2018, 10:55

Re: Review Request 68905: Removed version check from libevent dependency tracking from libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68905/#review209210 --- Ship it! Ship It! - Alexander Rojas On Oct. 3, 2018, 3:31

Re: Review Request 68914: Updated libevent linkage to adhere to best practices.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68914/#review209213 --- Ship it! Ship It! - Alexander Rojas On Oct. 3, 2018, 6:51

Re: Review Request 68916: Moved libevent_openssl validation into libevent.m4.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68916/#review209215 --- Ship it! Ship It! - Alexander Rojas On Oct. 3, 2018, 9:32

Re: Review Request 68915: Moved libevent_openssl validation into libevent.m4.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68915/#review209214 --- Ship it! Ship It! - Alexander Rojas On Oct. 3, 2018, 9:32

Re: Review Request 68913: Updated libevent linkage to adhere to best practices.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68913/#review209212 --- Ship it! Ship It! - Alexander Rojas On Oct. 3, 2018, 6:50

Re: Review Request 68906: Fixed ssl build specific incompatiblity with libevent later than 2.1.5.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68906/#review209211 --- Ship it! Ship It! - Alexander Rojas On Oct. 4, 2018, 1:06

Re: Review Request 68904: Removed version check from libevent dependency tracking.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68904/#review209209 --- Ship it! Ship It! - Alexander Rojas On Oct. 3, 2018, 3:30

Re: Review Request 68360: Removed Principal object from ObjectApprovers class.

), 239 (patched) <https://reviews.apache.org/r/68360/#comment290791> I think you can still call this `principal` instead of `printablePrincipal`. I don't think it will cause any confusion. - Alexander Rojas On Aug. 16, 2018, 2:33 p.m., Benno Evers

Re: Review Request 68307: Added a test for master's handling of stale authentication requests.

not distinguish between agents or schedulers > during authentication, this tests is sufficient to cover both cases. - Alexander Rojas On Aug. 14, 2018, 12:24 a.m., Benjamin Mahler wrote: > > --- > This is an automatically genera

Re: Review Request 68306: Fixed an authentication request amplification issue in the master.

_info_. In my opinion if we are in this situation, something is going wrong somewhere else and the stability of the system is at stake. src/master/master.cpp Lines 9627 (patched) <https://reviews.apache.org/r/68306/#comment290656> Same as before, this is probably a warning. - Ale

Re: Review Request 68305: Increased and added flag for the master's authentication timeout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68305/#review207307 --- Ship it! Ship It! - Alexander Rojas On Aug. 14, 2018, 12:22

Re: Review Request 68229: Removed unused local variable in `slave.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68229/#review206882 --- Ship it! Ship It! - Alexander Rojas On Aug. 6, 2018, 4:14

Re: Review Request 67722: Fixed unproperly guarded future.

://reviews.apache.org/r/67722/diff/4/ Changes: https://reviews.apache.org/r/67722/diff/3-4/ Testing --- ```sh make check ``` Thanks, Alexander Rojas

Re: Review Request 67722: Fixed unproperly guarded future.

://reviews.apache.org/r/67722/diff/3/ Changes: https://reviews.apache.org/r/67722/diff/2-3/ Testing --- ```sh make check ``` Thanks, Alexander Rojas

Re: Review Request 67722: Fixed unproperly guarded future.

about what other people think. THe only thing I do not agree from your snippet is to log a warning when invalid credentials are passed, afterall that is consider a normal behavior of the program. - Alexander --- Thi

Re: Review Request 67791: Prevented master from asking agents to shutdown on auth failures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67791/#review205792 --- Ship it! Ship It! - Alexander Rojas On July 4, 2018, 1:57

Re: Review Request 67722: Fixed unproperly guarded future.

://reviews.apache.org/r/67722/diff/2/ Changes: https://reviews.apache.org/r/67722/diff/1-2/ Testing --- ```sh make check ``` Thanks, Alexander Rojas

Re: Review Request 67722: Fixed unproperly guarded future.

s info. - Alexander Rojas On June 25, 2018, 7:56 p.m., Alexander Rojas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 67722: Fixed unproperly guarded future.

2/#review205373 --- On June 25, 2018, 7:56 p.m., Alexander Rojas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67722/ > ---

Re: Review Request 67425: [WIP] Implement a JWK Set parser converting JWKs into RSA keys.

/jwk_set.cpp Lines 262 (patched) <https://reviews.apache.org/r/67425/#comment288504> we don't break on `else` 3rdparty/libprocess/src/jwk_set.cpp Lines 272 (patched) <https://reviews.apache.org/r/67425/#comment288503> add a `// namespace {` at

Re: Review Request 67791: Prevented master from asking agents to shutdown on auth failures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67791/#review205631 --- Ship it! Ship It! - Alexander Rojas On July 2, 2018, 7:04

Re: Review Request 67632: Always define PICOJSON_USE_INT64.

tps://reviews.apache.org/r/67632/#comment288493> This breaks compilation if someone already has define `PICOJSON_USE_INT64`. I think the cleanest way to go about it is: ```c++ #ifndef PICOJSON_USE_INT64 # define PICOJSON_USE_INT64 #endif ``` - Alexander Rojas O

Re: Review Request 67722: Fixed unproperly guarded future.

\process.vcxproj" (default > > target) (17) -> > >"D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj" (default target) > > (23) -> > > C:\Program Files (x86)\Microsoft Visual > > Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppC

Review Request 67722: Fixed unproperly guarded future.

--- ```sh make check ``` Thanks, Alexander Rojas

Re: Review Request 67425: [WIP] Implement a JWK Set parser converting JWKs into RSA keys.

> On June 4, 2018, 4:04 p.m., Alexander Rojas wrote: > > Before going into detail with this, last patchset we forgot to add certain > > files to the install target wich ended up breaking tarball generation. > > Mostly a failure of your reviewers (myself included). Since yo

Review Request 67476: Added guideline for contributions modifying Makefile.am.

when modifying `Makefile.am` files. Diffs - docs/advanced-contribution.md f95149120d39b9517ace3ec0ac37d82d3d3a77c4 Diff: https://reviews.apache.org/r/67476/diff/1/ Testing --- Not a code related change. Thanks, Alexander Rojas

Re: Review Request 67357: Added constant time comparison of JWT signatures.

://reviews.apache.org/r/67357/diff/3-4/ Testing --- ```sh make check ``` Thanks, Alexander Rojas

Re: Review Request 67472: Fixed CppLinter in python3/mesos-style.py to use correct linter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67472/#review204388 --- Ship it! Ship It! - Alexander Rojas On June 6, 2018, 9:41

Re: Review Request 67357: Added constant time comparison of JWT signatures.

; executor '3f11d255-bb7b-4e99-967b-055fef95b595' of framework > > 62cf792a-dc69-4e3c-b54f-d83f98fb9451- at executor(1)@192.10.1.5:55652 > > I0606 10:25:26.688225 22560 slave.cpp:4984] Received re-registration > > message from executor '3f11d255-bb7b-4e99-967b

Re: Review Request 67357: Added constant time comparison of JWT signatures.

://reviews.apache.org/r/67357/diff/2-3/ Testing --- ```sh make check ``` Thanks, Alexander Rojas

Re: Review Request 67357: Added constant time comparison of JWT signatures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67357/#review204122 ------- On May 31, 2018, 11:02 a.m., Alexander Rojas wrote: > > --

Re: Review Request 67425: [WIP] Implement a JWK Set parser converting JWKs into RSA keys.

of thumb whenever one modifies the `Makefile.am`). - Alexander Rojas On June 4, 2018, 3:27 p.m., Clement Michaud wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 67357: Added constant time comparison of JWT signatures.

://reviews.apache.org/r/67357/diff/1-2/ Testing --- ```sh make check ``` Thanks, Alexander Rojas

Review Request 67357: Added constant time comparison of JWT signatures.

is visited during the comparison instead of returning at the first failure. Diffs - 3rdparty/libprocess/src/jwt.cpp 4477ddd17dede2b924a47e33942b39244f10316f Diff: https://reviews.apache.org/r/67357/diff/1/ Testing --- ```sh make check ``` Thanks, Alexander Rojas

Review Request 67339: Modified launch.cpp to writes its logs into cerr.

, Alexander Rojas

Re: Review Request 66694: Updated the 1.6.0 CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66694/#review201614 --- Ship it! Ship It! - Alexander Rojas On April 18, 2018, 8:45

Re: Review Request 66621: Add support for alg RS256 to JWT library.

reviews.apache.org/r/66621/#comment282798> missed an space between `if` and `(`. 3rdparty/libprocess/src/ssl/utilities.cpp Lines 427 (patched) <https://reviews.apache.org/r/66621/#comment282799> I'd add an empty line here.

Re: Review Request 66621: Add alg RS256 support for JWT generator and validator.

that needs to be fixed. SSL support is an optional configurable feature (`--with-ssl` in the configure options). Since your patch depends on SSL, you need the guards to enable the feature just when SSL is enabled. - Alexander Rojas On April 15, 2018, 12:19 a.m., Clément Michaud wrote

Re: Review Request 66088: Fixed crash on macOS during certain authorization calls.

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66088/#review199259 ------- On March 15, 2018, 3:27 p.m., Alexander Rojas wrote: > >

Re: Review Request 66088: Fixed crash on macOS during certain authorization calls.

/diff/1-2/ Testing --- ```sh # In multiple platforms. make check ``` Thanks, Alexander Rojas

Review Request 66088: Fixed crash on macOS during certain authorization calls.

, the macOS implementation did not follow the same pattern showing a bug in the code. Diffs - src/common/http.cpp 03f539f8942d50de34f42fd711053e94d0a1c95d Diff: https://reviews.apache.org/r/66088/diff/1/ Testing --- ```sh # In multiple platforms. make check ``` Thanks, Alexander Rojas

Re: Review Request 65313: Refactored authorization logic in the agent.

--- make check Thanks, Alexander Rojas

Re: Review Request 65311: Added the ObjectApprovers to which unifies authorization logic.

price to pay than a gigantic switch here. - Alexander --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65311/#review198973 -----

Re: Review Request 65314: Removed code which is not used.

/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 65313: Refactored authorization logic in the agent.

--- make check Thanks, Alexander Rojas

Re: Review Request 65313: Refactored authorization logic in the agent.

e, so this is a neat trick for that. - Alexander --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65313/#review198917 ---

Re: Review Request 65314: Removed code which is not used.

://reviews.apache.org/r/65314/diff/8/ Changes: https://reviews.apache.org/r/65314/diff/7-8/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 65313: Refactored authorization logic in the agent.

/65313/diff/5-6/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 65312: Refactored authorization logic in the master.

e666b664dd125317cda5d16285d444b9c21e1f35 Diff: https://reviews.apache.org/r/65312/diff/5/ Changes: https://reviews.apache.org/r/65312/diff/4-5/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 65311: Added the ObjectApprovers to which unifies authorization logic.

/65311/diff/6/ Changes: https://reviews.apache.org/r/65311/diff/5-6/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 65310: Added lambda::zip.

://reviews.apache.org/r/65310/diff/4-5/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 65311: Added the ObjectApprovers to which unifies authorization logic.

ep it and investigate further whether it is necessary. - Alexander --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65311/#review198811 ------

Re: Review Request 65310: Added lambda::zip.

: https://reviews.apache.org/r/65310/diff/3-4/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 65314: Removed code which is not used.

://reviews.apache.org/r/65314/diff/7/ Changes: https://reviews.apache.org/r/65314/diff/6-7/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 65313: Refactored authorization logic in the agent.

/65313/diff/4-5/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 65312: Refactored authorization logic in the master.

/master/master.cpp f2c2dbe6a4568027f11ad14121c2f9a1d1a43f80 Diff: https://reviews.apache.org/r/65312/diff/4/ Changes: https://reviews.apache.org/r/65312/diff/3-4/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 65314: Removed code which is not used.

/ Changes: https://reviews.apache.org/r/65314/diff/5-6/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 65313: Refactored authorization logic in the agent.

/65313/diff/3-4/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 65314: Removed code which is not used.

, see [MESOS-3968](https://issues.apache.org/jira/browse/MESOS-3968) - Alexander Rojas On Feb. 8, 2018, 1:59 p.m., Alexander Rojas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 65314: Removed code which is not used.

: https://reviews.apache.org/r/65314/diff/5/ Changes: https://reviews.apache.org/r/65314/diff/4-5/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 65313: Refactored authorization logic in the agent.

: https://reviews.apache.org/r/65313/diff/2-3/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 65314: Removed code which is not used.

/ Changes: https://reviews.apache.org/r/65314/diff/3-4/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 65311: Added the ObjectApprovers to which unifies authorization logic.

/65311/diff/4/ Changes: https://reviews.apache.org/r/65311/diff/3-4/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 65314: Removed code which is not used.

/ Changes: https://reviews.apache.org/r/65314/diff/2-3/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 65313: Refactored authorization logic in the agent.

--- make check Thanks, Alexander Rojas

Re: Review Request 65311: Added the ObjectApprovers to which unifies authorization logic.

/65311/diff/3/ Changes: https://reviews.apache.org/r/65311/diff/2-3/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 65312: Refactored authorization logic in the master.

cc2685a6bc14103c639ce776cf1c912361e93381 Diff: https://reviews.apache.org/r/65312/diff/2/ Changes: https://reviews.apache.org/r/65312/diff/1-2/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 65311: Added the ObjectApprovers to which unifies authorization logic.

/65311/diff/2/ Changes: https://reviews.apache.org/r/65311/diff/1-2/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 65311: Added the ObjectApprovers to which unifies authorization logic.

return true; > > } > > ``` > > > > And then the callsites could look like: > > ``` > > approvers->approved(resource); > > ``` > > > > WDYT? I liked the idea but somehow the program didn't resolved the te

Re: Review Request 65310: Added lambda::zip.

c9212be27b45da45f15371689f2aabf18c98657b 3rdparty/stout/tests/lambda_tests.cpp 11b034306b11b95efa9bcd9811c5145ad39314a5 Diff: https://reviews.apache.org/r/65310/diff/2/ Changes: https://reviews.apache.org/r/65310/diff/1-2/ Testing --- make check Thanks, Alexander Rojas

Review Request 65311: Added the ObjectApprovers to which unifies authorization logic.

Thanks, Alexander Rojas

Review Request 65312: Refactored authorization logic in the master.

://reviews.apache.org/r/65312/diff/1/ Testing --- make check Thanks, Alexander Rojas

Review Request 65313: Refactored authorization logic in the agent.

1619bb77e3e7d5a6d387e4d4bb071d83ce914967 src/slave/http.cpp 77e711ceeb0e2613d629b5e21fd686f85dfad11a src/slave/slave.cpp 43c7955237655accdf869db1b6494a35f77acdb3 Diff: https://reviews.apache.org/r/65313/diff/1/ Testing --- make check Thanks, Alexander Rojas

Review Request 65314: Removed code which is not used.

, Alexander Rojas

Review Request 65310: Added lambda::zip.

c9212be27b45da45f15371689f2aabf18c98657b 3rdparty/stout/tests/lambda_tests.cpp 11b034306b11b95efa9bcd9811c5145ad39314a5 Diff: https://reviews.apache.org/r/65310/diff/1/ Testing --- make check Thanks, Alexander Rojas

Re: Review Request 65305: Fixed a libprocess crash when tests clear the authorization callbacks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65305/#review196106 --- Ship it! Ship It! - Alexander Rojas On Jan. 24, 2018, 1:54

Re: Review Request 65226: Added SecurePathOrValue for file flags which need not to leak contents.

3rdparty/stout/include/stout/flags/parse.hpp 6112d699be4cbdcb7a7872da8f29d41aab0939a3 Diff: https://reviews.apache.org/r/65226/diff/2/ Changes: https://reviews.apache.org/r/65226/diff/1-2/ Testing --- ``` make check ``` Full testing in follow up patch. Thanks, Alexander Rojas

Re: Review Request 65090: Mesos flags related to ZooKeeper use SecurePathOrValue.

jq -r '.flags.master') == `cat /tmp/$USER/zk/zk.conf` ]] kill %2 kill %1 ``` Thanks, Alexander Rojas

Review Request 65227: Added specific flag loader for zookeeper urls preventing password leaks.

= `cat /tmp/$USER/zk/zk.conf` ]] kill %2 kill %1 ``` Thanks, Alexander Rojas

Re: Review Request 65090: Mesos flags related to ZooKeeper use SecurePathOrValue.

\ --zk=`cat /tmp/$USER/zk/zk.conf` & [[ $(http -b $PUBLIC_IP:5051/flags | jq -r '.flags.master') == `cat /tmp/$USER/zk/zk.conf` ]] kill %2 kill %1 ``` Thanks, Alexander Rojas

Review Request 65226: Added SecurePathOrValue for file flags which need not to leak contents.

6112d699be4cbdcb7a7872da8f29d41aab0939a3 Diff: https://reviews.apache.org/r/65226/diff/1/ Testing --- ``` make check ``` Full testing in follow up patch. Thanks, Alexander Rojas

Re: Review Request 63325: Refactored authorization logic in the agent.

c07e25f668bef6b6fa3cae4b69ba90de3eb3bdcc Diff: https://reviews.apache.org/r/63325/diff/4/ Changes: https://reviews.apache.org/r/63325/diff/3-4/ Testing --- make check Thanks, Alexander Rojas

Review Request 65090: Added specific flag loader for zookeeper urls preventing password leaks.

--work_dir=/tmp/$USER/mesos/agent \ --log_dir=/tmp/$USER/mesos/agent/log \ --zk=`cat /tmp/$USER/zk/zk.conf` & [[ $(http -b $PUBLIC_IP:5051/flags | jq -r '.flags.master') == `cat /tmp/$USER/zk/zk.conf` ]] kill %2 kill %1 ``` Thanks, Alexander Rojas

Re: Review Request 64515: Used `reserve_resources` ACL for static reservations.

horizedToStaticallyReserveResources` and you save a restart of a master. - Alexander Rojas On Dec. 12, 2017, 1:30 a.m., Jiang Yan Xu wrote: > > --- > This is an auto

Re: Review Request 64514: Refactor out `authorizeReserveResources` that takes a `Resources`.

tps://reviews.apache.org/r/64514/#comment272250> I'm face with a conundrum, should this follow the patter of the other authorization methods and use Doxygen, or should it follow the pattern of the rest of the file? I'll let it up to you. - Alexander Rojas On Dec. 12, 2017, 1:

Re: Review Request 60891: Added ACLs and AuthZ for standalone containers.

://github.com/apache/mesos/blob/master/src/tests/authorization_tests.cpp) - Alexander Rojas On Nov. 14, 2017, 2:24 a.m., Joseph Wu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 62637: Added an object approver to authorize requests from resource providers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62637/#review191714 --- Please add unit tests. - Alexander Rojas On Nov. 21, 2017, 2

Re: Review Request 62636: Generated authentication tokens for local resource providers.

written without unit tests. Please address that in the whole chain. - Alexander Rojas On Nov. 21, 2017, 1:10 a.m., Chun-Hung Hsiao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 62636: Generated authentication tokens for local resource providers.

y already says it failed to validate a secret. You could just do `return error.get()`. src/resource_provider/storage/provider.cpp Lines 104 (patched) <https://reviews.apache.org/r/62636/#comment269595> is there any situatio when the `authToken` is `None`? - Alexander Rojas On Nov.

Re: Review Request 63828: Added authorization tests for standalone container APIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63828/#review191043 --- Ship it! Ship It! - Alexander Rojas On Nov. 15, 2017, 9:42

Re: Review Request 63694: Added context to agent processing calls.

> On Nov. 9, 2017, 5:26 p.m., Alexander Rukletsov wrote: > > src/slave/http.cpp > > Line 2750 (original), 2793 (patched) > > > > > > This check is actually weird. {{ContainerID}} is optional in > >

Re: Review Request 63292: Added lamdba::zip.

return output; ``` If we had ranges we could even get away without `contents`. - Alexander Rojas On Oct. 25, 2017, 12:03 p.m., Benjamin Hindman wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 63101: Upgrades jQuery used by Mesos WebUI to version 3.2.1.

y-upgrade. Thanks, Alexander Rojas

Review Request 63102: Upgrades AngularJS used by Mesos WebUI to version 1.2.32.

/63102/diff/1/ Testing --- manual testing Launched a cluster with two agents and two frameworks. Verified that the UI behaved as before. Thanks, Alexander Rojas

Review Request 63101: Upgrades jQuery used by Mesos WebUI to version 3.2.1.

. Verified that the UI behaved as before. Thanks, Alexander Rojas

  1   2   3   4   5   6   7   8   9   10   >