Re: Review Request 66815: Removed an unconditional .get() in DefaultExecutor.

2018-12-11 Thread Alexander Rukletsov
t;< taskId << "' completed in state " << stringify(taskState) << (message.isSome() ? ": " + message.get() : ""); ``` - Alexander Rukletsov On April 26, 2018, 3:24 p.m., Benno Evers wrote: > > -

Re: Review Request 69464: Made the `createTask` helper work for both v0 and v1 API.

2018-11-28 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69464/#review210929 --- Ship it! Ship It! - Alexander Rukletsov On Nov. 27, 2018

Re: Review Request 69451: Fixed master crash when executors send messages to recovered frameworks.

2018-11-28 Thread Alexander Rukletsov
) <https://reviews.apache.org/r/69451/#comment295764> Does it make sense to add a log line in case neither `http` not `pid` are set? - Alexander Rukletsov On Nov. 28, 2018, 12:40 a.m., Chun-Hung Hsiao

Re: Review Request 69405: Refactored createAuthorizationCallbacks into common/authorization.

2018-11-20 Thread Alexander Rukletsov
Lines 34 (patched) <https://reviews.apache.org/r/69405/#comment295456> please move `stout/hashset` include here - Alexander Rukletsov On Nov. 20, 2018, 2:35 a.m., Till Toenshoff wrote: > > --- > This is an automatica

Re: Review Request 69386: Added test for ACCESS_MESOS_LOG authorization.

2018-11-19 Thread Alexander Rukletsov
though they are not directly related to the ticket you're working on. Thank you, Till! - Alexander Rukletsov On Nov. 18, 2018, 11:11 p.m., Till Toenshoff wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 69384: Introduced common/authorization and refactored collectAuthorizations.

2018-11-19 Thread Alexander Rukletsov
(patched) <https://reviews.apache.org/r/69384/#comment295371> This should go before "master/..." - Alexander Rukletsov On Nov. 18, 2018, 10:52 p.m., Till Toenshoff wrote: > > --- > This is an automatically g

Re: Review Request 69385: Refactored createSubject and authorizeLogAccess to common/authorization.

2018-11-19 Thread Alexander Rukletsov
comment295375> Ditto - Alexander Rukletsov On Nov. 18, 2018, 11:10 p.m., Till Toenshoff wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Re: Review Request 68131: Added MasterActorResponsiveness_BENCHMARK_Test.

2018-11-18 Thread Alexander Rukletsov
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68131/#review210347 --- On Nov. 18, 2018, 8:10 p.m., Alexander Rukletsov wrote: > > -

Re: Review Request 68131: Added MasterActorResponsiveness_BENCHMARK_Test.

2018-11-18 Thread Alexander Rukletsov
/ Changes: https://reviews.apache.org/r/68131/diff/4-5/ Testing --- See https://reviews.apache.org/r/68132/ Thanks, Alexander Rukletsov

Re: Review Request 68131: Added MasterActorResponsiveness_BENCHMARK_Test.

2018-11-17 Thread Alexander Rukletsov
t as is. - Alexander --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68131/#review210347 --- On Nov. 4, 2018, 4:31 a.m

Re: Review Request 69369: Added collectAuthorizations helper to master.hpp.

2018-11-17 Thread Alexander Rukletsov
(patched) <https://reviews.apache.org/r/69369/#comment295358> Please include - Alexander Rukletsov On Nov. 18, 2018, 1:25 a.m., Till Toenshoff wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 69368: Added test reproducing crash on authorization failure.

2018-11-17 Thread Alexander Rukletsov
) <https://reviews.apache.org/r/69368/#comment295356> We usually back tick variable, type names. src/tests/master_tests.cpp Lines 10109 (patched) <https://reviews.apache.org/r/69368/#comment295357> why is "Static" capitalized? - Alexander Rukletsov On Nov. 18,

Re: Review Request 69267: Fixed flaky SchedulerTest.MasterFailover.

2018-11-08 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69267/#review210396 --- Ship it! Ship It! - Alexander Rukletsov On Nov. 7, 2018, 1

Re: Review Request 68131: Added MasterActorResponsiveness_BENCHMARK_Test.

2018-11-03 Thread Alexander Rukletsov
/ Changes: https://reviews.apache.org/r/68131/diff/3-4/ Testing --- See https://reviews.apache.org/r/68132/ Thanks, Alexander Rukletsov

Re: Review Request 69224: Fixed a test flake in `HealthCheckTest.HealthyTaskNonShell`.

2018-11-01 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69224/#review210250 --- Ship it! Ship It! - Alexander Rukletsov On Nov. 1, 2018, 3

Re: Review Request 68812: Added example framework for inverse-offers.

2018-10-24 Thread Alexander Rukletsov
ent294613> How about pulling it into a constant, e.g., `constexpr char FRAMEWORK_NAME[]`? - Alexander Rukletsov On Sept. 23, 2018, 12:08 a.m., Till Toenshoff wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 69110: Added task health check definitions to master API responses.

2018-10-23 Thread Alexander Rukletsov
tps://reviews.apache.org/r/69110/#comment294552> What do you think about moving this blob to `AgentAPITest::GetState`? It will be consistent with the `TASK_ADDED` test. - Alexander Rukletsov On Oct. 22, 2018, 6:37 p.m., Greg Mann

Re: Review Request 69110: Added task health check definitions to master API responses.

2018-10-22 Thread Alexander Rukletsov
for the contents of `TASK_ADDED` soon and add expose check definitions as well. include/mesos/mesos.proto Lines 2200-2201 (patched) <https://reviews.apache.org/r/69110/#comment294455> Let's add a `TODO` here for `CheckInfo`. Here and below. - Alexander Rukletsov On Oct. 22, 2018, 5:

Re: Review Request 68993: Introduced `logResponse` for http handlers.

2018-10-16 Thread Alexander Rukletsov
/http.hpp 4f994a0744f098363327b785df56e877c9624e2a src/common/http.cpp 9070071bbb42703b3f62e0cf50b31da943da015c Diff: https://reviews.apache.org/r/68993/diff/2/ Changes: https://reviews.apache.org/r/68993/diff/1-2/ Testing --- See https://reviews.apache.org/r/68994/ Thanks, Alexander

Re: Review Request 68994: Logged request processing time for some endpoints.

2018-10-16 Thread Alexander Rukletsov
ippet from the master log: ``` I1011 16:08:51.012370 63365120 http.cpp:1178] HTTP GET for /master/flags from 192.168.1.3:56629 with User-Agent='HTTPie/0.9.3' ``` Thanks, Alexander Rukletsov

Re: Review Request 68992: Added 'received' timestamp into `process::Request`.

2018-10-16 Thread Alexander Rukletsov
bbcd0bac8bab51da2dae6c052896d11a86753744 Diff: https://reviews.apache.org/r/68992/diff/2/ Changes: https://reviews.apache.org/r/68992/diff/1-2/ Testing --- See https://reviews.apache.org/r/68994/ Thanks, Alexander Rukletsov

Re: Review Request 68992: Added 'received' timestamp into `process::Request`.

2018-10-16 Thread Alexander Rukletsov
ps://reviews.apache.org/r/68992/#review209605 ------- On Oct. 11, 2018, 2:16 p.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 67840: Renamed committer checklist into committer guidelines.

2018-10-15 Thread Alexander Rukletsov
029b8cd1f5b1c6403aa653b496f6a7067d1bc053 Diff: https://reviews.apache.org/r/67840/diff/2/ Changes: https://reviews.apache.org/r/67840/diff/1-2/ Testing --- None: not a functional change. Thanks, Alexander Rukletsov

Re: Review Request 67841: Updated committer candidate guidelines.

2018-10-15 Thread Alexander Rukletsov
/67841/diff/1-2/ Testing --- None: not a functional change. Thanks, Alexander Rukletsov

Review Request 68993: Introduced `logResponse` for http handlers.

2018-10-11 Thread Alexander Rukletsov
src/common/http.cpp 9070071bbb42703b3f62e0cf50b31da943da015c Diff: https://reviews.apache.org/r/68993/diff/1/ Testing --- See https://reviews.apache.org/r/68994/ Thanks, Alexander Rukletsov

Review Request 68994: Logged request processing time for some endpoints.

2018-10-11 Thread Alexander Rukletsov
flags from 192.168.1.3:56629 with User-Agent='HTTPie/0.9.3' ``` Thanks, Alexander Rukletsov

Review Request 68992: Added 'received' timestamp into `process::Request`.

2018-10-11 Thread Alexander Rukletsov
://reviews.apache.org/r/68992/diff/1/ Testing --- See https://reviews.apache.org/r/68994/ Thanks, Alexander Rukletsov

Re: Review Request 61818: Adjusted a comment and a log message around container termination.

2018-10-09 Thread Alexander Rukletsov
ect. This case should not be logged as an error. Diffs - src/slave/slave.cpp 50d2a10cd68f6611efd4e691e5325e6e0c06f33a Diff: https://reviews.apache.org/r/61818/diff/1/ Testing --- None: not a functional change. Thanks, Alexander Rukletsov

Re: Review Request 68945: Fused constructors of `MethodNotAllowed` into one.

2018-10-08 Thread Alexander Rukletsov
> > There is no good reason to provide two c-tors for `MethodNotAllowed`, > with one taking `requestMethod` and one not. Instead, an `Option<>` > can be used. This also removes the need for copy-paste in the c-tor > body. > > > Diffs > - > > 3rdparty/libprocess/include/process/http.hpp > cef511a1563a26e170ce7f4a49de12776b4512e7 > > > Diff: https://reviews.apache.org/r/68945/diff/2/ > > > Testing > --- > > `make check` on various linux distros > > > Thanks, > > Alexander Rukletsov > >

Re: Review Request 68945: Fused constructors of `MethodNotAllowed` into one.

2018-10-08 Thread Alexander Rukletsov
rocess/include/process/http.hpp cef511a1563a26e170ce7f4a49de12776b4512e7 Diff: https://reviews.apache.org/r/68945/diff/2/ Changes: https://reviews.apache.org/r/68945/diff/1-2/ Testing --- `make check` on various linux distros Thanks, Alexander Rukletsov

Review Request 68944: Used delegating constructors in `Response` types.

2018-10-07 Thread Alexander Rukletsov
https://reviews.apache.org/r/68945/ Thanks, Alexander Rukletsov

Review Request 68945: Fused constructors of `MethodNotAllowed` into one.

2018-10-07 Thread Alexander Rukletsov
tp.hpp cef511a1563a26e170ce7f4a49de12776b4512e7 Diff: https://reviews.apache.org/r/68945/diff/1/ Testing --- `make check` on various linux distros Thanks, Alexander Rukletsov

Re: Review Request 67414: Added default message bodies to libprocess HTTP error responses.

2018-10-07 Thread Alexander Rukletsov
24-838 (patched) <https://reviews.apache.org/r/67414/#comment293580> Even though both are apparently allowed by our style guide, I'd go for local consistency. - Alexander Rukletsov On Oct. 5, 2018, 4:45 p.m., Benno

Re: Review Request 67414: Added default message bodies to libprocess HTTP error responses.

2018-10-05 Thread Alexander Rukletsov
> On June 5, 2018, 10:46 a.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/include/process/http.hpp > > Line 701 (original), 701-702 (patched) > > <https://reviews.apache.org/r/67414/diff/1/?file=2034492#file2034492line701> > > > > Why n

Re: Review Request 68866: Waited for TEARDOWN response in v1 Java scheduler shim.

2018-10-04 Thread Alexander Rukletsov
://reviews.apache.org/r/68866/diff/4/ Changes: https://reviews.apache.org/r/68866/diff/3-4/ Testing --- `make check` on various Linux distro Thanks, Alexander Rukletsov

Re: Review Request 68865: Put `TerminateEvent` at the end of the queue in the Mesos library.

2018-10-04 Thread Alexander Rukletsov
/ Testing --- See https://reviews.apache.org/r/68866/ Thanks, Alexander Rukletsov

Re: Review Request 68866: Waited for TEARDOWN response in v1 Java scheduler shim.

2018-10-04 Thread Alexander Rukletsov
://reviews.apache.org/r/68866/diff/3/ Changes: https://reviews.apache.org/r/68866/diff/2-3/ Testing --- `make check` on various Linux distro Thanks, Alexander Rukletsov

Re: Review Request 68866: Waited for TEARDOWN response in v1 Java scheduler shim.

2018-10-04 Thread Alexander Rukletsov
2a5fbd79ac7bad933067cd96e38186849af8edc4 Diff: https://reviews.apache.org/r/68866/diff/2/ Changes: https://reviews.apache.org/r/68866/diff/1-2/ Testing (updated) --- `make check` on various Linux distro Thanks, Alexander Rukletsov

Re: Review Request 68866: Waited for TEARDOWN response in v1 Java scheduler shim.

2018-10-04 Thread Alexander Rukletsov
://reviews.apache.org/r/68866/diff/1/ Testing --- `make check`on various Linux distro Thanks, Alexander Rukletsov

Re: Review Request 68865: Put `TerminateEvent` at the end of the queue in the Mesos library.

2018-10-04 Thread Alexander Rukletsov
(stage) of such event can be dispatched after the termination event. Diffs - src/scheduler/scheduler.cpp 471152945d6af660c8983324b38702d872657f89 Diff: https://reviews.apache.org/r/68865/diff/1/ Testing --- See https://reviews.apache.org/r/68866/ Thanks, Alexander Rukletsov

Re: Review Request 68903: Avoid deadlock-prone blocking in master's parallel endpoint serving.

2018-10-04 Thread Alexander Rukletsov
thread before master actor proceeds to launching the last worker? - Alexander Rukletsov On Oct. 3, 2018, 12:07 a.m., Benjamin Mahler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 68866: Waited for TEARDOWN response in v1 Java scheduler shim.

2018-09-28 Thread Alexander Rukletsov
ler/scheduler.cpp#L301) too. Not sure I follow, Vinod. - Alexander --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68866/#review209074 --------

Re: Review Request 68866: Waited for TEARDOWN response in v1 Java scheduler shim.

2018-09-27 Thread Alexander Rukletsov
/diff/1/ Testing (updated) --- `make check`on various Linux distro Thanks, Alexander Rukletsov

Re: Review Request 68865: Put `TerminateEvent` at the end of the queue in the Mesos library.

2018-09-27 Thread Alexander Rukletsov
/ Testing (updated) --- See https://reviews.apache.org/r/68866/ Thanks, Alexander Rukletsov

Review Request 68866: Waited for TEARDOWN response in v1 Java scheduler shim.

2018-09-27 Thread Alexander Rukletsov
, Alexander Rukletsov

Review Request 68865: Put `TerminateEvent` at the end of the queue in the Mesos library.

2018-09-27 Thread Alexander Rukletsov
https://issues.apache.org/jira/browse/MESOS-9274 Repository: mesos Description --- See summary. Diffs - src/scheduler/scheduler.cpp 471152945d6af660c8983324b38702d872657f89 Diff: https://reviews.apache.org/r/68865/diff/1/ Testing --- Thanks, Alexander Rukletsov

Re: Review Request 68839: Disabled flaky LaunchNestedContainerSessionsInParallel test.

2018-09-26 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68839/#review209050 --- Ship it! Ship It! - Alexander Rukletsov On Sept. 25, 2018

Re: Review Request 68784: Fixed broken pipe error in IOSwitchboard.

2018-09-21 Thread Alexander Rukletsov
(patched) <https://reviews.apache.org/r/68784/#comment293089> Thanks, Andrei! An advice I'd like to share: prefer explicit capture. In this case, when something changes in the code flow, the compiler notifies you happily : ) - Alexander Rukletsov On Sept. 21, 2018, 12:

Re: Review Request 68768: Fixed disconnection while sending acknowledgment to IOSwitchboard.

2018-09-21 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68768/#review208853 --- Ship it! Ship It! - Alexander Rukletsov On Sept. 19, 2018

Re: Review Request 68784: Fixed broken pipe error in IOSwitchboard.

2018-09-21 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68784/#review208852 --- Ship it! Ship It! - Alexander Rukletsov On Sept. 21, 2018

Re: Review Request 62187: Fixed broken pipe error in IOSwitchboard.

2018-09-18 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62187/#review208704 --- Ship it! Ship It! - Alexander Rukletsov On Sept. 10, 2018

Re: Review Request 65168: Fixed HTTP errors caused by dropped HTTP responses by IOSwitchboard.

2018-09-18 Thread Alexander Rukletsov
ched) <https://reviews.apache.org/r/65168/#comment292857> please `snake_case` instead of `camelCase` - Alexander Rukletsov On Sept. 6, 2018, 3:22 p.m., Andrei Budnik wrote: > > --- > This is an automatically generated e-mai

Re: Review Request 68230: Added `AgentAPITest.LaunchNestedContainerSessionKillTask` test.

2018-09-12 Thread Alexander Rukletsov
292610> Does it make sense to make helpers out of these as well? - Alexander Rukletsov On Aug. 31, 2018, 1:11 p.m., Andrei Budnik wrote: > > --- > This is an automatically generate

Re: Review Request 65168: Fixed HTTP errors caused by dropped HTTP responses by IOSwitchboard.

2018-09-12 Thread Alexander Rukletsov
(original), 1230 (patched) <https://reviews.apache.org/r/65168/#comment292613> no "a" src/slave/http.cpp Lines 3152-3153 (patched) <https://reviews.apache.org/r/65168/#comment292612> fits one line - Alexander Rukletsov On Sept. 6, 2018, 3:22 p.m

Re: Review Request 68231: Added `AgentAPITest.AttachContainerInputRepeat` test.

2018-09-12 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68231/#review208562 --- Ship it! - Alexander Rukletsov On Aug. 31, 2018, 2:15 p.m

Re: Review Request 68232: Fixed IOSwitchboard waiting EOF from attach container input request.

2018-09-12 Thread Alexander Rukletsov
ines 1710 (patched) <https://reviews.apache.org/r/68232/#comment292596> [promise] - Alexander Rukletsov On Aug. 31, 2018, 11:48 a.m., Andrei Budnik wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Re: Review Request 68568: Added '/roles' to the set of batched master endpoints.

2018-09-06 Thread Alexander Rukletsov
), 2562 (patched) <https://reviews.apache.org/r/68568/#comment292310> I'll move it to `master.cpp`. src/master/master.hpp Lines 1614 (patched) <https://reviews.apache.org/r/68568/#comment292311> I think this can be removed now. - Alexander Rukletsov On Sept. 5, 201

Re: Review Request 68236: Fixed `LaunchNestedContainerSessionsInParallel` test.

2018-09-06 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68236/#review208405 --- Ship it! Ship It! - Alexander Rukletsov On Sept. 3, 2018, 4

Re: Review Request 68627: Brought site dependencies up to date.

2018-09-05 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68627/#review208343 --- Ship it! Ship It! - Alexander Rukletsov On Sept. 5, 2018, 8

Re: Review Request 68567: Restructured /roles code.

2018-09-04 Thread Alexander Rukletsov
> On Sept. 4, 2018, 9:39 a.m., Alexander Rukletsov wrote: > > src/master/http.cpp > > Line 2648 (original), 2644 (patched) > > <https://reviews.apache.org/r/68567/diff/1/?file=2079012#file2079012line2648> > > > > `std::move()` Reading https://www

Re: Review Request 68568: Added '/roles' to the set of batched master endpoints.

2018-09-04 Thread Alexander Rukletsov
eLogAccess( const Option& principal); ``` src/master/readonly_handler.cpp Lines 745 (patched) <https://reviews.apache.org/r/68568/#comment292038> const - Alexander Rukletsov On Sept. 4, 2018, 9:39 a.m

Re: Review Request 68568: Added '/roles' to the set of batched master endpoints.

2018-09-04 Thread Alexander Rukletsov
-mail. To reply, visit: > https://reviews.apache.org/r/68568/ > --- > > (Updated Sept. 4, 2018, 9:39 a.m.) > > > Review request for mesos and Alexander Rukletsov. > > > Bugs: MESOS-9194 > https://issues.apache.org/jira/browse/MESOS-9194 > > &

Re: Review Request 68567: Restructured /roles code.

2018-09-04 Thread Alexander Rukletsov
/#comment292036> const - Alexander Rukletsov On Aug. 30, 2018, 11:33 a.m., Benno Evers wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 68555: Made checker library retry to remove the previous check container.

2018-09-03 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68555/#review208259 --- Ship it! Good catch and good fix, Qian! - Alexander Rukletsov

Re: Review Request 68495: Made command check always waits before removing the nested container.

2018-09-03 Thread Alexander Rukletsov
. - Alexander Rukletsov On Aug. 24, 2018, 9:54 a.m., Qian Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 68495: Made command check always waits before removing the nested container.

2018-09-03 Thread Alexander Rukletsov
> On Aug. 27, 2018, 5:16 p.m., Alexander Rukletsov wrote: > > src/checks/checker_process.cpp > > Lines 878-889 (original), 890-901 (patched) > > <https://reviews.apache.org/r/68495/diff/1/?file=2077041#file2077041line890> > > > > It looks like we

Re: Review Request 68131: Added MasterActorResponsiveness_BENCHMARK_Test.

2018-08-30 Thread Alexander Rukletsov
--- See https://reviews.apache.org/r/68132/ Thanks, Alexander Rukletsov

Re: Review Request 68232: Fixed IOSwitchboard waiting EOF from attach container input request.

2018-08-30 Thread Alexander Rukletsov
232/#comment291900> not is pending seems a safer choice - Alexander Rukletsov On Aug. 25, 2018, 10:12 a.m., Andrei Budnik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > h

Re: Review Request 68224: Augmented `Statistics` to work with any collection.

2018-08-28 Thread Alexander Rukletsov
-- On Aug. 14, 2018, 12:48 p.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68224/ > -

Re: Review Request 68537: Cleaned up some style issues in `ReadOnlyHandler`.

2018-08-28 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68537/#review208060 --- Ship it! Ship It! - Alexander Rukletsov On Aug. 28, 2018, 2

Re: Review Request 68473: Moved members of `ReadOnlyHandler` into separate file.

2018-08-28 Thread Alexander Rukletsov
19-20 (patched) <https://reviews.apache.org/r/68473/#comment291803> No, darling : ) src/master/readonly_handler.cpp Lines 26-27 (patched) <https://reviews.apache.org/r/68473/#comment291804> Nope : ) - Alexander Rukletsov On Aug. 27, 2018, 5:44 p.m., Benno

Re: Review Request 68440: Added '/tasks' to the set of batched master endpoints.

2018-08-28 Thread Alexander Rukletsov
), 4043 (patched) <https://reviews.apache.org/r/68440/#comment291802> Extra blank line - Alexander Rukletsov On Aug. 28, 2018, 10:28 a.m., Benno Evers wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 68234: Added `AgentAPITest.LaunchNestedContainerWithUnknownParent` test.

2018-08-28 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68234/#review208039 --- Ship it! Ship It! - Alexander Rukletsov On Aug. 27, 2018, 2

Re: Review Request 68235: Cleaned up container on launch failures in composing containerizer.

2018-08-28 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68235/#review208040 --- Ship it! Ship It! - Alexander Rukletsov On Aug. 27, 2018, 2

Re: Review Request 68495: Made command check always waits before removing the nested container.

2018-08-27 Thread Alexander Rukletsov
ng? We can end up calling it twice, but I think it's fine? - Alexander Rukletsov On Aug. 24, 2018, 9:54 a.m., Qian Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 68441: Added '/slaves' to the set of batched master endpoints.

2018-08-27 Thread Alexander Rukletsov
hed) <https://reviews.apache.org/r/68441/#comment291626> // NOTE: Requests to this endpoint are batched. Or maybe even better: group batched endpoints together. - Alexander Rukletsov On Aug

Re: Review Request 68440: Added '/tasks' to the set of batched master endpoints.

2018-08-27 Thread Alexander Rukletsov
TE: Requests to this endpoint are batched. - Alexander Rukletsov On Aug. 22, 2018, 1:16 p.m., Benno Evers wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 68321: Added '/state-summary' to the set of batched master endpoints.

2018-08-27 Thread Alexander Rukletsov
/master/http.cpp Line 3476 (original), 3487 (patched) <https://reviews.apache.org/r/68321/#comment291623> `return std::move(OK(...));` - Alexander Rukletsov On Aug. 21, 2018, 2:09 p.m., Benno Evers

Re: Review Request 68442: Added '/frameworks' to the set of batched master endpoints.

2018-08-27 Thread Alexander Rukletsov
his endpoint are batched. or grouping, see https://reviews.apache.org/r/68441/ - Alexander Rukletsov On Aug. 22, 2018, 1:16 p.m., Benno Evers wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 68473: Moved members of ReadOnlyHandler into separate file.

2018-08-27 Thread Alexander Rukletsov
r/68473/#comment291648> remove this line src/master/readonly_handler.cpp Lines 40 (patched) <https://reviews.apache.org/r/68473/#comment291649> remove this line src/master/readonly_handler.cpp Lines 91-92 (patched) <https://reviews.apache.org/r/68473/#comment291650&g

Re: Review Request 68502: Added stout wrapper for `boost::circular_buffer`.

2018-08-24 Thread Alexander Rukletsov
committing. - Alexander Rukletsov On Aug. 24, 2018, 5:38 p.m., Benno Evers wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 68484: Added macros to unconditionally disable boost debug mode.

2018-08-24 Thread Alexander Rukletsov
> On Aug. 24, 2018, 7:52 a.m., Alexander Rukletsov wrote: > > Maybe mention that folks should consider moving away from boost 1.53 in > > `upgrades.md`? > > Benno Evers wrote: > I dont think so, switching Boost version can be a huge pain, and if we > get this f

Re: Review Request 68484: Enforced disabling boost debug mode.

2018-08-24 Thread Alexander Rukletsov
23, 2018, 4:25 p.m., Benno Evers wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68484/ > --- > > (Updated Aug. 23, 2018, 4:25 p.m.) > >

Re: Review Request 68484: Enforced disabling boost debug mode.

2018-08-24 Thread Alexander Rukletsov
ent291410> Please the same in slave.hpp - Alexander Rukletsov On Aug. 23, 2018, 4:25 p.m., Benno Evers wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 67575: Changed operator API to notify subscribers on every status change.

2018-08-21 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67575/#review207655 --- Ship it! Ship It! - Alexander Rukletsov On June 15, 2018

Re: Review Request 68321: Add '/state-summary' to batched master endpoints.

2018-08-21 Thread Alexander Rukletsov
(patched) <https://reviews.apache.org/r/68321/#comment291086> How about moving definitions on this class's methods to a separate file, e.g., "readonly_handlers.cpp"? - Alexander Rukletsov On Aug. 17, 2018, 7:03 p.m., B

Re: Review Request 68296: Added 'handler' field to batched requests.

2018-08-21 Thread Alexander Rukletsov
), 2865 (patched) <https://reviews.apache.org/r/68296/#comment291085> I think we don't add a space between the variable name and c-tor initialization list. - Alexander Rukletsov On Aug. 20, 2018, 2:11 p.m., Benno Evers

Re: Review Request 68343: Moved state serialization into separate function.

2018-08-21 Thread Alexander Rukletsov
master.hpp Lines 1388-1389 (patched) <https://reviews.apache.org/r/68343/#comment291083> We have an unwritten agreement to add a black line between paragraphs in comments. - Alexander Rukletsov On Aug. 20, 2018, 6:34 p

Re: Review Request 68257: Fixed incorrect `mnt` namespace detection of command executor's task.

2018-08-20 Thread Alexander Rukletsov
> On Aug. 17, 2018, 8:37 p.m., Alexander Rukletsov wrote: > > src/slave/containerizer/mesos/utils.cpp > > Lines 81-83 (patched) > > <https://reviews.apache.org/r/68257/diff/2/?file=2072515#file2072515line82> > > > > Let's unite `candidate` and `has

Re: Review Request 68345: Fixed an expectation in the master tests.

2018-08-20 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68345/#review207609 --- Ship it! Ship It! - Alexander Rukletsov On Aug. 14, 2018, 4

Re: Review Request 68321: Add '/state-summary' to batched master endpoints.

2018-08-20 Thread Alexander Rukletsov
tps://reviews.apache.org/r/68321/#comment291062> Do you plan to augment this review or pull these additions into separate review(s)? - Alexander Rukletsov On Aug. 17, 2018, 7:03 p.m., Benno Evers wrote: > > --- > This is a

Re: Review Request 68343: Moved state serialization into separate function.

2018-08-20 Thread Alexander Rukletsov
tps://reviews.apache.org/r/68343/#comment291061> Indentation - Alexander Rukletsov On Aug. 17, 2018, 7:06 p.m., Benno Evers wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 68296: Added 'handler' field to batched requests.

2018-08-20 Thread Alexander Rukletsov
), 3035-3036 (patched) <https://reviews.apache.org/r/68296/#comment291060> These will become `const &`. src/master/master.hpp Lines 1871 (patched) <https://reviews.apache.org/r/68296/#comment291059> Remove this blank line - Alexander Rukletsov On Aug. 17, 2018,

Re: Review Request 68343: Moved state serialization into separate function.

2018-08-20 Thread Alexander Rukletsov
che.org/r/68343/#comment291056> corresponding what? src/master/master.hpp Lines 1398 (patched) <https://reviews.apache.org/r/68343/#comment291058> On the previous line please. - Alexander Rukletsov On Aug. 17, 2018, 7:06

Re: Review Request 68348: Fixed wrong `mnt` namespace detection for non-command executor tasks.

2018-08-17 Thread Alexander Rukletsov
erizer.cpp Lines 1952 (patched) <https://reviews.apache.org/r/68348/#comment290943> s/enter task's/enter the task's - Alexander Rukletsov On Aug. 14, 2018, 5:26 p.m., Andrei Budnik wrote: > > --- > This is an automatic

Re: Review Request 68408: Added `ROOT_CGROUPS_LaunchNestedDebugAfterUnshareMntNamespace` test.

2018-08-17 Thread Alexander Rukletsov
without the subsequent https://reviews.apache.org/r/68348 patch? If so, can you please update the "testing done" section saying so? - Alexander Rukletsov On Aug. 17, 2018, 12:17 p.m., Andrei Budnik wrote: > > --- > This

Re: Review Request 68257: Fixed incorrect `mnt` namespace detection of command executor's task.

2018-08-17 Thread Alexander Rukletsov
g/r/68257/#comment290938> Let's unite `candidate` and `hasGrandchild` into `Option candidate;` src/slave/containerizer/mesos/utils.cpp Line 120 (original), 139 (patched) <https://reviews.apache.org/r/68257/#comment290939> This will then become `candidate.getOrElse(parent);` - Alexander

Re: Review Request 68256: Added `LaunchNestedContainerSessionInParallel` test.

2018-08-17 Thread Alexander Rukletsov
arameters and less on the boilerplate code. Same for the snippet below. - Alexander Rukletsov On Aug. 7, 2018, 1:46 p.m., Andrei Budnik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 68321: Add '/state-summary' to batched master endpoints.

2018-08-16 Thread Alexander Rukletsov
tps://reviews.apache.org/r/68321/#comment290801> It can remain const! - Alexander Rukletsov On Aug. 13, 2018, 1:46 p.m., Benno Evers wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://

Re: Review Request 68296: Added 'handler' field to batched requests.

2018-08-16 Thread Alexander Rukletsov
tps://reviews.apache.org/r/68296/#comment290799> Let's keep associate. - Alexander Rukletsov On Aug. 14, 2018, 2:20 p.m., Benno Evers wrote: > > --- > This is an automatically generated e-mail. To reply,

  1   2   3   4   5   6   7   8   9   10   >