Re: Review Request 50217: Added disk full framework to example frameworks unit test.

2016-07-25 Thread Artem Harutyunyan
/tests/examples_tests.cpp ac513ce9aa3c8f366fe81ba937e3dc0d51a26940 Diff: https://reviews.apache.org/r/50217/diff/ Testing --- Thanks, Artem Harutyunyan

Re: Review Request 46626: Added example framework for testing disk quota enforcement.

2016-07-25 Thread Artem Harutyunyan
src/examples/disk_full_framework.cpp PRE-CREATION Diff: https://reviews.apache.org/r/46626/diff/ Testing --- Thanks, Artem Harutyunyan

Review Request 50313: Added Developer Community Status blog post.

2016-07-21 Thread Artem Harutyunyan
PRE-CREATION Diff: https://reviews.apache.org/r/50313/diff/ Testing --- Thanks, Artem Harutyunyan

Re: Review Request 46626: Added example framework for testing disk quota enforcement.

2016-07-20 Thread Artem Harutyunyan
ly, visit: https://reviews.apache.org/r/46626/#review142825 --- On July 19, 2016, 6:23 p.m., Artem Harutyunyan wrote: > > --- > This is an automatically generated e-mai

Re: Review Request 46626: Added example framework for testing disk quota enforcement.

2016-07-19 Thread Artem Harutyunyan
Diff: https://reviews.apache.org/r/46626/diff/ Testing --- Thanks, Artem Harutyunyan

Re: Review Request 46626: Added example framework for testing disk quota enforcement.

2016-07-19 Thread Artem Harutyunyan
o in a followup review. - Artem --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46626/#review142631 --- On July 19, 2016, 12

Re: Review Request 46626: Added example framework for testing disk quota enforcement.

2016-07-19 Thread Artem Harutyunyan
Diff: https://reviews.apache.org/r/46626/diff/ Testing --- Thanks, Artem Harutyunyan

Re: Review Request 46626: Added example framework for testing disk quota enforcement.

2016-07-16 Thread Artem Harutyunyan
gt; Description > --- > > Added example framework for testing disk quota enforcement. > > > Diffs > - > > src/Makefile.am cc83525a4455bbb0e654d346921d66ed2436411d > src/examples/disk_full_framework.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/46626/diff/ > > > Testing > --- > > > Thanks, > > Artem Harutyunyan > >

Re: Review Request 46626: Added example framework for testing disk quota enforcement.

2016-07-16 Thread Artem Harutyunyan
Diff: https://reviews.apache.org/r/46626/diff/ Testing --- Thanks, Artem Harutyunyan

Review Request 49211: Renamed and moved AFFILIATIONS.yml to docs/contributors.yaml.

2016-06-24 Thread Artem Harutyunyan
338241827f3e6a46cc54eb6416b2b9aae4f99b18 Diff: https://reviews.apache.org/r/49211/diff/ Testing --- Thanks, Artem Harutyunyan

Re: Review Request 49170: Added a bullet point on JIRA and a snippet on AFFILIATIONS.yml.

2016-06-23 Thread Artem Harutyunyan
, Artem Harutyunyan

Re: Review Request 49170: Added a bullet point on JIRA and a snippet on AFFILIATIONS.yml.

2016-06-23 Thread Artem Harutyunyan
---- On June 23, 2016, 9:49 p.m., Artem Harutyunyan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49170/ > ---

Re: Review Request 49067: Added AFFILIATIONS.yml file.

2016-06-23 Thread Artem Harutyunyan
of contributors currently missing from the file. Thanks, Artem Harutyunyan

Re: Review Request 49067: Added AFFILIATIONS.yml file.

2016-06-23 Thread Artem Harutyunyan
of contributors currently missing from the file. Thanks, Artem Harutyunyan

Re: Review Request 49067: Added AFFILIATIONS.yml file.

2016-06-23 Thread Artem Harutyunyan
of contributors currently missing from the file. Thanks, Artem Harutyunyan

Re: Review Request 49067: Added AFFILIATIONS.yml file.

2016-06-22 Thread Artem Harutyunyan
the list of contributors currently missing from the file. Thanks, Artem Harutyunyan

Review Request 49067: Added AFFILIATIONS.yml file.

2016-06-22 Thread Artem Harutyunyan
: mesos Description --- Added AFFILIATIONS.yml file. Diffs - AFFILIATIONS.yml PRE-CREATION Diff: https://reviews.apache.org/r/49067/diff/ Testing --- Parsed the file with a test script to validate the syntax. Thanks, Artem Harutyunyan

Re: Review Request 46626: Added example framework for testing disk quota enforcement.

2016-06-07 Thread Artem Harutyunyan
--- Thanks, Artem Harutyunyan

Re: Review Request 46626: Added example framework for testing disk quota enforcement.

2016-06-07 Thread Artem Harutyunyan
ink? I am open to suggestsions. And what do you mean by abort? Exiting the framework? - Artem --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46626/#review134863 -------

Re: Review Request 46626: Added example framework for testing disk quota enforcement.

2016-06-07 Thread Artem Harutyunyan
-CREATION Diff: https://reviews.apache.org/r/46626/diff/ Testing --- Thanks, Artem Harutyunyan

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

2016-02-09 Thread Artem Harutyunyan
> On Feb. 6, 2016, 7:39 p.m., Guangya Liu wrote: > > @Maged, I think that you can now find a shephard for this. You can post an > > email to d...@mesos.apache.org to ask for a shephard for MESOS-4353 Folks, generally the expectation is that the shepherd is found *before* the code gets written

Re: Review Request 41818: Handled quota when volumes are bind mounted into the sandbox.

2016-01-26 Thread Artem Harutyunyan
-- On Jan. 26, 2016, 12:13 a.m., Artem Harutyunyan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41818/ > -

Re: Review Request 41818: Handled quota when volumes are bind mounted into the sandbox.

2016-01-26 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41818/ --- (Updated Jan. 26, 2016, 12:13 a.m.) Review request for Artem Harutyunyan

Re: Review Request 41818: Handled quota when volumes are bind mounted into the sandbox.

2016-01-26 Thread Artem Harutyunyan
------ This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41818/#review116224 --- On Jan. 26, 2016, 12:13 a.m., Artem Harutyunyan wrote: > > ---

Re: Review Request 41818: Handled quota when volumes are bind mounted into the sandbox.

2016-01-26 Thread Artem Harutyunyan
: https://reviews.apache.org/r/41818/diff/ Testing --- sudo mesos-tests.sh Thanks, Artem Harutyunyan

Re: Review Request 41818: Handled quota when volumes are bind mounted into the sandbox.

2016-01-26 Thread Artem Harutyunyan
.apache.org/r/41818/#review116424 --- On Jan. 26, 2016, 10:48 a.m., Artem Harutyunyan wrote: > > --- > This is an automatically generated e-mail. To reply, v

Re: Review Request 42068: Porting Mesos on ppc64le.

2016-01-17 Thread Artem Harutyunyan
the same patch. Could you please break this patch into 2? - Artem Harutyunyan On Jan. 8, 2016, 3:02 a.m., Qian Zhang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 42274: Added common command utils file.

2016-01-14 Thread Artem Harutyunyan
ssion format. http://linux.livejournal.com/1872012.html - Artem Harutyunyan On Jan. 13, 2016, 3:13 p.m., Jojy Varghese wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Review Request 42312: Updated commiter affiliations.

2016-01-14 Thread Artem Harutyunyan
--- Updated commiter affiliations. Diffs - docs/committers.md 0302b5e0578bbf3c530deac0e0ccdcdaed073026 Diff: https://reviews.apache.org/r/42312/diff/ Testing --- Thanks, Artem Harutyunyan

Re: Review Request 41818: WIP: Handled quota when volumes are bind mounted into the sandbox.

2016-01-12 Thread Artem Harutyunyan
: https://reviews.apache.org/r/41818/diff/ Testing --- The test for this is in the works. Thanks, Artem Harutyunyan

Re: Review Request 41818: WIP: Handled quota when volumes are bind mounted into the sandbox.

2016-01-12 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41818/ --- (Updated Jan. 12, 2016, 1:50 p.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 41818: Handled quota when volumes are bind mounted into the sandbox.

2016-01-12 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41818/ --- (Updated Jan. 12, 2016, 3:48 p.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 41818: WIP: Handled quota when volumes are bind mounted into the sandbox.

2016-01-07 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41818/ --- (Updated Jan. 7, 2016, 4 p.m.) Review request for mesos and Artem Harutyunyan

Re: Review Request 41705: Added support for enforcing quota on (persistent) volumes (MESOS-4198).

2016-01-04 Thread Artem Harutyunyan
d971db09083faad08f3cf18c25a79245321d1d9a src/tests/disk_quota_tests.cpp ce736c32a9e78a8a6d0793a06fe87911b9b0558d Diff: https://reviews.apache.org/r/41705/diff/ Testing --- GTEST_FILTER='DiskQuotaTest*' make check -j8 Thanks, Artem Harutyunyan

Re: Review Request 41705: Added support for enforcing quota on (persistent) volumes (MESOS-4198).

2015-12-30 Thread Artem Harutyunyan
sit: https://reviews.apache.org/r/41705/#review111902 --- On Dec. 28, 2015, 11:36 a.m., Artem Harutyunyan wrote: > > --- > This is an automatically generated e-mail. To reply, v

Re: Review Request 41586: Partially enforced commit message guidelines with a hook.

2015-12-30 Thread Artem Harutyunyan
/ Testing --- Thanks, Artem Harutyunyan

Re: Review Request 41705: Added support for enforcing quota on (persistent) volumes (MESOS-4198).

2015-12-30 Thread Artem Harutyunyan
eviews.apache.org/r/41705/#review112343 --- On Dec. 30, 2015, 4:01 p.m., Artem Harutyunyan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41705/ > ---

Re: Review Request 41705: Added support for enforcing quota on (persistent) volumes (MESOS-4198).

2015-12-30 Thread Artem Harutyunyan
d971db09083faad08f3cf18c25a79245321d1d9a src/tests/disk_quota_tests.cpp ce736c32a9e78a8a6d0793a06fe87911b9b0558d Diff: https://reviews.apache.org/r/41705/diff/ Testing --- GTEST_FILTER='DiskQuotaTest*' make check -j8 Thanks, Artem Harutyunyan

Re: Review Request 41704: Added support for checking whether a given path is absolute.

2015-12-30 Thread Artem Harutyunyan
3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp 4374e64b499db3e47f62f562cb51b0640144ec6a Diff: https://reviews.apache.org/r/41704/diff/ Testing --- Ran stout tests. Thanks, Artem Harutyunyan

Re: Review Request 41704: Added support for checking whether a given path is absolute.

2015-12-30 Thread Artem Harutyunyan
3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp 4374e64b499db3e47f62f562cb51b0640144ec6a Diff: https://reviews.apache.org/r/41704/diff/ Testing --- Ran stout tests. Thanks, Artem Harutyunyan

Re: Review Request 41705: Added support for enforcing quota on (persistent) volumes (MESOS-4198).

2015-12-28 Thread Artem Harutyunyan
Thanks, Artem Harutyunyan

Re: Review Request 41704: Added support for checking whether a given path is absolute.

2015-12-28 Thread Artem Harutyunyan
/libprocess/3rdparty/stout/include/stout/path.hpp 0b986f0898da95c4cffd8bde1adfd9994d567096 3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp 821dbb185f09e2f279d95fd354ce2168cddf1bac Diff: https://reviews.apache.org/r/41704/diff/ Testing --- Ran stout tests. Thanks, Artem

Re: Review Request 41704: WIP: Added support for checking whether a given path is absolute.

2015-12-25 Thread Artem Harutyunyan
3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp 821dbb185f09e2f279d95fd354ce2168cddf1bac Diff: https://reviews.apache.org/r/41704/diff/ Testing --- Ran stout tests. Thanks, Artem Harutyunyan

Re: Review Request 41705: WIP: Added support for enforcing quota on (persistent) volumes (MESOS-4198).

2015-12-25 Thread Artem Harutyunyan
d971db09083faad08f3cf18c25a79245321d1d9a src/tests/disk_quota_tests.cpp ce736c32a9e78a8a6d0793a06fe87911b9b0558d Diff: https://reviews.apache.org/r/41705/diff/ Testing --- GTEST_FILTER='DiskQuotaTest*' make check -j8 Thanks, Artem Harutyunyan

Re: Review Request 41586: Partially enforced commit message guidelines with a hook.

2015-12-25 Thread Artem Harutyunyan
ues.apache.org/jira/browse/MESOS-4250 to follow up. - Artem ----------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41586/#review111839 --

Re: Review Request 41584: Added commit message guidelines to docs.

2015-12-25 Thread Artem Harutyunyan
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41584/#review111372 --- On Dec. 19, 2015, 12:18 a.m., Artem Harutyunyan wrote: > >

Re: Review Request 41586: Partially enforced commit message guidelines with a hook.

2015-12-25 Thread Artem Harutyunyan
/ Testing --- Thanks, Artem Harutyunyan

Review Request 41706: Added Qunar to Powered by Mesos page.

2015-12-24 Thread Artem Harutyunyan
Description --- https://github.com/apache/mesos/pull/83 Diffs - docs/powered-by-mesos.md bbcac44570506b7e2bdd06ac0ab2204b0417314e Diff: https://reviews.apache.org/r/41706/diff/ Testing --- Thanks, Artem Harutyunyan

Review Request 41704: WIP: Added support for checking whether a given path is absolute.

2015-12-23 Thread Artem Harutyunyan
/path_tests.cpp 821dbb185f09e2f279d95fd354ce2168cddf1bac Diff: https://reviews.apache.org/r/41704/diff/ Testing --- Ran stout tests. Thanks, Artem Harutyunyan

Review Request 41705: WIP: Added support for enforcing quota on (persistent) volumes (MESOS-4198).

2015-12-23 Thread Artem Harutyunyan
ce736c32a9e78a8a6d0793a06fe87911b9b0558d Diff: https://reviews.apache.org/r/41705/diff/ Testing --- GTEST_FILTER='DiskQuotaTest*' make check -j8 Thanks, Artem Harutyunyan

Review Request 41584: Added commit message guidelines to docs.

2015-12-19 Thread Artem Harutyunyan
. Repository: mesos Description --- Added commit message guidelines to docs. Diffs - docs/submitting-a-patch.md f0048f51395422645a520b61815c1ae3c7004aa3 Diff: https://reviews.apache.org/r/41584/diff/ Testing --- Thanks, Artem Harutyunyan

Review Request 41586: Partially enforced commit message guidelines with a hook.

2015-12-19 Thread Artem Harutyunyan
. Repository: mesos Description --- Partially enforced commit message guidelines with a hook. Diffs - bootstrap 89d986fd95dc16bbb79623ef92e3b14a2e7009f9 support/hooks/commit-msg PRE-CREATION Diff: https://reviews.apache.org/r/41586/diff/ Testing --- Thanks, Artem Harutyunyan

Re: Review Request 41420: Added ContainerInfo to internal Task protobuf.

2015-12-18 Thread Artem Harutyunyan
://reviews.apache.org/r/41420/diff/ Testing --- Thanks, Artem Harutyunyan

Re: Review Request 41426: Changed MergeFrom() to CopyFrom() in protobuf::createTask().

2015-12-18 Thread Artem Harutyunyan
://reviews.apache.org/r/41426/diff/ Testing --- Thanks, Artem Harutyunyan

Re: Review Request 41423: Exposed partial contents of ContainerInfo through the state endpoint.

2015-12-18 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41423/ --- (Updated Dec. 18, 2015, 3:12 p.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 41422: Removed manual construction of Task in master.

2015-12-18 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41422/ --- (Updated Dec. 18, 2015, 3:10 p.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 41420: Added ContainerInfo to internal Task protobuf.

2015-12-18 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41420/ --- (Updated Dec. 18, 2015, 3:48 p.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 41422: Removed manual construction of Task in master.

2015-12-18 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41422/ --- (Updated Dec. 18, 2015, 3:49 p.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 41571: Removed deprecated code.

2015-12-18 Thread Artem Harutyunyan
. Repository: mesos Description --- Removed deprecated code. Diffs (updated) - src/tests/containerizer/docker_containerizer_tests.cpp 3f199e622dd337cdbf32d4368f4ead424c39823c Diff: https://reviews.apache.org/r/41571/diff/ Testing --- Thanks, Artem Harutyunyan

Re: Review Request 41426: Changed MergeFrom() to CopyFrom() in protobuf::createTask().

2015-12-18 Thread Artem Harutyunyan
://reviews.apache.org/r/41426/diff/ Testing --- Thanks, Artem Harutyunyan

Re: Review Request 41423: Exposed partial contents of ContainerInfo through the state endpoint.

2015-12-18 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41423/ --- (Updated Dec. 18, 2015, 3:58 p.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 41420: Added ContainerInfo to internal Task protobuf.

2015-12-18 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41420/ --- (Updated Dec. 18, 2015, 3:04 p.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 41421: Modified ptotobuf::createTask to use ContainerInfo from internal Task protobuf.

2015-12-18 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41421/ --- (Updated Dec. 18, 2015, 3:09 p.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 41571: Removed deprecated code.

2015-12-18 Thread Artem Harutyunyan
. Repository: mesos Description --- Removed deprecated code. Diffs (updated) - src/tests/containerizer/docker_containerizer_tests.cpp 3f199e622dd337cdbf32d4368f4ead424c39823c Diff: https://reviews.apache.org/r/41571/diff/ Testing --- Thanks, Artem Harutyunyan

Review Request 41571: Removed deprecated code.

2015-12-18 Thread Artem Harutyunyan
--- Removed deprecated code. Diffs - src/tests/containerizer/docker_containerizer_tests.cpp 3f199e622dd337cdbf32d4368f4ead424c39823c Diff: https://reviews.apache.org/r/41571/diff/ Testing --- Thanks, Artem Harutyunyan

Re: Review Request 41423: Exposed partial contents of ContainerInfo through the state endpoint.

2015-12-18 Thread Artem Harutyunyan
> (Updated Dec. 18, 2015, 2:45 p.m.) > > > Review request for mesos, Artem Harutyunyan and Jie Yu. > > > Bugs: MESOS-4064 > https://issues.apache.org/jira/browse/MESOS-4064 > > > Repository: mesos > > > Description > --- > > Exposed

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-18 Thread Artem Harutyunyan
1637) <https://reviews.apache.org/r/41380/#comment171418> s/IP used/IPs are used/? - Artem Harutyunyan On Dec. 17, 2015, 2:41 p.m., Avinash sridharan wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 41423: Exposed partial contents of ContainerInfo through the state endpoint.

2015-12-18 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41423/ --- (Updated Dec. 18, 2015, 2:45 p.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-18 Thread Artem Harutyunyan
> On Dec. 18, 2015, 2:54 p.m., Artem Harutyunyan wrote: > > Commit messages should usually end with a period. - Artem --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41380/#rev

Re: Review Request 41381: Added unit test cases to test the new vip and instance_port fields

2015-12-18 Thread Artem Harutyunyan
/#comment171523> Ditto as above. But please submit a follow up patch if you decide to switch these (and possible other) occurences as well. - Artem Harutyunyan On Dec. 17, 2015, 3:15 p.m., Avinash sridharan wrote: > > --- &g

Re: Review Request 41380: Added repeated vip field to DiscoveryInfo and an instance_port field to Port

2015-12-18 Thread Artem Harutyunyan
> On Dec. 17, 2015, 5:40 p.m., Adam B wrote: > > Let's get rid of the Vips message per MPark's recommendation, since we're > > unlikely to ever add any more fields to that message. Could you please also clean the `Depends On` field for this review? - Artem

Re: Review Request 41420: Added ContainerInfo to internal Task protobuf.

2015-12-17 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41420/ --- (Updated Dec. 17, 2015, 9:39 a.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 41421: Modified ptotobuf::createTask to use ContainerInfo from internal Task protobuf.

2015-12-17 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41421/ --- (Updated Dec. 17, 2015, 9:39 a.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 41422: Removed manual construction of Task in master.

2015-12-17 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41422/ --- (Updated Dec. 17, 2015, 9:40 a.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 41421: Modified ptotobuf::createTask to use ContainerInfo from internal Task protobuf.

2015-12-17 Thread Artem Harutyunyan
--- Thanks, Artem Harutyunyan

Re: Review Request 41423: Exposed partial contents of ContainerInfo through the state endpoint.

2015-12-17 Thread Artem Harutyunyan
3f199e622dd337cdbf32d4368f4ead424c39823c Diff: https://reviews.apache.org/r/41423/diff/ Testing --- make check Thanks, Artem Harutyunyan

Re: Review Request 41421: Modified ptotobuf::createTask to use ContainerInfo from internal Task protobuf.

2015-12-17 Thread Artem Harutyunyan
Diff: https://reviews.apache.org/r/41421/diff/ Testing --- Thanks, Artem Harutyunyan

Re: Review Request 41422: Removed manual construction of Task in master.

2015-12-17 Thread Artem Harutyunyan
/diff/ Testing --- Thanks, Artem Harutyunyan

Re: Review Request 41420: Added ContainerInfo to internal Task protobuf.

2015-12-17 Thread Artem Harutyunyan
/41420/diff/ Testing --- Thanks, Artem Harutyunyan

Re: Review Request 41423: Exposed partial contents of ContainerInfo through the state endpoint.

2015-12-17 Thread Artem Harutyunyan
/containerizer/docker_containerizer_tests.cpp 3f199e622dd337cdbf32d4368f4ead424c39823c Diff: https://reviews.apache.org/r/41423/diff/ Testing --- make check Thanks, Artem Harutyunyan

Re: Review Request 41423: Exposed partial contents of ContainerInfo through the state endpoint.

2015-12-16 Thread Artem Harutyunyan
6e1eb0b8465809d1da5dac1cd29b692b9fa6ff66 src/tests/containerizer/docker_containerizer_tests.cpp 3f199e622dd337cdbf32d4368f4ead424c39823c Diff: https://reviews.apache.org/r/41423/diff/ Testing (updated) --- make check Thanks, Artem Harutyunyan

Re: Review Request 39410: Added support for github to apply-reviews.py.

2015-12-10 Thread Artem Harutyunyan
) - support/apply-reviews.py 6ea229facebf6ee071c0d0186fd1f702e0c48a39 Diff: https://reviews.apache.org/r/39410/diff/ Testing --- Tested with python 2.7 Thanks, Artem Harutyunyan

Re: Review Request 39410: Added support for github to apply-reviews.py.

2015-12-10 Thread Artem Harutyunyan
-reviews.py 6ea229facebf6ee071c0d0186fd1f702e0c48a39 Diff: https://reviews.apache.org/r/39410/diff/ Testing --- Tested with python 2.7 Thanks, Artem Harutyunyan

Re: Review Request 41178: Fixed a message dropping bug in the health checker.

2015-12-09 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41178/#review109668 --- Ship it! Ship It! - Artem Harutyunyan On Dec. 9, 2015, 6:01

Re: Review Request 41178: Fixed a message dropping bug in the health checker.

2015-12-09 Thread Artem Harutyunyan
org/r/41178/#comment169263> Do we need to create a JIRA for eventually get rid of the hack? - Artem Harutyunyan On Dec. 9, 2015, 6:01 p.m., Ben Mahler wrote: > > --- > This is an automatically generated e-mail. To reply,

Review Request 41182: Exposed task health flag through the state endpoint on master and slave.

2015-12-09 Thread Artem Harutyunyan
b1454b085b36bb7c4d8ef012c764cd8466b4fb02 Diff: https://reviews.apache.org/r/41182/diff/ Testing --- make check Thanks, Artem Harutyunyan

Re: Review Request 40241: Fixed a bug with hanging editor reported by Ben Mahler.

2015-11-14 Thread Artem Harutyunyan
git commit. To mitigate that I switched to `subprocess.call()` and did some code refactoring to accomodate that change. Diffs (updated) - support/apply-reviews.py d39ee9bb0ee782bd756b7a5fc0dec70d056c9589 Diff: https://reviews.apache.org/r/40241/diff/ Testing --- Thanks, Artem

Re: Review Request 39410: Added support for github to apply-reviews.py.

2015-11-14 Thread Artem Harutyunyan
) - support/apply-reviews.py d39ee9bb0ee782bd756b7a5fc0dec70d056c9589 Diff: https://reviews.apache.org/r/39410/diff/ Testing --- Tested with python 2.7 Thanks, Artem Harutyunyan

Re: Review Request 39410: Added support for github to apply-reviews.py.

2015-11-14 Thread Artem Harutyunyan
commit -c ORIG_HEAD ``` - Artem --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39410/#review105939 --- On Nov. 12, 2015, 10

Re: Review Request 40225: Fixed the Review Board URL in the commit message.

2015-11-14 Thread Artem Harutyunyan
Diff: https://reviews.apache.org/r/40225/diff/ Testing --- Thanks, Artem Harutyunyan

Re: Review Request 39420: Added '--chain' option to apply-reviews.py.

2015-11-14 Thread Artem Harutyunyan
d39ee9bb0ee782bd756b7a5fc0dec70d056c9589 Diff: https://reviews.apache.org/r/39420/diff/ Testing --- Tested with python 2.7. - With and without '-c'. - Tested reviews with and without parents. Thanks, Artem Harutyunyan

Re: Review Request 40241: Fixed apply-reviews.py to prevent git commit editors from hanging.

2015-11-14 Thread Artem Harutyunyan
/ Testing --- Thanks, Artem Harutyunyan

Re: Review Request 40225: Fixed the Review Board URL in the commit message; substituted subprocess.call_check() with subprocess.call().

2015-11-12 Thread Artem Harutyunyan
/diff/ Testing --- Thanks, Artem Harutyunyan

Re: Review Request 39410: Added support for github to apply-reviews.py.

2015-11-12 Thread Artem Harutyunyan
d39ee9bb0ee782bd756b7a5fc0dec70d056c9589 Diff: https://reviews.apache.org/r/39410/diff/ Testing --- Tested with python 2.7 Thanks, Artem Harutyunyan

Re: Review Request 39420: Added '--chain' option to apply-reviews.py.

2015-11-12 Thread Artem Harutyunyan
d39ee9bb0ee782bd756b7a5fc0dec70d056c9589 Diff: https://reviews.apache.org/r/39420/diff/ Testing --- Tested with python 2.7. - With and without '-c'. - Tested reviews with and without parents. Thanks, Artem Harutyunyan

Re: Review Request 40129: Updated apply-review.sh to use apply-reviews.py.

2015-11-12 Thread Artem Harutyunyan
6391451542e9e8847ec38e2ad9d9acf552afead3 Diff: https://reviews.apache.org/r/40129/diff/ Testing --- Thanks, Artem Harutyunyan

Re: Review Request 40129: Updated apply-review.sh to use apply-reviews.py.

2015-11-12 Thread Artem Harutyunyan
gt; with existing tooling? is that plan to kill this eventually? worth adding > > some comments/TODO/JIRA for this. > > Artem Harutyunyan wrote: > Here is the JIRA https://issues.apache.org/jira/browse/MESOS-3885. > > `verify_reviews.py` still references apply-review

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

2015-11-12 Thread Artem Harutyunyan
views.apache.org/r/38876 > > ``` Fixed in https://reviews.apache.org/r/40225/. - Artem --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/#review106053 --

Re: Review Request 40225: Fixed the Review Board URL in the commit message; substituted subprocess.call_check() with subprocess.call().

2015-11-12 Thread Artem Harutyunyan
/diff/ Testing --- Thanks, Artem Harutyunyan

Re: Review Request 39410: Added support for github to apply-reviews.py.

2015-11-12 Thread Artem Harutyunyan
d39ee9bb0ee782bd756b7a5fc0dec70d056c9589 Diff: https://reviews.apache.org/r/39410/diff/ Testing --- Tested with python 2.7 Thanks, Artem Harutyunyan

  1   2   3   4   >