Re: Review Request 45000: MESOS-3902: [Updated] Fix location header in redirect from non-leader.

2016-03-25 Thread Ashwin Murthy
at NOTE as the bug is attached to this review and the > commit will be pasted to that ticket. I'll remove it while committing. > > > - Vinod Kone > > On March 24th, 2016, 2:24 a.m. UTC, Ashwin Murthy wrote: > Review request for mesos and Vinod Kone. > By Ashwin Murthy.

Re: Review Request 45000: MESOS-3902: [Updated] Fix location header in redirect from non-leader.

2016-03-23 Thread Ashwin Murthy
) - src/master/http.cpp 97e4b0ce3286540788e3e6c5b484687b83e000f6 Diff: https://reviews.apache.org/r/45000/diff/ Testing (updated) --- This has been tested end to end with 3 local mesos masters and zk. Valided the location header is now correct. Thanks, Ashwin Murthy

Re: Review Request 45000: MESOS-3902: Fix in location header during redirect from non-leader.

2016-03-23 Thread Ashwin Murthy
- src/master/http.cpp bfea8fa811c24d37b2d7a8109728e1f40217e02f Diff: https://reviews.apache.org/r/45000/diff/ Testing (updated) --- This has been tested end to end Thanks, Ashwin Murthy

Re: Review Request 45000: MESOS-3902: Fix in location header during redirect from non-leader.

2016-03-23 Thread Ashwin Murthy
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45000/#review124472 --- On March 20, 2016, 11:03 p.m., Ashwin Murthy wrote: > >

Re: Review Request 45000: MESOS-3902: Fix in location header during redirect from non-leader.

2016-03-20 Thread Ashwin Murthy
verify this by setting up multiple masters with ZK. Thanks, Ashwin Murthy

Re: Review Request 45000: MESOS-3902: Fix in location header during redirect from non-leader.

2016-03-20 Thread Ashwin Murthy
tests cannot be written at this point. Need to manually verify this by setting up multiple masters with ZK. Thanks, Ashwin Murthy

Re: Review Request 45000: MESOS-3902: Fix in location header during redirect from non-leader.

2016-03-20 Thread Ashwin Murthy
but it turns out multi master tests cannot be written at this point. Need to manually verify this by setting up multiple masters with ZK. Thanks, Ashwin Murthy

Re: Review Request 45078: MESOS-3902: Fix location header in redirect from non-leader.

2016-03-20 Thread Ashwin Murthy
sit: https://reviews.apache.org/r/45078/#review124455 --- On March 19, 2016, 9:57 p.m., Ashwin Murthy wrote: > > --- > This is an automatically generated e-mail. To reply, v

Review Request 45000: MESOS-3902: Fix in location header during redirect from non-leader.

2016-03-19 Thread Ashwin Murthy
this by setting up multiple masters with ZK. Thanks, Ashwin Murthy

Review Request 45078: MESOS-3902: Fix location header in redirect from non-leader.

2016-03-19 Thread Ashwin Murthy
/ Testing --- Manual testing to be done. Testing framework does not support multi-master tests as yet. Thanks, Ashwin Murthy

Re: Review Request 45000: MESOS-3902: Fix in location header during redirect from non-leader.

2016-03-19 Thread Ashwin Murthy
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45000/#review124350 ----------- On March 18, 2016, 12:04 a.m., Ashwin Murthy wrote: > > -

Review Request 44971: MESOS-3902: Fix location header in redirect from non-leading master.

2016-03-19 Thread Ashwin Murthy
--- None yet. Was attempting to write a test but turns there is no good way to test multi master in our testing framework. Will need to test this manually by launching multiple masters with ZK setup. Doing that in parallel Thanks, Ashwin Murthy