Review Request 70034: Consistently used `override` in tests' `BlockingAuthorizer`.

2019-02-21 Thread Benjamin Bannier
Description --- Consistently used `override` in tests' `BlockingAuthorizer`. Diffs - src/tests/master_load_tests.cpp 4e9c8e89d50a7a93f3e25b7120f4d2ec4e44a0c8 Diff: https://reviews.apache.org/r/70034/diff/1/ Testing --- `make check` Thanks, Benjamin Bannier

Re: Review Request 70022: Added master load tests to cmake build.

2019-02-21 Thread Benjamin Bannier
> On Feb. 20, 2019, 4:17 p.m., Benjamin Bannier wrote: > > LGTM. We should also run `support/mesos-tidy.sh`. That setup depends on > > cmake and we could see new failures from adding the file there. I kicked > > off a run. > > Benjamin Bannier wrote: > Ou

Re: Review Request 70026: Increased the number of review requests queried by ReviewBot to 200.

2019-02-20 Thread Benjamin Bannier
(patched) <https://reviews.apache.org/r/70026/#comment298844> I think moving this up to the declaration of `query_parameters` would provide more context (e.g., that 200 is the possible max value). - Benjamin Bannier On Feb. 20, 2019, 10:25 p.m., Vinod Kone

Re: Review Request 70022: Added master load tests to cmake build.

2019-02-20 Thread Benjamin Bannier
> On Feb. 20, 2019, 4:17 p.m., Benjamin Bannier wrote: > > LGTM. We should also run `support/mesos-tidy.sh`. That setup depends on > > cmake and we could see new failures from adding the file there. I kicked > > off a run. Our tidy checks report something here, `

Re: Review Request 70022: Added master load tests to cmake build.

2019-02-20 Thread Benjamin Bannier
`. That setup depends on cmake and we could see new failures from adding the file there. I kicked off a run. - Benjamin Bannier On Feb. 20, 2019, 4:06 p.m., Benno Evers wrote: > > --- > This is an automatically generated e-mail. To rep

Review Request 70012: Fixed type error in verify-reviews.py.

2019-02-19 Thread Benjamin Bannier
pache.org/api/review-requests/69955/reviews/: UNAUTHORIZED (b'{"stat": "fail", "err": {"msg": "The username or password was not correct", "code": 104}}') a213091210c72ff6c2fc2d20a25d886d9c16c278 ``` If `post_review` is defined as `return` additional reviews are validated after 69955. Thanks, Benjamin Bannier

Re: Review Request 70000: Fixed verify-reviews.py to not abort review verification prematurely.

2019-02-19 Thread Benjamin Bannier
on the last patch in the chain instead of aborting (see the `TODO` in the code on why we weren't able to diagnose the issue in the faulty patch with the current implementation). Thanks, Benjamin Bannier

Re: Review Request 70000: Fixed verify-reviews.py to not abort review verification prematurely.

2019-02-19 Thread Benjamin Bannier
o catch this exception. > > what if we don't get into this for loop at all if it's a single review > > chain? > > > > i think it should be in #197. > > Benjamin Bannier wrote: > Good point. It seems it _also_ needs to be in l.197, but we still

Re: Review Request 70000: Fixed verify-reviews.py to not abort review verification prematurely.

2019-02-19 Thread Benjamin Bannier
patch in the chain instead of aborting (see the `TODO` in the code on why we weren't able to diagnose the issue in the faulty patch with the current implementation). Thanks, Benjamin Bannier

Re: Review Request 70000: Fixed verify-reviews.py to not abort review verification prematurely.

2019-02-19 Thread Benjamin Bannier
reply, visit: https://reviews.apache.org/r/7/#review212917 ------- On Feb. 19, 2019, 5:53 p.m., Benjamin Bannier wrote: > > --- > This is an automatically

Re: Review Request 70000: Fixed verify-reviews.py to not abort review verification prematurely.

2019-02-19 Thread Benjamin Bannier
patch in the chain instead of aborting (see the `TODO` in the code on why we weren't able to diagnose the issue in the faulty patch with the current implementation). Thanks, Benjamin Bannier

Re: Review Request 70000: Fixed verify-reviews.py to not abort review verification prematurely.

2019-02-19 Thread Benjamin Bannier
the `TODO` in the code on why we weren't able to diagnose the issue in the faulty patch with the current implementation). Thanks, Benjamin Bannier

Re: Review Request 70000: Fixed verify-reviews.py to not abort review verification prematurely.

2019-02-19 Thread Benjamin Bannier
to post a review on the last patch in the chain instead of aborting (see the `TODO` in the code on why we weren't able to diagnose the issue in the faulty patch with the current implementation). Thanks, Benjamin Bannier

Re: Review Request 69898: Updated `CreateDestroyDisk*` SLRP tests to test pipelined operations.

2019-02-18 Thread Benjamin Bannier
> On Feb. 12, 2019, 4:10 p.m., Benjamin Bannier wrote: > > src/tests/storage_local_resource_provider_tests.cpp > > Line 818 (original), 817 (patched) > > <https://reviews.apache.org/r/69898/diff/2/?file=2124911#file2124911line838> > > > > Is this need

Re: Review Request 69994: Added a test `ROOT_EmptyCheckpointFileSlaveRecovery`.

2019-02-18 Thread Benjamin Bannier
> On Feb. 15, 2019, 2:39 p.m., Andrei Budnik wrote: > > src/tests/containerizer/docker_volume_isolator_tests.cpp > > Lines 851 (patched) > > > > > > Consider `Owned mockClient`? > > Qian Zhang wrote: > What is

Review Request 70000: Fixed verify-reviews.py to not abort review verification prematurely.

2019-02-17 Thread Benjamin Bannier
implementation). Thanks, Benjamin Bannier

Review Request 69998: Reformated verify-reviews.py with yapf.

2019-02-17 Thread Benjamin Bannier
as part of https://reviews.apache.org/r/7/ Thanks, Benjamin Bannier

Review Request 69999: Fixed some lint issues in verify-reviews.py.

2019-02-17 Thread Benjamin Bannier
://reviews.apache.org/r/7/ Thanks, Benjamin Bannier

Re: Review Request 69890: Added test for per-framework, per-role minimal allocatable resources.

2019-02-14 Thread Benjamin Bannier
Diff: https://reviews.apache.org/r/69890/diff/5/ Changes: https://reviews.apache.org/r/69890/diff/4-5/ Testing --- `make check` Thanks, Benjamin Bannier

Re: Review Request 69862: Validated static framework offer filters.

2019-02-14 Thread Benjamin Bannier
://reviews.apache.org/r/69862/diff/4-5/ Testing --- `make check` Thanks, Benjamin Bannier

Re: Review Request 69890: Added test for per-framework, per-role minimal allocatable resources.

2019-02-14 Thread Benjamin Bannier
ate? Come to think of it, should we > > validate that all entries are non-empty? There doesn't seem to be any point > > in allowing an empty entry, since any single empty entry renders it > > equivalent to the empty set case? > > Benjamin Bannier wrote: > Fixed

Re: Review Request 69818: Added offer filters to static framework configuration.

2019-02-14 Thread Benjamin Bannier
: https://reviews.apache.org/r/69818/diff/11/ Changes: https://reviews.apache.org/r/69818/diff/10-11/ Testing --- `make check` Thanks, Benjamin Bannier

Re: Review Request 69890: Added test for per-framework, per-role minimal allocatable resources.

2019-02-13 Thread Benjamin Bannier
ate? Come to think of it, should we > > validate that all entries are non-empty? There doesn't seem to be any point > > in allowing an empty entry, since any single empty entry renders it > > equivalent to the empty set case? > > Benjamin Bannier wrote: > Fixed

Re: Review Request 69890: Added test for per-framework, per-role minimal allocatable resources.

2019-02-13 Thread Benjamin Bannier
Diff: https://reviews.apache.org/r/69890/diff/4/ Changes: https://reviews.apache.org/r/69890/diff/3-4/ Testing --- `make check` Thanks, Benjamin Bannier

Re: Review Request 69862: Validated static framework offer filters.

2019-02-13 Thread Benjamin Bannier
b34e88f12a8959989aea5c180b15f8ae2933d33f Diff: https://reviews.apache.org/r/69862/diff/4/ Changes: https://reviews.apache.org/r/69862/diff/3-4/ Testing --- `make check` Thanks, Benjamin Bannier

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

2019-02-13 Thread Benjamin Bannier
-090dab729358__new_over_old.png Thanks, Benjamin Bannier

Re: Review Request 69942: Added a test for MESOS-9554.

2019-02-12 Thread Benjamin Bannier
> On Feb. 12, 2019, 7:34 p.m., Benjamin Bannier wrote: > > src/tests/hierarchical_allocator_tests.cpp > > Lines 2924-2929 (patched) > > <https://reviews.apache.org/r/69942/diff/1/?file=2124739#file2124739line2924> > > > > This test actually is mor

Re: Review Request 69892: Made SLRP recover node-published volumes after reboot.

2019-02-12 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69892/#review212764 --- Ship it! Ship It! - Benjamin Bannier On Feb. 12, 2019, 9:42

Re: Review Request 69942: Added a test for MESOS-9554.

2019-02-12 Thread Benjamin Bannier
rent"))? .pushReservation(createDynamicReservationInfo("parent/child"));? ``` - Benjamin Bannier On Feb. 11, 2019, 7:21 p.m., Benjamin Mahler wrote: > > --- > This is an automatically generated e-ma

Re: Review Request 69905: Added a SLRP unit test for failed persistent volume cleanup.

2019-02-12 Thread Benjamin Bannier
/storage_local_resource_provider_tests.cpp Lines 2814-2815 (patched) <https://reviews.apache.org/r/69905/#comment298644> Is this actually needed? With just the default filters the test still passes. Could you either remove this or document where it is needed (e.g., to address flakiness)? - Benjamin Bannier On

Re: Review Request 69904: Extracted common offer matching functions from SLRP tests.

2019-02-12 Thread Benjamin Bannier
/storage_local_resource_provider_tests.cpp Lines 334 (patched) <https://reviews.apache.org/r/69904/#comment298642> Could you briefly document what these do? We could just declare these outside of the class in this file instead of them being `static`. - Benjamin Bannier On Feb. 12, 2019, 6:26 a.m., Chu

Re: Review Request 69898: Updated `CreateDestroyDisk*` SLRP tests to test pipelined operations.

2019-02-12 Thread Benjamin Bannier
1094-1095 (patched) <https://reviews.apache.org/r/69898/#comment298641> Could document ordering of `unreserve` and `destroy_disk` here. - Benjamin Bannier On Feb. 12, 2019, 6:26 a.m., Chun-Hung Hsiao wrote: > > --- > Thi

Re: Review Request 69897: Made SLRP `PublishResourcesRecovery` test to check volume cleanup.

2019-02-12 Thread Benjamin Bannier
src/tests/storage_local_resource_provider_tests.cpp Line 2255 (original), 2283 (patched) <https://reviews.apache.org/r/69897/#comment298637> Could us operation status update, see previous RRs. - Benjamin Bannier On Feb. 12, 2019, 6:24 a.m., Chu

Re: Review Request 69896: Made SLRP `PublishResourcesReboot` test to check persistent volume cleanup.

2019-02-12 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69896/#review212741 --- Ship it! Ship It! - Benjamin Bannier On Feb. 12, 2019, 6:22

Re: Review Request 69896: Made SLRP `PublishResourcesReboot` test to check persistent volume cleanup.

2019-02-12 Thread Benjamin Bannier
obably merge this note with the one mentioning MESOS-9553. src/tests/storage_local_resource_provider_tests.cpp Line 2564 (original), 2598 (patched) <https://reviews.apache.org/r/69896/#comment298633> Wait for an operation status update here? - Benjamin Bannier On Feb. 12, 2019, 6:

Re: Review Request 69895: Made SLRP `PublishResources` test to check persistent volume cleanup.

2019-02-12 Thread Benjamin Bannier
clearer and closer to what we want to me. - Benjamin Bannier On Feb. 12, 2019, 6:20 a.m., Chun-Hung Hsiao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 69893: Clean up persistent volumes on SLRP disks.

2019-02-12 Thread Benjamin Bannier
> On Feb. 5, 2019, 6:55 p.m., Benjamin Bannier wrote: > > src/resource_provider/storage/provider.cpp > > Lines 3244 (patched) > > <https://reviews.apache.org/r/69893/diff/1/?file=2123916#file2123916line3246> > > > > Does this break seemless upgra

Re: Review Request 69893: Clean up persistent volumes on SLRP disks.

2019-02-12 Thread Benjamin Bannier
t; This could be `const.` - Benjamin Bannier On Feb. 12, 2019, 6:19 a.m., Chun-Hung Hsiao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 69892: Made SLRP recover node-published volumes after reboot.

2019-02-12 Thread Benjamin Bannier
298623> Hmm, executing this only on the `!node_publish_required` path seems asymmetric. Could we install this unconditionally? - Benjamin Bannier On Feb. 12, 2019, 6:05 a.m., Chun-Hung Hsiao wrote: > > --- > This is an automati

Re: Review Request 69866: Updated SLRP test `ProfileDisappeared` to request operation feedback.

2019-02-12 Thread Benjamin Bannier
/tests/storage_local_resource_provider_tests.cpp Lines 1110-1112 (patched) <https://reviews.apache.org/r/69866/#comment298613> Let's use `create` and `remove` in 1, 2, 3, also to be consistent with 4. - Benjamin Bannier On Feb. 12, 2019, 6:01 a.m., Chun-Hung

Re: Review Request 69858: Persisted intentionally dropped operations in SLRP.

2019-02-12 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69858/#review212734 --- Ship it! Ship It! - Benjamin Bannier On Feb. 6, 2019, 1:04

Re: Review Request 69938: Add resource decorator hook to implicitly allocate mandatory resources.

2019-02-12 Thread Benjamin Bannier
> On Feb. 12, 2019, 12:33 a.m., Mesos Reviewbot Windows wrote: > > FAIL: Some of the unit tests failed. Please check the relevant logs. > > > > Reviews applied: `['69938']` > > > > Failed command: `Start-MesosCITesting` > > > > All the build artifacts available at: > >

Re: Review Request 69890: Added test for per-framework, per-role minimal allocatable resources.

2019-02-11 Thread Benjamin Bannier
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69890/#review212678 --- On Feb. 11, 2019, 4:46 p.m., Benjamin Bannier wrote: > > ---

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

2019-02-11 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69821/#review212679 --- On Feb. 11, 2019, 4:46 p.m., Benjamin Bannier wrote: > > --- &g

Re: Review Request 69818: Added offer filters to static framework configuration.

2019-02-11 Thread Benjamin Bannier
4089cf4dfc65ac4dc5a092c04f4c2022ed8a1587 Diff: https://reviews.apache.org/r/69818/diff/10/ Changes: https://reviews.apache.org/r/69818/diff/9-10/ Testing --- `make check` Thanks, Benjamin Bannier

Re: Review Request 69818: Added offer filters to static framework configuration.

2019-02-11 Thread Benjamin Bannier
uot;shape" that will be > > matched against a potential offer, yes? > > Benjamin Bannier wrote: > Yes. Anything you feel is missing currently? I added an example use. - Benjamin --- This is an automatically gener

Re: Review Request 69889: Stored static framework offer filters in allocator framework class.

2019-02-11 Thread Benjamin Bannier
--- `make check` Thanks, Benjamin Bannier

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

2019-02-11 Thread Benjamin Bannier
-8882-4aff-956b-090dab729358__new_over_old.png Thanks, Benjamin Bannier

Re: Review Request 69890: Added test for per-framework, per-role minimal allocatable resources.

2019-02-11 Thread Benjamin Bannier
://reviews.apache.org/r/69890/diff/3/ Changes: https://reviews.apache.org/r/69890/diff/2-3/ Testing --- `make check` Thanks, Benjamin Bannier

Re: Review Request 69890: Added test for per-framework, per-role minimal allocatable resources.

2019-02-08 Thread Benjamin Bannier
://reviews.apache.org/r/69890/diff/2/ Changes: https://reviews.apache.org/r/69890/diff/1-2/ Testing --- `make check` Thanks, Benjamin Bannier

Re: Review Request 69890: Added test for per-framework, per-role minimal allocatable resources.

2019-02-08 Thread Benjamin Bannier
mes like pointed out by you below. - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69890/#review212563 --- On Feb. 8,

Re: Review Request 69889: Stored static framework offer filters in allocator framework class.

2019-02-08 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69889/#review212564 ------- On Feb. 8, 2019, 12:32 p.m., Benjamin Bannier wrote: > > --

Re: Review Request 69889: Stored static framework offer filters in allocator framework class.

2019-02-08 Thread Benjamin Bannier
/diff/1-2/ Testing --- `make check` Thanks, Benjamin Bannier

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

2019-02-08 Thread Benjamin Bannier
/31/d76189de-8882-4aff-956b-090dab729358__new_over_old.png Thanks, Benjamin Bannier

Re: Review Request 69818: Added offer filters to static framework configuration.

2019-02-08 Thread Benjamin Bannier
visit: https://reviews.apache.org/r/69818/#review212609 ------- On Feb. 4, 2019, 9:37 p.m., Benjamin Bannier wrote: > > --- > This is an automatically generat

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

2019-02-08 Thread Benjamin Bannier
st the comment here about why it's safe to break? It still seems > > relevant > > Benjamin Bannier wrote: > Hmm, not sure what you are after. My patch `continue`s instead of > `break`s. The way the code is structured now we cannot `break` here, but > instead must iter

Re: Review Request 69889: Stored static framework offer filters in allocator framework class.

2019-02-08 Thread Benjamin Bannier
2 ------- On Feb. 8, 2019, 12:32 p.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69889/ >

Re: Review Request 69902: Fixed incorrect skipping in the allocation loops.

2019-02-06 Thread Benjamin Bannier
the original code. Like Meng wrote, some way to test this would be great. - Benjamin Bannier On Feb. 5, 2019, 11:30 p.m., Benjamin Mahler wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 69900: Reduced unnecessary agent lookups in the allocation loops.

2019-02-06 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69900/#review212603 --- Ship it! Ship It! - Benjamin Bannier On Feb. 5, 2019, 11:30

Re: Review Request 69893: Clean up persistent volumes on SLRP disks.

2019-02-05 Thread Benjamin Bannier
emless upgrades? Probably okay, but still something worth documenting in the upgrades guide. - Benjamin Bannier On Feb. 5, 2019, 8:42 a.m., Chun-Hung Hsiao wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Re: Review Request 69892: Made SLRP recover node-published volumes after reboot.

2019-02-05 Thread Benjamin Bannier
s being done here? Here and below. - Benjamin Bannier On Feb. 5, 2019, 8:40 a.m., Chun-Hung Hsiao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 69894: Disallowed `DESTROY_DISK` on persistent volumes.

2019-02-05 Thread Benjamin Bannier
volume first then destroy the disk resource. ``` Also, spaces either at start or end of line, not mixed. At the start seems popular. - Benjamin Bannier On Feb. 5, 2019, 8:43 a.m., Chun-Hung Hsiao

Re: Review Request 69680: Have master acknowledge operation updates of completed frameworks.

2019-02-05 Thread Benjamin Bannier
additional stress Thanks, Benjamin Bannier

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

2019-02-05 Thread Benjamin Bannier
-8882-4aff-956b-090dab729358__new_over_old.png Thanks, Benjamin Bannier

Re: Review Request 69680: Have master acknowledge operation updates of completed frameworks.

2019-02-05 Thread Benjamin Bannier
--- * `make check` * tested on a number of configurations in internal CI * ran added test in repetition, both with and without additional stress Thanks, Benjamin Bannier

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

2019-02-05 Thread Benjamin Bannier
Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69821/#review212523 --- On Feb. 5, 2019, 5:38 p.m., Benjami

Re: Review Request 69858: Persisted intentionally dropped operations in SLRP.

2019-02-05 Thread Benjamin Bannier
It isn't clear from the second sentence whether you document behavior or give a prescription on how to use this function. - Benjamin Bannier On Jan. 30, 2019, 11:35 p.m., Chun-Hung Hsiao wrote: > > --- > This is an automatically

Re: Review Request 69866: Updated SLRP test `ProfileDisappeared` to request operation feedbacks.

2019-02-05 Thread Benjamin Bannier
eculation failures and `DESTROY_DISK` should never be speculated. Don't we see the update due to the profile changes (which triggered a storage pool reconciliation)? - Benjamin Bannier On Feb. 5, 2019, 8:38 a.m., Chu

Re: Review Request 69885: Sped up some resource benchmark test instantiations.

2019-02-05 Thread Benjamin Bannier
± ?): 572.5 ms ± 6.7 ms[User: 343.3 ms, System: 138.4 ms] Range (min … max): 562.2 ms … 588.7 ms10 runs ``` Remaining time is due to the long list of filters `mesos-tests` uses. Thanks, Benjamin Bannier

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

2019-02-04 Thread Benjamin Bannier
matically generated e-mail. To reply, visit: https://reviews.apache.org/r/69821/#review212523 ------- On Feb. 4, 2019, 11:05 p.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:

Review Request 69890: Added test for per-framework, per-role minimal allocatable resources.

2019-02-04 Thread Benjamin Bannier
and the behavior of empty filters or minimal resource quantities set up for a framework. Diffs - src/tests/hierarchical_allocator_tests.cpp cc88afbad1b4e6bf707cb13b50c964aa01f9a3ee Diff: https://reviews.apache.org/r/69890/diff/1/ Testing --- `make check` Thanks, Benjamin Bannier

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

2019-02-04 Thread Benjamin Bannier
new/old timings https://reviews.apache.org/media/uploaded/files/2019/01/31/d76189de-8882-4aff-956b-090dab729358__new_over_old.png Thanks, Benjamin Bannier

Review Request 69889: Stored static framework offer filters in allocator framework class.

2019-02-04 Thread Benjamin Bannier
--- `make check` Thanks, Benjamin Bannier

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

2019-02-04 Thread Benjamin Bannier
Ratio new/old timings https://reviews.apache.org/media/uploaded/files/2019/01/31/d76189de-8882-4aff-956b-090dab729358__new_over_old.png Thanks, Benjamin Bannier

Re: Review Request 69818: Added offer filters to static framework configuration.

2019-02-04 Thread Benjamin Bannier
--- On Feb. 4, 2019, 9:37 p.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69818/ > --

Re: Review Request 69818: Added offer filters to static framework configuration.

2019-02-04 Thread Benjamin Bannier
4089cf4dfc65ac4dc5a092c04f4c2022ed8a1587 Diff: https://reviews.apache.org/r/69818/diff/8/ Changes: https://reviews.apache.org/r/69818/diff/7-8/ Testing --- `make check` Thanks, Benjamin Bannier

Re: Review Request 69885: Sped up some resource benchmark test instantiations.

2019-02-04 Thread Benjamin Bannier
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69885/#review212519 ------- On Feb. 4, 2019, 9:29 p.m., Benjamin Bannier wrote: > > --

Re: Review Request 69885: Sped up some resource benchmark test instantiations.

2019-02-04 Thread Benjamin Bannier
… 815.5 ms10 runs Benchmark #4: After patch, optimized Time (mean ± ?): 572.5 ms ± 6.7 ms[User: 343.3 ms, System: 138.4 ms] Range (min … max): 562.2 ms … 588.7 ms10 runs ``` Remaining time is due to the long list of filters `mesos-tests` uses. Thanks, Benjamin Bannier

Review Request 69885: Sped up some resource benchmark test instantiations.

2019-02-04 Thread Benjamin Bannier
± ?): 572.5 ms ± 6.7 ms[User: 343.3 ms, System: 138.4 ms] Range (min … max): 562.2 ms … 588.7 ms10 runs ``` Remaining time is due to the long list of filters `mesos-tests` uses. Thanks, Benjamin Bannier

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

2019-02-04 Thread Benjamin Bannier
--- `make check` File Attachments Ratio new/old timings https://reviews.apache.org/media/uploaded/files/2019/01/31/d76189de-8882-4aff-956b-090dab729358__new_over_old.png Thanks, Benjamin Bannier

Re: Review Request 69818: Added offer filters to static framework configuration.

2019-02-04 Thread Benjamin Bannier
4089cf4dfc65ac4dc5a092c04f4c2022ed8a1587 Diff: https://reviews.apache.org/r/69818/diff/7/ Changes: https://reviews.apache.org/r/69818/diff/6-7/ Testing --- `make check` Thanks, Benjamin Bannier

Re: Review Request 69818: Added offer filters to static framework configuration.

2019-02-04 Thread Benjamin Bannier
entially empty) map of per-role filters. ``` - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69818/#review212488 --------

Re: Review Request 69818: Added offer filters to static framework configuration.

2019-02-04 Thread Benjamin Bannier
t; > > Also, we're missing a patch for the master to allow changing the value upon > > framework re-registration? > > Benjamin Bannier wrote: > Re:commit message, see my comment here, > https://reviews.apache.org/r/69818/#comment298165. > > Re:changi

Re: Review Request 69818: Added offer filters to static framework configuration.

2019-02-04 Thread Benjamin Bannier
e the existing > > * `DECLINE` filter, which is a time based resource subset > > * filter that only applies to the agent that was declined). > > */ > > ``` > > Benjamin Bannier wrote: > I thought about something like that as well, but the

Re: Review Request 69862: Validated static framework offer filters.

2019-02-04 Thread Benjamin Bannier
/r/69862/diff/2-3/ Testing --- `make check` Thanks, Benjamin Bannier

Re: Review Request 69818: Added offer filters to static framework configuration.

2019-01-31 Thread Benjamin Bannier
lters, updated this patch. - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69818/#review212419 --- On Jan. 31,

Re: Review Request 69818: Added offer filters to static framework configuration.

2019-01-31 Thread Benjamin Bannier
://reviews.apache.org/r/69818/diff/5-6/ Testing --- `make check` Thanks, Benjamin Bannier

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

2019-01-31 Thread Benjamin Bannier
> On Jan. 29, 2019, 9:37 p.m., Benjamin Mahler wrote: > > The commit description makes it sound like the filter is using the > > **union** of the flag and the per-framework/role override: > > > > > This set is populated with any minimal allocatable resources specified in > > > the allocator's

Re: Review Request 69818: Added offer filters to static framework configuration.

2019-01-31 Thread Benjamin Bannier
e the existing > > * `DECLINE` filter, which is a time based resource subset > > * filter that only applies to the agent that was declined). > > */ > > ``` > > Benjamin Bannier wrote: > I thought about something like that as well, but the

Re: Review Request 69862: Validated static framework offer filters.

2019-01-31 Thread Benjamin Bannier
/ Testing --- `make check` Thanks, Benjamin Bannier

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

2019-01-31 Thread Benjamin Bannier
(updated) Ratio new/old timings https://reviews.apache.org/media/uploaded/files/2019/01/31/d76189de-8882-4aff-956b-090dab729358__new_over_old.png Thanks, Benjamin Bannier

Re: Review Request 69818: Added offer filters to static framework configuration.

2019-01-31 Thread Benjamin Bannier
/ Testing --- `make check` Thanks, Benjamin Bannier

Re: Review Request 69819: Added equality operator for `ResourceQuantities`.

2019-01-31 Thread Benjamin Bannier
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69819/#review212390 --- On Jan. 29, 2019, 5:20 p.m., Benjamin Bannier wrote

Re: Review Request 69818: Added offer filters to static framework configuration.

2019-01-30 Thread Benjamin Bannier
ps://reviews.apache.org/r/69818/#review212419 --- On Jan. 30, 2019, 4:04 p.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69818/ > -

Re: Review Request 69863: Removed an unnecessary '.get()' from a master test.

2019-01-30 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69863/#review212463 --- Ship it! Ship It! - Benjamin Bannier On Jan. 30, 2019, 9:32

Re: Review Request 69861: Declared `HierarchicalAllocatorProcess::allocatable` `const`.

2019-01-30 Thread Benjamin Bannier
> On Jan. 30, 2019, 5:09 p.m., Benjamin Mahler wrote: > > Thanks! Probably don't need the duplicate description in the commit message? > > Benjamin Bannier wrote: > The way we have our reviewboard interaction set up, not manually > adjusting a redundant description i

Re: Review Request 69861: Declared `HierarchicalAllocatorProcess::allocatable` `const`.

2019-01-30 Thread Benjamin Bannier
ed e-mail. To reply, visit: https://reviews.apache.org/r/69861/#review212452 --- On Jan. 30, 2019, 4:03 p.m., Benjamin Bannier wrote: > > --- > This is an automatically generate

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

2019-01-30 Thread Benjamin Bannier
/hierarchical_allocator_tests.cpp cc88afbad1b4e6bf707cb13b50c964aa01f9a3ee Diff: https://reviews.apache.org/r/69821/diff/3/ Changes: https://reviews.apache.org/r/69821/diff/2-3/ Testing --- `make check` Thanks, Benjamin Bannier

Review Request 69862: Validated static framework offer filters.

2019-01-30 Thread Benjamin Bannier
/validation.hpp a5bdff6a9301631dac9970568a1346460939c861 src/master/validation.cpp a71edeb7827b534e27ad3e3398abe555bf36e741 Diff: https://reviews.apache.org/r/69862/diff/1/ Testing --- `make check` Thanks, Benjamin Bannier

Re: Review Request 69818: Added offer filters to static framework configuration.

2019-01-30 Thread Benjamin Bannier
src/common/resource_quantities.cpp 320983929cd7d14973c4b98d6ed5338de690ff5f Diff: https://reviews.apache.org/r/69818/diff/4/ Changes: https://reviews.apache.org/r/69818/diff/3-4/ Testing --- `make check` Thanks, Benjamin Bannier

  1   2   3   4   5   6   7   8   9   10   >