Re: Review Request 67955: Added some new generic flag parsers.

2018-07-19 Thread Benjamin Hindman
eviews.apache.org/r/67955/#review206242 --- On July 18, 2018, 1:19 a.m., Benjamin Hindman wrote: > > --- > This is an automatically generated e-mail. To re

Review Request 67959: Added support for instrumenting processes.

2018-07-17 Thread Benjamin Hindman
8baf60d8bbb675e26fea5e76c825ef73fedbc629 Diff: https://reviews.apache.org/r/67959/diff/1/ Testing --- make check Thanks, Benjamin Hindman

Review Request 67958: Added LibprocessTest for easily configuring the library for a test.

2018-07-17 Thread Benjamin Hindman
://reviews.apache.org/r/67958/diff/1/ Testing --- make check Thanks, Benjamin Hindman

Review Request 67960: Added support for instrumenting HTTP endpoints.

2018-07-17 Thread Benjamin Hindman
7c0a0bc0c1e50354b6da219032ac830cbeec0a0d 3rdparty/libprocess/src/tests/http_tests.cpp acbd6973829411652fc5d57ef473c0d8ba9cd5b4 Diff: https://reviews.apache.org/r/67960/diff/1/ Testing --- make check Thanks, Benjamin Hindman

Review Request 67957: Refactored TemporaryDirectoryTest to be a mixin.

2018-07-17 Thread Benjamin Hindman
other test classes. Diffs - 3rdparty/stout/include/stout/tests/utils.hpp eb13cceec29c5db8a75067aac5a00b8f8e9b5046 Diff: https://reviews.apache.org/r/67957/diff/1/ Testing --- make check Thanks, Benjamin Hindman

Review Request 67956: Removed some generic flag parsers that are now in stout.

2018-07-17 Thread Benjamin Hindman
--- Removed some generic flag parsers that are now in stout. Diffs - src/common/parse.hpp 03814e3112a043a1001764b316b9d49501d33665 Diff: https://reviews.apache.org/r/67956/diff/1/ Testing --- make check Thanks, Benjamin Hindman

Review Request 67955: Added some new generic flag parsers.

2018-07-17 Thread Benjamin Hindman
--- Added some new generic flag parsers. Diffs - 3rdparty/stout/include/stout/flags/parse.hpp 4566b798b8b66d47779a28cabdea06f588012686 Diff: https://reviews.apache.org/r/67955/diff/1/ Testing --- make check Thanks, Benjamin Hindman

Re: Review Request 67927: Removed potentially unneeded lambda capture.

2018-07-16 Thread Benjamin Hindman
! - Benjamin Hindman On July 16, 2018, 7:22 p.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Review Request 67921: Bug fix for semaphore decomission "deadlock".

2018-07-15 Thread Benjamin Hindman
a decomission. Diffs - 3rdparty/libprocess/src/semaphore.hpp 50501b9797894ad274eb73f74b3eed00cd719114 Diff: https://reviews.apache.org/r/67921/diff/1/ Testing --- make check Thanks, Benjamin Hindman

Re: Review Request 65151: Added a test for discarding a future from Queue::get.

2018-01-15 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65151/#review195436 --- Ship it! Ship It! - Benjamin Hindman On Jan. 13, 2018, 9:35

Re: Review Request 65150: Added support for discarding a Future from Queue::get.

2018-01-15 Thread Benjamin Hindman
above? 3rdparty/libprocess/include/process/queue.hpp Lines 74 (patched) <https://reviews.apache.org/r/65150/#comment274614> I personally prefer nesting these as it's less prone to copy-pasta mistakes, but up to you. - Benjamin Hindman On Jan. 13, 2018, 9:35 p.m., Benjamin

Review Request 65171: Reduced copying of Response by adding extra override Headers.

2018-01-15 Thread Benjamin Hindman
/ Testing --- make check Thanks, Benjamin Hindman

Review Request 64909: Removed unnecessary `SocketManager::dispose` data structure.

2018-01-02 Thread Benjamin Hindman
/process.cpp 75cf1d3b6d3d257ba9bc81c68017a74a6511cebf 3rdparty/libprocess/src/socket_manager.hpp dd4d111c4ae579420060e547dd12f8f0711c Diff: https://reviews.apache.org/r/64909/diff/1/ Testing --- make check Thanks, Benjamin Hindman

Review Request 64907: Added abandonment and process exit support to `loop()`.

2018-01-02 Thread Benjamin Hindman
a83d0aa44ab0 Diff: https://reviews.apache.org/r/64907/diff/1/ Testing --- make check Thanks, Benjamin Hindman

Review Request 64908: Refactored `HttpProxy` to not rely on `SocketManager`.

2018-01-02 Thread Benjamin Hindman
--- make check Thanks, Benjamin Hindman

Review Request 64906: Exposed `send()` helpers for `Socket`'s.

2018-01-02 Thread Benjamin Hindman
70b5ec479e90c0eb6ac729b465739b581729a956 3rdparty/libprocess/src/http.cpp f51d2aaa639ee36ce960268cb32a3aa88f14aa29 Diff: https://reviews.apache.org/r/64906/diff/1/ Testing --- make check Thanks, Benjamin Hindman

Review Request 64291: Refactored authorization logic.

2017-12-03 Thread Benjamin Hindman
, Benjamin Hindman

Re: Review Request 64081: Fix a code snippet in libprocess documentation.

2017-11-27 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64081/#review191892 --- Ship it! Ship It! - Benjamin Hindman On Nov. 27, 2017, 11

Review Request 64073: Fixed ignored Socket::accept discard when using LibeventSSLSocketImpl.

2017-11-26 Thread Benjamin Hindman
, Benjamin Hindman

Review Request 61158: Introduced http::Server in process.cpp.

2017-11-26 Thread Benjamin Hindman
/libprocess/src/process.cpp 64bcce215d19558dd493e30e96ca16577fe0722a 3rdparty/libprocess/src/socket_manager.hpp dd4d111c4ae579420060e547dd12f8f0711c Diff: https://reviews.apache.org/r/61158/diff/1/ Testing --- make check Thanks, Benjamin Hindman

Review Request 64074: Added ENABLE_HTTP_SERVER option for cmake.

2017-11-26 Thread Benjamin Hindman
: mesos Description --- Added ENABLE_HTTP_SERVER option for cmake. Diffs - cmake/CompilationConfigure.cmake deb574200bceb605a60b536a396c98d9247c6018 Diff: https://reviews.apache.org/r/64074/diff/1/ Testing --- make check Thanks, Benjamin Hindman

Review Request 63942: Added a state machine abstraction.

2017-11-19 Thread Benjamin Hindman
/state_machine_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/63942/diff/1/ Testing --- make check Thanks, Benjamin Hindman

Review Request 63941: Added support for enum's to hashset and hashmap.

2017-11-19 Thread Benjamin Hindman
/ Testing --- make check Thanks, Benjamin Hindman

Re: Review Request 63940: Added a Future constructor for Try<Future>.

2017-11-19 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63940/#review191462 --- Ship it! Ship It! - Benjamin Hindman On Nov. 20, 2017, 12

Re: Review Request 63606: Avoid an extra copy during ProtobufProcess::send.

2017-11-07 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63606/#review190319 --- Ship it! Ship It! - Benjamin Hindman On Nov. 7, 2017, 4:23

Re: Review Request 63605: Support moving in data during ProcessBase::send.

2017-11-07 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63605/#review190318 --- Ship it! Ship It! - Benjamin Hindman On Nov. 7, 2017, 3:40

Re: Review Request 63604: Removed an unnecessary serialization in protobuf process.

2017-11-07 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63604/#review190315 --- Ship it! Ship It! - Benjamin Hindman On Nov. 7, 2017, 3:40

Review Request 63468: Added TERMINATED state to processes.

2017-11-01 Thread Benjamin Hindman
/diff/1/ Testing --- make check Thanks, Benjamin Hindman

Review Request 63292: Added lamdba::zip.

2017-10-25 Thread Benjamin Hindman
check Thanks, Benjamin Hindman

Re: Review Request 63208: Fixed a crash in ProcessManager::resume due to race.

2017-10-22 Thread Benjamin Hindman
/libprocess/src/process.cpp Lines 3291 (patched) <https://reviews.apache.org/r/63208/#comment265878> Any way we could not have to grab this reference each time we loop? This is in the hot path. - Benjamin Hindman On Oct. 22, 2017, 3 a.m., Benjamin Mahler

Re: Review Request 62698: Fixed the clang complation error for the executor tests.

2017-09-29 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62698/#review186749 --- Ship it! Ship It! - Benjamin Hindman On Sept. 29, 2017, 9

Review Request 62609: Protect against Future callbacks deleting instance.

2017-09-26 Thread Benjamin Hindman
, Benjamin Hindman

Re: Review Request 62553: Fixed a flaky test.

2017-09-26 Thread Benjamin Hindman
here is that this test is really dependent on the environment, i.e., what is running on that machine. Is there a better way to do this? Is there something else we can "test" to ensure that CFS has been turned on, rather than trying to actually exercise the CFS algorithm? - Benjami

Review Request 62553: Fixed a flaky test.

2017-09-25 Thread Benjamin Hindman
Description --- Fixed a flaky test. Diffs - src/tests/containerizer/cgroups_isolator_tests.cpp 3fc93417f2d3febf2feca3ec1c8476c9edcfbf4d Diff: https://reviews.apache.org/r/62553/diff/1/ Testing --- make check Thanks, Benjamin Hindman

Re: Review Request 62252: Added `process::Executor::execute()`.

2017-09-25 Thread Benjamin Hindman
We can simplify these next ones: `AWAIT_EXPECT_EQ(f3Result, executor.execute(f3));` 3rdparty/libprocess/src/tests/process_tests.cpp Lines 1286-1288 (patched) <https://reviews.apache.org/r/62252/#comment262604> `AWAIT_EXPECT_EQ(f4Result, executor.execute(std::bind(f4, 42)));` - Benjam

Re: Review Request 62252: Added `process::Executor::execute()`.

2017-09-20 Thread Benjamin Hindman
ocess_tests.cpp Lines 1242 (patched) <https://reviews.apache.org/r/62252/#comment262161> Can we update the code to use `CountDownLatch` so we can use `AWAIT_READY(latch.triggered())` and also pull all the test chunks together "locally" so that it's easier to see what each piece does.

Re: Review Request 62252: Added `process::Executor::execute()`.

2017-09-14 Thread Benjamin Hindman
est for a function/lambda that already returns a `Future`. - Benjamin Hindman On Sept. 13, 2017, 5:34 p.m., Chun-Hung Hsiao wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 62252: Added `process::Executor::execute()`.

2017-09-12 Thread Benjamin Hindman
a separate `Executor::Process` class, and instead can just use `dispatch()` on the existing `process`. You should be able to simplify your SFINAE by leveraging the return type `dispatch()` since it already takes care of the `void` issue for you. - Benjamin Hindman On Sept. 12, 2017, 8:12 p.m

Review Request 62203: Use a `process::Executor` to ensure safety of asynchronous callbacks.

2017-09-08 Thread Benjamin Hindman
--- make check Thanks, Benjamin Hindman

Re: Review Request 62148: Made the `stop()` logic in the scheduler library simpler.

2017-09-07 Thread Benjamin Hindman
tps://reviews.apache.org/r/62148/#comment261015> Have we pulled in libprocess dependencies in public headers in the past? - Benjamin Hindman On Sept. 7, 2017, 5:54 a.m., Anand Mazumdar wrote: > > --- > This is an automatically g

Review Request 62053: Removed garbage collector.

2017-09-02 Thread Benjamin Hindman
afa53537a5c7d4d8b0f4e3b8e04d7d0f2c4c6631 3rdparty/libprocess/src/tests/process_tests.cpp 8d36600701a795a7fa8d73a844657ff98eee6aa7 Diff: https://reviews.apache.org/r/62053/diff/1/ Testing --- make check Thanks, Benjamin Hindman

Re: Review Request 61987: Added an undiscardable() helper that blocks discards from propagating.

2017-08-30 Thread Benjamin Hindman
, Benjamin Hindman

Review Request 61987: Added an undiscardable() helper that blocks discards from propagating.

2017-08-30 Thread Benjamin Hindman
2f5f0a20b5a39b04fd684b1cb44b6a33b647bbef 3rdparty/libprocess/src/tests/future_tests.cpp 0c8725b9a5e64aaac6e3979e450a11e84f9bd45e Diff: https://reviews.apache.org/r/61987/diff/1/ Testing --- make check Thanks, Benjamin Hindman

Review Request 61611: Added hashset::contains for iterable.

2017-08-13 Thread Benjamin Hindman
--- Added hashset::contains for iterable. Diffs - 3rdparty/stout/include/stout/hashset.hpp d2f7d5ddba62cc87e2b61cb06c86b8ef4cd1a212 Diff: https://reviews.apache.org/r/61611/diff/1/ Testing --- make check Thanks, Benjamin Hindman

Review Request 61609: Refactored UPID to be immutable and updated libprocess as necessary.

2017-08-13 Thread Benjamin Hindman
: https://reviews.apache.org/r/61609/diff/1/ Testing --- make check Thanks, Benjamin Hindman

Review Request 61610: Changes in Mesos necessary for UPID immutability.

2017-08-13 Thread Benjamin Hindman
1d9d142ed9e801b79535a2c28f5a94ffbf1bf160 src/tests/uri_fetcher_tests.cpp 8a40f46b215bb1f267a59a9edfca83445f86b430 Diff: https://reviews.apache.org/r/61610/diff/1/ Testing --- make check Thanks, Benjamin Hindman

Re: Review Request 61410: Remove support for omitting 202 responses to old libprocess clients.

2017-08-03 Thread Benjamin Hindman
s only necessary after we started to use `http::Server` since without `keepAlive` the `http::Server` will shutdown the socket right away (and `connection.disconnect()` would fail?). - Benjamin Hindman On Aug. 3, 2017, 6:30 p.m., Benjamin Mahler

Re: Review Request 61058: Added a lock-free event queue.

2017-07-29 Thread Benjamin Hindman
-CREATION 3rdparty/libprocess/src/process.cpp b268cdad776a3ca2a87cbe60eb098bde2a70667c Diff: https://reviews.apache.org/r/61058/diff/3/ Changes: https://reviews.apache.org/r/61058/diff/2-3/ Testing --- make check Thanks, Benjamin Hindman

Re: Review Request 61058: Added a lock-free event queue.

2017-07-29 Thread Benjamin Hindman
ueue.hpp > > Lines 209-211 (patched) > > <https://reviews.apache.org/r/61058/diff/2/?file=1781185#file1781185line209> > > > > Shouldn't an item smaller than the next entry we expect be something we > > CHECK against rather than silently drop?

Review Request 61198: Added explicit EventQueue::Producer/Consumer interfaces.

2017-07-27 Thread Benjamin Hindman
Thanks, Benjamin Hindman

Review Request 61155: Added http::Server.

2017-07-26 Thread Benjamin Hindman
Diff: https://reviews.apache.org/r/61155/diff/1/ Testing --- make check Thanks, Benjamin Hindman

Review Request 61154: Added safe downcasts for Socket.

2017-07-26 Thread Benjamin Hindman
--- Added safe downcasts for Socket. Diffs - 3rdparty/libprocess/include/process/socket.hpp ae6154d5d142f65352e00f37b4e66d0b62fdc3c2 Diff: https://reviews.apache.org/r/61154/diff/1/ Testing --- make check Thanks, Benjamin Hindman

Review Request 61147: Added Future::onAbandoned and Future::isAbandoned.

2017-07-26 Thread Benjamin Hindman
161ca0dc7aea526d450d71a80839d8cc075aaa31 3rdparty/libprocess/src/tests/process_tests.cpp ed11909a2a5e3214fa974bdea098f4057cea9666 3rdparty/libprocess/src/tests/shared_tests.cpp 2a2ffe76b7b7ce016b559de7b5d3a28a06f422ef Diff: https://reviews.apache.org/r/61147/diff/1/ Testing --- make check Thanks, Benjamin

Review Request 61149: Added Future::condition.

2017-07-26 Thread Benjamin Hindman
--- Added Future::condition. Diffs - 3rdparty/libprocess/include/process/future.hpp cce950509f58022e79bb51a6e72ea1a005b9cb50 Diff: https://reviews.apache.org/r/61149/diff/1/ Testing --- make check Thanks, Benjamin Hindman

Review Request 61148: Added Future::recover.

2017-07-26 Thread Benjamin Hindman
--- make check Thanks, Benjamin Hindman

Review Request 61157: Refactored ProcessManager::handle for future use with http::Server.

2017-07-26 Thread Benjamin Hindman
/r/61157/diff/1/ Testing --- make check Thanks, Benjamin Hindman

Review Request 61150: Added Future::onAbandoned semantics to process::collect/await.

2017-07-26 Thread Benjamin Hindman
://reviews.apache.org/r/61150/diff/1/ Testing --- make check Thanks, Benjamin Hindman

Review Request 61152: Added overload of process::await that takes and returns single future.

2017-07-26 Thread Benjamin Hindman
://reviews.apache.org/r/61152/diff/1/ Testing --- make check Thanks, Benjamin Hindman

Review Request 61153: Added discard happens-before relationship in process::await/collect.

2017-07-26 Thread Benjamin Hindman
--- Added discard happens-before relationship in process::await/collect. Diffs - 3rdparty/libprocess/include/process/collect.hpp fccf55a26a2ef61fa3b73d100a0741832e4dfa56 Diff: https://reviews.apache.org/r/61153/diff/1/ Testing --- make check Thanks, Benjamin Hindman

Review Request 61156: Factored out HttpProxy.

2017-07-26 Thread Benjamin Hindman
/http_proxy.cpp PRE-CREATION 3rdparty/libprocess/src/process.cpp b268cdad776a3ca2a87cbe60eb098bde2a70667c 3rdparty/libprocess/src/socket_manager.hpp PRE-CREATION Diff: https://reviews.apache.org/r/61156/diff/1/ Testing --- make check Thanks, Benjamin Hindman

Review Request 61151: Used Future::recover in Mesos.

2017-07-26 Thread Benjamin Hindman
--- Used Future::recover in Mesos. Diffs - src/slave/containerizer/mesos/io/switchboard.cpp 64180944f8680828781168faa67417489abf1bc8 Diff: https://reviews.apache.org/r/61151/diff/1/ Testing --- make check Thanks, Benjamin Hindman

Re: Review Request 61005: Added a test to check for copy assignment of `net::IP::Network`.

2017-07-24 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61005/#review181307 --- Ship it! Ship It! - Benjamin Hindman On July 20, 2017, 6:08

Re: Review Request 61004: Added a copy assignment operator to `net::IP::Network`.

2017-07-24 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61004/#review181306 --- Ship it! Ship It! - Benjamin Hindman On July 20, 2017, 6:06

Review Request 61069: Introduced an optimized fixed size last-in-first-out semaphore.

2017-07-23 Thread Benjamin Hindman
109c300b8292f109b699c096eff0c72d674f4f14 3rdparty/libprocess/src/semaphore.hpp 01438838f67e2b3093d95d49931f72888955f11c Diff: https://reviews.apache.org/r/61069/diff/1/ Testing --- make check Thanks, Benjamin Hindman

Review Request 61068: Added a copy-on-write optimization for UPID 'id' field.

2017-07-23 Thread Benjamin Hindman
634ac44337980fec03ceadaa81a7557d6a714af8 3rdparty/libprocess/src/process.cpp b268cdad776a3ca2a87cbe60eb098bde2a70667c Diff: https://reviews.apache.org/r/61068/diff/1/ Testing --- make check Thanks, Benjamin Hindman

Review Request 61067: More optimizations for creating a MessageEvent.

2017-07-23 Thread Benjamin Hindman
d40179f874754e00b58f271c401650138dc7d01c 3rdparty/libprocess/src/process.cpp b268cdad776a3ca2a87cbe60eb098bde2a70667c Diff: https://reviews.apache.org/r/61067/diff/1/ Testing --- make check Thanks, Benjamin Hindman

Review Request 61066: Added 'process::workers'.

2017-07-23 Thread Benjamin Hindman
: https://reviews.apache.org/r/61066/diff/1/ Testing --- Thanks, Benjamin Hindman

Review Request 61057: Removed ProcessBase::inject to support future event queues.

2017-07-23 Thread Benjamin Hindman
Thanks, Benjamin Hindman

Review Request 61060: Cached a reference to a ProcessBase in every UPID.

2017-07-21 Thread Benjamin Hindman
://reviews.apache.org/r/61060/diff/1/ Testing --- make check Thanks, Benjamin Hindman

Review Request 61058: Added a lock-free event queue.

2017-07-21 Thread Benjamin Hindman
--- Added a lock-free event queue. Diffs - 3rdparty/libprocess/configure.ac cb2cf4f32be5cbdf9df1e32f9aaf2bbba0a5ae03 3rdparty/libprocess/src/event_queue.hpp PRE-CREATION Diff: https://reviews.apache.org/r/61058/diff/1/ Testing --- make check Thanks, Benjamin Hindman

Review Request 61059: Added --enable-lock-free-event-queue configuration in Mesos.

2017-07-21 Thread Benjamin Hindman
Thanks, Benjamin Hindman

Review Request 61056: Removed unused mutex.

2017-07-21 Thread Benjamin Hindman
: https://reviews.apache.org/r/61056/diff/1/ Testing --- make check Thanks, Benjamin Hindman

Review Request 61054: Added a functional "map" abstraction.

2017-07-21 Thread Benjamin Hindman
--- Added a functional "map" abstraction. Diffs - 3rdparty/stout/include/stout/lambda.hpp e67acf5e5eac09ac760da0eb711e982605e389db Diff: https://reviews.apache.org/r/61054/diff/1/ Testing --- make check Thanks, Benjamin Hindman

Review Request 61053: Removed unnecessary states RUNNING and TERMINATED.

2017-07-21 Thread Benjamin Hindman
/ Testing --- make check Thanks, Benjamin Hindman

Review Request 61052: Refactored Gate and updated Gate per Process implementation.

2017-07-21 Thread Benjamin Hindman
3rdparty/libprocess/src/gate.hpp a51610e9b20acfe6cd22ea932efd1e6afad84cf2 3rdparty/libprocess/src/process.cpp b268cdad776a3ca2a87cbe60eb098bde2a70667c Diff: https://reviews.apache.org/r/61052/diff/1/ Testing --- make check Thanks, Benjamin Hindman

Review Request 60983: Added a message passing benchmark.

2017-07-19 Thread Benjamin Hindman
, Benjamin Hindman

Review Request 60979: Added --enable-lock-free-run-queue configuration to Mesos.

2017-07-19 Thread Benjamin Hindman
--- Added --enable-lock-free-run-queue configuration to Mesos. Diffs - configure.ac 5f2ef525e5ee00d204342fa8f374ef9807800f95 Diff: https://reviews.apache.org/r/60979/diff/1/ Testing --- make check Thanks, Benjamin Hindman

Re: Review Request 60831: Removed extra/unnecessary allocations of Message.

2017-07-18 Thread Benjamin Hindman
://reviews.apache.org/r/60831/diff/1-2/ Testing --- make check Thanks, Benjamin Hindman

Re: Review Request 60830: Replaced std::map with hashmap for ProcessBase::handlers.

2017-07-18 Thread Benjamin Hindman
Diff: https://reviews.apache.org/r/60830/diff/2/ Changes: https://reviews.apache.org/r/60830/diff/1-2/ Testing --- make check Thanks, Benjamin Hindman

Re: Review Request 60831: Removed extra/unnecessary allocations of Message.

2017-07-18 Thread Benjamin Hindman
way I updated the code reads the easiest now. - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60831/#review180623 -------

Re: Review Request 60825: Performance optimizations for message passing.

2017-07-18 Thread Benjamin Hindman
25/diff/1/?file=1776833#file1776833line73> > > > > const? Agreed. - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60825/#review180626 ------

Re: Review Request 60825: Performance optimizations for message passing.

2017-07-18 Thread Benjamin Hindman
4d7c4a4679e5c624ee750226d542e0d8c228507a Diff: https://reviews.apache.org/r/60825/diff/2/ Changes: https://reviews.apache.org/r/60825/diff/1-2/ Testing --- make check Thanks, Benjamin Hindman

Review Request 60831: Removed extra/unnecessary allocations of Message.

2017-07-14 Thread Benjamin Hindman
38d787a083a5eb31e922d283f4b4bed2bd62eb0a 3rdparty/libprocess/src/tests/test_linkee.cpp 77df385d3388788658fa40d033816e1fbb8d8f2c Diff: https://reviews.apache.org/r/60831/diff/1/ Testing --- Thanks, Benjamin Hindman

Review Request 60884: Changes for libprocess Message optimization.

2017-07-14 Thread Benjamin Hindman
--- Changes for libprocess Message optimization. Diffs - src/master/master.cpp 287a5b71bc61949648ac0edff7668f217357a054 Diff: https://reviews.apache.org/r/60884/diff/1/ Testing --- Thanks, Benjamin Hindman

Review Request 60829: Replaced std::map with hashmap for ProcessManager::processes.

2017-07-14 Thread Benjamin Hindman
--- Replaced std::map with hashmap for ProcessManager::processes. Diffs - 3rdparty/libprocess/src/process.cpp 7ce6d2b13baa68906e091a95c0dd58ee1ca2bc7d Diff: https://reviews.apache.org/r/60829/diff/1/ Testing --- Thanks, Benjamin Hindman

Review Request 60871: Added double-checked locking for filter.

2017-07-14 Thread Benjamin Hindman
iff: https://reviews.apache.org/r/60871/diff/1/ Testing --- Thanks, Benjamin Hindman

Review Request 60830: Replaced std::map with hashmap for ProcessBase::handlers.

2017-07-14 Thread Benjamin Hindman
/diff/1/ Testing --- Thanks, Benjamin Hindman

Review Request 60832: Added concept of an `epoch` to support proper settling.

2017-07-14 Thread Benjamin Hindman
--- Also refactored increments/decrements of `running` to make it easier to reason about. Diffs - 3rdparty/libprocess/src/process.cpp 7ce6d2b13baa68906e091a95c0dd58ee1ca2bc7d Diff: https://reviews.apache.org/r/60832/diff/1/ Testing --- make check Thanks, Benjamin Hindman

Re: Review Request 60724: Fixed initialization of `LIBPROCESS_IP6` on agent.

2017-07-10 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60724/#review180066 --- Ship it! - Benjamin Hindman On July 9, 2017, 8:23 p.m

Re: Review Request 59127: Added IPv6 flags for Mesos agent.

2017-07-06 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59127/#review179840 --- Ship it! Ship It! - Benjamin Hindman On July 7, 2017, 1:02

Re: Review Request 59131: Added an IPv6 address storage to UPID.

2017-07-06 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59131/#review179835 --- Ship it! Ship It! - Benjamin Hindman On July 6, 2017, 11:31

Re: Review Request 60692: Fixed `net::IPv4` to return `INADDR_ANY` for `ANY()`.

2017-07-06 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60692/#review179833 --- Ship it! Ship It! - Benjamin Hindman On July 6, 2017, 11:46

Re: Review Request 60002: Added ENUM_TEMPLATE_PARAMS preprocessor macro.

2017-07-06 Thread Benjamin Hindman
below. 3rdparty/stout/include/stout/preprocessor.hpp Lines 37 (patched) <https://reviews.apache.org/r/60002/#comment254679> Why make this specific to "templates" and instead just do: ``` #define ENUM BOOST_PP_ENUM ``` - Benjamin Hindman On June 15, 2017, 7

Re: Review Request 60551: Added a test for docker container running on a v4/6 host network.

2017-07-05 Thread Benjamin Hindman
ainerizerIPv6Test::SetUp` and `DockerContainerizerIPv6Test::TearDown` below for now and also add a comment that we eventually want to pull this out into it's own class. - Benjamin Hindman On June 29, 2017, 11:22 p.m., Avinash sridharan wrote: > >

Re: Review Request 59131: Added an IPv6 address storage to UPID.

2017-07-05 Thread Benjamin Hindman
) <https://reviews.apache.org/r/59131/#comment254564> ``` struct { #ifdef __WINDOWS__ Option unix; #endif // __WINDOWS__ Option v4; Option v6; } address; ``` ? - Benjamin Hindman On June 29, 2017, 11:23 p.m., Avinash sridharan

Re: Review Request 59127: Added IPv6 flags for Mesos agent.

2017-07-05 Thread Benjamin Hindman
on the IPv6 network ..." etc. Because the long term intention is that this will also be used for specifying a flag that we'll bind to? - Benjamin Hindman On June 29, 2017, 11:25 p.m., Avinash sridharan wrote: > > --- >

Re: Review Request 59233: Updated v6 address for containers running on host network.

2017-07-05 Thread Benjamin Hindman
) <https://reviews.apache.org/r/59233/#comment254506> s/Setup/Set up/ src/slave/slave.cpp Lines 4545 (patched) <https://reviews.apache.org/r/59233/#comment254507> ... the protocol is set to `IPv4` and therefore we don't explicitly set the protocol here. - Benjamin Hindm

Re: Review Request 59130: Added storage for IPv6 in a `libprocess` process.

2017-07-05 Thread Benjamin Hindman
libprocess/src/process.cpp Lines 1392-1393 (patched) <https://reviews.apache.org/r/59130/#comment254505> Can we move this up to just below where we reset `__address__` please? Thanks! - Benjamin Hindman On June 29, 2017, 11:

Re: Review Request 60149: Added support for `net::IPv4` and `net::IPv6` in `FlagsBase`.

2017-07-05 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60149/#review179688 --- Ship it! Ship It! - Benjamin Hindman On June 29, 2017, 11

Re: Review Request 60148: Mesos updates for new inet4::Address.

2017-07-05 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60148/#review179687 --- Ship it! Ship It! - Benjamin Hindman On June 29, 2017, 11

  1   2   3   4   5   6   7   >