Re: Review Request 48034: Added v1 files to CMakeLists.txt.

2016-05-30 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48034/#review135494 --- Ship it! Ship It! - Bernd Mathiske On May 30, 2016, 3:21

Re: Review Request 47521: Added creator principal to '/create-volumes' tests.

2016-05-27 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47521/#review135217 --- Ship it! Ship It! - Bernd Mathiske On May 27, 2016, 3:55

Re: Review Request 47516: Added creator principal to tests.

2016-05-27 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47516/#review135203 --- Ship it! Ship It! - Bernd Mathiske On May 26, 2016, 11:28

Re: Review Request 47522: Added creator principal to persistent volume tests.

2016-05-27 Thread Bernd Mathiske
ck around "volume" with braces, this one without. - Bernd Mathiske On May 26, 2016, 11:25 p.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Re: Review Request 47521: Added creator principal to '/create-volumes' tests.

2016-05-27 Thread Bernd Mathiske
p (line 1010) <https://reviews.apache.org/r/47521/#comment200233> In the above case, this part is within the scope block, here it is not. Please move the opening curly brace up. - Bernd Mathiske On May 26, 2016, 10:37 p.m

Re: Review Request 47359: Fixed a typo in persistent volume docs.

2016-05-27 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47359/#review135186 --- Ship it! Ship It! - Bernd Mathiske On May 24, 2016, 3:14

Re: Review Request 47360: Updated dynamic reservation and persistent volume docs.

2016-05-26 Thread Bernd Mathiske
reply, visit: > https://reviews.apache.org/r/47360/ > --- > > (Updated May 24, 2016, 3:09 p.m.) > > > Review request for mesos, Bernd Mathiske and Neil Conway. > > > Bugs: MESOS-5215 > https://issues.apache.org

Re: Review Request 47528: Updated validation tests with creator principal.

2016-05-25 Thread Bernd Mathiske
(line 466) <https://reviews.apache.org/r/47528/#comment199673> More Hamming distance than just the "2" would make the difference between the principals even easier to spot. - Bernd Mathiske On May 23, 2016, 9:44 p.m.,

Re: Review Request 47522: Added creator principal to persistent volume tests.

2016-05-23 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47522/#review134351 --- Ship it! Ship It! - Bernd Mathiske On May 18, 2016, 1:06

Re: Review Request 47520: Updated test helpers with creator principal.

2016-05-23 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47520/#review134348 --- Ship it! Ship It! - Bernd Mathiske On May 18, 2016, 1:04

Re: Review Request 47519: Updated an example framework to specify its principal.

2016-05-23 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47519/#review134347 --- Ship it! Ship It! - Bernd Mathiske On May 18, 2016, 1:04

Re: Review Request 47528: Updated validation tests with creator principal.

2016-05-23 Thread Bernd Mathiske
of code any different from the one below? - Bernd Mathiske On May 18, 2016, 1:02 a.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 47515: Enforced a constraint on `DiskInfo.Persistence.principal`.

2016-05-23 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47515/#review134345 --- Ship it! Ship It! - Bernd Mathiske On May 22, 2016, 9:37

Re: Review Request 47515: Enforced a constraint on `DiskInfo.Persistence.principal`.

2016-05-18 Thread Bernd Mathiske
pp (line 823) <https://reviews.apache.org/r/47515/#comment198335> was -> has been same below - Bernd Mathiske On May 18, 2016, 1:01 a.m., Greg Mann wrote: > > --- > This is an automatically generated e-

Re: Review Request 46242: Removed a check in Reserve operation validation.

2016-05-12 Thread Bernd Mathiske
become the same if someone else "creatively" updates DEFAULT_CREDENTIAL.principal later... Maybe add some random letters? On the other hand, I don't think it matters here, so we might as well create conformity to avoid confusion and use DEFAULT_CREDENTIAL.principal() i

Re: Review Request 46813: Update distribute to setuptools.

2016-05-03 Thread Bernd Mathiske
> On April 29, 2016, 9:20 a.m., haosdent huang wrote: > > 3rdparty/versions.am, line 25 > > > > > > I saw the latest version of setuptools is `20.10.1` in > > https://pypi.python.org/pypi/setuptools Do we have any

Re: Review Request 46832: Fixed the CMake build.

2016-04-29 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46832/#review131091 --- Ship it! Ship It! - Bernd Mathiske On April 29, 2016, 6:31

Re: Review Request 46813: Update distribute to setuptools.

2016-04-29 Thread Bernd Mathiske
let's move on and switch to setuptools now. - Bernd Mathiske On April 29, 2016, 2:13 a.m., Zhiwei Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 46717: Added sketch of fetcher cache metrics.

2016-04-27 Thread Bernd Mathiske
tps://reviews.apache.org/r/46717/#comment194627> Note that we don't necessarily use the whole cache dir. The agent flag fetcher_cache_size is free to be set to a different value, a logical usage limit. - Bernd Mathiske On April 26, 2016, 5:30 p.m., Michael Browning

Re: Review Request 45209: Made sure all Python modules are installed.

2016-04-11 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45209/#review128098 --- Ship it! Ship It! - Bernd Mathiske On April 11, 2016, 5:15

Re: Review Request 45039: Updated the comment for launching tasks and accepting offers.

2016-04-05 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45039/#review127092 --- Ship it! Ship It! - Bernd Mathiske On April 5, 2016, 6:27

Re: Review Request 44710: Fixed placement of mock call expectation for fetcher cache tests.

2016-03-11 Thread Bernd Mathiske
be called exactly once before the driver is started. Diffs - src/tests/fetcher_cache_tests.cpp f9c48f5d938c2601cb8f826029d6969d676ab98e Diff: https://reviews.apache.org/r/44710/diff/ Testing --- make check - all fetcher cache tests succeeded. Thanks, Bernd Mathiske

Review Request 44710: Fixed placement of mock call expectation for fetcher cache tests.

2016-03-11 Thread Bernd Mathiske
--- make check - all fetcher cache tests succeeded. Thanks, Bernd Mathiske

Re: Review Request 43629: Especially updated tests to use the updated MesosTest helpers.

2016-03-08 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43629/#review122504 --- Ship it! Ship It! - Bernd Mathiske On March 4, 2016, 3:55

Re: Review Request 43629: Especially updated tests to use the updated MesosTest helpers.

2016-03-08 Thread Bernd Mathiske
> On March 3, 2016, 5:55 a.m., Bernd Mathiske wrote: > > src/tests/slave_recovery_tests.cpp, line 3461 > > <https://reviews.apache.org/r/43629/diff/4/?file=1278087#file1278087line3461> > > > > Why was this moved up here? Couldn't this be in lin

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

2016-03-08 Thread Bernd Mathiske
way to write this stretch of code. Please pick one. This one is probably the least controversial. :-) - Bernd Mathiske On March 4, 2016, 4:14 p.m., Joseph Wu wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

2016-03-08 Thread Bernd Mathiske
> On March 4, 2016, 6:45 a.m., Bernd Mathiske wrote: > > > > Joseph Wu wrote: > I also noticed a couple of these: > ``` > MesosSchedulerDriver driver( > , DEFAULT_FRAMEWORK_INFO, master.get()->pid, > DEFAULT_CREDENTIAL); > ``` &g

Re: Review Request 44448: Replaced EXIT(1) with EXIT(EXIT_FAILURE).

2016-03-07 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8/#review122299 --- Ship it! Ship It! - Bernd Mathiske On March 7, 2016, 5:09

Re: Review Request 44447: Replaced EXIT(1) with EXIT(EXIT_FAILURE) in libprocess.

2016-03-07 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7/#review122295 --- Ship it! Ship It! - Bernd Mathiske On March 7, 2016, 5:09

Re: Review Request 44446: Replaced EXIT(1) with EXIT(EXIT_FAILURE) in stout.

2016-03-07 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6/#review122294 --- Ship it! Ship It! - Bernd Mathiske On March 7, 2016, 5:08

Re: Review Request 43629: Especially updated tests to use the updated MesosTest helpers.

2016-03-04 Thread Bernd Mathiske
> On March 3, 2016, 5:55 a.m., Bernd Mathiske wrote: > > src/tests/slave_recovery_tests.cpp, line 3461 > > <https://reviews.apache.org/r/43629/diff/4/?file=1278087#file1278087line3461> > > > > Why was this moved up here? Couldn't this be in lin

Re: Review Request 43630: Especially updated scheduler tests to use the updated MesosTest helpers.

2016-03-04 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43630/#review122079 --- Ship it! - Bernd Mathiske On March 2, 2016, 1:45 p.m

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

2016-03-04 Thread Bernd Mathiske
be missing part of what we want to test here. src/tests/master_tests.cpp (line 2046) <https://reviews.apache.org/r/43615/#comment183954> Same as above. Aren't we stopping the master too late for our purposes? src/tests/master_tests.cpp (line 3648) <https://reviews.apache.org/r/4

Re: Review Request 43614: Refactor MesosTest and remove cleanup logic.

2016-03-04 Thread Bernd Mathiske
tps://reviews.apache.org/r/43614/#comment183936> If we were pedantic, we could make the order of the params the same in the comment and the signature. src/tests/mesos.hpp (line 204) <https://reviews.apache.org/r/43614/#comment183937> Param order in comments vs. signature. - Be

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

2016-03-04 Thread Bernd Mathiske
be improved (as could the original), but if you focus just on the refactoring, without making additional improvements which could be addressed in extra patches, I think we are done here. - Bernd Mathiske On March 2, 2016, 1:45 p.m., Joseph Wu wrote

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

2016-03-04 Thread Bernd Mathiske
> On March 3, 2016, 5:22 a.m., Bernd Mathiske wrote: > > src/tests/cluster.hpp, line 213 > > <https://reviews.apache.org/r/43613/diff/8/?file=1278081#file1278081line213> > > > > I don't think we need this constructor. We are using an instance of > >

Re: Review Request 44336: Removed numeric suffixes where appropriate in allocator tests.

2016-03-04 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44336/#review122063 --- Ship it! Ship It! - Bernd Mathiske On March 3, 2016, 5:01

Re: Review Request 44335: Moved variable declarations closer to where they are used.

2016-03-04 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44335/#review122061 --- Ship it! Ship It! - Bernd Mathiske On March 3, 2016, 5:01

Re: Review Request 44334: Cleaned up empty hashmaps from allocator tests.

2016-03-04 Thread Bernd Mathiske
S"? Could the parameter of the methods in question be supplied with a default value? Then no corresponding argument at all would appear in these tests. - Bernd Mathiske On March 3, 2016, 5 a.m., Alexander Rukletsov wrote: > > --

Re: Review Request 43629: Especially updated tests to use the updated MesosTest helpers.

2016-03-03 Thread Bernd Mathiske
tps://reviews.apache.org/r/43629/#comment183697> Why was this moved up here? Couldn't this be in line 3389/3402? LGTM - Bernd Mathiske On March 2, 2016, 1:45 p.m., Joseph Wu wrote: > > --- > This is an automatically generated e

Re: Review Request 43614: Refactor MesosTest and remove cleanup logic.

2016-03-03 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43614/#review121855 --- LGTM, pending dependencies. - Bernd Mathiske On March 2, 2016

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

2016-03-03 Thread Bernd Mathiske
sts/cluster.cpp (line 404) <https://reviews.apache.org/r/43613/#comment183677> This could move inside the constructor, so the pid can be a constant. But that's probably an uncommon pattern in Mesos. So OK to leave as is. - Bernd Mathiske On Ma

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

2016-03-02 Thread Bernd Mathiske
suggested in the reviews this one depends on. - Bernd Mathiske On Feb. 29, 2016, 1:55 p.m., Joseph Wu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 43614: Refactor MesosTest and remove cleanup logic.

2016-03-02 Thread Bernd Mathiske
hen we would only need one kind for all cases and a lot of code would look substantially simpler. The only Owned ones would be those that are always Owned. - Bernd Mathiske On Feb. 16, 2016, 2:15 p.m., Joseph Wu

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

2016-03-02 Thread Bernd Mathiske
pache.org/r/43613/#comment183389> Note that an ASSERT is only the correct measure to use here if we return an Error then and guard the factory function with an ASSERT in every test's top scope. Otherwise, CHECK was correct, preventing potential access to a NULL pointer. - Bernd Mathi

Re: Review Request 44179: Reintroduce deleted anchor in configuration.md.

2016-03-02 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44179/#review121622 --- Ship it! Ship It! - Bernd Mathiske On Feb. 29, 2016, 4:36

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

2016-03-01 Thread Bernd Mathiske
e use a Try return type as discussed above, the ASSERT_SOME in the top level test code makes things right again. Still, strictly speaking, it "look more "correct" if writing this here, assuming the Try: LOG(FATAL) << "Failed to wait for _recover"

Re: Review Request 44029: Fetcher::basename should ignore query strings and fragments.

2016-03-01 Thread Bernd Mathiske
> On Feb. 26, 2016, 5:40 a.m., Bernd Mathiske wrote: > > There is a more elaborate solution to this problem > > (https://reviews.apache.org/r/40054), but it requires a lot of code to > > implement URL parsing. Until we finalize that, I think the patch at hand > > ge

Re: Review Request 44029: Fetcher::basename should ignore query strings and fragments.

2016-02-26 Thread Bernd Mathiske
(https://reviews.apache.org/r/40054), but it requires a lot of code to implement URL parsing. Until we finalize that, I think the patch at hand gets the most urgent job done. - Bernd Mathiske On Feb. 25, 2016, 10:32 a.m., James Peach wrote

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

2016-02-26 Thread Bernd Mathiske
399. But then I still do not get to observe a consistent use pattern of terminate(). See my comment above. - Bernd Mathiske On Feb. 24, 2016, 12:06 p.m., Joseph Wu wrote: > > --- > This is an automatically generate

Re: Review Request 43963: Fixed flakiness in DockerContainerizerTest.ROOT_DOCKER_Logs.

2016-02-25 Thread Bernd Mathiske
1855) <https://reviews.apache.org/r/43963/#comment182145> Why the extra image? This test seems to run just fine with the other changes and simply "alpine". What is the significance of "Expect" here? - Bernd Mathiske On Feb. 24, 2016,

Re: Review Request 43961: Added some additional synchronization in ROOT_CGROUPS_Pids_and_Tids.

2016-02-25 Thread Bernd Mathiske
me clear to me. Suggestion: // This observation ensures that the "cat" process // has completed its part of the exec() procedure // and is now executing normally." - Bernd Mathiske On

Re: Review Request 43850: Added waits at different points in the test to ensure milestones.

2016-02-24 Thread Bernd Mathiske
(line 242) <https://reviews.apache.org/r/43850/#comment181935> Nice pattern. We try not to capture by reference, but here this is put to use to great effect. - Bernd Mathiske On Feb. 24, 2016, 1:10 a.m., Alexander Rojas

Re: Review Request 43849: Fixed typos in subprocess.cpp comments.

2016-02-23 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43849/#review120345 --- Ship it! Ship It! - Bernd Mathiske On Feb. 23, 2016, 9:49

Re: Review Request 41950: Cleaned up hierarchical allocator tests.

2016-02-23 Thread Bernd Mathiske
-- > > (Updated Jan. 28, 2016, 5:12 a.m.) > > > Review request for mesos, Bernd Mathiske, Ben Mahler, Joerg Schad, and Joris > Van Remoortere. > > > Repository: mesos > > > Description > --- > > Changes made: > - empty resource map pro

Re: Review Request 43799: Removed race condition from libevent based poll implementation.

2016-02-23 Thread Bernd Mathiske
should work as is, it is more straight forward and the common (generally safer) pattern to access the shared pointer here, not the weak one. _ev.get() (respectively ev_.get(), see above) - Bernd Mathiske On Feb. 19, 2016, 5:09 p.m., Alexander

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

2016-02-22 Thread Bernd Mathiske
omatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43367/#review119838 --- On Feb. 18, 2016, 6:54 a.m., haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > ht

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

2016-02-19 Thread Bernd Mathiske
o need to be dramatic about this little tidbit :-) s/lambda/extra/ src/tests/cluster.cpp (line 136) <https://reviews.apache.org/r/43613/#comment181258> I think you can keep the first clause on the same line, then align underneath. - Bernd Math

Re: Review Request 43271: Modify subprocess to deal with LIBPROCESS_PORT specially.

2016-02-19 Thread Bernd Mathiske
; You can use 'subprocess_environment(environment)' here without the temp var, avoiding the ugly underscore naming. If you ewant to keep it, though, the underscore goes to the end: "environment_". And then you should use const ref. - Bernd Mathiske On Fe

Re: Review Request 43737: Fixed typo in fetcher docs.

2016-02-19 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43737/#review119846 --- Ship it! Thanks! - Bernd Mathiske On Feb. 18, 2016, 1:17

Re: Review Request 43271: Modify subprocess to deal with LIBPROCESS_PORT specially.

2016-02-18 Thread Bernd Mathiske
_environment but not the code below as a subroutine looks unbalanced. Why not factor the whole affair into a common subroutine together? This routine may look like a filter function: env -> env. - Bernd Mathiske On Feb. 5, 2016, 3:25 p.m.,

Re: Review Request 36071: Add flow diagram for docker containerizer.

2016-02-18 Thread Bernd Mathiske
> On July 7, 2015, 4:51 a.m., Bernd Mathiske wrote: > > 1. Inconsistent capitalization in box labels. > > 2. You explain different paths to obtain an "executor pid" and then you > > checkpoint a "container pid". You lost me there. > >

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

2016-02-18 Thread Bernd Mathiske
190) <https://reviews.apache.org/r/43367/#comment180968> s/taks works, settling/tasks works and settling/ - Bernd Mathiske On Feb. 17, 2016, 8:55 a.m., haosdent huang wrote: > > --- > This is an automatically g

Re: Review Request 41865: Use full width for mesos div.container

2016-02-18 Thread Bernd Mathiske
closed given your patch? - Bernd Mathiske On Jan. 3, 2016, 7:08 a.m., haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 43608: Speed up FetcherCache test cases by disable framework checkpoint.

2016-02-17 Thread Bernd Mathiske
> On Feb. 17, 2016, 7:21 a.m., Bernd Mathiske wrote: > > Are a couple of seconds wirth the extra code complexity? Opinions, please! > > haosdent huang wrote: > Yes, @bernd, as you see here, this patch don't bring too much effects. > How about let's discard it an

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

2016-02-17 Thread Bernd Mathiske
der and you don't have to pass all these parameters, you can capture them. AFAIK we are merely solving a syntactical problem here: macro ASSERT_* contains "return ..." with a return type that does not match start(). Right? - Bernd Mathiske On Feb. 16,

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

2016-02-17 Thread Bernd Mathiske
> On Feb. 17, 2016, 2:09 a.m., Bernd Mathiske wrote: > > src/tests/fetcher_cache_tests.cpp, line 197 > > <https://reviews.apache.org/r/43367/diff/9/?file=1252393#file1252393line197> > > > > Having run multiple test suite runs, I am not convinced this has much

Re: Review Request 43608: Speed up FetcherCache test cases by disable framework checkpoint.

2016-02-17 Thread Bernd Mathiske
, please! - Bernd Mathiske On Feb. 16, 2016, 6:10 p.m., haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 42842: Fixed flakiness in ContainerLoggerTest.DefaultToSandbox.

2016-02-17 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42842/#review119461 --- Ship it! Ship It! - Bernd Mathiske On Feb. 10, 2016, 9:49

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

2016-02-17 Thread Bernd Mathiske
s less than the variance. - Bernd Mathiske On Feb. 17, 2016, 1:54 a.m., haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test by reduce loop.

2016-02-17 Thread Bernd Mathiske
into a separate review, let's ship it! - Bernd Mathiske On Feb. 16, 2016, 6:10 p.m., haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

2016-02-16 Thread Bernd Mathiske
> On Feb. 16, 2016, 3:02 a.m., Bernd Mathiske wrote: > > src/tests/fetcher_cache_tests.cpp, line 422 > > <https://reviews.apache.org/r/43367/diff/4/?file=1239305#file1239305line422> > > > > In some fetcher cache tests, we specifically want to find

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

2016-02-16 Thread Bernd Mathiske
m., haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42696/ > --- > > (Updated Feb. 9, 2016, 4:48 p.m.) > > > Review request

Re: Review Request 43367: Speed up FetcherCache test cases by advance allocation_interval.

2016-02-16 Thread Bernd Mathiske
terval and not playing with the clock? - Bernd Mathiske On Feb. 9, 2016, 8:17 p.m., haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

2016-02-16 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42696/#review119290 --- Ship it! Ship It! - Bernd Mathiske On Feb. 9, 2016, 4:48

Re: Review Request 43491: Added note about implicit default filter to javadoc.

2016-02-15 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43491/#review119214 --- Ship it! Ship It! - Bernd Mathiske On Feb. 13, 2016, 6:38

Re: Review Request 43525: Fixed an unsigned<->signed comparison.

2016-02-12 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43525/#review119027 --- Ship it! Ship It! - Bernd Mathiske On Feb. 12, 2016, 3:47

Review Request 43359: Fixed the build with gcc 5.2.

2016-02-09 Thread Bernd Mathiske
--- (An unsigned<->signed comparison was failing.) Diffs - src/tests/containerizer/isolator_tests.cpp c20f33ebd6b0b1703c513c0d4bfe4f7d3a9201c8 Diff: https://reviews.apache.org/r/43359/diff/ Testing --- Thanks, Bernd Mathiske

Re: Review Request 43359: Fixed the build with gcc 5.2.

2016-02-09 Thread Bernd Mathiske
esting (updated) --- Checked that the build completes "make check" with gcc 5.2.1. Thanks, Bernd Mathiske

Re: Review Request 43316: Decrease countCacheEntries in FetcherCacheTest.SimpleEviction .

2016-02-08 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43316/#review118227 --- Ship it! Ship It! - Bernd Mathiske On Feb. 7, 2016, 10:38

Re: Review Request 40731: Added a test case for floating point precision of resource allocation.

2016-02-03 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40731/#review117593 --- Ship it! Ship It! - Bernd Mathiske On Jan. 28, 2016, 4:45

Re: Review Request 43072: Use full screen width for Mesos UI using Bootstraps (v3.3.6) container-fluid

2016-02-02 Thread Bernd Mathiske
> --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43072/ > --- > > (Updated Feb. 1, 2016, 3:36 p.m.) > > > Review

Re: Review Request 43072: Use full screen width for Mesos UI using Bootstraps (v3.3.6) container-fluid

2016-02-02 Thread Bernd Mathiske
apply-reviews.py", line 199, in patch_data > > return reviewboard_data() > > File "support/apply-reviews.py", line 252, in reviewboard_data > > email=user.get('email')) > > UnicodeEncodeError: 'ascii' codec can't encode character u'\xf8' in > > position 11: ordin

Review Request 42914: Listed supported file extensions in fetcher documentation.

2016-01-28 Thread Bernd Mathiske
/diff/ Testing --- Opened file with MD renderer. Thanks, Bernd Mathiske

Re: Review Request 42914: Listed supported file extensions in fetcher documentation.

2016-01-28 Thread Bernd Mathiske
> On Jan. 28, 2016, 11:40 p.m., Timothy Chen wrote: > > docs/fetcher.md, line 119 > > <https://reviews.apache.org/r/42914/diff/2/?file=1225096#file1225096line119> > > > > then files with a recognized extension > > Bernd Mathiske wrote: >

Re: Review Request 42914: Listed supported file extensions in fetcher documentation.

2016-01-28 Thread Bernd Mathiske
derstand what you mean. - Bernd --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42914/#review116929 --- On Jan. 28, 2016,

Re: Review Request 42914: Listed supported file extensions in fetcher documentation.

2016-01-28 Thread Bernd Mathiske
(updated) - docs/fetcher.md cb4f3c33fb67f7ac65dbe7ebe1347d2599c43f37 Diff: https://reviews.apache.org/r/42914/diff/ Testing --- Opened file with MD renderer. Thanks, Bernd Mathiske

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

2016-01-26 Thread Bernd Mathiske
713) <https://reviews.apache.org/r/42696/#comment177376> const - Bernd Mathiske On Jan. 24, 2016, 7:01 a.m., haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 42477: Corrected example in quota user doc.

2016-01-26 Thread Bernd Mathiske
> On Jan. 22, 2016, 8:34 a.m., Bernd Mathiske wrote: > > docs/quota.md, line 166 > > <https://reviews.apache.org/r/42477/diff/2/?file=1205605#file1205605line166> > > > > Please explain what this seemingly redundant field is doing. > > Guangya L

Re: Review Request 42674: Replaced busybox with alpine in docker tests.

2016-01-25 Thread Bernd Mathiske
tps://reviews.apache.org/r/42674/#comment177079> Instead of naked strings we should reuse a constant that we can change in one place. - Bernd Mathiske On Jan. 22, 2016, 5:26 p.m., Timothy Chen wrote: > > --- > This is an automatica

Re: Review Request 42674: Replaced busybox with alpine in docker tests.

2016-01-25 Thread Bernd Mathiske
ally generated e-mail. To reply, visit: > https://reviews.apache.org/r/42674/ > --- > > (Updated Jan. 22, 2016, 5:26 p.m.) > > > Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Jie Yu. > > > Repository: mesos > > > Description &g

Re: Review Request 42353: Correctted typo in fetcher.md.

2016-01-24 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42353/#review116032 --- Ship it! Ship It! - Bernd Mathiske On Jan. 22, 2016, 4:54

Re: Review Request 42353: Correctted typo in fetcher.md.

2016-01-22 Thread Bernd Mathiske
353/#comment176903> Suggestions: s/the names/these variable names s/all in/entirely in - Bernd Mathiske On Jan. 22, 2016, 5:18 a.m., Guangya Liu wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 42374: Logger Module: Add test filter for tests requiring `logrotate`.

2016-01-22 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42374/#review115840 --- Ship it! Ship It! - Bernd Mathiske On Jan. 19, 2016, 7:41 p.m

Re: Review Request 42476: Introduced protobuf for set quota requests.

2016-01-21 Thread Bernd Mathiske
it! - Bernd Mathiske On Jan. 20, 2016, 4:12 a.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 41648: Used initializer list c-tor for brevity.

2016-01-20 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41648/#review115383 --- Ship it! Ship It! - Bernd Mathiske On Jan. 12, 2016, 1:33 p.m

Re: Review Request 41950: Cleaned up hierarchical allocator tests.

2016-01-20 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41950/#review115382 --- Ship it! Ship It! - Bernd Mathiske On Jan. 12, 2016, 1:34 p.m

Re: Review Request 42535: Made allocator's pause/resume idempotent.

2016-01-20 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42535/#review115395 --- Ship it! Ship It! - Bernd Mathiske On Jan. 19, 2016, 6:09 p.m

Re: Review Request 42476: Introduced protobuf for set quota requests.

2016-01-20 Thread Bernd Mathiske
lt;https://reviews.apache.org/r/42476/#comment176383> Why not use protoRequest here? - Bernd Mathiske On Jan. 20, 2016, 1 a.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-mail. To r

Re: Review Request 42476: Introduced protobuf for set quota requests.

2016-01-20 Thread Bernd Mathiske
> On Jan. 20, 2016, 1:14 a.m., Bernd Mathiske wrote: > > docs/quota.md, line 94 > > <https://reviews.apache.org/r/42476/diff/3/?file=1201682#file1201682line94> > > > > plural > > Alexander Rukletsov wrote: > I think we use single

  1   2   3   4   >