Re: Review Request 67602: Improve the debug logging in mesos container
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67602/#review206493 --- Ship it! Ship It! - CHEN RUNCONG On 六月 19, 2018, 10:59 p.m., CHEN RUNCONG wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67602/ > --- > > (Updated 六月 19, 2018, 10:59 p.m.) > > > Review request for mesos and Gilbert Song. > > > Bugs: MESOS-8423 > https://issues.apache.org/jira/browse/MESOS-8423 > > > Repository: mesos > > > Description > --- > > Improve the debug logging in mesos container > > > Diffs > - > > src/slave/containerizer/mesos/containerizer.cpp > 7b3b0d34a26a695e36a2f89e24b80b02ecc9b7c7 > > > Diff: https://reviews.apache.org/r/67602/diff/1/ > > > Testing > --- > > > Thanks, > > CHEN RUNCONG > >
Re: Review Request 67585: Fixed the issue:if the container is destroyed in the mean time, then we will potentially segfault here.
> On 六月 14, 2018, 11:18 p.m., Gilbert Song wrote: > > src/slave/containerizer/docker.cpp > > Lines 1386 (patched) > > <https://reviews.apache.org/r/67585/diff/2/?file=2040459#file2040459line1386> > > > > one newline below fixed it - CHEN --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67585/#review204804 --- On 六月 15, 2018, 5:21 p.m., CHEN RUNCONG wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67585/ > --- > > (Updated 六月 15, 2018, 5:21 p.m.) > > > Review request for mesos and Gilbert Song. > > > Bugs: MESOS-6092 > https://issues.apache.org/jira/browse/MESOS-6092 > > > Repository: mesos > > > Description > --- > > Fixed the issue:if the container is destroyed in the mean time, then we will > potentially segfault here. > > > Diffs > - > > src/slave/containerizer/docker.cpp 391700f9698d0658b9273d79857bfa30bf3549be > > > Diff: https://reviews.apache.org/r/67585/diff/3/ > > > Testing > --- > > > Thanks, > > CHEN RUNCONG > >
Re: Review Request 67585: Fixed the issue:if the container is destroyed in the mean time, then we will potentially segfault here.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67585/ --- (Updated 六月 15, 2018, 5:21 p.m.) Review request for mesos and Gilbert Song. Bugs: MESOS-6092 https://issues.apache.org/jira/browse/MESOS-6092 Repository: mesos Description --- Fixed the issue:if the container is destroyed in the mean time, then we will potentially segfault here. Diffs (updated) - src/slave/containerizer/docker.cpp 391700f9698d0658b9273d79857bfa30bf3549be Diff: https://reviews.apache.org/r/67585/diff/3/ Changes: https://reviews.apache.org/r/67585/diff/2-3/ Testing --- Thanks, CHEN RUNCONG
Re: Review Request 67585: Fixed the issue:if the container is destroyed in the mean time, then we will potentially segfault here.
> On 六月 14, 2018, 11:18 p.m., Gilbert Song wrote:
> > src/slave/containerizer/docker.cpp
> > Lines 1383-1385 (patched)
> > <https://reviews.apache.org/r/67585/diff/2/?file=2040459#file2040459line1383>
> >
> > Please follow this format:
> >
> > ```
> > if (containers_[containerId]->state == Container::DESTROYING) {
> > return Failure(
> > "Container is being destroyed during launching excutor
> > container");
> > }
> > ```
ok
- CHEN
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67585/#review204804
---
On 六月 15, 2018, 5:21 p.m., CHEN RUNCONG wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67585/
> ---
>
> (Updated 六月 15, 2018, 5:21 p.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Bugs: MESOS-6092
> https://issues.apache.org/jira/browse/MESOS-6092
>
>
> Repository: mesos
>
>
> Description
> ---
>
> Fixed the issue:if the container is destroyed in the mean time, then we will
> potentially segfault here.
>
>
> Diffs
> -
>
> src/slave/containerizer/docker.cpp 391700f9698d0658b9273d79857bfa30bf3549be
>
>
> Diff: https://reviews.apache.org/r/67585/diff/3/
>
>
> Testing
> ---
>
>
> Thanks,
>
> CHEN RUNCONG
>
>
Re: Review Request 67594: Improve the debug logging in mesos container
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67594/ --- (Updated 六月 14, 2018, 11:28 p.m.) Review request for mesos. Bugs: MESOS-8423 https://issues.apache.org/jira/browse/MESOS-8423 Repository: mesos Description --- Improve the debug logging in mesos container Diffs - src/slave/containerizer/mesos/containerizer.cpp 17a1a3762b2012ff875e4da9c9d4622514e48051 Diff: https://reviews.apache.org/r/67594/diff/1/ Testing --- Thanks, CHEN RUNCONG
Re: Review Request 67579: Added chenrc to the contributors list.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67579/ --- (Updated June 14, 2018, 3:37 p.m.) Review request for mesos and Gilbert Song. Summary (updated) - Added chenrc to the contributors list. Repository: mesos Description --- Added chenrc to the contributors list Diffs - docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958 Diff: https://reviews.apache.org/r/67579/diff/1/ Testing --- Thanks, CHEN RUNCONG
Re: Review Request 67602: Improve the debug logging in mesos container
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67602/ --- (Updated 六月 14, 2018, 7:45 p.m.) Review request for mesos and Gilbert Song. Bugs: MESOS-8423 https://issues.apache.org/jira/browse/MESOS-8423 Repository: mesos Description --- Improve the debug logging in mesos container Diffs - src/slave/containerizer/mesos/containerizer.cpp 7b3b0d34a26a695e36a2f89e24b80b02ecc9b7c7 Diff: https://reviews.apache.org/r/67602/diff/1/ Testing --- Thanks, CHEN RUNCONG
Review Request 67602: Improve the debug logging in mesos container
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67602/ --- Review request for mesos and Gilbert Song. Repository: mesos Description --- Improve the debug logging in mesos container Diffs - src/slave/containerizer/mesos/containerizer.cpp 7b3b0d34a26a695e36a2f89e24b80b02ecc9b7c7 Diff: https://reviews.apache.org/r/67602/diff/1/ Testing --- Thanks, CHEN RUNCONG
Review Request 67594: Improve the debug logging in mesos container
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67594/ --- Review request for mesos and Gilbert Song. Bugs: MESOS-8423 https://issues.apache.org/jira/browse/MESOS-8423 Repository: mesos Description --- Improve the debug logging in mesos container Diffs - src/slave/containerizer/mesos/containerizer.cpp 17a1a3762b2012ff875e4da9c9d4622514e48051 Diff: https://reviews.apache.org/r/67594/diff/1/ Testing --- Thanks, CHEN RUNCONG
Re: Review Request 67585: Fixed the issue:if the container is destroyed in the mean time, then we will potentially segfault here.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67585/ --- (Updated 六月 14, 2018, 12:34 a.m.) Review request for mesos and Gilbert Song. Bugs: MESOS-6092 https://issues.apache.org/jira/browse/MESOS-6092 Repository: mesos Description --- Fixed the issue:if the container is destroyed in the mean time, then we will potentially segfault here. Diffs (updated) - src/slave/containerizer/docker.cpp 391700f9698d0658b9273d79857bfa30bf3549be Diff: https://reviews.apache.org/r/67585/diff/2/ Changes: https://reviews.apache.org/r/67585/diff/1-2/ Testing --- Thanks, CHEN RUNCONG
Review Request 67585: Fixed the issue:if the container is destroyed in the mean time, then we will potentially segfault here.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67585/ --- Review request for mesos and Gilbert Song. Bugs: MESOS-6092 https://issues.apache.org/jira/browse/MESOS-6092 Repository: mesos Description --- Fixed the issue:if the container is destroyed in the mean time, then we will potentially segfault here. Diffs - src/slave/containerizer/docker.cpp 391700f9698d0658b9273d79857bfa30bf3549be Diff: https://reviews.apache.org/r/67585/diff/1/ Testing --- Thanks, CHEN RUNCONG
Review Request 67581: Fixed the issue:if the container is destroyed in the mean time, then we will potentially segfault here.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67581/ --- Review request for mesos and Gilbert Song. Bugs: MESOS-6092 https://issues.apache.org/jira/browse/MESOS-6092 Repository: mesos Description --- Fixed the issue:if the container is destroyed in the mean time, then we will potentially segfault here. Diffs - src/slave/containerizer/docker.cpp 391700f9698d0658b9273d79857bfa30bf3549be Diff: https://reviews.apache.org/r/67581/diff/1/ Testing --- Thanks, CHEN RUNCONG
Review Request 67579: Added chenrc to the contributors list
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67579/ --- Review request for mesos and Gilbert Song. Repository: mesos Description --- Added chenrc to the contributors list Diffs - docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958 Diff: https://reviews.apache.org/r/67579/diff/1/ Testing --- Thanks, CHEN RUNCONG
Review Request 67578: add user information
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67578/ --- Review request for mesos and Gilbert Song. Repository: mesos Description --- add user information Diffs - docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958 Diff: https://reviews.apache.org/r/67578/diff/1/ Testing --- Thanks, CHEN RUNCONG
Re: Review Request 67562: The container should not be access when the container is destroyed in the mean time.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67562/ --- (Updated June 13, 2018, 9:54 a.m.) Review request for mesos, Gilbert Song and Greg Mann. Bugs: MESOS-6092 https://issues.apache.org/jira/browse/MESOS-6092 Repository: mesos Description --- The container should not be access when the container is destroyed in the mean time. Diffs - src/slave/containerizer/docker.cpp 391700f9698d0658b9273d79857bfa30bf3549be Diff: https://reviews.apache.org/r/67562/diff/1/ Testing --- Thanks, CHEN RUNCONG
Re: Review Request 67542: submmit my user information
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67542/ --- (Updated 六月 12, 2018, 10:49 p.m.) Review request for mesos and Gilbert Song. Repository: mesos Description --- submmit my user information Diffs (updated) - docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958 Diff: https://reviews.apache.org/r/67542/diff/3/ Changes: https://reviews.apache.org/r/67542/diff/2-3/ Testing --- Thanks, CHEN RUNCONG
Re: Review Request 67549: modify my user information
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67549/ --- (Updated 六月 12, 2018, 10:48 p.m.) Review request for mesos and Gilbert Song. Repository: mesos Description --- modify my user information Diffs (updated) - docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958 Diff: https://reviews.apache.org/r/67549/diff/2/ Changes: https://reviews.apache.org/r/67549/diff/1-2/ Testing --- Thanks, CHEN RUNCONG
Review Request 67562: The container should not be access when the container is destroyed in the mean time.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67562/ --- Review request for mesos and Gilbert Song. Bugs: 6092 https://issues.apache.org/jira/browse/6092 Repository: mesos Description --- The container should not be access when the container is destroyed in the mean time. Diffs - src/slave/containerizer/docker.cpp 391700f9698d0658b9273d79857bfa30bf3549be Diff: https://reviews.apache.org/r/67562/diff/1/ Testing --- Thanks, CHEN RUNCONG
Re: Review Request 67542: submmit my user information
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67542/ --- (Updated 六月 12, 2018, 5:19 p.m.) Review request for mesos and Gilbert Song. Repository: mesos Description --- submmit my user information Diffs (updated) - docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958 Diff: https://reviews.apache.org/r/67542/diff/2/ Changes: https://reviews.apache.org/r/67542/diff/1-2/ Testing --- Thanks, CHEN RUNCONG
Review Request 67549: modify my user information
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67549/ --- Review request for mesos. Repository: mesos Description --- modify my user information Diffs - docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958 Diff: https://reviews.apache.org/r/67549/diff/1/ Testing --- Thanks, CHEN RUNCONG
Review Request 67542: submmit my user information
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67542/ --- Review request for mesos and Gilbert Song. Repository: mesos Description --- submmit my user information Diffs - docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958 Diff: https://reviews.apache.org/r/67542/diff/1/ Testing --- Thanks, CHEN RUNCONG
