> On 六月 13, 2017, 12:12 a.m., Vinod Kone wrote:
> > Can you split this review into multiple logical reviews? It is really hard
> > to review otherwise.
> >
> > Below are a few splits I could think of
> >
> > 1) Renames of variables (e.g., in tests).
> > 2) Changes of resources value in tests
To reply, visit:
https://reviews.apache.org/r/58200/#review171402
-------
On 四月 16, 2017, 9:26 a.m., Deshi Xiao wrote:
>
> ---
> This is an automatically generated e
{
"scheme": "http",
"port": 5050
},
"gracePeriodSeconds": 300,
"intervalSeconds": 60,
"timeoutSeconds": 20,
"maxConsecutiveFailures": 3
}
}
```
Lauch task
```
$ mesos-execute --master=127.0.0.1:5050 --task=/tmp/task.json
```
And verified the healthy status of task is correct.
```
I0407 16:29:57.258509 88767 health_checker.cpp:123] Entered the net namespace
of task (pid: '88727') successfully
I0407 16:29:57.334801 88643 health_checker.cpp:395] Performed HTTP health check
for task 'test-health-check' in 86.311186ms
I0407 16:29:57.334872 88643 health_checker.cpp:319] HTTP health check for task
'test-health-check' passed
```
Thanks,
Deshi Xiao
secutiveFailures": 3
}
}
```
Lauch task
```
$ mesos-execute --master=127.0.0.1:5050 --task=/tmp/task.json
```
And verified the healthy status of task is correct.
```
I0407 16:29:57.258509 88767 health_checker.cpp:123] Entered the net namespace
of task (pid: '88727') successfully
I0407 16:29:57.334801 88643 health_checker.cpp:395] Performed HTTP health check
for task 'test-health-check' in 86.311186ms
I0407 16:29:57.334872 88643 health_checker.cpp:319] HTTP health check for task
'test-health-check' passed
```
Thanks,
Deshi Xiao
uot;
}
},
"health_check": {
"type": "HTTP",
"http": {
"scheme": "http",
"port": 5050
},
"gracePeriodSeconds": 300,
"intervalSeconds": 60,
"timeoutSeconds": 20,
"maxConsecutiveFailures": 3
}
}
```
Lauch task
```
$ mesos-execute --master=127.0.0.1:5050 --task=/tmp/task.json
```
And verified the healthy status of task is correct.
```
I0407 16:29:57.258509 88767 health_checker.cpp:123] Entered the net namespace
of task (pid: '88727') successfully
I0407 16:29:57.334801 88643 health_checker.cpp:395] Performed HTTP health check
for task 'test-health-check' in 86.311186ms
I0407 16:29:57.334872 88643 health_checker.cpp:319] HTTP health check for task
'test-health-check' passed
```
Thanks,
Deshi Xiao
Seconds": 300,
"intervalSeconds": 60,
"timeoutSeconds": 20,
"maxConsecutiveFailures": 3
}
}
```
Lauch task
```
$ mesos-execute --master=127.0.0.1:5050 --task=/tmp/task.json
```
And verified the healthy status of task is correct.
```
I0407 16:29:57.258509 88767 health_checker.cpp:123] Entered the net namespace
of task (pid: '88727') successfully
I0407 16:29:57.334801 88643 health_checker.cpp:395] Performed HTTP health check
for task 'test-health-check' in 86.311186ms
I0407 16:29:57.334872 88643 health_checker.cpp:319] HTTP health check for task
'test-health-check' passed
```
Thanks,
Deshi Xiao
mapping(--pid=host)
Diffs
-
src/slave/containerizer/docker.cpp ad9ab847cb3093724ef374d036c896b4e7f18b5e
Diff: https://reviews.apache.org/r/58200/diff/1/
Testing (updated)
---
first testing : https://gist.github.com/xiaods/c5a11e3ab51e89a9609edc2c477f7ea8
Thanks,
Deshi Xiao
-
src/slave/containerizer/docker.cpp ad9ab847cb3093724ef374d036c896b4e7f18b5e
Diff: https://reviews.apache.org/r/58200/diff/1/
Testing
---
Thanks,
Deshi Xiao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50629/#review160272
---
good for me.
- Deshi Xiao
On 七月 30, 2016, 6 p.m., Yong Tang
then bringing it
> > back up as a brand new slave."
> >
> > To truly observe this behavior, you should start a task on the slave
> > before you shut it down. Then you will see a TASK_LOST and the task will be
> > killed.
>
> Deshi Xiao wrote:
>
s is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45500/#review129929
---
On 四月 12, 2016, 11:49 a.m., Deshi Xiao wrote:
>
> ---
> This is a
ow aobut your feedback.
- Deshi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45500/#review127447
---
On 四月 12, 2
on localhost(ubuntu)
Thanks,
Deshi Xiao
on localhost(ubuntu)
Thanks,
Deshi Xiao
e062daa9fcfc776144b48325daa1f1284c5e59a4
Diff: https://reviews.apache.org/r/45500/diff/
Testing
---
make test on localhost(ubuntu)
Thanks,
Deshi Xiao
/containerizer/port_mapping_tests.cpp
e062daa9fcfc776144b48325daa1f1284c5e59a4
Diff: https://reviews.apache.org/r/45500/diff/
Testing
---
make test on localhost(ubuntu)
Thanks,
Deshi Xiao
/port_mapping_tests.cpp
e062daa9fcfc776144b48325daa1f1284c5e59a4
Diff: https://reviews.apache.org/r/45500/diff/
Testing (updated)
---
make test on localhost(ubuntu)
Thanks,
Deshi Xiao
/containerizer/port_mapping_tests.cpp
e062daa9fcfc776144b48325daa1f1284c5e59a4
Diff: https://reviews.apache.org/r/45500/diff/
Testing
---
will testing on Linux(ubuntu,centos)
Thanks,
Deshi Xiao
020fd8a4bf5911671e038a96f8b50c0f58e22ed5
src/tests/containerizer/port_mapping_tests.cpp
e062daa9fcfc776144b48325daa1f1284c5e59a4
Diff: https://reviews.apache.org/r/45500/diff/
Testing
---
will testing on Linux(ubuntu,centos)
Thanks,
Deshi Xiao
/uploaded/files/2016/04/01/c782c054-1e37-4f92-ae03-55841eca9c05__cgroups.cpp
Thanks,
Deshi Xiao
020fd8a4bf5911671e038a96f8b50c0f58e22ed5
src/tests/containerizer/port_mapping_tests.cpp
e062daa9fcfc776144b48325daa1f1284c5e59a4
Diff: https://reviews.apache.org/r/45500/diff/
Testing (updated)
---
will testing on Linux(ubuntu,centos)
Thanks,
Deshi Xiao
very common case. it need more detail discussion with team.
- Deshi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45474/#review126242
------
020fd8a4bf5911671e038a96f8b50c0f58e22ed5
src/tests/containerizer/port_mapping_tests.cpp
e062daa9fcfc776144b48325daa1f1284c5e59a4
Diff: https://reviews.apache.org/r/45500/diff/
Testing
---
make check on localhost(centos)
Thanks,
Deshi Xiao
> On 三月 30, 2016, 6:40 p.m., Cong Wang wrote:
> > You must be joking when you say you tested this Linux change on your osx...
>
> Deshi Xiao wrote:
> Oops. let me testing it again on centos.
Wang Cong, are u a ex-redhatter? if u have alternative linux, please help
testin
Diff: https://reviews.apache.org/r/45500/diff/
Testing (updated)
---
make check on localhost(centos)
Thanks,
Deshi Xiao
To reply, visit:
https://reviews.apache.org/r/45500/#review126169
---
On 三月 30, 2016, 6:34 p.m., Deshi Xiao wrote:
>
> ---
> This is an automatically generated e-mail. To rep
/45500/diff/
Testing
---
make check on mac_osx 11
Thanks,
Deshi Xiao
t case.
- Deshi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45474/#review126066
---
On 三月 30, 2016, 8:13 a.m., Deshi Xiao wrote:
>
> --
tate.
- Deshi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45474/#review126042
---
On 三月 30, 2016, 7:03 a.m., D
/tests/slave_tests.cpp 1f1a31020096efa5db698e86ac74e61dfdb4b94a
Diff: https://reviews.apache.org/r/45474/diff/
Testing
---
make check on localhost
Thanks,
Deshi Xiao
1f1a31020096efa5db698e86ac74e61dfdb4b94a
Diff: https://reviews.apache.org/r/45474/diff/
Testing
---
make check on localhost
Thanks,
Deshi Xiao
> On 三月 23, 2016, 8:21 a.m., Deshi Xiao wrote:
> > can we ignore .md scan? the .md possible container non-ascii characters.
>
> Neil Conway wrote:
> Are non-ASCII characters in .md files actually required? We should be
> able to use HTML character entities inste
characters.
- Deshi Xiao
On 三月 22, 2016, 11:49 p.m., Yong Tang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
33 matches
Mail list logo
