Re: Review Request 59294: Optionally scale egress bandwidth with CPU.

2017-07-24 Thread Ian Downes
c84aa6724170bba46bbe8410b71d42a1626e src/tests/containerizer/port_mapping_tests.cpp 16e015a8ac53a4aa5336b60c40228720b5f6910a Diff: https://reviews.apache.org/r/59294/diff/6/ Changes: https://reviews.apache.org/r/59294/diff/5-6/ Testing --- # added a new test $ make check Thanks, Ian Downes

Re: Review Request 60203: Introduce HTB class.

2017-07-24 Thread Ian Downes
464120214b75e2e422c8ea6a57c5654ba77d669f src/linux/routing/queueing/internal.hpp 9fe522ee017c86af8c7b2e518cd0957af08750e4 Diff: https://reviews.apache.org/r/60203/diff/3/ Changes: https://reviews.apache.org/r/60203/diff/2-3/ Testing --- make check Thanks, Ian Downes

Re: Review Request 60203: Introduce HTB class.

2017-06-30 Thread Ian Downes
Diff: https://reviews.apache.org/r/60203/diff/2/ Changes: https://reviews.apache.org/r/60203/diff/1-2/ Testing --- make check Thanks, Ian Downes

Re: Review Request 59294: Optionally scale egress bandwidth with CPU.

2017-06-30 Thread Ian Downes
16e015a8ac53a4aa5336b60c40228720b5f6910a Diff: https://reviews.apache.org/r/59294/diff/5/ Changes: https://reviews.apache.org/r/59294/diff/4-5/ Testing --- # added a new test $ make check Thanks, Ian Downes

Re: Review Request 60203: Introduce HTB class.

2017-06-30 Thread Ian Downes
- Ian --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60203/#review178789 --- On June 19, 2017, 12:36 p.m., Ian Downes wrote

Re: Review Request 60203: Introduce HTB class.

2017-06-30 Thread Ian Downes
ng and removed the erroneous comment. - Ian --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60203/#review178789 ----------- O

Re: Review Request 59294: Optionally scale egress bandwidth with CPU.

2017-06-30 Thread Ian Downes
scale rate by cpu and burst naturally becomes progressively less useful for higher cpu. - Ian --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59294/#review178796 ---

Re: Review Request 59294: Optionally scale egress bandwidth with CPU.

2017-06-21 Thread Ian Downes
c84aa6724170bba46bbe8410b71d42a1626e src/tests/containerizer/port_mapping_tests.cpp 16e015a8ac53a4aa5336b60c40228720b5f6910a Diff: https://reviews.apache.org/r/59294/diff/4/ Changes: https://reviews.apache.org/r/59294/diff/3-4/ Testing --- # added a new test $ make check Thanks, Ian Downes

Re: Review Request 59294: Optionally scale egress bandwidth with CPU.

2017-06-21 Thread Ian Downes
--- # added a new test $ make check Thanks, Ian Downes

Re: Review Request 59294: Optionally scale egress bandwidth with CPU.

2017-06-19 Thread Ian Downes
gt; > Then, the custom logic can be injected into a label decrorator, rather > > than first class it here? > > Ian Downes wrote: > It's not really a heuristic, it's a simple linear model with min/max. The > major benefit is that it enables more effective allocation of a

Review Request 60203: Introduce HTB class.

2017-06-19 Thread Ian Downes
857646190d21387f98832f5094128505a52a0776 src/linux/routing/queueing/htb.cpp 464120214b75e2e422c8ea6a57c5654ba77d669f src/linux/routing/queueing/internal.hpp 9fe522ee017c86af8c7b2e518cd0957af08750e4 Diff: https://reviews.apache.org/r/60203/diff/1/ Testing --- make check Thanks, Ian Downes

Re: Review Request 59294: Optionally scale egress bandwidth with CPU.

2017-05-26 Thread Ian Downes
0c8276e425a6a7d22ee68edc6cc25b331635ec44 src/tests/containerizer/port_mapping_tests.cpp d062f2f6bcf7b44dbcde951cdca23b0a2cd42115 Diff: https://reviews.apache.org/r/59294/diff/2/ Testing --- # added a new test $ make check Thanks, Ian Downes

Re: Review Request 59294: Optionally scale egress bandwidth with CPU.

2017-05-26 Thread Ian Downes
/tests/containerizer/port_mapping_tests.cpp d062f2f6bcf7b44dbcde951cdca23b0a2cd42115 Diff: https://reviews.apache.org/r/59294/diff/2/ Changes: https://reviews.apache.org/r/59294/diff/1-2/ Testing --- # added a new test $ make check Thanks, Ian Downes

Re: Review Request 59294: Optionally scale egress bandwidth with CPU.

2017-05-26 Thread Ian Downes
/tests/containerizer/port_mapping_tests.cpp d062f2f6bcf7b44dbcde951cdca23b0a2cd42115 Diff: https://reviews.apache.org/r/59294/diff/2/ Changes: https://reviews.apache.org/r/59294/diff/1-2/ Testing --- # added a new test $ make check Thanks, Ian Downes

Re: Review Request 59294: Optionally scale egress bandwidth with CPU.

2017-05-24 Thread Ian Downes
ply, visit: https://reviews.apache.org/r/59294/#review175114 --- On May 15, 2017, 1:56 p.m., Ian Downes wrote: > > --- > This is an automatically generated e-mail. To reply, vi

Review Request 59294: Optionally scale egress bandwidth with CPU.

2017-05-15 Thread Ian Downes
bc63a6a4cb6115b4b4d592e67e34045f52b50d4c src/tests/containerizer/port_mapping_tests.cpp a528382e8b4831b9c7e8dcc877a5e242909f0cd5 Diff: https://reviews.apache.org/r/59294/diff/1/ Testing --- # added a new test $ make check Thanks, Ian Downes

Re: Review Request 53931: Don't expect an init process in a FreeBSD jail.

2016-12-02 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53931/#review157872 --- Ship it! Ship It! - Ian Downes On Nov. 19, 2016, 11:13 a.m

Re: Review Request 53927: Check isJailed in tests that call mknod.

2016-12-02 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53927/#review157871 --- Ship it! Ship It! - Ian Downes On Nov. 18, 2016, 10:45 p.m

Re: Review Request 53926: Move isJailed for FreeBSD into utils.

2016-12-02 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53926/#review157869 --- Ship it! Ship It! - Ian Downes On Nov. 19, 2016, 4:42 p.m

Re: Review Request 53925: Fix wait macros on FreeBSD.

2016-12-02 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53925/#review157868 --- Ship it! Ship It! - Ian Downes On Nov. 18, 2016, 10:17 p.m

Re: Review Request 53913: Disable sentinel checks for clang on FreeBSD.

2016-12-02 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53913/#review157866 --- Ship it! Ship It! - Ian Downes On Nov. 18, 2016, 4:11 p.m

Re: Review Request 53912: Fix xattr for FreeBSD.

2016-12-02 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53912/#review157865 --- Ship it! Ship It! - Ian Downes On Nov. 18, 2016, 4:10 p.m

Re: Review Request 53882: Fix configure on FreeBSD.

2016-12-02 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53882/#review157864 --- Ship it! Ship It! - Ian Downes On Nov. 18, 2016, 4:11 p.m

Review Request 53009: Add support for task labels to example no_executor_framework.

2016-10-18 Thread Ian Downes
Description --- Add support for task labels to example no_executor_framework. Diffs - src/examples/no_executor_framework.cpp e82ae9a9ea23c7d181b071f0e3f5071b3856d8a4 Diff: https://reviews.apache.org/r/53009/diff/ Testing --- Thanks, Ian Downes

Re: Review Request 50540: Add systemd watchdog support.

2016-08-09 Thread Ian Downes
d accepted the stop command? src/tests/linux/systemd_tests.cpp (line 126) <https://reviews.apache.org/r/50540/#comment211392> What happens if there's an assertion during the test!? Because this is outside the test sandbox it'll leak. See earlier comment about writing and refere

Re: Review Request 49273: Helper binary for executors to chroot tasks.

2016-07-05 Thread Ian Downes
only for the command executor? - Ian --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49273/#review139601 --- On June 27, 2016, 10:09

Re: Review Request 49273: Helper binary for executors to chroot tasks.

2016-07-05 Thread Ian Downes
> On July 4, 2016, 10:06 a.m., Jie Yu wrote: > > Please see the test section of https://reviews.apache.org/r/49569/ > > > > Let me know if that's ok or not. Thanks! > > Ian Downes wrote: > Hey, thanks for looking at this. I looked at the review for

Re: Review Request 49273: Helper binary for executors to chroot tasks.

2016-07-05 Thread Ian Downes
pache.org/r/49273/#review140687 --- On June 27, 2016, 10:09 a.m., Ian Downes wrote: > > --- > This is an automatically generated e-mail. To reply, vis

Review Request 49273: Helper binary for executors to chroot tasks.

2016-06-27 Thread Ian Downes
. Thanks, Ian Downes

Re: Review Request 44475: Improve master slaves metrics.

2016-03-07 Thread Ian Downes
/ which describes why I think this is an unexpected fundamental change in how the metrics are counted. - Ian Downes On March 7, 2016, 2:51 p.m., Cong Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 44474: Improve master tasks metrics.

2016-03-07 Thread Ian Downes
.e., staging before starting. src/master/metrics.cpp (line 193) <https://reviews.apache.org/r/44474/#comment184416> foreach? - Ian Downes On March 7, 2016, 2:51 p.m., Cong Wang wrote: > > --- > This is an automatically

Re: Review Request 43283: Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.

2016-02-26 Thread Ian Downes
> On Feb. 8, 2016, 2:52 p.m., Ian Downes wrote: > > src/linux/perf.cpp, lines 423-426 > > <https://reviews.apache.org/r/43283/diff/1/?file=1237011#file1237011line423> > > > > Hmmm, I'm not satisfied with this. I thought the new output format was > >

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

2016-02-18 Thread Ian Downes
> On Dec. 15, 2015, 11:36 a.m., Ian Downes wrote: > > src/slave/containerizer/docker.cpp, line 838 > > <https://reviews.apache.org/r/33174/diff/2/?file=927472#file927472line838> > > > > Docker supports specifying the CFS period and quota to run a contai

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

2016-02-18 Thread Ian Downes
tps://reviews.apache.org/r/33174/#comment181038> Why not call update() here, rather than _update()? It will determine the correct pid, just launched in launchExecutorContainer(). - Ian Downes On Dec. 15, 2015, 12:14 p.m., Steve Niemitz

Re: Review Request 43730: Added SNMP statistics to v1 mesos.proto too.

2016-02-18 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43730/#review119687 --- Ship it! Ship It! - Ian Downes On Feb. 18, 2016, 11:15 a.m

Re: Review Request 43284: Wait for perf statistics processes exit.

2016-02-08 Thread Ian Downes
econds. Note: I'm not sure if the correct behavior is implemented... - Ian Downes On Feb. 7, 2016, 12:19 a.m., haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 43284: Wait for perf statistics processes exit.

2016-02-08 Thread Ian Downes
> On Feb. 8, 2016, 2:47 p.m., Ian Downes wrote: > > src/slave/containerizer/mesos/isolators/cgroups/perf_event.cpp, lines > > 132-134 > > <https://reviews.apache.org/r/43284/diff/1/?file=1237013#file1237013line132> > > > > I think you should disca

Re: Review Request 43283: Fix PerfEventIsolatorTest.ROOT_CGROUPS_Sample failed on CentOS 7.1.

2016-02-08 Thread Ian Downes
org/r/43283/#comment179540> Hmmm, I'm not satisfied with this. I thought the new output format was introduced at a specific kernel version (3.13.0 might not be correct). Could you please confirm that the 3.10 on CentOS7.1 has the new unit field but other 3.10 kernels don't. - Ian

Re: Review Request 42757: Split os::memory() out into platform specific files.

2016-02-08 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42757/#review118301 --- Ship it! Ship It! - Ian Downes On Feb. 5, 2016, 9:35 a.m

Re: Review Request 42735: Make bash scripts portable.

2016-02-08 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42735/#review118297 --- Ship it! Ship It! - Ian Downes On Feb. 5, 2016, 8:51 a.m

Re: Review Request 42735: Make commit-msg hook portable.

2016-01-25 Thread Ian Downes
--- > > (Updated Jan. 25, 2016, 12:07 p.m.) > > > Review request for mesos, Artem Harutyunyan and Ian Downes. > > > Bugs: MESOS-4502 > https://issues.apache.org/jira/browse/MESOS-4502 > > > Repository: mesos > > > D

Re: Review Request 41911: Added a test case for corrupt packets

2016-01-20 Thread Ian Downes
tests/containerizer/port_mapping_tests.cpp (line 1149) <https://reviews.apache.org/r/41911/#comment176189> ditto, drop the "1". src/tests/containerizer/port_mapping_tests.cpp (line 1172) <https://reviews.apache.org/r/41911/#comment176264>

Re: Review Request 41726: Implement os::memory() for FreeBSD.

2016-01-20 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41726/#review115510 --- Ship it! Ship It! - Ian Downes On Jan. 7, 2016, 4:52 p.m

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

2015-12-15 Thread Ian Downes
cfs quota changes depending on the CPU resource value so it definitely does need to be re-written at every update. Again, this is a straight copy-and-paste from the MC cpu isolator. This part of the code looks fine to me. @Tim, do you concur? - Ian Downes On April 14, 2015, 1:32 p.m., S

Re: Review Request 38117: Export per container SNMP statistics

2015-12-15 Thread Ian Downes
d test parsing is sucessful, further tests should ensure known values are parsed correctly. - Ian Downes On Dec. 14, 2015, 4:05 p.m., Cong Wang wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 41245: Use ethtool -k lo to check ethtool command

2015-12-11 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41245/#review109990 --- Ship it! Ship It! - Ian Downes On Dec. 10, 2015, 9:20 p.m

Re: Review Request 41158: Turn off rx checksum offloading for veth in container

2015-12-09 Thread Ian Downes
/port_mapping.cpp (line 3572) <https://reviews.apache.org/r/41158/#comment169231> s/kernel/the kernel/ src/slave/containerizer/mesos/isolators/network/port_mapping.cpp (line 3574) <https://reviews.apache.org/r/41158/#comment169230> s/could/to - Ian Downes On Dec. 9, 2015, 3:1

Re: Review Request 39634: FreeBSD: Enable mesos build and start fixing some tests

2015-11-30 Thread Ian Downes
ity in libc? src/tests/attributes_tests.cpp (line 38) <https://reviews.apache.org/r/39634/#comment167813> These are unrelated to the FreeBSD support so can you split them out? Else, I'll do it when I commit this patch. - Ian Downes On Nov. 27, 2015, 8:26 p.m., Da

Re: Review Request 39635: FreeBSD: Enable libprocess build and disable failing test

2015-11-30 Thread Ian Downes
ss/src/tests/http_tests.cpp (line 897) <https://reviews.apache.org/r/39635/#comment167819> Full stop. - Ian Downes On Nov. 27, 2015, 8:26 p.m., David Forsythe wrote: > > --- > This is an automatically generated e-mai

Re: Review Request 37101: Remove unused sched API's

2015-11-17 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37101/#review106954 --- Ship it! Ship It! - Ian Downes On Aug. 24, 2015, 2:30 p.m

Re: Review Request 39417: Add --egress_flow_classifier_parent flag

2015-11-17 Thread Ian Downes
> On Oct. 26, 2015, 5:20 p.m., Ian Downes wrote: > > src/slave/containerizer/isolators/network/port_mapping.cpp, lines 401-405 > > <https://reviews.apache.org/r/39417/diff/1/?file=1100528#file1100528line401> > > > > Why not add a 0x prefix if it's

Re: Review Request 38074: Calculate schedule latency with trace events

2015-11-17 Thread Ian Downes
pache.org/r/38074/#comment165808> Users have different kernels, code should determine the version at run time and act accordingly. src/slave/containerizer/isolators/cgroups/perf_event.cpp (line 633) <https://reviews.apache.org/r/38074/#comment165811> Include error mes

Re: Review Request 39415: Error out when root qdisc already exists

2015-10-27 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39415/#review104185 --- Ship it! Ship It! - Ian Downes On Oct. 17, 2015, 5:22 p.m

Re: Review Request 39490: Always create non-IP egress filters

2015-10-27 Thread Ian Downes
2431) <https://reviews.apache.org/r/39490/#comment162473> Why is this no longer a failure? src/slave/containerizer/isolators/network/port_mapping.cpp (line 2450) <https://reviews.apache.org/r/39490/#comment162474> ditto? - Ian Downes On Oct. 20, 2015, 11:57 a.m., Con

Re: Review Request 39416: Document --egress_unique_flow_per_container in docs/configuration.md

2015-10-27 Thread Ian Downes
tps://reviews.apache.org/r/39416/#comment162355> Does it actually create a flow per container or is it really based on the 5 tuple, which will be different for different containers? - Ian Downes On Oct. 17, 2015, 5:24 p.m., Cong Wang

Re: Review Request 39417: Add --egress_flow_classifier_parent flag

2015-10-26 Thread Ian Downes
.cpp (lines 506 - 513) <https://reviews.apache.org/r/39417/#comment162362> Why is this description different from the docs? - Ian Downes On Oct. 17, 2015, 5:29 p.m., Cong Wang wrote: > > --- > This is an automaticall

Re: Review Request 39417: Add --egress_flow_classifier_parent flag

2015-10-26 Thread Ian Downes
t; > (Updated Oct. 17, 2015, 5:29 p.m.) > > > Review request for mesos, Ian Downes and Jie Yu. > > > Repository: mesos > > > Description > --- > > When --egress_unique_flow_per_container is enabled, we need to install a flow > classifie

Re: Review Request 39345: Enable build on FreeBSD, start porting components.

2015-10-21 Thread Ian Downes
're using this for setting quota. src/tests/attributes_tests.cpp (line 40) <https://reviews.apache.org/r/39345/#comment161517> Did this cause a problem running the tests or are you cleaning things up? - Ian Downes On Oct. 20, 2015, 12:45 a.m., David Forsythe wrote: > >

Re: Review Request 39345: Enable build on FreeBSD, start porting components.

2015-10-21 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39345/#review103232 ------- On Oct. 20, 2015, 12:45 a.m., David Forsythe wrote: > > --- > This is an automati

Re: Review Request 38117: Export per container SNMP statistics

2015-10-16 Thread Ian Downes
lave/containerizer/isolators/network/port_mapping.cpp (line 1169) <https://reviews.apache.org/r/38117/#comment160782> Toggle line type here. src/slave/containerizer/isolators/network/port_mapping.cpp (lines 1171 - 1174) <https://reviews.apache.org/r/38117/#comment160781>

Re: Review Request 38855: Added support for getting shared and slave mount peer group ID.

2015-09-29 Thread Ian Downes
(line 241) <https://reviews.apache.org/r/38855/#comment158311> Like above, can you verify the master id is correct? src/tests/containerizer/fs_tests.cpp (line 243) <https://reviews.apache.org/r/38855/#comment158310> s/Cleanup/Clean up/ - Ian Downes On Sept. 29,

Re: Review Request 38858: Ensured that slave's work_dir is a shared mount in its own peer group when LinuxFilesystemIsolator is used.

2015-09-29 Thread Ian Downes
a shared mount... src/tests/containerizer/filesystem_isolator_tests.cpp (lines 949 - 953) <https://reviews.apache.org/r/38858/#comment158319> Ditto. - Ian Downes On Sept. 29, 2015, 12:48 p.m., Jie Yu wrote: > > --- > This i

Re: Review Request 34136: Add ContainerImage protobuf.

2015-07-11 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34136/#review89438 --- On June 22, 2015, 9:42 a.m., Ian Downes wrote

Re: Review Request 34136: Add ContainerImage protobuf.

2015-07-11 Thread Ian Downes
. To reply, visit: https://reviews.apache.org/r/34136/#review90166 --- On June 22, 2015, 9:42 a.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 34136: Add ContainerImage protobuf.

2015-07-11 Thread Ian Downes
a.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34136/ --- (Updated June 22, 2015, 9:42 a.m.) Review

Re: Review Request 34135: Add filesystem/ isolators for persistent volumes.

2015-07-11 Thread Ian Downes
-CREATION src/slave/containerizer/isolators/filesystem/posix.cpp PRE-CREATION src/slave/containerizer/mesos/containerizer.cpp 47d146125dfd4ea909e7ec9d94f41cfa11d035e5 Diff: https://reviews.apache.org/r/34135/diff/ Testing --- existing persistent volumes tests. Thanks, Ian Downes

Review Request 36428: Remove erroneous code for isolator modules.

2015-07-11 Thread Ian Downes
/diff/ Testing --- Thanks, Ian Downes

Review Request 36429: Add filesystem/linux isolator for persistent volumes.

2015-07-11 Thread Ian Downes
PRE-CREATION src/slave/containerizer/mesos/containerizer.cpp 47d146125dfd4ea909e7ec9d94f41cfa11d035e5 Diff: https://reviews.apache.org/r/36429/diff/ Testing --- Thanks, Ian Downes

Re: Review Request 34135: Add filesystem/posix isolator for persistent volumes.

2015-07-11 Thread Ian Downes
/filesystem/posix.cpp PRE-CREATION src/slave/containerizer/mesos/containerizer.cpp 47d146125dfd4ea909e7ec9d94f41cfa11d035e5 Diff: https://reviews.apache.org/r/34135/diff/ Testing --- existing persistent volumes tests. Thanks, Ian Downes

Re: Review Request 34137: Add support for container image provisioners.

2015-07-11 Thread Ian Downes
--- Thanks, Ian Downes

Re: Review Request 34135: Add filesystem/ isolators for persistent volumes.

2015-07-10 Thread Ian Downes
--- On June 22, 2015, 9:41 a.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34135

Re: Review Request 34137: Add support for container image provisioners.

2015-07-10 Thread Ian Downes
0741616b656e947cb460dd6ee6a9a4852be001c2 src/slave/state.hpp fed4b7ecf9572a8dbb1a99dbb1769d3e55ef7bc5 src/slave/state.cpp 8eda22a550e5add0f84c46cc2ed762b006c0dcec src/tests/containerizer_tests.cpp 0cdb2d2a3f19a4835e85c6b040759019b03f051e Diff: https://reviews.apache.org/r/34137/diff/ Testing --- Thanks, Ian

Re: Review Request 34135: Add filesystem/ isolators for persistent volumes.

2015-07-10 Thread Ian Downes
8c102fb7d1f79ee768cb06de3a976ea12f958712 Diff: https://reviews.apache.org/r/34135/diff/ Testing --- existing persistent volumes tests. Thanks, Ian Downes

Re: Review Request 36378: Refactor Linux Performance monitor to handle changing 'perf stat' output versions depending on kernel version.

2015-07-10 Thread Ian Downes
://reviews.apache.org/r/36378/#comment144550 newline - Ian Downes On July 9, 2015, 4:08 p.m., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36378

Re: Review Request 36380: Test cases for performance monitor support of multiple output versions depending on kernel version.

2015-07-10 Thread Ian Downes
- Ian Downes On July 10, 2015, 1:52 p.m., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36380/ --- (Updated July

Re: Review Request 34137: Add support for container image provisioners.

2015-07-07 Thread Ian Downes
0741616b656e947cb460dd6ee6a9a4852be001c2 src/slave/state.hpp fed4b7ecf9572a8dbb1a99dbb1769d3e55ef7bc5 src/slave/state.cpp 8eda22a550e5add0f84c46cc2ed762b006c0dcec src/tests/containerizer_tests.cpp 0cdb2d2a3f19a4835e85c6b040759019b03f051e Diff: https://reviews.apache.org/r/34137/diff/ Testing --- Thanks, Ian

Re: Review Request 34141: AppC provsioning backend.

2015-07-07 Thread Ian Downes
--- Thanks, Ian Downes

Re: Review Request 34142: AppC provisioner.

2015-07-07 Thread Ian Downes
/flags.cpp cbf431eb0627bdaf07241cc0fc4630df06fb20e2 Diff: https://reviews.apache.org/r/34142/diff/ Testing --- Thanks, Ian Downes

Re: Review Request 31444: Support chrooting in MesosContainerizer launch helper.

2015-07-07 Thread Ian Downes
--- Manual testing only so far. This is harder to automate because we need a self-contained chroot to execute something in... Suggestions welcome. Thanks, Ian Downes

Re: Review Request 34140: AppC image store

2015-07-07 Thread Ian Downes
/diff/ Testing --- Thanks, Ian Downes

Re: Review Request 34139: AppC image discovery.

2015-07-07 Thread Ian Downes
src/slave/containerizer/provisioners/appc/discovery.cpp PRE-CREATION src/slave/flags.hpp 7634e368c72e83932dcd992d78eaca146326606b src/slave/flags.cpp cbf431eb0627bdaf07241cc0fc4630df06fb20e2 Diff: https://reviews.apache.org/r/34139/diff/ Testing --- Thanks, Ian Downes

Re: Review Request 34138: AppC hash computation.

2015-07-07 Thread Ian Downes
://reviews.apache.org/r/34138/diff/ Testing --- Thanks, Ian Downes

Re: Review Request 36281: Document per-container unique egress flows and network queueing statistics.

2015-07-07 Thread Ian Downes
://reviews.apache.org/r/36281/#comment143938 Can you state and explain why there's no shaping/limit on ingress? State explicitly that shaping delays traffic and will not drop packets. - Ian Downes On July 7, 2015, 2:54 p.m., Paul Brett wrote

Re: Review Request 31444: Support chrooting in MesosContainerizer launch helper.

2015-07-06 Thread Ian Downes
://reviews.apache.org/r/31444/#review89425 --- On June 22, 2015, 9:38 a.m., Ian Downes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org

Re: Review Request 36113: perf: refactored parse to allow determining an output parsing function based on the runtime version.

2015-07-01 Thread Ian Downes
(line) and gets the right output. - Ian Downes On July 1, 2015, 3:44 p.m., Chi Zhang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36113

Re: Review Request 36114: perf: added another extract function to support the new perf format after v3.12.

2015-07-01 Thread Ian Downes
if (a x) { // } else if (a y) { // } else if (a z) { // } else { // } ``` src/linux/perf.cpp (line 549) https://reviews.apache.org/r/36114/#comment143163 Where is the variable `version` defined? - Ian Downes On July 1, 2015, 3:44 p.m., Chi

Re: Review Request 36115: perf: changed 'parse' interface to allow testing and added tests.

2015-07-01 Thread Ian Downes
fields and values. src/tests/perf_tests.cpp (line 87) https://reviews.apache.org/r/36115/#comment143172 ```cpp foreach (const tupleVersion, string input, input1) {} ```? - Ian Downes On July 1, 2015, 3:44 p.m., Chi Zhang wrote

Re: Review Request 36112: perf: extracted out a 'version' function.

2015-07-01 Thread Ian Downes
/36112/#comment143162 See subsequent review, I don't think this needs to be pulled out into a separate function. - Ian Downes On July 1, 2015, 3:43 p.m., Chi Zhang wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 36014: Fixed stack trace in isolator tests on Linux VM

2015-06-29 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36014/#review89775 --- Ship it! Ship It! - Ian Downes On June 29, 2015, 11:58 a.m

Re: Review Request 34835: Add constexpr to C++ whitelist

2015-06-26 Thread Ian Downes
is only for constexpr functions? - Ian Downes On June 24, 2015, 2:14 p.m., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34835

Re: Review Request 35585: Updated Isolator to return required namespaces.

2015-06-23 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35585/#review89011 --- Ship it! Ship It! - Ian Downes On June 22, 2015, 10:03 p.m

Re: Review Request 35585: Updated Isolator to return required namespaces.

2015-06-23 Thread Ian Downes
On June 23, 2015, 11:01 a.m., Ian Downes wrote: Ship It! For the test error, are we not cleaning out /var/run/mesos/netns (correctly) between tests so we're trying to symlink container1 repeatedly? We should probably be storing these symlinks in a directory the test controls? - Ian

Re: Review Request 34137: Add support for container image provisioners.

2015-06-22 Thread Ian Downes
0cdb2d2a3f19a4835e85c6b040759019b03f051e Diff: https://reviews.apache.org/r/34137/diff/ Testing --- Thanks, Ian Downes

Re: Review Request 34908: Rename --docker_sandbox_directory flag for general use.

2015-06-22 Thread Ian Downes
://reviews.apache.org/r/34908/diff/ Testing --- Thanks, Ian Downes

Re: Review Request 34141: AppC provsioning backend.

2015-06-22 Thread Ian Downes
/ Testing --- Thanks, Ian Downes

Re: Review Request 34140: AppC image store

2015-06-22 Thread Ian Downes
: https://reviews.apache.org/r/34140/diff/ Testing --- Thanks, Ian Downes

Re: Review Request 35033: Define potentially missing MS_* mount flags.

2015-06-22 Thread Ian Downes
/r/35033/diff/ Testing --- Thanks, Ian Downes

Re: Review Request 32891: Support for entering and configuring a Linux chroot.

2015-06-22 Thread Ian Downes
/fs.cpp 568565f878b34708170a886dc4d62849aa01f263 Diff: https://reviews.apache.org/r/32891/diff/ Testing --- Thanks, Ian Downes

Re: Review Request 34142: AppC provisioner.

2015-06-22 Thread Ian Downes
/provisioners/appc.cpp PRE-CREATION src/slave/flags.hpp 7634e368c72e83932dcd992d78eaca146326606b src/slave/flags.cpp cbf431eb0627bdaf07241cc0fc4630df06fb20e2 Diff: https://reviews.apache.org/r/34142/diff/ Testing --- Thanks, Ian Downes

Re: Review Request 34135: Add filesystem/ isolators for persistent volumes.

2015-06-22 Thread Ian Downes
/containerizer/linux_launcher.cpp 8eae258d81229e19f8c587f5e023b1df7deed025 src/slave/containerizer/mesos/containerizer.cpp 8c102fb7d1f79ee768cb06de3a976ea12f958712 Diff: https://reviews.apache.org/r/34135/diff/ Testing --- existing persistent volumes tests. Thanks, Ian Downes

  1   2   >