Re: Review Request 49903: Printed empty set if `Resources` instance is empty.

2016-07-11 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49903/#review141750 --- Ship it! Ship It! - Isabel Jimenez On July 11, 2016, 4:31

Re: Review Request 42674: Replaced busybox with alpine in docker tests.

2016-01-25 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42674/#review116162 --- Ship it! Ship It! - Isabel Jimenez On Jan. 25, 2016, 7:18

Re: Review Request 42674: Replaced busybox with alpine in docker tests.

2016-01-22 Thread Isabel Jimenez
tps://reviews.apache.org/r/42674/#comment176994> Why can't we be consistent and use the official alpine image here too? - Isabel Jimenez On Jan. 23, 2016, 12:02 a.m., Timothy Chen wrote: > > --- > This is an automatically generated e

Re: Review Request 42674: Replaced busybox with alpine in docker tests.

2016-01-22 Thread Isabel Jimenez
> On Jan. 23, 2016, 12:14 a.m., Isabel Jimenez wrote: > > +1 for this change. Alpine is great. - Isabel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42674/#rev

Re: Review Request 23747: check missing apache headers script

2015-12-11 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23747/#review110045 --- test - Isabel Jimenez On July 22, 2014, 1:37 a.m., Isabel

Re: Review Request 39908: Added a section to Upgrades doc

2015-11-03 Thread Isabel Jimenez
, Isabel Jimenez

Re: Review Request 39908: Added a section to Upgrades doc

2015-11-03 Thread Isabel Jimenez
generated e-mail. To reply, visit: https://reviews.apache.org/r/39908/#review104953 --- On Nov. 3, 2015, 6 p.m., Isabel Jimenez wrote: > > --- > This is an automatically

Review Request 39908: Added a section to Upgrades doc

2015-11-03 Thread Isabel Jimenez
--- Added mention to Credential protobuf change in 0.26 in uprades.md Diffs - docs/upgrades.md 3854e59 Diff: https://reviews.apache.org/r/39908/diff/ Testing --- Thanks, Isabel Jimenez

Re: Review Request 39908: Added a section to Upgrades doc

2015-11-03 Thread Isabel Jimenez
docs/upgrades.md 3854e59 Diff: https://reviews.apache.org/r/39908/diff/ Testing --- Thanks, Isabel Jimenez

Re: Review Request 39908: Added a section to Upgrades doc

2015-11-03 Thread Isabel Jimenez
/diff/ Testing --- Thanks, Isabel Jimenez

Re: Review Request 39908: Added a section to Upgrades doc

2015-11-03 Thread Isabel Jimenez
--- Thanks, Isabel Jimenez

Re: Review Request 39908: Added a section to Upgrades doc

2015-11-03 Thread Isabel Jimenez
> On Nov. 3, 2015, 7:21 p.m., Neil Conway wrote: > > docs/upgrades.md, line 16 > > <https://reviews.apache.org/r/39908/diff/1/?file=1114771#file1114771line16> > > > > AFAIK this isn't Java-specific. > > Isabel Jimenez wrote: > This will mostly

Re: Review Request 39908: Added a section to Upgrades doc

2015-11-03 Thread Isabel Jimenez
> On Nov. 3, 2015, 11:33 p.m., Guangya Liu wrote: > > CHANGELOG, line 1 > > <https://reviews.apache.org/r/39908/diff/4/?file=1115243#file1115243line1> > > > > s/Version 0.26.0/Version 0.26.0(WIP) > > Isabel Jimenez wrote: > This are the rele

Re: Review Request 39908: Added a section to Upgrades doc

2015-11-03 Thread Isabel Jimenez
://reviews.apache.org/r/39908/diff/ Testing --- Thanks, Isabel Jimenez

Re: Review Request 39908: Added a section to Upgrades doc

2015-11-03 Thread Isabel Jimenez
/diff/ Testing --- Thanks, Isabel Jimenez

Re: Review Request 39908: Added a section to Upgrades doc

2015-11-03 Thread Isabel Jimenez
o need to specify WIP - Isabel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39908/#review105002 --- On Nov. 3, 2015,

Re: Review Request 39908: Added a section to Upgrades doc

2015-11-03 Thread Isabel Jimenez
---- On Nov. 3, 2015, 10:30 p.m., Isabel Jimenez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39908/ > -

Re: Review Request 39908: Added a section to Upgrades doc

2015-11-03 Thread Isabel Jimenez
/diff/ Testing --- Thanks, Isabel Jimenez

Re: Review Request 39708: Removed redundant code for conversion from PID to HTTP based frameworks

2015-10-28 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39708/#review104337 --- Ship it! Ship It! - Isabel Jimenez On Oct. 28, 2015, 4:51 a.m

Re: Review Request 39709: Added logic to ensure the during a HTTP to PID scheduler downgrade, the previous HTTP instance gets an error message

2015-10-28 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39709/#review104339 --- Ship it! Ship It! - Isabel Jimenez On Oct. 28, 2015, 4:54 a.m

Re: Review Request 39710: Added test to verify downgrade from HTTP to PID based schedulers

2015-10-28 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39710/#review104347 --- Ship it! Ship It! - Isabel Jimenez On Oct. 28, 2015, 8:43 p.m

Re: Review Request 38577: Added synchronous validation for Call in Agent

2015-10-26 Thread Isabel Jimenez
Inversed advise here, killed this and made sure above pattern is consistent everywhere. - Isabel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38577/#review104123 ----

Re: Review Request 38618: Changed executor HTTP API tests

2015-10-26 Thread Isabel Jimenez
(updated) - src/tests/executor_http_api_tests.cpp e429d84 Diff: https://reviews.apache.org/r/38618/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 38577: Added synchronous validation for Call in Agent

2015-10-26 Thread Isabel Jimenez
e6169a0 src/Makefile.am e797dac src/slave/http.cpp 3f7f71b src/slave/validation.hpp PRE-CREATION src/slave/validation.cpp PRE-CREATION src/tests/executor_http_api_tests.cpp e429d84 Diff: https://reviews.apache.org/r/38577/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 38844: Added unit tests for Call validation in Agent

2015-10-26 Thread Isabel Jimenez
://reviews.apache.org/r/38844/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 38577: Added synchronous validation for Call in Agent

2015-10-26 Thread Isabel Jimenez
src/Makefile.am e797dac src/slave/http.cpp 3f7f71b src/slave/validation.hpp PRE-CREATION src/slave/validation.cpp PRE-CREATION src/tests/executor_http_api_tests.cpp e429d84 Diff: https://reviews.apache.org/r/38577/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 38844: Added unit tests for Call validation in Agent

2015-10-26 Thread Isabel Jimenez
: https://reviews.apache.org/r/38844/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 39323: Fixed syntax error in sed usage on OSX.

2015-10-14 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39323/#review102705 --- Ship it! Ship It! - Isabel Jimenez On Oct. 14, 2015, 6:26 p.m

Re: Review Request 39098: Changed secret field in Credential from 'bytes' to 'string'

2015-10-13 Thread Isabel Jimenez
/java/TestFramework.java aad94c0 src/tests/credentials_tests.cpp ced27c4 Diff: https://reviews.apache.org/r/39098/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 39099: Changed secret field in Credential from 'bytes' to 'string' for V1

2015-10-13 Thread Isabel Jimenez
Thanks, Isabel Jimenez

Re: Review Request 39098: Changed secret field in Credential from 'bytes' to 'string'

2015-10-13 Thread Isabel Jimenez
/examples/java/TestFramework.java aad94c0 src/tests/credentials_tests.cpp ced27c4 Diff: https://reviews.apache.org/r/39098/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 39098: Changed secret field in Credential from 'bytes' to 'string'

2015-10-07 Thread Isabel Jimenez
78720b0 src/examples/java/TestFramework.java aad94c0 Diff: https://reviews.apache.org/r/39098/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 38899: Added handler for Executor->Framework message for the Executor HTTP API

2015-10-07 Thread Isabel Jimenez
> On Oct. 7, 2015, 6:40 p.m., Isabel Jimenez wrote: > > Ship It! LGTM, just might need to get rebase on changes for switch syntax in other patches. - Isabel --- This is an automatically generated e-mail. To reply, vis

Review Request 39100: Changed Credential validation

2015-10-07 Thread Isabel Jimenez
--- We should validate credentials before anything else in HTTP endpoints. Diffs - src/master/http.cpp 4b9f9ed Diff: https://reviews.apache.org/r/39100/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 39100: Changed Credential validation

2015-10-07 Thread Isabel Jimenez
--- make check Thanks, Isabel Jimenez

Review Request 39003: Fixed Python protobuf V1 generation

2015-10-05 Thread Isabel Jimenez
Massenzio. Repository: mesos Description --- V1 protobus were not being generated for python. Diffs - src/Makefile.am e698927 Diff: https://reviews.apache.org/r/39003/diff/ Testing --- make check and verify v1 protobufs were properly generated Thanks, Isabel Jimenez

Review Request 39002: Fixed sed command for Python protos generation.

2015-10-05 Thread Isabel Jimenez
properly generated Thanks, Isabel Jimenez

Re: Review Request 38875: Moved the framework/executor exists check before Subscribe call in Agent

2015-10-05 Thread Isabel Jimenez
875/#comment158997> Could you please change the syntax for every case to be consistent with `: {` through this switch? - Isabel Jimenez On Sept. 30, 2015, 3:39 a.m., Anand Mazumdar wrote: > > --- > This is an automatica

Re: Review Request 38877: Added functionality for Subscribe/Subscribed workflow for HTTP executors

2015-10-05 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38877/#review101565 --- Ship it! Ship It! - Isabel Jimenez On Sept. 30, 2015, 6:06 a.m

Re: Review Request 38873: Added helper functions for evolving old style executor messages to V1 Executor Events

2015-10-05 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38873/#review101550 --- LGTM just small nit from standing review issue - Isabel Jimenez

Re: Review Request 38646: Added WIP note for Executor endpoint in changelog

2015-10-05 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38646/#review101544 --- Ship it! Ship It! - Isabel Jimenez On Sept. 25, 2015, 12:09

Re: Review Request 38873: Added helper functions for evolving old style executor messages to V1 Executor Events

2015-10-05 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38873/#review101551 --- Ship it! Ship It! - Isabel Jimenez On Oct. 5, 2015, 11:09 p.m

Re: Review Request 38577: Added synchronous validation for Call in Agent

2015-10-05 Thread Isabel Jimenez
src/slave/http.cpp f9cf7bb src/slave/validation.hpp PRE-CREATION src/slave/validation.cpp PRE-CREATION Diff: https://reviews.apache.org/r/38577/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 38577: Added synchronous validation for Call in Agent

2015-10-02 Thread Isabel Jimenez
src/slave/http.cpp f9cf7bb src/slave/validation.hpp PRE-CREATION src/slave/validation.cpp PRE-CREATION Diff: https://reviews.apache.org/r/38577/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 38844: Added unit tests for Call validation in Agent

2015-10-02 Thread Isabel Jimenez
--- make check Thanks, Isabel Jimenez

Re: Review Request 38967: Added functionality to generate Java V1 Protobufs and insert them into the existing JAR for now

2015-10-02 Thread Isabel Jimenez
967/#comment158761> Could you also add a fix for v1 python proto generation? - Isabel Jimenez On Oct. 2, 2015, 10:27 p.m., Anand Mazumdar wrote: > > --- > This is an automatically generated e-mail. To reply,

Review Request 38844: Added unit tests for Call validation in Agent

2015-09-29 Thread Isabel Jimenez
Description --- Unit tests for Call validation in Agent. Diffs - src/tests/executor_http_api_tests.cpp c2c05f4 Diff: https://reviews.apache.org/r/38844/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 38577: Added synchronous validation for Call in Agent

2015-09-29 Thread Isabel Jimenez
src/slave/validation.hpp PRE-CREATION src/slave/validation.cpp PRE-CREATION Diff: https://reviews.apache.org/r/38577/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 38844: Added unit tests for Call validation in Agent

2015-09-29 Thread Isabel Jimenez
--- make check Thanks, Isabel Jimenez

Re: Review Request 38577: Added synchronous validation for Call in Agent

2015-09-29 Thread Isabel Jimenez
e/slave.cpp#L2838 This introduces a change of behavior, I'll reflect this on the design Doc too. - Isabel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38577/#review101003 ---------

Review Request 38867: Added drop message method in Agent

2015-09-29 Thread Isabel Jimenez
. Repository: mesos Description --- We need a drop message method in Agent, similar to the one existing in Master. Diffs - src/slave/slave.hpp 18be4f8 src/slave/slave.cpp d1c9977 Diff: https://reviews.apache.org/r/38867/diff/ Testing --- make Thanks, Isabel Jimenez

Re: Review Request 38577: Added synchronous validation for Call in Agent

2015-09-29 Thread Isabel Jimenez
8aa4566 src/slave/http.cpp f9cf7bb src/slave/validation.hpp PRE-CREATION src/slave/validation.cpp PRE-CREATION Diff: https://reviews.apache.org/r/38577/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 38844: Added unit tests for Call validation in Agent

2015-09-29 Thread Isabel Jimenez
/executor_http_api_tests.cpp c2c05f4 Diff: https://reviews.apache.org/r/38844/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 38844: Added unit tests for Call validation in Agent

2015-09-29 Thread Isabel Jimenez
://reviews.apache.org/r/38844/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 38577: Added synchronous validation for Call in Agent

2015-09-29 Thread Isabel Jimenez
) - src/CMakeLists.txt 891f951 src/Makefile.am 8aa4566 src/slave/http.cpp f9cf7bb src/slave/validation.hpp PRE-CREATION src/slave/validation.cpp PRE-CREATION Diff: https://reviews.apache.org/r/38577/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 38844: Added unit tests for Call validation in Agent

2015-09-29 Thread Isabel Jimenez
/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 38844: Added unit tests for Call validation in Agent

2015-09-29 Thread Isabel Jimenez
anks - Isabel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38844/#review101001 --- On Sept. 29, 2015, 8:25 p.m., Isabe

Re: Review Request 38577: Added synchronous validation for Call in Agent

2015-09-29 Thread Isabel Jimenez
> On Sept. 25, 2015, 6:52 p.m., Vinod Kone wrote: > > src/Makefile.am, line 501 > > <https://reviews.apache.org/r/38577/diff/2/?file=1080351#file1080351line501> > > > > I think you'll make Alex happy if you also update the corresponding > > CMake file(

Re: Review Request 38577: Added synchronous validation for Call in Agent

2015-09-25 Thread Isabel Jimenez
arate dependant patch. - Isabel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38577/#review100653 --- On Sept. 22, 2015

Re: Review Request 38618: Changed executor HTTP API tests

2015-09-25 Thread Isabel Jimenez
/executor_http_api_tests.cpp c2c05f4 Diff: https://reviews.apache.org/r/38618/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 38779: Use new HTTP status code check in scheduler.

2015-09-25 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38779/#review100708 --- Ship it! Ship It! - Isabel Jimenez On Sept. 25, 2015, 10:40

Re: Review Request 38577: Added synchronous validation for Call in Agent

2015-09-25 Thread Isabel Jimenez
> > Added validation for Call protobuf message in Agent /api/v1/executor endpoint. > > > Diffs > - > > src/Makefile.am e224060 > src/slave/http.cpp 12a4d39 > src/slave/validation.hpp PRE-CREATION > src/slave/validation.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/38577/diff/ > > > Testing > --- > > make check > > > Thanks, > > Isabel Jimenez > >

Review Request 38650: Enabled '--no-cache' for docker images build on ASF CI

2015-09-22 Thread Isabel Jimenez
this patch on the ASF CI Thanks, Isabel Jimenez

Re: Review Request 38577: Added synchronous validation for Call in Agent

2015-09-22 Thread Isabel Jimenez
/slave/validation.hpp PRE-CREATION src/slave/validation.cpp PRE-CREATION Diff: https://reviews.apache.org/r/38577/diff/ Testing --- make check Thanks, Isabel Jimenez

Review Request 38618: Changed executor HTTP API tests

2015-09-22 Thread Isabel Jimenez
://reviews.apache.org/r/38618/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 38577: Added synchronous validation for Call in Agent

2015-09-22 Thread Isabel Jimenez
e224060 src/slave/http.cpp 12a4d39 src/slave/validation.hpp PRE-CREATION src/slave/validation.cpp PRE-CREATION Diff: https://reviews.apache.org/r/38577/diff/ Testing --- make check Thanks, Isabel Jimenez

Review Request 38619: Added missing header guards for master/validation.hpp

2015-09-22 Thread Isabel Jimenez
Description --- Header guards were missing in master/validation.hpp Diffs - src/master/validation.hpp 3434868 Diff: https://reviews.apache.org/r/38619/diff/ Testing --- Thanks, Isabel Jimenez

Re: Review Request 38577: Added synchronous validation for Call in Agent

2015-09-22 Thread Isabel Jimenez
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38577/#review99886 --- On Sept. 22, 2015, 9:46 a.m., Isabel Jimenez wrote: > >

Review Request 38577: Added synchronous validation for Call in Agent

2015-09-21 Thread Isabel Jimenez
src/slave/validation.cpp PRE-CREATION Diff: https://reviews.apache.org/r/38577/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 38497: Introduced Executor HTTP endpoint on Agent

2015-09-21 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38497/#review99779 --- Ship it! Ship It! - Isabel Jimenez On Sept. 18, 2015, 5:18 p.m

Re: Review Request 38499: Tests for executor endpoint on agent

2015-09-21 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38499/#review99789 --- Ship it! Ship It! - Isabel Jimenez On Sept. 18, 2015, 5:19 p.m

Re: Review Request 38496: Added devolve operation for V1 Executor Protobuf

2015-09-18 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38496/#review99614 --- Ship it! Ship It! - Isabel Jimenez On Sept. 18, 2015, 5:18 p.m

Re: Review Request 38416: Allow HTTP response codes to be checked with code.

2015-09-16 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38416/#review99193 --- Ship it! Ship It! - Isabel Jimenez On Sept. 16, 2015, 1:03 a.m

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

2015-09-15 Thread Isabel Jimenez
os. I'm sending a separate patch. - Isabel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38143/#review99117 --- On Sep

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

2015-09-15 Thread Isabel Jimenez
- Isabel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38143/#review99117 --- On Sept. 15, 2015, 10:46 p.m., Isabel Jimenez wrote

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

2015-09-15 Thread Isabel Jimenez
-CREATION src/Makefile.am 509256f Diff: https://reviews.apache.org/r/38143/diff/ Testing --- make && make check Thanks, Isabel Jimenez

Re: Review Request 38278: Updating unversioned Executor protobuf

2015-09-15 Thread Isabel Jimenez
Thanks, Isabel Jimenez

Re: Review Request 38278: Updating unversioned Executor protobuf

2015-09-15 Thread Isabel Jimenez
Thanks, Isabel Jimenez

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

2015-09-15 Thread Isabel Jimenez
--- make && make check Thanks, Isabel Jimenez

Re: Review Request 38321: Adding upgrade specifications to docs for '.json' endpoints

2015-09-12 Thread Isabel Jimenez
. Repository: mesos Description --- Adding a Note for the deprecation of endpoints with '.json' extension. Diffs (updated) - docs/upgrades.md c4b2880 Diff: https://reviews.apache.org/r/38321/diff/ Testing --- Thanks, Isabel Jimenez

Re: Review Request 36126: Removing '.json' extension in slave endpoints url

2015-09-11 Thread Isabel Jimenez
src/tests/monitor_tests.cpp 53fb53e src/tests/slave_tests.cpp 5c1a3d3 src/webui/master/static/js/controllers.js fbf8696 src/webui/master/static/js/services.js 2cd9d7d Diff: https://reviews.apache.org/r/36126/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 36127: Removing '.json' extension in files endpoints url

2015-09-11 Thread Isabel Jimenez
/master/static/js/controllers.js fbf8696 Diff: https://reviews.apache.org/r/36127/diff/ Testing --- make check Thanks, Isabel Jimenez

Review Request 38321: Adding upgrade specifications to docs for '.json' endpoints

2015-09-11 Thread Isabel Jimenez
--- Adding a Note for the deprecation of endpoints with '.json' extension. Diffs - docs/upgrades.md c4b2880 Diff: https://reviews.apache.org/r/38321/diff/ Testing --- Thanks, Isabel Jimenez

Re: Review Request 36125: Removing '.json' extension in master endpoints url

2015-09-10 Thread Isabel Jimenez
/webui/master/static/js/controllers.js 3445028 Diff: https://reviews.apache.org/r/36125/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 36125: Removing '.json' extension in master endpoints url

2015-09-10 Thread Isabel Jimenez
/webui/master/static/js/controllers.js 3445028 Diff: https://reviews.apache.org/r/36125/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 36126: Removing '.json' extension in slave endpoints url

2015-09-10 Thread Isabel Jimenez
check Thanks, Isabel Jimenez

Re: Review Request 36125: Removing '.json' extension in master endpoints url

2015-09-10 Thread Isabel Jimenez
s.apache.org/r/36125/#review98275 --- On Sept. 10, 2015, 5:33 p.m., Isabel Jimenez wrote: > > --- > This is an automatically generated e-mail. To reply, v

Re: Review Request 36127: Removing '.json' extension in files endpoints url

2015-09-10 Thread Isabel Jimenez
/controllers.js 3445028 Diff: https://reviews.apache.org/r/36127/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 36127: Removing '.json' extension in files endpoints url

2015-09-10 Thread Isabel Jimenez
3445028 Diff: https://reviews.apache.org/r/36127/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 36126: Removing '.json' extension in slave endpoints url

2015-09-10 Thread Isabel Jimenez
dpoints :) - Isabel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36126/#review98295 --- On Sept. 10, 2015, 5:43 p.m.,

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

2015-09-10 Thread Isabel Jimenez
--- make && make check Thanks, Isabel Jimenez

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

2015-09-10 Thread Isabel Jimenez
--- make && make check Thanks, Isabel Jimenez

Re: Review Request 36127: Removing '.json' extension in files endpoints url

2015-09-10 Thread Isabel Jimenez
/master/static/js/controllers.js fbf8696 Diff: https://reviews.apache.org/r/36127/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

2015-09-10 Thread Isabel Jimenez
mp; make check Thanks, Isabel Jimenez

Review Request 38278: Updating unversioned Executor protobuf

2015-09-10 Thread Isabel Jimenez
: mesos Description --- Adding last changes of the executor HTTP API design to the unversioned protobuf Diffs - include/mesos/executor/executor.proto 52c84b3 Diff: https://reviews.apache.org/r/38278/diff/ Testing --- make Thanks, Isabel Jimenez

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

2015-09-10 Thread Isabel Jimenez
reviews.apache.org/r/38143/#review98326 --- On Sept. 10, 2015, 10:32 p.m., Isabel Jimenez wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 36126: Removing '.json' extension in slave endpoints url

2015-09-10 Thread Isabel Jimenez
/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 36125: Removing '.json' extension in master endpoints url

2015-09-10 Thread Isabel Jimenez
/master_tests.cpp 8a6b98b src/webui/master/static/js/controllers.js fbf8696 Diff: https://reviews.apache.org/r/36125/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 36125: Removing '.json' extension in master endpoints url

2015-09-10 Thread Isabel Jimenez
/master/static/js/controllers.js fbf8696 Diff: https://reviews.apache.org/r/36125/diff/ Testing --- make check Thanks, Isabel Jimenez

Re: Review Request 38191: Removing unused Executor protobuf

2015-09-09 Thread Isabel Jimenez
- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38191/#review98222 ----------- On Sept. 8, 2015, 10:30 p.m., Isabel Jimenez wrote: > > -

  1   2   3   >