Re: Review Request 69776: Fixed flakiness by adding per agent config dir for mesos test.

2019-01-16 Thread Jie Yu
> On Jan. 16, 2019, 10:10 p.m., Jie Yu wrote: > > src/tests/mesos.cpp > > Line 173 (original), 173 (patched) > > <https://reviews.apache.org/r/69776/diff/1/?file=2120114#file2120114line173> > > > > s/agentDir/configDir/ > > Gilbert Song wro

Re: Review Request 69776: Fixed flakiness by adding per agent config dir for mesos test.

2019-01-16 Thread Jie Yu
), 173 (patched) <https://reviews.apache.org/r/69776/#comment297689> s/agentDir/configDir/ - Jie Yu On Jan. 16, 2019, 10:08 p.m., Gilbert Song wrote: > > --- > This is an automatically generated e-mail. To reply,

Review Request 69727: Compared the device number of namespace handle instead of /proc.

2019-01-11 Thread Jie Yu
ber directly against the namespace handle, instead of `/proc`. Diffs - src/slave/containerizer/mesos/isolators/network/cni/cni.cpp a1130a58553fb67bd8c212498b98978f116d7b0c Diff: https://reviews.apache.org/r/69727/diff/1/ Testing --- sudo make check Thanks, Jie Yu

Re: Review Request 69728: Invoked base test `SetUp` and `TearDown` methods in derived tests.

2019-01-11 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69728/#review211917 --- Ship it! Ship It! - Jie Yu On Jan. 11, 2019, 11:17 p.m

Re: Review Request 69712: Added a CNI reboot test.

2019-01-11 Thread Jie Yu
to true. Diffs (updated) - src/tests/containerizer/cni_isolator_tests.cpp eb20e637ecbe1b39e2dbb274c5198828f2fdf62f Diff: https://reviews.apache.org/r/69712/diff/3/ Changes: https://reviews.apache.org/r/69712/diff/2-3/ Testing --- sudo make check Thanks, Jie Yu

Re: Review Request 69712: Added a CNI reboot test.

2019-01-11 Thread Jie Yu
to true. Diffs (updated) - src/tests/containerizer/cni_isolator_tests.cpp eb20e637ecbe1b39e2dbb274c5198828f2fdf62f Diff: https://reviews.apache.org/r/69712/diff/2/ Changes: https://reviews.apache.org/r/69712/diff/1-2/ Testing --- sudo make check Thanks, Jie Yu

Re: Review Request 69715: Fixed the CNI_NETNS handling in port mapper CNI plugin.

2019-01-11 Thread Jie Yu
/isolators/network/cni/plugins/port_mapper/port_mapper.cpp 4e784ffb4ac29861c888fdbed4fcf9902bf4182a Diff: https://reviews.apache.org/r/69715/diff/2/ Changes: https://reviews.apache.org/r/69715/diff/1-2/ Testing --- sudo make check Thanks, Jie Yu

Re: Review Request 69710: Switched to use ContainerizerTest for CNI tests.

2019-01-11 Thread Jie Yu
eb20e637ecbe1b39e2dbb274c5198828f2fdf62f Diff: https://reviews.apache.org/r/69710/diff/2/ Changes: https://reviews.apache.org/r/69710/diff/1-2/ Testing --- sudo make check Thanks, Jie Yu

Re: Review Request 69711: Separated runtime dirs from other dirs in MesosTest.

2019-01-11 Thread Jie Yu
--- sudo make check Thanks, Jie Yu

Re: Review Request 69715: Fixed the CNI_NETNS handling in port mapper CNI plugin.

2019-01-11 Thread Jie Yu
ps://reviews.apache.org/r/69715/#review211875 ----------- On Jan. 11, 2019, 6:14 a.m., Jie Yu wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 69712: Added a CNI reboot test.

2019-01-11 Thread Jie Yu
ated e-mail. To reply, visit: https://reviews.apache.org/r/69712/#review211871 ------- On Jan. 11, 2019, 5:13 a.m., Jie Yu wrote: > > --- > This is a

Re: Review Request 69710: Switched to use ContainerizerTest for CNI tests.

2019-01-11 Thread Jie Yu
izerTest::SetUp()` instead? Good catch! - Jie --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69710/#review211869 ------- On

Review Request 69715: Fixed the CNI_NETNS handling in port mapper CNI plugin.

2019-01-10 Thread Jie Yu
/port_mapper.cpp 4e784ffb4ac29861c888fdbed4fcf9902bf4182a Diff: https://reviews.apache.org/r/69715/diff/1/ Testing --- sudo make check Thanks, Jie Yu

Review Request 69714: Fixed a bug in docker_containerizer_tests.cpp.

2019-01-10 Thread Jie Yu
--- sudo make check Thanks, Jie Yu

Review Request 69713: Fixed a bug in health_check_tests.cpp.

2019-01-10 Thread Jie Yu
--- We forgot to call MesosTest::SetUp() and MesosTest::TearDown() in the override methods. Diffs - src/tests/health_check_tests.cpp 3e9b2da5aa1602a5dd24007d9b14cab74e7d02ae Diff: https://reviews.apache.org/r/69713/diff/1/ Testing --- sudo make check Thanks, Jie Yu

Re: Review Request 69710: Switched to use ContainerizerTest for CNI tests.

2019-01-10 Thread Jie Yu
eb20e637ecbe1b39e2dbb274c5198828f2fdf62f Diff: https://reviews.apache.org/r/69710/diff/1/ Testing --- sudo make check Thanks, Jie Yu

Re: Review Request 69711: Separated runtime dirs from other dirs in MesosTest.

2019-01-10 Thread Jie Yu
affecting other files for the test. This patch makes the runtime directory a separate directory. Diffs - src/tests/mesos.cpp 3a1101cf41995733fe7b6492781def6ac09c6130 Diff: https://reviews.apache.org/r/69711/diff/1/ Testing --- sudo make check Thanks, Jie Yu

Review Request 69710: Switched to use ContainerizerTest for CNI tests.

2019-01-10 Thread Jie Yu
Thanks, Jie Yu

Review Request 69711: Separated runtime dirs from other dirs in MesosTest.

2019-01-10 Thread Jie Yu
- src/tests/mesos.cpp 3a1101cf41995733fe7b6492781def6ac09c6130 Diff: https://reviews.apache.org/r/69711/diff/1/ Testing --- sudo make check Thanks, Jie Yu

Review Request 69712: Added a CNI reboot test.

2019-01-10 Thread Jie Yu
/containerizer/cni_isolator_tests.cpp eb20e637ecbe1b39e2dbb274c5198828f2fdf62f Diff: https://reviews.apache.org/r/69712/diff/1/ Testing --- sudo make check Thanks, Jie Yu

Re: Review Request 69706: Kept `CNI_NETNS` unset in detach if network namespace is gone.

2019-01-10 Thread Jie Yu
ache.org/r/69706/diff/2/ Changes: https://reviews.apache.org/r/69706/diff/1-2/ Testing --- sudo make check Thanks, Jie Yu

Review Request 69706: Kept `CNI_NETNS` unset in detach if network namespace is gone.

2019-01-10 Thread Jie Yu
ni/cni.cpp cc23428d27d40be8c4ff1476e6e984c7d12760c4 Diff: https://reviews.apache.org/r/69706/diff/1/ Testing --- sudo make check Thanks, Jie Yu

Re: Review Request 69690: Changed the gRPC make variables for protoc detection.

2019-01-07 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69690/#review211738 --- Ship it! Ship It! - Jie Yu On Jan. 7, 2019, 8:19 p.m., Chun

Re: Review Request 69671: Always build gRPC with its embedded c-ares.

2019-01-04 Thread Jie Yu
) <https://reviews.apache.org/r/69671/#comment297209> Can you add some comments about this one? Or just separate this change in a different patch? - Jie Yu On Jan. 5, 2019, 1:24 a.m., Chun-Hung Hsiao

Re: Review Request 69665: Added missing 3rdparty patches to the distribution.

2019-01-03 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69665/#review211663 --- Ship it! Ship It! - Jie Yu On Jan. 4, 2019, 12:57 a.m

Re: Review Request 69590: Moves CNI root directory to a persistent location.

2018-12-18 Thread Jie Yu
/reviews.apache.org/r/69590/#comment296514> instead of use `paths::ROOT_DIR`, you should use `flags.runtime_dir` - Jie Yu On Dec. 19, 2018, 4:52 a.m., Deepak Goel wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 69540: Added `ROOT_PseudoDevicesWithRootFilesystem` test.

2018-12-10 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69540/#review211151 --- Ship it! Ship It! - Jie Yu On Dec. 10, 2018, 4:41 p.m

Review Request 69538: Added UCR bridge network for Mesos Mini.

2018-12-09 Thread Jie Yu
t;: 128, "requirePorts": false, "networks": [ { "mode": "container/bridge" } ], "healthChecks": [], "fetch": [], "constraints": [], "cmd": "sleep 10" } ``` Thanks, Jie Yu

Re: Review Request 69532: Made sure containers runtime dir has device file access.

2018-12-09 Thread Jie Yu
``` ```json { "id": "/test", "cmd": "dd if=/dev/zero of=file bs=1024 count=1 oflag=dsync", "cpus": 1, "mem": 128, "disk": 128, "instances": 1, "container": { "type": "MESOS", "docker": { "image": "ubuntu:18.04" } } } ``` Thanks, Jie Yu

Review Request 69537: Used strings::format in os::shell.

2018-12-09 Thread Jie Yu
3rdparty/stout/include/stout/os/windows/shell.hpp b9e06d667159d2fb5e266ce7f7e633deb1237a78 Diff: https://reviews.apache.org/r/69537/diff/1/ Testing --- make check Thanks, Jie Yu

Re: Review Request 69532: Made sure containers runtime dir has device file access.

2018-12-09 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69532/#review211130 --- On Dec. 8, 2018, 4:45 a.m., Jie Yu wrote: > >

Re: Review Request 69532: Made sure containers runtime dir has device file access.

2018-12-07 Thread Jie Yu
of=file bs=1024 count=1 oflag=dsync", "cpus": 1, "mem": 128, "disk": 128, "instances": 1, "container": { "type": "MESOS", "docker": { "image": "ubuntu:18.04" } } } ``` Thanks, Jie Yu

Re: Review Request 69532: Made sure containers runtime dir has device file access.

2018-12-07 Thread Jie Yu
/69532/diff/1-2/ Testing --- sudo make check Thanks, Jie Yu

Review Request 69532: Made sure containers runtime dir has device file access.

2018-12-07 Thread Jie Yu
/isolators/volume/host_path.cpp 2e4cd2b9b852b0c95a2957f4bed33fe54f093e3d src/slave/containerizer/mesos/launch.cpp 6aa4397aa0fc9e1c93a0f3a13fbe0a55c5a02f0c Diff: https://reviews.apache.org/r/69532/diff/1/ Testing --- sudo make check Thanks, Jie Yu

Re: Review Request 69528: Fixed a regression in binding GPU container devices.

2018-12-07 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69528/#review211120 --- Ship it! Ship It! - Jie Yu On Dec. 7, 2018, 7:41 p.m

Re: Review Request 69210: Removed unnecesssarily verbose container mount logging.

2018-12-04 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69210/#review211022 --- Ship it! Ship It! - Jie Yu On Nov. 17, 2018, 12:49 a.m

Re: Review Request 69211: Improved the code comments for `getContainerDevicesPath`.

2018-12-03 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69211/#review211015 --- Ship it! Ship It! - Jie Yu On Dec. 4, 2018, 1:19 a.m

Re: Review Request 69450: Applied the `ContainerMountInfo` protobuf helper.

2018-12-03 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69450/#review211014 --- Ship it! Ship It! - Jie Yu On Nov. 27, 2018, 12:49 a.m

Re: Review Request 69210: Used the MS_SILENT mount flag to elide unwanted logging.

2018-12-03 Thread Jie Yu
Line 189 (original), 189 (patched) <https://reviews.apache.org/r/69210/#comment295866> This is a bit weird to me. I'd prefer just add a new optional field in ContainerMountInfo - Jie Yu On Nov. 17, 2018, 12:49 a.m., James Peach

Re: Review Request 69086: Moved the container root construction to the isolators.

2018-12-03 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69086/#review211012 --- Ship it! Ship It! - Jie Yu On Nov. 27, 2018, 12:49 a.m

Re: Review Request 69377: Added blog post for Mesos Mini.

2018-11-19 Thread Jie Yu
://reviews.apache.org/r/69377/diff/4/ Changes: https://reviews.apache.org/r/69377/diff/3-4/ Testing --- Markdown rendering can be viewed here: https://github.com/jieyu/mesos/blob/mesos_mini_blog/site/source/blog/2018-11-19-mesos-mini.md Thanks, Jie Yu

Re: Review Request 69377: Added blog post for Mesos Mini.

2018-11-19 Thread Jie Yu
https://reviews.apache.org/r/69377/#review210643 --- On Nov. 19, 2018, 5:47 a.m., Jie Yu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > ht

Re: Review Request 69377: Added blog post for Mesos Mini.

2018-11-18 Thread Jie Yu
/ Changes: https://reviews.apache.org/r/69377/diff/2-3/ Testing --- Markdown rendering can be viewed here: https://github.com/jieyu/mesos/blob/mesos_mini_blog/site/source/blog/2018-11-19-mesos-mini.md Thanks, Jie Yu

Re: Review Request 65811: Added Stout `path::normalize` function for POSIX paths.

2018-11-18 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65811/#review210638 --- Ship it! Ship It! - Jie Yu On Nov. 7, 2018, 10:10 p.m

Re: Review Request 68832: Add unit tests for Stout `path::normalize` function in POSIX.

2018-11-18 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68832/#review210639 --- Ship it! Ship It! - Jie Yu On Nov. 7, 2018, 10:29 p.m

Re: Review Request 69377: Added blog post for Mesos Mini.

2018-11-17 Thread Jie Yu
://reviews.apache.org/r/69377/diff/1-2/ Testing --- Markdown rendering can be viewed here: https://github.com/jieyu/mesos/blob/mesos_mini_blog/site/source/blog/2018-11-19-mesos-mini.md Thanks, Jie Yu

Review Request 69377: Added blog post for Mesos Mini.

2018-11-17 Thread Jie Yu
/mesos/blob/mesos_mini_blog/site/source/blog/2018-11-19-mesos-mini.md Thanks, Jie Yu

Re: Review Request 69086: Moved container root construction to the isolators.

2018-11-04 Thread Jie Yu
CSI integration) src/slave/containerizer/mesos/launch.cpp Line 466 (original), 471 (patched) <https://reviews.apache.org/r/69086/#comment294978> Do we still need this function? Looks like this is just a verification now. Can you simply move the logic to the main `execute()` method?

Re: Review Request 69214: Mounted devpts with `gid=5` by default.

2018-10-30 Thread Jie Yu
decision? - Jie Yu On Oct. 30, 2018, 4:46 p.m., James Peach wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 69086: Move the container `/dev` construction to the isolators.

2018-10-28 Thread Jie Yu
re. src/slave/containerizer/mesos/isolators/filesystem/linux.cpp Lines 436 (patched) <https://reviews.apache.org/r/69086/#comment294764> Ditto. src/slave/containerizer/mesos/launch.cpp Lines 510 (patched) <https://reviews.apache.org/r/69086/#comment294765> Is this intent

Re: Review Request 69103: Fixed bug in 'execute.cpp' with tty-based tasks and no 'containerInfo'.

2018-10-23 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69103/#review209946 --- Ship it! Ship It! - Jie Yu On Oct. 20, 2018, 9:52 a.m

Re: Review Request 69009: Stout: Added a sync option for `write` and `rename`.

2018-10-15 Thread Jie Yu
ally generated e-mail. To reply, visit: https://reviews.apache.org/r/69009/#review209538 --- On Oct. 12, 2018, 11:53 p.m., Chun-Hung Hsiao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org

Re: Review Request 68987: Fixed protobuf map equality check in the URI disk profile adaptor.

2018-10-10 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68987/#review209433 --- Ship it! Ship It! - Jie Yu On Oct. 11, 2018, 5:18 a.m

Re: Review Request 68923: Updated Docker library to avoid 'os::killtree()' when discarding.

2018-10-04 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68923/#review209247 --- Ship it! Ship It! - Jie Yu On Oct. 4, 2018, 10:14 p.m

Re: Review Request 68924: Updated the Docker library to avoid 'os::killtree()'.

2018-10-04 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68924/#review209233 --- Ship it! Ship It! - Jie Yu On Oct. 4, 2018, 5:26 a.m., Greg

Re: Review Request 68923: Updated 'Docker::inspect()' to avoid 'os::killtree()'.

2018-10-04 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68923/#review209231 --- Ship it! Ship It! - Jie Yu On Oct. 4, 2018, 5:22 a.m., Greg

Re: Review Request 68810: Removed call to 'setsid()' in command executor if TTY attached.

2018-10-01 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68810/#review209133 --- Ship it! Ship It! - Jie Yu On Sept. 29, 2018, 12:05 p.m

Re: Review Request 68880: Cached the cgroup results in Docker containerizer.

2018-09-28 Thread Jie Yu
mount table is big (e.g., MESOS-8418). This patch uses the static local variable to cache the result. Diffs - src/slave/containerizer/docker.cpp 277a1550e199097ebc3c47d0a6c0d258bac90da5 Diff: https://reviews.apache.org/r/68880/diff/1/ Testing --- sudo make check Thanks, Jie Yu

Review Request 68880: Cached the cgroup results in Docker containerizer.

2018-09-28 Thread Jie Yu
- src/slave/containerizer/docker.cpp 277a1550e199097ebc3c47d0a6c0d258bac90da5 Diff: https://reviews.apache.org/r/68880/diff/1/ Testing --- sudo make check Thanks, Jie Yu

Review Request 68862: Removed unneeded pluginDir field from CNI isolator.

2018-09-26 Thread Jie Yu
ed470465726227a61216b467ad1a7f030806008f Diff: https://reviews.apache.org/r/68862/diff/1/ Testing --- sudo make check Thanks, Jie Yu

Review Request 68861: Skipped CNI config load if named network is not enabled.

2018-09-26 Thread Jie Yu
the network configs. This patch fixed a potential CHECK failure. Diffs - src/slave/containerizer/mesos/isolators/network/cni/cni.cpp ed470465726227a61216b467ad1a7f030806008f Diff: https://reviews.apache.org/r/68861/diff/1/ Testing --- sudo make check Thanks, Jie Yu

Re: Review Request 68810: Removed call to 'setsid()' in command executor if TTY attached.

2018-09-26 Thread Jie Yu
and executor. I.e., ``` if (containerConfig.has_task_info()) { launchInfo.mutable_command()->add_arguments( "--tty_slave_path=" + slavePath.get()); } ``` - Jie Yu On Sept. 22, 2018, 12:3

Re: Review Request 68724: Added the ability to launch tasks with a TTY attached to mesos-execute.

2018-09-26 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68724/#review209030 --- Ship it! Ship It! - Jie Yu On Sept. 22, 2018, 12:35 a.m

Re: Review Request 68763: Cleaned up residual containers when removing resource provider configs.

2018-09-21 Thread Jie Yu
here. src/resource_provider/daemon.cpp Lines 686-688 (patched) <https://reviews.apache.org/r/68763/#comment293184> Can we LOG all errors in the `futures` list, not just the first one? You need to combine the error messages. - Jie Yu On Sept. 21, 2018, 7:47 p.m., Chu

Re: Review Request 68769: Fixed rtnl_act leak in routing::filter::internal::attach().

2018-09-19 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68769/#review208771 --- Ship it! Ship It! - Jie Yu On Sept. 19, 2018, 6:27 p.m

Review Request 68728: Added rapidjson to RPM spec file.

2018-09-16 Thread Jie Yu
/68728/diff/1/ Testing --- Thanks, Jie Yu

Re: Review Request 68614: Implicitly authorized `VIEW_STANDALONE_CONTAINER` for SLRPs.

2018-09-03 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68614/#review208288 --- Ship it! Ship It! - Jie Yu On Sept. 3, 2018, 10:22 p.m

Re: Review Request 68615: Added the `devolve` helper for agent v1 API responses.

2018-09-03 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68615/#review208283 --- Ship it! Ship It! - Jie Yu On Sept. 3, 2018, 10:25 p.m

Re: Review Request 68601: Cleaned up residual CSI endpoint sockets for terminated plugins.

2018-09-03 Thread Jie Yu
> On Sept. 2, 2018, 3:37 a.m., Jie Yu wrote: > > src/authorizer/local/authorizer.cpp > > Lines 1138 (patched) > > <https://reviews.apache.org/r/68601/diff/1/?file=2079385#file2079385line1138> > > > > you might also need VIEW_CONTAINERS because `GetCon

Re: Review Request 68601: Cleaned up residual CSI endpoint sockets for terminated plugins.

2018-09-01 Thread Jie Yu
d allow us to see the log history. - Jie Yu On Sept. 1, 2018, 5:31 p.m., Chun-Hung Hsiao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 68600: Added a unit test for plugin crash during an agent failover.

2018-09-01 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68600/#review208233 --- Ship it! Ship It! - Jie Yu On Sept. 1, 2018, 5:31 p.m

Re: Review Request 68599: Added an unit test for rootfs cleanup EBUSY fix.

2018-09-01 Thread Jie Yu
/provisioner_docker_tests.cpp Lines 1140-1142 (patched) <https://reviews.apache.org/r/68599/#comment291961> I'd swap the order of these two. - Jie Yu On Sept. 1, 2018, 6:15 p.m., Gilbert Song wrote: > > --- > This is an automatically g

Review Request 68598: Added a missing failure message in overlay backend.

2018-08-31 Thread Jie Yu
Description --- Added a missing failure message in overlay backend. Diffs - src/slave/containerizer/mesos/provisioner/backends/overlay.cpp e32b9918ac15122477e05ebe701c9425bbefa809 Diff: https://reviews.apache.org/r/68598/diff/1/ Testing --- Thanks, Jie Yu

Re: Review Request 68597: Made copy backend destroy more robust.

2018-08-31 Thread Jie Yu
/68597/diff/1-2/ Testing --- sudo make check Thanks, Jie Yu

Re: Review Request 68594: Made overlay backend destroy more robust.

2018-08-31 Thread Jie Yu
/slave/containerizer/mesos/provisioner/backends/overlay.cpp e32b9918ac15122477e05ebe701c9425bbefa809 Diff: https://reviews.apache.org/r/68594/diff/2/ Changes: https://reviews.apache.org/r/68594/diff/1-2/ Testing --- sudo make check Thanks, Jie Yu

Re: Review Request 68596: Made bind backend destroy more robust.

2018-08-31 Thread Jie Yu
Diff: https://reviews.apache.org/r/68596/diff/2/ Changes: https://reviews.apache.org/r/68596/diff/1-2/ Testing --- sudo make check Thanks, Jie Yu

Re: Review Request 68595: Made aufs backend destroy more robust.

2018-08-31 Thread Jie Yu
/slave/containerizer/mesos/provisioner/backends/aufs.cpp c2cdd9310e84c94e48f2e72de96ddced5b3d2e41 Diff: https://reviews.apache.org/r/68595/diff/2/ Changes: https://reviews.apache.org/r/68595/diff/1-2/ Testing --- sudo make check Thanks, Jie Yu

Review Request 68597: Made copy backend destroy more robust.

2018-08-31 Thread Jie Yu
recovery. Diffs - src/slave/containerizer/mesos/provisioner/backends/copy.cpp d3eb6b443d49e1cd6cfd7fa3be1776155e8a1bb0 Diff: https://reviews.apache.org/r/68597/diff/1/ Testing --- sudo make check Thanks, Jie Yu

Review Request 68596: Made bind backend destroy more robust.

2018-08-31 Thread Jie Yu
, Jie Yu

Review Request 68594: Made overlay backend destroy more robust.

2018-08-31 Thread Jie Yu
e32b9918ac15122477e05ebe701c9425bbefa809 Diff: https://reviews.apache.org/r/68594/diff/1/ Testing --- sudo make check Thanks, Jie Yu

Review Request 68595: Made aufs backend destroy more robust.

2018-08-31 Thread Jie Yu
c2cdd9310e84c94e48f2e72de96ddced5b3d2e41 Diff: https://reviews.apache.org/r/68595/diff/1/ Testing --- sudo make check Thanks, Jie Yu

Re: Review Request 68562: Windows: Add comment about V2S2 Docker image Manifest.

2018-08-29 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68562/#review208113 --- Ship it! Ship It! - Jie Yu On Aug. 29, 2018, 8:50 p.m

Re: Review Request 67984: Windows: Added CMake logic to download and "install" `wclayer.exe`.

2018-08-29 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67984/#review208108 --- Ship it! Ship It! - Jie Yu On Aug. 6, 2018, 6:46 p.m

Re: Review Request 68454: Windows: Fetch blobs with V2S2 Docker image manifest.

2018-08-29 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68454/#review208107 --- Ship it! Ship It! - Jie Yu On Aug. 28, 2018, 11:26 p.m

Re: Review Request 67930: Windows: Enabled `DockerFetcherPluginTest` suite.

2018-08-29 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67930/#review208106 --- Ship it! Ship It! - Jie Yu On Aug. 25, 2018, 9:57 p.m

Re: Review Request 68550: Fixed flakiness in the `CreateDestroyDiskRecovery` SLRP test.

2018-08-28 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68550/#review208072 --- Ship it! Ship It! - Jie Yu On Aug. 28, 2018, 9:46 p.m

Re: Review Request 68454: Windows: Fetch blobs with V2S2 Docker image manifest.

2018-08-28 Thread Jie Yu
35-937 (patched) <https://reviews.apache.org/r/68454/#comment291811> No need for this tmp variable. src/uri/fetchers/docker.cpp Lines 982-986 (patched) <https://reviews.apache.org/r/68454/#comment291812> Ditto. No need for this tmp variable. - Jie Yu On Aug. 25, 2018, 9:57

Re: Review Request 68355: Added a CNI test for networking statistics.

2018-08-28 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68355/#review208062 --- Ship it! Ship It! - Jie Yu On Aug. 17, 2018, 3:37 a.m

Re: Review Request 68527: Added cpus/mem to the resource provider config in SLRP tests.

2018-08-27 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68527/#review207993 --- Ship it! Ship It! - Jie Yu On Aug. 27, 2018, 8:54 p.m

Re: Review Request 68454: Windows: Fetch blobs with V2S2 Docker image manifest.

2018-08-24 Thread Jie Yu
> On Aug. 24, 2018, 5:45 a.m., Jie Yu wrote: > > src/uri/fetchers/docker.cpp > > Lines 235 (patched) > > <https://reviews.apache.org/r/68454/diff/2/?file=2076952#file2076952line235> > > > > Can you check with Andy. Let's be consisent on doing encod

Re: Review Request 68454: Windows: Fetch blobs with V2S2 Docker image manifest.

2018-08-24 Thread Jie Yu
> On Aug. 24, 2018, 5:45 a.m., Jie Yu wrote: > > src/uri/fetchers/docker.cpp > > Lines 235 (patched) > > <https://reviews.apache.org/r/68454/diff/2/?file=2076952#file2076952line235> > > > > Can you check with Andy. Let's be consisent on doing encod

Re: Review Request 67930: Windows: Enabled `DockerFetcherPluginTest` suite.

2018-08-23 Thread Jie Yu
ent291399> We can use a constant like `TEST_REPOSITORY` in the top of this file? lile `TEST_DIGEST`? - Jie Yu On Aug. 6, 2018, 6:46 p.m., Liangyu Zhao wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 68454: Windows: Fetch blobs with V2S2 Docker image manifest.

2018-08-23 Thread Jie Yu
iews.apache.org/r/68454/#comment291397> Please do j++ to be consistent with i++ above. src/uri/fetchers/docker.cpp Lines 1026 (patched) <https://reviews.apache.org/r/68454/#comment291391> Let's avoid nesting by dealing with failure first: ``` if (urls.empty()) { r

Re: Review Request 68455: Windows: Enable DockerFetcher in Windows agent.

2018-08-23 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68455/#review207805 --- Ship it! Ship It! - Jie Yu On Aug. 21, 2018, 9:30 p.m

Re: Review Request 68454: Windows: Fetch blobs with V2S2 Docker image manifest.

2018-08-23 Thread Jie Yu
if (code == http::Status::OK) { return Nothing(); } return _urlFetchBlob(blobUri, directory, authHeaders, urls); }); } ``` - Jie Yu On Aug. 21, 2018, 9:30 p.m., Liangyu Zhao wrote: > > --- > This is an

Re: Review Request 68453: Windows: Fetch version 2 scheme 2 Docker image manifest.

2018-08-22 Thread Jie Yu
ry, blobUri, authHeaders, code); #else return Failure( "Unexpected HTTP response '" + http::Status::string(code) + "' " "when trying to download the blob"); #endif

Re: Review Request 68453: Windows: Fetch version 2 scheme 2 Docker image manifest.

2018-08-22 Thread Jie Yu
free to ignore this src/uri/fetchers/docker.cpp Lines 897 (patched) <https://reviews.apache.org/r/68453/#comment291308> I'd use `.repair` instead - Jie Yu On Aug. 21, 2018, 9:29 p.m., Liangyu Zhao wrote: > > --- > This

Re: Review Request 68451: Windows: Parse version 2 schema 2 Docker image manifest.

2018-08-22 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68451/#review207800 --- Can you add unit test for the validate function? - Jie Yu

Re: Review Request 68451: Windows: Parse version 2 schema 2 Docker image manifest.

2018-08-22 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68451/#review207799 --- Ship it! Ship It! - Jie Yu On Aug. 21, 2018, 9:29 p.m

Re: Review Request 68450: Windows: Update curl version to 7.61.0.

2018-08-22 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68450/#review207798 --- Ship it! Ship It! - Jie Yu On Aug. 21, 2018, 9:28 p.m

  1   2   3   4   5   6   7   8   9   10   >