Re: Review Request 69377: Added blog post for Mesos Mini.

2018-11-19 Thread Joerg Schad
r/69377/#comment295370> when *the* Mesos Docker container finishes. - Joerg Schad On Nov. 19, 2018, 5:47 a.m., Jie Yu wrote: > > --- > This is an automatically generated e-mail. To reply

Re: Review Request 69377: Added blog post for Mesos Mini.

2018-11-19 Thread Joerg Schad
> On Nov. 19, 2018, 8:02 a.m., Joerg Schad wrote: > > Excited about this, just some nits! - Joerg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69377/#rev

Re: Review Request 68625: Added 'MesosCon 2018 CFP is now closed!' blog post.

2018-09-04 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68625/#review208334 --- Ship it! Ship It! - Joerg Schad On Sept. 4, 2018, 11:13 p.m

Re: Review Request 68111: Added 'MesosCon 2018 CFP is now open!' blog post.

2018-07-31 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68111/#review206690 --- Ship it! Ship It! - Joerg Schad On July 31, 2018, 4:34 p.m

Re: Review Request 67748: Added monitoring paragraph to high-availability.md.

2018-06-26 Thread Joerg Schad
h does it depend on the queried master). I unfortunately do not have the correct/best formulation here at hand, but I feel that this is a bit ambigious: @xujyan should know more here. - Joerg Schad On June 26, 2018, 7:12 p.m., Till Toenshoff

Re: Review Request 63400: Fix bad links.

2017-10-30 Thread Joerg Schad
the old pages? There might be external links being broken as well... - Joerg Schad On Oct. 29, 2017, 9:43 p.m., Tomasz Janiszewski wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 63400: Fix bad links.

2017-10-30 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63400/#review189576 --- Ship it! Ship It! - Joerg Schad On Oct. 29, 2017, 9:43 p.m

Re: Review Request 62042: Change `EXPECT` to `ASSERT` when relying on the assertion afterwards.

2017-09-01 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62042/#review184396 --- Ship it! - Joerg Schad On Sept. 1, 2017, 9:27 p.m., Gastón

Re: Review Request 56867: Added upgrade guide for 1.2.x.

2017-02-23 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56867/#review166627 --- Ship it! Ship It! - Joerg Schad On Feb. 24, 2017, 12:47 a.m

Re: Review Request 56742: Updated CHANGELOG for Mesos 1.2.0 release.

2017-02-23 Thread Joerg Schad
742/#comment238622> I know this is autogenerated (and minor), but it feels off that the above categories are plural ("All Experimental Features", ..) while this is singular ("Bug", ..). - Joerg Schad On Feb. 24, 2017

Re: Review Request 56742: Updated CHANGELOG for Mesos 1.2.0 release.

2017-02-23 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56742/#review166618 --- Ship it! Ship It! - Joerg Schad On Feb. 24, 2017, 12:04 a.m

Re: Review Request 52219: Renamed slave to agent in subprocess.cpp.

2016-09-23 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52219/#review150194 --- Ship it! Ship It! - Joerg Schad On Sept. 23, 2016, 3:46 p.m

Re: Review Request 45491: Refactored subprocess options [1/2].

2016-09-21 Thread Joerg Schad
> On April 5, 2016, 6:40 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/include/process/subprocess.hpp, line 219 > > <https://reviews.apache.org/r/45491/diff/2/?file=1320641#file1320641line219> > > > > Do we use this `operator() ()` style

Re: Review Request 45491: Refactored subprocess options [1/2].

2016-09-21 Thread Joerg Schad
is is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45491/#review127636 --- On Sept. 21, 2016, 3:25 p.m., Joerg Schad wrote: > > --

Re: Review Request 45491: Refactored subprocess options [1/2].

2016-09-21 Thread Joerg Schad
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45491/#review149420 --- On Sept. 21, 2016, 3:25 p.m., Joerg Schad wrote: > > --

Re: Review Request 45491: Refactored subprocess options [1/2].

2016-09-21 Thread Joerg Schad
/subprocess_tests.cpp 0ff3945d2c722ebc1529265427397c5dfba6854e Diff: https://reviews.apache.org/r/45491/diff/ Testing --- Tested entire chain see https://reviews.apache.org/r/45492. Thanks, Joerg Schad

Re: Review Request 45492: Used ChildHooks in Mesos [2/2].

2016-09-21 Thread Joerg Schad
/ Testing --- sudo Make check + internal ci Thanks, Joerg Schad

Re: Review Request 52015: Used {} instead of Hook::None() in libprocess [1/2].

2016-09-21 Thread Joerg Schad
make check + internal ci Thanks, Joerg Schad

Re: Review Request 52017: Renamed Hook to parent Hook in libprocess [1/2].

2016-09-21 Thread Joerg Schad
ps://reviews.apache.org/r/52017/#review149413 ------- On Sept. 21, 2016, 3:22 p.m., Joerg Schad wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 52017: Renamed Hook to parent Hook in libprocess [1/2].

2016-09-21 Thread Joerg Schad
23bc14a30d013e47c4b48782a90523cd0bbb8c14 3rdparty/libprocess/src/subprocess.cpp 8ca61f77083ac4b77aa1aec22806e1be43dbfa6c Diff: https://reviews.apache.org/r/52017/diff/ Testing --- tested entire chain (see 53018). Thanks, Joerg Schad

Review Request 52120: Converted watchdog option into a childhook in libprocess [1/2].

2016-09-21 Thread Joerg Schad
/libprocess/src/subprocess.cpp 8ca61f77083ac4b77aa1aec22806e1be43dbfa6c 3rdparty/libprocess/src/tests/subprocess_tests.cpp 0ff3945d2c722ebc1529265427397c5dfba6854e Diff: https://reviews.apache.org/r/52120/diff/ Testing --- tested entire chain. Thanks, Joerg Schad

Re: Review Request 52018: Renamed Hook to ParentHook in Mesos [2/2].

2016-09-21 Thread Joerg Schad
://reviews.apache.org/r/52018/diff/ Testing --- sudo make check + internal ci Thanks, Joerg Schad

Review Request 52121: Converted watchdog option into childhook in Mesos [2/2].

2016-09-21 Thread Joerg Schad
/disk.cpp 3f49b9f5cd4331e54b6f687c31e4304d694ffbc9 Diff: https://reviews.apache.org/r/52121/diff/ Testing --- sudo make check + internal ci Thanks, Joerg Schad

Re: Review Request 51804: Fixed typos in subprocess_base.hpp.

2016-09-19 Thread Joerg Schad
Rukletsov. Repository: mesos Description --- Fixed typos in subprocess_base.hpp. Diffs - 3rdparty/libprocess/include/process/subprocess_base.hpp acd23c99162f164c02a7781abeb95b3c220ead12 Diff: https://reviews.apache.org/r/51804/diff/ Testing --- Thanks, Joerg Schad

Review Request 52018: Renamed Hook to ParentHook in Mesos.

2016-09-18 Thread Joerg Schad
/linux_launcher.cpp 1c49f568b12f5ad688bb43625de3dcbfd618ca79 src/tests/containerizer/launcher.hpp f87b3ce92c6a5d996995833d79c976db6afe2700 Diff: https://reviews.apache.org/r/52018/diff/ Testing --- sudo make check + internal ci Thanks, Joerg Schad

Review Request 52017: Renamed Hook to parent Hook in libprocess [1/2].

2016-09-18 Thread Joerg Schad
/subprocess.cpp 8ca61f77083ac4b77aa1aec22806e1be43dbfa6c Diff: https://reviews.apache.org/r/52017/diff/ Testing --- tested entire chain (see 53018). Thanks, Joerg Schad

Re: Review Request 52015: Used {} instead of Hook::None() in libprocess [1/2].

2016-09-18 Thread Joerg Schad
: https://reviews.apache.org/r/52015/diff/ Testing --- sudo make check + internal ci Thanks, Joerg Schad

Review Request 52016: Replaces Hook::None() by {} in Mesos [2/2].

2016-09-18 Thread Joerg Schad
, Joerg Schad

Review Request 52015: Used {} instead of Hook::None() in libprocess.

2016-09-18 Thread Joerg Schad
--- Used {} instead of Hook::None() in libprocess. Diffs - 3rdparty/libprocess/include/process/subprocess_base.hpp acd23c99162f164c02a7781abeb95b3c220ead12 Diff: https://reviews.apache.org/r/52015/diff/ Testing --- sudo make check + internal ci Thanks, Joerg Schad

Re: Review Request 45492: Used ChildHooks in Mesos [2/2].

2016-09-18 Thread Joerg Schad
/ Testing --- sudo Make check + internal ci Thanks, Joerg Schad

Re: Review Request 45491: Refactored subprocess options [1/2].

2016-09-18 Thread Joerg Schad
you tried if ```const > > vector& child_hooks = {}``` works or not? > > Joerg Schad wrote: > This is currently consistent with Hook::None(). Do you have a strong > opinion? > > Jie Yu wrote: > Yeah, I'd like to cleanup Hook::None() as well. This caused

Re: Review Request 45491: Refactored subprocess options [1/2].

2016-09-18 Thread Joerg Schad
/subprocess_tests.cpp 0ff3945d2c722ebc1529265427397c5dfba6854e Diff: https://reviews.apache.org/r/45491/diff/ Testing --- Tested entire chain see https://reviews.apache.org/r/45492. Thanks, Joerg Schad

Re: Review Request 45491: Refactored subprocess options [1/2].

2016-09-17 Thread Joerg Schad
----- On Sept. 11, 2016, 8:17 p.m., Joerg Schad wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45491/ >

Re: Review Request 45491: Refactored subprocess options [1/2].

2016-09-17 Thread Joerg Schad
://reviews.apache.org/r/45491/#review149318 --- On Sept. 11, 2016, 8:17 p.m., Joerg Schad wrote: > > --- > This is an automatically generated e-mail. T

Review Request 51804: Fixed typos in subprocess_base.hpp.

2016-09-12 Thread Joerg Schad
Description --- Fixed typos in subprocess_base.hpp. Diffs - 3rdparty/libprocess/include/process/subprocess_base.hpp acd23c99162f164c02a7781abeb95b3c220ead12 Diff: https://reviews.apache.org/r/51804/diff/ Testing --- Thanks, Joerg Schad

Re: Review Request 45492: Used ChildHooks in Mesos [2/2].

2016-09-12 Thread Joerg Schad
/diff/ Testing --- sudo Make check + internal ci Thanks, Joerg Schad

Re: Review Request 45491: Refactored subprocess options [1/2].

2016-09-11 Thread Joerg Schad
0ff3945d2c722ebc1529265427397c5dfba6854e Diff: https://reviews.apache.org/r/45491/diff/ Testing --- Tested entire chain see https://reviews.apache.org/r/45492. Thanks, Joerg Schad

Re: Review Request 45492: Used ChildHooks in Mesos [2/2].

2016-09-11 Thread Joerg Schad
: https://reviews.apache.org/r/45492/diff/ Testing (updated) --- sudo Make check + internal ci Thanks, Joerg Schad

Re: Review Request 45491: Refactored subprocess options [1/2].

2016-09-11 Thread Joerg Schad
8ca61f77083ac4b77aa1aec22806e1be43dbfa6c 3rdparty/libprocess/src/tests/subprocess_tests.cpp 0ff3945d2c722ebc1529265427397c5dfba6854e Diff: https://reviews.apache.org/r/45491/diff/ Testing (updated) --- Tested entire chain see https://reviews.apache.org/r/45492. Thanks, Joerg Schad

Review Request 51786: Fixed Typo in subprocess.hpp.

2016-09-11 Thread Joerg Schad
Description --- Fixed Typo in subprocess.hpp. Diffs - 3rdparty/libprocess/include/process/posix/subprocess.hpp 57f71d15e6fbb032c8b6c5d0c73a93751022e7e7 Diff: https://reviews.apache.org/r/51786/diff/ Testing --- Thanks, Joerg Schad

Review Request 51571: Updated Mesos version in getting started guide.

2016-09-01 Thread Joerg Schad
--- Updated Mesos version in getting started guide. Diffs - docs/getting-started.md ebe52705b8c8757d4a507ce3ae75f56d535a39d1 Diff: https://reviews.apache.org/r/51571/diff/ Testing --- viewed in website docker container Thanks, Joerg Schad

Re: Review Request 51329: Fixed incorrect html in upgrades.md.

2016-08-23 Thread Joerg Schad
Toenshoff. Repository: mesos Description --- Fixed incorrect html in upgrades.md. Diffs - docs/upgrades.md d3e7cdd51b4c294ef49447595d9cb074c5a993fe Diff: https://reviews.apache.org/r/51329/diff/ Testing (updated) --- Viewed in website docker container. Thanks, Joerg Schad

Review Request 51329: Fixed incorrect html in upgrades.md.

2016-08-23 Thread Joerg Schad
--- Fixed incorrect html in upgrades.md. Diffs - docs/upgrades.md d3e7cdd51b4c294ef49447595d9cb074c5a993fe Diff: https://reviews.apache.org/r/51329/diff/ Testing --- Viewed in docker container. Thanks, Joerg Schad

Re: Review Request 51283: Fixed broken link in multiple disk documentation.

2016-08-22 Thread Joerg Schad
with website docker container. Thanks, Joerg Schad

Review Request 51283: Fixed broken link in multiple disk documentation.

2016-08-22 Thread Joerg Schad
: mesos Description --- Fixed broken link in multiple disk documentation. Diffs - docs/multiple-disk.md 20b99e0e57360ad43804201b27e593d7ed48ce2c Diff: https://reviews.apache.org/r/51283/diff/ Testing --- Build and checked with website docker container. Thanks, Joerg Schad

Review Request 51147: Corrected typo in docker_build example.

2016-08-16 Thread Joerg Schad
--- The example given in the error message was incorrect. Diffs - support/docker_build.sh 5c38c5c3e4570bb2c1a223a2197c8fc8f39e2c2d Diff: https://reviews.apache.org/r/51147/diff/ Testing --- Thanks, Joerg Schad

Re: Review Request 50771: Added coverity build to build_docker.sh.

2016-08-09 Thread Joerg Schad
mesos.apache.org? Done - Joerg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50771/#review145273 --- On Aug. 10, 20

Re: Review Request 50771: Added coverity build to build_docker.sh.

2016-08-09 Thread Joerg Schad
8ae1aadbc12b12e44984d34ccfbcb8a97bf05bcf Diff: https://reviews.apache.org/r/50771/diff/ Testing --- ran build with and without COVERITY_TOKEN. Thanks, Joerg Schad

Review Request 50771: Added coverity build to build_docker.sh.

2016-08-03 Thread Joerg Schad
: https://reviews.apache.org/r/50771/diff/ Testing --- ran build with and without COVERITY_TOKEN. Thanks, Joerg Schad

Review Request 50722: TestCommit.

2016-08-02 Thread Joerg Schad
NOT MERGE TestCommit. Diffs - test PRE-CREATION Diff: https://reviews.apache.org/r/50722/diff/ Testing --- Thanks, Joerg Schad

Re: Review Request 50601: Fixed Rakefile to generate links to external .md files.

2016-07-29 Thread Joerg Schad
://regex101.com/r/zP6sH6/3 Thanks, Joerg Schad

Review Request 50601: Fixed Rakefile to generate links to external .md files.

2016-07-29 Thread Joerg Schad
that this includes https links. Diffs - site/Rakefile aa777bdd8e459f27ab487b5641595142f4e14c68 Diff: https://reviews.apache.org/r/50601/diff/ Testing --- build website via docker container. additionally regex explained/tested here: https://regex101.com/r/zP6sH6/2 Thanks, Joerg Schad

Re: Review Request 50199: Refactored fetcher cache directory creation.

2016-07-20 Thread Joerg Schad
org/r/50199/#comment208681> Can it happen that dir already exists? - Joerg Schad On July 20, 2016, 7:50 p.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 50199: Refactored fetcher cache directory creation.

2016-07-20 Thread Joerg Schad
> On July 20, 2016, 8:14 a.m., Joerg Schad wrote: > > src/launcher/fetcher.cpp, line 514 > > <https://reviews.apache.org/r/50199/diff/2/?file=1447745#file1447745line514> > > > > I personally would still use this cacheDirectory as parameter to > >

Re: Review Request 50199: Refactored fetcher cache directory creation.

2016-07-20 Thread Joerg Schad
> On July 20, 2016, 8:14 a.m., Joerg Schad wrote: > > src/launcher/fetcher.cpp, line 436 > > <https://reviews.apache.org/r/50199/diff/2/?file=1447745#file1447745line436> > > > > Do we really want to check and fail on this condition? In the previous >

Re: Review Request 50199: Refactored fetcher cache directory creation.

2016-07-20 Thread Joerg Schad
is cacheDirectory as parameter to createCacheDirectory for the following reason: we need to extract it anyhow and otherwise we do that at two different places. Feel free to drop if you have a different opinion. - Joerg Schad On July 19, 201

Re: Review Request 50199: Refactored fetcher cache directory creation.

2016-07-19 Thread Joerg Schad
/reviews.apache.org/r/50199/#comment208498> Is there a reason to do this outside `createCacheDirectory`? We are already passing fetcherInfo... src/launcher/fetcher.cpp (line 512) <https://reviews.apache.org/r/50199/#comment208499> Should we check whether an error was returned

Re: Review Request 49892: Removed unnecessary await from test.

2016-07-19 Thread Joerg Schad
Thanks, Joerg Schad

Re: Review Request 49892: Removed unnecessary await from test.

2016-07-19 Thread Joerg Schad
.apache.org/r/49892/#review141806 --- On July 11, 2016, 2:04 p.m., Joerg Schad wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49892/ > --

Re: Review Request 50022: Fixed incorrected command in documentation.

2016-07-14 Thread Joerg Schad
> On July 14, 2016, 10:35 a.m., Guangya Liu wrote: > > I think we should not merge this, the mesos-execute should use mesos > > containerizer but not docker containerizer here, comments? > > Joerg Schad wrote: > Good point. I was mostly concerned with th

Re: Review Request 50022: Fixed incorrected command in documentation.

2016-07-14 Thread Joerg Schad
inerizers=mesos and then update. - Joerg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50022/#review142220 --- On July 14, 2016, 8:32 a.

Review Request 50022: Fixed incorrected command in documentation.

2016-07-14 Thread Joerg Schad
/aec465f898b9186aa3c26acad7671d20 Thanks, Joerg Schad

Re: Review Request 49892: Removed unnecessary await from test.

2016-07-11 Thread Joerg Schad
://reviews.apache.org/r/49892/diff/ Testing --- make check --gtest_repeat=100 Thanks, Joerg Schad

Re: Review Request 32079: added a few more presentations

2016-07-11 Thread Joerg Schad
presentations. Could we just update this list to a more recent point in time? Over the past year there have been many updated/new presentations to the topics covered here... - Joerg Schad On March 15, 2015, 2:08 a.m., Nancy Ko wrote

Re: Review Request 49692: Removed an unnecessary `Clock::settle` from a test case.

2016-07-11 Thread Joerg Schad
-mail. To reply, visit: > https://reviews.apache.org/r/49692/ > --- > > (Updated July 6, 2016, 8:38 a.m.) > > > Review request for mesos, Joerg Schad and Vinod Kone. > > > Repository: mesos > > > Description > --

Review Request 49892: Removed unnecessary await from test.

2016-07-11 Thread Joerg Schad
--- make check --gtest_repeat=100 Thanks, Joerg Schad

Re: Review Request 49865: Renamed `info` to `executorInfo` in `Master::Http::_getExecutors`.

2016-07-10 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49865/#review141606 --- Ship it! Ship It! - Joerg Schad On July 10, 2016, 6:47 a.m

Re: Review Request 49693: Cleaned up some minor style issues.

2016-07-08 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49693/#review141276 --- Ship it! Ship It! - Joerg Schad On July 6, 2016, 8:39 a.m

Re: Review Request 49788: Used MESOS_VERSION instead of fixed mesos version string.

2016-07-07 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49788/#review141252 --- Ship it! Ship It! - Joerg Schad On July 8, 2016, 5:21 a.m

Re: Review Request 49685: Added filtering for orphaned executors in `GET_EXECUTORS` operator API.

2016-07-06 Thread Joerg Schad
tps://reviews.apache.org/r/49685/#comment206427> s/info/executorInfo ? - Joerg Schad On July 6, 2016, 6:07 p.m., haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 49681: Renamed `unsubscribed_frameworks` to `recovered_frameworks`.

2016-07-06 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49681/#review141046 --- Ship it! Ship It! - Joerg Schad On July 6, 2016, 6:06 p.m

Re: Review Request 49700: Added test to check orphaned tasks are filtered.

2016-07-06 Thread Joerg Schad
://reviews.apache.org/r/49700/diff/ Testing --- (sudo) make check on various platforms Thanks, Joerg Schad

Re: Review Request 49697: Removed CHECK from orphan_task filtering.

2016-07-06 Thread Joerg Schad
://reviews.apache.org/r/49697/diff/ Testing --- (sudo) make check on various platforms Thanks, Joerg Schad

Re: Review Request 49685: Added filtering for orphaned executors in `GET_EXECUTORS` operator API.

2016-07-06 Thread Joerg Schad
lexity too much :-)). See https://reviews.apache.org/r/49697/diff/2/ - Joerg Schad On July 6, 2016, 9:30 a.m., haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 49697: Removed CHECK from orphan_task filtering.

2016-07-06 Thread Joerg Schad
://reviews.apache.org/r/49697/diff/ Testing --- (sudo) make check on various platforms Thanks, Joerg Schad

Review Request 49700: Added test to check orphaned tasks are filtered.

2016-07-06 Thread Joerg Schad
) make check on various platforms Thanks, Joerg Schad

Review Request 49699: Changed name of authorization test.

2016-07-06 Thread Joerg Schad
/49699/diff/ Testing --- (sudo) make check on various platforms Thanks, Joerg Schad

Review Request 49698: Renamed incorrect variable name in authorization tests.

2016-07-06 Thread Joerg Schad
--- (sudo) make check an various platforms Thanks, Joerg Schad

Review Request 49697: Removed CHECK from orphan_task filtering.

2016-07-06 Thread Joerg Schad
--- (sudo) make check on various platforms Thanks, Joerg Schad

Re: Review Request 49685: Added filtering for orphaned executors in `GET_EXECUTORS` operator API.

2016-07-06 Thread Joerg Schad
y 6, 2016, 3:43 a.m.) > > > Review request for mesos, Anand Mazumdar, Joerg Schad, Vinod Kone, and Zhitao > Li. > > > Repository: mesos > > > Description > --- > > Added filtering for orphaned executors in `GET_EXECUTORS` operator API. > > &g

Re: Review Request 49607: Added support for recovered frameworks.

2016-07-05 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49607/#review140833 --- On July 5, 2016, 8:15 p.m., Joerg Schad wrote: > > -

Re: Review Request 49607: Added support for recovered frameworks.

2016-07-05 Thread Joerg Schad
da643e6e50b2f313705d2f862c961291aa5d2f22 Diff: https://reviews.apache.org/r/49607/diff/ Testing --- (sudo) make check Thanks, Joerg Schad

Re: Review Request 49607: Added support for recovered frameworks.

2016-07-05 Thread Joerg Schad
da643e6e50b2f313705d2f862c961291aa5d2f22 Diff: https://reviews.apache.org/r/49607/diff/ Testing --- (sudo) make check Thanks, Joerg Schad

Re: Review Request 49609: Added filtering for orphaned tasks in /state endpoint.

2016-07-05 Thread Joerg Schad
/diff/ Testing --- sudo make check Thanks, Joerg Schad

Review Request 49639: Added test for sending framework information after master failover.

2016-07-05 Thread Joerg Schad
fc02ca64c3efcc4d7b7f52d9208fe15a1d60ca44 Diff: https://reviews.apache.org/r/49639/diff/ Testing --- (sudo) make check on various platforms Thanks, Joerg Schad

Re: Review Request 49631: Changed Aurora URL since it's not in incubator anymore

2016-07-05 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49631/#review140759 --- Ship it! Ship It! - Joerg Schad On July 5, 2016, 12:04 p.m

Re: Review Request 49609: Added filtering for orphaned tasks in /state endpoint.

2016-07-05 Thread Joerg Schad
/ Testing (updated) --- sudo make check Thanks, Joerg Schad

Review Request 49607: Added support for recovered frameworks.

2016-07-05 Thread Joerg Schad
://reviews.apache.org/r/49607/diff/ Testing --- (sudo) make check Thanks, Joerg Schad

Review Request 49606: Extended install() to support 7 arguments.

2016-07-05 Thread Joerg Schad
check Thanks, Joerg Schad

Review Request 49609: Added filtering for orphaned tasks in /state endpoint.

2016-07-05 Thread Joerg Schad
filtering for orphaned tasks in /state endpoint. Diffs - src/master/http.cpp 7b2f77b9264242f31ab62eb9db7c621a1b8aa2fe Diff: https://reviews.apache.org/r/49609/diff/ Testing --- Thanks, Joerg Schad

Re: Review Request 49575: Fixed `delete` usage in authorization_test.cpp.

2016-07-04 Thread Joerg Schad
ddd1f6f8caff7b78746f7344c83b89305e94e203 Diff: https://reviews.apache.org/r/49575/diff/ Testing --- sudo make check Thanks, Joerg Schad

Re: Review Request 49574: Refactored /role and getRoles endpoint code.

2016-07-04 Thread Joerg Schad
7b2f77b9264242f31ab62eb9db7c621a1b8aa2fe src/master/master.hpp be7cd239c49a0710a29a8187c01484f9f6d615e1 Diff: https://reviews.apache.org/r/49574/diff/ Testing --- make (sudo) make check Thanks, Joerg Schad

Re: Review Request 49370: Updateted documentation for roles endpoint filtering.

2016-07-04 Thread Joerg Schad
fb56cdba6f142171b3d49e2582b7921f211907e3 src/master/http.cpp 7b2f77b9264242f31ab62eb9db7c621a1b8aa2fe Diff: https://reviews.apache.org/r/49370/diff/ Testing --- Viewed docs via docker website container. Thanks, Joerg Schad

Re: Review Request 49369: Introduced authorization based filtering for /roles.

2016-07-04 Thread Joerg Schad
://reviews.apache.org/r/49369/diff/ Testing --- sudo make check Thanks, Joerg Schad

Re: Review Request 49575: Fixed `delete` usage in authorization_test.cpp.

2016-07-03 Thread Joerg Schad
Diff: https://reviews.apache.org/r/49575/diff/ Testing --- sudo make check Thanks, Joerg Schad

Re: Review Request 49574: Refactored /role and getRoles endpoint code.

2016-07-03 Thread Joerg Schad
7b2f77b9264242f31ab62eb9db7c621a1b8aa2fe src/master/master.hpp be7cd239c49a0710a29a8187c01484f9f6d615e1 Diff: https://reviews.apache.org/r/49574/diff/ Testing --- make (sudo) make check Thanks, Joerg Schad

Re: Review Request 49575: Fixed `delete` usage in authorization_test.cpp.

2016-07-03 Thread Joerg Schad
ly, visit: https://reviews.apache.org/r/49575/#review140564 ------- On July 3, 2016, 4:47 p.m., Joerg Schad wrote: > > --- > This is an automatically generated e-mail. To re

Review Request 49574: Refactored /role and getRoles endpoint code.

2016-07-03 Thread Joerg Schad
/master/master.hpp be7cd239c49a0710a29a8187c01484f9f6d615e1 Diff: https://reviews.apache.org/r/49574/diff/ Testing --- make (sudo) make check Thanks, Joerg Schad

Re: Review Request 49370: Updateted documentation for roles endpoint filtering.

2016-07-02 Thread Joerg Schad
9bd6031d2a3aef921fa4e3f6683cc5c234832d47 src/master/http.cpp 528f01f2e00ddbd15da1cc4fca27b5347c9fc798 Diff: https://reviews.apache.org/r/49370/diff/ Testing --- Viewed docs via docker website container. Thanks, Joerg Schad

Re: Review Request 49369: Introduced authorization based filtering for /roles.

2016-07-02 Thread Joerg Schad
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49369/#review140399 --- On July 1, 2016, 2:39 p.m., Joerg Schad wrote: > > ---

  1   2   3   4   5   6   7   8   9   10   >