Re: Review Request 67980: Windows: Enabled rest of `ProcessTest` suite.

2018-07-23 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67980/#review206358 --- Ship it! Ship It! - John Kordich On July 19, 2018, 8:47

Re: Review Request 67983: Enabled `TimeTest.Now` on Windows.

2018-07-23 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67983/#review206359 --- Ship it! Ship It! - John Kordich On July 20, 2018, 5:19

Re: Review Request 67979: Windows: Documented why the `RemoteLinkLeak` test is not enabled.

2018-07-23 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67979/#review206357 --- Ship it! Ship It! - John Kordich On July 19, 2018, 8:46

Re: Review Request 67978: Windows: Enabled `RemoteLink` tests.

2018-07-23 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67978/#review206356 --- Ship it! Ship It! - John Kordich On July 19, 2018, 8:44

Re: Review Request 67977: Fixed `test-linkee` logic in `ProcessRemoteLinkTest::SetUp()`.

2018-07-23 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67977/#review206354 --- Ship it! Ship It! - John Kordich On July 19, 2018, 8:44

Re: Review Request 67976: Windows: Added `nullptr` checks when using `libwinio_loop` pointer.

2018-07-23 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67976/#review206353 --- Ship it! Ship It! - John Kordich On July 19, 2018, 8:43

Re: Review Request 67951: Added optional `path_separator` parameter to `Path` constructor.

2018-07-23 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67951/#review206352 --- Ship it! Ship It! - John Kordich On July 19, 2018, 8:41

Re: Review Request 67952: Windows: Ported remaining tests in the `HTTPTest` suite.

2018-07-17 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67952/#review206180 --- Ship it! Ship It! - John Kordich On July 17, 2018, 10:27

Re: Review Request 67951: Added optional `path_separator` parameter to `Path` constructor.

2018-07-17 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67951/#review206179 --- Ship it! Ship It! - John Kordich On July 17, 2018, 10:27

Re: Review Request 67607: Windows: Fixed libarchive and zlib linkage warnings.

2018-06-14 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67607/#review204817 --- Ship it! Ship It! - John Kordich On June 14, 2018, 11:20

Review Request 67454: Fixed failing ArchiverTest due to long filename.

2018-06-05 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67454/ --- Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Chun-Hung Hsiao,

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

2018-06-04 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67066/ --- (Updated June 4, 2018, 7:11 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 67064: Added libarchive, bzip2, and xz patches and associated build changes.

2018-06-04 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67064/ --- (Updated June 4, 2018, 7:11 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 67065: Added a new stout utility header file which interfaces with libarchive.

2018-06-04 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67065/ --- (Updated June 4, 2018, 7:11 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 67065: Added a new stout utility header file which interfaces with libarchive.

2018-06-01 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67065/ --- (Updated June 1, 2018, 10:40 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

2018-06-01 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67066/ --- (Updated June 1, 2018, 9:58 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 67064: Added libarchive, bzip2, and xz patches and associated build changes.

2018-06-01 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67064/ --- (Updated June 1, 2018, 9:58 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 67065: Added a new stout utility header file which interfaces with libarchive.

2018-06-01 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67065/ --- (Updated June 1, 2018, 9:58 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

2018-05-30 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67066/ --- (Updated May 30, 2018, 8:30 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 67065: Added a new stout utility header file which interfaces with libarchive.

2018-05-30 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67065/ --- (Updated May 30, 2018, 8:29 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

2018-05-29 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67066/#review204009 --- I'm not sure why review bot is failing for Linux. Will

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

2018-05-24 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67066/ --- (Updated May 25, 2018, 2:13 a.m.) Review request for mesos, Akash Gupta,

Re: Review Request 67064: Added libarchive, bzip2, and xz patches and associated build changes.

2018-05-24 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67064/ --- (Updated May 25, 2018, 2:09 a.m.) Review request for mesos, Akash Gupta,

Re: Review Request 67118: Added bzip2, libarchive, and xz tarballs.

2018-05-24 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67118/ --- (Updated May 25, 2018, 2:08 a.m.) Review request for mesos, Akash Gupta,

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

2018-05-23 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67066/ --- (Updated May 23, 2018, 11:03 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 67065: Added a new stout utility header file which interfaces with libarchive.

2018-05-23 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67065/ --- (Updated May 23, 2018, 11:03 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 67064: Added libarchive, bzip2, and xz patches and associated build changes.

2018-05-23 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67064/ --- (Updated May 23, 2018, 11:03 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 67189: Windows: Removed guards now that `os::shell` exists.

2018-05-18 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67189/#review203436 --- Ship it! Ship It! - John Kordich On May 17, 2018, 7:03

Re: Review Request 67188: Windows: Implemented `os::shell` and enabled tests.

2018-05-18 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67188/#review203435 --- Fix it, then Ship it!

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

2018-05-15 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67066/ --- (Updated May 15, 2018, 6:30 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 67064: Added libarchive, bzip2, and xz patches and associated build changes.

2018-05-15 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67064/ --- (Updated May 15, 2018, 5:09 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 67064: Added libarchive, bzip2, and xz patches and associated build changes.

2018-05-14 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67064/#review203079 --- Oh, of course I see why there's an error here. I'm looking for

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

2018-05-14 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67066/ --- (Updated May 14, 2018, 10:42 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 67064: Added libarchive, bzip2, and xz patches and associated build changes.

2018-05-14 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67064/ --- (Updated May 14, 2018, 10:42 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 67065: Added a new stout utility header file which interfaces with libarchive.

2018-05-14 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67065/ --- (Updated May 14, 2018, 10:42 p.m.) Review request for mesos, Akash Gupta,

Review Request 67118: Added bzip2, libarchive, and xz tarballs.

2018-05-14 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67118/ --- Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Chun-Hung Hsiao,

Re: Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

2018-05-14 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67066/ --- (Updated May 14, 2018, 5:13 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 67065: Added a new stout utility header file which interfaces with libarchive.

2018-05-14 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67065/ --- (Updated May 14, 2018, 5:13 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 67064: Added libarchive, bzip2, and xz tarballs and associated build changes.

2018-05-14 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67064/ --- (Updated May 14, 2018, 5:13 p.m.) Review request for mesos, Akash Gupta,

Review Request 67064: Added libarchive, bzip2, and xz tarballs and associated build changes.

2018-05-10 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67064/ --- Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Chun-Hung Hsiao,

Review Request 67066: Modified the fetcher to use libarchive and added associated tests.

2018-05-10 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67066/ --- Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Chun-Hung Hsiao,

Review Request 67065: Added a new stout utility header file which interfaces with libarchive.

2018-05-10 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67065/ --- Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Chun-Hung Hsiao,

Re: Review Request 66892: Added `SubprocessTest.PipeLargeOutput`.

2018-05-01 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66892/#review202224 --- Ship it! Ship It! - John Kordich On May 1, 2018, 9:24 p.m.,

Re: Review Request 66836: Fixed `mesos-tcp-connect` to use `net::socket`.

2018-04-27 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66836/#review202088 --- Ship it! Ship It! - John Kordich On April 27, 2018, 4:22

Re: Review Request 66835: Replaced `int` and `HANDLE` types with `int_fd`.

2018-04-27 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66835/#review202087 --- Ship it! Ship It! - John Kordich On April 27, 2018, 4:22

Re: Review Request 66834: Windows: Specialized `flags::parse`.

2018-04-27 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66834/#review202086 --- Ship it! Ship It! - John Kordich On April 27, 2018, 4:22

Re: Review Request 66773: Windows: Fixed `os::stat::mtime()` to use `GetFileTime()`.

2018-04-27 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66773/#review202085 --- Ship it! Ship It! - John Kordich On April 27, 2018, 4:21

Re: Review Request 66437: Windows: Removed `FD_CRT` from `WindowsFD` abstraction.

2018-04-27 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66437/#review202081 --- Ship it! Ship It! - John Kordich On April 27, 2018, 4:17

Re: Review Request 66437: Windows: Removed `FD_CRT` from `WindowsFD` abstraction.

2018-04-05 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66437/#review200559 --- Ship it! This really does feel hacky, but the alternative

Re: Review Request 66455: Windows: Fixed `os::ftruncate()` to use `SetEndOfFile()`.

2018-04-04 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66455/#review200524 --- Ship it!

Re: Review Request 66439: Windows: Made `protobuf::write()` use CRT file descriptor explicitly.

2018-04-04 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66439/#review200523 --- 3rdparty/stout/include/stout/protobuf.hpp Line 83 (original), 87

Re: Review Request 66435: Added overloads for `int_fd` to `os::stat::isdir()` and `size()`.

2018-04-04 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66435/#review200518 --- Ship it! Ship It! - John Kordich On April 4, 2018, 5:52

Re: Review Request 66434: Windows: Refactored `subprocess_windows.cpp` to use `os::open()`.

2018-04-04 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66434/#review200517 --- Ship it! Ship It! - John Kordich On April 4, 2018, 7:18

Re: Review Request 66433: Windows: Made `net::download()` use CRT file descriptor explicitly.

2018-04-04 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66433/#review200515 --- Ship it! Ship It! - John Kordich On April 4, 2018, 7:18

Re: Review Request 66432: Windows: Fixed `os::write()` to use `WriteFile()`.

2018-04-04 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66432/#review200514 --- Ship it! Ship It! - John Kordich On April 4, 2018, 5:50

Re: Review Request 66431: Windows: Fixed `os::read()` to use `ReadFile()`.

2018-04-04 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66431/#review200513 --- Ship it!

Re: Review Request 66430: Windows: Fixed `os::dup()` to use `DuplicateHandle()`.

2018-04-04 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66430/#review200511 --- Ship it! Ship It! - John Kordich On April 4, 2018, 5:50

Re: Review Request 66429: Windows: Deleted dead code from `process::internal` namespace.

2018-04-04 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66429/#review200509 --- Ship it! Ship It! - John Kordich On April 4, 2018, 7:17

Re: Review Request 66428: Windows: Fixed `os::lseek()` to use `SetFilePointerEx()`.

2018-04-04 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66428/#review200508 --- Ship it! 3rdparty/stout/include/stout/os/windows/lseek.hpp

Re: Review Request 66427: Split `stout/os/lseek.hpp` into Windows and POSIX files.

2018-04-04 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66427/#review200507 --- Ship it! Ship It! - John Kordich On April 4, 2018, 5:48

Re: Review Request 66425: Windows: Replaced `WindowsFD` with `int_fd` typedef.

2018-04-04 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66425/#review200506 --- Ship it! Ship It! - John Kordich On April 4, 2018, 5:47

Re: Review Request 66424: Windows: Replaced `_wopen()` with `CreateFileW()` in `os::open()`.

2018-04-04 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66424/#review200505 --- Ship it! Ship It! - John Kordich On April 4, 2018, 5:47

Re: Review Request 66423: Split `stout/os/open.hpp` into Windows and POSIX files.

2018-04-04 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66423/#review200504 --- Ship it! Ship It! - John Kordich On April 4, 2018, 5:47

Re: Review Request 66420: Windows: Extracted job object code into `os/windows/jobobject.hpp`.

2018-04-04 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66420/#review200503 --- Ship it! Ship It! - John Kordich On April 4, 2018, 5:46

Re: Review Request 66420: Windows: Extracted job object code into `os/windows/jobobject.hpp`.

2018-04-04 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66420/#review200502 --- Fix it, then Ship it! Oops. I just realized as I was getting

Re: Review Request 66445: Windows: Cleaned up included CRT headers.

2018-04-04 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66445/#review200498 --- Ship it! Ship It! - John Kordich On April 4, 2018, 7:26

Re: Review Request 66443: Fixed `Subprocess::ChildHook::CHDIR()` to use `os::chdir()`.

2018-04-04 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66443/#review200496 --- Ship it! Ship It! - John Kordich On April 4, 2018, 5:58

Re: Review Request 66442: Windows: Fixed `os::abort()` to use `WriteFile()`.

2018-04-04 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66442/#review200495 --- Ship it! Ship It! - John Kordich On April 4, 2018, 5:57

Re: Review Request 66444: Windows: Made `signals.hpp` compile.

2018-04-04 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66444/#review200497 --- Ship it! Ship It! - John Kordich On April 4, 2018, 5:58

Re: Review Request 66441: Fixed mismatched types in `process.cpp`.

2018-04-04 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66441/#review200494 --- Ship it! Ship It! - John Kordich On April 4, 2018, 5:57

Re: Review Request 66440: Replaced `open()` with `os::open()` in `http_proxy.cpp`.

2018-04-04 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66440/#review200493 --- Ship it! Ship It! - John Kordich On April 4, 2018, 5:57

Re: Review Request 66438: Windows: Made `libevent` use CRT file descriptor explicitly.

2018-04-04 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66438/#review200492 --- Ship it! Ship It! - John Kordich On April 4, 2018, 7:19

Re: Review Request 66436: Removed use of `fstat()` from `http.cpp` and `http_proxy.cpp`.

2018-04-04 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66436/#review200490 --- Ship it! Ship It! - John Kordich On April 4, 2018, 5:54

Re: Review Request 66426: Windows: More constness in stout.

2018-04-04 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66426/#review200489 --- Ship it! Ship It! - John Kordich On April 4, 2018, 5:48

Re: Review Request 66421: Windows: Included used `jobobject.hpp` stout header in libprocess.

2018-04-04 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66421/#review200487 --- Ship it! Ship It! - John Kordich On April 4, 2018, 5:47

Re: Review Request 66002: Fixed the HTTP API path variables on Windows.

2018-03-19 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66002/ --- (Updated March 19, 2018, 6:20 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 66008: CMake: Enabled compiler warnings.

2018-03-13 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66008/#review199096 --- Ship it! Ship It! - John Kordich On March 9, 2018, 10:38

Re: Review Request 66012: CMake: Split `CMAKE_FORWARD_ARGS` into `C` and `CXX` versions.

2018-03-12 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66012/#review199032 --- Ship it! I'm fine with these changes, but the description can

Re: Review Request 66011: Windows: Set 3rdparty libraries to link to CRT dynamically.

2018-03-12 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66011/#review199034 --- Ship it! Ship It! - John Kordich On March 9, 2018, 10:39

Re: Review Request 66013: Windows: Made ZooKeeper use default CRT linking.

2018-03-12 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66013/#review199033 --- Ship it! Ship It! - John Kordich On March 9, 2018, 10:39

Re: Review Request 66010: Windows: Switched to default CRT linkage.

2018-03-12 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66010/#review199031 --- Ship it! Ship It! - John Kordich On March 9, 2018, 10:39

Re: Review Request 66009: CMake: Added `-Wno-unused-local-typedefs` to Boost interface.

2018-03-12 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66009/#review199030 --- Ship it! Ship It! - John Kordich On March 9, 2018, 10:38

Re: Review Request 66007: CMake: Set C++11 as standard automatically.

2018-03-12 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66007/#review199029 --- Ship it! Ship It! - John Kordich On March 9, 2018, 10:37

Re: Review Request 66014: Windows: Made SASL use default CRT linking.

2018-03-09 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66014/#review198974 --- Ship it! Ship It! - John Kordich On March 9, 2018, 10:39

Re: Review Request 66002: Fixed the HTTP API path variables on Windows.

2018-03-09 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66002/ --- (Updated March 9, 2018, 8:17 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 66002: Fixed the HTTP API path variables on Windows to use proper seperators.

2018-03-09 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66002/#review198955 --- src/tests/files_tests.cpp Line 338 (original), 338 (patched)

Review Request 66002: Fixed the HTTP API path variables on Windows to use proper seperators.

2018-03-09 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66002/ --- Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Jeff Coffler, and

Re: Review Request 65936: Changed flags to CreateFile to support Windows symlink path resolution.

2018-03-08 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65936/ --- (Updated March 8, 2018, 11:21 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 65936: Changed flags to CreateFile to support Windows symlink path resolution.

2018-03-08 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65936/ --- (Updated March 8, 2018, 7:22 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 65936: Changed flags to CreateFile to support Windows symlink path resolution.

2018-03-07 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65936/ --- (Updated March 7, 2018, 10:24 a.m.) Review request for mesos, Akash Gupta,

Review Request 65936: Changed flags to CreateFile to support Windows symlink path resolution.

2018-03-07 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65936/ --- Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, and Jeff Coffler.

Re: Review Request 64104: Added dependency of curl to agent. Enabled most health check tests.

2017-12-04 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64104/ --- (Updated Dec. 4, 2017, 6:54 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 64102: Renamed curl target to libcurl, and staging of curl.exe on Windows.

2017-12-04 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64102/ --- (Updated Dec. 4, 2017, 6:54 p.m.) Review request for mesos, Akash Gupta,

Re: Review Request 64103: Changed dependency of curl to libcurl for stout.

2017-12-04 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64103/ --- (Updated Dec. 4, 2017, 6:54 p.m.) Review request for mesos, Akash Gupta,

Review Request 64102: Renamed curl target to libcurl, and staging of curl.exe on Windows.

2017-11-27 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64102/ --- Review request for mesos, Andrew Schwartzmeyer and Joseph Wu. Repository:

Review Request 64104: Added dependency of curl to agent. Enabled most health check tests.

2017-11-27 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64104/ --- Review request for mesos. Bugs: MESOS-6709

Review Request 64103: Changed dependency of curl to libcurl for stout.

2017-11-27 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64103/ --- Review request for mesos. Repository: mesos Description --- Changed

Re: Review Request 63816: Windows: Fixed MESOS-6816 to enable `ExecutorEnvironmentVariables`.

2017-11-15 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63816/#review191100 --- Ship it! - John Kordich On Nov. 14, 2017, 11:17 p.m., Andrew

Re: Review Request 63815: Windows: Fixed environment priorities in `shell.hpp`.

2017-11-15 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63815/#review191099 --- Ship it! Nice fix, that would have been annoying otherwise. -

Re: Review Request 63814: Windows: Fixed `os::host_default_path()`.

2017-11-15 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63814/#review191098 --- Ship it! - John Kordich On Nov. 14, 2017, 11:16 p.m., Andrew

  1   2   >