Re: Review Request 46798: Introduced linux capabilities support for mesos containerizer.

2016-05-26 Thread Jojy Varghese
. Thanks, Jojy Varghese

Re: Review Request 46371: Added basic tests for capabilities API.

2016-05-26 Thread Jojy Varghese
/capabilities_test_helper_main.cpp PRE-CREATION src/tests/capabilities_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/46371/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 46370: Introduced linux capabilities API.

2016-05-26 Thread Jojy Varghese
--- make check. Thanks, Jojy Varghese

Re: Review Request 46371: Added basic tests for capabilities API.

2016-05-25 Thread Jojy Varghese
/capabilities_test_helper_main.cpp PRE-CREATION src/tests/capabilities_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/46371/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 46370: Introduced linux capabilities API.

2016-05-25 Thread Jojy Varghese
://reviews.apache.org/r/46370/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 47199: Implemented parsing docker labels in v1 spec.

2016-05-23 Thread Jojy Varghese
tps://reviews.apache.org/r/47199/#comment199283> Looks like there is scope for de-duplicating code between this block and the block above(`config` and `container_config`)? - Jojy Varghese On May 13, 2016, 8:49 p.m., Gilbert Song

Re: Review Request 47608: Add Labels from TaskInfo into TaskStatus message.

2016-05-23 Thread Jojy Varghese
riable names (unlike L3318). (L3318 in particular, does not need the extra variable. See other similar code.) - Jojy Varghese On May 20, 2016, 6:38 p.m., Srinivas Brahmaroutu wrote: > > --- > This is an automatically generated e

Re: Review Request 47482: Added preliminary support for parsing ELF files in stout.

2016-05-18 Thread Jojy Varghese
s opposed to being first created and then copied. - Jojy Varghese On May 18, 2016, 3:16 a.m., Kevin Klues wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 47482: Added preliminary support for parsing ELF files in stout.

2016-05-17 Thread Jojy Varghese
pp (line 184) <https://reviews.apache.org/r/47482/#comment198216> emplace_back? 3rdparty/stout/include/stout/elf.hpp (line 196) <https://reviews.apache.org/r/47482/#comment198214> const? - Jojy Varghese On May 17, 2016, 7:17

Re: Review Request 47481: Rewrote os::read() to be friendlier to reading binary data.

2016-05-17 Thread Jojy Varghese
tps://reviews.apache.org/r/47481/#comment198170> Does this assume a certain stack size? - Jojy Varghese On May 17, 2016, 8:36 p.m., Kevin Klues wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 46798: Introduced linux capabilities support for mesos containerizer.

2016-05-17 Thread Jojy Varghese
4293416ac8434e9eb7e80724480a54936a2fe24a src/tests/containerizer/mesos_containerizer_tests.cpp 09742ff21513dc2570684d384b257868dd57a9ce Diff: https://reviews.apache.org/r/46798/diff/ Testing --- make check; used mesos cli to test end to end functionality. Thanks, Jojy Varghese

Re: Review Request 46370: Introduced linux capabilities API.

2016-05-17 Thread Jojy Varghese
--- make check. Thanks, Jojy Varghese

Re: Review Request 46498: Add runtime for Appc Spec ex: command, workingdir and environment.

2016-05-16 Thread Jojy Varghese
I think you just need the base image manifest here and not all the manifests. Right? - Jojy Varghese On May 14, 2016, 4:20 a.m., Srinivas Brahmaroutu wrote: > > --- > This is an automatica

Re: Review Request 46799: Added capabilities support to mesos-execute.

2016-05-13 Thread Jojy Varghese
4711e80314e2fc4cde077bebd9a8167324c3254e Diff: https://reviews.apache.org/r/46799/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 46798: Introduced linux capabilities support for mesos containerizer.

2016-05-12 Thread Jojy Varghese
://reviews.apache.org/r/46798/diff/ Testing --- make check; used mesos cli to test end to end functionality. Thanks, Jojy Varghese

Re: Review Request 46799: Added capabilities support to mesos-execute.

2016-05-12 Thread Jojy Varghese
4711e80314e2fc4cde077bebd9a8167324c3254e Diff: https://reviews.apache.org/r/46799/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 46370: Introduced linux capabilities API.

2016-05-12 Thread Jojy Varghese
--- make check. Thanks, Jojy Varghese

Re: Review Request 46498: Add runtime for Appc Spec ex: command, workingdir and environment.

2016-05-12 Thread Jojy Varghese
your previous patches (https://reviews.apache.org/r/46107) here. I would advice you to split this patch into 2: - Protobuf changes - Other changes -jojy - Jojy Varghese On May 12, 2016, 9:23 p.m., Srinivas Brahmaroutu wrote

Re: Review Request 46371: Added basic tests for capabilities API.

2016-05-10 Thread Jojy Varghese
src/tests/capabilities_test_helper_main.cpp PRE-CREATION src/tests/capabilities_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/46371/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 46370: Introduced linux capabilities API.

2016-05-10 Thread Jojy Varghese
://reviews.apache.org/r/46370/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 46369: Added capabilities support in ContanerInfo protobuf.

2016-05-10 Thread Jojy Varghese
include/mesos/v1/mesos.proto 44b4f8a059f9dfdcbf02f0c30c1b859898c2e617 Diff: https://reviews.apache.org/r/46369/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 46370: Introduced linux capabilities API.

2016-05-09 Thread Jojy Varghese
global variable in > > the cpp file which will be set the first time `version` is called. Any > > subsequent calling of `version` will use the cached value: > > > > ``` > > Try version(); > > Try lastCapability(); > > > > Try<Ow

Re: Review Request 46370: Introduced linux capabilities API.

2016-05-08 Thread Jojy Varghese
global variable in > > the cpp file which will be set the first time `version` is called. Any > > subsequent calling of `version` will use the cached value: > > > > ``` > > Try version(); > > Try lastCapability(); > > > > Try<Ow

Re: Review Request 46370: Introduced linux capabilities API.

2016-05-07 Thread Jojy Varghese
global variable in > > the cpp file which will be set the first time `version` is called. Any > > subsequent calling of `version` will use the cached value: > > > > ``` > > Try version(); > > Try lastCapability(); > > > > Try<Ow

Re: Review Request 46370: Introduced linux capabilities API.

2016-05-07 Thread Jojy Varghese
classes. Also, I believe that we should have `Capability` (NET_RAW, CHOWN etc) as first class citizens of the API. For example libcap uses `cap_value_t` as the type for the capabilities. I added `enum Capability` as the type. - Jojy

Re: Review Request 46799: Added capabilities support to mesos-execute.

2016-05-06 Thread Jojy Varghese
t; > all when running `mesos-execute` in other platorms. > > Jojy Varghese wrote: > I avoided that logic as it would mean spreading `ifdef` all over the file. > > Qian Zhang wrote: > Right, but I think that is the common way to handle the platform-specific > logic, you

Re: Review Request 46799: Added capabilities support to mesos-execute.

2016-05-06 Thread Jojy Varghese
4711e80314e2fc4cde077bebd9a8167324c3254e Diff: https://reviews.apache.org/r/46799/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 46798: Introduced linux capabilities support for mesos containerizer.

2016-05-06 Thread Jojy Varghese
://reviews.apache.org/r/46798/diff/ Testing --- make check; used mesos cli to test end to end functionality. Thanks, Jojy Varghese

Re: Review Request 46370: Introduced linux capabilities API.

2016-05-06 Thread Jojy Varghese
--- make check. Thanks, Jojy Varghese

Re: Review Request 46369: Added capabilities support in ContanerInfo protobuf.

2016-05-06 Thread Jojy Varghese
44b4f8a059f9dfdcbf02f0c30c1b859898c2e617 Diff: https://reviews.apache.org/r/46369/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 46371: Added basic tests for capabilities API.

2016-05-05 Thread Jojy Varghese
/capabilities_test_helper_main.cpp PRE-CREATION src/tests/capabilities_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/46371/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 46798: Introduced linux capabilities support for mesos containerizer.

2016-05-05 Thread Jojy Varghese
://reviews.apache.org/r/46798/diff/ Testing --- make check; used mesos cli to test end to end functionality. Thanks, Jojy Varghese

Re: Review Request 46370: Introduced linux capabilities API.

2016-05-05 Thread Jojy Varghese
--- make check. Thanks, Jojy Varghese

Re: Review Request 46107: Add Appc runtime spec for command, working directory and environment.

2016-05-03 Thread Jojy Varghese
import "mesos/docker/v1.proto"; ``` include/mesos/slave/isolator.proto (line 94) <https://reviews.apache.org/r/46107/#comment195537> I would place this message above the `Docker` messgae. - Jojy Varghese On April 12, 2016,

Re: Review Request 46798: Introduced linux capabilities support for mesos containerizer.

2016-05-02 Thread Jojy Varghese
functionality. Thanks, Jojy Varghese

Re: Review Request 46799: Added capabilities support to mesos-execute.

2016-04-29 Thread Jojy Varghese
4711e80314e2fc4cde077bebd9a8167324c3254e Diff: https://reviews.apache.org/r/46799/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 46799: Added capabilities support to mesos-execute.

2016-04-28 Thread Jojy Varghese
eviews.apache.org/r/46799/#review131021 --- On April 28, 2016, 9:49 p.m., Jojy Varghese wrote: > > --- > This is an automatically generated e-mail. To re

Review Request 46799: Added capabilities support to mesos-execute.

2016-04-28 Thread Jojy Varghese
://reviews.apache.org/r/46799/diff/ Testing --- make check. Thanks, Jojy Varghese

Review Request 46798: Introduced linux capabilities support for mesos containerizer.

2016-04-28 Thread Jojy Varghese
29d313051865761306029f331eb36684c3252ffb src/tests/containerizer/mesos_containerizer_tests.cpp 09742ff21513dc2570684d384b257868dd57a9ce Diff: https://reviews.apache.org/r/46798/diff/ Testing --- make check; used mesos cli to test end to end functionality. Thanks, Jojy Varghese

Re: Review Request 46370: Introduced linux capabilities API.

2016-04-28 Thread Jojy Varghese
--- make check. Thanks, Jojy Varghese

Re: Review Request 46370: Introduced linux capabilities API.

2016-04-25 Thread Jojy Varghese
--- make check. Thanks, Jojy Varghese

Re: Review Request 46182: Adding app runtime processing to appc store and provisioner.

2016-04-21 Thread Jojy Varghese
visioner.cpp (line 307) <https://reviews.apache.org/r/46182/#comment193476> Fix indentation src/slave/containerizer/mesos/provisioner/store.hpp (line 26) <https://reviews.apache.org/r/46182/#comment193477> headers should be alphabetically sorted. - Jojy Varghese On April 15, 2

Re: Review Request 46369: Added capabilities support in ContanerInfo protobuf.

2016-04-21 Thread Jojy Varghese
34da0a1484dc2f71262d8b97484b8edaae35bb6c Diff: https://reviews.apache.org/r/46369/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 46370: Introduced linux capabilities API.

2016-04-20 Thread Jojy Varghese
plexity to the caller. Same idea with other classes. - Jojy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46370/#review129674 --- On April 2

Re: Review Request 46370: Introduced linux capabilities API.

2016-04-20 Thread Jojy Varghese
sit: https://reviews.apache.org/r/46370/#review129674 --- On April 20, 2016, 8:19 p.m., Jojy Varghese wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 46370: Introduced linux capabilities API.

2016-04-20 Thread Jojy Varghese
--- make check. Thanks, Jojy Varghese

Re: Review Request 46371: Added basic tests for capabilities API.

2016-04-20 Thread Jojy Varghese
/capabilities_test_helper_main.cpp PRE-CREATION src/tests/capabilities_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/46371/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 46370: Introduced linux capabilities API.

2016-04-20 Thread Jojy Varghese
--- make check. Thanks, Jojy Varghese

Re: Review Request 46370: Introduced linux capabilities API.

2016-04-20 Thread Jojy Varghese
actice in C++ to define an `enum` as a > > `enum class` for better type checking. As such, you can define the final > > element with a common name of `COUNT` to get at the size of the enum. > > > > For example, you can get at the size of the enum as: > > `capabilities

Re: Review Request 46370: Introduced linux capabilities API.

2016-04-20 Thread Jojy Varghese
because that is what its referenced as in every documentation and literature. - Jojy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46370/#review129674 --

Review Request 46371: Added basic tests for capabilities API.

2016-04-19 Thread Jojy Varghese
--- Added basic tests for capabilities API. Diffs - src/Makefile.am a8f68316c5d4d4c82d99363535a97fa5b1caafc5 src/tests/capabilities_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/46371/diff/ Testing --- make check. Thanks, Jojy Varghese

Review Request 46370: Introduced linux capabilities API.

2016-04-19 Thread Jojy Varghese
/CMakeLists.txt ca59a1824352423f4db6ef8bb41acc6fe602c041 src/Makefile.am a8f68316c5d4d4c82d99363535a97fa5b1caafc5 src/linux/capabilities.hpp PRE-CREATION src/linux/capabilities.cpp PRE-CREATION Diff: https://reviews.apache.org/r/46370/diff/ Testing --- make check. Thanks, Jojy Varghese

Review Request 46369: Added capabilities support in ContanerInfo protobuf.

2016-04-19 Thread Jojy Varghese
, Jojy Varghese

Re: Review Request 46044: Cleaned up c-tor signature in mesos-execute.

2016-04-11 Thread Jojy Varghese
> On April 11, 2016, 9:53 p.m., Jojy Varghese wrote: > > src/cli/execute.cpp, line 196 > > <https://reviews.apache.org/r/46044/diff/1/?file=1339684#file1339684line196> > > > > I like the idea of simplifying the ctor. I am not too excited about the >

Re: Review Request 46044: Cleaned up c-tor signature in mesos-execute.

2016-04-11 Thread Jojy Varghese
t (say `ContainerInfo`). Just my 2 cents. - Jojy Varghese On April 11, 2016, 7:01 p.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 44934: Updated mesos-execute to add support for Appc.

2016-04-01 Thread Jojy Varghese
://reviews.apache.org/r/44934/diff/ Testing --- Tested with various Appc images. Thanks, Jojy Varghese

Re: Review Request 45002: Added FTS_PHYSICAL option to fts_open for rmdir.

2016-03-23 Thread Jojy Varghese
--- make check. Thanks, Jojy Varghese

Re: Review Request 45003: Fixed rmdir comment for FTS_SLNONE as per coding guidelines.

2016-03-23 Thread Jojy Varghese
> > > > (1) The relevant parameters are `FTS_PHYSICAL` vs. `FTS_LOGICAL`, as > > well as `FTS_COMFOLLOW`. > > > > (2) Since we _do_ set `FTS_PHYSICAL`, isn't it possible for > > `FTS_SLNONE` to be returned? > > Jojy Varghese wrote: > I b

Re: Review Request 45003: Fixed rmdir comment for FTS_SLNONE as per coding guidelines.

2016-03-23 Thread Jojy Varghese
> > > > (1) The relevant parameters are `FTS_PHYSICAL` vs. `FTS_LOGICAL`, as > > well as `FTS_COMFOLLOW`. > > > > (2) Since we _do_ set `FTS_PHYSICAL`, isn't it possible for > > `FTS_SLNONE` to be returned? > > Jojy Varghese wrote: > I b

Re: Review Request 45003: Fixed rmdir comment for FTS_SLNONE as per coding guidelines.

2016-03-23 Thread Jojy Varghese
://reviews.apache.org/r/45003/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 45002: Added FTS_PHYSICAL option to fts_open for rmdir.

2016-03-23 Thread Jojy Varghese
23a5b1059b4d9fde1e4a1aab5cd4fa6d05862332 Diff: https://reviews.apache.org/r/45002/diff/ Testing --- make check. Thanks, Jojy Varghese

Review Request 45259: Added Appc provisioner integration test.

2016-03-23 Thread Jojy Varghese
check. Thanks, Jojy Varghese

Re: Review Request 45003: Fixed rmdir comment for FTS_SLNONE as per coding guidelines.

2016-03-23 Thread Jojy Varghese
> > > > (1) The relevant parameters are `FTS_PHYSICAL` vs. `FTS_LOGICAL`, as > > well as `FTS_COMFOLLOW`. > > > > (2) Since we _do_ set `FTS_PHYSICAL`, isn't it possible for > > `FTS_SLNONE` to be returned? > > Jojy Varghese wrote: > I b

Re: Review Request 44934: Updated mesos-execute to add support for Appc.

2016-03-22 Thread Jojy Varghese
cally generated e-mail. To reply, visit: https://reviews.apache.org/r/44934/#review124834 --- On March 20, 2016, 4:19 a.m., Jojy Varghese wrote: > > --- > This is an automa

Review Request 44934: Updated mesos-execute to add support for Appc.

2016-03-20 Thread Jojy Varghese
--- Updated mesos-execute to add support for Appc. Diffs - src/cli/execute.cpp ed42cb568f3d16856f48b3bbd354cb2b0fb83e8e Diff: https://reviews.apache.org/r/44934/diff/ Testing --- Tested with various Appc images. Thanks, Jojy Varghese

Review Request 45002: Added FTS_PHYSICAL option to fts_open for rmdir.

2016-03-20 Thread Jojy Varghese
/rmdir.hpp cbc97596cd8ed1e6d4261568fd0086c86e063232 3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp daa46e05d113fd62ea9dad042ec41aaab28ad003 Diff: https://reviews.apache.org/r/45002/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 44934: Updated mesos-execute to add support for Appc.

2016-03-20 Thread Jojy Varghese
. Repository: mesos Description --- Updated mesos-execute to add support for Appc. Diffs (updated) - src/cli/execute.cpp ed42cb568f3d16856f48b3bbd354cb2b0fb83e8e Diff: https://reviews.apache.org/r/44934/diff/ Testing --- Tested with various Appc images. Thanks, Jojy Varghese

Re: Review Request 44934: Updated mesos-execute to add support for Appc.

2016-03-19 Thread Jojy Varghese
/ Testing --- Tested with various Appc images. Thanks, Jojy Varghese

Re: Review Request 45002: Added FTS_PHYSICAL option to fts_open for rmdir.

2016-03-19 Thread Jojy Varghese
2/#review124434 --- On March 18, 2016, 12:16 a.m., Jojy Varghese wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:/

Re: Review Request 45003: Fixed rmdir comment for FTS_SLNONE as per coding guidelines.

2016-03-19 Thread Jojy Varghese
LOW needs to be set in order for FTS_SLNONE to be returned. - Jojy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45003/#review124433 ---

Review Request 45010: Fixed newlines for include directives.

2016-03-19 Thread Jojy Varghese
Description --- Fixed newlines for include directives. Diffs - 3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp daa46e05d113fd62ea9dad042ec41aaab28ad003 Diff: https://reviews.apache.org/r/45010/diff/ Testing --- make check. Thanks, Jojy Varghese

Review Request 45003: Fixed rmdir comment for FTS_SLNONE as per coding guidelines.

2016-03-19 Thread Jojy Varghese
Description --- Fixed rmdir comment for FTS_SLNONE as per coding guidelines. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rmdir.hpp cbc97596cd8ed1e6d4261568fd0086c86e063232 Diff: https://reviews.apache.org/r/45003/diff/ Testing --- make check. Thanks, Jojy

Re: Review Request 44934: Updated mesos-execute to add support for Appc.

2016-03-19 Thread Jojy Varghese
--- Tested with various Appc images. Thanks, Jojy Varghese

Re: Review Request 44755: Added getAppcImage for Appc provisioning tests.

2016-03-19 Thread Jojy Varghese
--- make check. Thanks, Jojy Varghese

Re: Review Request 44934: Updated mesos-execute to add support for Appc.

2016-03-19 Thread Jojy Varghese
labels.add_labels()->CopyFrom(arch); > > > > appc.mutable_labels()->CopyFrom(labels); > > > > Image mesosImage; > > > > mesosImage.set_type(Image::APPC); > > mesosImage.mutable_appc()->CopyFrom(appc); > >

Review Request 45001: Replaced const ref to temporary in tests for consistency.

2016-03-19 Thread Jojy Varghese
: https://reviews.apache.org/r/45001/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 44934: Updated mesos-execute to add support for Appc.

2016-03-19 Thread Jojy Varghese
`if (containerizer == "mesos")` for both dockerImage case and appcImage case. By seperating the logic by cotainerizer, we now can add more image types into the "mesos" containerizer block (say OCI image). - Jojy -

Re: Review Request 44934: Updated mesos-execute to add support for Appc.

2016-03-19 Thread Jojy Varghese
labels.add_labels()->CopyFrom(arch); > > > > appc.mutable_labels()->CopyFrom(labels); > > > > Image mesosImage; > > > > mesosImage.set_type(Image::APPC); > > mesosImage.mutable_appc()->CopyFrom(appc); > >

Re: Review Request 44755: Added getAppcImage for Appc provisioning tests.

2016-03-19 Thread Jojy Varghese
--- make check. Thanks, Jojy Varghese

Re: Review Request 44934: Updated mesos-execute to add support for Appc.

2016-03-19 Thread Jojy Varghese
. Repository: mesos Description --- Updated mesos-execute to add support for Appc. Diffs (updated) - src/cli/execute.cpp ed42cb568f3d16856f48b3bbd354cb2b0fb83e8e Diff: https://reviews.apache.org/r/44934/diff/ Testing --- Tested with various Appc images. Thanks, Jojy Varghese

Re: Review Request 44934: Updated mesos-execute to add support for Appc.

2016-03-18 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44934/#review123969 ------- On March 16, 2016, 9:21 p.m., Jojy Varghese wrote: > > -

Re: Review Request 44874: Added support for FTS_SLNONE in rmdir.

2016-03-15 Thread Jojy Varghese
ed to fix it there as well as we fix it here. - Jojy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44874/#review123803 -----

Re: Review Request 44874: Added support for FTS_SLNONE in rmdir.

2016-03-15 Thread Jojy Varghese
47 is where `fts_open` calls `fts_stat` with a check for `FTS_COMFOLLOW`. In `fts_stat`, L879, the check is made for `logical` or `follow`. - Jojy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/

Review Request 44874: Added support for FTS_SLNONE in rmdir.

2016-03-15 Thread Jojy Varghese
://reviews.apache.org/r/44874/diff/ Testing --- make check. Thanks, Jojy Varghese

Review Request 44873: Added test for rmdir with device file.

2016-03-15 Thread Jojy Varghese
--- make check. Thanks, Jojy Varghese

Re: Review Request 44230: Added FS_DEFAULT case in rmdir.

2016-03-15 Thread Jojy Varghese
64bccdebcea46119e69e4e > None of these tests covers this bug. > > - Cong > > > On March 1st, 2016, 10:01 p.m. UTC, Jojy Varghese wrote: > > Review request for mesos and Jie Yu. > By Jojy Varghese. > Updated March 1, 2016, 10:01 p.m. > > Repository: mesos > Des

Re: Review Request 44230: Added FS_DEFAULT case in rmdir.

2016-03-15 Thread Jojy Varghese
gt; ------- > > > On March 1, 2016, 10:01 p.m., Jojy Varghese wrote: >> >> --- >> This is an automatically generated e-mail. To reply, visit: >> https:/

Re: Review Request 44755: Added getAppcImage for Appc provisioning tests.

2016-03-15 Thread Jojy Varghese
and make it 'static'? > > Anand Mazumdar wrote: > Wondering why does this function needs to be a global and can't be part > of the test fixture i.e. `AppcImageFetcherTest`? > > Jojy Varghese wrote: > The intend is to use it in all fixtures. Eg, for integegration tes

Re: Review Request 44755: Added getAppcImage for Appc provisioning tests.

2016-03-15 Thread Jojy Varghese
tests, we have a separate fixture. - Jojy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44755/#review123688 ------- On M

Re: Review Request 44755: Added getAppcImage for Appc provisioning tests.

2016-03-15 Thread Jojy Varghese
://reviews.apache.org/r/44755/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 44456: Added Appc provisioner integration test.

2016-03-12 Thread Jojy Varghese
069af8a0b5e031d9032fd13154cee250f279b404 Diff: https://reviews.apache.org/r/44456/diff/ Testing --- make check. Thanks, Jojy Varghese

Review Request 44755: Added getAppcImage for Appc provisioning tests.

2016-03-12 Thread Jojy Varghese
--- Added helper function to get an Appc image protobuf object with given parameters. Diffs - src/tests/containerizer/provisioner_appc_tests.cpp 069af8a0b5e031d9032fd13154cee250f279b404 Diff: https://reviews.apache.org/r/44755/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 44456: Added Appc provisioner integration test.

2016-03-11 Thread Jojy Varghese
6c8087e17aa8b7139ba12337d5be472b7099e77f Diff: https://reviews.apache.org/r/44456/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 44299: Added unit test for file URI fetcher.

2016-03-08 Thread Jojy Varghese
eviews.apache.org/r/44299/#review122461 --- On March 8, 2016, 10:49 p.m., Jojy Varghese wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 44456: Added Appc provisioner integration test.

2016-03-08 Thread Jojy Varghese
6c8087e17aa8b7139ba12337d5be472b7099e77f Diff: https://reviews.apache.org/r/44456/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 44299: Added unit test for file URI fetcher.

2016-03-08 Thread Jojy Varghese
. Repository: mesos Description --- Added unit test for file URI fetcher. Diffs (updated) - src/tests/containerizer/provisioner_appc_tests.cpp 6c8087e17aa8b7139ba12337d5be472b7099e77f Diff: https://reviews.apache.org/r/44299/diff/ Testing --- make check. Thanks, Jojy Varghese

Review Request 44534: Refactored AppcImageFetcherTest.

2016-03-08 Thread Jojy Varghese
to 'server'). - Renamed prepareServerImage to prepareImage to reflect the semantics. Diffs - src/tests/containerizer/provisioner_appc_tests.cpp 6c8087e17aa8b7139ba12337d5be472b7099e77f Diff: https://reviews.apache.org/r/44534/diff/ Testing --- make check. Thanks, Jojy

Review Request 44533: Fixed AppcStoreTest fixture to remove imageId from test image.

2016-03-08 Thread Jojy Varghese
--- Fixed AppcStoreTest fixture to remove imageId from test image. Diffs - src/tests/containerizer/provisioner_appc_tests.cpp 6c8087e17aa8b7139ba12337d5be472b7099e77f Diff: https://reviews.apache.org/r/44533/diff/ Testing --- make check. Thanks, Jojy Varghese

Re: Review Request 44455: Fixed AppcImageFetcherTest for manifest formatting.

2016-03-08 Thread Jojy Varghese
, Jojy Varghese

Review Request 44455: Fixed AppcImageFetcherTest for manifest formatting.

2016-03-07 Thread Jojy Varghese
--- Fixed AppcImageFetcherTest for manifest formatting. Diffs - src/tests/containerizer/provisioner_appc_tests.cpp 6c8087e17aa8b7139ba12337d5be472b7099e77f Diff: https://reviews.apache.org/r/44455/diff/ Testing --- make check. Thanks, Jojy Varghese

  1   2   3   4   5   6   7   8   >