Re: Review Request 69708: Fixed gRPC CMake build issue on Ubuntu 14.04.

2019-01-15 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69708/#review212038 --- Ship it! Ship It! - Joseph Wu On Jan. 15, 2019, 3:13 p.m

Review Request 69752: Split scheduler::Call validation into a separate file.

2019-01-15 Thread Joseph Wu
-CREATION src/scheduler/validation.cpp PRE-CREATION Diff: https://reviews.apache.org/r/69752/diff/1/ Testing --- cmake --build . Thanks, Joseph Wu

Review Request 69754: CMake: Changed mesos-execute to link against a smaller library.

2019-01-15 Thread Joseph Wu
e99b055ebb0fc0a97955bcb71c74bd9a8c6923ed Diff: https://reviews.apache.org/r/69754/diff/1/ Testing --- cmake --build . --target mesos-hdfs cmake --build . --target mesos-execute Thanks, Joseph Wu

Review Request 69755: Moved flags and constants in MesosContainerLaunch into header.

2019-01-15 Thread Joseph Wu
/port_mapping_tests.cpp b511016fa7cd80d2ffee1747e5e463cc1b2d56bb Diff: https://reviews.apache.org/r/69755/diff/1/ Testing --- cmake --build . Thanks, Joseph Wu

Review Request 69753: CMake: Split part of libmesos into several smaller libraries.

2019-01-15 Thread Joseph Wu
-scheduler Thanks, Joseph Wu

Review Request 69751: CMake: Disabled "local" clusters in the scheduler libraries.

2019-01-15 Thread Joseph Wu
ired masters/agents. A rewrite like this would have the benefit of greater control over the example tests, which currently only check if the script succeeds. Once done, we can consider deleting the "local" cluster code entirely. Thanks, Joseph Wu

Re: Review Request 69750: CMake: Changed linkage of mesos-tcp-connect.

2019-01-15 Thread Joseph Wu
erated e-mail. To reply, visit: https://reviews.apache.org/r/69750/#review212033 ------- On Jan. 15, 2019, 12:01 p.m., Joseph Wu wrote: > > --- > This is an automatica

Review Request 69749: CMake: Cleaned up a block of platform-specific sources.

2019-01-15 Thread Joseph Wu
f42a4a6bda7ebb0af05df051bd5f07fbef33bf6d src/slave/containerizer/mesos/CMakeLists.txt 92f4a49fdab43bb6767021e0332e2eaa205b0fec Diff: https://reviews.apache.org/r/69749/diff/1/ Testing --- cmake --build . --target tests On OSX and Windows. Thanks, Joseph Wu

Review Request 69750: CMake: Changed linkage of mesos-tcp-connect.

2019-01-15 Thread Joseph Wu
. --target mesos-tcp-connect Thanks, Joseph Wu

Re: Review Request 69656: Fixed test `MesosContainerizerSlaveRecoveryTest.ResourceStatistics`.

2019-01-14 Thread Joseph Wu
arting); EXPECT_EQ(TASK_STARTING, statusStarting->state()); ``` - Joseph Wu On Jan. 2, 2019, 9:16 p.m., Meng Zhu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revie

Re: Review Request 69708: Fixed gRPC CMake build issue on Ubuntu 14.04.

2019-01-14 Thread Joseph Wu
n will work even if the "tweak" component of the version does not match. (i.e. if `OPENSSL_VERSION` is "1.0.1s") This is because CMake only performs integer comparisons when looking at versions, but OpenSSL denotes tweaks via letters (and these are therefore ignored by CMake).

Re: Review Request 69735: Fixed maintenance causes machines not in schedule rescinding offers.

2019-01-14 Thread Joseph Wu
/r/65366/ The patch is a bit old, but could be re-used if necessary. - Joseph Wu On Jan. 13, 2019, 7:34 p.m., fei long wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 69721: Broke up `SSLTest.ProtocolMismatch` into smaller tests.

2019-01-14 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69721/#review211958 --- Ship it! Ship It! - Joseph Wu On Jan. 11, 2019, 3:22 a.m

Re: Review Request 69720: Made `SSLTest` an unparameterized test suite.

2019-01-14 Thread Joseph Wu
g those tests down) - Joseph Wu On Jan. 11, 2019, 3:22 a.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 69584: Relaxed matching criteria for test filters.

2018-12-18 Thread Joseph Wu
> On Dec. 18, 2018, 10:44 a.m., Meng Zhu wrote: > > Not quite sure about the false positive issue: > > > > "This change is also safe regarding false positives, since our > > naming conventions forbid the matched strings from appearing > > naturally in any test name." > > > > Ah, I wasn't aware

Re: Review Request 69436: Fixed flaky check in cluster::Slave destructor.

2018-12-14 Thread Joseph Wu
Full log: console Armand, did you accidentally use your own reviewboard credentials in one of these scripts? - Joseph --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69436/#review211329

Re: Review Request 69474: Added tests for agent/executor heartbeating.

2018-12-10 Thread Joseph Wu
check src/mesos-tests --gtest_filter="*Heartbeat*" --verbose --gtest_repeat=-1 --gtest_break_on_failure ``` Thanks, Joseph Wu

Re: Review Request 69473: Added heartbeaters for agent and HTTP executors.

2018-12-10 Thread Joseph Wu
edf7269d4057ec8c95bb54c855210ad00d002a50 src/slave/slave.cpp e13b955ffd92a8872dd513c006e96bd72e298c85 Diff: https://reviews.apache.org/r/69473/diff/5/ Changes: https://reviews.apache.org/r/69473/diff/4-5/ Testing --- make Thanks, Joseph Wu

Re: Review Request 69473: Added heartbeaters for agent and HTTP executors.

2018-12-10 Thread Joseph Wu
--------- On Dec. 7, 2018, 2:17 p.m., Joseph Wu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69473/ >

Re: Review Request 69514: Added gauge metric for operator event stream subscribers.

2018-12-10 Thread Joseph Wu
failure ``` Thanks, Joseph Wu

Re: Review Request 69472: Refactored master and agent streaming connections.

2018-12-10 Thread Joseph Wu
nks, Joseph Wu

Re: Review Request 69474: Added tests for agent/executor heartbeating.

2018-12-10 Thread Joseph Wu
is is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69474/#review211143 ------- On Dec. 7, 2018, 2:18 p.m., Joseph Wu wrote: > > --- > This is an

Re: Review Request 69473: Added heartbeaters for agent and HTTP executors.

2018-12-10 Thread Joseph Wu
le.com/protocol-buffers/docs/proto3#enum - Joseph --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69473/#review211142 ----------- On Dec. 7, 2018, 2:17 p.m., Joseph Wu wrote: > > -

Re: Review Request 69474: Added tests for agent/executor heartbeating.

2018-12-07 Thread Joseph Wu
tbeat*" --verbose --gtest_repeat=-1 --gtest_break_on_failure ``` Thanks, Joseph Wu

Re: Review Request 69473: Added heartbeaters for agent and HTTP executors.

2018-12-07 Thread Joseph Wu
Diff: https://reviews.apache.org/r/69473/diff/4/ Changes: https://reviews.apache.org/r/69473/diff/3-4/ Testing --- make Thanks, Joseph Wu

Re: Review Request 69514: Added gauge metric for operator event stream subscribers.

2018-12-05 Thread Joseph Wu
est_filter="*MaxEventStreamSubscribers*" --gtest_repeat=-1 --gtest_break_on_failure ``` Thanks, Joseph Wu

Re: Review Request 69474: Added tests for agent/executor heartbeating.

2018-12-05 Thread Joseph Wu
Diff: https://reviews.apache.org/r/69474/diff/4/ Changes: https://reviews.apache.org/r/69474/diff/3-4/ Testing --- ``` cmake --build . --target check src/mesos-tests --gtest_filter="*Heartbeat*" --verbose --gtest_repeat=-1 --gtest_break_on_failure ``` Thanks, Joseph Wu

Re: Review Request 69473: Added heartbeaters for agent and HTTP executors.

2018-12-05 Thread Joseph Wu
ly put into a header somewhere. But we can discuss/do that in future. - Joseph --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69473/#review211070 --------

Re: Review Request 69473: Added heartbeaters for agent and HTTP executors.

2018-12-05 Thread Joseph Wu
://reviews.apache.org/r/69473/diff/2-3/ Testing --- make Thanks, Joseph Wu

Re: Review Request 69472: Refactored master and agent streaming connections.

2018-12-05 Thread Joseph Wu
ing connection. Thanks, Joseph Wu

Re: Review Request 69473: Added heartbeaters for agent and HTTP executors.

2018-12-05 Thread Joseph Wu
://reviews.apache.org/r/69473/diff/1-2/ Testing --- make Thanks, Joseph Wu

Re: Review Request 69472: Refactored master and agent streaming connections.

2018-12-05 Thread Joseph Wu
g/r/69472/diff/2/ Changes: https://reviews.apache.org/r/69472/diff/1-2/ Testing --- make The original plan was to use the same helper for the executor too, but of the Master, Framework, and Agent heartbeats, only the executor lacks a streaming connection. Thanks, Joseph Wu

Re: Review Request 69463: Added HEARTBEAT events and calls for the executor HTTP API.

2018-12-05 Thread Joseph Wu
rget mesos-protobufs Thanks, Joseph Wu

Review Request 69514: Added gauge metric for operator event stream subscribers.

2018-12-05 Thread Joseph Wu
reamSubscribers*" --gtest_repeat=-1 --gtest_break_on_failure ``` Thanks, Joseph Wu

Re: Review Request 69307: Changed master to hold subscribers in a circular buffer.

2018-12-05 Thread Joseph Wu
edde48a4b4b46c9f47bc44de389c97b77322b8e8 Diff: https://reviews.apache.org/r/69307/diff/3/ Changes: https://reviews.apache.org/r/69307/diff/2-3/ Testing --- ``` make check src/mesos-tests --gtest_filter="*MaxEventStreamSubscribers*" --gtest_repeat=-1 --gtest_break_on_failure ``` Thanks, Joseph Wu

Re: Review Request 69307: Changed master to hold subscribers in a circular buffer.

2018-12-05 Thread Joseph Wu
iber leak in the first place. - Joseph --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69307/#review211032 --- On Nov. 30, 2018, 6:49 p.m

Re: Review Request 68795: Added deduplication for read-only master requests.

2018-12-04 Thread Joseph Wu
(patched) <https://reviews.apache.org/r/68795/#comment295882> Nit: Remove this comment. And similarly above sections. - Joseph Wu On Nov. 21, 2018, 5:20 p.m., Benno Evers wrote: > > --- > This is an automatically generated e

Re: Review Request 69307: Changed master to hold subscribers in a circular buffer.

2018-11-30 Thread Joseph Wu
: https://reviews.apache.org/r/69307/diff/1-2/ Testing --- ``` make check src/mesos-tests --gtest_filter="*MaxEventStreamSubscribers*" --gtest_repeat=-1 --gtest_break_on_failure ``` Thanks, Joseph Wu

Re: Review Request 69307: Changed master to hold subscribers in a circular buffer.

2018-11-30 Thread Joseph Wu
Master::exited(id::UUID)` function outside of the operator event stream functions. So it may be fine to remove this line in favor of logging when the limit is reached. - Joseph Wu On Nov. 26, 2018, 3:40 p.m., Joseph Wu

Re: Review Request 69064: Added unit tests for Master HTTP endpoints.

2018-11-30 Thread Joseph Wu
t onto the master's queue before we un-gate the Authorizer. ``` // Unblock the BlockingAuthorizer. // This should trigger all the deferals onto the master from the Authorizer's // thread. When this future completes, the master's queue should be full // of batched request

Re: Review Request 68795: Added deduplication for read-only master requests.

2018-11-29 Thread Joseph Wu
f the stream, and neither would get a cohesive response (or if lucky, one reader would read everything, and the other reader(s) would get nothing). - Joseph Wu On Nov. 21, 2018, 5:20 p.m., Benno Evers wrote: > > --- > This is an au

Re: Review Request 69071: Narrowed interface of `ReadOnlyHandler` members.

2018-11-29 Thread Joseph Wu
t; > (Updated Nov. 21, 2018, 5:19 p.m.) > > > Review request for mesos, Alexander Rukletsov and Joseph Wu. > > > Repository: mesos > > > Description > --- > > Previously, the members of `ReadOnlyHandler` would take a full `Request` as > param

Re: Review Request 69474: Added tests for agent/executor heartbeating.

2018-11-29 Thread Joseph Wu
_repeat=-1 --gtest_break_on_failure ``` Thanks, Joseph Wu

Re: Review Request 69411: Added new interface for constructing `cluster::Master`.

2018-11-29 Thread Joseph Wu
the master's, because there are several dependency chains in the agent. - Joseph Wu On Nov. 21, 2018, 5:21 p.m., Benno Evers wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://r

Re: Review Request 69473: Added heartbeaters for agent and HTTP executors.

2018-11-28 Thread Joseph Wu
(patched) <https://reviews.apache.org/r/69473/#comment295771> Note: Lacking this switch case will not cause crashes (`UNREACHABLE`) on older agents/executors because the new HEARTBEAT protobuf will be parsed as the `UNKNOWN` type. - Joseph Wu On Nov. 28, 2018, 4 p.m., Joseph Wu

Review Request 69473: Added heartbeaters for agent and HTTP executors.

2018-11-28 Thread Joseph Wu
edf7269d4057ec8c95bb54c855210ad00d002a50 src/slave/slave.cpp 858b78620e1ef33f3587d0bd95a684917aaf5bbb Diff: https://reviews.apache.org/r/69473/diff/1/ Testing --- make Thanks, Joseph Wu

Review Request 69474: WIP: Added tests for agent/executor heartbeating.

2018-11-28 Thread Joseph Wu
alls` test is still a bit flaky (roughly one failure in ~50,000 iterations), so I'm marking this test as WIP. Thanks, Joseph Wu

Review Request 69472: Moved heartbeating helper out of master.

2018-11-28 Thread Joseph Wu
: https://reviews.apache.org/r/69472/diff/1/ Testing --- make The original plan was to use the same helper for the executor too, but of the Master, Framework, and Agent heartbeats, only the executor lacks a streaming connection. Thanks, Joseph Wu

Re: Review Request 69307: Changed master to hold subscribers in a circular buffer.

2018-11-27 Thread Joseph Wu
- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69307/#review210891 --- On Nov. 26, 2018, 3:40 p.m., Joseph Wu wrote: > > -

Review Request 69463: Added HEARTBEAT events and calls for the executor HTTP API.

2018-11-27 Thread Joseph Wu
1/executor/executor.proto b2ef325cf6a72137854355d541889c7c6ae7c230 Diff: https://reviews.apache.org/r/69463/diff/1/ Testing --- cmake --build . --target mesos-protobufs Thanks, Joseph Wu

Re: Review Request 69436: Fixed flaky check in cluster::Slave destructor.

2018-11-26 Thread Joseph Wu
- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69436/ > ------- > > (Updated Nov. 22, 2018, 11:43 a.m.) > > > Review request for mesos, Andr

Re: Review Request 69273: Fixed flaky agent reconfiguration test.

2018-11-14 Thread Joseph Wu
after // detecting the master, even when the clock is paused. ``` - Joseph Wu On Nov. 14, 2018, 7:23 a.m., Benno Evers wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 69171: Added validation of cache files to the URI Fetcher.

2018-11-14 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69171/#review210558 --- Ship it! Ship It! - Joseph Wu On Oct. 29, 2018, 3:33 p.m

Re: Review Request 69311: Enabled parallel test runner to cmake build.

2018-11-14 Thread Joseph Wu
, but you get the > > idea) > > > > Of course, if CMake already does the correct thing anyways, disregard > > this issue. > > Joseph Wu wrote: > https://cmake.org/cmake/help/v3.8/prop_test/ENVIRONMENT.html > > Cmake should overwrite the environment

Re: Review Request 69311: Enabled parallel test runner to cmake build.

2018-11-13 Thread Joseph Wu
ed e-mail. To reply, visit: https://reviews.apache.org/r/69311/#review210500 --- On Nov. 10, 2018, 4:01 p.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69311/ > -

Re: Review Request 69273: Fixed flaky agent reconfiguration test.

2018-11-13 Thread Joseph Wu
> On Nov. 7, 2018, 1:44 p.m., Joseph Wu wrote: > > src/tests/slave_recovery_tests.cpp > > Line 4827 (original), 4841-4845 (patched) > > <https://reviews.apache.org/r/69273/diff/1/?file=2104774#file2104774line4842> > > > > There is always a non

Review Request 69307: Changed master to hold subscribers in a circular buffer.

2018-11-09 Thread Joseph Wu
--gtest_filter="*MaxEventStreamSubscribers*" --gtest_repeat=-1 --gtest_break_on_failure ``` Thanks, Joseph Wu

Review Request 69302: Added optional argument to Master operator SUBSCRIBE call.

2018-11-08 Thread Joseph Wu
- include/mesos/master/master.proto 80bd7c43cbb6d7df0dbd1c162cf4dda48f0e2e30 include/mesos/v1/master/master.proto cd41a7e8dc98753b5d2b8f93d92114fe97463636 Diff: https://reviews.apache.org/r/69302/diff/1/ Testing --- See last review in chain. Thanks, Joseph Wu

Review Request 69303: Implemented an optional time-to-live on subscriber connections.

2018-11-08 Thread Joseph Wu
on_failure ``` Thanks, Joseph Wu

Re: Review Request 69272: Clarified some comments about the usage of offer filters.

2018-11-07 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69272/#review210382 --- Ship it! Ship It! - Joseph Wu On Nov. 7, 2018, 10:40 a.m

Re: Review Request 69273: Fixed flaky agent reconfiguration test.

2018-11-07 Thread Joseph Wu
way to wait for the agent to detect the master, and then advance the clock. Instead, try setting `slaveFlags.registration_backoff_factor = Seconds(0);`. I think that should bypass this small subscription delay. - Joseph Wu On Nov. 7, 2018, 10:40 a.m., Benno

Re: Review Request 69278: Added hierchical allocator benchmarks to the cmake build.

2018-11-07 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69278/#review210379 --- Ship it! Ship It! - Joseph Wu On Nov. 7, 2018, 1:17 p.m

Re: Review Request 69276: Fixed flakiness in `FsTest.Used`.

2018-11-07 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69276/#review210378 --- Ship it! Ship It! - Joseph Wu On Nov. 7, 2018, 1:16 p.m

Review Request 69267: Fixed flaky SchedulerTest.MasterFailover.

2018-11-06 Thread Joseph Wu
/ Testing --- make check GLOG_v=1 src/mesos-tests --gtest_filter="*SchedulerTest.MasterFailover*" --gtest_repeat=-1 --gtest_break_on_failure --verbose Thanks, Joseph Wu

Re: Review Request 69140: Allowed for unbundled libarchive on cmake builds.

2018-10-30 Thread Joseph Wu
> On Oct. 24, 2018, 11:21 a.m., Joseph Wu wrote: > > We could probably do away with some of the double-negatives (i.e. `not > > UNBUNDLED` -> `BUNDLED`) in the new variable names and logic. > > Till Toenshoff wrote: > That one I would prefer to change, if need

Re: Review Request 69140: Allowed for unbundled libarchive on cmake builds.

2018-10-30 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69140/#review210187 --- Ship it! Ship It! - Joseph Wu On Oct. 30, 2018, 1:20 p.m

Re: Review Request 69216: Added small style fix-ups for libevent unbundling on CMake builds.

2018-10-30 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69216/#review210185 --- Ship it! Ship It! - Joseph Wu On Oct. 30, 2018, 1:19 p.m

Re: Review Request 69205: Fixed FetcherTest.DuplicateFileURI on OSX.

2018-10-30 Thread Joseph Wu
// be considered identical. ``` - Joseph --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69205/#review210177 -------

Review Request 69205: Fixed FetcherTest.DuplicateFileURI on OSX.

2018-10-29 Thread Joseph Wu
stdlib. Diffs - src/common/type_utils.cpp 33d63809b61a18e03ff745c88f024c71dd221ca2 src/v1/mesos.cpp 9b2df2dd798dff24a91a2604ab53c7fbb5ecfbcf Diff: https://reviews.apache.org/r/69205/diff/1/ Testing --- make check Thanks, Joseph Wu

Re: Review Request 69203: Fixed LongLivedDefaultExecutorRestart GC test.

2018-10-29 Thread Joseph Wu
case the agent actor leaks. - Joseph --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69203/#review210153 --- On Oct

Re: Review Request 69146: Made fetcher tests more robust by using the test sandbox.

2018-10-29 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69146/#review210143 --- Ship it! Ship It! - Joseph Wu On Oct. 25, 2018, 12:34 p.m

Review Request 69203: Fixed LongLivedDefaultExecutorRestart GC test.

2018-10-29 Thread Joseph Wu
4d94430b9de57c20f0f7fe7001a543dbf3a56f1d Diff: https://reviews.apache.org/r/69203/diff/1/ Testing --- make check Thanks, Joseph Wu

Re: Review Request 69194: Fixed test `MesosContainerizerSlaveRecoveryTest.ResourceStatistics`.

2018-10-26 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69194/#review210121 --- Ship it! Ship It! - Joseph Wu On Oct. 26, 2018, 3:34 p.m

Re: Review Request 69178: Fixed test `MasterTestPrePostReservationRefinement.LaunchGroup`.

2018-10-26 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69178/#review210119 --- Ship it! Ship It! - Joseph Wu On Oct. 26, 2018, 4 p.m

Re: Review Request 69172: Added `FetcherCacheTest.LocalCachedMissing` test.

2018-10-26 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69172/#review210117 --- Ship it! Ship It! - Joseph Wu On Oct. 25, 2018, 1:47 p.m

Re: Review Request 69171: Added validation of cache files to the URI Fetcher.

2018-10-26 Thread Joseph Wu
future is ready (i.e the file has been downloaded). ``` - Joseph Wu On Oct. 25, 2018, 1:47 p.m., Andrei Budnik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:/

Re: Review Request 69178: Fixed test `MasterTestPrePostReservationRefinement.LaunchGroup`.

2018-10-26 Thread Joseph Wu
``` src/tests/master_tests.cpp Lines 9588-9598 (original), 9588-9614 (patched) <https://reviews.apache.org/r/69178/#comment294747> Given the above suggestion, this can be replaced with: ``` AWAIT_READY(startingUpdate); AWAIT_READY(runningUpdate); ``` - Joseph Wu On

Review Request 69186: Added tests for master SUBSCRIBE heartbeating.

2018-10-26 Thread Joseph Wu
https://reviews.apache.org/r/69186/diff/1/ Testing --- ``` make check src/mesos-tests --gtest_filter="*MasterAPITest.*Heartbeats*" --gtest_repeat=1000 --gtest_break_on_failure ``` Thanks, Joseph Wu

Re: Review Request 69176: Fixed flaky test `SchedulerHttpApiTest.UpdatePidToHttpScheduler`.

2018-10-26 Thread Joseph Wu
gotten your commit bits?), or shall I? - Joseph Wu On Oct. 25, 2018, 4:11 p.m., Meng Zhu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 69180: Enabled streaming requests on the master /api/v1 endpoint.

2018-10-26 Thread Joseph Wu
://reviews.apache.org/r/69180/diff/1-2/ Testing --- make See later in chain. Thanks, Joseph Wu

Review Request 69184: Marked internal::recordio::Reader as non-copyable/assignable.

2018-10-25 Thread Joseph Wu
in chain. Thanks, Joseph Wu

Review Request 69185: Added streaming header support for /api/v1 SUBSCRIBE.

2018-10-25 Thread Joseph Wu
75ab6ea422a77e25049cd6afe007507d11650a06 src/master/master.hpp ea7e9242b62fe6c2cc0e717f9a9f2f0c1cc0a390 Diff: https://reviews.apache.org/r/69185/diff/1/ Testing --- make See later in chain. Thanks, Joseph Wu

Review Request 69183: Added optional heartbeat monitoring to the master /api/v1.

2018-10-25 Thread Joseph Wu
://reviews.apache.org/r/69183/diff/1/ Testing --- make See later in chain. Thanks, Joseph Wu

Review Request 69182: Moved Master::Subscribers::Subscriber constructor into .cpp file.

2018-10-25 Thread Joseph Wu
0c95c438975efd949cbf86f7d8bfea940c20a43a Diff: https://reviews.apache.org/r/69182/diff/1/ Testing --- make See later in chain. Thanks, Joseph Wu

Review Request 69181: Passed streaming decoder from master /api/v1 to master actor.

2018-10-25 Thread Joseph Wu
0c95c438975efd949cbf86f7d8bfea940c20a43a Diff: https://reviews.apache.org/r/69181/diff/1/ Testing --- make See later in chain. Thanks, Joseph Wu

Review Request 69180: Enabled streaming requests on the master /api/v1 endpoint.

2018-10-25 Thread Joseph Wu
: https://reviews.apache.org/r/69180/diff/1/ Testing --- make See later in chain. Thanks, Joseph Wu

Re: Review Request 69146: Made fetcher tests more robust by using the test sandbox.

2018-10-24 Thread Joseph Wu
> On Oct. 24, 2018, 4:31 p.m., Till Toenshoff wrote: > > src/tests/fetcher_tests.cpp > > Lines 105-106 (patched) > > > > > > While this solution appears to be the most efficient it also is not > > entirely

Re: Review Request 69140: Allowed for unbundled libarchive on cmake builds.

2018-10-24 Thread Joseph Wu
OOT_DIR` variable doesn't need to be inside this conditional. The variable would have no effect when we are using a bundled library, and would still be set/read on using an installed library. - Joseph Wu On Oct. 24, 2018, 5:25 a.m., Till Toenshoff wrote: > > ---

Re: Review Request 68543: Added stout helper to parse strings to protobuf messages.

2018-08-28 Thread Joseph Wu
) <https://reviews.apache.org/r/68543/#comment291801> Using `flags::parse` will include some deprecated behavior (if the string starts with `"/"`, we will attempt to read a location on disk). `JSON::parse` would be a better choice. - Joseph Wu On Aug. 28, 2018, 10:25 a.m.,

Re: Review Request 68065: Enabled garbage collection of terminated tasks' metadata.

2018-08-22 Thread Joseph Wu
Diff: https://reviews.apache.org/r/68065/diff/2/ Changes: https://reviews.apache.org/r/68065/diff/1-2/ Testing --- See last patch in chain. Thanks, Joseph Wu

Re: Review Request 68095: Modified MesosContainerizer to GC nested container sandboxes.

2018-08-22 Thread Joseph Wu
/containerizer.cpp c38bfacef6a0c8e3b8703c64b40d6d428c9013fe Diff: https://reviews.apache.org/r/68095/diff/2/ Changes: https://reviews.apache.org/r/68095/diff/1-2/ Testing --- See last patch in chain. Thanks, Joseph Wu

Re: Review Request 68066: Shared GC actor between Agent and MesosContainerizer.

2018-08-22 Thread Joseph Wu
/tests/containerizer/volume_secret_isolator_tests.cpp 8b11c6f789c60e4d3ceda164f1523e9791123450 Diff: https://reviews.apache.org/r/68066/diff/3/ Changes: https://reviews.apache.org/r/68066/diff/2-3/ Testing --- See last patch in chain. Thanks, Joseph Wu

Re: Review Request 68067: Added flag to control GC-ing of nested container sandboxes.

2018-08-22 Thread Joseph Wu
bff194fef98f38a8b91d86ef4ec99889d0cfe31f src/slave/flags.cpp e017f3921a0bccc03f6ef639a04163bf7fc4e79b src/slave/http.cpp 1b6d266a1a7821c9de6871cbca43317b3c392a32 Diff: https://reviews.apache.org/r/68067/diff/4/ Changes: https://reviews.apache.org/r/68067/diff/3-4/ Testing --- See last patch in chain. Thanks, Joseph Wu

Re: Review Request 68068: Added tests for task metadata GC using the default executor.

2018-08-22 Thread Joseph Wu
...) Thanks, Joseph Wu

Re: Review Request 68095: Modified MesosContainerizer to GC nested container sandboxes.

2018-08-06 Thread Joseph Wu
ent290032> Need to unschedule directories for GC when they are removed. It's possible that ContainerIDs will be reused after removal, and if we don't unschedule, a reused ContainerID/sandbox could be GC'd while it is in use. - Joseph Wu On July 27, 2018, 5:22 p.m., Jos

Re: Review Request 68092: CMake: Always build gRPC in Mesos.

2018-07-27 Thread Joseph Wu
> On July 27, 2018, 2:08 p.m., Mesos Reviewbot Windows wrote: > > FAIL: Mesos binaries failed to build. > > > > Reviews applied: `['68091', '68074', '68092']` > > > > Failed command: `cmake.exe --build . --config Release -- /maxcpucount` > > > > All the build artifacts available at: > >

Re: Review Request 68067: Added flag to control GC-ing of nested container sandboxes.

2018-07-27 Thread Joseph Wu
atically generated e-mail. To reply, visit: https://reviews.apache.org/r/68067/#review206538 ----------- On July 27, 2018, 5:22 p.m., Joseph Wu wrote: > > --- > This is an auto

Review Request 68095: Modified MesosContainerizer to GC nested container sandboxes.

2018-07-27 Thread Joseph Wu
--- See last patch in chain. Thanks, Joseph Wu

Re: Review Request 68067: Added flag to control GC-ing of nested container sandboxes.

2018-07-27 Thread Joseph Wu
58cdc0f1100fe244e5bf1036e1ccf39478d5d478 Diff: https://reviews.apache.org/r/68067/diff/2/ Changes: https://reviews.apache.org/r/68067/diff/1-2/ Testing --- See last patch in chain. Thanks, Joseph Wu

Re: Review Request 68073: Fixed rapidjson cmake compilation.

2018-07-26 Thread Joseph Wu
. - Joseph Wu On July 26, 2018, 4:48 p.m., Chun-Hung Hsiao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

  1   2   3   4   5   6   7   8   9   10   >