Re: Review Request 68591: Added allocator benchmark for non-homogeneous framework profiles.

2018-09-14 Thread Kapil Arya
dy checked > > `frameworkTasksLaunched[frameworkId] < frameworkProfile.maxTasksPerInstance` > > Kapil Arya wrote: > This is tracking total tasks across all frameworks as opposed to total > tasks per framework. Fixed now. - Kapil -

Re: Review Request 68591: Added allocator benchmark for non-homogeneous framework profiles.

2018-09-14 Thread Kapil Arya
) ``` Thanks, Kapil Arya

Re: Review Request 68591: Added allocator benchmark for non-homogeneous framework profiles.

2018-09-14 Thread Kapil Arya
ail. To reply, visit: https://reviews.apache.org/r/68591/#review208632 --- On Sept. 14, 2018, 3:17 p.m., Kapil Arya wrote: > > --- > This is an automatically generated e-ma

Re: Review Request 68548: Introduced a base class for writing allocator benchmarks.

2018-09-14 Thread Kapil Arya
ted during initialize() call. - Kapil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68548/#review208633 --- On Sept

Re: Review Request 68591: Added allocator benchmark for non-homogeneous framework profiles.

2018-09-14 Thread Kapil Arya
] HierarchicalAllocations_BENCHMARK_TestBase.Allocations (30055 ms) ``` Thanks, Kapil Arya

Re: Review Request 68548: Introduced a base class for writing allocator benchmarks.

2018-09-14 Thread Kapil Arya
/ Testing --- Thanks, Kapil Arya

Re: Review Request 68548: Introduced a base class for writing allocator benchmarks.

2018-09-14 Thread Kapil Arya
/ Testing --- Thanks, Kapil Arya

Re: Review Request 68591: Added allocator benchmark for non-homogeneous framework profiles.

2018-09-14 Thread Kapil Arya
, Kapil Arya

Re: Review Request 68591: Added allocator benchmark for non-homogeneous framework profiles.

2018-09-13 Thread Kapil Arya
, Kapil Arya

Re: Review Request 68591: Added allocator benchmark for non-homogeneous framework profiles.

2018-09-13 Thread Kapil Arya
, Kapil Arya

Re: Review Request 68548: Introduced a base class for writing allocator benchmarks.

2018-09-13 Thread Kapil Arya
/ Testing --- Thanks, Kapil Arya

Re: Review Request 68591: Added allocator benchmark for non-homogeneous framework profiles.

2018-09-13 Thread Kapil Arya
eviews.apache.org/r/68591/diff/2/?file=2088300#file2088300line436> > > > > in << ... << allocation rounds/cycles That was a weird mix of wordings. I have updated the patch to address some of that. - Kapil ------

Re: Review Request 68591: Added allocator benchmark for non-homogeneous framework profiles.

2018-09-13 Thread Kapil Arya
, Kapil Arya

Re: Review Request 68548: Introduced a base class for writing allocator benchmarks.

2018-09-13 Thread Kapil Arya
locator/mesos/hierarchical.cpp#L534 - Kapil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68548/#review208530 ------- O

Re: Review Request 68548: Introduced a base class for writing allocator benchmarks.

2018-09-13 Thread Kapil Arya
: https://reviews.apache.org/r/68548/diff/5-6/ Testing --- Thanks, Kapil Arya

Re: Review Request 68591: Added allocator benchmark for non-homogeneous framework profiles.

2018-09-11 Thread Kapil Arya
1mins Resource statistics: Cluster capacity: cpus:5120; mem:3904 Cluster allocation: cpus:1093.4; mem:1688000 Target allocation: cpus:2370; mem:1740 [ OK ] HierarchicalAllocations_BENCHMARK_TestBase.Allocations (60321 ms) ``` Thanks, Kapil Arya

Re: Review Request 68548: Introduced a base class for writing allocator benchmarks.

2018-09-11 Thread Kapil Arya
- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68548/#review208321 --- On Sept. 11, 2018, 3:15 p.m., Kapil Arya wrote: > > ---

Re: Review Request 68548: Introduced a base class for writing allocator benchmarks.

2018-09-11 Thread Kapil Arya
ps://reviews.apache.org/r/68548/#review208321 ------- On Sept. 11, 2018, 3:15 p.m., Kapil Arya wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 68591: Added allocator benchmark for non-homogeneous framework profiles.

2018-09-11 Thread Kapil Arya
, Kapil Arya

Re: Review Request 68548: Introduced a base class for writing allocator benchmarks.

2018-09-11 Thread Kapil Arya
/hierarchical_allocator_benchmarks.cpp PRE-CREATION Diff: https://reviews.apache.org/r/68548/diff/5/ Changes: https://reviews.apache.org/r/68548/diff/4-5/ Testing --- Thanks, Kapil Arya

Re: Review Request 68613: Replaced javah with `javac -c` for newer JDKs.

2018-09-03 Thread Kapil Arya
d84581823708cdece68d52bdc023e01d72645bf8 src/Makefile.am cf0cf22b3f582d3d4427f13288af3845aef45263 Diff: https://reviews.apache.org/r/68613/diff/3/ Changes: https://reviews.apache.org/r/68613/diff/2-3/ Testing --- Thanks, Kapil Arya

Re: Review Request 68613: Replaced javah with `javac -c` for newer JDKs.

2018-09-03 Thread Kapil Arya
) - configure.ac d84581823708cdece68d52bdc023e01d72645bf8 src/Makefile.am cf0cf22b3f582d3d4427f13288af3845aef45263 Diff: https://reviews.apache.org/r/68613/diff/2/ Changes: https://reviews.apache.org/r/68613/diff/1-2/ Testing --- Thanks, Kapil Arya

Re: Review Request 68612: Consolidated Java header targets using makefile patterns.

2018-09-03 Thread Kapil Arya
cf0cf22b3f582d3d4427f13288af3845aef45263 Diff: https://reviews.apache.org/r/68612/diff/2/ Changes: https://reviews.apache.org/r/68612/diff/1-2/ Testing --- Thanks, Kapil Arya

Re: Review Request 68610: Updated libjvm search logic for newer openjdk versions.

2018-09-03 Thread Kapil Arya
for newer openjdk versions. Diffs (updated) - configure.ac d84581823708cdece68d52bdc023e01d72645bf8 Diff: https://reviews.apache.org/r/68610/diff/2/ Changes: https://reviews.apache.org/r/68610/diff/1-2/ Testing --- Thanks, Kapil Arya

Review Request 68612: Consolidated Java header targets using makefile patterns.

2018-09-03 Thread Kapil Arya
://issues.apache.org/jira/browse/MESOS-8921 Repository: mesos Description --- Consolidated Java header targets using makefile patterns. Diffs - src/Makefile.am cf0cf22b3f582d3d4427f13288af3845aef45263 Diff: https://reviews.apache.org/r/68612/diff/1/ Testing --- Thanks, Kapil

Review Request 68610: Updated libjvm.so search logic for newer openjdk versions.

2018-09-03 Thread Kapil Arya
://issues.apache.org/jira/browse/MESOS-8921 Repository: mesos Description --- Updated libjvm.so search logic for newer openjdk versions. Diffs - configure.ac d84581823708cdece68d52bdc023e01d72645bf8 Diff: https://reviews.apache.org/r/68610/diff/1/ Testing --- Thanks, Kapil

Review Request 68613: Replaced javah with `javac -c` for newer JDKs.

2018-09-03 Thread Kapil Arya
cf0cf22b3f582d3d4427f13288af3845aef45263 Diff: https://reviews.apache.org/r/68613/diff/1/ Testing --- Thanks, Kapil Arya

Review Request 68611: Fixed maven invocation with proper JAVA_HOME.

2018-09-03 Thread Kapil Arya
JAVA_HOME to set the environment variable when invoking maven. Diffs - src/Makefile.am cf0cf22b3f582d3d4427f13288af3845aef45263 Diff: https://reviews.apache.org/r/68611/diff/1/ Testing --- Thanks, Kapil Arya

Review Request 68591: Added allocator benchmark for non-homogeneous framework profiles.

2018-08-31 Thread Kapil Arya
/hierarchical_allocator_benchmarks.cpp PRE-CREATION Diff: https://reviews.apache.org/r/68591/diff/1/ Testing --- Make check with the new test. Thanks, Kapil Arya

Review Request 68549: Added pause and resume helpers to the allocator.

2018-08-28 Thread Kapil Arya
e3adb5dbb968684f6f63477f56a6abf4f288c896 src/tests/allocator.hpp 1d844464741b3f40890198e2503593c76de870df Diff: https://reviews.apache.org/r/68549/diff/1/ Testing --- Thanks, Kapil Arya

Review Request 68548: Added allocator benchmark test harness.

2018-08-28 Thread Kapil Arya
/hierarchical_allocator_benchmarks.cpp PRE-CREATION Diff: https://reviews.apache.org/r/68548/diff/1/ Testing --- Thanks, Kapil Arya

Re: Review Request 68370: Updated Zookeeper patch to fix format error.

2018-08-16 Thread Kapil Arya
) - 3rdparty/zookeeper-3.4.8.patch edfc3b5cf20568ded024137e3d4f7ab2fe221c2d Diff: https://reviews.apache.org/r/68370/diff/2/ Changes: https://reviews.apache.org/r/68370/diff/1-2/ Testing --- Thanks, Kapil Arya

Review Request 68393: Fixed grpc compilation for directory paths with symlinks.

2018-08-16 Thread Kapil Arya
--- Automake variable `abs_builddir` doesn't resolve symlinks so we explicitly call `realpath` on grpc targets. Diffs - 3rdparty/Makefile.am 248d517874c2b34e98446d1e6724078c5c21708c Diff: https://reviews.apache.org/r/68393/diff/1/ Testing --- Thanks, Kapil Arya

Review Request 68370: Updated Zookeeper to fix `-Werror-format-overflow` error.

2018-08-15 Thread Kapil Arya
Description --- The patch is motivated from: https://github.com/apache/zookeeper/pull/559/ Diffs - 3rdparty/zookeeper-3.4.8.patch edfc3b5cf20568ded024137e3d4f7ab2fe221c2d Diff: https://reviews.apache.org/r/68370/diff/1/ Testing --- Thanks, Kapil Arya

Re: Review Request 67780: Removed incorrect symlink handling in archiver utility.

2018-06-28 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67780/#review205547 --- Ship it! Duh! - Kapil Arya On June 28, 2018, 9 p.m., Joseph

Re: Review Request 67680: Fixed archiver failure to extract hardlinks to another directory.

2018-06-20 Thread Kapil Arya
if it's too much. - Kapil Arya On June 20, 2018, 7:55 p.m., Joseph Wu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 67680: Fixed archiver failure to extract hardlinks to another directory.

2018-06-20 Thread Kapil Arya
) <https://reviews.apache.org/r/67680/#comment288098> Should we add a short comment on how the contents were generated? Basically, copy-paste commands from the Testing Done section of this RR? - Kapil Arya On June 20, 2018, 7:55 p.m., Joseph Wu

Re: Review Request 66229: Implemented UPDATE_FRAMEWORK call.

2018-05-09 Thread Kapil Arya
/diff/13/ Changes: https://reviews.apache.org/r/66229/diff/12-13/ Testing --- Thanks, Kapil Arya

Re: Review Request 66230: Added test for updating framework info.

2018-05-09 Thread Kapil Arya
/ Testing --- Thanks, Kapil Arya

Re: Review Request 66228: Added Call for updating framework info.

2018-05-09 Thread Kapil Arya
/scheduler/scheduler.proto fcfec5e417463103e98dd6917722b4fde41cac7c Diff: https://reviews.apache.org/r/66228/diff/9/ Changes: https://reviews.apache.org/r/66228/diff/8-9/ Testing --- Thanks, Kapil Arya

Review Request 67049: Modified Master::updateFramework to optionally return an Error.

2018-05-09 Thread Kapil Arya
c30cf082d9ddf2e5dd97e0d887d6d07d8e03cbd4 src/master/master.cpp c723a291ed8d219ced4492bc905ac6b52683ae47 Diff: https://reviews.apache.org/r/67049/diff/1/ Testing --- Thanks, Kapil Arya

Review Request 67048: Updated some Master functions to accept repeated fields.

2018-05-09 Thread Kapil Arya
c723a291ed8d219ced4492bc905ac6b52683ae47 Diff: https://reviews.apache.org/r/67048/diff/1/ Testing --- Thanks, Kapil Arya

Review Request 67047: Consolidated master framework validation at one place.

2018-05-09 Thread Kapil Arya
src/master/validation.cpp ac2e1bb8771841ec59b3bdcdeffb6c6230680d4d Diff: https://reviews.apache.org/r/67047/diff/1/ Testing --- Thanks, Kapil Arya

Re: Review Request 66872: Updated FrameworkInfo comparator.

2018-05-09 Thread Kapil Arya
://reviews.apache.org/r/66872/diff/3/ Changes: https://reviews.apache.org/r/66872/diff/2-3/ Testing --- Thanks, Kapil Arya

Re: Review Request 66230: Added test for adding/removing framework roles.

2018-05-04 Thread Kapil Arya
749420a23bc1a3873bd4d5aee56e78cff79bb1af Diff: https://reviews.apache.org/r/66230/diff/8/ Changes: https://reviews.apache.org/r/66230/diff/7-8/ Testing --- Thanks, Kapil Arya

Re: Review Request 66229: Implemented UPDATE_FRAMEWORK call.

2018-05-02 Thread Kapil Arya
7c129ceb929596acbb64d37025e055661277e6bf src/master/validation.cpp ac2e1bb8771841ec59b3bdcdeffb6c6230680d4d Diff: https://reviews.apache.org/r/66229/diff/9/ Changes: https://reviews.apache.org/r/66229/diff/8-9/ Testing --- Thanks, Kapil Arya

Re: Review Request 66872: Updated FrameworkInfo comparator.

2018-05-02 Thread Kapil Arya
e1aef8a9625a805e7ad2dfad37bfeedee82f160d src/v1/mesos.cpp 9b2df2dd798dff24a91a2604ab53c7fbb5ecfbcf Diff: https://reviews.apache.org/r/66872/diff/1/ Testing --- Thanks, Kapil Arya

Review Request 66872: Updated FrameworkInfo comparator.

2018-04-30 Thread Kapil Arya
/common/type_utils.cpp 33d63809b61a18e03ff745c88f024c71dd221ca2 src/tests/master_allocator_tests.cpp e1aef8a9625a805e7ad2dfad37bfeedee82f160d src/v1/mesos.cpp 9b2df2dd798dff24a91a2604ab53c7fbb5ecfbcf Diff: https://reviews.apache.org/r/66872/diff/1/ Testing --- Thanks, Kapil Arya

Review Request 66864: Updated FrameworkInfo comparator.

2018-04-28 Thread Kapil Arya
--- Thanks, Kapil Arya

Re: Review Request 66746: Replaced protobuf-specific comparators with MessageDifferencer.

2018-04-24 Thread Kapil Arya
specific > > types we want to check. Do we need the `Message&` level equality operator? > > Kapil Arya wrote: > Right now we don't have any differing equality semantics for any of the > messages. There are four non-standard semantics are captured in the generic > m

Re: Review Request 66746: Replaced protobuf-specific comparators with MessageDifferencer.

2018-04-24 Thread Kapil Arya
- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66746/#review201799 --- On April 20, 2018, 4:19 p.m., Kapil Arya wrote: > > ---

Re: Review Request 66230: Added test for adding/removing framework roles.

2018-04-20 Thread Kapil Arya
://reviews.apache.org/r/66230/diff/6/ Changes: https://reviews.apache.org/r/66230/diff/5-6/ Testing --- Thanks, Kapil Arya

Re: Review Request 66229: Implemented UPDATE_FRAMEWORK call.

2018-04-20 Thread Kapil Arya
/master/validation.cpp ac2e1bb8771841ec59b3bdcdeffb6c6230680d4d Diff: https://reviews.apache.org/r/66229/diff/6/ Changes: https://reviews.apache.org/r/66229/diff/5-6/ Testing --- Thanks, Kapil Arya

Re: Review Request 66228: Added Call for updating framework info.

2018-04-20 Thread Kapil Arya
/v1/scheduler/scheduler.proto 25ebcfcb07cb4fb928dcfdc242bb6509c9080491 Diff: https://reviews.apache.org/r/66228/diff/5/ Changes: https://reviews.apache.org/r/66228/diff/4-5/ Testing --- Thanks, Kapil Arya

Review Request 66746: Replaced protobuf-specific comparators with MessageDifferencer.

2018-04-20 Thread Kapil Arya
with: DefaultExecutorCheckTest.CommandCheckSharesWorkDirWithTask DefaultExecutorCheckTest.MultipleTasksWithChecks Thanks, Kapil Arya

Re: Review Request 66229: Implemented UPDATE_FRAMEWORK call.

2018-04-12 Thread Kapil Arya
ted e-mail. To reply, visit: https://reviews.apache.org/r/66229/#review201053 ------- On April 12, 2018, 9:38 p.m., Kapil Arya wrote: > > --- > This is an

Re: Review Request 66229: Implemented UPDATE_FRAMEWORK call.

2018-04-12 Thread Kapil Arya
7c129ceb929596acbb64d37025e055661277e6bf src/master/validation.cpp ac2e1bb8771841ec59b3bdcdeffb6c6230680d4d Diff: https://reviews.apache.org/r/66229/diff/5/ Changes: https://reviews.apache.org/r/66229/diff/4-5/ Testing --- Thanks, Kapil Arya

Re: Review Request 66230: Added test for adding/removing framework roles.

2018-04-12 Thread Kapil Arya
749420a23bc1a3873bd4d5aee56e78cff79bb1af Diff: https://reviews.apache.org/r/66230/diff/5/ Changes: https://reviews.apache.org/r/66230/diff/4-5/ Testing --- Thanks, Kapil Arya

Re: Review Request 66229: Implemented UPDATE_FRAMEWORK call.

2018-04-11 Thread Kapil Arya
/master/validation.cpp ac2e1bb8771841ec59b3bdcdeffb6c6230680d4d Diff: https://reviews.apache.org/r/66229/diff/4/ Changes: https://reviews.apache.org/r/66229/diff/3-4/ Testing --- Thanks, Kapil Arya

Re: Review Request 66228: Added Call for updating framework info.

2018-04-11 Thread Kapil Arya
/v1/scheduler/scheduler.proto 25ebcfcb07cb4fb928dcfdc242bb6509c9080491 Diff: https://reviews.apache.org/r/66228/diff/4/ Changes: https://reviews.apache.org/r/66228/diff/3-4/ Testing --- Thanks, Kapil Arya

Re: Review Request 65939: Updated role endpoints for hierarchical accounting.

2018-04-05 Thread Kapil Arya
ter.cpp Lines 619 (patched) <https://reviews.apache.org/r/65939/#comment281363> This VLOG seems to stand out. Do we need similar log messages in other functions (`addResources`, etc.)? - Kapil Arya On April 5, 2018, 12:15 p.m., Till Toenshoff wrote: > > ---

Re: Review Request 65940: Added test validating hierarchical role accounting.

2018-04-05 Thread Kapil Arya
test coverage for insertion/deletion of roles implicit roles. Perhaps a TODO? src/tests/api_tests.cpp Lines 1072 (patched) <https://reviews.apache.org/r/65940/#comment281381> For completeness, can we check `roles(0)` as well? - Kapil Arya On April 5, 2018, 12:15 p.m., Till Toe

Review Request 66229: Implemented UPDATE_FRAMEWORK call.

2018-03-22 Thread Kapil Arya
/66229/diff/1/ Testing --- Thanks, Kapil Arya

Review Request 66230: Added test for adding/removing framework roles.

2018-03-22 Thread Kapil Arya
--- Thanks, Kapil Arya

Review Request 66228: Added call/event for updating framework info.

2018-03-22 Thread Kapil Arya
f08fdfbab2a13d1104e7be4b42bf20e9048ab562 Diff: https://reviews.apache.org/r/66228/diff/1/ Testing --- Thanks, Kapil Arya

Review Request 65696: Allowed base64-decoding with whitespaces.

2018-02-16 Thread Kapil Arya
eabc9b0f0ad794ffccda44e338ea855b8c4a796f 3rdparty/stout/tests/base64_tests.cpp a6837c820384e3311d2c030885039a7dd7f01a66 Diff: https://reviews.apache.org/r/65696/diff/1/ Testing --- Updated base64 tests and ran make check Thanks, Kapil Arya

Re: Review Request 65416: Enabled gRPC in the RPM spec file.

2018-01-30 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65416/#review196523 --- Ship it! Ship It! - Kapil Arya On Jan. 29, 2018, 10:41 p.m

Re: Review Request 64297: Updated modules documentation with some more details.

2018-01-25 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64297/#review196294 --- Ship it! Ship It! - Kapil Arya On Jan. 25, 2018, 5:16 p.m

Re: Review Request 64297: Updated modules documentation with some more details.

2018-01-25 Thread Kapil Arya
org/r/64297/#comment275846> s/- Used/Used/ I wonder if there is any value in keeping the TestModule around. - Kapil Arya On Jan. 25, 2018, 4:58 p.m., Till Toenshoff wrote: > > --- > This is an automatically g

Re: Review Request 65116: Getting Started using the Mesos RPM Binaries.

2018-01-16 Thread Kapil Arya
> On Jan. 16, 2018, 2:30 p.m., Kapil Arya wrote: > > Sorry for jumping so late into the party :(. > > > > I wanted to point out a better procedure to install Mesos packages. It's > > listed in the email I sent out earlier to the dev@ mailing list > > (

Re: Review Request 65116: Getting Started using the Mesos RPM Binaries.

2018-01-16 Thread Kapil Arya
/mesos/el/7/x86_64 gpgcheck=0 repo_gpgcheck=0 enabled=1 EOF $ sudo mv /tmp/bintray-mesos-el.repo /etc/yum.repos.d/bintray-mesos-el.repo $ sudo yum update $ sudo yum install mesos ``` - Kapil Arya On Jan. 11, 2018, 9:36 p.m., Senthil Kumaran

Review Request 63889: Use annotated tags in vote.sh and release.sh.

2017-11-16 Thread Kapil Arya
--- Thanks, Kapil Arya

Re: Review Request 62166: Updated RC tagging+voting mechanism.

2017-11-09 Thread Kapil Arya
0ff90cb935bd719c6b4bca5c94f48df1ada5ded9 support/vote.sh 98643a1ad4ced0bd18cec6bc4488add9acc229fa Diff: https://reviews.apache.org/r/62166/diff/2/ Changes: https://reviews.apache.org/r/62166/diff/1-2/ Testing --- Used the updated script to tag and vote 1.4.0-rc4. Thanks, Kapil Arya

Re: Review Request 63543: Added bintray publishing scripts.

2017-11-09 Thread Kapil Arya
debuginfo files (~250MB). Thanks, Kapil Arya

Re: Review Request 63543: Added bintray publishing scripts.

2017-11-09 Thread Kapil Arya
e `-x` was to make shell output verbose -- removed that now. - Kapil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63543/#review190618 -------

Review Request 63543: Added bintray publishing scripts.

2017-11-03 Thread Kapil Arya
). Thanks, Kapil Arya

Re: Review Request 62616: Binary packaging for Centos 7.

2017-10-30 Thread Kapil Arya
. If `MESOS_TAG` environment variable is not supplied, it builds the package from the local mesos tree. Thanks, Kapil Arya

Re: Review Request 62616: Binary packaging for Centos 7.

2017-10-13 Thread Kapil Arya
`/.m2:$HOME/.m2:rw,z -v `pwd`:/mesos:rw,z mesos/packaging:centos7 /mesos/support/packaging/centos/build_rpm RPMs will be placed inside /centos7/rpmbuild/RPMs/x86_64 directory. If `MESOS_TAG` environment variable is not supplied, it builds the package from the local mesos tree. Thanks, Kapil

Re: Review Request 62616: Binary packaging for Centos 7.

2017-10-13 Thread Kapil Arya
utomatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62616/#review187282 --- On Oct. 13, 2017, 2:02 p.m., Kapil Arya wrote: > >

Re: Review Request 62616: Binary packaging for Centos 7.

2017-10-13 Thread Kapil Arya
reply, visit: https://reviews.apache.org/r/62616/#review186971 --- On Oct. 13, 2017, 2:02 p.m., Kapil Arya wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62616/ > ---

Re: Review Request 62616: Binary packaging for Centos 7.

2017-10-13 Thread Kapil Arya
To reply, visit: https://reviews.apache.org/r/62616/#review186959 --- On Oct. 13, 2017, 2:02 p.m., Kapil Arya wrote: > > --- > This is an automatically generated e

Re: Review Request 62616: Binary packaging for Centos 7.

2017-10-13 Thread Kapil Arya
epo and install the rpm package inside it. But I think that is stage 2 and orthogonal to this RR. - Kapil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62616/#review186855

Re: Review Request 62616: Binary packaging for Centos 7.

2017-10-13 Thread Kapil Arya
Jenkins CI is available at https://builds.apache.org/job/Mesos/job/Packaging/job/CentosRPMs/. Thanks, Kapil Arya

Re: Review Request 62661: Added --disable-libtool-wrapper configuration to Mesos.

2017-10-03 Thread Kapil Arya
? - Kapil Arya On Sept. 28, 2017, 7:37 a.m., Andrei Budnik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 62616: Binary packaging for Centos 7.

2017-09-27 Thread Kapil Arya
tested on an internal Jenkins CI. A buildjob on ASF Jenkins CI is available at https://builds.apache.org/job/Mesos/job/Packaging/job/CentosRPMs/. Thanks, Kapil Arya

Re: Review Request 62616: [WIP] Binary packaging for CentOS.

2017-09-27 Thread Kapil Arya
://reviews.apache.org/r/62616/diff/1/ Testing --- The scripts have been tested on an internal Jenkins CI. A buildjob on ASF Jenkins CI is available at https://builds.apache.org/job/Mesos/job/Packaging/job/CentosRPMs/. Thanks, Kapil Arya

Review Request 62616: [WIP] Binary packaging for Centos 7.

2017-09-27 Thread Kapil Arya
Jenkins CI is available at https://builds.apache.org/job/Mesos/job/Packaging/job/CentosRPMs/. Thanks, Kapil Arya

Re: Review Request 62358: Replaced xlocale.h with locale.h.

2017-09-15 Thread Kapil Arya
/stout/include/stout/jsonify.hpp 06b18e27672c45a1d6ab93e4595419200c590ae4 Diff: https://reviews.apache.org/r/62358/diff/1/ Testing (updated) --- make with glibc 2.26. Thanks, Kapil Arya

Review Request 62253: Ignored cgroups v2 hierarchy when parsing /proc/self/cgroups.

2017-09-12 Thread Kapil Arya
elds with empty controller field. Diffs - src/linux/cgroups.cpp 95c81d90f956e11d23e965dd0d0b83a66220d858 Diff: https://reviews.apache.org/r/62253/diff/1/ Testing --- make check on Fedora 26. Thanks, Kapil Arya

Review Request 62254: Ignored /proc/self/ns/pid_for_children when listing namespaces.

2017-09-12 Thread Kapil Arya
namespaces via `ls /proc/self/ns`. Diffs - src/linux/ns.hpp f1792e854e3fb40321a6ad3f7d1f0f9fbd03761a Diff: https://reviews.apache.org/r/62254/diff/1/ Testing --- make check on Fedora 26. Thanks, Kapil Arya

Review Request 62166: Updated RC tagging+voting mechanism.

2017-09-07 Thread Kapil Arya
rt/vote.sh 98643a1ad4ced0bd18cec6bc4488add9acc229fa Diff: https://reviews.apache.org/r/62166/diff/1/ Testing --- Used the updated script to tag and vote 1.4.0-rc4. Thanks, Kapil Arya

Re: Review Request 61725: Added secrets docs.

2017-08-18 Thread Kapil Arya
://reviews.apache.org/r/61725/diff/4/ Testing --- ./mesos-website-dev.sh Thanks, Kapil Arya

Re: Review Request 61733: Synchronized comment in v1 and unversioned master.proto.

2017-08-18 Thread Kapil Arya
and Till Toenshoff. Repository: mesos Description --- Synchronized comment in v1 and unversioned master.proto. Diffs - include/mesos/v1/master/master.proto c3fb31de2509adcdec8204f8bbe46b46a31540e8 Diff: https://reviews.apache.org/r/61733/diff/1/ Testing --- Thanks, Kapil

Review Request 61745: Fixed capitalization and typos in endpoint helps.

2017-08-18 Thread Kapil Arya
--- Fixed capitalization and typos in endpoint helps. Diffs - src/master/http.cpp 959091c8ec03b6ac7bcb5d21b04d2f7d5aff7d54 src/slave/http.cpp 544a052b8b2c3e70d2d109f3ec4fe6a4ca4a05ee Diff: https://reviews.apache.org/r/61745/diff/1/ Testing --- Thanks, Kapil Arya

Re: Review Request 61732: Updated endpoints help.

2017-08-18 Thread Kapil Arya
/diff/3/ Changes: https://reviews.apache.org/r/61732/diff/2-3/ Testing --- Thanks, Kapil Arya

Re: Review Request 61733: Synchronized comment in v1 and unversioned master.proto.

2017-08-18 Thread Kapil Arya
il. To reply, visit: https://reviews.apache.org/r/61733/#review183228 ------- On Aug. 18, 2017, 9:32 a.m., Kapil Arya wrote: > > --- > This is an automat

Re: Review Request 61725: Added secrets docs.

2017-08-18 Thread Kapil Arya
://reviews.apache.org/r/61725/diff/4/ Testing (updated) --- ./mesos-website-dev.sh Thanks, Kapil Arya

Re: Review Request 61725: Added secrets docs.

2017-08-18 Thread Kapil Arya
://reviews.apache.org/r/61725/diff/4/ Changes: https://reviews.apache.org/r/61725/diff/3-4/ Testing --- Thanks, Kapil Arya

Re: Review Request 61735: Removed diacritics from docs/health-checks.md.

2017-08-18 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61735/#review183217 --- Ship it! Ship It! - Kapil Arya On Aug. 18, 2017, 10:41 a.m

Re: Review Request 61725: Added secrets docs.

2017-08-18 Thread Kapil Arya
://reviews.apache.org/r/61725/diff/3/ Changes: https://reviews.apache.org/r/61725/diff/2-3/ Testing --- Thanks, Kapil Arya

  1   2   3   4   5   6   7   8   >