Re: Review Request 69395: Added '--all' flag to 'mesos task list'.

2018-11-26 Thread Kevin Klues
) <https://reviews.apache.org/r/69395/#comment295665> Can we be more descriptive here? src/python/cli_new/lib/cli/tests/task.py Lines 252 (patched) <https://reviews.apache.org/r/69395/#comment295666> Comment should mention launching two tasks or something. - Kevin Klues On N

Re: Review Request 69395: Added '--all' flag to 'mesos task list'.

2018-11-26 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69395/#review210866 --- Ship it! Ship It! - Kevin Klues On Nov. 26, 2018, 1:54

Re: Review Request 69426: Replaced CLI test helper function 'running_tasks' by 'wait_for_task'.

2018-11-26 Thread Kevin Klues
ents as above. src/python/cli_new/lib/cli/tests/task.py Lines 164-168 (original), 198-210 (patched) <https://reviews.apache.org/r/69426/#comment295664> Same comments as above. - Kevin Klues On Nov. 2

Re: Review Request 69425: Fixed name of task created when running mesos-cli-tests.

2018-11-26 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69425/#review210862 --- Ship it! Ship It! - Kevin Klues On Nov. 22, 2018, 11:33

Re: Review Request 69394: Updated 'mesos task list' to only display running tasks.

2018-11-26 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69394/#review210860 --- Ship it! Ship It! - Kevin Klues On Nov. 25, 2018, 9:53 vorm

Re: Review Request 69426: Replaced CLI test helper function 'running_tasks' by 'wait_for_task'.

2018-11-22 Thread Kevin Klues
), 68-70 (patched) <https://reviews.apache.org/r/69426/#comment295576> Instead of throwing an exception here, do an assert that the tasks array has 1 element in it. Do the same for all instances below. - Kevin Klues On Nov. 22, 2018, 11:35 vorm., Armand Grillet

Re: Review Request 69426: Replaced CLI test helper function 'running_tasks' by 'wait_for_task'.

2018-11-22 Thread Kevin Klues
stance of this pattern below as well. - Kevin Klues On Nov. 22, 2018, 11:35 vorm., Armand Grillet wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Re: Review Request 69425: Fixed name of task created when running mesos-cli-tests.

2018-11-22 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69425/#review210810 --- Ship it! Ship It! - Kevin Klues On Nov. 22, 2018, 11:33

Re: Review Request 69390: Added docs describing how to use the new CLI.

2018-11-22 Thread Kevin Klues
before committing. - Kevin Klues On Nov. 20, 2018, 11:12 vorm., Armand Grillet wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 69394: Updated 'mesos task list' to only display running tasks.

2018-11-22 Thread Kevin Klues
. - Kevin Klues On Nov. 19, 2018, 2:17 nachm., Armand Grillet wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 69394: Updated 'mesos task list' to only display running tasks.

2018-11-22 Thread Kevin Klues
), 189 (patched) <https://reviews.apache.org/r/69394/#comment295567> We should use `[-1]` here instead of `pop()`. - Kevin Klues On Nov. 19, 2018, 2:17 nachm., Armand Grillet wrote: > > --- > This is an automatically g

Re: Review Request 69393: Displayed 'State' field when using 'mesos task list'.

2018-11-22 Thread Kevin Klues
), 189 (patched) <https://reviews.apache.org/r/69393/#comment295566> This is racy, as the task may have reached RUNNING before reaching this line. You have told me offline that this is fixed in a follow-up RR, so we can address this then. - Kevin Klues On Nov. 19, 2018, 4:14 nachm.,

Re: Review Request 69393: Displayed 'State' field when using 'mesos task list'.

2018-11-22 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69393/#review210806 --- Ship it! Ship It! - Kevin Klues On Nov. 19, 2018, 4:14

Re: Review Request 69390: Added docs describing how to use the new CLI.

2018-11-22 Thread Kevin Klues
ment295563> The plugin array lists... docs/cli.md Lines 59 (patched) <https://reviews.apache.org/r/69390/#comment295565> The master field is composed of... - Kevin Klues On Nov. 20, 201

Re: Review Request 69390: Added docs describing how to use the new CLI.

2018-11-20 Thread Kevin Klues
g/r/69390/#comment295438> We should move the text that says: ``` For now, the Mesos Command Line Interface is still under development and not built as part of a standard Mesos distribution. ``` to here and have a better opening line for the whole document. - Kevin

Re: Review Request 69255: Updated PyInstaller requirement for new CLI to support Python 3.7.

2018-11-19 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69255/#review210664 --- Ship it! Ship It! - Kevin Klues On Nov. 5, 2018, 6:13 nachm

Re: Review Request 69395: Added '--all' flag to 'mesos task list'.

2018-11-19 Thread Kevin Klues
) <https://reviews.apache.org/r/69395/#comment295387> This will be flakey. - Kevin Klues On Nov. 19, 2018, 2:17 nachm., Armand Grillet wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 69393: Displayed 'State' field when using 'mesos task list'.

2018-11-19 Thread Kevin Klues
] here instaead of pop(). src/python/cli_new/lib/cli/tests/task.py Line 188 (original), 189 (patched) <https://reviews.apache.org/r/69393/#comment295385> Should now be UNKNOWN Keep in mind though, that this is flakey, because we don't know when the task will transition states. - Ke

Re: Review Request 69374: Updated new CLI test step to use binary created by PyInstaller.

2018-11-19 Thread Kevin Klues
committing. - Kevin Klues On Nov. 16, 2018, 9:36 nachm., Armand Grillet wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 69390: Added docs describing how to use the new CLI.

2018-11-19 Thread Kevin Klues
ewline after this? docs/cli.md Lines 54 (patched) <https://reviews.apache.org/r/69390/#comment295383> Let's move these instructions up somehwere near where I mentioned that its still under development, etc. - Kevin Klues On Nov. 19, 2018, 10:31 vorm., Ar

Re: Review Request 69381: Updated configuration docs describing how to build the new CLI.

2018-11-19 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69381/#review210658 --- Ship it! Ship It! - Kevin Klues On Nov. 18, 2018, 5:58

Re: Review Request 69380: Added configuration docs describing how to use Python 3.

2018-11-19 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69380/#review210657 --- Ship it! Ship It! - Kevin Klues On Nov. 18, 2018, 5:58

Re: Review Request 69374: Updated new CLI test step to use binary created by PyInstaller.

2018-11-19 Thread Kevin Klues
org/r/69374/#comment295379> Since we are doing the postactivate, we don't need the full path to mesos-cli-tests anymore, let's remove it... src/python/cli_new/tests/CMakeLists.txt Lines 26 (patched) <https://reviews.apache.org/r/69374/#comment295380> Ditto - Kevin Klues

Re: Review Request 69208: Updated new CLI task attach/exec exit strategy.

2018-11-02 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69208/#review210308 --- Ship it! Ship It! - Kevin Klues On Okt. 30, 2018, 12:55

Re: Review Request 69206: Updated new CLI commands for new CLI to return proper exit status.

2018-11-02 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69206/#review210305 --- Ship it! Ship It! - Kevin Klues On Okt. 30, 2018, 12:51

Re: Review Request 69237: Simplified newline handling in 'test_exec()' test for new CLI.

2018-11-02 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69237/#review210303 --- Ship it! Ship It! - Kevin Klues On Nov. 1, 2018, 10:28

Re: Review Request 69207: Moved 'updated_tasks()' to new CLI tests base.

2018-11-02 Thread Kevin Klues
it in order to keep the test code cleaner. - Kevin Klues On Okt. 30, 2018, 12:53 vorm., Armand Grillet wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 69207: Moved 'updated_tasks()' to new CLI tests base.

2018-11-02 Thread Kevin Klues
) <https://reviews.apache.org/r/69207/#comment294957> As a helper, calling this `updated_tasks()` is weird. Let's call it `running_tasks()`. - Kevin Klues On Okt. 30, 2018, 12:53 vorm., Armand Grillet

Re: Review Request 69116: Added 'popen_tty()' to test util functions for the new CLI.

2018-11-02 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69116/#review210299 --- Ship it! Ship It! - Kevin Klues On Okt. 22, 2018, 12:23

Re: Review Request 69115: Added test for interactive 'task exec'.

2018-11-01 Thread Kevin Klues
. - Kevin Klues On Okt. 22, 2018, 2:40 nachm., Armand Grillet wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 69115: Added test for interactive 'task exec'.

2018-11-01 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69115/#review210265 --- Ship it! Ship It! - Kevin Klues On Okt. 22, 2018, 2:40

Re: Review Request 69115: Added test for interactive 'task exec'.

2018-11-01 Thread Kevin Klues
) <https://reviews.apache.org/r/69115/#comment294870> Typo src/python/cli_new/lib/cli/tests/task.py Lines 126 (patched) <https://reviews.apache.org/r/69115/#comment294871> Why do we need the strip() here? - Kevin Klues On Okt. 22, 2018, 2:40 nachm., Armand G

Re: Review Request 69115: Added test for interactive 'task exec'.

2018-10-22 Thread Kevin Klues
is comment seems unnecessary src/python/cli_new/lib/cli/tests/task.py Lines 124-126 (patched) <https://reviews.apache.org/r/69115/#comment294470> I don't really like the way we do this. I'd rather just open it twice and get the content twice. - Kevin Klues On Okt. 22, 2018,

Re: Review Request 69049: Added test for 'task exec'.

2018-10-22 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69049/#review209862 --- Ship it! Ship It! - Kevin Klues On Okt. 22, 2018, 2:13

Re: Review Request 69119: Added new CLI constants 'TEST_DIRECTORY' and 'TEST_DATA_DIRECTORY'.

2018-10-22 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69119/#review209860 --- Ship it! Ship It! - Kevin Klues On Okt. 22, 2018, 2:12

Re: Review Request 69049: Added test for 'task exec'.

2018-10-22 Thread Kevin Klues
> On Okt. 22, 2018, 1:45 nachm., Kevin Klues wrote: > > src/python/cli_new/lib/cli/tests/task.py > > Lines 41 (patched) > > <https://reviews.apache.org/r/69049/diff/1/?file=2101777#file2101777line41> > > > > It seems strange to just assu

Re: Review Request 69049: Added test for 'task exec'.

2018-10-22 Thread Kevin Klues
hy are we actually using a bare-raise here? src/python/cli_new/lib/cli/tests/task.py Lines 82 (patched) <https://reviews.apache.org/r/69049/#comment294463> We shouldn't have to decode here anymore after moving the `exec_command` to use `universal_newline`. - Kevin Klues On Okt. 22, 201

Re: Review Request 69048: Added tenacity to 'pip-requirements' for new CLI.

2018-10-22 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69048/#review209853 --- Ship it! Ship It! - Kevin Klues On Okt. 22, 2018, 10:31

Re: Review Request 69114: Added 'exec_command' to test util functions for the new CLI.

2018-10-22 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69114/#review209851 --- Ship it! Ship It! - Kevin Klues On Okt. 22, 2018, 1:26

Re: Review Request 69114: Added 'exec_command' to test util functions for the new CLI.

2018-10-22 Thread Kevin Klues
e should use the argument to Popen with `universal_newlines=True`. - Kevin Klues On Okt. 22, 2018, 10:31 vorm., Armand Grillet wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 69105: Added 'task attach' subcommand to new CLI.

2018-10-20 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69105/#review209823 --- Ship it! Ship It! - Kevin Klues On Okt. 20, 2018, 10:04

Re: Review Request 69103: Fixed bug in 'execute.cpp' with tty-based tasks and no 'containerInfo'.

2018-10-20 Thread Kevin Klues
\ --command="sh -i" $ mesos task attach tty-test sh-4.3$ Thanks, Kevin Klues

Re: Review Request 69104: Fixed formatting in subcommand help in the new CLI.

2018-10-20 Thread Kevin Klues
| --help) mesos task attach --version mesos task attach [options] Options: --no-stdin do not attach a stdin [default: False] -h --help Show this screen. Description: Attach the CLI to the stdio of a running task To detach type the sequence CTRL-p CTRL-q. ``` Thanks, Kevin Klues

Review Request 69104: Fixed formatting in subcommand help in the new CLI.

2018-10-20 Thread Kevin Klues
://reviews.apache.org/r/69104/diff/1/ Testing --- Thanks, Kevin Klues

Review Request 69103: Fixed bug in 'execute.cpp' with tty-based tasks and no 'containerInfo'.

2018-10-20 Thread Kevin Klues
/mesos-master.sh \ --ip=127.0.0.1 \ --work_dir=/var/lib/mesos sudo bin/mesos-agent.sh --master=127.0.0.1:5050 \ --work_dir=/var/lib/mesos sudo src/mesos-execute \ --master=127.0.0.1:5050 \ --name=tty-test \ --tty \ --command="sh -i" Thanks, Kevin Klues

Re: Review Request 69003: Added `task exec` to new CLI.

2018-10-18 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69003/#review209750 --- Ship it! Ship It! - Kevin Klues On Okt. 15, 2018, 6:53 vorm

Re: Review Request 69003: Added `task exec` to new CLI.

2018-10-18 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69003/#review209749 --- Ship it! Ship It! - Kevin Klues On Okt. 15, 2018, 6:53 vorm

Re: Review Request 69003: Added `task exec` to new CLI.

2018-10-18 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69003/#review209748 --- Ship it! Ship It! - Kevin Klues On Okt. 15, 2018, 6:53 vorm

Re: Review Request 68978: Added TaskIO object to new CLI for `task exec` and `task attach`.

2018-10-18 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68978/#review209747 --- Ship it! Ship It! - Kevin Klues On Okt. 15, 2018, 11:06

Re: Review Request 69023: Added `retry` argument to `request()` method in Python library.

2018-10-17 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69023/#review209693 --- Ship it! Ship It! - Kevin Klues On Okt. 15, 2018, 11:05

Re: Review Request 69007: Added `get_container_id` to util functions for the new CLI.

2018-10-17 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69007/#review209692 --- Ship it! Ship It! - Kevin Klues On Okt. 13, 2018, 9:08 vorm

Re: Review Request 68971: Moved import of '../lib' from new CLI bootstrap to pip-requirements.txt.

2018-10-16 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68971/#review209615 --- Ship it! Ship It! - Kevin Klues On Okt. 16, 2018, 11:33

Re: Review Request 69047: Updated Python library to be easier to handle as a Python module.

2018-10-16 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69047/#review209612 --- Ship it! Ship It! - Kevin Klues On Okt. 16, 2018, 11:31

Re: Review Request 69026: Changed usage documentation for new CLI.

2018-10-15 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69026/#review209536 --- Ship it! Ship It! - Kevin Klues On Okt. 15, 2018, 11:45

Re: Review Request 69003: Added `task exec` to new CLI.

2018-10-14 Thread Kevin Klues
views.apache.org/r/69003/ > --- > > (Updated Okt. 12, 2018, 9:18 nachm.) > > > Review request for mesos and Kevin Klues. > > > Bugs: MESOS-6551 > https://issues.apache.org/jira/browse/MESOS-6551 > > > Repository: mesos > > > Description > --- > &

Re: Review Request 68965: Added try/catch statements when using Mesos util functions in new CLI.

2018-10-09 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68965/#review209367 --- Ship it! Ship It! - Kevin Klues On Okt. 9, 2018, 2:18 nachm

Re: Review Request 66683: Updated address sanitization in new CLI to accept DNS names.

2018-10-09 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66683/#review209358 --- Ship it! Ship It! - Kevin Klues On Okt. 9, 2018, 12:49

Re: Review Request 68950: Moved `get_agent_address` from `util.py` to `mesos.py` in new CLI.

2018-10-08 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68950/#review209309 --- Ship it! Ship It! - Kevin Klues On Okt. 8, 2018, 1:08 nachm

Re: Review Request 68734: Refactored new CLI.

2018-10-02 Thread Kevin Klues
decided to move the functionality spread across two files (tasks.py and agents.py) into a single mesos.py that has functions to abstract the various Mesos API calls. The main logic remains the same, it is just rearranged. - Kevin Klues On Sept. 17, 2018, 10:36 vorm., Armand Grillet wrote

Re: Review Request 68810: Removed call to 'setsid()' in command executor if TTY attached.

2018-09-29 Thread Kevin Klues
make -j 40 check Thanks, Kevin Klues

Review Request 68810: Removed call to 'setsid()' in command executor if TTY attached.

2018-09-21 Thread Kevin Klues
r/mesos/io/switchboard.cpp 52b0e521ed1c651c90b3a3df7c4df576288bf400 Diff: https://reviews.apache.org/r/68810/diff/1/ Testing --- $ make -j 40 check Thanks, Kevin Klues

Re: Review Request 68724: Added the ability to launch tasks with a TTY attached to mesos-execute.

2018-09-21 Thread Kevin Klues
ers=docker \ --executor_environment_variables="{}" \ --isolation="cgroups/all,filesystem/linux,docker/runtime,namespaces/pid" sudo src/mesos-execute \ --master=127.0.0.1:5050 \ --name=tty-test \ --docker_image=library/alpine \ --no-shell \ --tty \ --co

Review Request 68724: Added the ability to launch tasks with a TTY attached to mesos-execute.

2018-09-14 Thread Kevin Klues
ecute \ --master=127.0.0.1:5050 \ --name=tty-test \ --docker_image=library/alpine \ --no-shell \ --tty \ --command="sh -i" Thanks, Kevin Klues

Re: Review Request 67894: Migrated mesos python package to python3.6.

2018-08-29 Thread Kevin Klues
since they have been added by armand in an already commited RR. - Kevin Klues On Juli 12, 2018, 8:09 vorm., Eric Chung wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Review Request 68560: Updated the python2 'PyLinter' to only lint python2 based code.

2018-08-29 Thread Kevin Klues
/68560/diff/1/ Testing --- Thanks, Kevin Klues

Re: Review Request 67956: Removed some generic flag parsers that are now in stout.

2018-07-19 Thread Kevin Klues
adding them to stout in the previous commit didn't cause build errors, for the short time between commits when there were duplicate definitions of them? - Kevin Klues On July 18, 2018, 1:19 a.m., Benjamin Hindman wrote

Re: Review Request 67955: Added some new generic flag parsers.

2018-07-19 Thread Kevin Klues
(patched) <https://reviews.apache.org/r/67955/#comment289147> This comment is wrong. It's not for unsigned ints, it's for strings. - Kevin Klues On July 18, 2018, 1:19 a.m., Benjamin Hindman wrote: > > --- > This is a

Re: Review Request 67488: Updated CLI to Python 3.

2018-07-16 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67488/#review206106 --- Ship it! Ship It! - Kevin Klues On July 6, 2018, 1:56 p.m

Re: Review Request 67488: Updated CLI to Python 3.

2018-07-16 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67488/#review206104 --- Ship it! Ship It! - Kevin Klues On July 6, 2018, 1:56 p.m

Re: Review Request 67488: Updated CLI to Python 3.

2018-07-16 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67488/#review206105 --- Ship it! Ship It! - Kevin Klues On July 6, 2018, 1:56 p.m

Re: Review Request 67906: Updated tox usage in mesos-style.py to run in support virtualenv.

2018-07-13 Thread Kevin Klues
in the commit before pushing it. Please see the commit logs for details. - Kevin Klues On July 13, 2018, 8:20 a.m., Armand Grillet wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 67910: Fixed virtualenv management in support directory.

2018-07-13 Thread Kevin Klues
changed some variable names in the commit that actually fixes the virtualenv management. Please see the commit logs for details. - Kevin Klues On July 13, 2018, 4:38 p.m., Armand Grillet wrote: > > --- > This is an auto

Re: Review Request 67911: Fixed `build-virtualenv` to correctly clear virtual environment.

2018-07-13 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67911/#review206071 --- Ship it! Ship It! - Kevin Klues On July 13, 2018, 4:37 p.m

Re: Review Request 67853: Updated build-virtualenv to use Python 3 features.

2018-07-09 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67853/#review205856 --- Ship it! Ship It! - Kevin Klues On July 9, 2018, 3:54 p.m

Re: Review Request 67853: Updated build-virtualenv to use Python 3 features.

2018-07-09 Thread Kevin Klues
tps://reviews.apache.org/r/67853/#comment288759> Can we replace `` with `${0}` both here and below? - Kevin Klues On July 9, 2018, 3:54 p.m., Armand Grillet wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 67853: Updated build-virtualenv to use Python 3 features.

2018-07-09 Thread Kevin Klues
tps://reviews.apache.org/r/67853/#comment288758> I don't think we need this check in here. We should make this script usable for *both* python2 and python 3 environments and depending on what the environment is that it is invoked in, it will build an appropriate virtualenv. - Kevin

Re: Review Request 67842: Refactored base of Python CLI tests.

2018-07-06 Thread Kevin Klues
committing. - Kevin Klues On July 6, 2018, 1:53 p.m., Armand Grillet wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 67842: Refactored base of Python CLI tests.

2018-07-06 Thread Kevin Klues
apped in e.g.: ``` if hasattr(self, "flags") and hasattr(self.flags, "work_dir"): ``` - Kevin Klues On July 6, 2018, 1:53 p.m., Armand Grillet wrote: > > --- > This is an automatically g

Re: Review Request 67842: Refactored base of Python CLI tests.

2018-07-06 Thread Kevin Klues
Same cooment as for the agent. - Kevin Klues On July 6, 2018, 10:02 a.m., Armand Grillet wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 67488: Updated CLI to Python 3.

2018-07-04 Thread Kevin Klues
kill forces the process to die immediately. - Kevin Klues On June 12, 2018, 4:29 p.m., Armand Grillet wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 67487: Used `$PYTHON` in configure.ac and Makefile.am.

2018-07-04 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67487/#review205724 --- Ship it! Ship It! - Kevin Klues On June 12, 2018, 2:51 p.m

Re: Review Request 67413: Refactored logic for `PYTHON` and `PYTHON_VERSION` in `configure.ac`.

2018-07-04 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67413/#review205723 --- Ship it! Ship It! - Kevin Klues On July 3, 2018, 2:40 p.m

Re: Review Request 67413: Refactored logic for `PYTHON` and `PYTHON_VERSION` in `configure.ac`.

2018-07-04 Thread Kevin Klues
che.org/r/67413/#comment288602> s/or/and when/ - Kevin Klues On July 3, 2018, 2:40 p.m., Armand Grillet wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 67412: Improved coverage with configure and `PYTHON` or `PYTHON_VERSION` set.

2018-06-15 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67412/#review204843 --- Ship it! Ship It! - Kevin Klues On June 1, 2018, 3:14 p.m

Re: Review Request 67412: Improved coverage with configure and `PYTHON` or `PYTHON_VERSION` set.

2018-06-15 Thread Kevin Klues
ON=`$PYTHON -c "import sys; sys.stdout.write(sys.version[[:3]])"` +], [ + AC_MSG_ERROR([Cannot find Python executable '$PYTHON' in path.]) +]) ``` - Kevin Klues On June 1, 2018, 3:14 p.m., Armand Grillet wrote: > >

Re: Review Request 67411: Broadened check for Autotools Python environment variables.

2018-06-15 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67411/#review204837 --- Ship it! Ship It! - Kevin Klues On June 15, 2018, 1:16 p.m

Re: Review Request 67487: Used `$PYTHON` in configure.ac and Makefile.am.

2018-06-13 Thread Kevin Klues
) <https://reviews.apache.org/r/67487/#comment287302> Can you set PYTHON here so we know which python version we are building the virtualenv with? - Kevin Klues On June 12, 2018, 2:51 p.m., Armand Grillet

Re: Review Request 67412: Improved coverage with configure and `PYTHON` or `PYTHON_VERSION` set.

2018-06-13 Thread Kevin Klues
g/r/67412/#comment287300> Instead of this long complicated line, can we just set PYTHON_VERSION directrly from: ``` PYTHON_VERSION=`$PYTHON -c "import sys; sys.stdout.write(sys.version[[:3]])"` ``` - Kevin Klues On June 1, 2018, 3:14 p.m., Arma

Re: Review Request 67411: Broadened check for Autotools Python environment variables.

2018-06-13 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67411/#review204686 --- Ship it! Ship It! - Kevin Klues On June 1, 2018, 3:06 p.m

Re: Review Request 67488: Updated CLI to Python 3.

2018-06-13 Thread Kevin Klues
apache.org/r/67488/#comment287294> Remove this comment - Kevin Klues On June 12, 2018, 4:29 p.m., Armand Grillet wrote: > > --- > This is an automatically generated e-mail. To reply

Re: Review Request 67054: Added .tox to files excluded by Python linter.

2018-05-11 Thread Kevin Klues
and .tox directories to our .gitignore. They should never be part of the list of files that are being processed by mesos-style.py during a commit hook anyway. - Kevin Klues On May 10, 2018, 10:56 a.m., Armand Grillet wrote

Re: Review Request 67032: Removed pip install requirements-test.in in new CLI bootstrap script.

2018-05-09 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67032/#review202753 --- Ship it! Ship It! - Kevin Klues On May 9, 2018, 1:13 p.m

Re: Review Request 64970: Use tox for linting and testing code living uder src/python.

2018-05-09 Thread Kevin Klues
o pass this option here. We want to see the output of the commands it issues, but we don't want to see the output of tox itself. The '-qq' option gives us this ability. - Kevin Klues On March 14, 2018, 3:05 p.m., Eric Chung

Re: Review Request 66649: Added pb2gen.sh for generating python protobuf bindings.

2018-05-09 Thread Kevin Klues
ent284732> Is there some way to simplify this. Maybe by breaking it out into multiple steps? It will be really hard to maintain this going forward otherwise. - Kevin Klues On April 17, 2018, 8:22 p.m., Eric Chung wrote: > > --- > Thi

Re: Review Request 64211: Added options to build the Python CLI and run unit tests.

2018-04-12 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64211/#review201000 --- Ship it! Ship It! - Kevin Klues On March 24, 2018, 11:39

Re: Review Request 65585: Improved documentation regarding the new CLI setup.

2018-04-12 Thread Kevin Klues
it's a functionality change and not just documentation. src/python/cli_new/bin/mesos-cli-tests Line 5 (original) <https://reviews.apache.org/r/65585/#comment281933> This should probably have been in a spearate commit since it's a functionality change and not just documentation.

Re: Review Request 65585: Improved documentation regarding the new CLI setup.

2018-04-12 Thread Kevin Klues
tps://reviews.apache.org/r/65585/#comment281927> This should be ${CURRDIR} too. There is no need to introduce a new ${BINDIR} here. - Kevin Klues On March 24, 2018, 11:39 a.m., Armand Grillet wrote: > > --- > This is a

Re: Review Request 65705: Fixed CLI bootstrap script to work with long workspace paths.

2018-04-12 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65705/#review200996 --- Ship it! Ship It! - Kevin Klues On March 24, 2018, 11:39

Re: Review Request 64211: Added options to build the Python CLI and run unit tests.

2018-04-12 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64211/#review200995 --- Ship it! Ship It! - Kevin Klues On March 24, 2018, 11:39

Re: Review Request 65705: Fixed CLI bootstrap script to work with long workspace paths.

2018-04-12 Thread Kevin Klues
) <https://reviews.apache.org/r/65705/#comment281926> I see why this is a good change, but in the future, this should be done in a seperate commit. - Kevin Klues On March 24, 2018, 11:39 a.m., Armand Grillet

  1   2   3   4   5   6   7   8   9   10   >