Review Request 57984: Fixed indents.

2017-03-28 Thread Klaus Ma
indents. Diffs - src/master/master.cpp 43e9d26167c1f405329ea05224c22e7b8c65315f Diff: https://reviews.apache.org/r/57984/diff/1/ Testing --- Thanks, Klaus Ma

Re: Review Request 46298: Rejected relative path agent work_dir.

2016-09-25 Thread Klaus Ma
()` refactor. - Klaus Ma On July 16, 2016, 9:33 p.m., Klaus Ma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 45081: Excluded reserved resources when got nonRevocable resources in stage 1.

2016-09-21 Thread Klaus Ma
it'll be more future-proof. > > That is, even after reserved resources becomes revocable it would remain > > correct. > > > > Anyway, I'm curiuos as to why this patch is being suggested. Thanks! > > Klaus Ma wrote: > Try to improve the performance by avoid unnecessar

Re: Review Request 51027: Track allocation candidates to bound allocator.

2016-08-31 Thread Klaus Ma
> On Aug. 26, 2016, 2:24 p.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 275 > > <https://reviews.apache.org/r/51027/diff/2/?file=1481820#file1481820line275> > > > > I think we should use `insert(...)` instead of `=`; if the

Re: Review Request 51027: Track allocation candidates to bound allocator.

2016-08-26 Thread Klaus Ma
tps://reviews.apache.org/r/51027/#comment213741> I think we should use `insert(...)` instead of `=`; if the following event in the queue, are we still going to get the correct result? ``` batch -> addFramework(f1) -> addFramework(f2) ``` - Klaus Ma On Aug. 23, 2016, 4:49

Re: Review Request 45081: Excluded reserved resources when got nonRevocable resources in stage 1.

2016-08-12 Thread Klaus Ma
it'll be more future-proof. > > That is, even after reserved resources becomes revocable it would remain > > correct. > > > > Anyway, I'm curiuos as to why this patch is being suggested. Thanks! > > Klaus Ma wrote: > Try to improve the performance by avoid unnecessar

Re: Review Request 45081: Excluded reserved resources when got nonRevocable resources in stage 1.

2016-08-11 Thread Klaus Ma
rmance by avoid unnecessary operation :). - Klaus --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45081/#review145489 --------

Re: Review Request 49223: Fixed Value parsing code to only accept the canonical formats.

2016-07-21 Thread Klaus Ma
.cpp ff1926f9ab26c3ac3ab62b6df3ce305f5d12f12e Diff: https://reviews.apache.org/r/49223/diff/ Testing --- make && make check Thanks, Klaus Ma

Re: Review Request 50290: Did not put latest empty string in strings::split.

2016-07-21 Thread Klaus Ma
--- make && make check Thanks, Klaus Ma

Re: Review Request 49223: Fixed Value parsing code to only accept the canonical formats.

2016-07-21 Thread Klaus Ma
Diff: https://reviews.apache.org/r/49223/diff/ Testing --- make && make check Thanks, Klaus Ma

Re: Review Request 43561: Improve Ranges parsing to handle single values.

2016-07-21 Thread Klaus Ma
t Thanks, Klaus Ma

Re: Review Request 49223: Fixed Value parsing code to only accept the canonical formats.

2016-07-21 Thread Klaus Ma
d you keep tokenizing on newlines? AFAICT they are not part > > of the canonical format? Replaced tokenize with split, also add related test cases. - Klaus --- This is an automatically generated e-mail. T

Re: Review Request 49223: Fixed Value parsing code to only accept the canonical formats.

2016-07-21 Thread Klaus Ma
ff1926f9ab26c3ac3ab62b6df3ce305f5d12f12e Diff: https://reviews.apache.org/r/49223/diff/ Testing --- make && make check Thanks, Klaus Ma

Review Request 50295: Returned empty vector if string is empty.

2016-07-21 Thread Klaus Ma
empty vector if string is empty. Diffs - Diff: https://reviews.apache.org/r/50295/diff/ Testing --- Thanks, Klaus Ma

Re: Review Request 50290: Did not put latest empty string in strings::split.

2016-07-21 Thread Klaus Ma
7f7f1cffcebfe16cb986917b1d90c1ae4a480989 Diff: https://reviews.apache.org/r/50290/diff/ Testing --- make && make check Thanks, Klaus Ma

Review Request 50290: Returned empty vector if string is empty.

2016-07-21 Thread Klaus Ma
--- Returned empty vector if string is empty. Diffs - 3rdparty/stout/include/stout/strings.hpp 7f7f1cffcebfe16cb986917b1d90c1ae4a480989 Diff: https://reviews.apache.org/r/50290/diff/ Testing --- make && make check Thanks, Klaus Ma

Review Request 50285: Replaced boost::lexical_cast with numify when paring Value.

2016-07-21 Thread Klaus Ma
--- Replaced boost::lexical_cast with numify when paring Value. Diffs - src/common/values.cpp 7b8a8ea00bd4bd1a82c33be4438c26b2731b1dd8 Diff: https://reviews.apache.org/r/50285/diff/ Testing --- make && make check Thanks, Klaus Ma

Review Request 50280: Simplificed removing whitspace by strings::replace().

2016-07-20 Thread Klaus Ma
Thanks, Klaus Ma

Re: Review Request 45959: Support arithmetic operations for shared resources with consumer counts.

2016-07-19 Thread Klaus Ma
an check name,type, role firstly, then check SharedInfo. src/common/resources.cpp (line 882) <https://reviews.apache.org/r/45959/#comment208557> one `isShared()` is enough. `isShared` is checked in `subtractable`. - Klaus Ma On July 20, 2016,

Re: Review Request 46298: Rejected relative path agent work_dir.

2016-07-16 Thread Klaus Ma
; optional validate lambda to be passed in. > > Klaus Ma wrote: > @jie, thanks for the comments. Try to use validated lamba today, but > there some issues: > > 1. The `work_dir` is required without default value; if using validate > lamba, a "default" value is

Re: Review Request 46298: Rejected relative path agent work_dir.

2016-07-16 Thread Klaus Ma
://reviews.apache.org/r/46298/diff/ Testing --- 1. make && make check 2. e2e test: ``` $ ./src/mesos-slave --work_dir=aa --master=aa The required option `--work_dir` must be absolute path. ``` Thanks, Klaus Ma

Re: Review Request 49223: Fixed Value parsing code to only accept the canonical formats.

2016-07-15 Thread Klaus Ma
.cpp 7b8a8ea00bd4bd1a82c33be4438c26b2731b1dd8 src/tests/values_tests.cpp cc17b675d5d3768685b44a1cea64264dcbca80ba src/v1/values.cpp 3e0f739b69e680f9eb29ed36d4501c393758c861 Diff: https://reviews.apache.org/r/49223/diff/ Testing --- make && make check Thanks, Klaus Ma

Re: Review Request 50044: Updated Sorter::sort to return a vector rather than list.

2016-07-14 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50044/#review142309 --- Ship it! Ship It! - Klaus Ma On July 15, 2016, 3:35 a.m

Re: Review Request 50044: Updated Sorter::sort to return a vector rather than list.

2016-07-14 Thread Klaus Ma
tps://reviews.apache.org/r/50044/#comment207883> This's not necessary, `sorter/sorter.hpp` had included it. - Klaus Ma On July 15, 2016, 3:35 a.m., Benjamin Mahler wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 46298: Rejected relative path agent work_dir.

2016-07-13 Thread Klaus Ma
; optional validate lambda to be passed in. > > Klaus Ma wrote: > @jie, thanks for the comments. Try to use validated lamba today, but > there some issues: > > 1. The `work_dir` is required without default value; if using validate > lamba, a "default" value is

Re: Review Request 49381: Benchmark for Resources class.

2016-07-13 Thread Klaus Ma
0; ... cpus(r99):1;mem(r99):100" 1 times. [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_MEM/3 (135 ms) [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_MEM/4 Took 1753us to `mem()` "[1-2, 4-5, ... , 298-299]" 1 times. [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_MEM/4 (1 ms) [--] 30 tests from ResourcesOperators/Resources_BENCHMARK_Test (52070 ms total) Thanks, Klaus Ma

Re: Review Request 49381: Benchmark for Resources class.

2016-07-13 Thread Klaus Ma
perator_MEM/3 Took 134330us to `mem()` "cpus(r0):1;mem(r0):100; ... cpus(r99):1;mem(r99):100" 1 times. [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_MEM/3 (135 ms) [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_MEM/4 Took 1753us to `mem()` "[1-2, 4-5, ... , 298-299]" 1 times. [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_MEM/4 (1 ms) [--] 30 tests from ResourcesOperators/Resources_BENCHMARK_Test (52070 ms total) Thanks, Klaus Ma

Re: Review Request 46298: Rejected relative path agent work_dir.

2016-07-12 Thread Klaus Ma
; optional validate lambda to be passed in. > > Klaus Ma wrote: > @jie, thanks for the comments. Try to use validated lamba today, but > there some issues: > > 1. The `work_dir` is required without default value; if using validate > lamba, a "default" value is

Re: Review Request 46298: Rejected relative path agent work_dir.

2016-07-12 Thread Klaus Ma
84dbb2db41bd9849ab1245969884675d9d16555b Diff: https://reviews.apache.org/r/46298/diff/ Testing --- 1. make && make check 2. e2e test: ``` $ ./src/mesos-slave --work_dir=aa --master=aa The required option `--work_dir` must be absolute path. ``` Thanks, Klaus Ma

Re: Review Request 46298: Rejected relative path agent work_dir.

2016-07-12 Thread Klaus Ma
atically generated e-mail. To reply, visit: https://reviews.apache.org/r/46298/#review141756 ------- On April 19, 2016, 3:31 p.m., Klaus Ma wrote: > > --- > This is a

Re: Review Request 49381: Benchmark for Resources class (cpu, mem & port).

2016-07-12 Thread Klaus Ma
uot;cpus(r0):1;mem(r0):100; ... cpus(r99):1;mem(r99):100" 1 times. [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_MEM/3 (135 ms) [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_MEM/4 Took 1753us to `mem()` "[1-2, 4-5, ... , 298-299]" 1 times. [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_MEM/4 (1 ms) [--] 30 tests from ResourcesOperators/Resources_BENCHMARK_Test (52070 ms total) Thanks, Klaus Ma

Re: Review Request 49381: Benchmark for Resources class (cpu, mem & port).

2016-07-11 Thread Klaus Ma
1 times. [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_MEM/3 (129 ms) [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_MEM/4 Took 1405us to `mem()` "[1-2, 3-4, ... , 199-200]" 1 times. [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_MEM/4 (2 ms) [--] 30 tests from ResourcesOperators/Resources_BENCHMARK_Test (44301 ms total) Thanks, Klaus Ma

Re: Review Request 49381: Benchmark for Resources class (cpu, mem & port)

2016-07-11 Thread Klaus Ma
) [ RUN ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_MEM/4 Took 1405us to `mem()` "[1-2, 3-4, ... , 199-200]" 1 times. [ OK ] ResourcesOperators/Resources_BENCHMARK_Test.Operator_MEM/4 (2 ms) [--] 30 tests from ResourcesOperators/Resources_BENCHMARK_Test (44301 ms total) Thanks, Klaus Ma

Re: Review Request 49381: Benchmark for Resources class (cpu, mem & port)

2016-07-11 Thread Klaus Ma
mark for Resources class (cpu, mem & port) Diffs (updated) - src/tests/resources_tests.cpp dc12bd8f1e2da6972bc8aed598811c55d664036e Diff: https://reviews.apache.org/r/49381/diff/ Testing --- Thanks, Klaus Ma

Re: Review Request 49381: WIP: Benchmark for Resources class.

2016-07-09 Thread Klaus Ma
dc12bd8f1e2da6972bc8aed598811c55d664036e Diff: https://reviews.apache.org/r/49381/diff/ Testing --- Thanks, Klaus Ma

Re: Review Request 49223: Fixed Value parsing code to only accept the canonical formats.

2016-07-09 Thread Klaus Ma
/attributes-resources/ Diffs - src/common/values.cpp 587cb68551d438621e215953e89818b623b7f71b src/tests/values_tests.cpp 929861549e3155c33966896f817f9bf9e6d14354 Diff: https://reviews.apache.org/r/49223/diff/ Testing --- make && make check Thanks, Klaus Ma

Re: Review Request 49223: Fixed Value parsing code to only accept the canonical formats.

2016-07-09 Thread Klaus Ma
://reviews.apache.org/r/49223/diff/ Testing --- make && make check Thanks, Klaus Ma

Review Request 49707: Replaced raw string with const.

2016-07-06 Thread Klaus Ma
--- Replaced raw string with const. Diffs - src/slave/containerizer/fetcher.cpp 8545d9813058e3f7af93ebadccec64a355333b72 Diff: https://reviews.apache.org/r/49707/diff/ Testing --- make Thanks, Klaus Ma

Re: Review Request 49223: Enhance value parsing.

2016-07-05 Thread Klaus Ma
929861549e3155c33966896f817f9bf9e6d14354 Diff: https://reviews.apache.org/r/49223/diff/ Testing --- make && make check Thanks, Klaus Ma

Re: Review Request 49223: Enhance value parsing.

2016-07-05 Thread Klaus Ma
u please show more comments for what do you want to check here? It would > > be great if you can make the comment easy to understand. > > Klaus Ma wrote: > Only [0-9a-z./] is available for Text in document. > > Guangya Liu wrote: > OK, then what about "

Re: Review Request 49246: Enhanced startsWith/endsWith's performance.

2016-07-04 Thread Klaus Ma
162bdfb6c4f5a6b108761ebccd9b77e672f6dd87 Diff: https://reviews.apache.org/r/49246/diff/ Testing --- make && make check Thanks, Klaus Ma

Re: Review Request 49223: Enhance value parsing.

2016-07-04 Thread Klaus Ma
ally generated e-mail. To reply, visit: https://reviews.apache.org/r/49223/#review140648 ------- On July 4, 2016, 6:33 p.m., Klaus Ma wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 49586: Used startsWith char version for role validation.

2016-07-04 Thread Klaus Ma
it: https://reviews.apache.org/r/49586/#review140646 --- On July 4, 2016, 4:05 p.m., Klaus Ma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:/

Re: Review Request 49223: Enhance value parsing.

2016-07-04 Thread Klaus Ma
g/r/49223/#comment206026> Only `[0-9a-z./]` is available for Text in document. - Klaus Ma On July 4, 2016, 6:33 p.m., Klaus Ma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 49223: Enhance value parsing.

2016-07-04 Thread Klaus Ma
eviews.apache.org/r/49223/#review140294 ------- On July 4, 2016, 6:33 p.m., Klaus Ma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49223/ > ---

Re: Review Request 49223: Enhance value parsing.

2016-07-04 Thread Klaus Ma
/values_tests.cpp 929861549e3155c33966896f817f9bf9e6d14354 Diff: https://reviews.apache.org/r/49223/diff/ Testing --- make && make check Thanks, Klaus Ma

Review Request 49586: Used startsWith char version for role validation.

2016-07-04 Thread Klaus Ma
--- Used startsWith char version for role validation. Diffs - src/common/roles.cpp 65c71931a5645d346439c3cdff1c5c8cc3ee01a3 Diff: https://reviews.apache.org/r/49586/diff/ Testing --- make && make check Thanks, Klaus Ma

Re: Review Request 49581: Used the `char` version of `strings::startsWith` in stout.

2016-07-04 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49581/#review140610 --- Ship it! Ship It! - Klaus Ma On July 4, 2016, 8:38 a.m

Re: Review Request 49246: Enhanced startsWith/endsWith's performance.

2016-07-04 Thread Klaus Ma
162bdfb6c4f5a6b108761ebccd9b77e672f6dd87 Diff: https://reviews.apache.org/r/49246/diff/ Testing --- make && make check Thanks, Klaus Ma

Re: Review Request 49582: Used the `char` version of `strings::startsWith` in mesos.

2016-07-03 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49582/#review140600 --- Ship it! Ship It! - Klaus Ma On July 4, 2016, 8:39 a.m

Re: Review Request 49381: WIP: Benchmark for Resources class.

2016-06-30 Thread Klaus Ma
dc12bd8f1e2da6972bc8aed598811c55d664036e Diff: https://reviews.apache.org/r/49381/diff/ Testing --- Thanks, Klaus Ma

Re: Review Request 48895: Added allocator_fairness_excluded_resource_names flag to master.

2016-06-30 Thread Klaus Ma
> On June 30, 2016, 1:01 a.m., Klaus Ma wrote: > > src/master/flags.cpp, line 437 > > <https://reviews.apache.org/r/48895/diff/3/?file=1432431#file1432431line437> > > > > s/client/framework > > > > Mesos user does not know client. &g

Re: Review Request 49223: Enhance value parsing.

2016-06-29 Thread Klaus Ma
929861549e3155c33966896f817f9bf9e6d14354 Diff: https://reviews.apache.org/r/49223/diff/ Testing --- make && make check Thanks, Klaus Ma

Re: Review Request 48904: Updated allocator initialize() to include fairnessExcludeResourceNames.

2016-06-29 Thread Klaus Ma
> On June 30, 2016, 1:13 a.m., Klaus Ma wrote: > > src/master/master.cpp, line 830 > > <https://reviews.apache.org/r/48904/diff/3/?file=1432471#file1432471line830> > > > > Please check whether the resource name is valid. We only support cpus, > > mem,

Re: Review Request 49352: Added a flag parser for hashset.

2016-06-29 Thread Klaus Ma
> On June 30, 2016, 12:59 a.m., Klaus Ma wrote: > > src/common/parse.hpp, lines 150-152 > > <https://reviews.apache.org/r/49352/diff/1/?file=1432428#file1432428line150> > > > > Call `insert` directly should be fine. `set` will help to avoid > >

Re: Review Request 48904: Updated allocator initialize() to include fairnessExcludeResourceNames.

2016-06-29 Thread Klaus Ma
g/r/48904/#comment205346> Please check whether the resource name is valid. We only support cpus, mem, disk, ports, gpus for now. - Klaus Ma On June 29, 2016, 8:16 p.m., Guangya Liu wrote: > > --- > This is an automatica

Re: Review Request 48895: Added allocator_fairness_excluded_resource_names flag to master.

2016-06-29 Thread Klaus Ma
g/r/48895/#comment205344> s/client/framework Mesos user does not know client. - Klaus Ma On June 29, 2016, 8:14 p.m., Guangya Liu wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 48581: Removed duplicated code in 'strings::tokenize()'.

2016-06-29 Thread Klaus Ma
162bdfb6c4f5a6b108761ebccd9b77e672f6dd87 Diff: https://reviews.apache.org/r/48581/diff/ Testing --- make && make check Thanks, Klaus Ma

Review Request 49381: WIP: Benchmark for Resources class.

2016-06-29 Thread Klaus Ma
, Klaus Ma

Re: Review Request 49223: Enhanced Value parsing.

2016-06-28 Thread Klaus Ma
://reviews.apache.org/r/49223/diff/ Testing --- make && make check Thanks, Klaus Ma

Re: Review Request 49246: Enhanced startsWith/endsWith's performance.

2016-06-27 Thread Klaus Ma
imilar cases with `startsWith`. - Klaus --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49246/#review139536 ------- On

Re: Review Request 49246: Enhanced startsWith/endsWith's performance.

2016-06-27 Thread Klaus Ma
: https://reviews.apache.org/r/49246/diff/ Testing --- make && make check Thanks, Klaus Ma

Review Request 49246: Enhanced startsWith/endsWith's performance.

2016-06-27 Thread Klaus Ma
&& make check Thanks, Klaus Ma

Re: Review Request 49223: Enhanced Value parsing.

2016-06-26 Thread Klaus Ma
mp; make check Thanks, Klaus Ma

Re: Review Request 49223: Enhanced Value parsing.

2016-06-26 Thread Klaus Ma
Diff: https://reviews.apache.org/r/49223/diff/ Testing (updated) --- make && make check Thanks, Klaus Ma

Re: Review Request 49140: Added startsWith/endsWith to support char.

2016-06-26 Thread Klaus Ma
of `startsWith/endsWith` to improve the performance. - Klaus Ma On June 26, 2016, 5:46 p.m., Klaus Ma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 49140: Added startsWith/endsWith to support char.

2016-06-26 Thread Klaus Ma
: https://reviews.apache.org/r/49140/diff/ Testing --- make Thanks, Klaus Ma

Re: Review Request 49140: Added startsWith/endsWith to support char.

2016-06-26 Thread Klaus Ma
18bcb0e499a9d2d84113b5b9e609e5e40913ebcc support/docker_build.sh 8ae1aadbc12b12e44984d34ccfbcb8a97bf05bcf Diff: https://reviews.apache.org/r/49140/diff/ Testing --- make Thanks, Klaus Ma

Review Request 49223: WIP: enhance value parsing.

2016-06-24 Thread Klaus Ma
: enhance value parsing. Diffs - src/common/values.cpp 587cb68551d438621e215953e89818b623b7f71b Diff: https://reviews.apache.org/r/49223/diff/ Testing --- make Thanks, Klaus Ma

Review Request 49140: Added startsWith/endsWith to support char.

2016-06-23 Thread Klaus Ma
Thanks, Klaus Ma

Re: Review Request 48914: Added GPU_RESOURCES capability to FrameworkInfo.

2016-06-19 Thread Klaus Ma
> On June 19, 2016, 10:18 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1277-1279 > > > > > > This logic seems also allow agents without gpu resources offered to the > > framework

Re: Review Request 48593: Refactor Ranges Subtraction.

2016-06-13 Thread Klaus Ma
> On June 13, 2016, 11:40 a.m., Klaus Ma wrote: > > src/common/values.cpp, lines 411-419 > > <https://reviews.apache.org/r/48593/diff/2/?file=1415977#file1415977line411> > > > > Any data on performance improvement? > > Yanyan Hu wrote: >

Re: Review Request 48593: Refactor Ranges Subtraction.

2016-06-13 Thread Klaus Ma
> On June 13, 2016, 11:40 a.m., Klaus Ma wrote: > > src/common/values.cpp, lines 411-419 > > <https://reviews.apache.org/r/48593/diff/2/?file=1415977#file1415977line411> > > > > Any data on performance improvement? > > Yanyan Hu wrote: >

Re: Review Request 48593: Refactor Ranges Subtraction.

2016-06-12 Thread Klaus Ma
tps://reviews.apache.org/r/48593/#comment202389> Any data on performance improvement? - Klaus Ma On June 12, 2016, 4:03 p.m., Yanyan Hu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 43561: Improve Ranges parsing to handle single values.

2016-06-12 Thread Klaus Ma
having 3 > > levels of `tokenize`? > > Is this code in any critical paths? > > Klaus Ma wrote: > This function is only uesd when parsing resources from string; it only > impacts the duration of `make check`. I'll try it and let you known the > impact. Ru

Re: Review Request 46375: Updated MACHINE_UP_HELP's comments.

2016-06-12 Thread Klaus Ma
iew129614 --- On April 19, 2016, 3:51 p.m., Klaus Ma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revie

Re: Review Request 43561: Improve Ranges parsing to handle single values.

2016-06-11 Thread Klaus Ma
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43561/#review136543 --- On June 11, 2016, 10:29 p.m., Klaus Ma wrote: > > -

Re: Review Request 43561: Improve Ranges parsing to handle single values.

2016-06-11 Thread Klaus Ma
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43561/#review136543 --- On June 11, 2016, 10:29 p.m., Klaus Ma wrote: > > -

Re: Review Request 43561: Improve Ranges parsing to handle single values.

2016-06-11 Thread Klaus Ma
587cb68551d438621e215953e89818b623b7f71b src/tests/values_tests.cpp 929861549e3155c33966896f817f9bf9e6d14354 Diff: https://reviews.apache.org/r/43561/diff/ Testing --- make make check GTEST_FILTER=~"*" ./src/mesos-test Thanks, Klaus Ma

Re: Review Request 48581: Removed duplicated code in 'strings::tokenize()'.

2016-06-11 Thread Klaus Ma
Thanks, Klaus Ma

Review Request 48581: Removed duplicated code in 'strings::tokenize()'.

2016-06-11 Thread Klaus Ma
--- Removed duplicated code in 'strings::tokenize()'. Diffs - 3rdparty/stout/include/stout/strings.hpp 162bdfb6c4f5a6b108761ebccd9b77e672f6dd87 Diff: https://reviews.apache.org/r/48581/diff/ Testing --- Thanks, Klaus Ma

Re: Review Request 46425: Add helper function to simplify tokenize handling.

2016-06-11 Thread Klaus Ma
162bdfb6c4f5a6b108761ebccd9b77e672f6dd87 3rdparty/stout/tests/strings_tests.cpp b54a9dbf162403310b8bba687442e184a473f5a6 Diff: https://reviews.apache.org/r/46425/diff/ Testing --- make && make check Thanks, Klaus Ma

Re: Review Request 48579: Reset "dirty" to false in sort().

2016-06-10 Thread Klaus Ma
ocated}} & {{unallocated}}; and only return clients list in {{sort()}} (the client was sorted when inserted in {{allocated}} & {{unallocated}}). - Klaus Ma On June 11, 2016, 11:42 a.m., Guangya Liu wrote: > > --- > T

Re: Review Request 43561: Improve Ranges parsing to handle single values.

2016-06-09 Thread Klaus Ma
} > > ``` Sorry for un-based code, this's handled in r/45813. - Klaus --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43561/#review136543 ------- On March 22, 2016, 9:22 p.m., Klaus Ma wrote: > >

Re: Review Request 43561: Improve Ranges parsing to handle single values.

2016-06-08 Thread Klaus Ma
n automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43561/#review136543 --- On March 22, 2016, 9:22 p.m., Klaus Ma wrote: > > -

Re: Review Request 46425: Add helper function to simplify tokenize handling.

2016-04-27 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46425/#review130751 --- ping @joris :). - Klaus Ma On April 20, 2016, 1:48 p.m., Klaus

Re: Review Request 43588: Added allocator recovery tests in presence of quota.

2016-04-20 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43588/#review129691 --- ping :). - Klaus Ma On Feb. 23, 2016, 7:55 a.m., Joerg Schad

Re: Review Request 43561: Improve Ranges parsing to handle single values.

2016-04-19 Thread Klaus Ma
> > `foreachtoken(temp, ",\n", [](const string& token) { ... });` > > > > These helpers become rather heavy (at 3 nested) considering their > > utility. > > Klaus Ma wrote: > @joris, I think `foreachtoken` is also nested loop. When doi

Re: Review Request 46425: Add helper function to simplify tokenize handling.

2016-04-19 Thread Klaus Ma
/include/stout/strings.hpp 162bdfb6c4f5a6b108761ebccd9b77e672f6dd87 3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp 7eed0f3d08cd52a07c46b6ad194496186ac205b7 Diff: https://reviews.apache.org/r/46425/diff/ Testing --- make && make check Thanks, Klaus Ma

Review Request 46425: Add helper function to simplify tokenize handling.

2016-04-19 Thread Klaus Ma
/libprocess/3rdparty/stout/tests/strings_tests.cpp 7eed0f3d08cd52a07c46b6ad194496186ac205b7 Diff: https://reviews.apache.org/r/46425/diff/ Testing --- make && make check Thanks, Klaus Ma

Re: Review Request 43561: Improve Ranges parsing to handle single values.

2016-04-19 Thread Klaus Ma
> > `foreachtoken(temp, ",\n", [](const string& token) { ... });` > > > > These helpers become rather heavy (at 3 nested) considering their > > utility. > > Klaus Ma wrote: > @joris, I think `foreachtoken` is also nested loop. When doi

Re: Review Request 43561: Improve Ranges parsing to handle single values.

2016-04-19 Thread Klaus Ma
mp; token) { ... });` > > > > These helpers become rather heavy (at 3 nested) considering their > > utility. > > Klaus Ma wrote: > @joris, I think `foreachtoken` is also nested loop. When doing the > patches, there're three options to me: FSM, regex a

Review Request 46375: Updated MACHINE_UP_HELP's comments.

2016-04-19 Thread Klaus Ma
: mesos Description --- Updated MACHINE_UP_HELP's comments. Diffs - src/master/http.cpp a9cb99a92ff5a783e719df5e5cfb6e8301241df9 Diff: https://reviews.apache.org/r/46375/diff/ Testing --- make Thanks, Klaus Ma

Re: Review Request 46298: Rejected relative path agent work_dir.

2016-04-19 Thread Klaus Ma
create a docker volume for task's sandbox). Or do > > you want to do it in a separate patch? > > Klaus Ma wrote: > I'll submit another patch for that :). @AlexR, I updated usage out for this in this patch. - Klaus --- Thi

Re: Review Request 46298: Rejected relative path agent work_dir.

2016-04-19 Thread Klaus Ma
10d2974bd2b6e79255fc894979607f0d2d00c315 src/slave/main.cpp 38bd00584dd9c6a872398678b2288edeed1cd2a4 Diff: https://reviews.apache.org/r/46298/diff/ Testing --- 1. make && make check 2. e2e test: ``` $ ./src/mesos-slave --work_dir=aa --master=aa The required option `--work_dir` must be absolute path. ``` Thanks

Re: Review Request 46149: Speed up DynamicReservationFramework.

2016-04-18 Thread Klaus Ma
> On April 14, 2016, 7:56 p.m., Benjamin Bannier wrote: > > This is much better, but still long. I see that now most of the time is > > spent in `resourceOffers` -- can you think of a way to speed these up as > > well? > > Klaus Ma wrote: > @Banni

Re: Review Request 46364: Change to explicit case statements (`UNKNOWN`) instead of default.

2016-04-18 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46364/#review129476 --- Ship it! Ship It! - Klaus Ma On April 19, 2016, 11:28 a.m

Re: Review Request 44379: Use tokens size to parse perf stat format.

2016-04-18 Thread Klaus Ma
> On April 11, 2016, 10:09 p.m., Klaus Ma wrote: > > Ship It! > > Klaus Ma wrote: > LGTM. Just wonder how to handle the input that did not follow our > expectation: > > // value,event,cgroup > // value,unit,event,cgroup > /

Re: Review Request 46298: Rejected relative path agent work_dir.

2016-04-18 Thread Klaus Ma
eviews.apache.org/r/46298/#review129313 --- On April 16, 2016, 4:29 p.m., Klaus Ma wrote: > > --- > This is an automatically generated e-mail. To re

Review Request 46298: Rejected relative path agent work_dir.

2016-04-16 Thread Klaus Ma
://reviews.apache.org/r/46298/diff/ Testing --- 1. make && make check 2. e2e test: ``` $ ./src/mesos-slave --work_dir=aa --master=aa The required option `--work_dir` must be absolute path. ``` Thanks, Klaus Ma

  1   2   3   4   5   6   7   >