Re: Review Request 41854: Added module initialization to Master main().

2016-02-13 Thread Marco Massenzio
from 119 test cases ran. (210502 ms total) [ PASSED ] 932 tests. Thanks, Marco Massenzio

Re: Review Request 41760: Add initialization method to Anonymous module

2016-02-12 Thread Marco Massenzio
flags? Would > > we want to expose available master/slave flags as well in include/mesos? > > It's not quite clear what the correct representation would be. > > Marco Massenzio wrote: > Hey Kapil, > > thanks for review! > I'm in the middle of something

Re: Review Request 41854: Added module initialization to Master main() method

2016-02-12 Thread Marco Massenzio
/ Testing --- All unit tests pass. Thanks, Marco Massenzio

Re: Review Request 41854: Added module initialization to Master main() method

2016-02-12 Thread Marco Massenzio
222198ca89f672332cb80773a3f36fe1f0438f64 Diff: https://reviews.apache.org/r/41854/diff/ Testing --- make && make check [==] 932 tests from 119 test cases ran. (210502 ms total) [ PASSED ] 932 tests. Thanks, Marco Massenzio

Re: Review Request 41760: Add initialization method to Anonymous class.

2016-02-12 Thread Marco Massenzio
() for module; parsing runtime flags I0102 17:38:26.181658 19971 execute_module.hpp:139] Configured work dir to [/tmp/agent] and Sandbox dir to [/mnt/mesos/sandbox] ``` Thanks, Marco Massenzio

Re: Review Request 41854: Added module initialization to Master main() method

2016-02-12 Thread Marco Massenzio
src/slave/main.cpp 222198ca89f672332cb80773a3f36fe1f0438f64 Diff: https://reviews.apache.org/r/41854/diff/ Testing (updated) --- make && make check [==] 932 tests from 119 test cases ran. (210502 ms total) [ PASSED ] 932 tests. Thanks, Marco Massenzio

Re: Review Request 41760: Add initialization method to Anonymous module

2016-02-09 Thread Marco Massenzio
bly emitting warnings). - Marco --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41760/#review118242 --- On Jan. 4, 2016,

Re: Review Request 41760: Add initialization method to Anonymous module

2016-01-04 Thread Marco Massenzio
andbox dir to [/mnt/mesos/sandbox] ``` Thanks, Marco Massenzio

Re: Review Request 41760: [WIP] Add init(const FlagsBase&) to Anonymous module

2016-01-02 Thread Marco Massenzio
to module 'com_alertavert_mesos_RemoteExecution' I0102 17:38:26.180810 19971 execute_module.hpp:129] Executing initialize() for module; parsing runtime flags I0102 17:38:26.181658 19971 execute_module.hpp:139] Configured work dir to [/tmp/agent] and Sandbox dir to [/mnt/mesos/sandbox] ``` Thanks, Marco Massenzio

Re: Review Request 41760: [WIP] Add init(const FlagsBase&) to Anonymous module

2016-01-02 Thread Marco Massenzio
228 17:40:37.771086 26127 execute_module.cpp:262] work_dir: /tmp/agent I1228 17:40:37.771389 26127 main.cpp:307] Starting Mesos slave ... ``` Thanks, Marco Massenzio

Review Request 41854: Added module initialization to Master main() method

2016-01-02 Thread Marco Massenzio
://reviews.apache.org/r/41854/diff/ Testing --- All unit tests pass. Thanks, Marco Massenzio

Re: Review Request 41760: [WIP] Add init(const FlagsBase&) to Anonymous module

2016-01-02 Thread Marco Massenzio
r: /tmp/agent I1228 17:40:37.771389 26127 main.cpp:307] Starting Mesos slave ... ``` Thanks, Marco Massenzio

Re: Review Request 40445: Added linter for license headers in some file types.

2015-11-27 Thread Marco Massenzio
ttps://reviews.apache.org/r/40445/#comment167537> this is a bit on the ugly side of things :) and not very readable either (not to mention, not very extensible). Ideally, on would use a combination of RegEx and a comprehension list. - Marco Massenzio On Nov. 25, 2015, 9:5

Re: Review Request 37336: Added `execute()` method to process::Subprocess

2015-11-20 Thread Marco Massenzio
> > <https://reviews.apache.org/r/37336/diff/11/?file=1122403#file1122403line185> > > > > What if outData is called more than once? Great question! I would guess they'll get an empty string (as I assume that `io::read()` is sitting on an empty buffer) but worth lo

Re: Review Request 37336: Added `execute()` method to process::Subprocess

2015-11-20 Thread Marco Massenzio
he caller already have > > those information? > > Marco Massenzio wrote: > not necessarily - please note that this is executed asynchronously, so > the caller may have several of them running concurrently and having the > invocation returned together with the

Re: Review Request 40340: [WIP] Windows: Added Windows support to `support/post-reviews.py`.

2015-11-18 Thread Marco Massenzio
same comment as before support/mesos-style.py (line 97) <https://reviews.apache.org/r/40340/#comment166057> unnecessary parentheses - Marco Massenzio On Nov. 16, 2015, 9:25 a.m., Alex Clemmer wrote: > > --- >

Re: Review Request 40340: [WIP] Windows: Added Windows support to `support/post-reviews.py`.

2015-11-18 Thread Marco Massenzio
ps://reviews.apache.org/r/40340/#comment166072> +1 this is awesome - I wish all our methods were documented in this depth! support/post-reviews.py (line 106) <https://reviews.apache.org/r/40340/#comment166073> ``` while not choice in ['y', 'n', ctrl_d]: ``` - M

Re: Review Request 39410: Added support for github to apply-reviews.py.

2015-11-11 Thread Marco Massenzio
-- On Nov. 11, 2015, 10:10 a.m., Artem Harutyunyan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39410/ > ------- > > (Updated N

Re: Review Request 37336: Simplified the caller interface to process::Subprocess

2015-11-10 Thread Marco Massenzio
ot be here (and/or are confident the pattern above works) I'm happy to have another go at it. - Marco --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37336/#review105544 --- On Nov. 6, 2015, 6:24 a

Re: Review Request 37336: Added `execute()` method to process::Subprocess

2015-11-10 Thread Marco Massenzio
with an anonymous module that exposes an `/execute` endpoint and runs arbitrary commands, asynchronously, on an Agent) Thanks, Marco Massenzio

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

2015-11-06 Thread Marco Massenzio
enerated e-mail. To reply, visit: https://reviews.apache.org/r/39452/#review10 --- On Nov. 6, 2015, 8:35 p.m., Marco Massenzio wrote: > > --- > This

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

2015-11-06 Thread Marco Massenzio
l. To reply, visit: https://reviews.apache.org/r/39452/#review105385 ------- On Nov. 6, 2015, 7:45 p.m., Marco Massenzio wrote: > > --- > This is an automati

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

2015-11-06 Thread Marco Massenzio
de6cfc9e009a857ca45291b2dadce2a3b8199787 Diff: https://reviews.apache.org/r/39452/diff/ Testing (updated) --- Built the site & tested using: https://github.com/apache/mesos/tree/master/support/site-docker Thanks, Marco Massenzio

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

2015-11-06 Thread Marco Massenzio
) to decode. Diffs (updated) - docs/scheduler-http-api.md de6cfc9e009a857ca45291b2dadce2a3b8199787 Diff: https://reviews.apache.org/r/39452/diff/ Testing --- Built the site & tested using: https://github.com/apache/mesos/tree/master/support/site-docker Thanks, Marco Massenzio

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

2015-11-05 Thread Marco Massenzio
) - docs/scheduler-http-api.md de6cfc9e009a857ca45291b2dadce2a3b8199787 Diff: https://reviews.apache.org/r/39452/diff/ Testing --- Thanks, Marco Massenzio

Re: Review Request 37336: Simplified the caller interface to process::Subprocess

2015-11-05 Thread Marco Massenzio
> > > > `Subprocess process(path == "sh" ? Command(argv[2]) : Command(path, > > argv));` well, `invokedWith_` is already "exposed" to `subprocess` - as it's a 'friend' anyway. But I have simplified the invocation, so that it reflects closely what you suggested. - Marco --

Re: Review Request 37336: Simplified the caller interface to process::Subprocess

2015-11-05 Thread Marco Massenzio
and runs arbitrary commands, asynchronously, on an Agent) Thanks, Marco Massenzio

Re: Review Request 37336: Simplified the caller interface to process::Subprocess

2015-11-01 Thread Marco Massenzio
/subprocess_tests.cpp ac600a551fb1a7782ff33cce204b7819497ef54a Diff: https://reviews.apache.org/r/37336/diff/ Testing --- make check Thanks, Marco Massenzio

Re: Review Request 39410: Added support for github to apply-reviews.py.

2015-10-23 Thread Marco Massenzio
> On Oct. 20, 2015, 5:06 a.m., Marco Massenzio wrote: > > support/apply-reviews.py, line 160 > > <https://reviews.apache.org/r/39410/diff/3/?file=1100642#file1100642line160> > > > > you don't really need to escape the quotes, just take advantage of &g

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

2015-10-23 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/#review103778 --- Ship it! Ship It! - Marco Massenzio On Oct. 23, 2015, 6:18 a.m

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

2015-10-23 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39420/#review103779 --- Ship it! Thanks for the "Better Bash" :) - Marco

Re: Review Request 39410: Added support for github to apply-reviews.py.

2015-10-23 Thread Marco Massenzio
ous, I didn't know about the 'mutually exclusive' option!) in other words, don't you get an exception by trying to access **both** `args.github` AND `args.review_id` (because one of the two is missing)? - Marco Massenzio On Oct. 23, 2015, 6:18 a.m.,

Re: Review Request 39410: Added support for github to apply-reviews.py.

2015-10-23 Thread Marco Massenzio
> On Oct. 20, 2015, 5:06 a.m., Marco Massenzio wrote: > > support/apply-reviews.py, line 160 > > <https://reviews.apache.org/r/39410/diff/3/?file=1100642#file1100642line160> > > > > you don't really need to escape the quotes, just take advantage of &g

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

2015-10-23 Thread Marco Massenzio
Bash" :) would you mind "fixing" apply-review.sh? Thanks! - Marco Massenzio On Oct. 23, 2015, 6:19 a.m., Artem Harutyunyan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > ht

Re: Review Request 39410: Added support for github to apply-reviews.py.

2015-10-23 Thread Marco Massenzio
> On Oct. 20, 2015, 5:06 a.m., Marco Massenzio wrote: > > support/apply-reviews.py, line 106 > > <https://reviews.apache.org/r/39410/diff/3/?file=1100642#file1100642line106> > > > > it would be really nice if we could make our code work under both 2.7

Re: Review Request 39514: HTTP Scheduler API no longer allows FrameworkInfo.user to be empty

2015-10-21 Thread Marco Massenzio
> On Oct. 21, 2015, 6:05 p.m., Marco Massenzio wrote: > > include/mesos/v1/mesos.proto, lines 211-213 > > <https://reviews.apache.org/r/39514/diff/1/?file=1102339#file1102339line211> > > > > I know it's not your code, but could you please remove `automagic

Re: Review Request 39514: HTTP Scheduler API no longer allows FrameworkInfo.user to be empty

2015-10-21 Thread Marco Massenzio
e not set a user to run the task as on the agent; " << "unless the --switch_user is set to `false` on the agent " << "this may cause tasks to fail"; ``` - Marc

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

2015-10-20 Thread Marco Massenzio
atically generated e-mail. To reply, visit: https://reviews.apache.org/r/39452/#review103172 ------- On Oct. 19, 2015, 9:07 p.m., Marco Massenzio wrote: > > --- > This is a

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

2015-10-20 Thread Marco Massenzio
de6cfc9e009a857ca45291b2dadce2a3b8199787 Diff: https://reviews.apache.org/r/39452/diff/ Testing --- Thanks, Marco Massenzio

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

2015-10-20 Thread Marco Massenzio
de6cfc9e009a857ca45291b2dadce2a3b8199787 Diff: https://reviews.apache.org/r/39452/diff/ Testing --- Thanks, Marco Massenzio

Re: Review Request 39420: Added '--parent' option and made apply-review.sh call apply-reviews.py.

2015-10-20 Thread Marco Massenzio
-reviews.py (lines 267 - 272) <https://reviews.apache.org/r/39420/#comment161292> did you introduce leading tabs? (it may very well be a RB artifact, difficult to tell) - Marco Massenzio On Oct. 20

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

2015-10-20 Thread Marco Massenzio
ou are probably commenting on a stale version of the patch. - Marco --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39452/#review103314

Re: Review Request 39447: MESOS-3692 - better documented --switch_user flag

2015-10-19 Thread Marco Massenzio
/flags.cpp 1bf394ea62fde29caa6705cd5d156eae452adbf2 src/slave/paths.cpp fb77e64a6da017d8c9a00916d8935b670da0d374 Diff: https://reviews.apache.org/r/39447/diff/ Testing --- make check Thanks, Marco Massenzio

Review Request 39452: MESOS-3566 Description of RecordIO format

2015-10-19 Thread Marco Massenzio
://reviews.apache.org/r/39452/diff/ Testing --- Thanks, Marco Massenzio

Re: Review Request 39447: MESOS-3692 - better documented --switch_user flag

2015-10-19 Thread Marco Massenzio
f the sentence, so it should still look good. - Marco --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39447/#review103148 ------- On Oc

Re: Review Request 39447: MESOS-3692 - better documented --switch_user flag

2015-10-19 Thread Marco Massenzio
69fb37fc38e52277605b82cf67067168a37d79a6 src/slave/flags.cpp 1bf394ea62fde29caa6705cd5d156eae452adbf2 src/slave/paths.cpp fb77e64a6da017d8c9a00916d8935b670da0d374 Diff: https://reviews.apache.org/r/39447/diff/ Testing --- make check Thanks, Marco Massenzio

Re: Review Request 39447: MESOS-3692 - better documented --switch_user flag

2015-10-19 Thread Marco Massenzio
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39447/#review103146 --- On Oct. 19, 2015, 7:06 p.m., Marco Massenzio wrote: > > --

Re: Review Request 39452: MESOS-3566 Description of RecordIO format

2015-10-19 Thread Marco Massenzio
de6cfc9e009a857ca45291b2dadce2a3b8199787 Diff: https://reviews.apache.org/r/39452/diff/ Testing --- Thanks, Marco Massenzio

Re: Review Request 39447: MESOS-3692 - better documented --switch_user flag

2015-10-19 Thread Marco Massenzio
(updated) --- make check Thanks, Marco Massenzio

Re: Review Request 39449: Documented order of includes.

2015-10-19 Thread Marco Massenzio
er/flags.cpp` then `master/flags.hpp` should be included first. - Marco Massenzio On Oct. 19, 2015, 6:58 p.m., Jan Schlicht wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Review Request 39447: MESOS-3692 - better documented --switch_user flag

2015-10-19 Thread Marco Massenzio
://reviews.apache.org/r/39447/diff/ Testing --- Thanks, Marco Massenzio

Re: Review Request 39447: MESOS-3692 - better documented --switch_user flag

2015-10-19 Thread Marco Massenzio
69fb37fc38e52277605b82cf67067168a37d79a6 src/slave/flags.cpp 1bf394ea62fde29caa6705cd5d156eae452adbf2 src/slave/paths.cpp fb77e64a6da017d8c9a00916d8935b670da0d374 Diff: https://reviews.apache.org/r/39447/diff/ Testing --- make check Thanks, Marco Massenzio

Re: Review Request 39447: MESOS-3692 - better documented --switch_user flag

2015-10-19 Thread Marco Massenzio
------ On Oct. 19, 2015, 9:27 p.m., Marco Massenzio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39447/ > ---

Re: Review Request 39447: MESOS-3692 - better documented --switch_user flag

2015-10-19 Thread Marco Massenzio
Thanks, Marco Massenzio

Re: Review Request 39410: Added support for github to apply-reviews.py.

2015-10-19 Thread Marco Massenzio
arg is not there?) support/apply-reviews.py (lines 265 - 270) <https://reviews.apache.org/r/39410/#comment161193> this code look familiar and I remember already commenting about `applied` :) - Marco Massenzio On Oct. 18, 2015, 10:32 p.m., Artem Harutyunyan wrote: > > --

Re: Review Request 37336: Simplified the caller interface to process::Subprocess

2015-10-18 Thread Marco Massenzio
cess/src/subprocess.cpp a457cbe35ad33531c49f74550cd570cf28758f5d 3rdparty/libprocess/src/tests/subprocess_tests.cpp ac600a551fb1a7782ff33cce204b7819497ef54a Diff: https://reviews.apache.org/r/37336/diff/ Testing --- make check Thanks, Marco Massenzio

Re: Review Request 39386: Fix uncorrect launcher dir in docker executor.

2015-10-16 Thread Marco Massenzio
> On Oct. 16, 2015, 5:30 p.m., Marco Massenzio wrote: > > Thanks for doing this. > > > > I think you will need to document the flags' usage in `configuration.md` > > (or wherever appropriate) and state clearly that it's **required** and what > > it should poin

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

2015-10-16 Thread Marco Massenzio
> On Oct. 16, 2015, 4:15 p.m., Marco Massenzio wrote: > > Ship It! Thanks for addressing comments! - Marco --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/#rev

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

2015-10-16 Thread Marco Massenzio
> On Oct. 14, 2015, 4:45 p.m., Marco Massenzio wrote: > > support/apply-reviews.py, line 40 > > <https://reviews.apache.org/r/38883/diff/3/?file=1093293#file1093293line40> > > > > (setting aside for a second that we should use `requests.get()` instead >

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

2015-10-16 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38883/#review102921 --- Ship it! Ship It! - Marco Massenzio On Oct. 16, 2015, 3:29 p.m

Re: Review Request 37336: Simplified the caller interface to process::Subprocess

2015-10-16 Thread Marco Massenzio
/subprocess_tests.cpp ab7515325e5db0a4fd222bb982f51243d7b7e39d Diff: https://reviews.apache.org/r/37336/diff/ Testing --- make check Thanks, Marco Massenzio

Re: Review Request 37336: Simplified the caller interface to process::Subprocess

2015-10-16 Thread Marco Massenzio
a457cbe35ad33531c49f74550cd570cf28758f5d 3rdparty/libprocess/src/tests/subprocess_tests.cpp ac600a551fb1a7782ff33cce204b7819497ef54a Diff: https://reviews.apache.org/r/37336/diff/ Testing --- make check Thanks, Marco Massenzio

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

2015-10-16 Thread Marco Massenzio
> On Oct. 16, 2015, 4:15 p.m., Marco Massenzio wrote: > > Ship It! > > Marco Massenzio wrote: > Thanks for addressing comments! hey, minor nit: I've just noticed you insert whitespaces around named args: ``` "".format(url = USER_URL, user = us

Re: Review Request 39386: Fix uncorrect launcher dir in docker executor.

2015-10-16 Thread Marco Massenzio
tps://reviews.apache.org/r/39386/#comment160768> Please note it is a "required" option and what it it is meant to be used for (and, ideally, what it should point to). - Marco Massenzio On Oct. 16, 2015, 5:17 a.m., haos

Re: Review Request 39338: Added code that appends the fetcher log to the agent log upon fetcher failure.

2015-10-15 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39338/#review102848 --- Ship it! Ship It! - Marco Massenzio On Oct. 15, 2015, 1:11 p.m

Re: Review Request 38883: Removed calls to apply-review.sh script. Added support for amending commit messages.

2015-10-14 Thread Marco Massenzio
'url': review_url(review_id), 'author': user['fullname'], 'email': user['email'] 'message': '\n\n'.join([review['summary'], review['description'],

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

2015-10-14 Thread Marco Massenzio
g it as a `set`?): ``` applied = set() for review, summary in reviews: if review not in applied: applied.add(review) print(apply_review(...)) ``` - Marco Massenzio On Oct. 8, 2015, 6:26 p.m., Artem Harutyunyan wrote: > >

Re: Review Request 38627: Adds an overload of ModuleManager::create() allowing overriding parameters programatically

2015-10-12 Thread Marco Massenzio
and (b) I'd expect it anyway to be an `int` of some sort. Could you please consider renaming it to be something more expressive? thanks! - Marco Massenzio On Oct. 2, 2015, 8:11 p.m., Alexander Rojas wrote: > > --- > This

Re: Review Request 37336: Simplified the caller interface to process::Subprocess

2015-10-12 Thread Marco Massenzio
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37336/#review102243 --- On Oct. 12, 2015, 12:29 p.m., Marco Massenzio wrote: > > --

Re: Review Request 37024: Exposes mesos version information in components.

2015-10-05 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37024/#review101506 --- Ship it! Ship It! - Marco Massenzio On Oct. 5, 2015, 8 a.m

Re: Review Request 37024: Exposes mesos version information in components.

2015-10-05 Thread Marco Massenzio
tps://reviews.apache.org/r/37024/#comment158928> Minor nit: s/mesos/Apache Mesos and I think you can drop the "This endpoint" - "Shows the current version and build information for Apache Mesos" or something like that... - Marco Massenzio On Oct. 5, 2015, 8

Re: Review Request 37024: Exposes mesos version information in components.

2015-10-05 Thread Marco Massenzio
> On Oct. 5, 2015, 6:48 p.m., Marco Massenzio wrote: > > src/version/version.cpp, lines 81-82 > > <https://reviews.apache.org/r/37024/diff/6/?file=1090173#file1090173line81> > > > > Minor nit: s/mesos/Apache Mesos and I think you can drop the "This >

Re: Review Request 38416: Allow HTTP response codes to be checked with code.

2015-10-01 Thread Marco Massenzio
00: # yuk! we hit the skids ``` - Marco Massenzio On Sept. 25, 2015, 10:38 p.m., Timothy Chen wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 38416: Allow HTTP response codes to be checked with code.

2015-10-01 Thread Marco Massenzio
> On Oct. 1, 2015, 7:40 p.m., Marco Massenzio wrote: > > 3rdparty/libprocess/src/http.cpp, lines 75-160 > > <https://reviews.apache.org/r/38416/diff/3/?file=1084845#file1084845line75> > > > > +1 for the map > > > > I am also wondering

Re: Review Request 38473: Add flag to disable hostname lookup.

2015-09-21 Thread Marco Massenzio
/master_tests.cpp f26344d39543f65f2b0a94b8ff566836c8256bf7 Diff: https://reviews.apache.org/r/38473/diff/ Testing --- make check Thanks, Marco Massenzio

Re: Review Request 38473: Add flag to disable hostname lookup.

2015-09-21 Thread Marco Massenzio
t; detail for why not using the solution as above? What is the benefit of this > compared to using --host_name=$LIBPROCESS_IP? Thanks. > > Marco Massenzio wrote: > `$LIBPROCESS_IP` may not be set by the time we run the binary - it is > actually set in the `main()` method (of bot

Re: Review Request 38457: CMake: Fix MESOS-3250, a dynamic load error in Stout tests on OS X.

2015-09-21 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38457/#review99757 --- Ship it! Ship It! - Marco Massenzio On Sept. 21, 2015, 2:43 a.m

Re: Review Request 38473: Add flag to disable hostname lookup.

2015-09-21 Thread Marco Massenzio
elieve in karma :) ) Anyways, figured out that (a) this needs to be an `ASSERT_EQ` (as we `master.get()` in the following EXPECT) and (b) the comment here may actually be unnecessary, so I've removed it. - Marco --- This is an automati

Re: Review Request 38473: Add flag to disable hostname lookup.

2015-09-21 Thread Marco Massenzio
t; detail for why not using the solution as above? What is the benefit of this > compared to using --host_name=$LIBPROCESS_IP? Thanks. > > Marco Massenzio wrote: > `$LIBPROCESS_IP` may not be set by the time we run the binary - it is > actually set in the `main()` method (of bot

Re: Review Request 38473: Add flag to disable hostname lookup.

2015-09-19 Thread Marco Massenzio
/reviews.apache.org/r/38473/#review99628 --- On Sept. 19, 2015, 1:25 a.m., Marco Massenzio wrote: > > --- > This is an automatically generated e-mail. To r

Re: Review Request 38457: CMake: Fix MESOS-3250, a dynamic load error in Stout tests on OS X.

2015-09-19 Thread Marco Massenzio
> On Sept. 17, 2015, 4:44 p.m., Marco Massenzio wrote: > > I'm excited about this! > > Tested on OSX and (at least, as far as stout_tests go, it works, yay!) > > > > A quick question: why, instead of moving the files, we don't simply add a > > symlink that wi

Re: Review Request 38473: Add flag to disable hostname lookup.

2015-09-18 Thread Marco Massenzio
3db97aca921c9216d90384e1eb17030849516454 Diff: https://reviews.apache.org/r/38473/diff/ Testing --- make check Thanks, Marco Massenzio

Re: Review Request 38473: Add flag to disable hostname lookup.

2015-09-18 Thread Marco Massenzio
/mesos.hpp 3db97aca921c9216d90384e1eb17030849516454 Diff: https://reviews.apache.org/r/38473/diff/ Testing --- make check Thanks, Marco Massenzio

Re: Review Request 38454: Fix failed test LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids

2015-09-17 Thread Marco Massenzio
by just having ASSERT(true) :) BTW - it's fantastic this fixed the issue and you did the repeat-cycle test! - Marco Massenzio On Sept. 17, 2015, 9:55 a.m., Jian Qiu wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 38457: CMake: Fix MESOS-3250, a dynamic load error in Stout tests on OS X.

2015-09-17 Thread Marco Massenzio
is - can't wait to bid farewell to CDT for good. - Marco Massenzio On Sept. 17, 2015, 10:03 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revi

Re: Review Request 38259: [MESOS-3340] Command-line flags should take precedence over OS Env variables

2015-09-14 Thread Marco Massenzio
and then in Cmd Line too, and verify that it "works as intended"? Thanks for bearing with me and changing your code. I think it looks clean and nice now :) - Marco Massenzio On Sept. 13, 2015, 5:30 a.m., Klau

Re: Review Request 38259: [MESOS-3340] Command-line flags should take precedence over OS Env variables

2015-09-11 Thread Marco Massenzio
r method, you can just unit test that one - once - for both cases; without having to repeat the test, below) Thanks for doing this! A few comments, but generally good. Not sure if you have a shepherd for this - if not, please let me know and I can help find one.

Re: Review Request 38259: [MESOS-3340] Command-line flags should take precedence over OS Env variables

2015-09-11 Thread Marco Massenzio
an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38259/ > --- > > (Updated Sept. 11, 2015, 9:54 a.m.) > > > Review request for mesos, Bernd Mathiske and Marco Massenzio. > &

Re: Review Request 38259: [MESOS-3340] Command-line flags should take precedence over OS Env variables

2015-09-11 Thread Marco Massenzio
> On Sept. 11, 2015, 6:56 a.m., Marco Massenzio wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, lines > > 672-681 > > <https://reviews.apache.org/r/38259/diff/2/?file=1068027#file1068027line672> > > > > would it be possib

Re: Review Request 37336: Simplified the caller interface to process::Subprocess

2015-09-08 Thread Marco Massenzio
` Future future = subprocess.wait(); await(future, Seconds(5)); ``` or something along those lines - I wanted to actually "compress" the two calls into one. The question I had was more along the lines: given the current code (and the fact that it seems to "work as

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-09-01 Thread Marco Massenzio
> On Aug. 20, 2015, 7:39 p.m., Marco Massenzio wrote: > > include/mesos/scheduler/scheduler.proto, lines 314-315 > > <https://reviews.apache.org/r/37532/diff/1/?file=1042006#file1042006line314> > > > > This comments does not read well: what is the timeout? al

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-09-01 Thread Marco Massenzio
> On Aug. 20, 2015, 7:39 p.m., Marco Massenzio wrote: > > include/mesos/scheduler/scheduler.proto, lines 314-315 > > <https://reviews.apache.org/r/37532/diff/1/?file=1042006#file1042006line314> > > > > This comments does not read well: what is the timeout? al

Re: Review Request 37684: Added symlink test for /bin, lib, and /lib64.

2015-08-21 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37684/#review96054 --- Ship it! Ship It! - Marco Massenzio On Aug. 21, 2015, 4:51 p.m

Re: Review Request 37336: [WIP] Added `wait()` method to process::Subprocess

2015-08-20 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37336/#review95658 --- On Aug. 15, 2015, 2:02 a.m., Marco Massenzio wrote

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-08-20 Thread Marco Massenzio
confidence that this whole thing works. Also - some tests around more complex filtering (if any? maybe this is there is, then it's fine). - Marco Massenzio On Aug. 17, 2015, 1:47 p.m., Guangya Liu wrote: --- This is an automatically

Re: Review Request 37617: Added an error message to MesosContainerizerLaunch command.

2015-08-19 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37617/#review95891 --- Ship it! Ship It! - Marco Massenzio On Aug. 19, 2015, 6:26 p.m

Re: Review Request 37584: Fix bug accessing error() when no Error

2015-08-18 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37584/#review95754 --- On Aug. 18, 2015, 5:24 p.m., Marco Massenzio wrote

Review Request 37584: Fix bug accessing error() when no Error

2015-08-18 Thread Marco Massenzio
Master. This fixes it. Diffs - src/launcher/fetcher.cpp f8b46b8f957942d0cfdc45d3361f52dae3e514a3 Diff: https://reviews.apache.org/r/37584/diff/ Testing --- make check Thanks, Marco Massenzio

Re: Review Request 37208: Fix the spell error in help message of slave component.

2015-08-17 Thread Marco Massenzio
of my colleagues at Mesosphere to commit this. In general, no matter how small the patch, it's always advisable to have a shepherd (ie, someone with 'committer' status) to help commit the patch. - Marco Massenzio On Aug. 17, 2015, 6:50 a.m., Yong Qiao Wang wrote

Re: Review Request 33339: Add a Java example framework to test persistent volumes.

2015-08-17 Thread Marco Massenzio
MESOS_SOURCE_DIR) if [[ -z ${HAS_ENV} ]]; then echo ... exit 1 fi ``` same for BUILD_DIR - Marco Massenzio On June 21, 2015, 9:57 a.m., haosdent huang wrote: --- This is an automatically generated e-mail

  1   2   3   4   >