Re: Review Request 69572: Validated that resource providers use correct ID in operation states.

2018-12-18 Thread Mesos Reviewbot Windows
. Reviews applied: `['69569', '69572']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2721/mesos-review-69572 - Mesos Reviewbot Windows On Dec. 17, 2018, 9:56 a.m., Benjamin Bannier wrote

Re: Review Request 69493: Documented the `linux/seccomp` isolator.

2018-12-18 Thread Mesos Reviewbot Windows
command: `python.exe .\support\apply-reviews.py -n -r 67844` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2720/mesos-review-69493 Relevant logs: - [apply-review-67844.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos

Re: Review Request 69582: Added a test to verify a bug fix for the master.

2018-12-18 Thread Mesos Reviewbot Windows
. Reviews applied: `['69581', '69582']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2719/mesos-review-69582 - Mesos Reviewbot Windows On Dec. 18, 2018, 9:08 a.m., Greg Mann wrote

Re: Review Request 69579: Added a test `ROOT_UNPRIVILEGED_USER_TaskSandboxLocalPersistentVolume`.

2018-12-18 Thread Mesos Reviewbot Windows
logs. Reviews applied: `['69342', '69541', '69542', '69543', '69478', '69553', '69479', '69544', '67997', '68162', '68163', '69547', '69579']` Failed command: `Start-MesosCITesting` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing

Re: Review Request 69578: Set up `Object.value` for `CREATE_DISK` and `REMOVE_DISK` authorization.

2018-12-17 Thread Mesos Reviewbot Windows
. Reviews applied: `['69571', '69563', '69577', '69578']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2717/mesos-review-69578 - Mesos Reviewbot Windows On Dec. 18, 2018, 6:14 a.m., Chun-Hung Hsiao wrote

Re: Review Request 69575: WIP: Send operation feedback when agent is marked as gone.

2018-12-17 Thread Mesos Reviewbot Windows
logs. Reviews applied: `['69575']` Failed command: `Start-MesosCITesting` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2716/mesos-review-69575 Relevant logs: - [mesos-tests-cmake.log](http://dcos-win.westus2

Re: Review Request 69563: Made master to authorize `CREATE_DISK` and `DESTROY_DISK` properly.

2018-12-17 Thread Mesos Reviewbot Windows
logs. Reviews applied: `['69571', '69563']` Failed command: `Start-MesosCITesting` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2715/mesos-review-69563 Relevant logs: - [mesos-tests.log](http://dcos-win.westus2

Re: Review Request 69082: Correctly propagated `close` failures in some instances.

2018-12-17 Thread Mesos Reviewbot
: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Dec. 17, 2018, 10:54 a.m., Benjamin Bannier wrote

Re: Review Request 69559: Simplified verify-reviews.py to be more similar to the Python 2 script.

2018-12-17 Thread Mesos Reviewbot Windows
. Reviews applied: `['69559']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2714/mesos-review-69559 - Mesos Reviewbot Windows On Dec. 17, 2018, 3:55 p.m., Armand Grillet wrote

Re: Review Request 69082: Correctly propagated `close` failures in some instances.

2018-12-17 Thread Mesos Reviewbot Windows
. Reviews applied: `['69082']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2713/mesos-review-69082 - Mesos Reviewbot Windows On Dec. 17, 2018, 10:54 a.m., Benjamin Bannier wrote

Re: Review Request 69572: Validated that resource providers use correct ID in operation states.

2018-12-17 Thread Mesos Reviewbot Windows
. Reviews applied: `['69569', '69572']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2712/mesos-review-69572 - Mesos Reviewbot Windows On Dec. 17, 2018, 9:56 a.m., Benjamin Bannier wrote

Re: Review Request 69398: Added validation for framework IDs.

2018-12-17 Thread Mesos Reviewbot Windows
. Reviews applied: `['69397', '69557', '69398']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2711/mesos-review-69398 - Mesos Reviewbot Windows On Dec. 17, 2018, 8:43 a.m., Benjamin Bannier wrote

Re: Review Request 69563: Made master to authorize `CREATE_DISK` and `DESTROY_DISK` properly.

2018-12-17 Thread Mesos Reviewbot Windows
. Reviews applied: `['69571', '69563']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2710/mesos-review-69563 - Mesos Reviewbot Windows On Dec. 17, 2018, 7:30 a.m., Chun-Hung Hsiao wrote

Re: Review Request 69338: Change agent to not report disconnected resource providers.

2018-12-14 Thread Mesos Reviewbot Windows
. Reviews applied: `['69337', '69338']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2709/mesos-review-69338 - Mesos Reviewbot Windows On Dec. 14, 2018, 3:56 p.m., Benjamin Bannier wrote

Re: Review Request 69569: Added missing code to set resource provider and agent ids.

2018-12-14 Thread Mesos Reviewbot Windows
logs. Reviews applied: `['69569']` Failed command: `Start-MesosCITesting` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2708/mesos-review-69569 Relevant logs: - [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com

Re: Review Request 69559: Simplified verify-reviews.py to be more similar to the Python 2 script.

2018-12-14 Thread Mesos Reviewbot Windows
. Reviews applied: `['69559']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2707/mesos-review-69559 - Mesos Reviewbot Windows On Dec. 13, 2018, 3:59 p.m., Armand Grillet wrote

Re: Review Request 69338: Change agent to not report disconnected resource providers.

2018-12-13 Thread Mesos Reviewbot
command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Dec. 13, 2018, 1:51 p.m., Benjamin Bannier wrote

Re: Review Request 69563: Made master process authorization results properly for offer operations.

2018-12-13 Thread Mesos Reviewbot Windows
. Reviews applied: `['69563']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2706/mesos-review-69563 - Mesos Reviewbot Windows On Dec. 14, 2018, 1:55 a.m., Chun-Hung Hsiao wrote

Re: Review Request 69522: Tested the `Resource.DiskInfo.Source.vendor` field in related tests.

2018-12-13 Thread Mesos Reviewbot Windows
. Reviews applied: `['69037', '69520', '69521', '69522']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2705/mesos-review-69522 - Mesos Reviewbot Windows On Dec. 13, 2018, 2:22 p.m., Chun-Hung Hsiao wrote

Re: Review Request 69551: Renamed `Metrics()` function in test utils.

2018-12-13 Thread Mesos Reviewbot Windows
. Reviews applied: `['69551']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2704/mesos-review-69551 - Mesos Reviewbot Windows On Dec. 13, 2018, 2:23 p.m., Benno Evers wrote

Re: Review Request 69559: Simplified verify-reviews.py to be more similar to the Python 2 script.

2018-12-13 Thread Mesos Reviewbot Windows
. Reviews applied: `['69559']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2703/mesos-review-69559 - Mesos Reviewbot Windows On Dec. 13, 2018, 3:59 p.m., Armand Grillet wrote

Re: Review Request 69338: Change agent to not report disconnected resource providers.

2018-12-13 Thread Mesos Reviewbot Windows
logs. Reviews applied: `['69337', '69338']` Failed command: `Start-MesosCITesting` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2702/mesos-review-69338 Relevant logs: - [mesos-tests.log](http://dcos-win.westus2

Re: Review Request 69445: WIP: Moved `ReadOnlyHandler` into separate header.

2018-12-12 Thread Mesos Reviewbot Windows
. Reviews applied: `['69071', '68795', '69421', '69064', '69422', '69445']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2701/mesos-review-69445 - Mesos Reviewbot Windows On Dec. 12, 2018, 12:54 p.m., Benno Evers wrote

Re: Review Request 69559: Simplified verify-reviews.py to be more similar to the Python 2 script.

2018-12-12 Thread Mesos Reviewbot Windows
. Reviews applied: `['69559']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2700/mesos-review-69559 - Mesos Reviewbot Windows On Dec. 12, 2018, 2:19 p.m., Armand Grillet wrote

Re: Review Request 66815: Removed an unconditional .get() in DefaultExecutor.

2018-12-12 Thread Mesos Reviewbot Windows
. Reviews applied: `['66815']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2699/mesos-review-66815 - Mesos Reviewbot Windows On Dec. 12, 2018, 1:33 p.m., Benno Evers wrote

Re: Review Request 69557: Removed redundant handling of empty framework IDs.

2018-12-12 Thread Mesos Reviewbot Windows
. Reviews applied: `['69397', '69398', '69557']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2698/mesos-review-69557 - Mesos Reviewbot Windows On Dec. 12, 2018, 11:29 a.m., Benjamin Bannier wrote

Re: Review Request 69551: Renamed `Metrics()` function in test utils.

2018-12-11 Thread Mesos Reviewbot Windows
. Reviews applied: `['69551']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2696/mesos-review-69551 - Mesos Reviewbot Windows On Dec. 11, 2018, 1:20 p.m., Benno Evers wrote

Re: Review Request 69398: Added validation for framework IDs.

2018-12-11 Thread Mesos Reviewbot Windows
. Reviews applied: `['69397', '69398']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2697/mesos-review-69398 - Mesos Reviewbot Windows On Dec. 11, 2018, 1:48 p.m., Benjamin Bannier wrote

Re: Review Request 69547: Added a test `ROOT_UNPRIVILEGED_USER_TaskSandboxSharedPersistentVolume`.

2018-12-11 Thread Mesos Reviewbot Windows
. Reviews applied: `['69342', '69541', '69542', '69543', '69478', '69479', '69544', '67997', '68162', '68163', '69547']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2695/mesos-review-69547 - Mesos Reviewbot Windows On Dec. 11

Re: Review Request 69547: Added a test `ROOT_UNPRIVILEGED_USER_TaskSandboxSharedPersistentVolume`.

2018-12-10 Thread Mesos Reviewbot Windows
logs. Reviews applied: `['69342', '69541', '69542', '69543', '69478', '69479', '69544', '67997', '68162', '68163', '69547']` Failed command: `Start-MesosCITesting` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2694/mesos-review

Re: Review Request 69474: Added tests for agent/executor heartbeating.

2018-12-10 Thread Mesos Reviewbot Windows
logs. Reviews applied: `['69463', '69472', '69473', '69474']` Failed command: `Start-MesosCITesting` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2693/mesos-review-69474 Relevant logs: - [mesos-tests.log](http://dcos

Re: Review Request 69544: Made non-root containers can access shared persistent volume.

2018-12-10 Thread Mesos Reviewbot Windows
logs. Reviews applied: `['69342', '69541', '69542', '69543', '69478', '69479', '69544']` Failed command: `Start-MesosCITesting` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2692/mesos-review-69544 Relevant logs: - [mesos

Re: Review Request 69505: Added an operation status update manager to the agent.

2018-12-10 Thread Mesos Reviewbot Windows
logs. Reviews applied: `['69505']` Failed command: `Start-MesosCITesting` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2691/mesos-review-69505 Relevant logs: - [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com

Re: Review Request 69514: Added gauge metric for operator event stream subscribers.

2018-12-10 Thread Mesos Reviewbot Windows
. Reviews applied: `['69307', '69514']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2690/mesos-review-69514 - Mesos Reviewbot Windows On Dec. 10, 2018, 10:24 p.m., Joseph Wu wrote

Re: Review Request 69545: Refactored `LinuxFilesystemIsolator{Test, MesosTest}` tests.

2018-12-10 Thread Mesos Reviewbot Windows
. Reviews applied: `['69540', '69545']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2689/mesos-review-69545 - Mesos Reviewbot Windows On Dec. 10, 2018, 6:37 p.m., Andrei Budnik wrote

Re: Review Request 69544: Made non-root containers can access shared persistent volume.

2018-12-10 Thread Mesos Reviewbot Windows
logs. Reviews applied: `['69342', '69541', '69542', '69543', '69478', '69479', '69544']` Failed command: `Start-MesosCITesting` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2688/mesos-review-69544 Relevant logs: - [mesos

Re: Review Request 69540: Added `ROOT_PseudoDevicesWithRootFilesystem` test.

2018-12-10 Thread Mesos Reviewbot Windows
. Reviews applied: `['69540']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2687/mesos-review-69540 - Mesos Reviewbot Windows On Dec. 10, 2018, 4:41 p.m., Andrei Budnik wrote

Re: Review Request 69538: Added UCR bridge network for Mesos Mini.

2018-12-09 Thread Mesos Reviewbot Windows
logs. Reviews applied: `['69538']` Failed command: `Start-MesosCITesting` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2686/mesos-review-69538 Relevant logs: - [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com

Re: Review Request 69532: Made sure containers runtime dir has device file access.

2018-12-09 Thread Mesos Reviewbot Windows
logs. Reviews applied: `['69537', '69532']` Failed command: `Start-MesosCITesting` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2685/mesos-review-69532 Relevant logs: - [mesos-tests.log](http://dcos-win.westus2

Re: Review Request 69532: Made sure containers runtime dir has device file access.

2018-12-07 Thread Mesos Reviewbot Windows
logs. Reviews applied: `['69532']` Failed command: `Start-MesosCITesting` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2684/mesos-review-69532 Relevant logs: - [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com

Re: Review Request 69474: Added tests for agent/executor heartbeating.

2018-12-07 Thread Mesos Reviewbot Windows
. Reviews applied: `['69463', '69472', '69473', '69474']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2683/mesos-review-69474 - Mesos Reviewbot Windows On Dec. 7, 2018, 2:18 p.m., Joseph Wu wrote

Re: Review Request 69528: Fixed a regression in binding GPU container devices.

2018-12-07 Thread Mesos Reviewbot Windows
. Reviews applied: `['69528']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2682/mesos-review-69528 - Mesos Reviewbot Windows On Dec. 7, 2018, 11:41 a.m., James Peach wrote

Re: Review Request 69522: Tested the `Resource.DiskInfo.Source.vendor` field in related tests.

2018-12-06 Thread Mesos Reviewbot Windows
. Reviews applied: `['69037', '69520', '69521', '69522']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2681/mesos-review-69522 - Mesos Reviewbot Windows On Dec. 7, 2018, 4:37 a.m., Chun-Hung Hsiao wrote

Re: Review Request 69516: Fixed a flaky test EndpointCreateThenOfferRemove.

2018-12-06 Thread Mesos Reviewbot Windows
. Reviews applied: `['69516']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2680/mesos-review-69516 - Mesos Reviewbot Windows On Dec. 6, 2018, 3:54 p.m., Meng Zhu wrote

Re: Review Request 68785: Added jsonschema.py for managing json-based configs.

2018-12-05 Thread Mesos Reviewbot Windows
logs. Reviews applied: `['68785']` Failed command: `Start-MesosCITesting` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2679/mesos-review-68785 Relevant logs: - [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com

Re: Review Request 66649: Added pb2gen.sh for generating python protobuf bindings.

2018-12-05 Thread Mesos Reviewbot Windows
. Reviews applied: `['66649']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2678/mesos-review-66649 - Mesos Reviewbot Windows On Dec. 6, 2018, 4:26 a.m., Eric Chung wrote

Re: Review Request 69514: Added gauge metric for operator event stream subscribers.

2018-12-05 Thread Mesos Reviewbot Windows
logs. Reviews applied: `['69307', '69514']` Failed command: `Start-MesosCITesting` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2677/mesos-review-69514 Relevant logs: - [mesos-tests.log](http://dcos-win.westus2

Re: Review Request 69474: Added tests for agent/executor heartbeating.

2018-12-05 Thread Mesos Reviewbot Windows
. Reviews applied: `['69463', '69472', '69473', '69474']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2676/mesos-review-69474 - Mesos Reviewbot Windows On Dec. 6, 2018, 1:26 a.m., Joseph Wu wrote

Re: Review Request 68654: Enabled isort for src/python/lib.

2018-12-05 Thread Mesos Reviewbot Windows
. Reviews applied: `['68654']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2675/mesos-review-68654 - Mesos Reviewbot Windows On Dec. 6, 2018, 1:26 a.m., Eric Chung wrote

Re: Review Request 67185: Added request_protobuf to mesos.http.

2018-12-05 Thread Mesos Reviewbot Windows
. Reviews applied: `['67185']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2674/mesos-review-67185 - Mesos Reviewbot Windows On Dec. 5, 2018, 5:28 p.m., Eric Chung wrote

Re: Review Request 69098: Added a benchmark to compare quota and nonquota allocation performance.

2018-12-05 Thread Mesos Reviewbot Windows
. Reviews applied: `['69092', '69093', '69094', '69096', '69097', '69098']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2673/mesos-review-69098 - Mesos Reviewbot Windows On Oct. 22, 2018, 3:39 p.m., Meng Zhu wrote

Re: Review Request 69514: Added gauge metric for operator event stream subscribers.

2018-12-05 Thread Mesos Reviewbot Windows
. Reviews applied: `['69307', '69514']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2672/mesos-review-69514 - Mesos Reviewbot Windows On Dec. 5, 2018, 10:03 p.m., Joseph Wu wrote

Re: Review Request 69513: Manually copy test reports to host fs.

2018-12-05 Thread Mesos Reviewbot Windows
. Reviews applied: `['69513']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2671/mesos-review-69513 - Mesos Reviewbot Windows On Dec. 5, 2018, 7:52 p.m., Vinod Kone wrote

Re: Review Request 69493: Documented the `linux/seccomp` isolator.

2018-12-05 Thread Mesos Reviewbot
tar.gz' error: binary patch does not apply to '3rdparty/libseccomp-2.3.3.tar.gz' error: 3rdparty/libseccomp-2.3.3.tar.gz: patch does not apply Full log: https://builds.apache.org/job/Mesos-Reviewbot/23592/console - Mesos Reviewbot On Nov. 30, 2018, 4:33 p.m., Andrei

Re: Review Request 69493: Documented the `linux/seccomp` isolator.

2018-12-05 Thread Mesos Reviewbot Windows
command: `python.exe .\support\apply-reviews.py -n -r 67844` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2670/mesos-review-69493 Relevant logs: - [apply-review-67844.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos

Re: Review Request 69505: Added an operation status update manager to the agent.

2018-12-04 Thread Mesos Reviewbot Windows
. Reviews applied: `['69505']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2669/mesos-review-69505 - Mesos Reviewbot Windows On Dec. 4, 2018, 10:22 p.m., Greg Mann wrote

Re: Review Request 69211: Improved the code comments for `getContainerDevicesPath`.

2018-12-04 Thread Mesos Reviewbot Windows
. Reviews applied: `['69086', '69210', '69450', '69211']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2668/mesos-review-69211 - Mesos Reviewbot Windows On Dec. 4, 2018, 1:19 a.m., James Peach wrote

Re: Review Request 69211: Improved the code comments for `getContainerDevicesPath`.

2018-12-03 Thread Mesos Reviewbot Windows
. Reviews applied: `['69086', '69210', '69450', '69211']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2667/mesos-review-69211 - Mesos Reviewbot Windows On Dec. 4, 2018, 9:19 a.m., James Peach wrote

Re: Review Request 69307: Changed master to hold subscribers in a circular buffer.

2018-11-30 Thread Mesos Reviewbot Windows
logs. Reviews applied: `['69307']` Failed command: `Start-MesosCITesting` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2666/mesos-review-69307 Relevant logs: - [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com

Re: Review Request 69452: Added a test for executors sending messages to recovered frameworks.

2018-11-30 Thread Mesos Reviewbot Windows
. Reviews applied: `['69452']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2665/mesos-review-69452 - Mesos Reviewbot Windows On Nov. 28, 2018, 2:20 p.m., Chun-Hung Hsiao wrote

Re: Review Request 69493: Documented the `linux/seccomp` isolator.

2018-11-30 Thread Mesos Reviewbot Windows
command: `python.exe .\support\apply-reviews.py -n -r 67844` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2664/mesos-review-69493 Relevant logs: - [apply-review-67844.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos

Re: Review Request 69452: Added a test for executors sending messages to recovered frameworks.

2018-11-30 Thread Mesos Reviewbot Windows
logs. Reviews applied: `['69452']` Failed command: `Start-MesosCITesting` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2663/mesos-review-69452 Relevant logs: - [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com

Re: Review Request 69490: Implemented recovery for volume gid manager.

2018-11-30 Thread Mesos Reviewbot Windows
command: `python.exe .\support\apply-reviews.py -n -r 69344` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2662/mesos-review-69490 Relevant logs: - [apply-review-69344.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos

Re: Review Request 69490: Implemented recovery for volume gid manager.

2018-11-30 Thread Mesos Reviewbot Windows
command: `python.exe .\support\apply-reviews.py -n -r 69344` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2661/mesos-review-69490 Relevant logs: - [apply-review-69344.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos

Re: Review Request 69481: Deallocated the shared persistent volume's gid when it is removed.

2018-11-30 Thread Mesos Reviewbot Windows
command: `python.exe .\support\apply-reviews.py -n -r 69344` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2660/mesos-review-69481 Relevant logs: - [apply-review-69344.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos

Re: Review Request 69474: Added tests for agent/executor heartbeating.

2018-11-29 Thread Mesos Reviewbot Windows
logs. Reviews applied: `['69463', '69472', '69473', '69474']` Failed command: `Start-MesosCITesting` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2659/mesos-review-69474 Relevant logs: - [mesos-tests-cmake.log](http://dcos

Re: Review Request 69474: Added tests for agent/executor heartbeating.

2018-11-29 Thread Mesos Reviewbot Windows
logs. Reviews applied: `['69463', '69472', '69473', '69474']` Failed command: `Start-MesosCITesting` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2658/mesos-review-69474 Relevant logs: - [mesos-tests-cmake.log](http://dcos

Re: Review Request 69307: Changed master to hold subscribers in a circular buffer.

2018-11-28 Thread Mesos Reviewbot
: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Nov. 26, 2018, 11:40 p.m., Joseph Wu wrote

Re: Review Request 69420: Added Seccomp isolator tests.

2018-11-28 Thread Mesos Reviewbot Windows
command: `python.exe .\support\apply-reviews.py -n -r 67844` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2657/mesos-review-69420 Relevant logs: - [apply-review-67844.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos

Re: Review Request 69452: Added a test for executors sending messages to recovered frameworks.

2018-11-27 Thread Mesos Reviewbot Windows
. Reviews applied: `['69451', '69464', '69452']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2656/mesos-review-69452 - Mesos Reviewbot Windows On Nov. 27, 2018, 11:07 p.m., Chun-Hung Hsiao wrote

Re: Review Request 69463: Added HEARTBEAT events and calls for the executor HTTP API.

2018-11-27 Thread Mesos Reviewbot Windows
. Reviews applied: `['69463']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2655/mesos-review-69463 - Mesos Reviewbot Windows On Nov. 27, 2018, 10:11 p.m., Joseph Wu wrote

Re: Review Request 69458: Persisted the operation updates we sent out.

2018-11-27 Thread Mesos Reviewbot Windows
. Reviews applied: `['69157', '69458']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2654/mesos-review-69458 - Mesos Reviewbot Windows On Nov. 27, 2018, 5:59 p.m., Benjamin Bannier wrote

Re: Review Request 69454: Added the autoconf `tar-pax` option.

2018-11-27 Thread Mesos Reviewbot Windows
. Reviews applied: `['69454']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2653/mesos-review-69454 - Mesos Reviewbot Windows On Nov. 27, 2018, 5:51 a.m., James Peach wrote

Re: Review Request 69452: Added a test for executors sending messages to recovered frameworks.

2018-11-26 Thread Mesos Reviewbot Windows
. Reviews applied: `['69451', '69452']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2652/mesos-review-69452 - Mesos Reviewbot Windows On Nov. 27, 2018, 4:58 a.m., Chun-Hung Hsiao wrote

Re: Review Request 69211: Improved the code comments for `getContainerDevicesPath`.

2018-11-26 Thread Mesos Reviewbot Windows
. Reviews applied: `['69086', '69210', '69450', '69211']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2651/mesos-review-69211 - Mesos Reviewbot Windows On Nov. 17, 2018, 12:50 a.m., James Peach wrote

Re: Review Request 69449: Added the `DISCARD` blkio cgroup operation.

2018-11-26 Thread Mesos Reviewbot Windows
. Reviews applied: `['69449']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2650/mesos-review-69449 - Mesos Reviewbot Windows On Nov. 26, 2018, 12:38 p.m., James Peach wrote

Re: Review Request 69420: Added Seccomp isolator tests.

2018-11-26 Thread Mesos Reviewbot Windows
command: `python.exe .\support\apply-reviews.py -n -r 67844` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2649/mesos-review-69420 Relevant logs: - [apply-review-67844.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos

Re: Review Request 69447: Improved wording in comments for `AgentAdded` event.

2018-11-26 Thread Mesos Reviewbot Windows
. Reviews applied: `['69447']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2648/mesos-review-69447 - Mesos Reviewbot Windows On Nov. 26, 2018, 9:44 a.m., Benno Evers wrote

Re: Review Request 69395: Added '--all' flag to 'mesos task list'.

2018-11-26 Thread Mesos Reviewbot Windows
logs. Failed command: `Start-MesosCITesting` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2647/mesos-review-69395 Relevant logs: - [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing

Re: Review Request 69445: WIP: Moved `ReadOnlyHandler` into separate header.

2018-11-26 Thread Mesos Reviewbot Windows
. Reviews applied: `['69071', '68795', '69411', '69421', '69064', '69422', '69445']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2646/mesos-review-69445 - Mesos Reviewbot Windows On Nov. 26, 2018, 12:18 p.m., Benno Evers wrote

Re: Review Request 69444: Allowed for unbundled leveldb in CMake builds.

2018-11-25 Thread Mesos Reviewbot Windows
. Reviews applied: `['69444']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2645/mesos-review-69444 - Mesos Reviewbot Windows On Nov. 25, 2018, 7:25 p.m., Till Toenshoff wrote

Re: Review Request 69395: Added '--all' flag to 'mesos task list'.

2018-11-25 Thread Mesos Reviewbot Windows
. Reviews applied: `['69394', '69425', '69426', '69395']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2644/mesos-review-69395 - Mesos Reviewbot Windows On Nov. 25, 2018, 7:17 p.m., Armand Grillet wrote

Re: Review Request 69442: Updated 'REPOSITORY_URL' in 'support/reviewboardrc' to use gitbox.

2018-11-24 Thread Mesos Reviewbot Windows
logs. Reviews applied: `['69442']` Failed command: `Start-MesosCITesting` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2643/mesos-review-69442 Relevant logs: - [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com

Re: Review Request 69441: Fixed sandbox creation chmod error handling in the agent.

2018-11-23 Thread Mesos Reviewbot Windows
. Reviews applied: `['69441']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2642/mesos-review-69441 - Mesos Reviewbot Windows On Nov. 24, 2018, 1:22 p.m., Gilbert Song wrote

Re: Review Request 69438: Skipped an rlimit test if the environment is incompatible.

2018-11-23 Thread Mesos Reviewbot Windows
. Reviews applied: `['67136', '69438']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2641/mesos-review-69438 - Mesos Reviewbot Windows On Nov. 24, 2018, midnight, Benjamin Bannier wrote

Re: Review Request 69324: Removed some unnecessary intermediate build variables.

2018-11-23 Thread Mesos Reviewbot Windows
. Reviews applied: `['69323', '69324']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2640/mesos-review-69324 - Mesos Reviewbot Windows On Nov. 13, 2018, 5:30 a.m., James Peach wrote

Re: Review Request 69436: Fixed flaky check in cluster::Slave destructor.

2018-11-22 Thread Mesos Reviewbot Windows
. Reviews applied: `['69436']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2639/mesos-review-69436 - Mesos Reviewbot Windows On Nov. 22, 2018, 7:43 p.m., Benno Evers wrote

Re: Review Request 69324: Removed some unnecessary intermediate build variables.

2018-11-22 Thread Mesos Reviewbot Windows
. Reviews applied: `['69323', '69324']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2638/mesos-review-69324 - Mesos Reviewbot Windows On Nov. 13, 2018, 5:30 a.m., James Peach wrote

Re: Review Request 69395: Added '--all' flag to 'mesos task list'.

2018-11-22 Thread Mesos Reviewbot
b/cli/plugins/task/main.py: patch does not apply error: patch failed: src/python/cli_new/lib/cli/tests/task.py:186 error: src/python/cli_new/lib/cli/tests/task.py: patch does not apply Full log: https://builds.apache.org/job/Mesos-Reviewbot/23570/console - Mesos Reviewbot On Nov. 22, 2018, 11:36

Re: Review Request 69395: Added '--all' flag to 'mesos task list'.

2018-11-22 Thread Mesos Reviewbot Windows
command: `python.exe .\support\apply-reviews.py -n -r 69394` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2637/mesos-review-69395 Relevant logs: - [apply-review-69394.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos

Re: Review Request 69395: Added '--all' flag to 'mesos task list'.

2018-11-22 Thread Mesos Reviewbot
. Please find a reviewer by asking on JIRA or the mailing list. - Mesos Reviewbot On Nov. 22, 2018, 11:36 a.m., Armand Grillet wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 69426: Replaced CLI test helper function 'running_tasks' by 'wait_for_task'.

2018-11-22 Thread Mesos Reviewbot Windows
command: `python.exe .\support\apply-reviews.py -n -r 69394` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2635/mesos-review-69426 Relevant logs: - [apply-review-69394.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos

Re: Review Request 69395: Added '--all' flag to 'mesos task list'.

2018-11-22 Thread Mesos Reviewbot Windows
: `python.exe .\support\apply-reviews.py -n -r 69395` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2636/mesos-review-69395 Relevant logs: - [apply-review-69395.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot

Re: Review Request 69422: WIP: Add new metric for cache hits.

2018-11-21 Thread Mesos Reviewbot Windows
. Reviews applied: `['69071', '68795', '69411', '69421', '69064', '69422']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2634/mesos-review-69422 - Mesos Reviewbot Windows On Nov. 22, 2018, 1:22 a.m., Benno Evers wrote

Re: Review Request 69423: Added a scheduler test for `UNSUPPRESS` call.

2018-11-21 Thread Mesos Reviewbot Windows
. Reviews applied: `['69288', '69289', '69290', '69423']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2633/mesos-review-69423 - Mesos Reviewbot Windows On Nov. 22, 2018, 12:14 a.m., Meng Zhu wrote

Re: Review Request 69420: Added Seccomp isolator tests.

2018-11-21 Thread Mesos Reviewbot Windows
command: `python.exe .\support\apply-reviews.py -n -r 67844` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2632/mesos-review-69420 Relevant logs: - [apply-review-67844.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos

Re: Review Request 69411: Added new interface for constructing `cluster::Master`.

2018-11-20 Thread Mesos Reviewbot
. Please find a reviewer by asking on JIRA or the mailing list. - Mesos Reviewbot On Nov. 20, 2018, 2:20 p.m., Benno Evers wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 69412: Fixed thread safety issue in jwt signature validation.

2018-11-20 Thread Mesos Reviewbot Windows
. Reviews applied: `['69412']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2631/mesos-review-69412 - Mesos Reviewbot Windows On Nov. 20, 2018, 2:51 p.m., Alexander Rojas wrote

Re: Review Request 69411: Added new interface for constructing `cluster::Master`.

2018-11-20 Thread Mesos Reviewbot Windows
. Reviews applied: `['69411']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2630/mesos-review-69411 - Mesos Reviewbot Windows On Nov. 20, 2018, 2:20 p.m., Benno Evers wrote

Re: Review Request 69345: Made non-root containers can access SANDBOX_PATH volume of PARENT type.

2018-11-20 Thread Mesos Reviewbot Windows
. Reviews applied: `['69342', '69344', '69345']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2629/mesos-review-69345 - Mesos Reviewbot Windows On Nov. 20, 2018, 2:13 p.m., Qian Zhang wrote

  1   2   3   4   5   6   7   8   9   10   >