Re: Review Request 69423: Added a scheduler test for `UNSUPPRESS` call.

2019-11-21 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69423/#review218733
---



Bad review!

Reviews applied: [69423, 69290, 69289, 69288]

Error:
2019-11-21 16:17:07 URL:https://reviews.apache.org/r/69288/diff/raw/ 
[5774/5774] -> "69288.patch" [1]
error: patch failed: src/master/allocator/mesos/hierarchical.cpp:1353
error: src/master/allocator/mesos/hierarchical.cpp: patch does not apply

- Mesos Reviewbot


On Nov. 22, 2018, 12:14 a.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69423/
> ---
> 
> (Updated Nov. 22, 2018, 12:14 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Gastón Kleiman.
> 
> 
> Bugs: MESOS-9028
> https://issues.apache.org/jira/browse/MESOS-9028
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This test verifies that when framework unsuppresses,
> it will resume getting offers from unfiltered agent
> resources. And filtered agent resources should remain
> being filtered.
> 
> 
> Diffs
> -
> 
>   src/tests/scheduler_tests.cpp b571bb1d20744b943580677a26db4c12c7c311d1 
> 
> 
> Diff: https://reviews.apache.org/r/69423/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>



Re: Review Request 71741: Updated operator API documention to use rereservation format.

2019-11-20 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71741/#review218724
---



Bad review!

Reviews applied: [71741, 71739, 71725, 71729]

Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing 
list.

- Mesos Reviewbot


On Nov. 20, 2019, 2:17 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71741/
> ---
> 
> (Updated Nov. 20, 2019, 2:17 p.m.)
> 
> 
> Review request for mesos and Benno Evers.
> 
> 
> Bugs: MESOS-9993
> https://issues.apache.org/jira/browse/MESOS-9993
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated operator API documention to use rereservation format.
> 
> 
> Diffs
> -
> 
>   docs/operator-http-api.md 6cc367dabf3bec507e8d49af54d9aad9ac17471c 
> 
> 
> Diff: https://reviews.apache.org/r/71741/diff/2/
> 
> 
> Testing
> ---
> 
> Previewed in generated site
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 71790: SSL Socket: Implemented sendfile.

2019-11-20 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71790/#review218714
---



Patch looks great!

Reviews applied: [71659, 71764, 71660, 71661, 71662, 71663, 71664, 71665, 
71666, 71790]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Nov. 20, 2019, 12:29 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71790/
> ---
> 
> (Updated Nov. 20, 2019, 12:29 a.m.)
> 
> 
> Review request for mesos, Benno Evers, Benjamin Mahler, Greg Mann, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-10010
> https://issues.apache.org/jira/browse/MESOS-10010
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This implements the SSL socket's sendfile method, which must read
> the file (unlike the zero-copy os::sendfile).
> 
> This also moves a test exercising sendfile from process_tests.cpp
> into http_tests.cpp and parameterizes it for SSL and non-SSL.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/ssl/socket_wrapper.cpp PRE-CREATION 
>   3rdparty/libprocess/src/tests/http_tests.cpp 
> 1433f3d09a72133fab1441be53562d508bc01682 
>   3rdparty/libprocess/src/tests/process_tests.cpp 
> 05dc5ec2fdc74a989689e4378bef775bcf2b7a87 
> 
> 
> Diff: https://reviews.apache.org/r/71790/diff/2/
> 
> 
> Testing
> ---
> 
> cmake --build . --target libprocess-tests
> libprocess-tests
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>



Re: Review Request 71742: Mesos agent shouldn't respond pings if no master is registered

2019-11-19 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71742/#review218713
---



Bad patch!

Reviews applied: [71742]

Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:14.04' 
BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose 
--disable-libtool-wrappers --disable-parallel-test-execution' 
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh 2>&1 | tee 
build_71742"]

Error:
..
principal"},"source":{"id":"/tmp/CSIVersion_StorageLocalResourceProviderTest_OperatorOperationsWithResourceProviderResources_v1_3yGpKu/2GB-da412f9a-c645-426e-830f-36efccaf33ab","mount":{"root":"./csi/org.apache.mesos.csi.test/local/mounts"},"profile":"test","type":"MOUNT","vendor":"org.apache.mesos.csi.test.local"},"volume":{"container_path":"volume","mode":"RW"}},"name":"disk","provider_id":{"value":"4238df44-e758-45fa-a640-2b50ff3f9d9b"},"reservations":[{"role":"storage","type":"DYNAMIC"},{"principal":"test-principal","role":"storage/default-role","type":"DYNAMIC"}],"scalar":{"value":2048.0},"type":"SCALAR"}]'
I1120 06:06:59.865097 18662 sched.cpp:960] Rescinded offer 
a9e4592f-64ab-4112-9e88-7566facc2bed-O3
I1120 06:06:59.865196 18662 sched.cpp:971] Scheduler::offerRescinded took 
40528ns
I1120 06:06:59.865566 18648 hierarchical.cpp:1576] Recovered ports(allocated: 
storage/default-role):[31000-32000]; disk(allocated: 
storage/default-role)(reservations: 
[(DYNAMIC,storage),(DYNAMIC,storage/default-role,test-principal)])[MOUNT(org.apache.mesos.csi.test.local,/tmp/CSIVersion_StorageLocalResourceProviderTest_OperatorOperationsWithResourceProviderResources_v1_3yGpKu/2GB-da412f9a-c645-426e-830f-36efccaf33ab,test)]:2048;
 cpus(allocated: storage/default-role):2; mem(allocated: 
storage/default-role):1024; disk(allocated: storage/default-role):1024 (total: 
cpus:2; mem:1024; disk:1024; ports:[31000-32000]; disk(reservations: 
[(DYNAMIC,storage),(DYNAMIC,storage/default-role,test-principal)])[MOUNT(org.apache.mesos.csi.test.local,/tmp/CSIVersion_StorageLocalResourceProviderTest_OperatorOperationsWithResourceProviderResources_v1_3yGpKu/2GB-da412f9a-c645-426e-830f-36efccaf33ab,test)]:2048,
 offered or allocated: {}) on agent a9e4592f-64ab-4112-9e88-7566facc2bed-S0 
from framework a9e45
 92f-64ab-4112-9e88-7566facc2bed-
I1120 06:06:59.865661 18670 master.cpp:12794] Removing offer 
a9e4592f-64ab-4112-9e88-7566facc2bed-O3
I1120 06:06:59.866827 18648 hierarchical.cpp:1625] Framework 
a9e4592f-64ab-4112-9e88-7566facc2bed- filtered agent 
a9e4592f-64ab-4112-9e88-7566facc2bed-S0 for 5secs
I1120 06:06:59.869273 18651 master.cpp:12659] Sending operation '' (uuid: 
432806fd-224b-4139-aa48-1abc35ccafeb) to agent 
a9e4592f-64ab-4112-9e88-7566facc2bed-S0 at slave(1250)@172.17.0.2:42302 
(7ccc8b834dd0)
I1120 06:06:59.869983 18649 slave.cpp:4352] Ignoring new checkpointed resources 
and operations identical to the current version
I1120 06:06:59.873303 18671 provider.cpp:498] Received APPLY_OPERATION event
I1120 06:06:59.873347 18671 provider.cpp:1351] Received CREATE operation '' 
(uuid: 432806fd-224b-4139-aa48-1abc35ccafeb)
I1120 06:06:59.879556 18657 master.cpp:6482] Processing REVIVE call for 
framework a9e4592f-64ab-4112-9e88-7566facc2bed- (default) at 
scheduler-5eaf4119-5232-42ab-89d3-bcfa3995da6d@172.17.0.2:42302
I1120 06:06:59.880115 18657 hierarchical.cpp:1721] Unsuppressed offers and 
cleared filters for roles { storage/default-role } of framework 
a9e4592f-64ab-4112-9e88-7566facc2bed-
I1120 06:06:59.881371 18657 hierarchical.cpp:1853] Performed allocation for 1 
agents in 1.047256ms
I1120 06:06:59.881721 18657 hierarchical.cpp:1853] Performed allocation for 1 
agents in 151686ns
I1120 06:06:59.881968 18670 master.cpp:10497] Sending offers [ 
a9e4592f-64ab-4112-9e88-7566facc2bed-O4 ] to framework 
a9e4592f-64ab-4112-9e88-7566facc2bed- (default) at 
scheduler-5eaf4119-5232-42ab-89d3-bcfa3995da6d@172.17.0.2:42302
I1120 06:06:59.882639 18655 sched.cpp:934] Scheduler::resourceOffers took 
101940ns
I1120 06:06:59.893764 18661 http.cpp:1115] HTTP POST for 
/slave(1250)/api/v1/resource_provider from 172.17.0.2:44786
I1120 06:06:59.894723 18649 slave.cpp:8495] Handling resource provider message 
'UPDATE_OPERATION_STATUS: (uuid: 886bf308-26b8-4c87-a3d8-aaf636839fab) for 
framework  (latest state: OPERATION_FINISHED, status update state: 
OPERATION_FINISHED)'
I1120 06:06:59.894937 18649 slave.cpp:8948] Updating the state of operation 
with no ID (uuid: 886bf308-26b8-4c87-a3d8-aaf636839fab) for an operation API 
call (latest state: OPERATION_FINISHED, status update state: OPERATION_FINISHED)
I1120 06:06:59.894990 18649 slave.cpp:8702] Forwarding status update of 
operation with no ID (operation_uuid: 886bf308-26b8-4c87-a3d8-aaf636839fab) for 
an operator API call
I1120 06:06:59.895336 18664 master.cpp:12311] Updating the state of operation 

Re: Review Request 71755: Improved performance of v1 operator API GetMetrics call.

2019-11-19 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71755/#review218711
---



Bad patch!

Reviews applied: [71747, 71748, 71749, 71750, 71751, 71752, 71753, 71754, 71755]

Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:14.04' 
BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose 
--disable-libtool-wrappers --disable-parallel-test-execution' 
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh 2>&1 | tee 
build_71755"]

Error:
..
mesos-1.10.0/_inst/share/mesos\" 
-DPKGMODULEDIR=\"/mesos/mesos-1.10.0/_inst/lib/mesos/modules\" -I../../include 
-I../include -I../include/mesos -D__STDC_FORMAT_MACROS 
-I../3rdparty/boost-1.65.0 -I../3rdparty/concurrentqueue-7b69a8f 
-I../3rdparty/elfio-3.2 -I../3rdparty/glog-0.4.0/src 
-I../3rdparty/grpc-1.10.0/include -I../3rdparty/leveldb-1.19/include 
-I../3rdparty/libarchive-3.3.2/libarchive/ -I../../3rdparty/libprocess/include 
-I../3rdparty/nvml-352.79 -I../3rdparty/picojson-1.3.0 
-I../3rdparty/protobuf-3.5.0/src -I../3rdparty/rapidjson-1.1.0/include 
-I../../3rdparty/stout/include -I../3rdparty/zookeeper-3.4.8/src/c/include 
-I../3rdparty/zookeeper-3.4.8/src/c/generated -I/usr/include/subversion-1 
-I/usr/include/apr-1 -I/usr/include/apr-1.0 -pthread -Wall -Wsign-compare 
-Wformat-security -fstack-protector -fPIC -g1 -O0 -Wno-unused-local-typedefs 
-std=c++11 -c ../../src/logging/flags.cpp  -fPIC -DPIC -o 
logging/.libs/libmesos_no_3rdparty_la-flags.o
/bin/bash ../libtool  --tag=CXX   --mode=compile g++ -DPACKAGE_NAME=\"mesos\" 
-DPACKAGE_TARNAME=\"mesos\" -DPACKAGE_VERSION=\"1.10.0\" 
-DPACKAGE_STRING=\"mesos\ 1.10.0\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" 
-DPACKAGE=\"mesos\" -DVERSION=\"1.10.0\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 
-DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 
-DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 
-DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_CXX11=1 
-DHAVE_PTHREAD_PRIO_INHERIT=1 -DHAVE_PTHREAD=1 -DHAVE_OPENSSL_SSL_H=1 
-DHAVE_FTS_H=1 -DHAVE_APR_POOLS_H=1 -DHAVE_LIBAPR_1=1 -DHAVE_LIBCURL=1 
-DMESOS_HAS_JAVA=1 -DHAVE_LIBSASL2=1 -DHAVE_SVN_VERSION_H=1 
-DHAVE_LIBSVN_SUBR_1=1 -DHAVE_SVN_DELTA_H=1 -DHAVE_LIBSVN_DELTA_1=1 
-DHAVE_ZLIB_H=1 -DHAVE_LIBZ=1 -DHAVE_PYTHON=\"2.7\" -DMESOS_HAS_PYTHON=1 -I. 
-I../../src   -Werror -DLIBDIR=\"/mesos/mesos-1.10.0/_inst/lib\" 
-DPKGLIBEXECDIR=\"/mesos/mesos-1.10.0/_inst/libexec/mesos\" 
-DPKGDATADIR=\"/mesos/mesos-1.
 10.0/_inst/share/mesos\" 
-DPKGMODULEDIR=\"/mesos/mesos-1.10.0/_inst/lib/mesos/modules\" -I../../include 
-I../include -I../include/mesos -D__STDC_FORMAT_MACROS 
-I../3rdparty/boost-1.65.0 -I../3rdparty/concurrentqueue-7b69a8f 
-I../3rdparty/elfio-3.2 -I../3rdparty/glog-0.4.0/src 
-I../3rdparty/grpc-1.10.0/include -I../3rdparty/leveldb-1.19/include 
-I../3rdparty/libarchive-3.3.2/libarchive/ -I../../3rdparty/libprocess/include  
-I../3rdparty/nvml-352.79 -I../3rdparty/picojson-1.3.0 
-I../3rdparty/protobuf-3.5.0/src -I../3rdparty/rapidjson-1.1.0/include 
-I../../3rdparty/stout/include -I../3rdparty/zookeeper-3.4.8/src/c/include 
-I../3rdparty/zookeeper-3.4.8/src/c/generated -I/usr/include/subversion-1 
-I/usr/include/apr-1 -I/usr/include/apr-1.0  -pthread -Wall 
-Wsign-compare -Wformat-security -fstack-protector -fPIC -fPIE -g1 -O0 
-Wno-unused-local-typedefs -std=c++11 -c -o 
logging/libmesos_no_3rdparty_la-logging.lo `test -f 'logging/logging.cpp' || 
echo '../../src/'`logging/logging.cpp
libtool: compile:  g++ -DPACKAGE_NAME=\"mesos\" -DPACKAGE_TARNAME=\"mesos\" 
-DPACKAGE_VERSION=\"1.10.0\" "-DPACKAGE_STRING=\"mesos 1.10.0\"" 
-DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"mesos\" 
-DVERSION=\"1.10.0\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 
-DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 
-DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 
-DLT_OBJDIR=\".libs/\" -DHAVE_CXX11=1 -DHAVE_PTHREAD_PRIO_INHERIT=1 
-DHAVE_PTHREAD=1 -DHAVE_OPENSSL_SSL_H=1 -DHAVE_FTS_H=1 -DHAVE_APR_POOLS_H=1 
-DHAVE_LIBAPR_1=1 -DHAVE_LIBCURL=1 -DMESOS_HAS_JAVA=1 -DHAVE_LIBSASL2=1 
-DHAVE_SVN_VERSION_H=1 -DHAVE_LIBSVN_SUBR_1=1 -DHAVE_SVN_DELTA_H=1 
-DHAVE_LIBSVN_DELTA_1=1 -DHAVE_ZLIB_H=1 -DHAVE_LIBZ=1 -DHAVE_PYTHON=\"2.7\" 
-DMESOS_HAS_PYTHON=1 -I. -I../../src -Werror 
-DLIBDIR=\"/mesos/mesos-1.10.0/_inst/lib\" 
-DPKGLIBEXECDIR=\"/mesos/mesos-1.10.0/_inst/libexec/mesos\" 
-DPKGDATADIR=\"/mesos/mesos-1.10.0/_inst/share/mesos\" -DPKGM
 ODULEDIR=\"/mesos/mesos-1.10.0/_inst/lib/mesos/modules\" -I../../include 
-I../include -I../include/mesos -D__STDC_FORMAT_MACROS 
-I../3rdparty/boost-1.65.0 -I../3rdparty/concurrentqueue-7b69a8f 
-I../3rdparty/elfio-3.2 -I../3rdparty/glog-0.4.0/src 
-I../3rdparty/grpc-1.10.0/include -I../3rdparty/leveldb-1.19/include 

Re: Review Request 71787: Added end-to-end test for reservation update with persistent volume.

2019-11-19 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71787/#review218708
---



Patch looks great!

Reviews applied: [71785, 71787]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Nov. 19, 2019, 8:53 a.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71787/
> ---
> 
> (Updated Nov. 19, 2019, 8:53 a.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-9992
> https://issues.apache.org/jira/browse/MESOS-9992
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a new test that verifies that the reservation for a
> persistent disk volume can be updated after it has been
> created.
> 
> 
> Diffs
> -
> 
>   src/tests/persistent_volume_endpoints_tests.cpp 
> bddc9467c5b9fe6cdcbd84f1b110356a43b59ba0 
> 
> 
> Diff: https://reviews.apache.org/r/71787/diff/1/
> 
> 
> Testing
> ---
> 
> `./src/mesos-tests --gtest_filter="*ReservationUpdate*"`
> 
> 
> Thanks,
> 
> Benno Evers
> 
>



Re: Review Request 71666: SSL Wrapper: Implemented send/recv and shutdown.

2019-11-19 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71666/#review218700
---



Bad review!

Reviews applied: [71666, 71665, 71664, 71663, 71662, 71661, 71660, 71764, 71659]

Error:
2019-11-19 22:48:17 URL:https://reviews.apache.org/r/71665/diff/raw/ 
[16358/16358] -> "71665.patch" [1]
error: patch failed: 3rdparty/libprocess/src/ssl/socket_wrapper.cpp:30
error: 3rdparty/libprocess/src/ssl/socket_wrapper.cpp: patch does not apply

- Mesos Reviewbot


On Nov. 11, 2019, 7:41 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71666/
> ---
> 
> (Updated Nov. 11, 2019, 7:41 p.m.)
> 
> 
> Review request for mesos, Benno Evers, Benjamin Mahler, Greg Mann, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-10010
> https://issues.apache.org/jira/browse/MESOS-10010
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This completes a fully functional client-side SSL socket.
> 
> Needs a bit of cleanup and more error handling though.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/ssl/socket_wrapper.hpp PRE-CREATION 
>   3rdparty/libprocess/src/ssl/socket_wrapper.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/71666/diff/5/
> 
> 
> Testing
> ---
> 
> ```
> cmake --build . --target libprocess-tests
> libprocess-tests
> ```
> 
> Running libprocess-tests yields:
> ```
> [  FAILED  ] SSLTest.ValidDowngrade
> [  FAILED  ] SSLTest.ValidDowngradeEachProtocol
> [  FAILED  ] Encryption/NetSocketTest.EOFBeforeRecv/0, where GetParam() = 
> "SSL"
> [  FAILED  ] Encryption/NetSocketTest.EOFAfterRecv/0, where GetParam() = "SSL"
> ```
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>



Re: Review Request 71769: Gracefully handled duplicated volumes from non-conforming CSI plugins.

2019-11-14 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71769/#review218643
---



Bad review!

Reviews applied: [71769]

Error:
2019-11-15 02:09:48 URL:https://reviews.apache.org/r/71769/diff/raw/ 
[5431/5431] -> "71769.patch" [1]
error: patch failed: src/resource_provider/storage/provider.cpp:656
error: src/resource_provider/storage/provider.cpp: patch does not apply

- Mesos Reviewbot


On Nov. 14, 2019, 6:14 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71769/
> ---
> 
> (Updated Nov. 14, 2019, 6:14 p.m.)
> 
> 
> Review request for mesos and Chun-Hung Hsiao.
> 
> 
> Bugs: MESOS-9956
> https://issues.apache.org/jira/browse/MESOS-9956
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> If the SLRP uses a plugin that does not conform to the CSI spec and
> reports duplicated volumes, the duplicate would be removed.
> 
> This is a backport of `43b86da531a889b1c4b1d7ca6acb2eb924ea01e1`. We
> are not backporting test changes as the original patch relies on
> periodic plugin polling.
> 
> 
> Diffs
> -
> 
>   src/resource_provider/storage/provider.cpp 
> 6d632606f411d3ca99d3573a57c9f68b02ba8072 
> 
> 
> Diff: https://reviews.apache.org/r/71769/diff/1/
> 
> 
> Testing
> ---
> 
> `sudo make check` results in only known failures
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 71666: SSL Wrapper: Implemented send/recv and shutdown.

2019-11-13 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71666/#review218629
---



Patch looks great!

Reviews applied: [71659, 71764, 71660, 71661, 71662, 71663, 71664, 71665, 71666]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Nov. 11, 2019, 7:41 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71666/
> ---
> 
> (Updated Nov. 11, 2019, 7:41 p.m.)
> 
> 
> Review request for mesos, Benno Evers, Benjamin Mahler, Greg Mann, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-10010
> https://issues.apache.org/jira/browse/MESOS-10010
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This completes a fully functional client-side SSL socket.
> 
> Needs a bit of cleanup and more error handling though.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/ssl/socket_wrapper.hpp PRE-CREATION 
>   3rdparty/libprocess/src/ssl/socket_wrapper.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/71666/diff/5/
> 
> 
> Testing
> ---
> 
> ```
> cmake --build . --target libprocess-tests
> libprocess-tests
> ```
> 
> Running libprocess-tests yields:
> ```
> [  FAILED  ] SSLTest.ValidDowngrade
> [  FAILED  ] SSLTest.ValidDowngradeEachProtocol
> [  FAILED  ] Encryption/NetSocketTest.EOFBeforeRecv/0, where GetParam() = 
> "SSL"
> [  FAILED  ] Encryption/NetSocketTest.EOFAfterRecv/0, where GetParam() = "SSL"
> ```
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>



Re: Review Request 71742: Mesos agent shouldn't respond pings if no master is registered

2019-11-13 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71742/#review218616
---



Bad patch!

Reviews applied: [71742]

Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:14.04' 
BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose 
--disable-libtool-wrappers --disable-parallel-test-execution' 
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh 2>&1 | tee 
build_71742"]

Error:
..
b4d240c68- (default) at 
scheduler-eb169004-2da5-4544-af21-45d8770cf0be@172.17.0.2:43725
I1113 08:55:24.192509 18861 sched.cpp:934] Scheduler::resourceOffers took 
66119ns
I1113 08:55:24.195724 18868 process.cpp:3671] Handling HTTP event for process 
'master' with path: '/master/api/v1'
I1113 08:55:24.197166 18869 http.cpp:1115] HTTP POST for /master/api/v1 from 
172.17.0.2:58524
I1113 08:55:24.197444 18869 http.cpp:263] Processing call CREATE_VOLUMES
I1113 08:55:24.198328 18869 master.cpp:3982] Authorizing principal 
'test-principal' to create volumes 
'[{"disk":{"persistence":{"id":"1110bef5-ec74-4476-b2a6-fa12de70281b","principal":"test-principal"},"source":{"id":"/tmp/CSIVersion_StorageLocalResourceProviderTest_OperatorOperationsWithResourceProviderResources_v1_NrTXk1/2GB-580a2ec3-f46e-4118-af89-66e1d0a0b173","mount":{"root":"./csi/org.apache.mesos.csi.test/local/mounts"},"profile":"test","type":"MOUNT","vendor":"org.apache.mesos.csi.test.local"},"volume":{"container_path":"volume","mode":"RW"}},"name":"disk","provider_id":{"value":"875458c8-52f4-4f30-a00c-2f8c583e4a4d"},"reservations":[{"role":"storage","type":"DYNAMIC"},{"principal":"test-principal","role":"storage/default-role","type":"DYNAMIC"}],"scalar":{"value":2048.0},"type":"SCALAR"}]'
I1113 08:55:24.199939 18863 sched.cpp:960] Rescinded offer 
f31dc3e2-d030-4fe5-b8f8-324b4d240c68-O3
I1113 08:55:24.200021 18863 sched.cpp:971] Scheduler::offerRescinded took 
29618ns
I1113 08:55:24.200551 18861 hierarchical.cpp:1576] Recovered ports(allocated: 
storage/default-role):[31000-32000]; disk(allocated: 
storage/default-role)(reservations: 
[(DYNAMIC,storage),(DYNAMIC,storage/default-role,test-principal)])[MOUNT(org.apache.mesos.csi.test.local,/tmp/CSIVersion_StorageLocalResourceProviderTest_OperatorOperationsWithResourceProviderResources_v1_NrTXk1/2GB-580a2ec3-f46e-4118-af89-66e1d0a0b173,test)]:2048;
 cpus(allocated: storage/default-role):2; mem(allocated: 
storage/default-role):1024; disk(allocated: storage/default-role):1024 (total: 
cpus:2; mem:1024; disk:1024; ports:[31000-32000]; disk(reservations: 
[(DYNAMIC,storage),(DYNAMIC,storage/default-role,test-principal)])[MOUNT(org.apache.mesos.csi.test.local,/tmp/CSIVersion_StorageLocalResourceProviderTest_OperatorOperationsWithResourceProviderResources_v1_NrTXk1/2GB-580a2ec3-f46e-4118-af89-66e1d0a0b173,test)]:2048,
 offered or allocated: {}) on agent f31dc3e2-d030-4fe5-b8f8-324b4d240c68-S0 
from framework f31dc
 3e2-d030-4fe5-b8f8-324b4d240c68-
I1113 08:55:24.200685 18867 master.cpp:12794] Removing offer 
f31dc3e2-d030-4fe5-b8f8-324b4d240c68-O3
I1113 08:55:24.202123 18861 hierarchical.cpp:1625] Framework 
f31dc3e2-d030-4fe5-b8f8-324b4d240c68- filtered agent 
f31dc3e2-d030-4fe5-b8f8-324b4d240c68-S0 for 5secs
I1113 08:55:24.204321 18865 master.cpp:12659] Sending operation '' (uuid: 
d5f2f136-ec48-42af-8ac8-89485110e831) to agent 
f31dc3e2-d030-4fe5-b8f8-324b4d240c68-S0 at slave(1250)@172.17.0.2:43725 
(2c8a034ce049)
I1113 08:55:24.204887 18866 slave.cpp:4352] Ignoring new checkpointed resources 
and operations identical to the current version
I1113 08:55:24.207716 18872 provider.cpp:498] Received APPLY_OPERATION event
I1113 08:55:24.207767 18872 provider.cpp:1351] Received CREATE operation '' 
(uuid: d5f2f136-ec48-42af-8ac8-89485110e831)
I1113 08:55:24.213966 18865 master.cpp:6482] Processing REVIVE call for 
framework f31dc3e2-d030-4fe5-b8f8-324b4d240c68- (default) at 
scheduler-eb169004-2da5-4544-af21-45d8770cf0be@172.17.0.2:43725
I1113 08:55:24.214371 18865 hierarchical.cpp:1721] Unsuppressed offers and 
cleared filters for roles { storage/default-role } of framework 
f31dc3e2-d030-4fe5-b8f8-324b4d240c68-
I1113 08:55:24.215639 18865 hierarchical.cpp:1853] Performed allocation for 1 
agents in 1.124093ms
I1113 08:55:24.216162 18865 hierarchical.cpp:1853] Performed allocation for 1 
agents in 247643ns
I1113 08:55:24.216593 18873 master.cpp:10497] Sending offers [ 
f31dc3e2-d030-4fe5-b8f8-324b4d240c68-O4 ] to framework 
f31dc3e2-d030-4fe5-b8f8-324b4d240c68- (default) at 
scheduler-eb169004-2da5-4544-af21-45d8770cf0be@172.17.0.2:43725
I1113 08:55:24.217276 18864 sched.cpp:934] Scheduler::resourceOffers took 
86870ns
I1113 08:55:24.232483 18871 http.cpp:1115] HTTP POST for 
/slave(1250)/api/v1/resource_provider from 172.17.0.2:58518
I1113 08:55:24.233323 18860 slave.cpp:8491] Handling resource provider message 

Re: Review Request 71750: Improved performance of v1 operator API GetAgents call.

2019-11-11 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71750/#review218598
---



Bad patch!

Reviews applied: [71747, 71748, 71749, 71750]

Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:14.04' 
BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose 
--disable-libtool-wrappers --disable-parallel-test-execution' 
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh 2>&1 | tee 
build_71750"]

Error:
..
-DPACKAGE_STRING=\"mesos 1.10.0\"" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" 
-DPACKAGE=\"mesos\" -DVERSION=\"1.10.0\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 
-DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 
-DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 
-DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_CXX11=1 
-DHAVE_PTHREAD_PRIO_INHERIT=1 -DHAVE_PTHREAD=1 -DHAVE_OPENSSL_SSL_H=1 
-DHAVE_FTS_H=1 -DHAVE_APR_POOLS_H=1 -DHAVE_LIBAPR_1=1 -DHAVE_LIBCURL=1 
-DMESOS_HAS_JAVA=1 -DHAVE_LIBSASL2=1 -DHAVE_SVN_VERSION_H=1 
-DHAVE_LIBSVN_SUBR_1=1 -DHAVE_SVN_DELTA_H=1 -DHAVE_LIBSVN_DELTA_1=1 
-DHAVE_ZLIB_H=1 -DHAVE_LIBZ=1 -DHAVE_PYTHON=\"2.7\" -DMESOS_HAS_PYTHON=1 -I. 
-I../../src -Werror -DLIBDIR=\"/mesos/mesos-1.10.0/_inst/lib\" 
-DPKGLIBEXECDIR=\"/mesos/mesos-1.10.0/_inst/libexec/mesos\" 
-DPKGDATADIR=\"/mesos/mesos-1.10.0/_inst/share/mesos\" 
-DPKGMODULEDIR=\"/mesos/mesos-1.10.0/_inst/lib/mesos/modules\" -I../../include 
-I../include -I../include/mesos -
 D__STDC_FORMAT_MACROS -I../3rdparty/boost-1.65.0 
-I../3rdparty/concurrentqueue-7b69a8f -I../3rdparty/elfio-3.2 
-I../3rdparty/glog-0.4.0/src -I../3rdparty/grpc-1.10.0/include 
-I../3rdparty/leveldb-1.19/include -I../3rdparty/libarchive-3.3.2/libarchive/ 
-I../../3rdparty/libprocess/include -I../3rdparty/nvml-352.79 
-I../3rdparty/picojson-1.3.0 -I../3rdparty/protobuf-3.5.0/src 
-I../3rdparty/rapidjson-1.1.0/include -I../../3rdparty/stout/include 
-I../3rdparty/zookeeper-3.4.8/src/c/include 
-I../3rdparty/zookeeper-3.4.8/src/c/generated -I/usr/include/subversion-1 
-I/usr/include/apr-1 -I/usr/include/apr-1.0 -pthread -Wall -Wsign-compare 
-Wformat-security -fstack-protector -fPIC -g1 -O0 -Wno-unused-local-typedefs 
-std=c++11 -c ../../src/logging/flags.cpp  -fPIC -DPIC -o 
logging/.libs/libmesos_no_3rdparty_la-flags.o
/bin/bash ../libtool  --tag=CXX   --mode=compile g++ -DPACKAGE_NAME=\"mesos\" 
-DPACKAGE_TARNAME=\"mesos\" -DPACKAGE_VERSION=\"1.10.0\" 
-DPACKAGE_STRING=\"mesos\ 1.10.0\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" 
-DPACKAGE=\"mesos\" -DVERSION=\"1.10.0\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 
-DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 
-DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 
-DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_CXX11=1 
-DHAVE_PTHREAD_PRIO_INHERIT=1 -DHAVE_PTHREAD=1 -DHAVE_OPENSSL_SSL_H=1 
-DHAVE_FTS_H=1 -DHAVE_APR_POOLS_H=1 -DHAVE_LIBAPR_1=1 -DHAVE_LIBCURL=1 
-DMESOS_HAS_JAVA=1 -DHAVE_LIBSASL2=1 -DHAVE_SVN_VERSION_H=1 
-DHAVE_LIBSVN_SUBR_1=1 -DHAVE_SVN_DELTA_H=1 -DHAVE_LIBSVN_DELTA_1=1 
-DHAVE_ZLIB_H=1 -DHAVE_LIBZ=1 -DHAVE_PYTHON=\"2.7\" -DMESOS_HAS_PYTHON=1 -I. 
-I../../src   -Werror -DLIBDIR=\"/mesos/mesos-1.10.0/_inst/lib\" 
-DPKGLIBEXECDIR=\"/mesos/mesos-1.10.0/_inst/libexec/mesos\" 
-DPKGDATADIR=\"/mesos/mesos-1.
 10.0/_inst/share/mesos\" 
-DPKGMODULEDIR=\"/mesos/mesos-1.10.0/_inst/lib/mesos/modules\" -I../../include 
-I../include -I../include/mesos -D__STDC_FORMAT_MACROS 
-I../3rdparty/boost-1.65.0 -I../3rdparty/concurrentqueue-7b69a8f 
-I../3rdparty/elfio-3.2 -I../3rdparty/glog-0.4.0/src 
-I../3rdparty/grpc-1.10.0/include -I../3rdparty/leveldb-1.19/include 
-I../3rdparty/libarchive-3.3.2/libarchive/ -I../../3rdparty/libprocess/include  
-I../3rdparty/nvml-352.79 -I../3rdparty/picojson-1.3.0 
-I../3rdparty/protobuf-3.5.0/src -I../3rdparty/rapidjson-1.1.0/include 
-I../../3rdparty/stout/include -I../3rdparty/zookeeper-3.4.8/src/c/include 
-I../3rdparty/zookeeper-3.4.8/src/c/generated -I/usr/include/subversion-1 
-I/usr/include/apr-1 -I/usr/include/apr-1.0  -pthread -Wall 
-Wsign-compare -Wformat-security -fstack-protector -fPIC -fPIE -g1 -O0 
-Wno-unused-local-typedefs -std=c++11 -c -o 
logging/libmesos_no_3rdparty_la-logging.lo `test -f 'logging/logging.cpp' || 
echo '../../src/'`logging/logging.cpp
libtool: compile:  g++ -DPACKAGE_NAME=\"mesos\" -DPACKAGE_TARNAME=\"mesos\" 
-DPACKAGE_VERSION=\"1.10.0\" "-DPACKAGE_STRING=\"mesos 1.10.0\"" 
-DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"mesos\" 
-DVERSION=\"1.10.0\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 
-DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 
-DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 
-DLT_OBJDIR=\".libs/\" -DHAVE_CXX11=1 -DHAVE_PTHREAD_PRIO_INHERIT=1 
-DHAVE_PTHREAD=1 

Re: Review Request 71666: SSL Wrapper: Implemented send/recv and shutdown.

2019-11-11 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71666/#review218597
---



Patch looks great!

Reviews applied: [71659, 71660, 71661, 71662, 71663, 71664, 71665, 71666]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Nov. 11, 2019, 11:41 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71666/
> ---
> 
> (Updated Nov. 11, 2019, 11:41 a.m.)
> 
> 
> Review request for mesos, Benno Evers, Benjamin Mahler, Greg Mann, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-10010
> https://issues.apache.org/jira/browse/MESOS-10010
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This completes a fully functional client-side SSL socket.
> 
> Needs a bit of cleanup and more error handling though.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/ssl/socket_wrapper.hpp PRE-CREATION 
>   3rdparty/libprocess/src/ssl/socket_wrapper.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/71666/diff/5/
> 
> 
> Testing
> ---
> 
> ```
> cmake --build . --target libprocess-tests
> libprocess-tests
> ```
> 
> Running libprocess-tests yields:
> ```
> [  FAILED  ] SSLTest.ValidDowngrade
> [  FAILED  ] SSLTest.ValidDowngradeEachProtocol
> [  FAILED  ] Encryption/NetSocketTest.EOFBeforeRecv/0, where GetParam() = 
> "SSL"
> [  FAILED  ] Encryption/NetSocketTest.EOFAfterRecv/0, where GetParam() = "SSL"
> ```
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>



Re: Review Request 71742: Mesos agent responds pings only from currently registered master

2019-11-08 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71742/#review218582
---



Bad patch!

Reviews applied: [71742]

Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:14.04' 
BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose 
--disable-libtool-wrappers --disable-parallel-test-execution' 
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh 2>&1 | tee 
build_71742"]

Error:
..
pp:12794] Removing offer bf518529-d351-4a8b-bba1-60fa38542add-O3
I1109 00:29:33.548925 18798 hierarchical.cpp:1625] Framework 
bf518529-d351-4a8b-bba1-60fa38542add- filtered agent 
bf518529-d351-4a8b-bba1-60fa38542add-S0 for 5secs
I1109 00:29:33.551477 18811 master.cpp:12659] Sending operation '' (uuid: 
c3cd8267-059a-45e5-8a23-6a8a1e83d593) to agent 
bf518529-d351-4a8b-bba1-60fa38542add-S0 at slave(1250)@172.17.0.2:36833 
(7a92e10ffb12)
I1109 00:29:33.552137 18811 slave.cpp:4352] Ignoring new checkpointed resources 
and operations identical to the current version
I1109 00:29:33.555243 18797 provider.cpp:498] Received APPLY_OPERATION event
I1109 00:29:33.555289 18797 provider.cpp:1351] Received CREATE operation '' 
(uuid: c3cd8267-059a-45e5-8a23-6a8a1e83d593)
I1109 00:29:33.560374 18801 master.cpp:6482] Processing REVIVE call for 
framework bf518529-d351-4a8b-bba1-60fa38542add- (default) at 
scheduler-3dd25b70-0173-473f-abee-d49864755156@172.17.0.2:36833
I1109 00:29:33.560904 18803 hierarchical.cpp:1721] Unsuppressed offers and 
cleared filters for roles { storage/default-role } of framework 
bf518529-d351-4a8b-bba1-60fa38542add-
I1109 00:29:33.562279 18803 hierarchical.cpp:1853] Performed allocation for 1 
agents in 1.196644ms
I1109 00:29:33.562737 18803 hierarchical.cpp:1853] Performed allocation for 1 
agents in 205894ns
I1109 00:29:33.563107 18807 master.cpp:10497] Sending offers [ 
bf518529-d351-4a8b-bba1-60fa38542add-O4 ] to framework 
bf518529-d351-4a8b-bba1-60fa38542add- (default) at 
scheduler-3dd25b70-0173-473f-abee-d49864755156@172.17.0.2:36833
I1109 00:29:33.563773 18807 sched.cpp:934] Scheduler::resourceOffers took 
82563ns
I1109 00:29:33.578168 18808 http.cpp:1115] HTTP POST for 
/slave(1250)/api/v1/resource_provider from 172.17.0.2:48892
I1109 00:29:33.579185 18798 slave.cpp:8493] Handling resource provider message 
'UPDATE_OPERATION_STATUS: (uuid: 1bc3ea7a-a5ea-437a-8916-3880131439b3) for 
framework  (latest state: OPERATION_FINISHED, status update state: 
OPERATION_FINISHED)'
I1109 00:29:33.579345 18798 slave.cpp:8946] Updating the state of operation 
with no ID (uuid: 1bc3ea7a-a5ea-437a-8916-3880131439b3) for an operation API 
call (latest state: OPERATION_FINISHED, status update state: OPERATION_FINISHED)
I1109 00:29:33.579398 18798 slave.cpp:8700] Forwarding status update of 
operation with no ID (operation_uuid: 1bc3ea7a-a5ea-437a-8916-3880131439b3) for 
an operator API call
I1109 00:29:33.579720 18802 master.cpp:12311] Updating the state of operation 
'' (uuid: 1bc3ea7a-a5ea-437a-8916-3880131439b3) for an operator API call 
(latest state: OPERATION_PENDING, status update state: OPERATION_FINISHED)
I1109 00:29:33.580221 18810 slave.cpp:4352] Ignoring new checkpointed resources 
and operations identical to the current version
I1109 00:29:33.653975 18798 status_update_manager_process.hpp:152] Received 
operation status update OPERATION_FINISHED (Status UUID: 
0a105a21-ea89-4c39-a698-7206b4518659) for operation UUID 
c3cd8267-059a-45e5-8a23-6a8a1e83d593 on agent 
bf518529-d351-4a8b-bba1-60fa38542add-S0
I1109 00:29:33.654039 18798 status_update_manager_process.hpp:414] Creating 
operation status update stream c3cd8267-059a-45e5-8a23-6a8a1e83d593 
checkpoint=true
I1109 00:29:33.654115 18797 provider.cpp:498] Received 
ACKNOWLEDGE_OPERATION_STATUS event
I1109 00:29:33.654314 18798 status_update_manager_process.hpp:929] 
Checkpointing UPDATE for operation status update OPERATION_FINISHED (Status 
UUID: 0a105a21-ea89-4c39-a698-7206b4518659) for operation UUID 
c3cd8267-059a-45e5-8a23-6a8a1e83d593 on agent 
bf518529-d351-4a8b-bba1-60fa38542add-S0
I1109 00:29:33.720492 18798 status_update_manager_process.hpp:528] Forwarding 
operation status update OPERATION_FINISHED (Status UUID: 
0a105a21-ea89-4c39-a698-7206b4518659) for operation UUID 
c3cd8267-059a-45e5-8a23-6a8a1e83d593 on agent 
bf518529-d351-4a8b-bba1-60fa38542add-S0
I1109 00:29:33.720772 18798 status_update_manager_process.hpp:252] Received 
operation status update acknowledgement (UUID: 
eb231693-b2bc-4738-9dbb-a860839dacff) for stream 
1bc3ea7a-a5ea-437a-8916-3880131439b3
I1109 00:29:33.720830 18798 status_update_manager_process.hpp:929] 
Checkpointing ACK for operation status update OPERATION_FINISHED (Status UUID: 
eb231693-b2bc-4738-9dbb-a860839dacff) for operation UUID 
1bc3ea7a-a5ea-437a-8916-3880131439b3 on agent 

Re: Review Request 71741: Updated operator API documention to use rereservation format.

2019-11-08 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71741/#review218580
---



Bad review!

Reviews applied: [71741, 71739, 71725, 71729]

Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing 
list.

- Mesos Reviewbot


On Nov. 8, 2019, 1:13 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71741/
> ---
> 
> (Updated Nov. 8, 2019, 1:13 p.m.)
> 
> 
> Review request for mesos and Benno Evers.
> 
> 
> Bugs: MESOS-9993
> https://issues.apache.org/jira/browse/MESOS-9993
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated operator API documention to use rereservation format.
> 
> 
> Diffs
> -
> 
>   docs/operator-http-api.md 6cc367dabf3bec507e8d49af54d9aad9ac17471c 
> 
> 
> Diff: https://reviews.apache.org/r/71741/diff/1/
> 
> 
> Testing
> ---
> 
> Previewed in generated site
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 71735: Added 'nodiscard' attribute to some member functions of Resources.

2019-11-07 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71735/#review218570
---



Bad patch!

Reviews applied: [71734, 71735]

Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:14.04' 
BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose 
--disable-libtool-wrappers --disable-parallel-test-execution' 
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh 2>&1 | tee 
build_71735"]

Error:
..
chical.cpp:1625] Framework d2c0f3d0-d637-4928-a83d-e6f1f803763a- filtered 
agent d2c0f3d0-d637-4928-a83d-e6f1f803763a-S0 for 5secs
I1107 17:15:32.903017 18799 master.cpp:12589] Sending operation '' (uuid: 
f6b41846-a77b-4008-8c14-c5311bc1bf09) to agent 
d2c0f3d0-d637-4928-a83d-e6f1f803763a-S0 at slave(1247)@172.17.0.4:39947 
(791d85515a04)
I1107 17:15:32.903573 18804 slave.cpp:4352] Ignoring new checkpointed resources 
and operations identical to the current version
I1107 17:15:32.906338 18802 provider.cpp:498] Received APPLY_OPERATION event
I1107 17:15:32.906379 18802 provider.cpp:1351] Received RESERVE operation '' 
(uuid: f6b41846-a77b-4008-8c14-c5311bc1bf09)
I1107 17:15:32.920514 18799 status_update_manager_process.hpp:152] Received 
operation status update OPERATION_FINISHED (Status UUID: 
7cd79696-a316-4286-a4e6-f45fc42c62bf) for operation UUID 
f6b41846-a77b-4008-8c14-c5311bc1bf09 on agent 
d2c0f3d0-d637-4928-a83d-e6f1f803763a-S0
I1107 17:15:32.920583 18799 status_update_manager_process.hpp:414] Creating 
operation status update stream f6b41846-a77b-4008-8c14-c5311bc1bf09 
checkpoint=true
I1107 17:15:32.920883 18799 status_update_manager_process.hpp:929] 
Checkpointing UPDATE for operation status update OPERATION_FINISHED (Status 
UUID: 7cd79696-a316-4286-a4e6-f45fc42c62bf) for operation UUID 
f6b41846-a77b-4008-8c14-c5311bc1bf09 on agent 
d2c0f3d0-d637-4928-a83d-e6f1f803763a-S0
I1107 17:15:32.937435 18799 status_update_manager_process.hpp:528] Forwarding 
operation status update OPERATION_FINISHED (Status UUID: 
7cd79696-a316-4286-a4e6-f45fc42c62bf) for operation UUID 
f6b41846-a77b-4008-8c14-c5311bc1bf09 on agent 
d2c0f3d0-d637-4928-a83d-e6f1f803763a-S0
I1107 17:15:32.938262 18803 http_connection.hpp:131] Sending 
UPDATE_OPERATION_STATUS call to 
http://172.17.0.4:39947/slave(1247)/api/v1/resource_provider
I1107 17:15:32.939275 18793 process.cpp:3671] Handling HTTP event for process 
'slave(1247)' with path: '/slave(1247)/api/v1/resource_provider'
I1107 17:15:32.942592 18792 hierarchical.cpp:1853] Performed allocation for 1 
agents in 1.249097ms
I1107 17:15:32.943356 18794 master.cpp:10427] Sending offers [ 
d2c0f3d0-d637-4928-a83d-e6f1f803763a-O3 ] to framework 
d2c0f3d0-d637-4928-a83d-e6f1f803763a- (default) at 
scheduler-d84d8700-40bf-481e-afbe-e5ec4fce662d@172.17.0.4:39947
I1107 17:15:32.943956 18807 sched.cpp:934] Scheduler::resourceOffers took 
66154ns
I1107 17:15:32.946669 18798 process.cpp:3671] Handling HTTP event for process 
'master' with path: '/master/api/v1'
I1107 17:15:32.948333 18795 http.cpp:1115] HTTP POST for /master/api/v1 from 
172.17.0.4:48928
I1107 17:15:32.948576 18795 http.cpp:263] Processing call CREATE_VOLUMES
I1107 17:15:32.949432 18795 master.cpp:3938] Authorizing principal 
'test-principal' to create volumes 
'[{"disk":{"persistence":{"id":"09e86a6c-aee9-4868-8f78-bc38b51e91bf","principal":"test-principal"},"source":{"id":"/tmp/CSIVersion_StorageLocalResourceProviderTest_OperatorOperationsWithResourceProviderResources_v1_xFSogm/2GB-2d79ba2f-8efc-4ebc-89d1-d942fde9fb29","mount":{"root":"./csi/org.apache.mesos.csi.test/local/mounts"},"profile":"test","type":"MOUNT","vendor":"org.apache.mesos.csi.test.local"},"volume":{"container_path":"volume","mode":"RW"}},"name":"disk","provider_id":{"value":"cee03e8d-a980-4744-b7e9-9d40c2b2df65"},"reservations":[{"role":"storage","type":"DYNAMIC"},{"principal":"test-principal","role":"storage/default-role","type":"DYNAMIC"}],"scalar":{"value":2048.0},"type":"SCALAR"}]'
I1107 17:15:32.950933 18807 sched.cpp:960] Rescinded offer 
d2c0f3d0-d637-4928-a83d-e6f1f803763a-O3
I1107 17:15:32.951045 18807 sched.cpp:971] Scheduler::offerRescinded took 
56333ns
I1107 17:15:32.951463 18796 hierarchical.cpp:1576] Recovered ports(allocated: 
storage/default-role):[31000-32000]; disk(allocated: 
storage/default-role)(reservations: 
[(DYNAMIC,storage),(DYNAMIC,storage/default-role,test-principal)])[MOUNT(org.apache.mesos.csi.test.local,/tmp/CSIVersion_StorageLocalResourceProviderTest_OperatorOperationsWithResourceProviderResources_v1_xFSogm/2GB-2d79ba2f-8efc-4ebc-89d1-d942fde9fb29,test)]:2048;
 cpus(allocated: storage/default-role):2; mem(allocated: 
storage/default-role):1024; disk(allocated: storage/default-role):1024 (total: 
cpus:2; mem:1024; disk:1024; ports:[31000-32000]; disk(reservations: 

Re: Review Request 71725: Added end-to-end test for operator API reservation updates.

2019-11-07 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71725/#review218564
---



Bad review!

Reviews applied: [71725, 71729]

Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing 
list.

- Mesos Reviewbot


On Nov. 6, 2019, 3:54 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71725/
> ---
> 
> (Updated Nov. 6, 2019, 3:54 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-9992
> https://issues.apache.org/jira/browse/MESOS-9992
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a new test to verify that reservations can be updated
> using the operator API.
> 
> 
> Diffs
> -
> 
>   src/tests/api_tests.cpp bd207eaebc8fc14de16f7af633d943b315328e8a 
> 
> 
> Diff: https://reviews.apache.org/r/71725/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>



Re: Review Request 71725: Added end-to-end test for operator API reservation updates.

2019-11-06 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71725/#review218553
---



Bad review!

Reviews applied: [71725, 71729]

Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing 
list.

- Mesos Reviewbot


On Nov. 6, 2019, 3:54 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71725/
> ---
> 
> (Updated Nov. 6, 2019, 3:54 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-9992
> https://issues.apache.org/jira/browse/MESOS-9992
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a new test to verify that reservations can be updated
> using the operator API.
> 
> 
> Diffs
> -
> 
>   src/tests/api_tests.cpp bd207eaebc8fc14de16f7af633d943b315328e8a 
> 
> 
> Diff: https://reviews.apache.org/r/71725/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>



Re: Review Request 71735: Added 'nodiscard' attribute to some Resources member functions.

2019-11-06 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71735/#review218551
---



Bad patch!

Reviews applied: [71734, 71735]

Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:14.04' 
BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose 
--disable-libtool-wrappers --disable-parallel-test-execution' 
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh 2>&1 | tee 
build_71735"]

Error:
..
rchical.cpp:1625] Framework 7491b8f4-7d2d-4724-94cc-0c38789c2e7a- filtered 
agent 7491b8f4-7d2d-4724-94cc-0c38789c2e7a-S0 for 5secs
I1106 18:11:20.941293 18811 master.cpp:12589] Sending operation '' (uuid: 
c1989ea6-a7ac-4bd3-b65b-fdc32bbed1b1) to agent 
7491b8f4-7d2d-4724-94cc-0c38789c2e7a-S0 at slave(1247)@172.17.0.2:34297 
(2fb74f3d6491)
I1106 18:11:20.941938 18812 slave.cpp:4352] Ignoring new checkpointed resources 
and operations identical to the current version
I1106 18:11:20.945087 18816 provider.cpp:498] Received APPLY_OPERATION event
I1106 18:11:20.945124 18816 provider.cpp:1351] Received RESERVE operation '' 
(uuid: c1989ea6-a7ac-4bd3-b65b-fdc32bbed1b1)
I1106 18:11:20.945505 18821 hierarchical.cpp:1853] Performed allocation for 1 
agents in 1.104338ms
I1106 18:11:20.946249 18823 master.cpp:10427] Sending offers [ 
7491b8f4-7d2d-4724-94cc-0c38789c2e7a-O3 ] to framework 
7491b8f4-7d2d-4724-94cc-0c38789c2e7a- (default) at 
scheduler-c9671c16-f19c-4b46-9c4e-70a2728ef6f7@172.17.0.2:34297
I1106 18:11:20.946883 18808 sched.cpp:934] Scheduler::resourceOffers took 
78640ns
I1106 18:11:20.959390 18819 status_update_manager_process.hpp:152] Received 
operation status update OPERATION_FINISHED (Status UUID: 
35259340-e89f-493e-b68e-9724509e9da5) for operation UUID 
c1989ea6-a7ac-4bd3-b65b-fdc32bbed1b1 on agent 
7491b8f4-7d2d-4724-94cc-0c38789c2e7a-S0
I1106 18:11:20.959455 18819 status_update_manager_process.hpp:414] Creating 
operation status update stream c1989ea6-a7ac-4bd3-b65b-fdc32bbed1b1 
checkpoint=true
I1106 18:11:20.959676 18819 status_update_manager_process.hpp:929] 
Checkpointing UPDATE for operation status update OPERATION_FINISHED (Status 
UUID: 35259340-e89f-493e-b68e-9724509e9da5) for operation UUID 
c1989ea6-a7ac-4bd3-b65b-fdc32bbed1b1 on agent 
7491b8f4-7d2d-4724-94cc-0c38789c2e7a-S0
I1106 18:11:20.976094 18819 status_update_manager_process.hpp:528] Forwarding 
operation status update OPERATION_FINISHED (Status UUID: 
35259340-e89f-493e-b68e-9724509e9da5) for operation UUID 
c1989ea6-a7ac-4bd3-b65b-fdc32bbed1b1 on agent 
7491b8f4-7d2d-4724-94cc-0c38789c2e7a-S0
I1106 18:11:20.977013 18810 http_connection.hpp:131] Sending 
UPDATE_OPERATION_STATUS call to 
http://172.17.0.2:34297/slave(1247)/api/v1/resource_provider
I1106 18:11:20.978180 18822 process.cpp:3671] Handling HTTP event for process 
'slave(1247)' with path: '/slave(1247)/api/v1/resource_provider'
I1106 18:11:20.981583 18811 process.cpp:3671] Handling HTTP event for process 
'master' with path: '/master/api/v1'
I1106 18:11:20.983410 18816 http.cpp:1115] HTTP POST for /master/api/v1 from 
172.17.0.2:47100
I1106 18:11:20.983711 18816 http.cpp:263] Processing call CREATE_VOLUMES
I1106 18:11:20.984638 18816 master.cpp:3938] Authorizing principal 
'test-principal' to create volumes 
'[{"disk":{"persistence":{"id":"180a39c1-1d5c-4434-bdc0-10bd66a2102e","principal":"test-principal"},"source":{"id":"/tmp/CSIVersion_StorageLocalResourceProviderTest_OperatorOperationsWithResourceProviderResources_v1_3hXmZR/2GB-220194ee-efa6-4eaa-8b6d-b7656c30064d","mount":{"root":"./csi/org.apache.mesos.csi.test/local/mounts"},"profile":"test","type":"MOUNT","vendor":"org.apache.mesos.csi.test.local"},"volume":{"container_path":"volume","mode":"RW"}},"name":"disk","provider_id":{"value":"a5030b85-7c75-4fc1-aa23-594c4f90092f"},"reservations":[{"role":"storage","type":"DYNAMIC"},{"principal":"test-principal","role":"storage/default-role","type":"DYNAMIC"}],"scalar":{"value":2048.0},"type":"SCALAR"}]'
I1106 18:11:20.986253 18820 sched.cpp:960] Rescinded offer 
7491b8f4-7d2d-4724-94cc-0c38789c2e7a-O3
I1106 18:11:20.986346 18820 sched.cpp:971] Scheduler::offerRescinded took 
31562ns
I1106 18:11:20.986788 18822 hierarchical.cpp:1576] Recovered ports(allocated: 
storage/default-role):[31000-32000]; disk(allocated: 
storage/default-role)(reservations: 
[(DYNAMIC,storage),(DYNAMIC,storage/default-role,test-principal)])[MOUNT(org.apache.mesos.csi.test.local,/tmp/CSIVersion_StorageLocalResourceProviderTest_OperatorOperationsWithResourceProviderResources_v1_3hXmZR/2GB-220194ee-efa6-4eaa-8b6d-b7656c30064d,test)]:2048;
 cpus(allocated: storage/default-role):2; mem(allocated: 
storage/default-role):1024; disk(allocated: storage/default-role):1024 (total: 
cpus:2; mem:1024; disk:1024; ports:[31000-32000]; disk(reservations: 

Re: Review Request 71732: Fixed an incorrect resource mutation.

2019-11-06 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71732/#review218543
---



Patch looks great!

Reviews applied: [71732]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Nov. 6, 2019, 12:54 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71732/
> ---
> 
> (Updated Nov. 6, 2019, 12:54 p.m.)
> 
> 
> Review request for mesos, Benno Evers and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> `Resources::pushReservation` does not mutate the `Resources` it is
> invoked on; instead it returns its result which should then be used.
> 
> This issue was identified by making `Resources::pushReservation`
> `nodiscard`.
> 
> 
> Diffs
> -
> 
>   src/tests/scheduler_tests.cpp e0ed02900330c678bbf5c609c1f45d05147851ed 
> 
> 
> Diff: https://reviews.apache.org/r/71732/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 71725: Added end-to-end test for operator API reservation updates.

2019-11-06 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71725/#review218531
---



Bad review!

Reviews applied: [71725, 71729]

Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing 
list.

- Mesos Reviewbot


On Nov. 6, 2019, 12:09 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71725/
> ---
> 
> (Updated Nov. 6, 2019, 12:09 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a new test to verify that reservations can be updated
> using the operator API.
> 
> 
> Diffs
> -
> 
>   src/tests/api_tests.cpp bd207eaebc8fc14de16f7af633d943b315328e8a 
> 
> 
> Diff: https://reviews.apache.org/r/71725/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>



Re: Review Request 71729: Added authorization handling for reservations with `source`.

2019-11-06 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71729/#review218527
---



Bad review!

Reviews applied: [71729]

Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing 
list.

- Mesos Reviewbot


On Nov. 6, 2019, 10:10 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71729/
> ---
> 
> (Updated Nov. 6, 2019, 10:10 a.m.)
> 
> 
> Review request for mesos and Benno Evers.
> 
> 
> Bugs: MESOS-9991
> https://issues.apache.org/jira/browse/MESOS-9991
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds authorization handling for `RESERVE` operations
> containing `source` fields. In order to stay backwards-compatible we add
> a dedicated authorization branch for such operations which under the
> hood translates each removed reservation to an `UNRESERVE` operation and
> every added reservation as a `RESERVE` operation where we fall back to
> existing authorization code for authorization.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 2fdd6f7ddbb488d785c6f875c8b0c46c5f881d9d 
>   src/tests/master_authorization_tests.cpp 
> 06471aa7779d399f4474ed40db3fbcc60b8298b2 
> 
> 
> Diff: https://reviews.apache.org/r/71729/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 71666: SSL Wrapper: Implemented send/recv and shutdown.

2019-11-05 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71666/#review218520
---



Patch looks great!

Reviews applied: [71659, 71660, 71661, 71662, 71663, 71664, 71665, 71666]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Nov. 6, 2019, 3:41 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71666/
> ---
> 
> (Updated Nov. 6, 2019, 3:41 a.m.)
> 
> 
> Review request for mesos, Benno Evers, Benjamin Mahler, Greg Mann, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-10010
> https://issues.apache.org/jira/browse/MESOS-10010
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This completes a fully functional client-side SSL socket.
> 
> Needs a bit of cleanup and more error handling though.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/ssl/socket_wrapper.hpp PRE-CREATION 
>   3rdparty/libprocess/src/ssl/socket_wrapper.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/71666/diff/4/
> 
> 
> Testing
> ---
> 
> ```
> cmake --build . --target libprocess-tests
> libprocess-tests
> ```
> 
> Running libprocess-tests yields:
> ```
> [  FAILED  ] SSLTest.ValidDowngrade
> [  FAILED  ] SSLTest.ValidDowngradeEachProtocol
> [  FAILED  ] Encryption/NetSocketTest.EOFBeforeRecv/0, where GetParam() = 
> "SSL"
> [  FAILED  ] Encryption/NetSocketTest.EOFAfterRecv/0, where GetParam() = "SSL"
> ```
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>



Re: Review Request 71722: Improved error reporting in 'Resources::pushReservation()'.

2019-11-05 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71722/#review218514
---



Patch looks great!

Reviews applied: [71722]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Nov. 5, 2019, 5:05 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71722/
> ---
> 
> (Updated Nov. 5, 2019, 5:05 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Make sure to print the actual error message after an assertion
> failure in `Resources::pushReservations()`.
> 
> 
> Diffs
> -
> 
>   src/common/resources.cpp bfa9f3ea7e8c3e2dc9b4c4f7c86ad29b0de81f24 
> 
> 
> Diff: https://reviews.apache.org/r/71722/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>



Re: Review Request 71700: Updated offer operation resource validation for reservation updates.

2019-11-05 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71700/#review218511
---



Patch looks great!

Reviews applied: [71679, 71686, 71699, 71687, 71688, 71690, 71695, 71696, 71700]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Oct. 29, 2019, 6:13 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71700/
> ---
> 
> (Updated Oct. 29, 2019, 6:13 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated `validateAndUpgradeResources()` to also validate the `source`
> field in a reservation.
> 
> 
> Diffs
> -
> 
>   src/common/resources_utils.cpp cbdad4b045ad957b2ab1fd09a6b9fb12bb4fb523 
> 
> 
> Diff: https://reviews.apache.org/r/71700/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>



Re: Review Request 71700: Updated offer operation resource validation for reservation updates.

2019-11-05 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71700/#review218504
---



Patch looks great!

Reviews applied: [71679, 71686, 71699, 71687, 71688, 71690, 71695, 71696, 71700]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Oct. 29, 2019, 6:13 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71700/
> ---
> 
> (Updated Oct. 29, 2019, 6:13 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated `validateAndUpgradeResources()` to also validate the `source`
> field in a reservation.
> 
> 
> Diffs
> -
> 
>   src/common/resources_utils.cpp cbdad4b045ad957b2ab1fd09a6b9fb12bb4fb523 
> 
> 
> Diff: https://reviews.apache.org/r/71700/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>



Re: Review Request 71700: Updated offer operation resource validation for reservation updates.

2019-11-01 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71700/#review218485
---



Bad review!

Reviews applied: [71700, 71696, 71695, 71690, 71688, 71687, 71699, 71686, 71679]

Error:
2019-11-01 17:04:10 URL:https://reviews.apache.org/r/71695/diff/raw/ 
[5000/5000] -> "71695.patch" [1]
error: patch failed: src/master/http.cpp:2010
error: src/master/http.cpp: patch does not apply

- Mesos Reviewbot


On Oct. 29, 2019, 6:13 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71700/
> ---
> 
> (Updated Oct. 29, 2019, 6:13 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated `validateAndUpgradeResources()` to also validate the `source`
> field in a reservation.
> 
> 
> Diffs
> -
> 
>   src/common/resources_utils.cpp cbdad4b045ad957b2ab1fd09a6b9fb12bb4fb523 
> 
> 
> Diff: https://reviews.apache.org/r/71700/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>



Re: Review Request 71641: Garbage-collected lost tasks which are reported as running again.

2019-11-01 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71641/#review218484
---



Patch looks great!

Reviews applied: [71641]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Nov. 1, 2019, 12:08 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71641/
> ---
> 
> (Updated Nov. 1, 2019, 12:08 p.m.)
> 
> 
> Review request for mesos, Benno Evers, Benjamin Mahler, and Greg Mann.
> 
> 
> Bugs: MESOS-10018
> https://issues.apache.org/jira/browse/MESOS-10018
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Under certain conditions tasks which were previously `TASK_LOST` and
> completed can reappear in non-terminal states, e.g., if the agent on
> which they where running reconnect.
> 
> This patch adds garbage collection of such completed tasks so that users
> do not see tasks twice when obtaining task information from the master
> API. This change does not affect tasks status updates where we already
> correctly reported a previously `TASK_LOST` state as superseded by e.g.,
> `TASK_RUNNING`.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 351823e69f14dbb5eb1ea2b108c42e93722f1eff 
>   src/tests/master_tests.cpp 5486e23ce146eda9191e081a48c1f3fcb52a7569 
> 
> 
> Diff: https://reviews.apache.org/r/71641/diff/5/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 71666: WIP: SSL Wrapper: Implemented send/recv and shutdown.

2019-10-30 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71666/#review218472
---



Patch looks great!

Reviews applied: [71659, 71660, 71661, 71662, 71663, 71664, 71665, 71666]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Oct. 31, 2019, 1:35 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71666/
> ---
> 
> (Updated Oct. 31, 2019, 1:35 a.m.)
> 
> 
> Review request for mesos, Benno Evers, Benjamin Mahler, Greg Mann, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-10010
> https://issues.apache.org/jira/browse/MESOS-10010
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This completes a fully functional client-side SSL socket.
> 
> Needs a bit of cleanup and more error handling though.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/ssl/socket_wrapper.hpp PRE-CREATION 
>   3rdparty/libprocess/src/ssl/socket_wrapper.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/71666/diff/2/
> 
> 
> Testing
> ---
> 
> Successfully fetched from a webpage:
> ```
>   http::URL url = http::URL(
>  "https",
>  "www.google.com",
>  443);
> 
>   Future response = http::get(url);
>   AWAIT_READY(response);
>   EXPECT_EQ(http::Status::OK, response->code);
> ```
> 
> Running libprocess-tests yields:
> ```
> [  FAILED  ] SSLTest.SilentSocket (hangs indefinitely)
> [  FAILED  ] SSLTest.ValidDowngrade
> [  FAILED  ] SSLTest.ValidDowngradeEachProtocol
> [  FAILED  ] SSLTest.ShutdownThenSend
> ```
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>



Re: Review Request 71641: Garbage-collected lost tasks which are reported as running again.

2019-10-30 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71641/#review218459
---



Bad patch!

Reviews applied: [71641]

Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:14.04' 
BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose 
--disable-libtool-wrappers --disable-parallel-test-execution' 
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh 2>&1 | tee 
build_71641"]

Error:
..
=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 
-DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_CXX11=1 
-DHAVE_PTHREAD_PRIO_INHERIT=1 -DHAVE_PTHREAD=1 -DHAVE_OPENSSL_SSL_H=1 
-DHAVE_FTS_H=1 -DHAVE_APR_POOLS_H=1 -DHAVE_LIBAPR_1=1 -DHAVE_LIBCURL=1 
-DMESOS_HAS_JAVA=1 -DHAVE_LIBSASL2=1 -DHAVE_SVN_VERSION_H=1 
-DHAVE_LIBSVN_SUBR_1=1 -DHAVE_SVN_DELTA_H=1 -DHAVE_LIBSVN_DELTA_1=1 
-DHAVE_ZLIB_H=1 -DHAVE_LIBZ=1 -DHAVE_PYTHON=\"2.7\" -DMESOS_HAS_PYTHON=1 -I. 
-I../../src   -Werror -DLIBDIR=\"/mesos/mesos-1.10.0/_inst/lib\" 
-DPKGLIBEXECDIR=\"/mesos/mesos-1.10.0/_inst/libexec/mesos\" 
-DPKGDATADIR=\"/mesos/mesos-1.10.0/_inst/share/mesos\" 
-DPKGMODULEDIR=\"/mesos/mesos-1.10.0/_inst/lib/mesos/modules\" -I../../include 
-I../include -I../include/mesos -D__STDC_FORMAT_MACROS 
-I../3rdparty/boost-1.65.0 -I../3rdparty/concurrentqueue-7b69a8f 
-I../3rdparty/elfio-3.2 -I../3rdparty/glog-0.4.0/src 
-I../3rdparty/grpc-1.10.0/include -I../3rdparty/leveldb-1.19/include 
 -I../3rdparty/libarchive-3.3.2/libarchive/ -I../../3rdparty/libprocess/include 
 -I../3rdparty/nvml-352.79 -I../3rdparty/picojson-1.3.0 
-I../3rdparty/protobuf-3.5.0/src -I../3rdparty/rapidjson-1.1.0/include 
-I../../3rdparty/stout/include -I../3rdparty/zookeeper-3.4.8/src/c/include 
-I../3rdparty/zookeeper-3.4.8/src/c/generated 
-DSOURCE_DIR=\"/mesos/mesos-1.10.0/_build/..\" 
-DBUILD_DIR=\"/mesos/mesos-1.10.0/_build\" 
-I../3rdparty/googletest-release-1.8.0/googletest/include 
-I../3rdparty/googletest-release-1.8.0/googlemock/include 
-DTESTLIBEXECDIR=\"/mesos/mesos-1.10.0/_inst/libexec/mesos/tests\" 
-DSBINDIR=\"/mesos/mesos-1.10.0/_inst/sbin\" 
-I/usr/lib/jvm/java-7-openjdk-amd64/include 
-I/usr/lib/jvm/java-7-openjdk-amd64/include/linux -DZOOKEEPER_VERSION=\"3.4.8\" 
-I/usr/include/subversion-1 -I/usr/include/apr-1 -I/usr/include/apr-1.0 
 -pthread -Wall -Wsign-compare -Wformat-security -fstack-protector -fPIC 
-fPIE -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -c -o tests/mesos_tests-d
 isk_quota_tests.o `test -f 'tests/disk_quota_tests.cpp' || echo 
'../../src/'`tests/disk_quota_tests.cpp
g++ -DPACKAGE_NAME=\"mesos\" -DPACKAGE_TARNAME=\"mesos\" 
-DPACKAGE_VERSION=\"1.10.0\" -DPACKAGE_STRING=\"mesos\ 1.10.0\" 
-DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"mesos\" 
-DVERSION=\"1.10.0\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 
-DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 
-DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 
-DLT_OBJDIR=\".libs/\" -DHAVE_CXX11=1 -DHAVE_PTHREAD_PRIO_INHERIT=1 
-DHAVE_PTHREAD=1 -DHAVE_OPENSSL_SSL_H=1 -DHAVE_FTS_H=1 -DHAVE_APR_POOLS_H=1 
-DHAVE_LIBAPR_1=1 -DHAVE_LIBCURL=1 -DMESOS_HAS_JAVA=1 -DHAVE_LIBSASL2=1 
-DHAVE_SVN_VERSION_H=1 -DHAVE_LIBSVN_SUBR_1=1 -DHAVE_SVN_DELTA_H=1 
-DHAVE_LIBSVN_DELTA_1=1 -DHAVE_ZLIB_H=1 -DHAVE_LIBZ=1 -DHAVE_PYTHON=\"2.7\" 
-DMESOS_HAS_PYTHON=1 -I. -I../../src   -Werror 
-DLIBDIR=\"/mesos/mesos-1.10.0/_inst/lib\" 
-DPKGLIBEXECDIR=\"/mesos/mesos-1.10.0/_inst/libexec/mesos\" 
-DPKGDATADIR=\"/mesos/mesos-1.10.0/_inst/share/mesos\" -DPKGMODULEDIR=\"/mesos/
 mesos-1.10.0/_inst/lib/mesos/modules\" -I../../include -I../include 
-I../include/mesos -D__STDC_FORMAT_MACROS -I../3rdparty/boost-1.65.0 
-I../3rdparty/concurrentqueue-7b69a8f -I../3rdparty/elfio-3.2 
-I../3rdparty/glog-0.4.0/src -I../3rdparty/grpc-1.10.0/include 
-I../3rdparty/leveldb-1.19/include -I../3rdparty/libarchive-3.3.2/libarchive/ 
-I../../3rdparty/libprocess/include  -I../3rdparty/nvml-352.79 
-I../3rdparty/picojson-1.3.0 -I../3rdparty/protobuf-3.5.0/src 
-I../3rdparty/rapidjson-1.1.0/include -I../../3rdparty/stout/include 
-I../3rdparty/zookeeper-3.4.8/src/c/include 
-I../3rdparty/zookeeper-3.4.8/src/c/generated 
-DSOURCE_DIR=\"/mesos/mesos-1.10.0/_build/..\" 
-DBUILD_DIR=\"/mesos/mesos-1.10.0/_build\" 
-I../3rdparty/googletest-release-1.8.0/googletest/include 
-I../3rdparty/googletest-release-1.8.0/googlemock/include 
-DTESTLIBEXECDIR=\"/mesos/mesos-1.10.0/_inst/libexec/mesos/tests\" 
-DSBINDIR=\"/mesos/mesos-1.10.0/_inst/sbin\" 
-I/usr/lib/jvm/java-7-openjdk-amd64/include -I/usr/lib/
 jvm/java-7-openjdk-amd64/include/linux -DZOOKEEPER_VERSION=\"3.4.8\" 
-I/usr/include/subversion-1 -I/usr/include/apr-1 -I/usr/include/apr-1.0 
 -pthread -Wall -Wsign-compare -Wformat-security -fstack-protector -fPIC -fPIE 
-g1 -O0 

Re: Review Request 71700: Updated offer operation resource validation for reservation updates.

2019-10-29 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71700/#review218439
---



Bad patch!

Reviews applied: [71679, 71686, 71699, 71687, 71688, 71690, 71695, 71696, 71700]

Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:14.04' 
BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose 
--disable-libtool-wrappers --disable-parallel-test-execution' 
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh 2>&1 | tee 
build_71700"]

Error:
..
obuf/internal/factory_test1_pb2.py to factory_test1_pb2.pyc
byte-compiling 
build/bdist.linux-x86_64/egg/google/protobuf/internal/packed_field_test_pb2.py 
to packed_field_test_pb2.pyc
byte-compiling 
build/bdist.linux-x86_64/egg/google/protobuf/internal/well_known_types.py to 
well_known_types.pyc
byte-compiling 
build/bdist.linux-x86_64/egg/google/protobuf/internal/text_encoding_test.py to 
text_encoding_test.pyc
byte-compiling 
build/bdist.linux-x86_64/egg/google/protobuf/internal/type_checkers.py to 
type_checkers.pyc
byte-compiling 
build/bdist.linux-x86_64/egg/google/protobuf/internal/wire_format_test.py to 
wire_format_test.pyc
byte-compiling 
build/bdist.linux-x86_64/egg/google/protobuf/internal/api_implementation.py to 
api_implementation.pyc
byte-compiling 
build/bdist.linux-x86_64/egg/google/protobuf/internal/symbol_database_test.py 
to symbol_database_test.pyc
byte-compiling 
build/bdist.linux-x86_64/egg/google/protobuf/internal/message_factory_test.py 
to message_factory_test.pyc
byte-compiling 
build/bdist.linux-x86_64/egg/google/protobuf/internal/reflection_test.py to 
reflection_test.pyc
byte-compiling 
build/bdist.linux-x86_64/egg/google/protobuf/internal/any_test_pb2.py to 
any_test_pb2.pyc
byte-compiling 
build/bdist.linux-x86_64/egg/google/protobuf/internal/import_test_package/outer_pb2.py
 to outer_pb2.pyc
byte-compiling 
build/bdist.linux-x86_64/egg/google/protobuf/internal/import_test_package/inner_pb2.py
 to inner_pb2.pyc
byte-compiling 
build/bdist.linux-x86_64/egg/google/protobuf/internal/import_test_package/__init__.py
 to __init__.pyc
byte-compiling 
build/bdist.linux-x86_64/egg/google/protobuf/internal/descriptor_test.py to 
descriptor_test.pyc
byte-compiling 
build/bdist.linux-x86_64/egg/google/protobuf/internal/message_test.py to 
message_test.pyc
/bin/bash ../libtool  --tag=CXX   --mode=compile g++ -DPACKAGE_NAME=\"mesos\" 
-DPACKAGE_TARNAME=\"mesos\" -DPACKAGE_VERSION=\"1.10.0\" 
-DPACKAGE_STRING=\"mesos\ 1.10.0\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" 
-DPACKAGE=\"mesos\" -DVERSION=\"1.10.0\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 
-DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 
-DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 
-DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_CXX11=1 
-DHAVE_PTHREAD_PRIO_INHERIT=1 -DHAVE_PTHREAD=1 -DHAVE_OPENSSL_SSL_H=1 
-DHAVE_FTS_H=1 -DHAVE_APR_POOLS_H=1 -DHAVE_LIBAPR_1=1 -DHAVE_LIBCURL=1 
-DMESOS_HAS_JAVA=1 -DHAVE_LIBSASL2=1 -DHAVE_SVN_VERSION_H=1 
-DHAVE_LIBSVN_SUBR_1=1 -DHAVE_SVN_DELTA_H=1 -DHAVE_LIBSVN_DELTA_1=1 
-DHAVE_ZLIB_H=1 -DHAVE_LIBZ=1 -DHAVE_PYTHON=\"2.7\" -DMESOS_HAS_PYTHON=1 -I. 
-I../../src   -Werror -DLIBDIR=\"/mesos/mesos-1.10.0/_inst/lib\" 
-DPKGLIBEXECDIR=\"/mesos/mesos-1.10.0/_inst/libexec/mesos\" 
-DPKGDATADIR=\"/mesos/mesos-1.
 10.0/_inst/share/mesos\" 
-DPKGMODULEDIR=\"/mesos/mesos-1.10.0/_inst/lib/mesos/modules\" -I../../include 
-I../include -I../include/mesos -D__STDC_FORMAT_MACROS 
-I../3rdparty/boost-1.65.0 -I../3rdparty/concurrentqueue-7b69a8f 
-I../3rdparty/elfio-3.2 -I../3rdparty/glog-0.4.0/src 
-I../3rdparty/grpc-1.10.0/include -I../3rdparty/leveldb-1.19/include 
-I../3rdparty/libarchive-3.3.2/libarchive/ -I../../3rdparty/libprocess/include  
-I../3rdparty/nvml-352.79 -I../3rdparty/picojson-1.3.0 
-I../3rdparty/protobuf-3.5.0/src -I../3rdparty/rapidjson-1.1.0/include 
-I../../3rdparty/stout/include -I../3rdparty/zookeeper-3.4.8/src/c/include 
-I../3rdparty/zookeeper-3.4.8/src/c/generated -I/usr/include/subversion-1 
-I/usr/include/apr-1 -I/usr/include/apr-1.0  -pthread -Wall 
-Wsign-compare -Wformat-security -fstack-protector -fPIC -fPIE -g1 -O0 
-Wno-unused-local-typedefs -std=c++11 -c -o 
authentication/cram_md5/libmesos_no_3rdparty_la-authenticatee.lo `test -f 
'authentication/cram_md5/authenticatee.cp
 p' || echo '../../src/'`authentication/cram_md5/authenticatee.cpp
byte-compiling 
build/bdist.linux-x86_64/egg/google/protobuf/internal/file_options_test_pb2.py 
to file_options_test_pb2.pyc
byte-compiling build/bdist.linux-x86_64/egg/google/protobuf/timestamp_pb2.py to 
timestamp_pb2.pyc
byte-compiling build/bdist.linux-x86_64/egg/google/protobuf/struct_pb2.py to 
struct_pb2.pyc
byte-compiling build/bdist.linux-x86_64/egg/google/protobuf/map_unittest_pb2.py 
to map_unittest_pb2.pyc
byte-compiling 

Re: Review Request 71698: Optimized tracking of cluster resource totals.

2019-10-29 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71698/#review218437
---



Bad review!

Reviews applied: [71698]

Error:
2019-10-29 17:46:22 URL:https://reviews.apache.org/r/71698/diff/raw/ 
[41082/41082] -> "71698.patch" [1]
error: patch failed: src/master/allocator/mesos/hierarchical.hpp:523
error: src/master/allocator/mesos/hierarchical.hpp: patch does not apply
error: patch failed: src/master/allocator/mesos/hierarchical.cpp:537
error: src/master/allocator/mesos/hierarchical.cpp: patch does not apply
error: src/master/allocator/sorter/drf/sorter.hpp: does not exist in index
error: src/master/allocator/sorter/drf/sorter.cpp: does not exist in index
error: src/master/allocator/sorter/random/sorter.hpp: does not exist in index
error: src/master/allocator/sorter/random/sorter.cpp: does not exist in index
error: src/master/allocator/sorter/sorter.hpp: does not exist in index
error: patch failed: src/tests/sorter_tests.cpp:1613
error: src/tests/sorter_tests.cpp: patch does not apply

- Mesos Reviewbot


On Oct. 29, 2019, 4:38 p.m., Andrei Sekretenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71698/
> ---
> 
> (Updated Oct. 29, 2019, 4:38 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Meng Zhu.
> 
> 
> Bugs: MESOS-10015
> https://issues.apache.org/jira/browse/MESOS-10015
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch addresses poor performance of
> `HierarchicalAllocatorProcess::updateAllocation()` for agents with
> a huge number of non-addable resources in a many-framework case
> (see MESOS-10015).
> 
> Sorter methods for totals tracking that modify `Resources` of an agent
> in the Sorter are replaced with methods that add/remove resource
> quantities of an agent as a whole (which was actually the only use case
> of the old methods). Thus, subtracting/adding `Resources` of a whole
> agent no longer occurs when updating resources of an agent in a Sorter.
> 
> Further, this patch completely removes agent resource tracking logic
> from the random sorter (which by itself makes no use of them) by
> implementing cluster totals tracking in the allocator.
> 
> Results of `*BENCHMARK_WithReservationParam.UpdateAllocation*`
> (for the DRF sorter):
> 
> 1.7.x branch:
> Agent resources size: 200 (50 frameworks)
> Made 20 reserve and unreserve operations in 2.014081646secs
> Agent resources size: 400 (100 frameworks)
> Made 20 reserve and unreserve operations in 13.623513239secs
> Agent resources size: 800 (200 frameworks)
> Made 20 reserve and unreserve operations in 2.14100063438333mins
> Agent resources size: 1600 (400 frameworks)
> (killed after several minutes)
> 
> 1.7.x branch + this patch:
> Agent resources size: 200 (50 frameworks)
> Made 20 reserve and unreserve operations in 236.706615ms
> Agent resources size: 400 (100 frameworks)
> Made 20 reserve and unreserve operations in 483.544585ms
> Agent resources size: 800 (200 frameworks)
> Made 20 reserve and unreserve operations in 1.095224322secs
> ...
> Agent resources size: 6400 (1600 frameworks)
> Made 20 reserve and unreserve operations in 50.369691741secs
> 
> This is a backport of https://reviews.apache.org/r/71646
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> 1fce68fbdbb36edad0425dbd0d9c818f2cd0870e 
>   src/master/allocator/mesos/hierarchical.cpp 
> 3e8a8ce728b4cf1f45947f8fb2814c87b6468d91 
>   src/master/allocator/sorter/drf/sorter.hpp 
> 75f90f331fbe2ec514daa3fe00b0b05ad55932e1 
>   src/master/allocator/sorter/drf/sorter.cpp 
> 43c97671d692675df6a347e4482126d83d7e3f24 
>   src/master/allocator/sorter/random/sorter.hpp 
> 2031cb234cc3e29723f07ec7d3a7e8671a26a97f 
>   src/master/allocator/sorter/random/sorter.cpp 
> 6fcfc41f65bb6401cfb60af88866c2b02920887e 
>   src/master/allocator/sorter/sorter.hpp 
> 25ad48dff7e624e7d25072958bdd20513ab83d12 
>   src/tests/sorter_tests.cpp 1e2791f993af2fba592b0e76493864c096a0bb5f 
> 
> 
> Diff: https://reviews.apache.org/r/71698/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> `*BENCHMARK_WithReservationParam.UpdateAllocation*`:
> 
> **Before:**
> Agent resources size: 200 (50 roles, 1 reservations per role, 1 port ranges)
> Made 20 reserve and unreserve operations in 2.014081646secs
> Average UNRESERVE duration: 50.561677ms
> Average RESERVE duration: 50.142404ms
> 
> Agent resources size: 400 (100 rol

Re: Review Request 71697: Optimized tracking of cluster resource totals.

2019-10-29 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71697/#review218435
---



Bad review!

Reviews applied: [71697]

Error:
2019-10-29 16:48:01 URL:https://reviews.apache.org/r/71697/diff/raw/ 
[39429/39429] -> "71697.patch" [1]
error: patch failed: src/master/allocator/mesos/hierarchical.hpp:529
error: src/master/allocator/mesos/hierarchical.hpp: patch does not apply
error: patch failed: src/master/allocator/mesos/hierarchical.cpp:570
error: src/master/allocator/mesos/hierarchical.cpp: patch does not apply
error: src/master/allocator/sorter/drf/sorter.hpp: does not exist in index
error: src/master/allocator/sorter/drf/sorter.cpp: does not exist in index
error: src/master/allocator/sorter/random/sorter.hpp: does not exist in index
error: src/master/allocator/sorter/random/sorter.cpp: does not exist in index
error: src/master/allocator/sorter/sorter.hpp: does not exist in index

- Mesos Reviewbot


On Oct. 29, 2019, 3:30 p.m., Andrei Sekretenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71697/
> ---
> 
> (Updated Oct. 29, 2019, 3:30 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Meng Zhu.
> 
> 
> Bugs: MESOS-10015
> https://issues.apache.org/jira/browse/MESOS-10015
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch addresses poor performance of
> `HierarchicalAllocatorProcess::updateAllocation()` for agents with
> a huge number of non-addable resources in a many-framework case
> (see MESOS-10015).
> 
> Sorter methods for totals tracking that modify `Resources` of an agent
> in the Sorter are replaced with methods that add/remove resource
> quantities of an agent as a whole (which was actually the only use case
> of the old methods). Thus, subtracting/adding `Resources` of a whole
> agent no longer occurs when updating resources of an agent in a Sorter.
> 
> Further, this patch completely removes agent resource tracking logic
> from the random sorter (which by itself makes no use of them) by
> implementing cluster totals tracking in the allocator.
> 
> Results of `*BENCHMARK_WithReservationParam.UpdateAllocation*`
> (for the DRF sorter):
> 
> 1.8.x branch:
> Agent resources size: 200 (50 frameworks)
> Made 20 reserve and unreserve operations in 1.938801227secs
> Agent resources size: 400 (100 frameworks)
> Made 20 reserve and unreserve operations in 13.861857374secs
> Agent resources size: 800 (200 frameworks)
> Made 20 reserve and unreserve operations in 2.13412983136667mins
> 
> 1.8.x branch + this pathch:
> Agent resources size: 200 (50 frameworks)
> Made 20 reserve and unreserve operations in 214.063821ms
> Agent resources size: 400 (100 frameworks)
> Made 20 reserve and unreserve operations in 425.278671ms
> Agent resources size: 800 (200 frameworks)
> Made 20 reserve and unreserve operations in 1.136214374secs
> ...
> Agent resources size: 6400 (1600 frameworks)
> Made 20 reserve and unreserve operations in 50.094194999secs
> 
> This is a backport of https://reviews.apache.org/r/71646
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> 4f716820748e070569e988f8dad15670367a74b7 
>   src/master/allocator/mesos/hierarchical.cpp 
> 061b70258f4874f4f2b26a57705b9ba1543c7553 
>   src/master/allocator/sorter/drf/sorter.hpp 
> 7daf1bfd2dfe88e2d8e0af07c8af8aa823f80935 
>   src/master/allocator/sorter/drf/sorter.cpp 
> 9367469132e426f0b4b66a80ad300c157fba6bf2 
>   src/master/allocator/sorter/random/sorter.hpp 
> c8e777be256b4faf931bf1a106185d7f91b3ba6f 
>   src/master/allocator/sorter/random/sorter.cpp 
> 9899cfd570607a60dbd7980d340a8e7d9d3e6df5 
>   src/master/allocator/sorter/sorter.hpp 
> d56a1166a9e82b034564842ac071874ec2885004 
>   src/tests/sorter_tests.cpp 1e4a7893411d2107049a7bb92ee159526588c58c 
> 
> 
> Diff: https://reviews.apache.org/r/71697/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> `*BENCHMARK_WithReservationParam.UpdateAllocation*`:
> 
> **Before:**
> 
> Agent resources size: 200 (50 roles, 1 reservations per role, 1 port ranges)
> Made 20 reserve and unreserve operations in 1.938801227secs
> Average UNRESERVE duration: 49.161884ms
> Average RESERVE duration: 47.778177ms
> 
> Agent resources size: 400 (100 roles, 1 reservations per role, 1 port ranges)
> Made 20 reserve and unreserve operations in 13.861857374secs
> Average UNRESERVE duration: 346.822609ms
> Average RESERVE duration

Re: Review Request 71639: Added an benchmark for `allocator->UpdateAllocation()`.

2019-10-29 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71639/#review218432
---



Patch looks great!

Reviews applied: [71639]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Oct. 29, 2019, 3:43 a.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71639/
> ---
> 
> (Updated Oct. 29, 2019, 3:43 a.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
> 
> 
> Bugs: MESOS-10016
> https://issues.apache.org/jira/browse/MESOS-10016
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This benchmark evaluates the performance of
> `allocator->UpdateAllocation()` where the agent has various
> sizes of resource reservations.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> 38fd19cee6409e4daa5bb0ab523e8e464cdcc9a5 
> 
> 
> Diff: https://reviews.apache.org/r/71639/diff/3/
> 
> 
> Testing
> ---
> 
> On the master branch optimized build:
> 
> ```
> [ RUN  ] 
> ResourceParam/HierarchicalAllocator__BENCHMARK_WithResourceParam.UpdateAllocation/0
> Agent resources size: 50 (50 roles, 1 reservations per role, 1 ranges per 
> port resource)
> 20 RESERVE operations took 1.968569746secs, each takes 98.428487ms
> 20 UNRESERVE operations took 1.978470742secs, each takes 98.923537ms
> [   OK ] 
> ResourceParam/HierarchicalAllocator__BENCHMARK_WithResourceParam.UpdateAllocation/0
>  (3996 ms)
> [ RUN  ] 
> ResourceParam/HierarchicalAllocator__BENCHMARK_WithResourceParam.UpdateAllocation/1
> Agent resources size: 100 (100 roles, 1 reservations per role, 1 ranges per 
> port resource)
> 20 RESERVE operations took 10.094084426secs, each takes 504.704221ms
> 20 UNRESERVE operations took 10.293614069secs, each takes 514.680703ms
> [   OK ] 
> ResourceParam/HierarchicalAllocator__BENCHMARK_WithResourceParam.UpdateAllocation/1
>  (20584 ms)
> [ RUN  ] 
> ResourceParam/HierarchicalAllocator__BENCHMARK_WithResourceParam.UpdateAllocation/2
> Agent resources size: 200 (200 roles, 1 reservations per role, 1 ranges per 
> port resource)
> 20 RESERVE operations took 1.1601870593mins, each takes 3.480561178secs
> 20 UNRESERVE operations took 1.17209781845mins, each takes 3.516293455secs
> [   OK ] 
> ResourceParam/HierarchicalAllocator__BENCHMARK_WithResourceParam.UpdateAllocation/2
>  (141363 ms)
> ```
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>



Re: Review Request 71641: Garbage-collected lost tasks which are reported as running again.

2019-10-28 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71641/#review218430
---



Patch looks great!

Reviews applied: [71641]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Oct. 28, 2019, 10:53 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71641/
> ---
> 
> (Updated Oct. 28, 2019, 10:53 a.m.)
> 
> 
> Review request for mesos, Benno Evers, Benjamin Mahler, and Greg Mann.
> 
> 
> Bugs: MESOS-10018
> https://issues.apache.org/jira/browse/MESOS-10018
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Under certain conditions tasks which were previously `TASK_LOST` and
> completed can reappear in non-terminal states, e.g., if the agent on
> which they where running reconnect.
> 
> This patch adds garbage collection of such completed tasks so that users
> do not see tasks twice when obtaining task information from the master
> API. This change does not affect tasks status updates where we already
> correctly reported a previously `TASK_LOST` state as superseded by e.g.,
> `TASK_RUNNING`.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 351823e69f14dbb5eb1ea2b108c42e93722f1eff 
>   src/tests/master_tests.cpp 5486e23ce146eda9191e081a48c1f3fcb52a7569 
> 
> 
> Diff: https://reviews.apache.org/r/71641/diff/3/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 71641: Garbage-collected lost tasks which are reported as running again.

2019-10-28 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71641/#review218426
---



Bad patch!

Reviews applied: [71641]

Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:14.04' 
BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose 
--disable-libtool-wrappers --disable-parallel-test-execution' 
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh 2>&1 | tee 
build_71641"]

Error:
..
KAGE_VERSION=\"1.10.0\" -DPACKAGE_STRING=\"mesos\ 1.10.0\" 
-DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"mesos\" 
-DVERSION=\"1.10.0\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 
-DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 
-DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 
-DLT_OBJDIR=\".libs/\" -DHAVE_CXX11=1 -DHAVE_PTHREAD_PRIO_INHERIT=1 
-DHAVE_PTHREAD=1 -DHAVE_OPENSSL_SSL_H=1 -DHAVE_FTS_H=1 -DHAVE_APR_POOLS_H=1 
-DHAVE_LIBAPR_1=1 -DHAVE_LIBCURL=1 -DMESOS_HAS_JAVA=1 -DHAVE_LIBSASL2=1 
-DHAVE_SVN_VERSION_H=1 -DHAVE_LIBSVN_SUBR_1=1 -DHAVE_SVN_DELTA_H=1 
-DHAVE_LIBSVN_DELTA_1=1 -DHAVE_ZLIB_H=1 -DHAVE_LIBZ=1 -DHAVE_PYTHON=\"2.7\" 
-DMESOS_HAS_PYTHON=1 -I. -I../../src   -Werror 
-DLIBDIR=\"/mesos/mesos-1.10.0/_inst/lib\" 
-DPKGLIBEXECDIR=\"/mesos/mesos-1.10.0/_inst/libexec/mesos\" 
-DPKGDATADIR=\"/mesos/mesos-1.10.0/_inst/share/mesos\" 
-DPKGMODULEDIR=\"/mesos/mesos-1.10.0/_inst/lib/mesos/modules\" -I../../include 
-I../in
 clude -I../include/mesos -D__STDC_FORMAT_MACROS -I../3rdparty/boost-1.65.0 
-I../3rdparty/concurrentqueue-7b69a8f -I../3rdparty/elfio-3.2 
-I../3rdparty/glog-0.4.0/src -I../3rdparty/grpc-1.10.0/include 
-I../3rdparty/leveldb-1.19/include -I../3rdparty/libarchive-3.3.2/libarchive/ 
-I../../3rdparty/libprocess/include  -I../3rdparty/nvml-352.79 
-I../3rdparty/picojson-1.3.0 -I../3rdparty/protobuf-3.5.0/src 
-I../3rdparty/rapidjson-1.1.0/include -I../../3rdparty/stout/include 
-I../3rdparty/zookeeper-3.4.8/src/c/include 
-I../3rdparty/zookeeper-3.4.8/src/c/generated 
-DSOURCE_DIR=\"/mesos/mesos-1.10.0/_build/..\" 
-DBUILD_DIR=\"/mesos/mesos-1.10.0/_build\" 
-I../3rdparty/googletest-release-1.8.0/googletest/include 
-I../3rdparty/googletest-release-1.8.0/googlemock/include 
-DTESTLIBEXECDIR=\"/mesos/mesos-1.10.0/_inst/libexec/mesos/tests\" 
-DSBINDIR=\"/mesos/mesos-1.10.0/_inst/sbin\" 
-I/usr/lib/jvm/java-7-openjdk-amd64/include 
-I/usr/lib/jvm/java-7-openjdk-amd64/include/linux -DZOOKEEPER_VERSION=\"3
 .4.8\" -I/usr/include/subversion-1 -I/usr/include/apr-1 -I/usr/include/apr-1.0 
   -pthread -Wall -Wsign-compare -Wformat-security -fstack-protector -fPIC 
-fPIE -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -c -o 
tests/mesos_tests-default_executor_tests.o `test -f 
'tests/default_executor_tests.cpp' || echo 
'../../src/'`tests/default_executor_tests.cpp
g++ -DPACKAGE_NAME=\"mesos\" -DPACKAGE_TARNAME=\"mesos\" 
-DPACKAGE_VERSION=\"1.10.0\" -DPACKAGE_STRING=\"mesos\ 1.10.0\" 
-DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"mesos\" 
-DVERSION=\"1.10.0\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 
-DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 
-DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 
-DLT_OBJDIR=\".libs/\" -DHAVE_CXX11=1 -DHAVE_PTHREAD_PRIO_INHERIT=1 
-DHAVE_PTHREAD=1 -DHAVE_OPENSSL_SSL_H=1 -DHAVE_FTS_H=1 -DHAVE_APR_POOLS_H=1 
-DHAVE_LIBAPR_1=1 -DHAVE_LIBCURL=1 -DMESOS_HAS_JAVA=1 -DHAVE_LIBSASL2=1 
-DHAVE_SVN_VERSION_H=1 -DHAVE_LIBSVN_SUBR_1=1 -DHAVE_SVN_DELTA_H=1 
-DHAVE_LIBSVN_DELTA_1=1 -DHAVE_ZLIB_H=1 -DHAVE_LIBZ=1 -DHAVE_PYTHON=\"2.7\" 
-DMESOS_HAS_PYTHON=1 -I. -I../../src   -Werror 
-DLIBDIR=\"/mesos/mesos-1.10.0/_inst/lib\" 
-DPKGLIBEXECDIR=\"/mesos/mesos-1.10.0/_inst/libexec/mesos\" 
-DPKGDATADIR=\"/mesos/mesos-1.10.0/_inst/share/mesos\" -DPKGMODULEDIR=\"/mesos/
 mesos-1.10.0/_inst/lib/mesos/modules\" -I../../include -I../include 
-I../include/mesos -D__STDC_FORMAT_MACROS -I../3rdparty/boost-1.65.0 
-I../3rdparty/concurrentqueue-7b69a8f -I../3rdparty/elfio-3.2 
-I../3rdparty/glog-0.4.0/src -I../3rdparty/grpc-1.10.0/include 
-I../3rdparty/leveldb-1.19/include -I../3rdparty/libarchive-3.3.2/libarchive/ 
-I../../3rdparty/libprocess/include  -I../3rdparty/nvml-352.79 
-I../3rdparty/picojson-1.3.0 -I../3rdparty/protobuf-3.5.0/src 
-I../3rdparty/rapidjson-1.1.0/include -I../../3rdparty/stout/include 
-I../3rdparty/zookeeper-3.4.8/src/c/include 
-I../3rdparty/zookeeper-3.4.8/src/c/generated 
-DSOURCE_DIR=\"/mesos/mesos-1.10.0/_build/..\" 
-DBUILD_DIR=\"/mesos/mesos-1.10.0/_build\" 
-I../3rdparty/googletest-release-1.8.0/googletest/include 
-I../3rdparty/googletest-release-1.8.0/googlemock/include 
-DTESTLIBEXECDIR=\"/mesos/mesos-1.10.0/_inst/libexec/mesos/tests\" 
-DSBINDIR=\"/mesos/mesos-1.10.0/_inst/sbin\" 
-I/usr/lib/jvm/java-7-openjdk-amd64/include -I/usr/lib/

Re: Review Request 71673: Got rid of storing totals in the random sorter.

2019-10-24 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71673/#review218402
---



Patch looks great!

Reviews applied: [71646, 71672, 71673]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Oct. 24, 2019, 5:07 p.m., Andrei Sekretenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71673/
> ---
> 
> (Updated Oct. 24, 2019, 5:07 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Meng Zhu.
> 
> 
> Bugs: MESOS-10015
> https://issues.apache.org/jira/browse/MESOS-10015
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Got rid of storing totals in the random sorter.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> 9d0fbe771868ea60e66b9e25b0c666d5416d6e85 
>   src/master/allocator/mesos/hierarchical.cpp 
> 21010de363f25c516bb031e4ae4e53621128 
>   src/master/allocator/mesos/sorter/drf/sorter.hpp 
> 3f6c7413f1b76f3fa86388360983763c8b76079f 
>   src/master/allocator/mesos/sorter/drf/sorter.cpp 
> ef79083b710fba628b4a7e93f903883899f8a71b 
>   src/master/allocator/mesos/sorter/random/sorter.hpp 
> a3097be98d175d2b47714eb8b70b1ce8c5c2bba8 
>   src/master/allocator/mesos/sorter/random/sorter.cpp 
> 86aeb1b8136eaffd2d52d3b603636b01383a9024 
>   src/master/allocator/mesos/sorter/sorter.hpp 
> 6b6b4a1811ba36e0212de17b9a6e63a6f8678a7f 
> 
> 
> Diff: https://reviews.apache.org/r/71673/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>



Re: Review Request 71639: Added an benchmark for `allocator->UpdateAllocation()`.

2019-10-24 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71639/#review218383
---



Bad patch!

Reviews applied: [71639]

Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:14.04' 
BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose 
--disable-libtool-wrappers --disable-parallel-test-execution' 
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh 2>&1 | tee 
build_71639"]

Error:
..
/default-role):2; mem(allocated: storage/default-role):1024; disk(allocated: 
storage/default-role):1024 (total: cpus:2; mem:1024; disk:1024; 
ports:[31000-32000]; disk(reservations: 
[(DYNAMIC,storage),(DYNAMIC,storage/default-role,test-principal)])[MOUNT(org.apache.mesos.csi.test.local,/tmp/CSIVersion_StorageLocalResourceProviderTest_OperatorOperationsWithResourceProviderResources_v1_dGZkrA/2GB-7b4808f0-dd6c-4f19-a568-f6eb7e4d498d,test)]:2048,
 offered or allocated: {}) on agent 7c8d3337-ae4c-4b18-ae78-f8c28690dd61-S0 
from framework 7c8d3337-ae4c-4b18-ae78-f8c28690dd61-
I1024 09:26:53.782852 18659 master.cpp:12706] Removing offer 
7c8d3337-ae4c-4b18-ae78-f8c28690dd61-O3
I1024 09:26:53.784651 18648 hierarchical.cpp:1615] Framework 
7c8d3337-ae4c-4b18-ae78-f8c28690dd61- filtered agent 
7c8d3337-ae4c-4b18-ae78-f8c28690dd61-S0 for 5secs
I1024 09:26:53.787737 18652 master.cpp:12571] Sending operation '' (uuid: 
0275ef53-2c46-4698-bf17-4746f9d0cec0) to agent 
7c8d3337-ae4c-4b18-ae78-f8c28690dd61-S0 at slave(1247)@172.17.0.3:34124 
(4208d5688280)
I1024 09:26:53.788321 18669 slave.cpp:4352] Ignoring new checkpointed resources 
and operations identical to the current version
I1024 09:26:53.791106 18670 provider.cpp:498] Received APPLY_OPERATION event
I1024 09:26:53.791158 18670 provider.cpp:1351] Received CREATE operation '' 
(uuid: 0275ef53-2c46-4698-bf17-4746f9d0cec0)
I1024 09:26:53.795826 18661 master.cpp:6412] Processing REVIVE call for 
framework 7c8d3337-ae4c-4b18-ae78-f8c28690dd61- (default) at 
scheduler-0032e2bc-1cba-4d8e-8c13-8a319b903637@172.17.0.3:34124
I1024 09:26:53.796336 18660 hierarchical.cpp:1711] Unsuppressed offers and 
cleared filters for roles { storage/default-role } of framework 
7c8d3337-ae4c-4b18-ae78-f8c28690dd61-
I1024 09:26:53.797616 18660 hierarchical.cpp:1843] Performed allocation for 1 
agents in 1.08604ms
I1024 09:26:53.798040 18660 hierarchical.cpp:1843] Performed allocation for 1 
agents in 198699ns
I1024 09:26:53.798362 18659 master.cpp:10409] Sending offers [ 
7c8d3337-ae4c-4b18-ae78-f8c28690dd61-O4 ] to framework 
7c8d3337-ae4c-4b18-ae78-f8c28690dd61- (default) at 
scheduler-0032e2bc-1cba-4d8e-8c13-8a319b903637@172.17.0.3:34124
I1024 09:26:53.799041 18664 sched.cpp:934] Scheduler::resourceOffers took 
90724ns
I1024 09:26:53.809813 18663 http.cpp:1115] HTTP POST for 
/slave(1247)/api/v1/resource_provider from 172.17.0.3:40906
I1024 09:26:53.810912 18669 slave.cpp:8483] Handling resource provider message 
'UPDATE_OPERATION_STATUS: (uuid: fdb16b44-2e73-498d-a925-cee7d7192d72) for 
framework  (latest state: OPERATION_FINISHED, status update state: 
OPERATION_FINISHED)'
I1024 09:26:53.811089 18669 slave.cpp:8936] Updating the state of operation 
with no ID (uuid: fdb16b44-2e73-498d-a925-cee7d7192d72) for an operation API 
call (latest state: OPERATION_FINISHED, status update state: OPERATION_FINISHED)
I1024 09:26:53.811136 18669 slave.cpp:8690] Forwarding status update of 
operation with no ID (operation_uuid: fdb16b44-2e73-498d-a925-cee7d7192d72) for 
an operator API call
I1024 09:26:53.811465 18654 master.cpp:12223] Updating the state of operation 
'' (uuid: fdb16b44-2e73-498d-a925-cee7d7192d72) for an operator API call 
(latest state: OPERATION_PENDING, status update state: OPERATION_FINISHED)
I1024 09:26:53.812021 18657 slave.cpp:4352] Ignoring new checkpointed resources 
and operations identical to the current version
I1024 09:26:53.888097 18664 status_update_manager_process.hpp:152] Received 
operation status update OPERATION_FINISHED (Status UUID: 
6e7ad38b-1d89-4ca0-8e77-0506cac3e8c9) for operation UUID 
0275ef53-2c46-4698-bf17-4746f9d0cec0 on agent 
7c8d3337-ae4c-4b18-ae78-f8c28690dd61-S0
I1024 09:26:53.888248 18664 status_update_manager_process.hpp:414] Creating 
operation status update stream 0275ef53-2c46-4698-bf17-4746f9d0cec0 
checkpoint=true
I1024 09:26:53.888347 18670 provider.cpp:498] Received 
ACKNOWLEDGE_OPERATION_STATUS event
I1024 09:26:53.06 18664 status_update_manager_process.hpp:929] 
Checkpointing UPDATE for operation status update OPERATION_FINISHED (Status 
UUID: 6e7ad38b-1d89-4ca0-8e77-0506cac3e8c9) for operation UUID 
0275ef53-2c46-4698-bf17-4746f9d0cec0 on agent 
7c8d3337-ae4c-4b18-ae78-f8c28690dd61-S0
I1024 09:26:53.938164 18664 status_update_manager_process.hpp:528] Forwarding 
operation status update OPERATION_FINISHED (Status UUID: 

Re: Review Request 71666: WIP: SSL Wrapper: Implemented send/recv and shutdown.

2019-10-23 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71666/#review218381
---



Bad patch!

Reviews applied: [71659, 71660, 71661, 71662, 71663, 71664, 71665, 71666]

Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:14.04' 
BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose 
--disable-libtool-wrappers --disable-parallel-test-execution' 
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh 2>&1 | tee 
build_71666"]

Error:
..
incipal","role":"storage/default-role","type":"DYNAMIC"}],"scalar":{"value":2048.0},"type":"SCALAR"}]'
I1024 04:09:16.837707 18970 sched.cpp:960] Rescinded offer 
4e513900-c18f-44fd-b61e-94980d41083c-O3
I1024 04:09:16.837848 18970 sched.cpp:971] Scheduler::offerRescinded took 
43513ns
I1024 04:09:16.838539 18964 hierarchical.cpp:1566] Recovered ports(allocated: 
storage/default-role):[31000-32000]; disk(allocated: 
storage/default-role)(reservations: 
[(DYNAMIC,storage),(DYNAMIC,storage/default-role,test-principal)])[MOUNT(org.apache.mesos.csi.test.local,/tmp/CSIVersion_StorageLocalResourceProviderTest_OperatorOperationsWithResourceProviderResources_v1_9tOuB1/2GB-8ec4d43b-5633-47b6-85bd-6e180958bc84,test)]:2048;
 cpus(allocated: storage/default-role):2; mem(allocated: 
storage/default-role):1024; disk(allocated: storage/default-role):1024 (total: 
cpus:2; mem:1024; disk:1024; ports:[31000-32000]; disk(reservations: 
[(DYNAMIC,storage),(DYNAMIC,storage/default-role,test-principal)])[MOUNT(org.apache.mesos.csi.test.local,/tmp/CSIVersion_StorageLocalResourceProviderTest_OperatorOperationsWithResourceProviderResources_v1_9tOuB1/2GB-8ec4d43b-5633-47b6-85bd-6e180958bc84,test)]:2048,
 offered or allocated: {}) on agent 4e513900-c18f-44fd-b61e-94980d41083c-S0 
from framework 4e513
 900-c18f-44fd-b61e-94980d41083c-
I1024 04:09:16.838770 18959 master.cpp:12706] Removing offer 
4e513900-c18f-44fd-b61e-94980d41083c-O3
I1024 04:09:16.840548 18964 hierarchical.cpp:1615] Framework 
4e513900-c18f-44fd-b61e-94980d41083c- filtered agent 
4e513900-c18f-44fd-b61e-94980d41083c-S0 for 5secs
I1024 04:09:16.844607 18958 master.cpp:12571] Sending operation '' (uuid: 
431a5832-b5dc-4070-8864-e5905e28b81e) to agent 
4e513900-c18f-44fd-b61e-94980d41083c-S0 at slave(1245)@172.17.0.2:42005 
(af3ba927af2a)
I1024 04:09:16.845479 18958 slave.cpp:4352] Ignoring new checkpointed resources 
and operations identical to the current version
I1024 04:09:16.848281 18963 master.cpp:6412] Processing REVIVE call for 
framework 4e513900-c18f-44fd-b61e-94980d41083c- (default) at 
scheduler-fae671da-508d-496e-9b21-5f0e8463bce6@172.17.0.2:42005
I1024 04:09:16.849131 18960 hierarchical.cpp:1711] Unsuppressed offers and 
cleared filters for roles { storage/default-role } of framework 
4e513900-c18f-44fd-b61e-94980d41083c-
I1024 04:09:16.849989 18969 provider.cpp:498] Received APPLY_OPERATION event
I1024 04:09:16.850067 18969 provider.cpp:1351] Received CREATE operation '' 
(uuid: 431a5832-b5dc-4070-8864-e5905e28b81e)
I1024 04:09:16.851294 18960 hierarchical.cpp:1843] Performed allocation for 1 
agents in 1.70449ms
I1024 04:09:16.852298 18959 master.cpp:10409] Sending offers [ 
4e513900-c18f-44fd-b61e-94980d41083c-O4 ] to framework 
4e513900-c18f-44fd-b61e-94980d41083c- (default) at 
scheduler-fae671da-508d-496e-9b21-5f0e8463bce6@172.17.0.2:42005
I1024 04:09:16.852977 18965 sched.cpp:934] Scheduler::resourceOffers took 
71323ns
I1024 04:09:16.863402 18955 http.cpp:1115] HTTP POST for 
/slave(1245)/api/v1/resource_provider from 172.17.0.2:36920
I1024 04:09:16.865109 18953 slave.cpp:8483] Handling resource provider message 
'UPDATE_OPERATION_STATUS: (uuid: e7bbe480-05f9-4f0e-9b53-7d2bb48e9a73) for 
framework  (latest state: OPERATION_FINISHED, status update state: 
OPERATION_FINISHED)'
I1024 04:09:16.865459 18953 slave.cpp:8936] Updating the state of operation 
with no ID (uuid: e7bbe480-05f9-4f0e-9b53-7d2bb48e9a73) for an operation API 
call (latest state: OPERATION_FINISHED, status update state: OPERATION_FINISHED)
I1024 04:09:16.865547 18953 slave.cpp:8690] Forwarding status update of 
operation with no ID (operation_uuid: e7bbe480-05f9-4f0e-9b53-7d2bb48e9a73) for 
an operator API call
I1024 04:09:16.866223 18972 master.cpp:12223] Updating the state of operation 
'' (uuid: e7bbe480-05f9-4f0e-9b53-7d2bb48e9a73) for an operator API call 
(latest state: OPERATION_PENDING, status update state: OPERATION_FINISHED)
I1024 04:09:16.867074 18968 slave.cpp:4352] Ignoring new checkpointed resources 
and operations identical to the current version
I1024 04:09:16.950788 18959 status_update_manager_process.hpp:152] Received 
operation status update OPERATION_FINISHED (Status UUID: 
a12dedde-ff62-4851-ab61-9768f77a0a3d) for operation UUID 
431a5832-b5dc-4070-8864-e5905e28b81e on agent 
4e513900-c18f-44fd-b61e-94980d41083c-S0
I1024 

Re: Review Request 71663: SSL Wrapper: Windows: Made sure windows.hpp is included before OpenSSL.

2019-10-23 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71663/#review218370
---



Bad review!

Reviews applied: [71663, 71662, 71661, 71660, 71659]

Error:
2019-10-23 21:03:24 URL:https://reviews.apache.org/r/71663/diff/raw/ 
[3198/3198] -> "71663.patch" [1]
error: patch failed: 3rdparty/libprocess/src/openssl.cpp:18
error: 3rdparty/libprocess/src/openssl.cpp: patch does not apply

- Mesos Reviewbot


On Oct. 23, 2019, 7:37 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71663/
> ---
> 
> (Updated Oct. 23, 2019, 7:37 p.m.)
> 
> 
> Review request for mesos, Benno Evers, Benjamin Mahler, Greg Mann, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-10009
> https://issues.apache.org/jira/browse/MESOS-10009
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Depending on the version of OpenSSL and what headers of OpenSSL
> are included, the order of certain Windows headers may be included
> in the "wrong" order.  This results in hundreds of cryptic syntax
> errors from MSVC.
> 
> This sweeps through the existing sites with OpenSSL headers and
> makes sure to include the Windows headers above them.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/jwt.hpp 
> 62bf5c2ac3fcb6b76c88cd691d001358a4cb0aa6 
>   3rdparty/libprocess/include/process/ssl/gtest.hpp 
> 4a14a8ef7937e8c6adf3a78db3e9558333700a1b 
>   3rdparty/libprocess/include/process/ssl/tls_config.hpp 
> 18c51a8baabf07143c7892dbee0ad2d856457d8d 
>   3rdparty/libprocess/src/openssl.cpp 
> bd05866950e1043d9585a7c5fdc7b2147a233fd3 
>   3rdparty/libprocess/src/ssl/utilities.cpp 
> c4a8ab4f83939554ca3eb7b4eb86c42c8a539b48 
> 
> 
> Diff: https://reviews.apache.org/r/71663/diff/1/
> 
> 
> Testing
> ---
> 
> cmake --build . (Windows)
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>



Re: Review Request 71652: Avoid double reaping race in the command executor.

2019-10-23 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71652/#review218351
---



Bad patch!

Reviews applied: [71652]

Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:14.04' 
BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose 
--disable-libtool-wrappers --disable-parallel-test-execution' 
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh 2>&1 | tee 
build_71652"]

Error:
..
24; ports:[31000-32000]; disk(reservations: 
[(DYNAMIC,storage),(DYNAMIC,storage/default-role,test-principal)])[MOUNT(org.apache.mesos.csi.test.local,/tmp/CSIVersion_StorageLocalResourceProviderTest_OperatorOperationsWithResourceProviderResources_v1_iXVDxw/2GB-31d22435-1c20-4b95-a133-7ab0f68239d1,test)]:2048,
 offered or allocated: {}) on agent 8b74f172-6660-452a-b8f4-44d69129bd0c-S0 
from framework 8b74f172-6660-452a-b8f4-44d69129bd0c-
I1023 07:58:46.228407 18972 master.cpp:12706] Removing offer 
8b74f172-6660-452a-b8f4-44d69129bd0c-O3
I1023 07:58:46.230870 18970 hierarchical.cpp:1615] Framework 
8b74f172-6660-452a-b8f4-44d69129bd0c- filtered agent 
8b74f172-6660-452a-b8f4-44d69129bd0c-S0 for 5secs
I1023 07:58:46.233952 18966 master.cpp:12571] Sending operation '' (uuid: 
4cfdc6ca-5cc7-4191-b168-c57673c55e81) to agent 
8b74f172-6660-452a-b8f4-44d69129bd0c-S0 at slave(1249)@172.17.0.2:38971 
(4574622b6dd8)
I1023 07:58:46.234721 18978 slave.cpp:4352] Ignoring new checkpointed resources 
and operations identical to the current version
I1023 07:58:46.237903 18958 master.cpp:6412] Processing REVIVE call for 
framework 8b74f172-6660-452a-b8f4-44d69129bd0c- (default) at 
scheduler-4e29bb53-3c92-4102-a204-eb032bb2529a@172.17.0.2:38971
I1023 07:58:46.238562 18975 hierarchical.cpp:1711] Unsuppressed offers and 
cleared filters for roles { storage/default-role } of framework 
8b74f172-6660-452a-b8f4-44d69129bd0c-
I1023 07:58:46.239331 18963 provider.cpp:498] Received APPLY_OPERATION event
I1023 07:58:46.239405 18963 provider.cpp:1351] Received CREATE operation '' 
(uuid: 4cfdc6ca-5cc7-4191-b168-c57673c55e81)
I1023 07:58:46.240499 18975 hierarchical.cpp:1843] Performed allocation for 1 
agents in 1.615303ms
I1023 07:58:46.24 18975 hierarchical.cpp:1843] Performed allocation for 1 
agents in 255828ns
I1023 07:58:46.241899 18974 master.cpp:10409] Sending offers [ 
8b74f172-6660-452a-b8f4-44d69129bd0c-O4 ] to framework 
8b74f172-6660-452a-b8f4-44d69129bd0c- (default) at 
scheduler-4e29bb53-3c92-4102-a204-eb032bb2529a@172.17.0.2:38971
I1023 07:58:46.242486 18972 sched.cpp:934] Scheduler::resourceOffers took 
74004ns
I1023 07:58:46.253813 18957 http.cpp:1115] HTTP POST for 
/slave(1249)/api/v1/resource_provider from 172.17.0.2:35270
I1023 07:58:46.255318 18968 slave.cpp:8483] Handling resource provider message 
'UPDATE_OPERATION_STATUS: (uuid: 9eac9abd-2697-47f4-a5c2-a46fffa0deed) for 
framework  (latest state: OPERATION_FINISHED, status update state: 
OPERATION_FINISHED)'
I1023 07:58:46.255730 18968 slave.cpp:8936] Updating the state of operation 
with no ID (uuid: 9eac9abd-2697-47f4-a5c2-a46fffa0deed) for an operation API 
call (latest state: OPERATION_FINISHED, status update state: OPERATION_FINISHED)
I1023 07:58:46.255831 18968 slave.cpp:8690] Forwarding status update of 
operation with no ID (operation_uuid: 9eac9abd-2697-47f4-a5c2-a46fffa0deed) for 
an operator API call
I1023 07:58:46.256301 18962 master.cpp:12223] Updating the state of operation 
'' (uuid: 9eac9abd-2697-47f4-a5c2-a46fffa0deed) for an operator API call 
(latest state: OPERATION_PENDING, status update state: OPERATION_FINISHED)
I1023 07:58:46.257138 18976 slave.cpp:4352] Ignoring new checkpointed resources 
and operations identical to the current version
I1023 07:58:46.334250 18972 status_update_manager_process.hpp:152] Received 
operation status update OPERATION_FINISHED (Status UUID: 
9bdddc3b-fb07-46d6-b924-212ab36ef6c6) for operation UUID 
4cfdc6ca-5cc7-4191-b168-c57673c55e81 on agent 
8b74f172-6660-452a-b8f4-44d69129bd0c-S0
I1023 07:58:46.334384 18972 status_update_manager_process.hpp:414] Creating 
operation status update stream 4cfdc6ca-5cc7-4191-b168-c57673c55e81 
checkpoint=true
I1023 07:58:46.334528 18963 provider.cpp:498] Received 
ACKNOWLEDGE_OPERATION_STATUS event
I1023 07:58:46.334925 18972 status_update_manager_process.hpp:929] 
Checkpointing UPDATE for operation status update OPERATION_FINISHED (Status 
UUID: 9bdddc3b-fb07-46d6-b924-212ab36ef6c6) for operation UUID 
4cfdc6ca-5cc7-4191-b168-c57673c55e81 on agent 
8b74f172-6660-452a-b8f4-44d69129bd0c-S0
I1023 07:58:46.409291 18972 status_update_manager_process.hpp:528] Forwarding 
operation status update OPERATION_FINISHED (Status UUID: 
9bdddc3b-fb07-46d6-b924-212ab36ef6c6) for operation UUID 
4cfdc6ca-5cc7-4191-b168-c57673c55e81 on agent 
8b74f172-6660-452a-b8f4-44d69129bd0c-S0
I1023 

Re: Review Request 71646: Modified Sorter interface to add/remove an agent as a whole.

2019-10-22 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71646/#review218330
---



Patch looks great!

Reviews applied: [71646]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Oct. 22, 2019, 1:41 p.m., Andrei Sekretenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71646/
> ---
> 
> (Updated Oct. 22, 2019, 1:41 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Meng Zhu.
> 
> 
> Bugs: MESOS-10015
> https://issues.apache.org/jira/browse/MESOS-10015
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch replaces Sorter methods which modify `Resources` of an agent
> in the Sorter with methods which add/remove an agent as a whole
> (which was actually the only use case of the old methods).
> 
> Thus, subtracting/adding `Resources` of the whole agent no longer
> occurs when updating resources of the agent in the Sorter. This
> mitigates the issue with poor performance of
> `HierarchicalAllocatorProcess::updateAllocation()` for agents with
> a huge number of non-addable resources (see MESOS-10015).
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> 21010de363f25c516bb031e4ae4e53621128 
>   src/master/allocator/mesos/sorter/drf/sorter.hpp 
> 3f6c7413f1b76f3fa86388360983763c8b76079f 
>   src/master/allocator/mesos/sorter/drf/sorter.cpp 
> ef79083b710fba628b4a7e93f903883899f8a71b 
>   src/master/allocator/mesos/sorter/random/sorter.hpp 
> a3097be98d175d2b47714eb8b70b1ce8c5c2bba8 
>   src/master/allocator/mesos/sorter/random/sorter.cpp 
> 86aeb1b8136eaffd2d52d3b603636b01383a9024 
>   src/master/allocator/mesos/sorter/sorter.hpp 
> 6b6b4a1811ba36e0212de17b9a6e63a6f8678a7f 
>   src/tests/sorter_tests.cpp d7fdee8f2cab4c930230750f0bd1a55eb08f89bb 
> 
> 
> Diff: https://reviews.apache.org/r/71646/diff/1/
> 
> 
> Testing
> ---
> 
> **make check**
> 
> **Variant of 
> `ReservationParam/HierarchicalAllocator__BENCHMARK_WithReservationParam`**
> from https://reviews.apache.org/r/71639/ (work in progress) 
> shows significant improvement and change from O(number_of_roles^3) to 
> O(number_of_roles^2):
> **Before**:
> Agent resources size: 200 (50 roles, 1 reservations per role, 1 port ranges)
> Made 20 reserve and unreserve operations in 2.08586secs
> Average UNRESERVE duration: 51.491561ms
> Average RESERVE duration: 52.801438ms
> 
> Agent resources size: 400 (100 roles, 1 reservations per role, 1 port ranges)
> Made 20 reserve and unreserve operations in 13.8449005secs
> Average UNRESERVE duration: 347.624639ms
> Average RESERVE duration: 344.620385ms
> 
> Agent resources size: 800 (200 roles, 1 reservations per role, 1 port ranges)
> Made 20 reserve and unreserve operations in 2.19253121188333mins
> Average UNRESERVE duration: 3.285422441secs
> Average RESERVE duration: 3.292171194secs
> 
> Agent resources size: 1600 (400 roles, 1 reservations per role, 1 port ranges)
> (killed after several minutes)
> 
> **After:**
> 
> Agent resources size: 200 (50 roles, 1 reservations per role, 1 port ranges)
> Made 20 reserve and unreserve operations in 559.381603ms
> Average UNRESERVE duration: 14.221942ms
> Average RESERVE duration: 13.747137ms
> 
> Agent resources size: 400 (100 roles, 1 reservations per role, 1 port ranges)
> Made 20 reserve and unreserve operations in 1.186726648secs
> Average UNRESERVE duration: 29.569935ms
> Average RESERVE duration: 29.766396ms
> 
> Agent resources size: 800 (200 roles, 1 reservations per role, 1 port ranges)
> Made 20 reserve and unreserve operations in 3.269639813secs
> Average UNRESERVE duration: 82.652908ms
> Average RESERVE duration: 80.829081ms
> 
> Agent resources size: 1600 (400 roles, 1 reservations per role, 1 port ranges)
> Made 20 reserve and unreserve operations in 11.156949417secs
> Average UNRESERVE duration: 278.158063ms
> Average RESERVE duration: 279.689407ms
> 
> Agent resources size: 3200 (800 roles, 1 reservations per role, 1 port ranges)
> Made 20 reserve and unreserve operations in 44.796308954secs
> Average UNRESERVE duration: 1.114141457secs
> Average RESERVE duration: 1.12567399secs
> 
> **No significant performnce changes in 
> `QuotaParam/BENCHM

Re: Review Request 71644: Added link to binary packages doc to the documentation landing doc.

2019-10-22 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71644/#review218318
---



Patch looks great!

Reviews applied: [71644]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Oct. 22, 2019, 9:16 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71644/
> ---
> 
> (Updated Oct. 22, 2019, 9:16 a.m.)
> 
> 
> Review request for mesos, Senthil Kumaran and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added link to binary packages doc to the documentation landing doc.
> 
> 
> Diffs
> -
> 
>   docs/home.md 4e62b4a5730011170d163d27ea0358e23e979d01 
> 
> 
> Diff: https://reviews.apache.org/r/71644/diff/1/
> 
> 
> Testing
> ---
> 
> inspected the rendered site
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 71643: Logged failed TLS reverse DNS lookups as warnings for 'legacy' scheme.

2019-10-21 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71643/#review218317
---



Bad patch!

Reviews applied: [71643]

Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:14.04' 
BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose 
--disable-libtool-wrappers --disable-parallel-test-execution' 
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh 2>&1 | tee 
build_71643"]

Error:
..
KAGE_URL=\"\" -DPACKAGE=\"mesos\" -DVERSION=\"1.10.0\" -DSTDC_HEADERS=1 
-DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 
-DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 
-DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_CXX11=1 
-DHAVE_PTHREAD_PRIO_INHERIT=1 -DHAVE_PTHREAD=1 -DHAVE_OPENSSL_SSL_H=1 
-DHAVE_FTS_H=1 -DHAVE_APR_POOLS_H=1 -DHAVE_LIBAPR_1=1 -DHAVE_LIBCURL=1 
-DMESOS_HAS_JAVA=1 -DHAVE_LIBSASL2=1 -DHAVE_SVN_VERSION_H=1 
-DHAVE_LIBSVN_SUBR_1=1 -DHAVE_SVN_DELTA_H=1 -DHAVE_LIBSVN_DELTA_1=1 
-DHAVE_ZLIB_H=1 -DHAVE_LIBZ=1 -DHAVE_PYTHON=\"2.7\" -DMESOS_HAS_PYTHON=1 -I. 
-I../../../3rdparty/libprocess 
-DBUILD_DIR=\"/mesos/mesos-1.10.0/_build/3rdparty/libprocess\" 
-I../../../3rdparty/libprocess/include -I../../../3rdparty/libprocess/src 
-I../boost-1.65.0 -I../concurrentqueue-7b69a8f -I../elfio-3.2 
-I../glog-0.4.0/src -I../grpc-1.10.0/include -I../http-parser-2.6.2 
-I../libev-4.22 -D__STDC_FORMAT_MACROS -I../picojson-1.3.
 0 -I../protobuf-3.5.0/src -I../rapidjson-1.1.0/include 
-I../../../3rdparty/libprocess/../stout/include -DLIBPROCESS_ALLOW_JEMALLOC 
-I/usr/include/subversion-1 -I/usr/include/apr-1 -I/usr/include/apr-1.0 -Wall 
-Wsign-compare -Wformat-security -fstack-protector -fPIC -g1 -O0 
-Wno-unused-local-typedefs -std=c++11 -c 
../../../3rdparty/libprocess/src/clock.cpp  -fPIC -DPIC -o 
src/.libs/libprocess_la-clock.o
libtool: compile:  g++ -DPACKAGE_NAME=\"mesos\" -DPACKAGE_TARNAME=\"mesos\" 
-DPACKAGE_VERSION=\"1.10.0\" "-DPACKAGE_STRING=\"mesos 1.10.0\"" 
-DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"mesos\" 
-DVERSION=\"1.10.0\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 
-DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 
-DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 
-DLT_OBJDIR=\".libs/\" -DHAVE_CXX11=1 -DHAVE_PTHREAD_PRIO_INHERIT=1 
-DHAVE_PTHREAD=1 -DHAVE_OPENSSL_SSL_H=1 -DHAVE_FTS_H=1 -DHAVE_APR_POOLS_H=1 
-DHAVE_LIBAPR_1=1 -DHAVE_LIBCURL=1 -DMESOS_HAS_JAVA=1 -DHAVE_LIBSASL2=1 
-DHAVE_SVN_VERSION_H=1 -DHAVE_LIBSVN_SUBR_1=1 -DHAVE_SVN_DELTA_H=1 
-DHAVE_LIBSVN_DELTA_1=1 -DHAVE_ZLIB_H=1 -DHAVE_LIBZ=1 -DHAVE_PYTHON=\"2.7\" 
-DMESOS_HAS_PYTHON=1 -I. -I../../../3rdparty/libprocess 
-DBUILD_DIR=\"/mesos/mesos-1.10.0/_build/3rdparty/libprocess\" 
-I../../../3rdparty/libprocess/include -I../../../3rdparty/libprocess/src 
-I../boost-1.65.
 0 -I../concurrentqueue-7b69a8f -I../elfio-3.2 -I../glog-0.4.0/src 
-I../grpc-1.10.0/include -I../http-parser-2.6.2 -I../libev-4.22 
-D__STDC_FORMAT_MACROS -I../picojson-1.3.0 -I../protobuf-3.5.0/src 
-I../rapidjson-1.1.0/include -I../../../3rdparty/libprocess/../stout/include 
-DLIBPROCESS_ALLOW_JEMALLOC -I/usr/include/subversion-1 -I/usr/include/apr-1 
-I/usr/include/apr-1.0 -Wall -Wsign-compare -Wformat-security -fstack-protector 
-fPIC -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -c 
../../../3rdparty/libprocess/src/authenticator.cpp  -fPIC -DPIC -o 
src/.libs/libprocess_la-authenticator.o
libtool: compile:  g++ -DPACKAGE_NAME=\"mesos\" -DPACKAGE_TARNAME=\"mesos\" 
-DPACKAGE_VERSION=\"1.10.0\" "-DPACKAGE_STRING=\"mesos 1.10.0\"" 
-DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"mesos\" 
-DVERSION=\"1.10.0\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 
-DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 
-DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 
-DLT_OBJDIR=\".libs/\" -DHAVE_CXX11=1 -DHAVE_PTHREAD_PRIO_INHERIT=1 
-DHAVE_PTHREAD=1 -DHAVE_OPENSSL_SSL_H=1 -DHAVE_FTS_H=1 -DHAVE_APR_POOLS_H=1 
-DHAVE_LIBAPR_1=1 -DHAVE_LIBCURL=1 -DMESOS_HAS_JAVA=1 -DHAVE_LIBSASL2=1 
-DHAVE_SVN_VERSION_H=1 -DHAVE_LIBSVN_SUBR_1=1 -DHAVE_SVN_DELTA_H=1 
-DHAVE_LIBSVN_DELTA_1=1 -DHAVE_ZLIB_H=1 -DHAVE_LIBZ=1 -DHAVE_PYTHON=\"2.7\" 
-DMESOS_HAS_PYTHON=1 -I. -I../../../3rdparty/libprocess 
-DBUILD_DIR=\"/mesos/mesos-1.10.0/_build/3rdparty/libprocess\" 
-I../../../3rdparty/libprocess/include -I../../../3rdparty/libprocess/src 
-I../boost-1.65.
 0 -I../concurrentqueue-7b69a8f -I../elfio-3.2 -I../glog-0.4.0/src 
-I../grpc-1.10.0/include -I../http-parser-2.6.2 -I../libev-4.22 
-D__STDC_FORMAT_MACROS -I../picojson-1.3.0 -I../protobuf-3.5.0/src 
-I../rapidjson-1.1.0/include -I../../../3rdparty/libprocess/../stout/include 
-DLIBPROCESS_ALLOW_JEMALLOC -I/usr/include/subversion-1 -I/usr/include/apr-1 

Re: Review Request 71641: Garbage-collected lost tasks which are reported as running again.

2019-10-21 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71641/#review218308
---



Bad patch!

Reviews applied: [71641]

Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:14.04' 
BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose 
--disable-libtool-wrappers --disable-parallel-test-execution' 
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh 2>&1 | tee 
build_71641"]

Error:
..
or_tests.cpp
g++ -DPACKAGE_NAME=\"mesos\" -DPACKAGE_TARNAME=\"mesos\" 
-DPACKAGE_VERSION=\"1.10.0\" -DPACKAGE_STRING=\"mesos\ 1.10.0\" 
-DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"mesos\" 
-DVERSION=\"1.10.0\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 
-DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 
-DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 
-DLT_OBJDIR=\".libs/\" -DHAVE_CXX11=1 -DHAVE_PTHREAD_PRIO_INHERIT=1 
-DHAVE_PTHREAD=1 -DHAVE_OPENSSL_SSL_H=1 -DHAVE_FTS_H=1 -DHAVE_APR_POOLS_H=1 
-DHAVE_LIBAPR_1=1 -DHAVE_LIBCURL=1 -DMESOS_HAS_JAVA=1 -DHAVE_LIBSASL2=1 
-DHAVE_SVN_VERSION_H=1 -DHAVE_LIBSVN_SUBR_1=1 -DHAVE_SVN_DELTA_H=1 
-DHAVE_LIBSVN_DELTA_1=1 -DHAVE_ZLIB_H=1 -DHAVE_LIBZ=1 -DHAVE_PYTHON=\"2.7\" 
-DMESOS_HAS_PYTHON=1 -I. -I../../src   -Werror 
-DLIBDIR=\"/mesos/mesos-1.10.0/_inst/lib\" 
-DPKGLIBEXECDIR=\"/mesos/mesos-1.10.0/_inst/libexec/mesos\" 
-DPKGDATADIR=\"/mesos/mesos-1.10.0/_inst/share/mesos\" -DPKGMODULEDIR=\"/mesos/
 mesos-1.10.0/_inst/lib/mesos/modules\" -I../../include -I../include 
-I../include/mesos -D__STDC_FORMAT_MACROS -I../3rdparty/boost-1.65.0 
-I../3rdparty/concurrentqueue-7b69a8f -I../3rdparty/elfio-3.2 
-I../3rdparty/glog-0.4.0/src -I../3rdparty/grpc-1.10.0/include 
-I../3rdparty/leveldb-1.19/include -I../3rdparty/libarchive-3.3.2/libarchive/ 
-I../../3rdparty/libprocess/include  -I../3rdparty/nvml-352.79 
-I../3rdparty/picojson-1.3.0 -I../3rdparty/protobuf-3.5.0/src 
-I../3rdparty/rapidjson-1.1.0/include -I../../3rdparty/stout/include 
-I../3rdparty/zookeeper-3.4.8/src/c/include 
-I../3rdparty/zookeeper-3.4.8/src/c/generated 
-DSOURCE_DIR=\"/mesos/mesos-1.10.0/_build/..\" 
-DBUILD_DIR=\"/mesos/mesos-1.10.0/_build\" 
-I../3rdparty/googletest-release-1.8.0/googletest/include 
-I../3rdparty/googletest-release-1.8.0/googlemock/include 
-DTESTLIBEXECDIR=\"/mesos/mesos-1.10.0/_inst/libexec/mesos/tests\" 
-DSBINDIR=\"/mesos/mesos-1.10.0/_inst/sbin\" 
-I/usr/lib/jvm/java-7-openjdk-amd64/include -I/usr/lib/
 jvm/java-7-openjdk-amd64/include/linux -DZOOKEEPER_VERSION=\"3.4.8\" 
-I/usr/include/subversion-1 -I/usr/include/apr-1 -I/usr/include/apr-1.0 
 -pthread -Wall -Wsign-compare -Wformat-security -fstack-protector -fPIC -fPIE 
-g1 -O0 -Wno-unused-local-typedefs -std=c++11 -c -o 
tests/mesos_tests-disk_quota_tests.o `test -f 'tests/disk_quota_tests.cpp' || 
echo '../../src/'`tests/disk_quota_tests.cpp
g++ -DPACKAGE_NAME=\"mesos\" -DPACKAGE_TARNAME=\"mesos\" 
-DPACKAGE_VERSION=\"1.10.0\" -DPACKAGE_STRING=\"mesos\ 1.10.0\" 
-DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"mesos\" 
-DVERSION=\"1.10.0\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 
-DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 
-DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 
-DLT_OBJDIR=\".libs/\" -DHAVE_CXX11=1 -DHAVE_PTHREAD_PRIO_INHERIT=1 
-DHAVE_PTHREAD=1 -DHAVE_OPENSSL_SSL_H=1 -DHAVE_FTS_H=1 -DHAVE_APR_POOLS_H=1 
-DHAVE_LIBAPR_1=1 -DHAVE_LIBCURL=1 -DMESOS_HAS_JAVA=1 -DHAVE_LIBSASL2=1 
-DHAVE_SVN_VERSION_H=1 -DHAVE_LIBSVN_SUBR_1=1 -DHAVE_SVN_DELTA_H=1 
-DHAVE_LIBSVN_DELTA_1=1 -DHAVE_ZLIB_H=1 -DHAVE_LIBZ=1 -DHAVE_PYTHON=\"2.7\" 
-DMESOS_HAS_PYTHON=1 -I. -I../../src   -Werror 
-DLIBDIR=\"/mesos/mesos-1.10.0/_inst/lib\" 
-DPKGLIBEXECDIR=\"/mesos/mesos-1.10.0/_inst/libexec/mesos\" 
-DPKGDATADIR=\"/mesos/mesos-1.10.0/_inst/share/mesos\" -DPKGMODULEDIR=\"/mesos/
 mesos-1.10.0/_inst/lib/mesos/modules\" -I../../include -I../include 
-I../include/mesos -D__STDC_FORMAT_MACROS -I../3rdparty/boost-1.65.0 
-I../3rdparty/concurrentqueue-7b69a8f -I../3rdparty/elfio-3.2 
-I../3rdparty/glog-0.4.0/src -I../3rdparty/grpc-1.10.0/include 
-I../3rdparty/leveldb-1.19/include -I../3rdparty/libarchive-3.3.2/libarchive/ 
-I../../3rdparty/libprocess/include  -I../3rdparty/nvml-352.79 
-I../3rdparty/picojson-1.3.0 -I../3rdparty/protobuf-3.5.0/src 
-I../3rdparty/rapidjson-1.1.0/include -I../../3rdparty/stout/include 
-I../3rdparty/zookeeper-3.4.8/src/c/include 
-I../3rdparty/zookeeper-3.4.8/src/c/generated 
-DSOURCE_DIR=\"/mesos/mesos-1.10.0/_build/..\" 
-DBUILD_DIR=\"/mesos/mesos-1.10.0/_build\" 
-I../3rdparty/googletest-release-1.8.0/googletest/include 
-I../3rdparty/googletest-release-1.8.0/googlemock/include 
-DTESTLIBEXECDIR=\"/mesos/mesos-1.10.0/_inst/libexec/mesos/tests\" 

Re: Review Request 71639: Work-in-progress: Added an benchmark for `UpdateAllocation` call.

2019-10-21 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71639/#review218301
---



Patch looks great!

Reviews applied: [71639]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Oct. 21, 2019, 5:41 a.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71639/
> ---
> 
> (Updated Oct. 21, 2019, 5:41 a.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Work-in-progress: Added an benchmark for `UpdateAllocation` call.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> 38fd19cee6409e4daa5bb0ab523e8e464cdcc9a5 
> 
> 
> Diff: https://reviews.apache.org/r/71639/diff/1/
> 
> 
> Testing
> ---
> 
> On 1.9.x branch:
> 
> A sample update log line:
> 
> ```
> I1020 22:33:58.575657 47739 hierarchical.cpp:1192] Updated allocation of 
> framework framework11 on agent agent1 from mem(allocated: 
> loop-daeftvzzfeogrinsuvkapzswaqojpxcuagzv)(reservations: 
> [(DYNAMIC,loop-daeftvzzfeogrinsuvkapzswaqojpxcuagzv,{Label: 
> bywhflpwveqpcdprcjoebepqcrkeyjzbkvkr})]):128; cpus(allocated: 
> loop-daeftvzzfeogrinsuvkapzswaqojpxcuagzv)(reservations: 
> [(DYNAMIC,loop-daeftvzzfeogrinsuvkapzswaqojpxcuagzv,{Label: 
> bywhflpwveqpcdprcjoebepqcrkeyjzbkvkr})]):1; disk(allocated: 
> loop-daeftvzzfeogrinsuvkapzswaqojpxcuagzv)(reservations: 
> [(DYNAMIC,loop-daeftvzzfeogrinsuvkapzswaqojpxcuagzv,{Label: 
> bywhflpwveqpcdprcjoebepqcrkeyjzbkvkr})]):128 to mem(allocated: 
> loop-daeftvzzfeogrinsuvkapzswaqojpxcuagzv):128; cpus(allocated: 
> loop-daeftvzzfeogrinsuvkapzswaqojpxcuagzv):1; disk(allocated: 
> loop-daeftvzzfeogrinsuvkapzswaqojpxcuagzv):128
> ```
> 
> ```
> Agent resources size: 40
> Made 20 reserve and unreserve operations in 235.456896ms
> Each reserve and unreserve pair operation takes 11.772844ms
> [   OK ] 
> ReservationParam/HierarchicalAllocator__BENCHMARK_WithReservationParam.UpdateAllocation/0
>  (243 ms)
> [ RUN  ] 
> ReservationParam/HierarchicalAllocator__BENCHMARK_WithReservationParam.UpdateAllocation/1
> Agent resources size: 40
> Made 20 reserve and unreserve operations in 118.172514ms
> Each reserve and unreserve pair operation takes 5.908625ms
> [   OK ] 
> ReservationParam/HierarchicalAllocator__BENCHMARK_WithReservationParam.UpdateAllocation/1
>  (122 ms)
> [ RUN  ] 
> ReservationParam/HierarchicalAllocator__BENCHMARK_WithReservationParam.UpdateAllocation/2
> Agent resources size: 40
> Made 20 reserve and unreserve operations in 232.310825ms
> Each reserve and unreserve pair operation takes 11.615541ms
> [   OK ] 
> ReservationParam/HierarchicalAllocator__BENCHMARK_WithReservationParam.UpdateAllocation/2
>  (237 ms)
> [ RUN  ] 
> ReservationParam/HierarchicalAllocator__BENCHMARK_WithReservationParam.UpdateAllocation/3
> Agent resources size: 400
> Made 20 reserve and unreserve operations in 2.479472164secs
> Each reserve and unreserve pair operation takes 123.973608ms
> [   OK ] 
> ReservationParam/HierarchicalAllocator__BENCHMARK_WithReservationParam.UpdateAllocation/3
>  (2558 ms)
> [ RUN  ] 
> ReservationParam/HierarchicalAllocator__BENCHMARK_WithReservationParam.UpdateAllocation/4
> Agent resources size: 400
> Made 20 reserve and unreserve operations in 4.651083637secs
> Each reserve and unreserve pair operation takes 232.554181ms
> ```
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>



Re: Review Request 71629: Improved logging in Docker store and registry puller.

2019-10-17 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71629/#review218288
---



Patch looks great!

Reviews applied: [71608, 71629]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Oct. 18, 2019, 3:18 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71629/
> ---
> 
> (Updated Oct. 18, 2019, 3:18 a.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-9964
> https://issues.apache.org/jira/browse/MESOS-9964
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Improved logging in Docker store and registry puller.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 35b6afbb6b22575b90963927352443a8ddaf9885 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 
> 286ee5f00933b4c86a96dc4e10e42f9e7eac0ce2 
> 
> 
> Diff: https://reviews.apache.org/r/71629/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>



Re: Review Request 71629: Improved logging in Docker store and registry puller.

2019-10-17 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71629/#review218260
---



Patch looks great!

Reviews applied: [71608, 71629]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Oct. 17, 2019, 9:45 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71629/
> ---
> 
> (Updated Oct. 17, 2019, 9:45 a.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-9964
> https://issues.apache.org/jira/browse/MESOS-9964
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Improved logging in Docker store and registry puller.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 35b6afbb6b22575b90963927352443a8ddaf9885 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 
> 286ee5f00933b4c86a96dc4e10e42f9e7eac0ce2 
> 
> 
> Diff: https://reviews.apache.org/r/71629/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>



Re: Review Request 71608: Supported destroying UCR container in `PROVISIONING` state.

2019-10-17 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71608/#review218257
---



Patch looks great!

Reviews applied: [71608]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Oct. 17, 2019, 7:15 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71608/
> ---
> 
> (Updated Oct. 17, 2019, 7:15 a.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-9964
> https://issues.apache.org/jira/browse/MESOS-9964
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previously in MESOS-3736, we made Docker store support pulling same
> image simultaneously which is a performance improvement, however it
> may cause an issue: If the pulling hangs somehow, all the subsequent
> pulling request for the same image will hang as well, and as a result
> the container destroy will also hang since destroy has to wait for
> provisioning to finish, see MESOS-4985 for details.
> 
> So in this patch we removed that performance improvement and made UCR
> can destroy the container which is being provisioned, i.e., UCR will
> discard the container provisioning and then keep doing the container
> destroy. And we also improved Docker fetcher plugin so that when
> container provisioning is discarded the `curl` process used to fetch
> manifest or blob will be killed immediately.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.hpp 
> 6537f6550b353b1c65a30381f6d68f61508d4960 
>   src/slave/containerizer/mesos/containerizer.cpp 
> c61b954635ebcaed3e498452bddeee6e1b34f388 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 
> 286ee5f00933b4c86a96dc4e10e42f9e7eac0ce2 
>   src/slave/containerizer/mesos/provisioner/provisioner.hpp 
> 38664177ae3805041b412ed52dd0134a6f3aa679 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 
> 3d0b291fa878ab22625435afe2a219d6f776e52c 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 449928c10b897061642af8ad267f8b70695940e6 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 5d5a355afd9c4fda1c653d6cecb75703b0fe 
>   src/uri/fetchers/docker.cpp 8f5fc964f056b349ce57ced139e07f538cb1cfd2 
> 
> 
> Diff: https://reviews.apache.org/r/71608/diff/5/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>



Re: Review Request 71608: Supported destroying UCR container in `PROVISIONING` state.

2019-10-16 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71608/#review218230
---



Bad patch!

Reviews applied: [71608]

Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:14.04' 
BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose 
--disable-libtool-wrappers --disable-parallel-test-execution' 
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh 2>&1 | tee 
build_71608"]

Error:
..
 -DVERSION=\"1.10.0\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 
-DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 
-DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 
-DLT_OBJDIR=\".libs/\" -DHAVE_CXX11=1 -DHAVE_PTHREAD_PRIO_INHERIT=1 
-DHAVE_PTHREAD=1 -DHAVE_OPENSSL_SSL_H=1 -DHAVE_FTS_H=1 -DHAVE_APR_POOLS_H=1 
-DHAVE_LIBAPR_1=1 -DHAVE_LIBCURL=1 -DMESOS_HAS_JAVA=1 -DHAVE_LIBSASL2=1 
-DHAVE_SVN_VERSION_H=1 -DHAVE_LIBSVN_SUBR_1=1 -DHAVE_SVN_DELTA_H=1 
-DHAVE_LIBSVN_DELTA_1=1 -DHAVE_ZLIB_H=1 -DHAVE_LIBZ=1 -DHAVE_PYTHON=\"2.7\" 
-DMESOS_HAS_PYTHON=1 -I. -I../../../3rdparty/libprocess 
-DBUILD_DIR=\"/mesos/mesos-1.10.0/_build/3rdparty/libprocess\" 
-I../../../3rdparty/libprocess/include -I../../../3rdparty/libprocess/src 
-I../boost-1.65.0 -I../concurrentqueue-7b69a8f -I../elfio-3.2 
-I../glog-0.4.0/src -I../grpc-1.10.0/include -I../http-parser-2.6.2 
-I../libev-4.22 -D__STDC_FORMAT_MACROS -I../picojson-1.3.0 
-I../protobuf-3.5.0/src -I../ra
 pidjson-1.1.0/include -I../../../3rdparty/libprocess/../stout/include 
-DLIBPROCESS_ALLOW_JEMALLOC -I/usr/include/subversion-1 -I/usr/include/apr-1 
-I/usr/include/apr-1.0 -Wall -Wsign-compare -Wformat-security -fstack-protector 
-fPIC -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -c 
../../../3rdparty/libprocess/src/authenticator.cpp  -fPIC -DPIC -o 
src/.libs/libprocess_la-authenticator.o
libtool: compile:  g++ -DPACKAGE_NAME=\"mesos\" -DPACKAGE_TARNAME=\"mesos\" 
-DPACKAGE_VERSION=\"1.10.0\" "-DPACKAGE_STRING=\"mesos 1.10.0\"" 
-DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"mesos\" 
-DVERSION=\"1.10.0\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 
-DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 
-DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 
-DLT_OBJDIR=\".libs/\" -DHAVE_CXX11=1 -DHAVE_PTHREAD_PRIO_INHERIT=1 
-DHAVE_PTHREAD=1 -DHAVE_OPENSSL_SSL_H=1 -DHAVE_FTS_H=1 -DHAVE_APR_POOLS_H=1 
-DHAVE_LIBAPR_1=1 -DHAVE_LIBCURL=1 -DMESOS_HAS_JAVA=1 -DHAVE_LIBSASL2=1 
-DHAVE_SVN_VERSION_H=1 -DHAVE_LIBSVN_SUBR_1=1 -DHAVE_SVN_DELTA_H=1 
-DHAVE_LIBSVN_DELTA_1=1 -DHAVE_ZLIB_H=1 -DHAVE_LIBZ=1 -DHAVE_PYTHON=\"2.7\" 
-DMESOS_HAS_PYTHON=1 -I. -I../../../3rdparty/libprocess 
-DBUILD_DIR=\"/mesos/mesos-1.10.0/_build/3rdparty/libprocess\" 
-I../../../3rdparty/libprocess/include -I../../../3rdparty/libprocess/src 
-I../boost-1.65.
 0 -I../concurrentqueue-7b69a8f -I../elfio-3.2 -I../glog-0.4.0/src 
-I../grpc-1.10.0/include -I../http-parser-2.6.2 -I../libev-4.22 
-D__STDC_FORMAT_MACROS -I../picojson-1.3.0 -I../protobuf-3.5.0/src 
-I../rapidjson-1.1.0/include -I../../../3rdparty/libprocess/../stout/include 
-DLIBPROCESS_ALLOW_JEMALLOC -I/usr/include/subversion-1 -I/usr/include/apr-1 
-I/usr/include/apr-1.0 -Wall -Wsign-compare -Wformat-security -fstack-protector 
-fPIC -g1 -O0 -Wno-unused-local-typedefs -std=c++11 -c 
../../../3rdparty/libprocess/src/gtest_constants.cpp  -fPIC -DPIC -o 
src/.libs/libprocess_la-gtest_constants.o
libtool: compile:  g++ -DPACKAGE_NAME=\"mesos\" -DPACKAGE_TARNAME=\"mesos\" 
-DPACKAGE_VERSION=\"1.10.0\" "-DPACKAGE_STRING=\"mesos 1.10.0\"" 
-DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"mesos\" 
-DVERSION=\"1.10.0\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 
-DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 
-DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 
-DLT_OBJDIR=\".libs/\" -DHAVE_CXX11=1 -DHAVE_PTHREAD_PRIO_INHERIT=1 
-DHAVE_PTHREAD=1 -DHAVE_OPENSSL_SSL_H=1 -DHAVE_FTS_H=1 -DHAVE_APR_POOLS_H=1 
-DHAVE_LIBAPR_1=1 -DHAVE_LIBCURL=1 -DMESOS_HAS_JAVA=1 -DHAVE_LIBSASL2=1 
-DHAVE_SVN_VERSION_H=1 -DHAVE_LIBSVN_SUBR_1=1 -DHAVE_SVN_DELTA_H=1 
-DHAVE_LIBSVN_DELTA_1=1 -DHAVE_ZLIB_H=1 -DHAVE_LIBZ=1 -DHAVE_PYTHON=\"2.7\" 
-DMESOS_HAS_PYTHON=1 -I. -I../../../3rdparty/libprocess 
-DBUILD_DIR=\"/mesos/mesos-1.10.0/_build/3rdparty/libprocess\" 
-I../../../3rdparty/libprocess/include -I../../../3rdparty/libprocess/src 
-I../boost-1.65.
 0 -I../concurrentqueue-7b69a8f -I../elfio-3.2 -I../glog-0.4.0/src 
-I../grpc-1.10.0/include -I../http-parser-2.6.2 -I../libev-4.22 
-D__STDC_FORMAT_MACROS -I../picojson-1.3.0 -I../protobuf-3.5.0/src 
-I../rapidjson-1.1.0/include -I../../../3rdparty/libprocess/../stout/include 
-DLIBPROCESS_ALLOW_JEMALLOC -I/usr/include/subversion-1 -I/usr/include/apr-1 
-I/usr/include/apr-1.0 

Re: Review Request 71608: Supported destroying UCR container in `PROVISIONING` state.

2019-10-15 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71608/#review218220
---



Patch looks great!

Reviews applied: [71608]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Oct. 15, 2019, 2:18 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71608/
> ---
> 
> (Updated Oct. 15, 2019, 2:18 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-9964
> https://issues.apache.org/jira/browse/MESOS-9964
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previously in MESOS-3736, we made Docker store support pulling same
> image simultaneously which is a performance improvement, however it
> may cause an issue: If the pulling hangs somehow, all the subsequent
> pulling request for the same image will hang as well, and as a result
> the container destroy will also hang since destroy has to wait for
> provisioning to finish, see MESOS-4985 for details.
> 
> So in this patch we removed that performance improvement and made UCR
> can destroy the container which is being provisioned, i.e., UCR will
> discard the container provisioning and then keep doing the container
> destroy. And we also improved Docker fetcher plugin so that when
> container provisioning is discarded the `curl` process used to fetch
> manifest or blob will be killed immediately.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.hpp 
> 6537f6550b353b1c65a30381f6d68f61508d4960 
>   src/slave/containerizer/mesos/containerizer.cpp 
> c61b954635ebcaed3e498452bddeee6e1b34f388 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 
> 286ee5f00933b4c86a96dc4e10e42f9e7eac0ce2 
>   src/slave/containerizer/mesos/provisioner/provisioner.hpp 
> 38664177ae3805041b412ed52dd0134a6f3aa679 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 
> 3d0b291fa878ab22625435afe2a219d6f776e52c 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 449928c10b897061642af8ad267f8b70695940e6 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 5d5a355afd9c4fda1c653d6cecb75703b0fe 
>   src/uri/fetchers/docker.cpp 8f5fc964f056b349ce57ced139e07f538cb1cfd2 
> 
> 
> Diff: https://reviews.apache.org/r/71608/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>



Re: Review Request 71608: WIP: Supported destroying UCR container in `PROVISIONING` state.

2019-10-14 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71608/#review218203
---



Patch looks great!

Reviews applied: [71608]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Oct. 14, 2019, 2:50 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71608/
> ---
> 
> (Updated Oct. 14, 2019, 2:50 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-9964
> https://issues.apache.org/jira/browse/MESOS-9964
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> WIP: Supported destroying UCR container in `PROVISIONING` state.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.hpp 
> 6537f6550b353b1c65a30381f6d68f61508d4960 
>   src/slave/containerizer/mesos/containerizer.cpp 
> c61b954635ebcaed3e498452bddeee6e1b34f388 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 
> 286ee5f00933b4c86a96dc4e10e42f9e7eac0ce2 
>   src/slave/containerizer/mesos/provisioner/provisioner.hpp 
> 38664177ae3805041b412ed52dd0134a6f3aa679 
>   src/slave/containerizer/mesos/provisioner/provisioner.cpp 
> 3d0b291fa878ab22625435afe2a219d6f776e52c 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 5d5a355afd9c4fda1c653d6cecb75703b0fe 
>   src/uri/fetchers/docker.cpp 8f5fc964f056b349ce57ced139e07f538cb1cfd2 
> 
> 
> Diff: https://reviews.apache.org/r/71608/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>



Re: Review Request 71608: WIP: Supported destroying UCR container in `PROVISIONING` state.

2019-10-11 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71608/#review218191
---



Bad patch!

Reviews applied: [71608]

Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:14.04' 
BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose 
--disable-libtool-wrappers --disable-parallel-test-execution' 
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh 2>&1 | tee 
build_71608"]

Error:
..
LAR"}]'
I1011 17:32:07.722311 18989 sched.cpp:960] Rescinded offer 
43815832-d1a9-46d1-aecf-ab90f0b06204-O3
I1011 17:32:07.722419 18989 sched.cpp:971] Scheduler::offerRescinded took 
28621ns
I1011 17:32:07.722991 18982 master.cpp:12706] Removing offer 
43815832-d1a9-46d1-aecf-ab90f0b06204-O3
I1011 17:32:07.723021 18970 hierarchical.cpp:1566] Recovered ports(allocated: 
storage/default-role):[31000-32000]; disk(allocated: 
storage/default-role)(reservations: 
[(DYNAMIC,storage),(DYNAMIC,storage/default-role,test-principal)])[MOUNT(org.apache.mesos.csi.test.local,/tmp/CSIVersion_StorageLocalResourceProviderTest_OperatorOperationsWithResourceProviderResources_v1_3fAXuR/2GB-0e3a46a9-2bfd-4a7b-98e5-af47dc77ba36,test)]:2048;
 cpus(allocated: storage/default-role):2; mem(allocated: 
storage/default-role):1024; disk(allocated: storage/default-role):1024 (total: 
cpus:2; mem:1024; disk:1024; ports:[31000-32000]; disk(reservations: 
[(DYNAMIC,storage),(DYNAMIC,storage/default-role,test-principal)])[MOUNT(org.apache.mesos.csi.test.local,/tmp/CSIVersion_StorageLocalResourceProviderTest_OperatorOperationsWithResourceProviderResources_v1_3fAXuR/2GB-0e3a46a9-2bfd-4a7b-98e5-af47dc77ba36,test)]:2048,
 offered or allocated: {}) on agent 43815832-d1a9-46d1-aecf-ab90f0b06204-S0 
from framework 43815
 832-d1a9-46d1-aecf-ab90f0b06204-
I1011 17:32:07.725344 18970 hierarchical.cpp:1615] Framework 
43815832-d1a9-46d1-aecf-ab90f0b06204- filtered agent 
43815832-d1a9-46d1-aecf-ab90f0b06204-S0 for 5secs
I1011 17:32:07.729540 18978 master.cpp:12571] Sending operation '' (uuid: 
12b5f679-7049-418c-889e-a599bddaecf9) to agent 
43815832-d1a9-46d1-aecf-ab90f0b06204-S0 at slave(1249)@172.17.0.2:33599 
(5a7f1e158b5b)
I1011 17:32:07.730231 18981 slave.cpp:4352] Ignoring new checkpointed resources 
and operations identical to the current version
I1011 17:32:07.733209 18977 master.cpp:6412] Processing REVIVE call for 
framework 43815832-d1a9-46d1-aecf-ab90f0b06204- (default) at 
scheduler-068a09cf-d49f-47e2-9624-a4151c668a37@172.17.0.2:33599
I1011 17:32:07.733944 18988 hierarchical.cpp:1711] Unsuppressed offers and 
cleared filters for roles { storage/default-role } of framework 
43815832-d1a9-46d1-aecf-ab90f0b06204-
I1011 17:32:07.734148 18987 provider.cpp:498] Received APPLY_OPERATION event
I1011 17:32:07.734212 18987 provider.cpp:1351] Received CREATE operation '' 
(uuid: 12b5f679-7049-418c-889e-a599bddaecf9)
I1011 17:32:07.735894 18988 hierarchical.cpp:1843] Performed allocation for 1 
agents in 1.596759ms
I1011 17:32:07.736515 18988 hierarchical.cpp:1843] Performed allocation for 1 
agents in 261378ns
I1011 17:32:07.736927 18982 master.cpp:10409] Sending offers [ 
43815832-d1a9-46d1-aecf-ab90f0b06204-O4 ] to framework 
43815832-d1a9-46d1-aecf-ab90f0b06204- (default) at 
scheduler-068a09cf-d49f-47e2-9624-a4151c668a37@172.17.0.2:33599
I1011 17:32:07.737850 18967 sched.cpp:934] Scheduler::resourceOffers took 
112665ns
I1011 17:32:07.746440 18966 http.cpp:1115] HTTP POST for 
/slave(1249)/api/v1/resource_provider from 172.17.0.2:32910
I1011 17:32:07.748093 18979 slave.cpp:8483] Handling resource provider message 
'UPDATE_OPERATION_STATUS: (uuid: 58cfd2f9-be1a-4194-a8be-ab4a00efe898) for 
framework  (latest state: OPERATION_FINISHED, status update state: 
OPERATION_FINISHED)'
I1011 17:32:07.748378 18979 slave.cpp:8936] Updating the state of operation 
with no ID (uuid: 58cfd2f9-be1a-4194-a8be-ab4a00efe898) for an operation API 
call (latest state: OPERATION_FINISHED, status update state: OPERATION_FINISHED)
I1011 17:32:07.748462 18979 slave.cpp:8690] Forwarding status update of 
operation with no ID (operation_uuid: 58cfd2f9-be1a-4194-a8be-ab4a00efe898) for 
an operator API call
I1011 17:32:07.749047 18975 master.cpp:12223] Updating the state of operation 
'' (uuid: 58cfd2f9-be1a-4194-a8be-ab4a00efe898) for an operator API call 
(latest state: OPERATION_PENDING, status update state: OPERATION_FINISHED)
I1011 17:32:07.749917 18983 slave.cpp:4352] Ignoring new checkpointed resources 
and operations identical to the current version
I1011 17:32:07.928742 18967 status_update_manager_process.hpp:152] Received 
operation status update OPERATION_FINISHED (Status UUID: 
c6d5b3cd-10fe-4945-8914-e346e5e0842c) for operation UUID 
12b5f679-7049-418c-889e-a599bddaecf9 on agent 
43815832-d1a9-46d1-aecf-ab90f0b06204-S0
I1011 17:32:07.928853 18967 

Re: Review Request 71599: Added validation against scalar overflow.

2019-10-09 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71599/#review218151
---



Patch looks great!

Reviews applied: [71595, 71596, 71597, 71598, 71599]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Oct. 9, 2019, 4:43 a.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71599/
> ---
> 
> (Updated Oct. 9, 2019, 4:43 a.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Meng Zhu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Note that this input scalar validation is currently used during quota
> validation as well as during parsing. This means resources passed as
> strings will now include this overflow validation.
> 
> This validation is insufficient, it's still possible to use a very
> large value close to the overflow point, and have some addition occur
> later leading to overflow and a crash. But, it's better than nothing.
> 
> 
> Diffs
> -
> 
>   src/common/validation.cpp 14a8c7b9d70c303b527e5e43012999471ced2d78 
>   src/common/values.cpp 75203824a1016eae7088bee19e61ee8cf8d3a660 
>   src/v1/values.cpp 6193dbd8bad7f060e6bb2c18e3984c4a4b061ab6 
> 
> 
> Diff: https://reviews.apache.org/r/71599/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>



Re: Review Request 71498: Introduced a role tree helper to modify a role and all its ancestors.

2019-10-07 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71498/#review218108
---



Patch looks great!

Reviews applied: [71486, 71487, 71488, 71489, 71490, 71491, 71498]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Sept. 18, 2019, 12:59 p.m., Andrei Sekretenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71498/
> ---
> 
> (Updated Sept. 18, 2019, 12:59 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Meng Zhu.
> 
> 
> Bugs: MESOS-9949
> https://issues.apache.org/jira/browse/MESOS-9949
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Introduced a role tree helper to modify a role and all its ancestors.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> 5ea37912dadded47eaa2d354889c95533b191c59 
>   src/master/allocator/mesos/hierarchical.cpp 
> 256fdce61ccfb768605cac1579c9a6632cd26fec 
> 
> 
> Diff: https://reviews.apache.org/r/71498/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>



Re: Review Request 71498: Introduced a role tree helper to modify a role and all its ancestors.

2019-10-04 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71498/#review218092
---



Bad patch!

Reviews applied: [71486, 71487, 71488, 71489, 71490, 71491, 71498]

Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:14.04' 
BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose 
--disable-libtool-wrappers --disable-parallel-test-execution' 
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh 2>&1 | tee 
build_71498"]

Error:
..
D=1 -DHAVE_OPENSSL_SSL_H=1 -DHAVE_FTS_H=1 -DHAVE_APR_POOLS_H=1 
-DHAVE_LIBAPR_1=1 -DHAVE_LIBCURL=1 -DMESOS_HAS_JAVA=1 -DHAVE_LIBSASL2=1 
-DHAVE_SVN_VERSION_H=1 -DHAVE_LIBSVN_SUBR_1=1 -DHAVE_SVN_DELTA_H=1 
-DHAVE_LIBSVN_DELTA_1=1 -DHAVE_ZLIB_H=1 -DHAVE_LIBZ=1 -DHAVE_PYTHON=\"2.7\" 
-DMESOS_HAS_PYTHON=1 -I. -I../../src   -Werror 
-DLIBDIR=\"/mesos/mesos-1.10.0/_inst/lib\" 
-DPKGLIBEXECDIR=\"/mesos/mesos-1.10.0/_inst/libexec/mesos\" 
-DPKGDATADIR=\"/mesos/mesos-1.10.0/_inst/share/mesos\" 
-DPKGMODULEDIR=\"/mesos/mesos-1.10.0/_inst/lib/mesos/modules\" -I../../include 
-I../include -I../include/mesos -D__STDC_FORMAT_MACROS 
-I../3rdparty/boost-1.65.0 -I../3rdparty/concurrentqueue-7b69a8f 
-I../3rdparty/elfio-3.2 -I../3rdparty/glog-0.4.0/src 
-I../3rdparty/grpc-1.10.0/include -I../3rdparty/leveldb-1.19/include 
-I../3rdparty/libarchive-3.3.2/libarchive/ -I../../3rdparty/libprocess/include  
-I../3rdparty/nvml-352.79 -I../3rdparty/picojson-1.3.0 
-I../3rdparty/protobuf-3.5.0/src -I../3rdparty/rapidjson-1.
 1.0/include -I../../3rdparty/stout/include 
-I../3rdparty/zookeeper-3.4.8/src/c/include 
-I../3rdparty/zookeeper-3.4.8/src/c/generated -I/usr/include/subversion-1 
-I/usr/include/apr-1 -I/usr/include/apr-1.0  -pthread -Wall 
-Wsign-compare -Wformat-security -fstack-protector -fPIC -fPIE -g1 -O0 
-Wno-unused-local-typedefs -std=c++11 -c -o 
docker/libmesos_no_3rdparty_la-executor.lo `test -f 'docker/executor.cpp' || 
echo '../../src/'`docker/executor.cpp
libtool: compile:  g++ -DPACKAGE_NAME=\"mesos\" -DPACKAGE_TARNAME=\"mesos\" 
-DPACKAGE_VERSION=\"1.10.0\" "-DPACKAGE_STRING=\"mesos 1.10.0\"" 
-DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"mesos\" 
-DVERSION=\"1.10.0\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 
-DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 
-DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 
-DLT_OBJDIR=\".libs/\" -DHAVE_CXX11=1 -DHAVE_PTHREAD_PRIO_INHERIT=1 
-DHAVE_PTHREAD=1 -DHAVE_OPENSSL_SSL_H=1 -DHAVE_FTS_H=1 -DHAVE_APR_POOLS_H=1 
-DHAVE_LIBAPR_1=1 -DHAVE_LIBCURL=1 -DMESOS_HAS_JAVA=1 -DHAVE_LIBSASL2=1 
-DHAVE_SVN_VERSION_H=1 -DHAVE_LIBSVN_SUBR_1=1 -DHAVE_SVN_DELTA_H=1 
-DHAVE_LIBSVN_DELTA_1=1 -DHAVE_ZLIB_H=1 -DHAVE_LIBZ=1 -DHAVE_PYTHON=\"2.7\" 
-DMESOS_HAS_PYTHON=1 -I. -I../../src -Werror 
-DLIBDIR=\"/mesos/mesos-1.10.0/_inst/lib\" 
-DPKGLIBEXECDIR=\"/mesos/mesos-1.10.0/_inst/libexec/mesos\" 
-DPKGDATADIR=\"/mesos/mesos-1.10.0/_inst/share/mesos\" -DPKGM
 ODULEDIR=\"/mesos/mesos-1.10.0/_inst/lib/mesos/modules\" -I../../include 
-I../include -I../include/mesos -D__STDC_FORMAT_MACROS 
-I../3rdparty/boost-1.65.0 -I../3rdparty/concurrentqueue-7b69a8f 
-I../3rdparty/elfio-3.2 -I../3rdparty/glog-0.4.0/src 
-I../3rdparty/grpc-1.10.0/include -I../3rdparty/leveldb-1.19/include 
-I../3rdparty/libarchive-3.3.2/libarchive/ -I../../3rdparty/libprocess/include 
-I../3rdparty/nvml-352.79 -I../3rdparty/picojson-1.3.0 
-I../3rdparty/protobuf-3.5.0/src -I../3rdparty/rapidjson-1.1.0/include 
-I../../3rdparty/stout/include -I../3rdparty/zookeeper-3.4.8/src/c/include 
-I../3rdparty/zookeeper-3.4.8/src/c/generated -I/usr/include/subversion-1 
-I/usr/include/apr-1 -I/usr/include/apr-1.0 -pthread -Wall -Wsign-compare 
-Wformat-security -fstack-protector -fPIC -g1 -O0 -Wno-unused-local-typedefs 
-std=c++11 -c ../../src/docker/docker.cpp  -fPIC -DPIC -o 
docker/.libs/libmesos_no_3rdparty_la-docker.o
libtool: compile:  g++ -DPACKAGE_NAME=\"mesos\" -DPACKAGE_TARNAME=\"mesos\" 
-DPACKAGE_VERSION=\"1.10.0\" "-DPACKAGE_STRING=\"mesos 1.10.0\"" 
-DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"mesos\" 
-DVERSION=\"1.10.0\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 
-DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 
-DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 
-DLT_OBJDIR=\".libs/\" -DHAVE_CXX11=1 -DHAVE_PTHREAD_PRIO_INHERIT=1 
-DHAVE_PTHREAD=1 -DHAVE_OPENSSL_SSL_H=1 -DHAVE_FTS_H=1 -DHAVE_APR_POOLS_H=1 
-DHAVE_LIBAPR_1=1 -DHAVE_LIBCURL=1 -DMESOS_HAS_JAVA=1 -DHAVE_LIBSASL2=1 
-DHAVE_SVN_VERSION_H=1 -DHAVE_LIBSVN_SUBR_1=1 -DHAVE_SVN_DELTA_H=1 
-DHAVE_LIBSVN_DELTA_1=1 -DHAVE_ZLIB_H=1 -DHAVE_LIBZ=1 -DHAVE_PYTHON=\"2.7\" 
-DMESOS_HAS_PYTHON=1 -I. -I../../src -Werror 
-DLIBDIR=\"/mesos/mesos-1.10.0/_inst/lib\" 

Re: Review Request 71498: Introduced a role tree helper to modify a role and all its ancestors.

2019-10-04 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71498/#review218082
---



Bad review!

Reviews applied: [71498, 71491, 71490, 71489, 71488, 71487, 71486]

Error:
2019-10-04 18:23:53 URL:https://reviews.apache.org/r/71488/diff/raw/ 
[6554/6554] -> "71488.patch" [1]
error: patch failed: src/master/allocator/mesos/hierarchical.cpp:1477
error: src/master/allocator/mesos/hierarchical.cpp: patch does not apply

- Mesos Reviewbot


On Sept. 18, 2019, 12:59 p.m., Andrei Sekretenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71498/
> ---
> 
> (Updated Sept. 18, 2019, 12:59 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Meng Zhu.
> 
> 
> Bugs: MESOS-9949
> https://issues.apache.org/jira/browse/MESOS-9949
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Introduced a role tree helper to modify a role and all its ancestors.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> 5ea37912dadded47eaa2d354889c95533b191c59 
>   src/master/allocator/mesos/hierarchical.cpp 
> 256fdce61ccfb768605cac1579c9a6632cd26fec 
> 
> 
> Diff: https://reviews.apache.org/r/71498/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>



Re: Review Request 71579: Eliminate accidental loop amplification over unreachable tasks.

2019-10-03 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71579/#review218062
---



Patch looks great!

Reviews applied: [71579]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Oct. 3, 2019, 8:59 p.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71579/
> ---
> 
> (Updated Oct. 3, 2019, 8:59 p.m.)
> 
> 
> Review request for mesos, haosdent huang and Meng Zhu.
> 
> 
> Bugs: MESOS-9889
> https://issues.apache.org/jira/browse/MESOS-9889
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Per MESOS-9889, the foreachkey operator on a multimap will actually
> loop over each  entry, thus looping over the same key
> multiple times. The code in the master is written such that
> excessive looping occurs.
> 
> For example:   
> This will consider T1,T2,T3 3 times each rather than once each!
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 23eb2a6854b1b53f80167cc8425339530de78e81 
>   src/master/master.cpp 65994aa72ec4bfefdb09b88a62db910727bb0897 
> 
> 
> Diff: https://reviews.apache.org/r/71579/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>



Re: Review Request 71560: Made the MaintenanceInverseOffers test use only one framework.

2019-09-30 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71560/#review217995
---



Patch looks great!

Reviews applied: [71560]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Sept. 30, 2019, 1:33 p.m., Andrei Sekretenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71560/
> ---
> 
> (Updated Sept. 30, 2019, 1:33 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Meng Zhu.
> 
> 
> Bugs: MESOS-9980
> https://issues.apache.org/jira/browse/MESOS-9980
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch simplifies the test and attepmts to fix MESOS-9980 by
> removing the (potential) flakiness caused by agent2's resources
> being re-offered to framework2.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> a13eb017f7a93ee67c8426e4150858a547175ed6 
> 
> 
> Diff: https://reviews.apache.org/r/71560/diff/1/
> 
> 
> Testing
> ---
> 
> `./bin/mesos-tests.sh --gtest_filter="*MaintenanceInverseOffers*" 
> --gtest_break_on_failure --gtest_repeat=1`
> 
> `./bin/mesos-tests.sh --gtest_filter="*MaintenanceInverseOffers*" 
> --gtest_break_on_failure` fails if I break framework untracking in 
> `Slave::increaseAvailable()` in the allocator.
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>



Re: Review Request 71559: Added early exit in reviewbot if nothing to review.

2019-09-30 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71559/#review217993
---



Patch looks great!

Reviews applied: [71559]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Sept. 30, 2019, 1:06 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71559/
> ---
> 
> (Updated Sept. 30, 2019, 1:06 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The current reviewbot setup always makes sure that the `master` branch
> can be built before verifying any reviews. This takes considerable time.
> 
> With this patch we now avoid any builds if no reviews need to be
> verified. While detecting reviews requiring verification takes some
> time, it is currently much faster than building Mesos. With this setup
> we should now finish this job much faster in the usual case (nothing
> needs verification) while taking only on the order of a minute longer
> otherwise.
> 
> 
> Diffs
> -
> 
>   support/jenkins/reviewbot.sh c5b497634cb9754fa19c5af3f579ceae25ab912d 
> 
> 
> Diff: https://reviews.apache.org/r/71559/diff/1/
> 
> 
> Testing
> ---
> 
> Verified early exit by running locally.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 71498: Introduced a role tree helper to modify a role and all its ancestors.

2019-09-27 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71498/#review217968
---



Patch looks great!

Reviews applied: [71486, 71487, 71488, 71489, 71490, 71491, 71498]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Sept. 18, 2019, 5:59 a.m., Andrei Sekretenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71498/
> ---
> 
> (Updated Sept. 18, 2019, 5:59 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Meng Zhu.
> 
> 
> Bugs: MESOS-9949
> https://issues.apache.org/jira/browse/MESOS-9949
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Introduced a role tree helper to modify a role and all its ancestors.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> 5ea37912dadded47eaa2d354889c95533b191c59 
>   src/master/allocator/mesos/hierarchical.cpp 
> 256fdce61ccfb768605cac1579c9a6632cd26fec 
> 
> 
> Diff: https://reviews.apache.org/r/71498/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>



Re: Review Request 71534: Fixed parsing of HTTP authentication headers.

2019-09-27 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71534/#review217963
---



Patch looks great!

Reviews applied: [71533, 71534]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Sept. 25, 2019, 9:21 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71534/
> ---
> 
> (Updated Sept. 25, 2019, 9:21 a.m.)
> 
> 
> Review request for mesos, Benno Evers, Greg Mann, and Till Toenshoff.
> 
> 
> Bugs: MESOS-9968
> https://issues.apache.org/jira/browse/MESOS-9968
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds support for quoted strings in `Www-Authenticate` headers
> and allows to use spaces when delimiting authentication attributes of
> the form `WWW-Autenticate: a=b, c=d`, both of with are allowed by
> RFC2617.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/http.hpp 
> 654bbc2221597028b45817b8c3e29dc17515c6fe 
>   3rdparty/libprocess/src/http.cpp 0ed41aaac90dff188c424ded8536df03ab80d2ab 
>   3rdparty/libprocess/src/tests/http_tests.cpp 
> 8cb5f163f2fc34baeabfb1ef640fe39bf6709872 
> 
> 
> Diff: https://reviews.apache.org/r/71534/diff/3/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 71548: Documented setting quota on the default role in the release note.

2019-09-25 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71548/#review217950
---



Patch looks great!

Reviews applied: [71464, 71548]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Sept. 25, 2019, 10:44 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71548/
> ---
> 
> (Updated Sept. 25, 2019, 10:44 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documented setting quota on the default role in the release note.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 98bbaa0e93189f5cc1c406211c98f53abf79602d 
> 
> 
> Diff: https://reviews.apache.org/r/71548/diff/1/
> 
> 
> Testing
> ---
> 
> N/A
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>



Re: Review Request 71547: Refactored `removeFramework()` in the allocator.

2019-09-25 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71547/#review217949
---



Patch looks great!

Reviews applied: [71546, 71547]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Sept. 25, 2019, 10:30 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71547/
> ---
> 
> (Updated Sept. 25, 2019, 10:30 p.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Now allocated or offered resources are tracked in the slave
> struct, we no longer need to look up states in the sorter
> when removing frameworks. This patch makes the framework
> removal logic more simpler by doing this.
> 
> This also paves the way to deprecate the framework sorter.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> d42124f534536ad044bff9878d242892fa042f24 
>   src/master/allocator/mesos/hierarchical.cpp 
> 47281542792486854b71c7e75dfa8ea3ee3ef3fc 
> 
> 
> Diff: https://reviews.apache.org/r/71547/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>



Re: Review Request 71388: Introduced automatic lifecycle management in `DynamicLibrary`.

2019-09-25 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71388/#review217948
---



Patch looks great!

Reviews applied: [71388]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Sept. 25, 2019, 9:23 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71388/
> ---
> 
> (Updated Sept. 25, 2019, 9:23 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This not only simplifies our implementation of `DynamicLibrary`, but
> also removes the potential for accidental file descriptor leaks.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/posix/dynamiclibrary.hpp 
> 6a50592632246b06152bee177e933f65438c07ca 
> 
> 
> Diff: https://reviews.apache.org/r/71388/diff/2/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 71541: Fixed Javascript linting and IE compatibility of the UI roles tree.

2019-09-25 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71541/#review217939
---



Bad patch!

Reviews applied: [71541]

Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:14.04' 
BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose 
--disable-libtool-wrappers --disable-parallel-test-execution' 
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh 2>&1 | tee 
build_71541"]

Error:
..
t bbe07ca9-fe27-49ed-a497-56c746614965-S0 at slave(1246)@172.17.0.2:40755 
(f17bfe3e8bbb)
I0925 14:15:04.637451 18801 slave.cpp:4352] Ignoring new checkpointed resources 
and operations identical to the current version
I0925 14:15:04.640161 18796 provider.cpp:498] Received APPLY_OPERATION event
I0925 14:15:04.640197 18796 provider.cpp:1351] Received RESERVE operation '' 
(uuid: 65b906fa-afe2-4225-a942-143d48be3c0a)
I0925 14:15:04.653962 18793 status_update_manager_process.hpp:152] Received 
operation status update OPERATION_FINISHED (Status UUID: 
b3c06a59-a4bb-4e5a-9b1f-13196c0a3a1a) for operation UUID 
65b906fa-afe2-4225-a942-143d48be3c0a on agent 
bbe07ca9-fe27-49ed-a497-56c746614965-S0
I0925 14:15:04.654024 18793 status_update_manager_process.hpp:414] Creating 
operation status update stream 65b906fa-afe2-4225-a942-143d48be3c0a 
checkpoint=true
I0925 14:15:04.654261 18793 status_update_manager_process.hpp:929] 
Checkpointing UPDATE for operation status update OPERATION_FINISHED (Status 
UUID: b3c06a59-a4bb-4e5a-9b1f-13196c0a3a1a) for operation UUID 
65b906fa-afe2-4225-a942-143d48be3c0a on agent 
bbe07ca9-fe27-49ed-a497-56c746614965-S0
I0925 14:15:04.670671 18793 status_update_manager_process.hpp:528] Forwarding 
operation status update OPERATION_FINISHED (Status UUID: 
b3c06a59-a4bb-4e5a-9b1f-13196c0a3a1a) for operation UUID 
65b906fa-afe2-4225-a942-143d48be3c0a on agent 
bbe07ca9-fe27-49ed-a497-56c746614965-S0
I0925 14:15:04.671538 18804 http_connection.hpp:131] Sending 
UPDATE_OPERATION_STATUS call to 
http://172.17.0.2:40755/slave(1246)/api/v1/resource_provider
I0925 14:15:04.672477 18798 process.cpp:3671] Handling HTTP event for process 
'slave(1246)' with path: '/slave(1246)/api/v1/resource_provider'
I0925 14:15:04.675462 18797 hierarchical.cpp:1788] Performed allocation for 1 
agents in 1.028309ms
I0925 14:15:04.676064 18799 master.cpp:10389] Sending offers [ 
bbe07ca9-fe27-49ed-a497-56c746614965-O3 ] to framework 
bbe07ca9-fe27-49ed-a497-56c746614965- (default) at 
scheduler-8030f52c-2da5-455d-936a-91ad51a3a7ea@172.17.0.2:40755
I0925 14:15:04.676582 18806 sched.cpp:934] Scheduler::resourceOffers took 
66440ns
I0925 14:15:04.679494 18805 process.cpp:3671] Handling HTTP event for process 
'master' with path: '/master/api/v1'
I0925 14:15:04.681316 18808 http.cpp:1115] HTTP POST for /master/api/v1 from 
172.17.0.2:58302
I0925 14:15:04.681541 18808 http.cpp:263] Processing call CREATE_VOLUMES
I0925 14:15:04.682375 18808 master.cpp:3938] Authorizing principal 
'test-principal' to create volumes 
'[{"disk":{"persistence":{"id":"4ceac496-74ad-4b14-b587-f455c0a7d785","principal":"test-principal"},"source":{"id":"/tmp/CSIVersion_StorageLocalResourceProviderTest_OperatorOperationsWithResourceProviderResources_v1_0tLRkn/2GB-afc46bd8-1df9-4e55-87eb-b0bba290c20b","mount":{"root":"./csi/org.apache.mesos.csi.test/local/mounts"},"profile":"test","type":"MOUNT","vendor":"org.apache.mesos.csi.test.local"},"volume":{"container_path":"volume","mode":"RW"}},"name":"disk","provider_id":{"value":"eb030101-2457-40fe-98b6-e3a7135c0e3e"},"reservations":[{"role":"storage","type":"DYNAMIC"},{"principal":"test-principal","role":"storage/default-role","type":"DYNAMIC"}],"scalar":{"value":2048.0},"type":"SCALAR"}]'
I0925 14:15:04.683980 18799 sched.cpp:960] Rescinded offer 
bbe07ca9-fe27-49ed-a497-56c746614965-O3
I0925 14:15:04.684063 18799 sched.cpp:971] Scheduler::offerRescinded took 
25796ns
I0925 14:15:04.684481 18806 hierarchical.cpp:1511] Recovered ports(allocated: 
storage/default-role):[31000-32000]; disk(allocated: 
storage/default-role)(reservations: 
[(DYNAMIC,storage),(DYNAMIC,storage/default-role,test-principal)])[MOUNT(org.apache.mesos.csi.test.local,/tmp/CSIVersion_StorageLocalResourceProviderTest_OperatorOperationsWithResourceProviderResources_v1_0tLRkn/2GB-afc46bd8-1df9-4e55-87eb-b0bba290c20b,test)]:2048;
 cpus(allocated: storage/default-role):2; mem(allocated: 
storage/default-role):1024; disk(allocated: storage/default-role):1024 (total: 
cpus:2; mem:1024; disk:1024; ports:[31000-32000]; disk(reservations: 
[(DYNAMIC,storage),(DYNAMIC,storage/default-role,test-principal)])[MOUNT(org.apache.mesos.csi.test.local,/tmp/CSIVersion_StorageLocalResourceProviderTest_OperatorOperationsWithResourceProviderResources_v1_0tLRkn/2GB-afc46bd8-1df9-4e55-87eb-b0bba290c20b,test)]:2048,
 offered or allocated: {}) on agent 

Re: Review Request 71534: Fixed parsing of HTTP authentication headers.

2019-09-25 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71534/#review217936
---



Patch looks great!

Reviews applied: [71533, 71534]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Sept. 25, 2019, 9:21 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71534/
> ---
> 
> (Updated Sept. 25, 2019, 9:21 a.m.)
> 
> 
> Review request for mesos, Benno Evers, Greg Mann, and Till Toenshoff.
> 
> 
> Bugs: MESOS-9968
> https://issues.apache.org/jira/browse/MESOS-9968
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds support for quoted strings in `Www-Authenticate` headers
> and allows to use spaces when delimiting authentication attributes of
> the form `WWW-Autenticate: a=b, c=d`, both of with are allowed by
> RFC2617.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/http.hpp 
> 654bbc2221597028b45817b8c3e29dc17515c6fe 
>   3rdparty/libprocess/src/http.cpp 0ed41aaac90dff188c424ded8536df03ab80d2ab 
>   3rdparty/libprocess/src/tests/http_tests.cpp 
> 8cb5f163f2fc34baeabfb1ef640fe39bf6709872 
> 
> 
> Diff: https://reviews.apache.org/r/71534/diff/2/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 71538: Allowed disabling use of NVML headers.

2019-09-24 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71538/#review217933
---



Patch looks great!

Reviews applied: [71538]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Sept. 24, 2019, 3:08 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71538/
> ---
> 
> (Updated Sept. 24, 2019, 3:08 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Kevin Klues.
> 
> 
> Bugs: MESOS-9978
> https://issues.apache.org/jira/browse/MESOS-9978
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> NVML is distributed under a license which is probably not "free" which
> can e.g., be aan obstacle when including Mesos using symbols from it in
> certain distributions.
> 
> This patch adds a configure flag to disable use of the NVML headers
> completely. Note that with this flag disabled it is impossible to use
> GPU isolation with the Mesos containerizer.
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt 23ef7c1e5c6fe1555b6f2458f2a858471783ae2a 
>   3rdparty/Makefile.am 0de005dad9775f9f7e1a77a242e3b345219c7ac3 
>   cmake/CompilationConfigure.cmake 62cb23e81abb2c7e4e8e13c83b45afb98708bd30 
>   configure.ac f274f34e6982beb0a5a683526f7eb9c4ea744e40 
>   docs/configuration/autotools.md 55a5de83729271b043bd1b8de67798ab52b195c6 
>   docs/configuration/cmake.md 554c3bf458bc85609225a19ad4843029772ab51c 
>   src/CMakeLists.txt ef9382dc77d37fed344b7267119f3251acd3088a 
>   src/Makefile.am eff0127a0baa7c112db32aa1bd2b35e0d3cb7aee 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 16149a1428db687b131de08d14893a2dd684ce28 
>   src/slave/containerizer/mesos/isolators/gpu/nvml.hpp 
> eb5c0b008abc651d826c399f4538ad8916469b86 
>   src/slave/containerizer/mesos/isolators/gpu/nvml.cpp 
> 48a5bf6720e5c9a9ceec24740d47c14f0ad097b7 
>   src/tests/environment.cpp c3596fb94020d2433f15e630516b1320875a9fa3 
> 
> 
> Diff: https://reviews.apache.org/r/71538/diff/1/
> 
> 
> Testing
> ---
> 
> * tested toggle both ways in cmake and autotools build
> * wasn't able to test test filter since I don't seem to have access to a dev 
> machine with GPUs
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 71535: Fixed certificate write functions for windows.

2019-09-23 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71535/#review217921
---



Patch looks great!

Reviews applied: [71535]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Sept. 24, 2019, 12:41 a.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71535/
> ---
> 
> (Updated Sept. 24, 2019, 12:41 a.m.)
> 
> 
> Review request for mesos, Greg Mann and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The former implementation failed on Windows. By switching
> to the recommended `BIO_` API for serializing the x509 data
> to disk, we avoid that problem.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/ssl/utilities.cpp 
> c4a8ab4f83939554ca3eb7b4eb86c42c8a539b48 
> 
> 
> Diff: https://reviews.apache.org/r/71535/diff/2/
> 
> 
> Testing
> ---
> 
> Tested "manually" within a private project on Windows.
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>



Re: Review Request 71479: Added a test to ensure resources are recovered during agent removal.

2019-09-23 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71479/#review217920
---



Bad patch!

Reviews applied: [71515, 71516, 71476, 71479]

Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:14.04' 
BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose 
--disable-libtool-wrappers --disable-parallel-test-execution' 
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh 2>&1 | tee 
build_71479"]

Error:
..
6,profile)]:32; disk(allocated: 
role)[MOUNT(,f60c714f-548e-4e79-8c1d-468195360c35,profile)]:32; disk(allocated: 
role)[RAW(,0f722334-91be-4678-a003-d0a67c4ad449,profile)]:32 to cpus(allocated: 
role)(reservations: [(DYNAMIC,role)]):4; mem(allocated: role)(reservations: 
[(DYNAMIC,role)]):128; disk(allocated: role)(reservations: 
[(STATIC,role)]):288; disk(allocated: 
role)[RAW(,0f722334-91be-4678-a003-d0a67c4ad449,profile)]:32; disk(allocated: 
role)[MOUNT(,f60c714f-548e-4e79-8c1d-468195360c35,profile)]:32; disk(allocated: 
role)[BLOCK(,65cce9bf-6a9c-4efc-be65-577f2d01cd06,profile)]:32; disk(allocated: 
role)[RAW(,,profile)]:64; disk(allocated: role)(reservations: 
[(STATIC,role)])[98de50fe-5202-46ad-80fe-c84aeb3e3071:path]:32; disk(allocated: 
role)(reservations: 
[(STATIC,role)])[64a5abd1-0bc2-4810-a2f6-94ace0c56161:path]:64; cpus(allocated: 
role):10; mem(allocated: role):320; disk(allocated: role):64
I0923 22:18:37.979696 18655 hierarchical.cpp:1712] Allocation paused
I0923 22:18:37.980072 18655 hierarchical.cpp:1511] Recovered disk(allocated: 
role)(reservations: [(STATIC,role)]):128 (total: cpus:10; mem:320; disk:64; 
cpus(reservations: [(DYNAMIC,role)]):4; mem(reservations: 
[(DYNAMIC,role)]):128; disk(reservations: [(STATIC,role)]):288; 
disk[RAW(,0f722334-91be-4678-a003-d0a67c4ad449,profile)]:32; 
disk[MOUNT(,f60c714f-548e-4e79-8c1d-468195360c35,profile)]:32; 
disk[BLOCK(,65cce9bf-6a9c-4efc-be65-577f2d01cd06,profile)]:32; 
disk[RAW(,,profile)]:64; disk(reservations: 
[(STATIC,role)])[98de50fe-5202-46ad-80fe-c84aeb3e3071:path]:32; 
disk(reservations: 
[(STATIC,role)])[64a5abd1-0bc2-4810-a2f6-94ace0c56161:path]:64, offered or 
allocated: cpus(allocated: role)(reservations: [(DYNAMIC,role)]):4; 
mem(allocated: role)(reservations: [(DYNAMIC,role)]):128; disk(allocated: 
role)(reservations: [(STATIC,role)]):160; disk(allocated: 
role)[RAW(,0f722334-91be-4678-a003-d0a67c4ad449,profile)]:32; disk(allocated: 
role)[MOUNT(,f60c714f-548e-4e79-8c1d-468195360c35,profil
 e)]:32; disk(allocated: 
role)[BLOCK(,65cce9bf-6a9c-4efc-be65-577f2d01cd06,profile)]:32; disk(allocated: 
role)[RAW(,,profile)]:64; disk(allocated: role)(reservations: 
[(STATIC,role)])[98de50fe-5202-46ad-80fe-c84aeb3e3071:path]:32; disk(allocated: 
role)(reservations: 
[(STATIC,role)])[64a5abd1-0bc2-4810-a2f6-94ace0c56161:path]:64; cpus(allocated: 
role):10; mem(allocated: role):320; disk(allocated: role):64) on agent 
203ec0e6-ac19-4eac-b41f-cc4d8735d8f6-S0 from framework 
203ec0e6-ac19-4eac-b41f-cc4d8735d8f6-
I0923 22:18:37.981135 18655 hierarchical.cpp:1511] Recovered cpus(allocated: 
role)(reservations: [(DYNAMIC,role)]):4; mem(allocated: role)(reservations: 
[(DYNAMIC,role)]):128; disk(allocated: role)(reservations: 
[(STATIC,role)]):160; disk(allocated: 
role)[RAW(,0f722334-91be-4678-a003-d0a67c4ad449,profile)]:32; disk(allocated: 
role)[MOUNT(,f60c714f-548e-4e79-8c1d-468195360c35,profile)]:32; disk(allocated: 
role)[BLOCK(,65cce9bf-6a9c-4efc-be65-577f2d01cd06,profile)]:32; disk(allocated: 
role)[RAW(,,profile)]:64; disk(allocated: role)(reservations: 
[(STATIC,role)])[98de50fe-5202-46ad-80fe-c84aeb3e3071:path]:32; disk(allocated: 
role)(reservations: 
[(STATIC,role)])[64a5abd1-0bc2-4810-a2f6-94ace0c56161:path]:64; cpus(allocated: 
role):10; mem(allocated: role):320; disk(allocated: role):64 (total: cpus:10; 
mem:320; disk:64; cpus(reservations: [(DYNAMIC,role)]):4; mem(reservations: 
[(DYNAMIC,role)]):128; disk(reservations: [(STATIC,role)]):288; 
disk[RAW(,0f722334-91be-4678-a003-d0a67c4ad449,pro
 file)]:32; disk[MOUNT(,f60c714f-548e-4e79-8c1d-468195360c35,profile)]:32; 
disk[BLOCK(,65cce9bf-6a9c-4efc-be65-577f2d01cd06,profile)]:32; 
disk[RAW(,,profile)]:64; disk(reservations: 
[(STATIC,role)])[98de50fe-5202-46ad-80fe-c84aeb3e3071:path]:32; 
disk(reservations: 
[(STATIC,role)])[64a5abd1-0bc2-4810-a2f6-94ace0c56161:path]:64, offered or 
allocated: {}) on agent 203ec0e6-ac19-4eac-b41f-cc4d8735d8f6-S0 from framework 
203ec0e6-ac19-4eac-b41f-cc4d8735d8f6-
I0923 22:18:37.983225 18655 hierarchical.cpp:1560] Framework 
203ec0e6-ac19-4eac-b41f-cc4d8735d8f6- filtered agent 
203ec0e6-ac19-4eac-b41f-cc4d8735d8f6-S0 for 5secs
I0923 22:18:37.983539 18655 hierarchical.cpp:1722] Allocation resumed
I0923 22:18:37.985363 18640 slave.cpp:924] Agent terminating
I0923 22:18:37.985481 18658 master.cpp:1411] Framework 

Re: Review Request 71534: Properly handled quoted HTTP authentication headers.

2019-09-23 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71534/#review217912
---



Patch looks great!

Reviews applied: [71533, 71534]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Sept. 23, 2019, 11:02 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71534/
> ---
> 
> (Updated Sept. 23, 2019, 11:02 a.m.)
> 
> 
> Review request for mesos, Benno Evers, Greg Mann, and Till Toenshoff.
> 
> 
> Bugs: MESOS-9968
> https://issues.apache.org/jira/browse/MESOS-9968
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Properly handled quoted HTTP authentication headers.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/http.hpp 
> 654bbc2221597028b45817b8c3e29dc17515c6fe 
>   3rdparty/libprocess/src/http.cpp 0ed41aaac90dff188c424ded8536df03ab80d2ab 
>   3rdparty/libprocess/src/tests/http_tests.cpp 
> 8cb5f163f2fc34baeabfb1ef640fe39bf6709872 
> 
> 
> Diff: https://reviews.apache.org/r/71534/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 71520: Fixed inefficient `hashmap` access patterns.

2019-09-20 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71520/#review217890
---



Bad patch!

Reviews applied: [71519, 71520]

Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:14.04' 
BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose 
--disable-libtool-wrappers --disable-parallel-test-execution' 
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh 2>&1 | tee 
build_71520"]

Error:
..
ate_manager_process.hpp:929] Checkpointing UPDATE for operation status update 
OPERATION_FINISHED (Status UUID: 940f4d00-6695-45aa-a250-9507c3198a34) for 
operation UUID b3a97398-6410-4b63-b408-0eba2485da8b on agent 
534f9366-0c58-4e2d-9d37-74437bf8caa5-S0
I0920 14:06:46.514657 18812 status_update_manager_process.hpp:528] Forwarding 
operation status update OPERATION_FINISHED (Status UUID: 
940f4d00-6695-45aa-a250-9507c3198a34) for operation UUID 
b3a97398-6410-4b63-b408-0eba2485da8b on agent 
534f9366-0c58-4e2d-9d37-74437bf8caa5-S0
I0920 14:06:46.515743 18811 http_connection.hpp:131] Sending 
UPDATE_OPERATION_STATUS call to 
http://172.17.0.2:46739/slave(1246)/api/v1/resource_provider
I0920 14:06:46.516934 18803 process.cpp:3671] Handling HTTP event for process 
'slave(1246)' with path: '/slave(1246)/api/v1/resource_provider'
I0920 14:06:46.520047 18810 hierarchical.cpp:1786] Performed allocation for 1 
agents in 1.133837ms
I0920 14:06:46.520689 18809 master.cpp:10389] Sending offers [ 
534f9366-0c58-4e2d-9d37-74437bf8caa5-O3 ] to framework 
534f9366-0c58-4e2d-9d37-74437bf8caa5- (default) at 
scheduler-ff3c3bb8-0e3b-4e75-8daa-e248eac71088@172.17.0.2:46739
I0920 14:06:46.521351 18806 sched.cpp:934] Scheduler::resourceOffers took 
73637ns
I0920 14:06:46.524904 18802 process.cpp:3671] Handling HTTP event for process 
'master' with path: '/master/api/v1'
I0920 14:06:46.526823 18811 http.cpp:1115] HTTP POST for /master/api/v1 from 
172.17.0.2:44372
I0920 14:06:46.527076 18811 http.cpp:263] Processing call CREATE_VOLUMES
I0920 14:06:46.527822 18811 master.cpp:3938] Authorizing principal 
'test-principal' to create volumes 
'[{"disk":{"persistence":{"id":"ed7e02f4-402a-4a6b-b044-fd69d9bb8608","principal":"test-principal"},"source":{"id":"/tmp/CSIVersion_StorageLocalResourceProviderTest_OperatorOperationsWithResourceProviderResources_v1_N4Y1bn/2GB-2efda9be-e013-42ab-b96c-16f4db855b5b","mount":{"root":"./csi/org.apache.mesos.csi.test/local/mounts"},"profile":"test","type":"MOUNT","vendor":"org.apache.mesos.csi.test.local"},"volume":{"container_path":"volume","mode":"RW"}},"name":"disk","provider_id":{"value":"ba45d4df-aaea-477f-a68a-dd252d137e90"},"reservations":[{"role":"storage","type":"DYNAMIC"},{"principal":"test-principal","role":"storage/default-role","type":"DYNAMIC"}],"scalar":{"value":2048.0},"type":"SCALAR"}]'
I0920 14:06:46.529150 18810 sched.cpp:960] Rescinded offer 
534f9366-0c58-4e2d-9d37-74437bf8caa5-O3
I0920 14:06:46.529224 18810 sched.cpp:971] Scheduler::offerRescinded took 
23225ns
I0920 14:06:46.529758 18803 master.cpp:12684] Removing offer 
534f9366-0c58-4e2d-9d37-74437bf8caa5-O3
I0920 14:06:46.530614 18809 hierarchical.cpp:1511] Recovered ports(allocated: 
storage/default-role):[31000-32000]; disk(allocated: 
storage/default-role)(reservations: 
[(DYNAMIC,storage),(DYNAMIC,storage/default-role,test-principal)])[MOUNT(org.apache.mesos.csi.test.local,/tmp/CSIVersion_StorageLocalResourceProviderTest_OperatorOperationsWithResourceProviderResources_v1_N4Y1bn/2GB-2efda9be-e013-42ab-b96c-16f4db855b5b,test)]:2048;
 cpus(allocated: storage/default-role):2; mem(allocated: 
storage/default-role):1024; disk(allocated: storage/default-role):1024 (total: 
cpus:2; mem:1024; disk:1024; ports:[31000-32000]; disk(reservations: 
[(DYNAMIC,storage),(DYNAMIC,storage/default-role,test-principal)])[MOUNT(org.apache.mesos.csi.test.local,/tmp/CSIVersion_StorageLocalResourceProviderTest_OperatorOperationsWithResourceProviderResources_v1_N4Y1bn/2GB-2efda9be-e013-42ab-b96c-16f4db855b5b,test)]:2048,
 offered or allocated: {}) on agent 534f9366-0c58-4e2d-9d37-74437bf8caa5-S0 
from framework 534f9
 366-0c58-4e2d-9d37-74437bf8caa5-
I0920 14:06:46.530709 18809 hierarchical.cpp:1558] Framework 
534f9366-0c58-4e2d-9d37-74437bf8caa5- filtered agent 
534f9366-0c58-4e2d-9d37-74437bf8caa5-S0 for 5secs
I0920 14:06:46.532670 18806 master.cpp:12557] Sending operation '' (uuid: 
67fdaabf-1737-4ade-a631-7ac65973a64b) to agent 
534f9366-0c58-4e2d-9d37-74437bf8caa5-S0 at slave(1246)@172.17.0.2:46739 
(6775cde5d992)
I0920 14:06:46.533531 18800 slave.cpp:4352] Ignoring new checkpointed resources 
and operations identical to the current version
I0920 14:06:46.536733 18803 provider.cpp:498] Received APPLY_OPERATION event
I0920 14:06:46.536770 18803 provider.cpp:1351] Received CREATE operation '' 
(uuid: 67fdaabf-1737-4ade-a631-7ac65973a64b)
I0920 

Re: Review Request 71523: Bumped mesos-tidy onto upstream release_90.

2019-09-20 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71523/#review217882
---



Patch looks great!

Reviews applied: [71522, 71523]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Sept. 20, 2019, 7:53 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71523/
> ---
> 
> (Updated Sept. 20, 2019, 7:53 a.m.)
> 
> 
> Review request for mesos and Benno Evers.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Bumped mesos-tidy onto upstream release_90.
> 
> 
> Diffs
> -
> 
>   support/clang-tidy 27879a6eb7b43c767c68315c7d21f007da0c9875 
>   support/mesos-tidy/Dockerfile a6ca38a0396fc48ff9f815d52c675eca2eae9ec8 
> 
> 
> Diff: https://reviews.apache.org/r/71523/diff/1/
> 
> 
> Testing
> ---
> 
> `./support/mesos-tidy.sh` with a locally built image
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 71520: Fixed inefficient `hashmap` access patterns.

2019-09-20 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71520/#review217879
---



Bad review!

Reviews applied: [71520, 71519]

Error:
Circular dependency detected for review 71519.Please fix the 'depends_on' field.

- Mesos Reviewbot


On Sept. 19, 2019, 3:44 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71520/
> ---
> 
> (Updated Sept. 19, 2019, 3:44 p.m.)
> 
> 
> Review request for mesos, Benno Evers and Benjamin Mahler.
> 
> 
> Bugs: MESOS-9948
> https://issues.apache.org/jira/browse/MESOS-9948
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch fixes some inefficient access patterns around `hashmap::get`.
> Since this function returns an `Option` it can be used as a shorthand
> for a `contains` check and subsequent creation of a value (`Option`
> always contains a value). It was never not intended and is inefficient
> as `contains` itself (e.g., via `hashmap::get::isSome`), and for cases
> where only access to parts of the value in the `hashmap` is required
> (e.g., to access a member of an optional value). In both these cases we
> neither want nor need to create a temporary, and should instead either
> just use `contains`, or access the value with `hashmap::at` after a
> `contains` check; otherwise we might spend a lot of time creating
> unnecessary temporary values.
> 
> This patch fixes some easily identifiable cases found from skimming the
> result of the following clang-query command:
> 
> match cxxMemberCallExpr(
>   on(hasType(cxxRecordDecl(hasName("hashmap",
>   unless(
> hasParent(cxxBindTemporaryExpr(
>   hasParent(materializeTemporaryExpr(
> hasParent(exprWithCleanups(
>   hasParent(varDecl(),
>   callee(cxxMethodDecl(hasName("get"
> 
> This most probably misses a lot of cases. Given how easy it is to misuse
> `hashmap::get` we should consider whether it makes sense to get rid of
> it completely in lieu of an inlined form trading some additional lookups
> for temporary avoidance,
> 
> Option x = map.contains(k) ? Some(map.at(k)) : Option::none();
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/metrics/metrics.cpp 
> 623d44adbe838f995ddbe89ee26f5bcc9c600be5 
> 
> 
> Diff: https://reviews.apache.org/r/71520/diff/2/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 71518: Added the test `GarbageCollectorIntegrationTest.ROOT_OrphanContainer`.

2019-09-19 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71518/#review217876
---



Patch looks great!

Reviews applied: [71501, 71518]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Sept. 20, 2019, 3:06 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71518/
> ---
> 
> (Updated Sept. 20, 2019, 3:06 a.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-9966
> https://issues.apache.org/jira/browse/MESOS-9966
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added the test `GarbageCollectorIntegrationTest.ROOT_OrphanContainer`.
> 
> 
> Diffs
> -
> 
>   src/tests/gc_tests.cpp 2ea4bcb668e1fcbeb9c598053e4df4d54d17711d 
> 
> 
> Diff: https://reviews.apache.org/r/71518/diff/2/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> This test will fail without the previous patch r/71501.
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>



Re: Review Request 71479: Added a test to ensure resources are recovered during agent removal.

2019-09-19 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71479/#review217875
---



Patch looks great!

Reviews applied: [71515, 71516, 71476, 71479]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Sept. 12, 2019, 10:51 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71479/
> ---
> 
> (Updated Sept. 12, 2019, 10:51 p.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
> 
> 
> Bugs: MESOS-621
> https://issues.apache.org/jira/browse/MESOS-621
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a test to ensure resources are recovered during agent removal.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> 5f2e2b259af9920133dd22a5b03774d7035821dc 
> 
> 
> Diff: https://reviews.apache.org/r/71479/diff/1/
> 
> 
> Testing
> ---
> 
> Failed on master.
> Pass after r/71476
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>



Re: Review Request 71512: Windows: Libprocess: Fixed parallel test execution.

2019-09-19 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71512/#review217870
---



Patch looks great!

Reviews applied: [71510, 71511, 71512]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Sept. 19, 2019, 6:30 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71512/
> ---
> 
> (Updated Sept. 19, 2019, 6:30 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Greg Mann, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> For the test runner script to find the executable now, it needs
> to be given the configuration and the file extension.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/tests/CMakeLists.txt 
> b4ec9907d16c89b45562f4fa33c9f3d2913f6991 
> 
> 
> Diff: https://reviews.apache.org/r/71512/diff/2/
> 
> 
> Testing
> ---
> 
> cmake --build . --target check (Windows)
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>



Re: Review Request 71497: Introduced new names for SSL-related libprocess flags.

2019-09-19 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71497/#review217865
---



Patch looks great!

Reviews applied: [71496, 71497]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Sept. 19, 2019, 2:35 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71497/
> ---
> 
> (Updated Sept. 19, 2019, 2:35 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Till Toenshoff.
> 
> 
> Bugs: MESOS-9972
> https://issues.apache.org/jira/browse/MESOS-9972
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The `LIBPROCESS_SSL_REQUIRE_CERT` flag was renamed to
> `LIBPROCESS_SSL_REQUIRE_CLIENT_CERT`.
> 
> The `LIBPROCESS_SSL_VERIFY_CERT` flag was renamed to
> `LIBPROCESS_SSL_VERIFY_SERVER_CERT`.
> 
> The new names better describe the actual effect of both flags, and
> make upgrades easier by allowing operators to only enable verification
> on agents that are new enough to contain the updated hostname
> validation code paths.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/ssl/flags.hpp 
> 1a0e3820cc8cd1459625f46a54b194133500f11e 
>   3rdparty/libprocess/src/openssl.hpp 
> 271cc95238d287c06df36478554502e8b7205b09 
>   3rdparty/libprocess/src/openssl.cpp 
> 5854711971c9ebc4d676edc43af5ab5cfd5ea4c6 
>   3rdparty/libprocess/src/tests/ssl_tests.cpp 
> 9d5ab679165a709f7c3740020961ec89a7db4f54 
>   docs/ssl.md 90a2eb9800b7d8d9aa9d7b1060a6e5eb9e124b02 
>   docs/upgrades.md e630731c332fdd7df788f96644a8084f30b5c621 
> 
> 
> Diff: https://reviews.apache.org/r/71497/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>



Re: Review Request 71520: Fixed inefficient `hashmap` access patterns.

2019-09-19 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71520/#review217860
---



Patch looks great!

Reviews applied: [71519, 71520]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Sept. 19, 2019, 6:44 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71520/
> ---
> 
> (Updated Sept. 19, 2019, 6:44 a.m.)
> 
> 
> Review request for mesos, Benno Evers and Benjamin Mahler.
> 
> 
> Bugs: MESOS-9948
> https://issues.apache.org/jira/browse/MESOS-9948
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch fixes some inefficient access patterns around `hashmap::get`.
> Since this function returns an `Option` it can be used as a shorthand
> for a `contains` check and subsequent creation of a value (`Option`
> always contains a value). It was never not intended and is inefficient
> for `contains` itself (e.g., via `hashmap::get::isSome`), and for cases
> where only access to parts of the value in the `hashmap` is required
> (e.g., to read a member of an optional value). In both these cases we
> neither want nor need to create a temporary, and should instead either
> just use `contains`, or access the value with `hashmap::at` after a
> `contains` check since otherwise we might spend a lot of time creating
> unnecessary temporary values.
> 
> This patch fixes some easily identifiable case found by manually
> grooming the result of the following clang-query command:
> 
> match cxxMemberCallExpr(
>   on(hasType(cxxRecordDecl(hasName("hashmap",
>   unless(
> hasParent(cxxBindTemporaryExpr(
>   hasParent(materializeTemporaryExpr(
> hasParent(exprWithCleanups(
>   hasParent(varDecl(),
>   callee(cxxMethodDecl(hasName("get"
> 
> This most probably misses a lot of cases. Given how easy it is to
> misuse `hashmap::get` we should consider whether it makes sense to get
> rid of it completely in lie of an inlined form trading some additional
> lookups for temporary avoidance,
> 
> Option x = map.contains(k) ? Some(map.at(k)) : Option::none();
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/metrics/metrics.cpp 
> 623d44adbe838f995ddbe89ee26f5bcc9c600be5 
> 
> 
> Diff: https://reviews.apache.org/r/71520/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 71518: Added the test `GarbageCollectorIntegrationTest.OrphanContainer`.

2019-09-19 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71518/#review217854
---



Bad patch!

Reviews applied: [71501, 71518]

Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:14.04' 
BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose 
--disable-libtool-wrappers --disable-parallel-test-execution' 
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh 2>&1 | tee 
build_71518"]

Error:
..
located: storage/default-role):2; mem(allocated: storage/default-role):1024; 
disk(allocated: storage/default-role):1024 (total: cpus:2; mem:1024; disk:1024; 
ports:[31000-32000]; disk(reservations: 
[(DYNAMIC,storage),(DYNAMIC,storage/default-role,test-principal)])[MOUNT(org.apache.mesos.csi.test.local,/tmp/CSIVersion_StorageLocalResourceProviderTest_OperatorOperationsWithResourceProviderResources_v1_zHLLLc/2GB-c042af93-66e7-4215-af26-72013ff85317,test)]:2048,
 offered or allocated: {}) on agent 36c92ce8-38aa-4a77-a380-06d69b1beebc-S0 
from framework 36c92ce8-38aa-4a77-a380-06d69b1beebc-
I0919 14:44:25.709256 18652 hierarchical.cpp:1558] Framework 
36c92ce8-38aa-4a77-a380-06d69b1beebc- filtered agent 
36c92ce8-38aa-4a77-a380-06d69b1beebc-S0 for 5secs
I0919 14:44:25.711563 18634 master.cpp:12557] Sending operation '' (uuid: 
6ff76f8a-681e-4043-b580-a52aa2c6d2c7) to agent 
36c92ce8-38aa-4a77-a380-06d69b1beebc-S0 at slave(1248)@172.17.0.3:44477 
(1b384509bb52)
I0919 14:44:25.712173 18650 slave.cpp:4352] Ignoring new checkpointed resources 
and operations identical to the current version
I0919 14:44:25.715298 18639 provider.cpp:498] Received APPLY_OPERATION event
I0919 14:44:25.715380 18639 provider.cpp:1351] Received CREATE operation '' 
(uuid: 6ff76f8a-681e-4043-b580-a52aa2c6d2c7)
I0919 14:44:25.721730 18638 master.cpp:6398] Processing REVIVE call for 
framework 36c92ce8-38aa-4a77-a380-06d69b1beebc- (default) at 
scheduler-d265b96b-d3b0-40b3-9a28-427d737db487@172.17.0.3:44477
I0919 14:44:25.70 18631 hierarchical.cpp:1654] Unsuppressed offers and 
cleared filters for roles { storage/default-role } of framework 
36c92ce8-38aa-4a77-a380-06d69b1beebc-
I0919 14:44:25.723402 18631 hierarchical.cpp:1786] Performed allocation for 1 
agents in 996549ns
I0919 14:44:25.723737 18631 hierarchical.cpp:1786] Performed allocation for 1 
agents in 145181ns
I0919 14:44:25.724021 18637 master.cpp:10389] Sending offers [ 
36c92ce8-38aa-4a77-a380-06d69b1beebc-O4 ] to framework 
36c92ce8-38aa-4a77-a380-06d69b1beebc- (default) at 
scheduler-d265b96b-d3b0-40b3-9a28-427d737db487@172.17.0.3:44477
I0919 14:44:25.724589 18648 sched.cpp:934] Scheduler::resourceOffers took 
76312ns
I0919 14:44:25.732537 18654 http.cpp:1115] HTTP POST for 
/slave(1248)/api/v1/resource_provider from 172.17.0.3:55102
I0919 14:44:25.733646 18650 slave.cpp:8482] Handling resource provider message 
'UPDATE_OPERATION_STATUS: (uuid: 18778154-fd20-4e09-ada8-d19502ac05ca) for 
framework  (latest state: OPERATION_FINISHED, status update state: 
OPERATION_FINISHED)'
I0919 14:44:25.733819 18650 slave.cpp:8935] Updating the state of operation 
with no ID (uuid: 18778154-fd20-4e09-ada8-d19502ac05ca) for an operation API 
call (latest state: OPERATION_FINISHED, status update state: OPERATION_FINISHED)
I0919 14:44:25.733873 18650 slave.cpp:8689] Forwarding status update of 
operation with no ID (operation_uuid: 18778154-fd20-4e09-ada8-d19502ac05ca) for 
an operator API call
I0919 14:44:25.734203 18632 master.cpp:12213] Updating the state of operation 
'' (uuid: 18778154-fd20-4e09-ada8-d19502ac05ca) for an operator API call 
(latest state: OPERATION_PENDING, status update state: OPERATION_FINISHED)
I0919 14:44:25.734715 18651 slave.cpp:4352] Ignoring new checkpointed resources 
and operations identical to the current version
I0919 14:44:25.802605 18648 status_update_manager_process.hpp:152] Received 
operation status update OPERATION_FINISHED (Status UUID: 
80541db7-67e3-4040-89d6-cc2d45370739) for operation UUID 
6ff76f8a-681e-4043-b580-a52aa2c6d2c7 on agent 
36c92ce8-38aa-4a77-a380-06d69b1beebc-S0
I0919 14:44:25.802673 18648 status_update_manager_process.hpp:414] Creating 
operation status update stream 6ff76f8a-681e-4043-b580-a52aa2c6d2c7 
checkpoint=true
I0919 14:44:25.802695 18639 provider.cpp:498] Received 
ACKNOWLEDGE_OPERATION_STATUS event
I0919 14:44:25.802994 18648 status_update_manager_process.hpp:929] 
Checkpointing UPDATE for operation status update OPERATION_FINISHED (Status 
UUID: 80541db7-67e3-4040-89d6-cc2d45370739) for operation UUID 
6ff76f8a-681e-4043-b580-a52aa2c6d2c7 on agent 
36c92ce8-38aa-4a77-a380-06d69b1beebc-S0
I0919 14:44:25.852852 18648 status_update_manager_process.hpp:528] Forwarding 
operation status update OPERATION_FINISHED (Status UUID: 
80541db7-67e3-4040-89d6-cc2d45370739) for operation UUID 
6ff76f8a-681e-4043-b580-a52aa2c6d2c7 on 

Re: Review Request 71441: Fixed URI stringification.

2019-09-19 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71441/#review217847
---



Patch looks great!

Reviews applied: [71441]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Sept. 19, 2019, 5:11 a.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71441/
> ---
> 
> (Updated Sept. 19, 2019, 5:11 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-9963
> https://issues.apache.org/jira/browse/MESOS-9963
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> If the caller is not careful to ensure that the path component begins
> with '/', stringification of URI objects will concatenate the host and
> path, resulting in an malformed URI. The fix is to ensure that these
> fields are always separated by '/'.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_spec_tests.cpp 
> 4be0716895132e0406299f7d77f8ceb2d95dbe8a 
>   src/tests/uri_tests.cpp 1d33ab110bed7c0b7ecfa5d608965da5a1729562 
>   src/uri/utils.cpp 3940dc041c1783eec9e7c950402fd7c42e620d8e 
> 
> 
> Diff: https://reviews.apache.org/r/71441/diff/3/
> 
> 
> Testing
> ---
> 
> make check (Fedora 30)
> 
> 
> Thanks,
> 
> James Peach
> 
>



Re: Review Request 71516: Refactored framework role tracking logic in the allocator.

2019-09-18 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71516/#review217845
---



Patch looks great!

Reviews applied: [71515, 71516]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Sept. 19, 2019, 3:41 a.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71516/
> ---
> 
> (Updated Sept. 19, 2019, 3:41 a.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> A framework is tracked under the role if the framework:
> (1) is subscribed to the role;
> Or
> (2) has resources allocated under the role.
> 
> (2) could be true without (1). This is because we allow
> frameworks to update their roles without revoking their
> allocated or offered resources.
> 
> This patch recognizes this fact and encapsulates the related
> checks in the helper.
> 
> Benchmark result: no major performance impact.
> 
> Master
> 
> BENCHMARK_HierarchicalAllocator_WithQuotaParam.LargeAndSmallQuota/2
> Added 3000 agents in 90.816373ms
> Added 3000 frameworks in 17.202199348secs
> Made 3500 allocations in 15.46714944secs
> Made 0 allocation in 13.767830924secs
> 
> Master + this patch:
> 
> BENCHMARK_HierarchicalAllocator_WithQuotaParam.LargeAndSmallQuota/2
> Added 3000 agents in 86.782773ms
> Added 3000 frameworks in 18.174924815secs
> Made 3500 allocations in 15.813011454secs
> Made 0 allocation in 12.882917161secs
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> 5ea37912dadded47eaa2d354889c95533b191c59 
>   src/master/allocator/mesos/hierarchical.cpp 
> 256fdce61ccfb768605cac1579c9a6632cd26fec 
> 
> 
> Diff: https://reviews.apache.org/r/71516/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>



Re: Review Request 71512: Windows: Libprocess: Fixed parallel test execution.

2019-09-18 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71512/#review217842
---



Patch looks great!

Reviews applied: [71510, 71511, 71512]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Sept. 18, 2019, 11 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71512/
> ---
> 
> (Updated Sept. 18, 2019, 11 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Greg Mann, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> For the test runner script to find the executable now, it needs
> to be given the configuration and the file extension.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/tests/CMakeLists.txt 
> b4ec9907d16c89b45562f4fa33c9f3d2913f6991 
> 
> 
> Diff: https://reviews.apache.org/r/71512/diff/1/
> 
> 
> Testing
> ---
> 
> cmake --build . --target check (Windows)
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>



Re: Review Request 71488: Track per-role allocated resources in the roles tree.

2019-09-18 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71488/#review217839
---



Bad patch!

Reviews applied: [71486, 71487, 71488]

Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:14.04' 
BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose 
--disable-libtool-wrappers --disable-parallel-test-execution' 
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh 2>&1 | tee 
build_71488"]

Error:
..
ll_timeout="1mins" --frameworks_home="/tmp/rNv7BZ/ecy48u/frameworks" 
--gc_delay="1weeks" --gc_disk_headroom="0.1" 
--gc_non_executor_container_sandboxes="false" --help="false" 
--hostname_lookup="true" --http_command_executor="false" 
--http_credentials="/tmp/rNv7BZ/ecy48u/http_credentials" 
--http_heartbeat_interval="30secs" --initialize_driver_logging="true" 
--isolation="posix/cpu,posix/mem" --launcher="posix" 
--launcher_dir="/mesos/mesos-1.10.0/_build/src" --logbufsecs="0" 
--logging_level="INFO" --max_completed_executors_per_framework="150" 
--memory_profiling="false" --network_cni_metrics="true" 
--network_cni_root_dir_persist="false" 
--oversubscribed_resources_interval="15secs" --perf_duration="10secs" 
--perf_interval="1mins" --port="5051" --qos_correction_interval_min="0ns" 
--quiet="false" --reconfiguration_policy="equal" --recover="reconnect" 
--recovery_timeout="15mins" --registration_backoff_factor="10ms" 
--resources="cpus:2;gpus:0;mem:1024;disk:1024;ports:[31000-32000]" --revocabl
 e_cpu_low_priority="true" 
--runtime_dir="/tmp/ContentType_OperationReconciliationTest_UnknownOperationAgentMarkedGone_0_xlS3XZ"
 --sandbox_directory="/mnt/mesos/sandbox" --strict="true" --switch_user="true" 
--systemd_enable_support="true" 
--systemd_runtime_directory="/run/systemd/system" --version="false" 
--work_dir="/tmp/ContentType_OperationReconciliationTest_UnknownOperationAgentMarkedGone_0_38i4Mu"
 --zk_session_timeout="10secs"
I0918 23:35:19.574690 18657 credentials.hpp:86] Loading credential for 
authentication from '/tmp/rNv7BZ/ecy48u/credential'
I0918 23:35:19.575434 18657 slave.cpp:300] Agent using credential for: 
test-principal
I0918 23:35:19.575819 18657 credentials.hpp:37] Loading credentials for 
authentication from '/tmp/rNv7BZ/ecy48u/http_credentials'
I0918 23:35:19.576562 18657 http.cpp:975] Creating default 'basic' HTTP 
authenticator for realm 'mesos-agent-readonly'
I0918 23:35:19.577693 18657 disk_profile_adaptor.cpp:78] Creating default disk 
profile adaptor module
I0918 23:35:19.580186 18657 slave.cpp:615] Agent resources: 
[{"name":"cpus","scalar":{"value":2.0},"type":"SCALAR"},{"name":"mem","scalar":{"value":1024.0},"type":"SCALAR"},{"name":"disk","scalar":{"value":1024.0},"type":"SCALAR"},{"name":"ports","ranges":{"range":[{"begin":31000,"end":32000}]},"type":"RANGES"}]
I0918 23:35:19.581109 18657 slave.cpp:623] Agent attributes: [  ]
I0918 23:35:19.581487 18657 slave.cpp:632] Agent hostname: 905683fb3805
I0918 23:35:19.583003 18658 task_status_update_manager.cpp:181] Pausing sending 
task status updates
I0918 23:35:19.583117 18658 status_update_manager_process.hpp:379] Pausing 
operation status update manager
I0918 23:35:19.585777 18648 state.cpp:67] Recovering state from 
'/tmp/ContentType_OperationReconciliationTest_UnknownOperationAgentMarkedGone_0_38i4Mu/meta'
I0918 23:35:19.586390 18648 slave.cpp:7492] Finished recovering checkpointed 
state from 
'/tmp/ContentType_OperationReconciliationTest_UnknownOperationAgentMarkedGone_0_38i4Mu/meta',
 beginning agent recovery
I0918 23:35:19.587337 18648 task_status_update_manager.cpp:207] Recovering task 
status update manager
I0918 23:35:19.588311 18648 containerizer.cpp:821] Recovering Mesos containers
I0918 23:35:19.589103 18648 containerizer.cpp:1161] Recovering isolators
I0918 23:35:19.590978 18660 containerizer.cpp:1200] Recovering provisioner
I0918 23:35:19.592371 18660 provisioner.cpp:500] Provisioner recovery complete
I0918 23:35:19.594522 18649 composing.cpp:339] Finished recovering all 
containerizers
I0918 23:35:19.594980 18665 slave.cpp:7973] Recovering executors
I0918 23:35:19.595139 18665 slave.cpp:8126] Finished recovery
I0918 23:35:19.596966 18662 task_status_update_manager.cpp:181] Pausing sending 
task status updates
I0918 23:35:19.597014 18656 slave.cpp:1351] New master detected at 
master@172.17.0.2:34081
I0918 23:35:19.598083 18656 slave.cpp:1416] Detecting new master
I0918 23:35:19.597108 18663 status_update_manager_process.hpp:379] Pausing 
operation status update manager
I0918 23:35:19.599468 18661 slave.cpp:1443] Authenticating with master 
master@172.17.0.2:34081
I0918 23:35:19.599647 18661 slave.cpp:1452] Using default CRAM-MD5 authenticatee
I0918 23:35:19.600613 18661 authenticatee.cpp:121] Creating new client SASL 
connection
I0918 23:35:19.601212 18661 master.cpp:10590] Authenticating 
slave(1047)@172.17.0.2:34081
I0918 

Re: Review Request 71497: Introduced new names for SSL-related libprocess flags.

2019-09-18 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71497/#review217834
---



Patch looks great!

Reviews applied: [71496, 71497]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Sept. 18, 2019, 12:35 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71497/
> ---
> 
> (Updated Sept. 18, 2019, 12:35 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Till Toenshoff.
> 
> 
> Bugs: MESOS-9972
> https://issues.apache.org/jira/browse/MESOS-9972
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The `LIBPROCESS_SSL_REQUIRE_CERT` flag was renamed to
> `LIBPROCESS_SSL_REQUIRE_CLIENT_CERT`.
> 
> The `LIBPROCESS_SSL_VERIFY_CERT` flag was renamed to
> `LIBPROCESS_SSL_VERIFY_SERVER_CERT`.
> 
> The new names better describe the actual effect of both flags, and
> make upgrades easier by allowing operators to only enable verification
> on agents that are new enough to contain the updated hostname
> validation code paths.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/ssl/flags.hpp 
> 1a0e3820cc8cd1459625f46a54b194133500f11e 
>   3rdparty/libprocess/src/openssl.hpp 
> 271cc95238d287c06df36478554502e8b7205b09 
>   3rdparty/libprocess/src/openssl.cpp 
> 5854711971c9ebc4d676edc43af5ab5cfd5ea4c6 
>   3rdparty/libprocess/src/tests/ssl_tests.cpp 
> 9d5ab679165a709f7c3740020961ec89a7db4f54 
>   docs/ssl.md 90a2eb9800b7d8d9aa9d7b1060a6e5eb9e124b02 
>   docs/upgrades.md e630731c332fdd7df788f96644a8084f30b5c621 
> 
> 
> Diff: https://reviews.apache.org/r/71497/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>



Re: Review Request 71498: Introduced a role tree helper to modify a role and all its ancestors.

2019-09-18 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71498/#review217828
---



Patch looks great!

Reviews applied: [71489, 71486, 71487, 71488, 71490, 71491, 71498]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Sept. 18, 2019, 12:59 p.m., Andrei Sekretenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71498/
> ---
> 
> (Updated Sept. 18, 2019, 12:59 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Meng Zhu.
> 
> 
> Bugs: MESOS-9949
> https://issues.apache.org/jira/browse/MESOS-9949
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Introduced a role tree helper to modify a role and all its ancestors.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> 5ea37912dadded47eaa2d354889c95533b191c59 
>   src/master/allocator/mesos/hierarchical.cpp 
> 256fdce61ccfb768605cac1579c9a6632cd26fec 
> 
> 
> Diff: https://reviews.apache.org/r/71498/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>



Re: Review Request 71179: WIP: Added a flag for running example framework with a list of roles.

2019-09-18 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71179/#review217821
---



Bad review!

Reviews applied: []

Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing 
list.

- Mesos Reviewbot


On July 29, 2019, 4:44 p.m., Andrei Sekretenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71179/
> ---
> 
> (Updated July 29, 2019, 4:44 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-8503
> https://issues.apache.org/jira/browse/MESOS-8503
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> WIP: Added a flag for running example framework with a list of roles.
> 
> 
> Diffs
> -
> 
>   src/examples/long_lived_framework.cpp 
> 621a5ca973640b810d429827dacf4ab72cfebbb8 
> 
> 
> Diff: https://reviews.apache.org/r/71179/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>



Re: Review Request 71501: Gc'ed nested container sandbox only if we have root container sandbox.

2019-09-18 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71501/#review217815
---



Patch looks great!

Reviews applied: [71501]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Sept. 18, 2019, 10:49 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71501/
> ---
> 
> (Updated Sept. 18, 2019, 10:49 a.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-9966
> https://issues.apache.org/jira/browse/MESOS-9966
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Gc'ed nested container sandbox only if we have root container sandbox.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 16149a1428db687b131de08d14893a2dd684ce28 
> 
> 
> Diff: https://reviews.apache.org/r/71501/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>



Re: Review Request 71498: Introduced a role tree helper to modify a role and all its ancestors.

2019-09-17 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71498/#review217794
---



Patch looks great!

Reviews applied: [71489, 71486, 71487, 71488, 71490, 71491, 71498]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Sept. 17, 2019, 1:25 p.m., Andrei Sekretenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71498/
> ---
> 
> (Updated Sept. 17, 2019, 1:25 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Meng Zhu.
> 
> 
> Bugs: MESOS-9949
> https://issues.apache.org/jira/browse/MESOS-9949
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Introduced a role tree helper to modify a role and all its ancestors.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> 5ea37912dadded47eaa2d354889c95533b191c59 
>   src/master/allocator/mesos/hierarchical.cpp 
> 256fdce61ccfb768605cac1579c9a6632cd26fec 
> 
> 
> Diff: https://reviews.apache.org/r/71498/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>



Re: Review Request 65042: Adjusted CSI example framework for recent changes.

2019-09-17 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65042/#review217790
---



Patch looks great!

Reviews applied: [64932, 65042]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Sept. 17, 2019, 1 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65042/
> ---
> 
> (Updated Sept. 17, 2019, 1 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adjusts the CSI example framework for recent cleanups to
> example frameworks. It now uses generic flag classes which can e.g.,
> parse from both the environment and the command line.
> 
> 
> Diffs
> -
> 
>   src/examples/test_csi_user_framework.cpp 
> 1bf5d14859be5ec4e7ff351ab34a9b5752080146 
> 
> 
> Diff: https://reviews.apache.org/r/65042/diff/4/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 71497: Introduced new names for SSL-related libprocess flags.

2019-09-17 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71497/#review217786
---



Patch looks great!

Reviews applied: [71496, 71497]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Sept. 17, 2019, 12:50 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71497/
> ---
> 
> (Updated Sept. 17, 2019, 12:50 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The `LIBPROCESS_SSL_REQUIRE_CERT` flag was renamed to
> `LIBPROCESS_SSL_REQUIRE_CLIENT_CERT`.
> 
> The `LIBPROCESS_SSL_VERIFY_CERT` flag was renamed to
> `LIBPROCESS_SSL_VERIFY_SERVER_CERT`.
> 
> The new names better describe the actual effect of both flags, and
> make upgrades easier by allowing operators to only enable verification
> on agents that are new enough to contain the updated hostname
> validation code paths.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/ssl/flags.hpp 
> 1a0e3820cc8cd1459625f46a54b194133500f11e 
>   3rdparty/libprocess/src/openssl.hpp 
> 271cc95238d287c06df36478554502e8b7205b09 
>   3rdparty/libprocess/src/openssl.cpp 
> 5854711971c9ebc4d676edc43af5ab5cfd5ea4c6 
>   3rdparty/libprocess/src/tests/ssl_tests.cpp 
> 9d5ab679165a709f7c3740020961ec89a7db4f54 
>   docs/ssl.md 90a2eb9800b7d8d9aa9d7b1060a6e5eb9e124b02 
> 
> 
> Diff: https://reviews.apache.org/r/71497/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>



Re: Review Request 71494: Removed documentation on cquery.

2019-09-17 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71494/#review217780
---



Patch looks great!

Reviews applied: [71494]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Sept. 17, 2019, 7:44 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71494/
> ---
> 
> (Updated Sept. 17, 2019, 7:44 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benno Evers, and Till 
> Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Cquery is not developed anymore and being replaced by larger LSP
> implementation such as clangd. This patch completely removes any
> cquery-related documentation instead of updating it to use e.g., clangd.
> This is because any documentation related to setting up a LSP pipeline
> would be almost exclusively generic to a CMake C++ project and not
> specific to Mesos.
> 
> 
> Diffs
> -
> 
>   docs/cquery.md b893bc522561306a2cdf15e1c1876108ec8d329c 
>   docs/developer-guide.md 3906275e18801853bd21da18073c9f0e44aba2cd 
> 
> 
> Diff: https://reviews.apache.org/r/71494/diff/1/
> 
> 
> Testing
> ---
> 
> Test-rendered the documentation
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 71481: Added some extra ASSERTs to a role test.

2019-09-13 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71481/#review217719
---



Patch looks great!

Reviews applied: [71481]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Sept. 13, 2019, 12:48 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71481/
> ---
> 
> (Updated Sept. 13, 2019, 12:48 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Greg Mann, and Meng Zhu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> These asserts technically aren't required, since subsequent
> awaiting for offers assumes that the agents are created successfully.
> However, it seems useful to fail a bit earlier if the agent creation
> happens to fail.
> 
> 
> Diffs
> -
> 
>   src/tests/role_tests.cpp d6cc31bf89954c5a440142b378560cdc0286df23 
> 
> 
> Diff: https://reviews.apache.org/r/71481/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>



Re: Review Request 71480: Fixed a bug for non-partition-aware schedulers.

2019-09-12 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71480/#review217716
---



Patch looks great!

Reviews applied: [71480]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Sept. 12, 2019, 11:18 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71480/
> ---
> 
> (Updated Sept. 12, 2019, 11:18 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Joseph Wu, and Vinod Kone.
> 
> 
> Bugs: MESOS-9965
> https://issues.apache.org/jira/browse/MESOS-9965
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previously, the agent would send task status updates with the state
> TASK_GONE_BY_OPERATOR to all schedulers when an agent was drained
> with the `mark_gone` parameter set to `true`.
> 
> This patch updates this code to ensure that TASK_GONE_BY_OPERATOR
> is only sent to partition-aware schedulers.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp 4e9365669395c89202961ca80d41cd92346d23d2 
>   src/tests/slave_tests.cpp 02b65a925a52d09b0a9183d3288b9ab363b98bc5 
> 
> 
> Diff: https://reviews.apache.org/r/71480/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>



Re: Review Request 71479: Added a test to ensure resources are recovered during agent removal.

2019-09-12 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71479/#review217715
---



Patch looks great!

Reviews applied: [71459, 71460, 71476, 71479]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Sept. 12, 2019, 10:51 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71479/
> ---
> 
> (Updated Sept. 12, 2019, 10:51 p.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
> 
> 
> Bugs: MESOS-621
> https://issues.apache.org/jira/browse/MESOS-621
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a test to ensure resources are recovered during agent removal.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> 5f2e2b259af9920133dd22a5b03774d7035821dc 
> 
> 
> Diff: https://reviews.apache.org/r/71479/diff/1/
> 
> 
> Testing
> ---
> 
> Failed on master.
> Pass after r/71476
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>



Re: Review Request 71478: Windows: Moved definition out of inline function call.

2019-09-12 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71478/#review217711
---



Patch looks great!

Reviews applied: [71478]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Sept. 12, 2019, 7:35 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71478/
> ---
> 
> (Updated Sept. 12, 2019, 7:35 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MSVC does not deal with #ifdefs from inside function calls.
> So here, the `#if defined(...)` was taken literally and is
> considered a syntax error by MSVC.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/openssl.cpp 
> 5854711971c9ebc4d676edc43af5ab5cfd5ea4c6 
> 
> 
> Diff: https://reviews.apache.org/r/71478/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>



Re: Review Request 71440: Improved allocator inverse offer test.

2019-09-12 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71440/#review217708
---



Patch looks great!

Reviews applied: [68507, 68508, 71428, 71440]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Sept. 5, 2019, 9:12 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71440/
> ---
> 
> (Updated Sept. 5, 2019, 9:12 p.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The test is augmented to also check that a framework that
> declined offers from an agent will not get inverse offers
> for that agent.
> 
> 
> Diffs
> -
> 
>   src/tests/hierarchical_allocator_tests.cpp 
> 2c1d0fe2e3ac08e6443cf8348bb72ac7dae454a8 
> 
> 
> Diff: https://reviews.apache.org/r/71440/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>



Re: Review Request 71445: Removed race in `StorageLocalResourceProviderTest.Update`.

2019-09-12 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71445/#review217701
---



Patch looks great!

Reviews applied: [71445]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Sept. 12, 2019, 9:01 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71445/
> ---
> 
> (Updated Sept. 12, 2019, 9:01 a.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The agent might take some time before registering with the master which
> could have lead to unexpected retries in this test which the clock was
> resumed. This patch simplifies the test so we do not rely on
> `UpdateSlaveMessage` anymore.
> 
> 
> Diffs
> -
> 
>   src/tests/storage_local_resource_provider_tests.cpp 
> 089aa9787a66d737267179ad461be0c0a99d5c63 
> 
> 
> Diff: https://reviews.apache.org/r/71445/diff/2/
> 
> 
> Testing
> ---
> 
> * `make check`
> * ran test fixed here in repetition under external stress. Previous failure 
> rate ~6%, no failures in >5k runs after
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 71460: Tracked offered and allocated resources in the role tree.

2019-09-11 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71460/#review217697
---



Patch looks great!

Reviews applied: [71459, 71460]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Sept. 11, 2019, 10:52 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71460/
> ---
> 
> (Updated Sept. 11, 2019, 10:52 p.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This helpers simplify the quota tracking logic and also paves
> the way to reduce duplicated states in the sorter.
> 
> Also documented that shared resources must be uniquely
> identifiable.
> 
> Small performance degradation when making allocations due to
> duplicated map construction in `(un)trackAllocatedResources`.
> This will be removed once embeded the sorter in the role tree.
> 
> Benchmark `LargeAndSmallQuota/2`:
> 
> Master:
> 
> Added 3000 agents in 80.648188ms
> Added 3000 frameworks in 19.7006984secs
> Benchmark setup: 3000 agents, 3000 roles, 3000 frameworks,
> with drf sorter
> Made 3500 allocations in 16.044274434secs
> Made 0 allocation in 14.476429451secs
> 
> Master + this patch:
> Added 3000 agents in 80.110817ms
> Added 3000 frameworks in 17.25974094secs
> Benchmark setup: 3000 agents, 3000 roles, 3000 frameworks,
> with drf sorter
> Made 3500 allocations in 16.91971379secs
> Made 0 allocation in 13.784476154secs
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 8fd838e96228daacb0a1c0f4890fd3630841ab52 
>   include/mesos/v1/mesos.proto da19256cbb53215dc6f51d809ad214683ea153cf 
>   src/master/allocator/mesos/hierarchical.hpp 
> 48ba399e12129b3348b5c43b793f3428acf26d4e 
>   src/master/allocator/mesos/hierarchical.cpp 
> 187de173ee2f563e2ff0f7e5c96695dd94a73970 
> 
> 
> Diff: https://reviews.apache.org/r/71460/diff/3/
> 
> 
> Testing
> ---
> 
> make check
> Benchmark result in the description
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>



Re: Review Request 71464: Allowed setting quota the default "*" role.

2019-09-10 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71464/#review217684
---



Patch looks great!

Reviews applied: [71464]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Sept. 10, 2019, 6:56 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71464/
> ---
> 
> (Updated Sept. 10, 2019, 6:56 p.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
> 
> 
> Bugs: MESOS-3938
> https://issues.apache.org/jira/browse/MESOS-3938
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> There is no clear argument against setting quota on the default
> "*" role. This patch allows doing so. Tests are updated to check
> against regressions.
> 
> 
> Diffs
> -
> 
>   src/master/quota.cpp c9f39f3ef419a6460f3f869582c95d5f3d1a5f40 
>   src/tests/hierarchical_allocator_tests.cpp 
> 2c1d0fe2e3ac08e6443cf8348bb72ac7dae454a8 
>   src/tests/master_quota_tests.cpp 58328692b1026231e3f255938741ffc57324f97d 
>   src/tests/master_validation_tests.cpp 
> 90b844791ee0788efb8c4b220c246f56f5c9981f 
> 
> 
> Diff: https://reviews.apache.org/r/71464/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>



Re: Review Request 71460: Tracked offered and allocated resources in the role tree.

2019-09-10 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71460/#review217681
---



Patch looks great!

Reviews applied: [71459, 71460]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers 
--disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On Sept. 10, 2019, 6 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71460/
> ---
> 
> (Updated Sept. 10, 2019, 6 p.m.)
> 
> 
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This helpers simplify the quota tracking logic and also paves
> the way to reduce duplicated states in the sorter.
> 
> Small performance degradation when making allocations due to
> duplicated map construction in `(un)trackAllocatedResources`.
> This will be removed once embeded the sorter in the role tree.
> 
> Benchmark `LargeAndSmallQuota/2`:
> 
> Master:
> 
> Added 3000 agents in 80.648188ms
> Added 3000 frameworks in 19.7006984secs
> Benchmark setup: 3000 agents, 3000 roles, 3000 frameworks,
> with drf sorter
> Made 3500 allocations in 16.044274434secs
> Made 0 allocation in 14.476429451secs
> 
> Master + this patch:
> Added 3000 agents in 80.110817ms
> Added 3000 frameworks in 17.25974094secs
> Benchmark setup: 3000 agents, 3000 roles, 3000 frameworks,
> with drf sorter
> Made 3500 allocations in 16.91971379secs
> Made 0 allocation in 13.784476154secs
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> 48ba399e12129b3348b5c43b793f3428acf26d4e 
>   src/master/allocator/mesos/hierarchical.cpp 
> 187de173ee2f563e2ff0f7e5c96695dd94a73970 
> 
> 
> Diff: https://reviews.apache.org/r/71460/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> Benchmark result in the description
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>



  1   2   3   4   5   6   7   8   9   10   >