Re: Review Request 38287: Check if the futrue is failed before dispatch in freeze()

2015-10-01 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38287/#review101290 --- LGTM - Paul Brett On Sept. 24, 2015, 3:15 a.m., Jian Qiu wrote

Review Request 38728: Cgroups Test Filters aborts test.

2015-09-24 Thread Paul Brett
, Paul Brett

Re: Review Request 38528: Disable perf test when perf version is not support.

2015-09-21 Thread Paul Brett
version of perf to be installed, however the Parse test does not. Could we use the supported() test to disable all events matching both ROOT and Perf? - Paul Brett On Sept. 20, 2015, 2:49 a.m., haosdent huang wrote

Re: Review Request 37462: Add support for version detection and parsing.

2015-09-02 Thread Paul Brett
th of them. I'll make that clear. - Paul --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37462/#review97360 --- On Sept. 2,

Re: Review Request 37466: Update perf tests to including testing the supported perf output formats.

2015-09-02 Thread Paul Brett
the supported perf output formats. Diffs (updated) - src/tests/containerizer/perf_tests.cpp 8c29ca3dc2a8f6d1fb0f430482190f87f08eb4e8 Diff: https://reviews.apache.org/r/37466/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 37466: Update perf tests to including testing the supported perf output formats.

2015-09-02 Thread Paul Brett
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37466/#review97551 --- On Sept. 2, 2015, 11:33 p.m., Paul Brett wrote: > > --

Re: Review Request 37466: Update perf tests to including testing the supported perf output formats.

2015-09-02 Thread Paul Brett
/containerizer/perf_tests.cpp bef475e4b573f02b69f2c4dd6d1c6a6e10f34c38 Diff: https://reviews.apache.org/r/37466/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 37466: Update perf tests to including testing the supported perf output formats.

2015-09-02 Thread Paul Brett
/perf_tests.cpp bef475e4b573f02b69f2c4dd6d1c6a6e10f34c38 Diff: https://reviews.apache.org/r/37466/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 37462: Add support for version detection and parsing.

2015-09-02 Thread Paul Brett
to choose decode. The next patch will extend the perf tests to supply test cases for each of the supported perf versions. Thanks, Paul Brett

Re: Review Request 37466: Update perf tests to including testing the supported perf output formats.

2015-09-02 Thread Paul Brett
8c29ca3dc2a8f6d1fb0f430482190f87f08eb4e8 Diff: https://reviews.apache.org/r/37466/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 37442: Factor out the token extraction rules in prepartion for extending them to cope with multiple versions.

2015-09-01 Thread Paul Brett
--- sudo make check Thanks, Paul Brett

Re: Review Request 37462: Add support for version detection and parsing.

2015-09-01 Thread Paul Brett
are currently using the version of perf installed on the machine to choose decode. The next patch will extend the perf tests to supply test cases for each of the supported perf versions. Thanks, Paul Brett

Re: Review Request 37466: Update perf tests to including testing the supported perf output formats.

2015-09-01 Thread Paul Brett
/perf_tests.cpp 8c29ca3dc2a8f6d1fb0f430482190f87f08eb4e8 Diff: https://reviews.apache.org/r/37466/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 37462: Add support for version detection and parsing.

2015-09-01 Thread Paul Brett
of perf installed on the machine to choose decode. The next patch will extend the perf tests to supply test cases for each of the supported perf versions. Thanks, Paul Brett

Re: Review Request 37442: Factor out the token extraction rules in prepartion for extending them to cope with multiple versions.

2015-09-01 Thread Paul Brett
) - src/linux/perf.cpp dac7061471a0fa05de12cb530bcd5c63a6a71eee Diff: https://reviews.apache.org/r/37442/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 37442: Factor out the token extraction rules in prepartion for extending them to cope with multiple versions.

2015-09-01 Thread Paul Brett
s an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37442/#review97320 --- On Sept. 1, 2015, 7:49 p.m., Paul Brett wrote: > > --- > This is an automatical

Re: Review Request 37416: Perf supported() should be based on the version of perf, not the version of the kernel.

2015-08-31 Thread Paul Brett
Thanks, Paul Brett

Re: Review Request 37416: Perf supported() should be based on the version of perf, not the version of the kernel.

2015-08-31 Thread Paul Brett
check Thanks, Paul Brett

Re: Review Request 37416: Perf supported() should be based on the version of perf, not the version of the kernel.

2015-08-31 Thread Paul Brett
, Paul Brett

Re: Review Request 37416: Perf supported() should be based on the version of perf, not the version of the kernel.

2015-08-31 Thread Paul Brett
/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 37442: Factor out the token extraction rules in prepartion for extending them to cope with multiple versions.

2015-08-31 Thread Paul Brett
/37442/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 37416: Perf supported() should be based on the version of perf, not the version of the kernel.

2015-08-24 Thread Paul Brett
/#comment151479 It would be a rare event but not completly unexpected. After all, perf can be upgraded while mesos is running. - Paul Brett On Aug. 21, 2015, 6:46 p.m., Paul Brett wrote: --- This is an automatically generated e

Re: Review Request 37416: Perf supported() should be based on the version of perf, not the version of the kernel.

2015-08-24 Thread Paul Brett
is running. - Paul --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37416/#review96166 --- On Aug. 21, 2015, 6:46 p.m., Paul Brett wrote

Re: Review Request 37416: Perf supported() should be based on the version of perf, not the version of the kernel.

2015-08-21 Thread Paul Brett
, Paul Brett

Re: Review Request 37466: Update perf tests to including testing the supported perf output formats.

2015-08-20 Thread Paul Brett
cdc5f8314a875ababf2b17a32873775d808e1c78 src/tests/containerizer/perf_tests.cpp 6b3d70f3e7ea8f59f94e6961491d4e9a730e3334 Diff: https://reviews.apache.org/r/37466/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 37462: Add support for version detection and parsing.

2015-08-20 Thread Paul Brett
versions. Thanks, Paul Brett

Re: Review Request 37466: Update perf tests to including testing the supported perf output formats.

2015-08-20 Thread Paul Brett
/perf_tests.cpp 6b3d70f3e7ea8f59f94e6961491d4e9a730e3334 Diff: https://reviews.apache.org/r/37466/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 37466: Update perf tests to including testing the supported perf output formats.

2015-08-20 Thread Paul Brett
6b3d70f3e7ea8f59f94e6961491d4e9a730e3334 Diff: https://reviews.apache.org/r/37466/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 37462: Add support for version detection and parsing.

2015-08-20 Thread Paul Brett
of the supported perf versions. Thanks, Paul Brett

Re: Review Request 37462: Add support for version detection and parsing.

2015-08-20 Thread Paul Brett
/ Testing --- sudo make check Perf tests may fail on many machines because the tests are currently using the version of perf installed on the machine to choose decode. The next patch will extend the perf tests to supply test cases for each of the supported perf versions. Thanks, Paul Brett

Re: Review Request 37460: Prevent perf test failures from killing the test harness.

2015-08-20 Thread Paul Brett
6b3d70f3e7ea8f59f94e6961491d4e9a730e3334 Diff: https://reviews.apache.org/r/37460/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 37442: Factor out the token extraction rules in prepartion for extending them to cope with multiple versions.

2015-08-20 Thread Paul Brett
://reviews.apache.org/r/37442/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 37462: Add support for version detection and parsing.

2015-08-20 Thread Paul Brett
cases for each of the supported perf versions. Thanks, Paul Brett

Re: Review Request 37416: Perf supported() should be based on the version of perf, not the version of the kernel.

2015-08-20 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37416/#review95809 --- On Aug. 20, 2015, 1:13 a.m., Paul Brett wrote

Re: Review Request 37416: Perf supported() should be based on the version of perf, not the version of the kernel.

2015-08-20 Thread Paul Brett
/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 37416: Perf supported() should be based on the version of perf, not the version of the kernel.

2015-08-20 Thread Paul Brett
. - Paul --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37416/#review95809 --- On Aug. 20, 2015, 4:39 p.m., Paul Brett wrote

Re: Review Request 37416: Perf supported() should be based on the version of perf, not the version of the kernel.

2015-08-19 Thread Paul Brett
/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 37416: Perf supported() should be based on the version of perf, not the version of the kernel.

2015-08-19 Thread Paul Brett
/r/37416/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 37423: Split out common functions for running perf into a common perf class with wrapper functions to allow for reuse between sample, valid and version operations.

2015-08-18 Thread Paul Brett
and version operations. Diffs (updated) - src/linux/perf.cpp cb1a13d0b1754a50f0121bfda522056ff8c3e3c8 Diff: https://reviews.apache.org/r/37423/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 37417: Convert Perf event validator to use new shared object.

2015-08-18 Thread Paul Brett
. Repository: mesos Description --- Convert Perf event validator to use new shared object. Diffs - src/linux/perf.cpp cb1a13d0b1754a50f0121bfda522056ff8c3e3c8 Diff: https://reviews.apache.org/r/37417/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 37424: Timeout the perf future if the process does not complete.

2015-08-18 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37424/#review95606 --- On Aug. 13, 2015, 12:29 a.m., Paul Brett wrote

Re: Review Request 37424: Timeout the perf future if the process does not complete.

2015-08-18 Thread Paul Brett
--- sudo make check Thanks, Paul Brett

Re: Review Request 37417: Convert Perf event validator to use new shared object.

2015-08-18 Thread Paul Brett
. Repository: mesos Description --- Convert Perf event validator to use new shared object. Diffs - src/linux/perf.cpp cb1a13d0b1754a50f0121bfda522056ff8c3e3c8 Diff: https://reviews.apache.org/r/37417/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 37417: Convert Perf event validator to use new shared object.

2015-08-18 Thread Paul Brett
/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 37424: Timeout the perf future if the process does not complete.

2015-08-18 Thread Paul Brett
/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 37417: Convert Perf event validator to use new shared object.

2015-08-18 Thread Paul Brett
--- On Aug. 18, 2015, 11:01 p.m., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37417/ --- (Updated Aug. 18, 2015, 11

Re: Review Request 37416: Perf supported() should be based on the version of perf, not the version of the kernel.

2015-08-18 Thread Paul Brett
check Thanks, Paul Brett

Re: Review Request 37417: Convert Perf event validator to use new shared object.

2015-08-18 Thread Paul Brett
cdc5f8314a875ababf2b17a32873775d808e1c78 Diff: https://reviews.apache.org/r/37417/diff/ Testing --- sudo make check Thanks, Paul Brett

Review Request 37488: Fix cgroup CHECK failure cases test harness to abort.

2015-08-14 Thread Paul Brett
--- sudo make check Thanks, Paul Brett

Re: Review Request 37490: Convert CHECK functions to ADD_FAILURE in mesos.cpp to fail the test without aborting the test harness.

2015-08-14 Thread Paul Brett
/mesos.cpp 9bff4a66604a67d9add5a05247548e0162f3cda7 Diff: https://reviews.apache.org/r/37490/diff/ Testing --- sudo make check Thanks, Paul Brett

Review Request 37490: Convert CHECK functions to ADD_FAILURE in mesos.cpp to fail the test without aborting the test harness.

2015-08-14 Thread Paul Brett
/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 37490: Convert CHECK functions to ASSERT in mesos.cpp to fail the test without aborting the test harness.

2015-08-14 Thread Paul Brett
in mesos.cpp to fail the test without aborting the test harness. Diffs - src/tests/mesos.cpp 9bff4a66604a67d9add5a05247548e0162f3cda7 Diff: https://reviews.apache.org/r/37490/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 37416: Perf supported() should be based on the version of perf, not the version of the kernel.

2015-08-13 Thread Paul Brett
/37416/diff/ Testing --- sudo make check Thanks, Paul Brett

Review Request 37442: Factor out the token extraction rules in prepartion for extending them to cope with multiple versions.

2015-08-13 Thread Paul Brett
--- Factor out the token extraction rules in prepartion for extending them to cope with multiple versions. Diffs - src/linux/perf.cpp cb1a13d0b1754a50f0121bfda522056ff8c3e3c8 Diff: https://reviews.apache.org/r/37442/diff/ Testing --- sudo make check Thanks, Paul Brett

Review Request 37460: Prevent perf test failures from killing the test harness.

2015-08-13 Thread Paul Brett
--- sudo make check Thanks, Paul Brett

Review Request 37466: Update perf tests to including testing the supported perf output formats.

2015-08-13 Thread Paul Brett
/ Testing --- sudo make check Thanks, Paul Brett

Review Request 37462: Add support for version detection and parsing.

2015-08-13 Thread Paul Brett
://issues.apache.org/jira/browse/MESOS-2834 Repository: mesos Description --- Add support for version detection and parsing. Diffs - src/linux/perf.cpp cb1a13d0b1754a50f0121bfda522056ff8c3e3c8 Diff: https://reviews.apache.org/r/37462/diff/ Testing --- sudo make check Thanks, Paul

Review Request 37423: Split out common functions for running perf into a common perf class with wrapper functions to allow for reuse between sample, valid and version operations.

2015-08-12 Thread Paul Brett
cb1a13d0b1754a50f0121bfda522056ff8c3e3c8 Diff: https://reviews.apache.org/r/37423/diff/ Testing --- sudo make check Thanks, Paul Brett

Review Request 37417: Convert Perf event validator to use new shared object.

2015-08-12 Thread Paul Brett
Perf event validator to use new shared object. Diffs - src/linux/perf.cpp cb1a13d0b1754a50f0121bfda522056ff8c3e3c8 Diff: https://reviews.apache.org/r/37417/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 37399: Ignore no statistics condition for containers with no qdisc.

2015-08-12 Thread Paul Brett
/containerizer/isolators/network/port_mapping.cpp 6d635d4dd902fd3863cce689a7791f12d22c3e0c Diff: https://reviews.apache.org/r/37399/diff/ Testing --- sudo make check Thanks, Paul Brett

Review Request 37424: Timeout the perf future if the process does not complete.

2015-08-12 Thread Paul Brett
--- Timeout the perf future if the process does not complete. Diffs - src/linux/perf.cpp cb1a13d0b1754a50f0121bfda522056ff8c3e3c8 Diff: https://reviews.apache.org/r/37424/diff/ Testing --- sudo make check Thanks, Paul Brett

Review Request 37416: Perf supported() should be based on the version of perf, not the version of the kernel.

2015-08-12 Thread Paul Brett
--- Perf supported() should be based on the version of perf, not the version of the kernel. Diffs - src/linux/perf.cpp cb1a13d0b1754a50f0121bfda522056ff8c3e3c8 Diff: https://reviews.apache.org/r/37416/diff/ Testing --- sudo make check Thanks, Paul Brett

Review Request 37399: Ignore no statistics condition for containers with no qdisc.

2015-08-12 Thread Paul Brett
://reviews.apache.org/r/37399/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 37045: Convert Linux perf sampler to use process:await().

2015-08-05 Thread Paul Brett
Diff: https://reviews.apache.org/r/37045/diff/ Testing --- sudo make check Thanks, Paul Brett

Review Request 37147: Timeout perf stat command if it does not complete.

2015-08-05 Thread Paul Brett
, Paul Brett

Re: Review Request 37045: Convert Linux perf sampler to use process:await().

2015-08-04 Thread Paul Brett
/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 37045: Convert Linux perf sampler to use process:await().

2015-08-04 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37045/#review94148 --- On Aug. 4, 2015, 4:57 p.m., Paul Brett wrote: --- This is an automatically generated e-mail

Re: Review Request 37045: Convert Linux perf sampler to use process:await().

2015-08-04 Thread Paul Brett
Diff: https://reviews.apache.org/r/37045/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 37045: Convert Linux perf sampler to use process:await().

2015-08-04 Thread Paul Brett
: https://reviews.apache.org/r/37045/diff/ Testing --- sudo make check Thanks, Paul Brett

Review Request 37106: PortMappingIsolatorProcess shell script can silently fail.

2015-08-04 Thread Paul Brett
://reviews.apache.org/r/37106/diff/ Testing --- sudo make check Thanks, Paul Brett

Review Request 37045: Convert Linux perf sampler to use process:await().

2015-08-03 Thread Paul Brett
make check Thanks, Paul Brett

Review Request 37000: Refactor Subprocess logic in linux/perf.cpp to use common subroutine.

2015-07-31 Thread Paul Brett
/diff/ Testing --- sudo make check Thanks, Paul Brett

Review Request 36947: Fix new/delete mismatch in stout test.

2015-07-30 Thread Paul Brett
/36947/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 36378: Refactor Linux Performance monitor to handle changing 'perf stat' output versions depending on kernel version.

2015-07-16 Thread Paul Brett
on kernel version. Diffs (updated) - src/linux/perf.cpp 697b75e846a43d4f106ad8f39a18882836d7dc02 Diff: https://reviews.apache.org/r/36378/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 36378: Refactor Linux Performance monitor to handle changing 'perf stat' output versions depending on kernel version.

2015-07-13 Thread Paul Brett
depending on kernel version. Diffs (updated) - src/linux/perf.cpp 697b75e846a43d4f106ad8f39a18882836d7dc02 Diff: https://reviews.apache.org/r/36378/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 36380: Test cases for performance monitor support of multiple output versions depending on kernel version.

2015-07-13 Thread Paul Brett
/36380/#review91346 --- On July 10, 2015, 8:52 p.m., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36380

Re: Review Request 36378: Refactor Linux Performance monitor to handle changing 'perf stat' output versions depending on kernel version.

2015-07-13 Thread Paul Brett
697b75e846a43d4f106ad8f39a18882836d7dc02 Diff: https://reviews.apache.org/r/36378/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 36378: Refactor Linux Performance monitor to handle changing 'perf stat' output versions depending on kernel version.

2015-07-10 Thread Paul Brett
/perf.cpp 697b75e846a43d4f106ad8f39a18882836d7dc02 Diff: https://reviews.apache.org/r/36378/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 36378: Refactor Linux Performance monitor to handle changing 'perf stat' output versions depending on kernel version.

2015-07-10 Thread Paul Brett
. To reply, visit: https://reviews.apache.org/r/36378/#review91253 --- On July 10, 2015, 5:33 p.m., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 36378: Refactor Linux Performance monitor to handle changing 'perf stat' output versions depending on kernel version.

2015-07-10 Thread Paul Brett
version. Diffs (updated) - src/linux/perf.cpp 697b75e846a43d4f106ad8f39a18882836d7dc02 Diff: https://reviews.apache.org/r/36378/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 36378: Refactor Linux Performance monitor to handle changing 'perf stat' output versions depending on kernel version.

2015-07-10 Thread Paul Brett
. Diffs - src/linux/perf.cpp 697b75e846a43d4f106ad8f39a18882836d7dc02 Diff: https://reviews.apache.org/r/36378/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 36378: Refactor Linux Performance monitor to handle changing 'perf stat' output versions depending on kernel version.

2015-07-10 Thread Paul Brett
. - Paul --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36378/#review91253 --- On July 10, 2015, 8:48 p.m., Paul Brett wrote

Re: Review Request 36378: Refactor Linux Performance monitor to handle changing 'perf stat' output versions depending on kernel version.

2015-07-10 Thread Paul Brett
/#comment144721 Get version number from 'perf --version' not os::release. src/linux/perf.cpp (line 623) https://reviews.apache.org/r/36378/#comment144720 We should get the version number from 'perf --version' not os::release in case a mismatched perf is installed. - Paul Brett

Re: Review Request 36378: Refactor Linux Performance monitor to handle changing 'perf stat' output versions depending on kernel version.

2015-07-10 Thread Paul Brett
depending on kernel version. Diffs (updated) - src/linux/perf.cpp 697b75e846a43d4f106ad8f39a18882836d7dc02 Diff: https://reviews.apache.org/r/36378/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 36336: Expose major, minor and patch components from stout Version

2015-07-09 Thread Paul Brett
://reviews.apache.org/r/36336/#review91047 --- On July 8, 2015, 10:50 p.m., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r

Re: Review Request 36336: Expose major, minor and patch components from stout Version

2015-07-09 Thread Paul Brett
is a widely accepted format. Paul Brett wrote: g++ defines _GNU_SOURCE (required for libstdc++). This #includes sysmacros.h which #define major and minor as macros for makedev. Ben Mahler wrote: If you add major(), minor(), patch() as methods instead, does that bypass the macro issue

Re: Review Request 36336: Expose major, minor and patch components from stout Version

2015-07-09 Thread Paul Brett
is a widely accepted format. Paul Brett wrote: g++ defines _GNU_SOURCE (required for libstdc++). This #includes sysmacros.h which #define major and minor as macros for makedev. Ben Mahler wrote: If you add major(), minor(), patch() as methods instead, does that bypass the macro issue

Review Request 36380: Test cases for performance monitor support of multiple output versions depending on kernel version.

2015-07-09 Thread Paul Brett
Diff: https://reviews.apache.org/r/36380/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 36336: Expose major, minor and patch components from stout Version

2015-07-09 Thread Paul Brett
://reviews.apache.org/r/36336/diff/ Testing --- sudo make check Thanks, Paul Brett

Re: Review Request 36281: Document per-container unique egress flows and network queueing statistics.

2015-07-08 Thread Paul Brett
true? Yes - Paul --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36281/#review90857 --- On July 8, 2015, 12:59 a.m., Paul Brett wrote

Re: Review Request 36281: Document per-container unique egress flows and network queueing statistics.

2015-07-08 Thread Paul Brett
8889fb165cc70bc382be0c99de8d7748328abf57 Diff: https://reviews.apache.org/r/36281/diff/ Testing --- Rendered at https://www.notehub.org/2015/7/7/network-isolation for review. Thanks, Paul Brett

Re: Review Request 36336: Expose major, minor and patch components from stout Version

2015-07-08 Thread Paul Brett
/r/36336/#review91023 --- On July 8, 2015, 10:50 p.m., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36336

Review Request 36336: Expose major, minor and patch components from stout Version

2015-07-08 Thread Paul Brett
in the sysmacros.h header implicitly which define these for makedev. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp 8692323d28131cd5706dde0503d49f8f0b0a1aeb Diff: https://reviews.apache.org/r/36336/diff/ Testing --- sudo make check Thanks, Paul Brett

Review Request 36281: Document per-container unique egress flows and network queueing statistics.

2015-07-07 Thread Paul Brett
://reviews.apache.org/r/36281/diff/ Testing --- Rendered at https://www.notehub.org/2015/7/7/network-isolation for review. Thanks, Paul Brett

Re: Review Request 36281: Document per-container unique egress flows and network queueing statistics.

2015-07-07 Thread Paul Brett
-isolation.md PRE-CREATION docs/network-monitoring.md 8889fb165cc70bc382be0c99de8d7748328abf57 Diff: https://reviews.apache.org/r/36281/diff/ Testing --- Rendered at https://www.notehub.org/2015/7/7/network-isolation for review. Thanks, Paul Brett

Re: Review Request 36281: Document per-container unique egress flows and network queueing statistics.

2015-07-07 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36281/#review90813 --- On July 8, 2015, 12:03 a.m., Paul Brett wrote

Re: Review Request 36281: Document per-container unique egress flows and network queueing statistics.

2015-07-07 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36281/#review90827 --- On July 8, 2015, 12:03 a.m., Paul Brett wrote

Re: Review Request 36281: Document per-container unique egress flows and network queueing statistics.

2015-07-07 Thread Paul Brett
-monitoring.md 8889fb165cc70bc382be0c99de8d7748328abf57 Diff: https://reviews.apache.org/r/36281/diff/ Testing --- Rendered at https://www.notehub.org/2015/7/7/network-isolation for review. Thanks, Paul Brett

Re: Review Request 36112: perf: extracted out a 'version' function.

2015-07-01 Thread Paul Brett
/#comment143147 Not your code but we should propagate the failure to the caller so that sample can fail rather than halt and catch fire here. - Paul Brett On July 1, 2015, 10:43 p.m., Chi Zhang wrote: --- This is an automatically

Re: Review Request 36115: perf: changed 'parse' interface to allow testing and added tests.

2015-07-01 Thread Paul Brett
) https://reviews.apache.org/r/36115/#comment143155 Ditto. src/tests/perf_tests.cpp (line 170) https://reviews.apache.org/r/36115/#comment143156 Ditto. src/tests/perf_tests.cpp (line 240) https://reviews.apache.org/r/36115/#comment143157 Ditto. - Paul Brett On July 1, 2015, 10:44

  1   2   3   >