Re: Review Request 68335: Added a CNI test to verify destroy while preparing.

2018-08-14 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68335/#review207220
---




src/slave/containerizer/mesos/containerizer.hpp
Lines 196-201 (patched)
<https://reviews.apache.org/r/68335/#comment290515>

Instead of making this internal method public, can we do something similar 
with `MesosContainerizerDestroyTest.DestroyWhilePreparing` which simulates the 
case of a destroy while isolator preparing is in progress too?



src/tests/containerizer/cni_isolator_tests.cpp
Lines 48-49 (patched)
<https://reviews.apache.org/r/68335/#comment290510>

A newline between.


- Qian Zhang


On Aug. 14, 2018, 7 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68335/
> ---
> 
> (Updated Aug. 14, 2018, 7 a.m.)
> 
> 
> Review request for mesos, Deepak Goel, Qian Zhang, and Sergey Urbanovich.
> 
> 
> Bugs: MESOS-9142
> https://issues.apache.org/jira/browse/MESOS-9142
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This test is used to catch the regression described in MESOS-9142.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.hpp 
> 7711d463c8ed92e2580c56e88d7f372c6dfaeb2b 
>   src/tests/containerizer/cni_isolator_tests.cpp 
> cb22e73b4215b5b0a49ac610e5f657b73d38963b 
> 
> 
> Diff: https://reviews.apache.org/r/68335/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>



Re: Review Request 68334: Used state::checkpoint instead in CNI isolator.

2018-08-14 Thread Qian Zhang


> On Aug. 14, 2018, 3:30 p.m., Qian Zhang wrote:
> > Ship It!

BTW, what about the other files (i.e., hosts, hostname and resolv.conf) that 
CNI isolator persists in the container dir? Should we change from `os::write()` 
to `state::checkpoint()` for them too?


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68334/#review207216
---


On Aug. 14, 2018, 7:04 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68334/
> ---
> 
> (Updated Aug. 14, 2018, 7:04 a.m.)
> 
> 
> Review request for mesos, Deepak Goel, Qian Zhang, and Sergey Urbanovich.
> 
> 
> Bugs: MESOS-9142
> https://issues.apache.org/jira/browse/MESOS-9142
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is to ensure all or nothing semantics. We don't want to deal with a
> particially written file in case agent crashes.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
> f46c962d8f044092aaa113fafc536c6b25bab45c 
> 
> 
> Diff: https://reviews.apache.org/r/68334/diff/3/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>



Re: Review Request 68334: Used state::checkpoint instead in CNI isolator.

2018-08-14 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68334/#review207216
---


Ship it!




Ship It!

- Qian Zhang


On Aug. 14, 2018, 7:04 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68334/
> ---
> 
> (Updated Aug. 14, 2018, 7:04 a.m.)
> 
> 
> Review request for mesos, Deepak Goel, Qian Zhang, and Sergey Urbanovich.
> 
> 
> Bugs: MESOS-9142
> https://issues.apache.org/jira/browse/MESOS-9142
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is to ensure all or nothing semantics. We don't want to deal with a
> particially written file in case agent crashes.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
> f46c962d8f044092aaa113fafc536c6b25bab45c 
> 
> 
> Diff: https://reviews.apache.org/r/68334/diff/3/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>



Re: Review Request 68333: Made CNI isolator cleanup more robust.

2018-08-14 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68333/#review207214
---


Ship it!




Ship It!

- Qian Zhang


On Aug. 14, 2018, 6:59 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68333/
> ---
> 
> (Updated Aug. 14, 2018, 6:59 a.m.)
> 
> 
> Review request for mesos, Deepak Goel, Qian Zhang, and Sergey Urbanovich.
> 
> 
> Bugs: MESOS-9142
> https://issues.apache.org/jira/browse/MESOS-9142
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> If the container is destroyed while in isolator preparing state, the
> cleanup might fail due to missing files or directories. This patch makes
> the cleanup path in CNI isolator more robust so that the cleanup does
> not fail in those scenarios.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
> f46c962d8f044092aaa113fafc536c6b25bab45c 
> 
> 
> Diff: https://reviews.apache.org/r/68333/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>



Re: Review Request 68221: Updated `docker/volume` isolator to honor volume mode.

2018-08-14 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68221/
---

(Updated Aug. 14, 2018, 2:29 p.m.)


Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Changes
---

Addressed review comments.


Bugs: MESOS-8814
https://issues.apache.org/jira/browse/MESOS-8814


Repository: mesos


Description
---

Updated `docker/volume` isolator to honor volume mode.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 
76f1a5243c8d5028157f795d851b547a5ce57ac9 
  src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
ab749be6234a5eedc0617a131c126129f43f8d62 


Diff: https://reviews.apache.org/r/68221/diff/3/

Changes: https://reviews.apache.org/r/68221/diff/2-3/


Testing
---


Thanks,

Qian Zhang



Re: Review Request 68222: Added 2 tests for `docker/volume` isolator to cover read-only volume.

2018-08-14 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68222/
---

(Updated Aug. 14, 2018, 2:29 p.m.)


Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Changes
---

Addressed review comments.


Bugs: MESOS-8814
https://issues.apache.org/jira/browse/MESOS-8814


Repository: mesos


Description
---

Added 2 tests for `docker/volume` isolator to cover read-only volume.


Diffs (updated)
-

  src/tests/containerizer/docker_volume_isolator_tests.cpp 
c15a6fad642474765e4ad1952af6cd9ee937379e 


Diff: https://reviews.apache.org/r/68222/diff/3/

Changes: https://reviews.apache.org/r/68222/diff/2-3/


Testing
---

sudo make check


Thanks,

Qian Zhang



Re: Review Request 68219: Updated `volume/secret` isolator to honor volume mode.

2018-08-14 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68219/
---

(Updated Aug. 14, 2018, 2:29 p.m.)


Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Changes
---

Addressed review comments.


Bugs: MESOS-8814
https://issues.apache.org/jira/browse/MESOS-8814


Repository: mesos


Description
---

Updated `volume/secret` isolator to honor volume mode.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/volume/secret.cpp 
663aafc7173667f8f78b26bdc824a3ab2e04ed25 


Diff: https://reviews.apache.org/r/68219/diff/3/

Changes: https://reviews.apache.org/r/68219/diff/2-3/


Testing
---


Thanks,

Qian Zhang



Re: Review Request 68216: Updated `volume/image` isolator to honor volume mode.

2018-08-14 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68216/
---

(Updated Aug. 14, 2018, 2:28 p.m.)


Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Changes
---

Addressed review comments.


Bugs: MESOS-8814
https://issues.apache.org/jira/browse/MESOS-8814


Repository: mesos


Description
---

Updated `volume/image` isolator to honor volume mode.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/volume/image.hpp 
706b8ff28e1b1c8d15606d54d40622bc09885667 
  src/slave/containerizer/mesos/isolators/volume/image.cpp 
345772439b73b4816f71e15bb4e43a5d67c51c02 


Diff: https://reviews.apache.org/r/68216/diff/3/

Changes: https://reviews.apache.org/r/68216/diff/2-3/


Testing
---


Thanks,

Qian Zhang



Re: Review Request 68219: Updated `volume/secret` isolator to honor volume mode.

2018-08-13 Thread Qian Zhang


> On Aug. 14, 2018, 7:30 a.m., Gilbert Song wrote:
> > src/slave/containerizer/mesos/isolators/volume/secret.cpp
> > Lines 287 (patched)
> > <https://reviews.apache.org/r/68219/diff/2/?file=2069915#file2069915line287>
> >
> > Why not the same order as previous patches? I guess it does not hurt

Agree, let me make it the same order as the previous patches.


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68219/#review207185
---


On Aug. 7, 2018, 10:22 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68219/
> ---
> 
> (Updated Aug. 7, 2018, 10:22 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.
> 
> 
> Bugs: MESOS-8814
> https://issues.apache.org/jira/browse/MESOS-8814
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated `volume/secret` isolator to honor volume mode.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/volume/secret.cpp 
> 663aafc7173667f8f78b26bdc824a3ab2e04ed25 
> 
> 
> Diff: https://reviews.apache.org/r/68219/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>



Re: Review Request 68214: Updated `volume/sandbox_path` isolator to honor volume mode.

2018-08-13 Thread Qian Zhang


> On Aug. 13, 2018, 12:15 p.m., Gilbert Song wrote:
> > src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp
> > Line 373 (original), 373 (patched)
> > <https://reviews.apache.org/r/68214/diff/2/?file=2069910#file2069910line373>
> >
> > Not yours, but could we remove this?

I think we still need to keep it. Otherwise, the code in it may fail to compile 
on platforms other than Linux because those codes use some Linux specific 
macros, like `MS_BIND`.


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68214/#review207135
---


On Aug. 7, 2018, 10:18 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68214/
> ---
> 
> (Updated Aug. 7, 2018, 10:18 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.
> 
> 
> Bugs: MESOS-8814
> https://issues.apache.org/jira/browse/MESOS-8814
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated `volume/sandbox_path` isolator to honor volume mode.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp 
> 4896c6811c2c59dcf00871b7a8b6b9b50da0f062 
> 
> 
> Diff: https://reviews.apache.org/r/68214/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>



Re: Review Request 68222: Added 2 tests for `docker/volume` isolator to cover read-only volume.

2018-08-07 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68222/
---

(Updated Aug. 7, 2018, 10:24 p.m.)


Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Changes
---

Rebased.


Bugs: MESOS-8814
https://issues.apache.org/jira/browse/MESOS-8814


Repository: mesos


Description
---

Added 2 tests for `docker/volume` isolator to cover read-only volume.


Diffs (updated)
-

  src/tests/containerizer/docker_volume_isolator_tests.cpp 
c15a6fad642474765e4ad1952af6cd9ee937379e 


Diff: https://reviews.apache.org/r/68222/diff/2/

Changes: https://reviews.apache.org/r/68222/diff/1-2/


Testing
---

sudo make check


Thanks,

Qian Zhang



Re: Review Request 68221: Updated `docker/volume` isolator to honor volume mode.

2018-08-07 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68221/
---

(Updated Aug. 7, 2018, 10:23 p.m.)


Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Changes
---

Rebased.


Bugs: MESOS-8814
https://issues.apache.org/jira/browse/MESOS-8814


Repository: mesos


Description
---

Updated `docker/volume` isolator to honor volume mode.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 
76f1a5243c8d5028157f795d851b547a5ce57ac9 
  src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
ab749be6234a5eedc0617a131c126129f43f8d62 


Diff: https://reviews.apache.org/r/68221/diff/2/

Changes: https://reviews.apache.org/r/68221/diff/1-2/


Testing
---


Thanks,

Qian Zhang



Re: Review Request 68220: Updated the test `ROOT_SecretInVolumeWithRootFilesystem`.

2018-08-07 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68220/
---

(Updated Aug. 7, 2018, 10:23 p.m.)


Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Changes
---

Rebased.


Bugs: MESOS-8814
https://issues.apache.org/jira/browse/MESOS-8814


Repository: mesos


Description
---

This test is updated to cover both read-write and read-only volume.


Diffs (updated)
-

  src/tests/containerizer/volume_secret_isolator_tests.cpp 
11cd3b627b056d1811ab481b8aa599c346181383 


Diff: https://reviews.apache.org/r/68220/diff/2/

Changes: https://reviews.apache.org/r/68220/diff/1-2/


Testing
---

sudo make check


Thanks,

Qian Zhang



Re: Review Request 68218: Added a test `ROOT_ImageInReadOnlyVolumeWithoutRootFilesystem`.

2018-08-07 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68218/
---

(Updated Aug. 7, 2018, 10:22 p.m.)


Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Changes
---

Rebased.


Bugs: MESOS-8814
https://issues.apache.org/jira/browse/MESOS-8814


Repository: mesos


Description
---

Added a test `ROOT_ImageInReadOnlyVolumeWithoutRootFilesystem`.


Diffs (updated)
-

  src/tests/containerizer/volume_image_isolator_tests.cpp 
b49f0f98e3c31808d8d1e9edbb9a783bfe5231ce 


Diff: https://reviews.apache.org/r/68218/diff/2/

Changes: https://reviews.apache.org/r/68218/diff/1-2/


Testing
---

sudo make check


Thanks,

Qian Zhang



Re: Review Request 68219: Updated `volume/secret` isolator to honor volume mode.

2018-08-07 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68219/
---

(Updated Aug. 7, 2018, 10:22 p.m.)


Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Changes
---

Rebased.


Bugs: MESOS-8814
https://issues.apache.org/jira/browse/MESOS-8814


Repository: mesos


Description
---

Updated `volume/secret` isolator to honor volume mode.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/volume/secret.cpp 
663aafc7173667f8f78b26bdc824a3ab2e04ed25 


Diff: https://reviews.apache.org/r/68219/diff/2/

Changes: https://reviews.apache.org/r/68219/diff/1-2/


Testing
---


Thanks,

Qian Zhang



Re: Review Request 68216: Updated `volume/image` isolator to honor volume mode.

2018-08-07 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68216/
---

(Updated Aug. 7, 2018, 10:20 p.m.)


Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Changes
---

Rebased.


Bugs: MESOS-8814
https://issues.apache.org/jira/browse/MESOS-8814


Repository: mesos


Description
---

Updated `volume/image` isolator to honor volume mode.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/volume/image.hpp 
706b8ff28e1b1c8d15606d54d40622bc09885667 
  src/slave/containerizer/mesos/isolators/volume/image.cpp 
345772439b73b4816f71e15bb4e43a5d67c51c02 


Diff: https://reviews.apache.org/r/68216/diff/2/

Changes: https://reviews.apache.org/r/68216/diff/1-2/


Testing
---


Thanks,

Qian Zhang



Re: Review Request 68215: Added a test `VolumeSandboxPathIsolatorTest.ROOT_SelfTypeReadOnly`.

2018-08-07 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68215/
---

(Updated Aug. 7, 2018, 10:19 p.m.)


Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Changes
---

Rebased.


Bugs: MESOS-8814
https://issues.apache.org/jira/browse/MESOS-8814


Repository: mesos


Description
---

Added a test `VolumeSandboxPathIsolatorTest.ROOT_SelfTypeReadOnly`.


Diffs (updated)
-

  src/tests/containerizer/volume_sandbox_path_isolator_tests.cpp 
97b35a4dfb4c5942858bad5fbc743fd205dd4c3c 


Diff: https://reviews.apache.org/r/68215/diff/2/

Changes: https://reviews.apache.org/r/68215/diff/1-2/


Testing
---

sudo make check


Thanks,

Qian Zhang



Re: Review Request 68214: Updated `volume/sandbox_path` isolator to honor volume mode.

2018-08-07 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68214/
---

(Updated Aug. 7, 2018, 10:18 p.m.)


Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Changes
---

Rebased.


Bugs: MESOS-8814
https://issues.apache.org/jira/browse/MESOS-8814


Repository: mesos


Description
---

Updated `volume/sandbox_path` isolator to honor volume mode.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp 
4896c6811c2c59dcf00871b7a8b6b9b50da0f062 


Diff: https://reviews.apache.org/r/68214/diff/2/

Changes: https://reviews.apache.org/r/68214/diff/1-2/


Testing
---


Thanks,

Qian Zhang



Re: Review Request 68213: Added a test `VolumeHostPathIsolatorTest.ROOT_ReadOnlyVolumeFromHost`.

2018-08-07 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68213/
---

(Updated Aug. 7, 2018, 10:11 p.m.)


Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Changes
---

Rebased.


Bugs: MESOS-8814
https://issues.apache.org/jira/browse/MESOS-8814


Repository: mesos


Description
---

Added a test `VolumeHostPathIsolatorTest.ROOT_ReadOnlyVolumeFromHost`.


Diffs (updated)
-

  src/tests/containerizer/volume_host_path_isolator_tests.cpp 
3c925bcb2250ea7aea26443c866ac4bfd26d55b9 


Diff: https://reviews.apache.org/r/68213/diff/2/

Changes: https://reviews.apache.org/r/68213/diff/1-2/


Testing
---

sudo make check


Thanks,

Qian Zhang



Re: Review Request 68203: Updated volume isolators to honor volume mode.

2018-08-07 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68203/
---

(Updated Aug. 7, 2018, 10:10 p.m.)


Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Bugs: MESOS-8814
https://issues.apache.org/jira/browse/MESOS-8814


Repository: mesos


Description
---

Updated volume isolators to honor volume mode.


Diffs
-

  src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 
76f1a5243c8d5028157f795d851b547a5ce57ac9 
  src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
ab749be6234a5eedc0617a131c126129f43f8d62 
  src/slave/containerizer/mesos/isolators/volume/host_path.cpp 
9127cf4a9d8aa2b16bb5b9903103f1f76a1e2b1a 
  src/slave/containerizer/mesos/isolators/volume/image.hpp 
706b8ff28e1b1c8d15606d54d40622bc09885667 
  src/slave/containerizer/mesos/isolators/volume/image.cpp 
345772439b73b4816f71e15bb4e43a5d67c51c02 
  src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp 
4896c6811c2c59dcf00871b7a8b6b9b50da0f062 
  src/slave/containerizer/mesos/isolators/volume/secret.cpp 
663aafc7173667f8f78b26bdc824a3ab2e04ed25 


Diff: https://reviews.apache.org/r/68203/diff/2/


Testing
---


Thanks,

Qian Zhang



Re: Review Request 68212: Updated `volume/host_path` isolator to honor volume mode.

2018-08-07 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68212/
---

(Updated Aug. 7, 2018, 10:09 p.m.)


Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Changes
---

rebased.


Bugs: MESOS-8814
https://issues.apache.org/jira/browse/MESOS-8814


Repository: mesos


Description
---

Updated `volume/host_path` isolator to honor volume mode.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/volume/host_path.cpp 
9127cf4a9d8aa2b16bb5b9903103f1f76a1e2b1a 


Diff: https://reviews.apache.org/r/68212/diff/2/

Changes: https://reviews.apache.org/r/68212/diff/1-2/


Testing
---


Thanks,

Qian Zhang



Review Request 68222: Added 2 tests for `docker/volume` isolator to cover read-only volume.

2018-08-06 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68222/
---

Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Bugs: MESOS-8814
https://issues.apache.org/jira/browse/MESOS-8814


Repository: mesos


Description
---

Added 2 tests for `docker/volume` isolator to cover read-only volume.


Diffs
-

  src/tests/containerizer/docker_volume_isolator_tests.cpp 
c15a6fad642474765e4ad1952af6cd9ee937379e 


Diff: https://reviews.apache.org/r/68222/diff/1/


Testing
---

sudo make check


Thanks,

Qian Zhang



Review Request 68221: Updated `docker/volume` isolator to honor volume mode.

2018-08-06 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68221/
---

Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Bugs: MESOS-8814
https://issues.apache.org/jira/browse/MESOS-8814


Repository: mesos


Description
---

Updated `docker/volume` isolator to honor volume mode.


Diffs
-

  src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 
76f1a5243c8d5028157f795d851b547a5ce57ac9 
  src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
ab749be6234a5eedc0617a131c126129f43f8d62 


Diff: https://reviews.apache.org/r/68221/diff/1/


Testing
---


Thanks,

Qian Zhang



Review Request 68220: Updated the test `ROOT_SecretInVolumeWithRootFilesystem`.

2018-08-06 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68220/
---

Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Bugs: MESOS-8814
https://issues.apache.org/jira/browse/MESOS-8814


Repository: mesos


Description
---

This test is updated to cover both read-write and read-only volume.


Diffs
-

  src/tests/containerizer/volume_secret_isolator_tests.cpp 
11cd3b627b056d1811ab481b8aa599c346181383 


Diff: https://reviews.apache.org/r/68220/diff/1/


Testing
---

sudo make check


Thanks,

Qian Zhang



Review Request 68219: Updated `volume/secret` isolator to honor volume mode.

2018-08-06 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68219/
---

Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Bugs: MESOS-8814
https://issues.apache.org/jira/browse/MESOS-8814


Repository: mesos


Description
---

Updated `volume/secret` isolator to honor volume mode.


Diffs
-

  src/slave/containerizer/mesos/isolators/volume/secret.cpp 
663aafc7173667f8f78b26bdc824a3ab2e04ed25 


Diff: https://reviews.apache.org/r/68219/diff/1/


Testing
---


Thanks,

Qian Zhang



Review Request 68218: Added a test `ROOT_ImageInReadOnlyVolumeWithoutRootFilesystem`.

2018-08-06 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68218/
---

Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Bugs: MESOS-8814
https://issues.apache.org/jira/browse/MESOS-8814


Repository: mesos


Description
---

Added a test `ROOT_ImageInReadOnlyVolumeWithoutRootFilesystem`.


Diffs
-

  src/tests/containerizer/volume_image_isolator_tests.cpp 
b49f0f98e3c31808d8d1e9edbb9a783bfe5231ce 


Diff: https://reviews.apache.org/r/68218/diff/1/


Testing
---

sudo make check


Thanks,

Qian Zhang



Review Request 68216: Updated `volume/image` isolator to honor volume mode.

2018-08-06 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68216/
---

Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Bugs: MESOS-8814
https://issues.apache.org/jira/browse/MESOS-8814


Repository: mesos


Description
---

Updated `volume/image` isolator to honor volume mode.


Diffs
-

  src/slave/containerizer/mesos/isolators/volume/image.hpp 
706b8ff28e1b1c8d15606d54d40622bc09885667 
  src/slave/containerizer/mesos/isolators/volume/image.cpp 
345772439b73b4816f71e15bb4e43a5d67c51c02 


Diff: https://reviews.apache.org/r/68216/diff/1/


Testing
---


Thanks,

Qian Zhang



Review Request 68215: Added a test `VolumeSandboxPathIsolatorTest.ROOT_SelfTypeReadOnly`.

2018-08-06 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68215/
---

Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Bugs: MESOS-8814
https://issues.apache.org/jira/browse/MESOS-8814


Repository: mesos


Description
---

Added a test `VolumeSandboxPathIsolatorTest.ROOT_SelfTypeReadOnly`.


Diffs
-

  src/tests/containerizer/volume_sandbox_path_isolator_tests.cpp 
97b35a4dfb4c5942858bad5fbc743fd205dd4c3c 


Diff: https://reviews.apache.org/r/68215/diff/1/


Testing
---

sudo make check


Thanks,

Qian Zhang



Review Request 68214: Updated `volume/sandbox_path` isolator to honor volume mode.

2018-08-06 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68214/
---

Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Bugs: MESOS-8814
https://issues.apache.org/jira/browse/MESOS-8814


Repository: mesos


Description
---

Updated `volume/sandbox_path` isolator to honor volume mode.


Diffs
-

  src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp 
4896c6811c2c59dcf00871b7a8b6b9b50da0f062 


Diff: https://reviews.apache.org/r/68214/diff/1/


Testing
---


Thanks,

Qian Zhang



Re: Review Request 68203: Updated volume isolators to honor volume mode.

2018-08-06 Thread Qian Zhang


> On Aug. 5, 2018, 1:46 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/volume/host_path.cpp
> > Lines 318 (patched)
> > <https://reviews.apache.org/r/68203/diff/2/?file=2067547#file2067547line319>
> >
> > I'd suggest we separate this patch, and have one patch for each 
> > isolator (we might want to backport a few, like host path volume).
> > 
> > Also, add unit test for each isolator.
> 
> Jie Yu wrote:
> NVM, i saw the subsequent tests. Let's separate this patch please. we 
> might want to backport a few to old releases
> 
> Qian Zhang wrote:
> Agree.

I will discard this patch and the subsequent test patch, and post one patch for 
each isolator.


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68203/#review206864
---


On Aug. 4, 2018, 5:58 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68203/
> ---
> 
> (Updated Aug. 4, 2018, 5:58 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.
> 
> 
> Bugs: MESOS-8814
> https://issues.apache.org/jira/browse/MESOS-8814
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated volume isolators to honor volume mode.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 
> 76f1a5243c8d5028157f795d851b547a5ce57ac9 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
> ab749be6234a5eedc0617a131c126129f43f8d62 
>   src/slave/containerizer/mesos/isolators/volume/host_path.cpp 
> 9127cf4a9d8aa2b16bb5b9903103f1f76a1e2b1a 
>   src/slave/containerizer/mesos/isolators/volume/image.hpp 
> 706b8ff28e1b1c8d15606d54d40622bc09885667 
>   src/slave/containerizer/mesos/isolators/volume/image.cpp 
> 345772439b73b4816f71e15bb4e43a5d67c51c02 
>   src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp 
> 4896c6811c2c59dcf00871b7a8b6b9b50da0f062 
>   src/slave/containerizer/mesos/isolators/volume/secret.cpp 
> 663aafc7173667f8f78b26bdc824a3ab2e04ed25 
> 
> 
> Diff: https://reviews.apache.org/r/68203/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>



Review Request 68213: Added a test `VolumeHostPathIsolatorTest.ROOT_ReadOnlyVolumeFromHost`.

2018-08-06 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68213/
---

Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Bugs: MESOS-8814
https://issues.apache.org/jira/browse/MESOS-8814


Repository: mesos


Description
---

Added a test `VolumeHostPathIsolatorTest.ROOT_ReadOnlyVolumeFromHost`.


Diffs
-

  src/tests/containerizer/volume_host_path_isolator_tests.cpp 
3c925bcb2250ea7aea26443c866ac4bfd26d55b9 


Diff: https://reviews.apache.org/r/68213/diff/1/


Testing
---

sudo make check


Thanks,

Qian Zhang



Review Request 68212: Updated `volume/host_path` isolator to honor volume mode.

2018-08-06 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68212/
---

Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Bugs: MESOS-8814
https://issues.apache.org/jira/browse/MESOS-8814


Repository: mesos


Description
---

Updated `volume/host_path` isolator to honor volume mode.


Diffs
-

  src/slave/containerizer/mesos/isolators/volume/host_path.cpp 
9127cf4a9d8aa2b16bb5b9903103f1f76a1e2b1a 


Diff: https://reviews.apache.org/r/68212/diff/1/


Testing
---


Thanks,

Qian Zhang



Re: Review Request 68203: Updated volume isolators to honor volume mode.

2018-08-06 Thread Qian Zhang


> On Aug. 5, 2018, 1:46 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/volume/host_path.cpp
> > Lines 318 (patched)
> > <https://reviews.apache.org/r/68203/diff/2/?file=2067547#file2067547line319>
> >
> > I'd suggest we separate this patch, and have one patch for each 
> > isolator (we might want to backport a few, like host path volume).
> > 
> > Also, add unit test for each isolator.
> 
> Jie Yu wrote:
> NVM, i saw the subsequent tests. Let's separate this patch please. we 
> might want to backport a few to old releases

Agree.


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68203/#review206864
---


On Aug. 4, 2018, 5:58 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68203/
> ---
> 
> (Updated Aug. 4, 2018, 5:58 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.
> 
> 
> Bugs: MESOS-8814
> https://issues.apache.org/jira/browse/MESOS-8814
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated volume isolators to honor volume mode.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 
> 76f1a5243c8d5028157f795d851b547a5ce57ac9 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
> ab749be6234a5eedc0617a131c126129f43f8d62 
>   src/slave/containerizer/mesos/isolators/volume/host_path.cpp 
> 9127cf4a9d8aa2b16bb5b9903103f1f76a1e2b1a 
>   src/slave/containerizer/mesos/isolators/volume/image.hpp 
> 706b8ff28e1b1c8d15606d54d40622bc09885667 
>   src/slave/containerizer/mesos/isolators/volume/image.cpp 
> 345772439b73b4816f71e15bb4e43a5d67c51c02 
>   src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp 
> 4896c6811c2c59dcf00871b7a8b6b9b50da0f062 
>   src/slave/containerizer/mesos/isolators/volume/secret.cpp 
> 663aafc7173667f8f78b26bdc824a3ab2e04ed25 
> 
> 
> Diff: https://reviews.apache.org/r/68203/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>



Re: Review Request 68203: Updated volume isolators to honor volume mode.

2018-08-04 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68203/
---

(Updated Aug. 4, 2018, 5:58 p.m.)


Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Bugs: MESOS-8814
https://issues.apache.org/jira/browse/MESOS-8814


Repository: mesos


Description
---

Updated volume isolators to honor volume mode.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 
76f1a5243c8d5028157f795d851b547a5ce57ac9 
  src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
ab749be6234a5eedc0617a131c126129f43f8d62 
  src/slave/containerizer/mesos/isolators/volume/host_path.cpp 
9127cf4a9d8aa2b16bb5b9903103f1f76a1e2b1a 
  src/slave/containerizer/mesos/isolators/volume/image.hpp 
706b8ff28e1b1c8d15606d54d40622bc09885667 
  src/slave/containerizer/mesos/isolators/volume/image.cpp 
345772439b73b4816f71e15bb4e43a5d67c51c02 
  src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp 
4896c6811c2c59dcf00871b7a8b6b9b50da0f062 
  src/slave/containerizer/mesos/isolators/volume/secret.cpp 
663aafc7173667f8f78b26bdc824a3ab2e04ed25 


Diff: https://reviews.apache.org/r/68203/diff/2/

Changes: https://reviews.apache.org/r/68203/diff/1-2/


Testing
---


Thanks,

Qian Zhang



Review Request 68204: Added/updated a couple of tests to cover read-only volume.

2018-08-03 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68204/
---

Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Bugs: MESOS-8814
https://issues.apache.org/jira/browse/MESOS-8814


Repository: mesos


Description
---

Added/updated a couple of tests to cover read-only volume.


Diffs
-

  src/tests/containerizer/docker_volume_isolator_tests.cpp 
c15a6fad642474765e4ad1952af6cd9ee937379e 
  src/tests/containerizer/volume_host_path_isolator_tests.cpp 
3c925bcb2250ea7aea26443c866ac4bfd26d55b9 
  src/tests/containerizer/volume_image_isolator_tests.cpp 
b49f0f98e3c31808d8d1e9edbb9a783bfe5231ce 
  src/tests/containerizer/volume_sandbox_path_isolator_tests.cpp 
97b35a4dfb4c5942858bad5fbc743fd205dd4c3c 
  src/tests/containerizer/volume_secret_isolator_tests.cpp 
11cd3b627b056d1811ab481b8aa599c346181383 


Diff: https://reviews.apache.org/r/68204/diff/1/


Testing
---

sudo make check


Thanks,

Qian Zhang



Review Request 68203: Updated volume isolators to honor volume mode.

2018-08-03 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68203/
---

Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Bugs: MESOS-8814
https://issues.apache.org/jira/browse/MESOS-8814


Repository: mesos


Description
---

Updated volume isolators to honor volume mode.


Diffs
-

  src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 
76f1a5243c8d5028157f795d851b547a5ce57ac9 
  src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
ab749be6234a5eedc0617a131c126129f43f8d62 
  src/slave/containerizer/mesos/isolators/volume/host_path.cpp 
9127cf4a9d8aa2b16bb5b9903103f1f76a1e2b1a 
  src/slave/containerizer/mesos/isolators/volume/image.hpp 
706b8ff28e1b1c8d15606d54d40622bc09885667 
  src/slave/containerizer/mesos/isolators/volume/image.cpp 
345772439b73b4816f71e15bb4e43a5d67c51c02 
  src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp 
4896c6811c2c59dcf00871b7a8b6b9b50da0f062 
  src/slave/containerizer/mesos/isolators/volume/secret.cpp 
663aafc7173667f8f78b26bdc824a3ab2e04ed25 


Diff: https://reviews.apache.org/r/68203/diff/1/


Testing
---


Thanks,

Qian Zhang



Re: Review Request 68041: Granted container user permissions for IMAGE volume.

2018-08-03 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68041/
---

(Updated Aug. 4, 2018, 10:49 a.m.)


Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Bugs: MESOS-8811
https://issues.apache.org/jira/browse/MESOS-8811


Repository: mesos


Description
---

Granted container user permissions for IMAGE volume.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/volume/image.hpp 
706b8ff28e1b1c8d15606d54d40622bc09885667 
  src/slave/containerizer/mesos/isolators/volume/image.cpp 
345772439b73b4816f71e15bb4e43a5d67c51c02 


Diff: https://reviews.apache.org/r/68041/diff/2/

Changes: https://reviews.apache.org/r/68041/diff/1-2/


Testing
---


Thanks,

Qian Zhang



Re: Review Request 68162: Added a test `ROOT_UNPRIVILEGED_USER_SharedPersistentVolume`.

2018-08-02 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68162/
---

(Updated Aug. 2, 2018, 5:38 p.m.)


Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Bugs: MESOS-8813
https://issues.apache.org/jira/browse/MESOS-8813


Repository: mesos


Description
---

Added a test `ROOT_UNPRIVILEGED_USER_SharedPersistentVolume`.


Diffs (updated)
-

  src/tests/containerizer/linux_filesystem_isolator_tests.cpp 
84b342cdd4b8ef4803725ecfa9f922687ccdadd8 


Diff: https://reviews.apache.org/r/68162/diff/2/

Changes: https://reviews.apache.org/r/68162/diff/1-2/


Testing
---

sudo make check


Thanks,

Qian Zhang



Review Request 68163: Added a test `UNPRIVILEGED_USER_SharedPersistentVolume`.

2018-08-02 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68163/
---

Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Bugs: MESOS-8813
https://issues.apache.org/jira/browse/MESOS-8813


Repository: mesos


Description
---

Added a test `UNPRIVILEGED_USER_SharedPersistentVolume`.


Diffs
-

  src/tests/persistent_volume_tests.cpp 
6afc56cecbf6f06615dbc8632578332e6f7fb6ae 


Diff: https://reviews.apache.org/r/68163/diff/1/


Testing
---

sudo make check


Thanks,

Qian Zhang



Review Request 68162: Added a test `ROOT_UNPRIVILEGED_USER_SharedPersistentVolume`.

2018-08-02 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68162/
---

Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Bugs: MESOS-8813
https://issues.apache.org/jira/browse/MESOS-8813


Repository: mesos


Description
---

Added a test `ROOT_UNPRIVILEGED_USER_SharedPersistentVolume`.


Diffs
-

  src/tests/containerizer/linux_filesystem_isolator_tests.cpp 
84b342cdd4b8ef4803725ecfa9f922687ccdadd8 


Diff: https://reviews.apache.org/r/68162/diff/1/


Testing
---

sudo make check


Thanks,

Qian Zhang



Re: Review Request 68161: Granted container user permissions for shared persistent volume.

2018-08-02 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68161/
---

(Updated Aug. 2, 2018, 5:31 p.m.)


Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Bugs: MESOS-8813
https://issues.apache.org/jira/browse/MESOS-8813


Repository: mesos


Description
---

Granted container user permissions for shared persistent volume.


Diffs
-

  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
a47899cb528eef103f299def3bd3466905ac5b51 
  src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 
f91a2eeb835bb65a855eeb314d4c69e3b58fecae 


Diff: https://reviews.apache.org/r/68161/diff/1/


Testing
---


Thanks,

Qian Zhang



Review Request 68161: Granted container user permissions for shared persistent volume.

2018-08-02 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68161/
---

Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Bugs: MESOS-8812
https://issues.apache.org/jira/browse/MESOS-8812


Repository: mesos


Description
---

Granted container user permissions for shared persistent volume.


Diffs
-

  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
a47899cb528eef103f299def3bd3466905ac5b51 
  src/slave/containerizer/mesos/isolators/filesystem/posix.cpp 
f91a2eeb835bb65a855eeb314d4c69e3b58fecae 


Diff: https://reviews.apache.org/r/68161/diff/1/


Testing
---


Thanks,

Qian Zhang



Review Request 68127: Add `ROOT_INTERNET_CURL_UNPRIVILEGED_USER_CommandTaskRootfsWithVolume`.

2018-07-31 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68127/
---

Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Bugs: MESOS-8812
https://issues.apache.org/jira/browse/MESOS-8812


Repository: mesos


Description
---

Add `ROOT_INTERNET_CURL_UNPRIVILEGED_USER_CommandTaskRootfsWithVolume`.


Diffs
-

  src/tests/containerizer/docker_volume_isolator_tests.cpp 
c15a6fad642474765e4ad1952af6cd9ee937379e 


Diff: https://reviews.apache.org/r/68127/diff/1/


Testing
---

sudo make check


Thanks,

Qian Zhang



Review Request 68126: Added a test `ROOT_UNPRIVILEGED_USER_CommandTaskNoRootfsWithVolume`.

2018-07-31 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68126/
---

Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Bugs: MESOS-8812
https://issues.apache.org/jira/browse/MESOS-8812


Repository: mesos


Description
---

Added a test `ROOT_UNPRIVILEGED_USER_CommandTaskNoRootfsWithVolume`.


Diffs
-

  src/tests/containerizer/docker_volume_isolator_tests.cpp 
c15a6fad642474765e4ad1952af6cd9ee937379e 


Diff: https://reviews.apache.org/r/68126/diff/1/


Testing
---


Thanks,

Qian Zhang



Review Request 68125: Granted container user permissions for DOCKER_VOLUME volume.

2018-07-31 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68125/
---

Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Bugs: MESOS-8812
https://issues.apache.org/jira/browse/MESOS-8812


Repository: mesos


Description
---

Granted container user permissions for DOCKER_VOLUME volume.


Diffs
-

  src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 
76f1a5243c8d5028157f795d851b547a5ce57ac9 
  src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
ab749be6234a5eedc0617a131c126129f43f8d62 


Diff: https://reviews.apache.org/r/68125/diff/1/


Testing
---


Thanks,

Qian Zhang



Re: Review Request 68068: Added tests for task metadata GC using the default executor.

2018-07-29 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68068/#review206583
---




src/tests/gc_tests.cpp
Lines 729 (patched)
<https://reviews.apache.org/r/68068/#comment289578>

Can we change to use `testing::Sequence` to guarantee the order of status 
updates for each task? You could take the test below as a reference.

https://github.com/apache/mesos/blob/e6c6ab856d4f4829cbe71b60e93bb2c1dc6b44bc/src/tests/default_executor_tests.cpp#L300:L374



src/tests/gc_tests.cpp
Lines 957 (patched)
<https://reviews.apache.org/r/68068/#comment289579>

    Ditto.


- Qian Zhang


On July 27, 2018, 3:01 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68068/
> ---
> 
> (Updated July 27, 2018, 3:01 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Qian Zhang.
> 
> 
> Bugs: MESOS-7947
> https://issues.apache.org/jira/browse/MESOS-7947
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This adds two tests that launch a long-lived and short-lived task
> on the same executor.  The tests expect the short-lived task's
> metadata and sandbox to be garbage collected.
> 
> One test restarts the agent before GC to ensure recovery will
> schedule completed tasks for GC too.
> 
> One existing test is modified due to the extra GC event from
> task metadata.
> 
> 
> Diffs
> -
> 
>   src/tests/gc_tests.cpp 4f288cfd70cc53b4064bced96c3c5d6377c1c421 
>   src/tests/slave_recovery_tests.cpp 69b49220e00a37b0824203ae208813a60b67862e 
> 
> 
> Diff: https://reviews.apache.org/r/68068/diff/2/
> 
> 
> Testing
> ---
> 
> make check (OSX)
> 
> (Other platforms pending...)
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>



Re: Review Request 68065: Enabled garbage collection of terminated tasks' metadata.

2018-07-29 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68065/#review206582
---


Ship it!




- Qian Zhang


On July 27, 2018, 3:01 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68065/
> ---
> 
> (Updated July 27, 2018, 3:01 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Qian Zhang.
> 
> 
> Bugs: MESOS-7947
> https://issues.apache.org/jira/browse/MESOS-7947
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This commit schedules tasks' metadata, whose terminal statuses have been
> acknowledged, for garbage collection.  GC occurs according to the
> existing GC policy (controlled by agent flags --gc_delay and
> --gc_disk_headroom).  This change helps mitigate potential accumulation
> of directories for long-lived, multi-task executors, such as the
> default executor.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp e574c249f81e0e77abe982c126fe210a6ee8b591 
> 
> 
> Diff: https://reviews.apache.org/r/68065/diff/1/
> 
> 
> Testing
> ---
> 
> See last patch in chain.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>



Re: Review Request 68067: Added flag to control GC-ing of nested container sandboxes.

2018-07-29 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68067/#review206577
---




CHANGELOG
Lines 12 (patched)
<https://reviews.apache.org/r/68067/#comment289559>

s/Agent/agent/



CHANGELOG
Lines 13 (patched)
<https://reviews.apache.org/r/68067/#comment289560>

If we only garbage collect sandboxes created via the 
LAUNCH_NESTED_CONTAINER API, should we name this flag 
`--gc_nested_container_sandboxes`? Or we want this flag to cover standalone 
container in future?



docs/configuration/agent.md
Lines 892 (patched)
<https://reviews.apache.org/r/68067/#comment289566>

s/container/nested container/



docs/operator-http-api.md
Lines 3592 (patched)
<https://reviews.apache.org/r/68067/#comment289561>

s/Agent/agent/



docs/operator-http-api.md
Lines 3594-3595 (patched)
<https://reviews.apache.org/r/68067/#comment289565>

A newline between? Or we could merge these two paragraphs into one.



docs/operator-http-api.md
Lines 3595 (patched)
<https://reviews.apache.org/r/68067/#comment289563>

Besides this change, I think we also need to add this flag into the output 
of the agent API `GET_FLAGS` in this doc.



docs/operator-http-api.md
Lines 3596 (patched)
<https://reviews.apache.org/r/68067/#comment289562>

s/Agent/agent/



src/slave/flags.cpp
Lines 469 (patched)
<https://reviews.apache.org/r/68067/#comment289567>

Ditto.


- Qian Zhang


On July 28, 2018, 8:22 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68067/
> ---
> 
> (Updated July 28, 2018, 8:22 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Qian Zhang.
> 
> 
> Bugs: MESOS-7947
> https://issues.apache.org/jira/browse/MESOS-7947
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This adds an agent flag which enables garbage collection of finished
> nested container sandboxes.
> 
> This also updates some documentation and recommends enabling this flag
> when the user uses the same default executor to launch multiple tasks.
> 
> 
> Diffs
> -
> 
>   CHANGELOG 1ef4fe3de8865eb05a2a10ab16fa2cd37d5236fb 
>   docs/configuration/agent.md 83b5fed5a8bf287700688507eaa584f37e8ba2b7 
>   docs/operator-http-api.md 9a37dc55b7279b4b30c87f850aeddf0e83a3c2e7 
>   docs/sandbox.md 3b44112b9b1de7fcb31a9bd3f56289b4ed9e9f13 
>   docs/upgrades.md f3cf0b06fcc4dfa012f44f9cab28f9674b1b8b43 
>   src/slave/flags.hpp eeb9708f9ec76d83b6719541f4a012544c7c0cbe 
>   src/slave/flags.cpp 58cdc0f1100fe244e5bf1036e1ccf39478d5d478 
>   src/slave/http.cpp ab5864d9fd2fde478ed7da2ca7ed8abedc72c7c5 
> 
> 
> Diff: https://reviews.apache.org/r/68067/diff/3/
> 
> 
> Testing
> ---
> 
> See last patch in chain.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>



Re: Review Request 68095: Modified MesosContainerizer to GC nested container sandboxes.

2018-07-29 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68095/#review206578
---




src/slave/containerizer/mesos/containerizer.cpp
Lines 906 (patched)
<https://reviews.apache.org/r/68095/#comment289568>

s/sandboxes/sandbox/



src/slave/containerizer/mesos/containerizer.cpp
Lines 910-912 (patched)
<https://reviews.apache.org/r/68095/#comment289569>

Do we really need `containerId.has_parent()` here? I think the file 
`terminationPath` existing means this must be a nested container since we 
create `TERMINATION_FILE` only for nested container. So maybe this should be a 
check (`CHECK(containerId.has_parent())`)?



src/slave/containerizer/mesos/containerizer.cpp
Lines 916 (patched)
<https://reviews.apache.org/r/68095/#comment289570>

Do we need to make sure `directory` exists before gc it? Otherwise, we may 
gc the same dir again even after it has been removed by gc.



src/slave/containerizer/mesos/containerizer.cpp
Lines 2743-2753 (patched)
<https://reviews.apache.org/r/68095/#comment289571>

Can we merge these code into the above `if (containerId.has_parent()) {`?


- Qian Zhang


On July 28, 2018, 8:22 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68095/
> ---
> 
> (Updated July 28, 2018, 8:22 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Qian Zhang.
> 
> 
> Bugs: MESOS-7947
> https://issues.apache.org/jira/browse/MESOS-7947
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When the --gc_non_executor_container_sandboxes agent flag is enabled,
> this commit changes the MesosContainerizer to schedule nested container
> sandboxes for garbage collection.  The GC policy is the same between
> the MesosContainerizer and the Agent.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.hpp 
> 7711d463c8ed92e2580c56e88d7f372c6dfaeb2b 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 98129d006cda9b65804b518619b6addc8990410a 
> 
> 
> Diff: https://reviews.apache.org/r/68095/diff/1/
> 
> 
> Testing
> ---
> 
> See last patch in chain.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>



Re: Review Request 68067: Added flag to control GC-ing of nested container sandboxes.

2018-07-27 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68067/#review206538
---



I'd prefer to split this patch into two, one for adding the new flag and 
updating the related docs, and another for updating the containerizer's code.


src/slave/flags.hpp
Lines 92 (patched)
<https://reviews.apache.org/r/68067/#comment289504>

We also need to add this flag into `Http::STATE_HELP()` and a couple of 
docs, e.g., `agent.md`, `operator-http-api.md`, `sandbox.md`, `upgrade.md` and 
`CHANGELOG`.


- Qian Zhang


On July 27, 2018, 3:01 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68067/
> ---
> 
> (Updated July 27, 2018, 3:01 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Qian Zhang.
> 
> 
> Bugs: MESOS-7947
> https://issues.apache.org/jira/browse/MESOS-7947
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This adds an agent flag which enables garbage collection of finished
> nested container sandboxes.  Garbage collection follows the same
> policy as the agent (as defined by --gc_delay and --gc_disk_headroom).
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.hpp 
> 7711d463c8ed92e2580c56e88d7f372c6dfaeb2b 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 98129d006cda9b65804b518619b6addc8990410a 
>   src/slave/flags.hpp eeb9708f9ec76d83b6719541f4a012544c7c0cbe 
>   src/slave/flags.cpp 58cdc0f1100fe244e5bf1036e1ccf39478d5d478 
> 
> 
> Diff: https://reviews.apache.org/r/68067/diff/1/
> 
> 
> Testing
> ---
> 
> See last patch in chain.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>



Re: Review Request 67996: Granted container user permissions for SANDBOX volume of PARENT type.

2018-07-26 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67996/
---

(Updated July 26, 2018, 3:46 p.m.)


Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Bugs: MESOS-8810
https://issues.apache.org/jira/browse/MESOS-8810


Repository: mesos


Description
---

Granted container user permissions for SANDBOX volume of PARENT type.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp 
4896c6811c2c59dcf00871b7a8b6b9b50da0f062 
  src/slave/containerizer/mesos/utils.hpp 
bfd07e28c78fc140e395ffccd11d65545bf007fc 
  src/slave/containerizer/mesos/utils.cpp 
30e76d1d91651975033078f5450e45f5f2fd8ba0 


Diff: https://reviews.apache.org/r/67996/diff/3/

Changes: https://reviews.apache.org/r/67996/diff/2-3/


Testing
---


Thanks,

Qian Zhang



Review Request 68044: Added a test `ROOT_UNPRIVILEGED_USER_ImageInVolumeWithRootFilesystem`.

2018-07-25 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68044/
---

Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Bugs: MESOS-8811
https://issues.apache.org/jira/browse/MESOS-8811


Repository: mesos


Description
---

Added a test `ROOT_UNPRIVILEGED_USER_ImageInVolumeWithRootFilesystem`.


Diffs
-

  src/tests/containerizer/volume_image_isolator_tests.cpp 
b49f0f98e3c31808d8d1e9edbb9a783bfe5231ce 


Diff: https://reviews.apache.org/r/68044/diff/1/


Testing
---

sudo make check


Thanks,

Qian Zhang



Review Request 68041: Granted container user permissions for IMAGE volume.

2018-07-25 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68041/
---

Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Bugs: MESOS-8811
https://issues.apache.org/jira/browse/MESOS-8811


Repository: mesos


Description
---

Granted container user permissions for IMAGE volume.


Diffs
-

  src/slave/containerizer/mesos/isolators/volume/image.hpp 
706b8ff28e1b1c8d15606d54d40622bc09885667 
  src/slave/containerizer/mesos/isolators/volume/image.cpp 
345772439b73b4816f71e15bb4e43a5d67c51c02 


Diff: https://reviews.apache.org/r/68041/diff/1/


Testing
---


Thanks,

Qian Zhang



Review Request 68040: Added a new method `getDefaultBackend()` to the provisioner.

2018-07-25 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68040/
---

Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Bugs: MESOS-8811
https://issues.apache.org/jira/browse/MESOS-8811


Repository: mesos


Description
---

Added a new method `getDefaultBackend()` to the provisioner.


Diffs
-

  src/slave/containerizer/mesos/provisioner/provisioner.hpp 
7f84aa499b21140eb29ef7f81e2608743b12eb75 
  src/slave/containerizer/mesos/provisioner/provisioner.cpp 
ac402fbead81e4b356cb35cea08a00049002e870 


Diff: https://reviews.apache.org/r/68040/diff/1/


Testing
---


Thanks,

Qian Zhang



Review Request 68043: Added test `ROOT_UNPRIVILEGED_USER_ImageInVolumeWithoutRootFilesystem`.

2018-07-25 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68043/
---

Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Bugs: MESOS-8811
https://issues.apache.org/jira/browse/MESOS-8811


Repository: mesos


Description
---

Added test `ROOT_UNPRIVILEGED_USER_ImageInVolumeWithoutRootFilesystem`.


Diffs
-

  src/tests/containerizer/volume_image_isolator_tests.cpp 
b49f0f98e3c31808d8d1e9edbb9a783bfe5231ce 


Diff: https://reviews.apache.org/r/68043/diff/1/


Testing
---

sudo make check


Thanks,

Qian Zhang



Re: Review Request 67996: Granted container user permissions for SANDBOX volume of PARENT type.

2018-07-20 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67996/
---

(Updated July 20, 2018, 11:38 p.m.)


Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Bugs: MESOS-8810
https://issues.apache.org/jira/browse/MESOS-8810


Repository: mesos


Description
---

Granted container user permissions for SANDBOX volume of PARENT type.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp 
4896c6811c2c59dcf00871b7a8b6b9b50da0f062 
  src/slave/containerizer/mesos/utils.hpp 
bfd07e28c78fc140e395ffccd11d65545bf007fc 
  src/slave/containerizer/mesos/utils.cpp 
30e76d1d91651975033078f5450e45f5f2fd8ba0 


Diff: https://reviews.apache.org/r/67996/diff/2/

Changes: https://reviews.apache.org/r/67996/diff/1-2/


Testing
---


Thanks,

Qian Zhang



Review Request 67997: Added a test `ROOT_UNPRIVILEGED_USER_ParentTypeDifferentUser`.

2018-07-20 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67997/
---

Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Bugs: MESOS-8810
https://issues.apache.org/jira/browse/MESOS-8810


Repository: mesos


Description
---

Added a test `ROOT_UNPRIVILEGED_USER_ParentTypeDifferentUser`.


Diffs
-

  src/tests/containerizer/volume_sandbox_path_isolator_tests.cpp 
97b35a4dfb4c5942858bad5fbc743fd205dd4c3c 


Diff: https://reviews.apache.org/r/67997/diff/1/


Testing
---

sudo make check


Thanks,

Qian Zhang



Review Request 67996: Granted container user permissions for SANDBOX volume of PARENT type.

2018-07-20 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67996/
---

Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Bugs: MESOS-8810
https://issues.apache.org/jira/browse/MESOS-8810


Repository: mesos


Description
---

Granted container user permissions for SANDBOX volume of PARENT type.


Diffs
-

  src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp 
4896c6811c2c59dcf00871b7a8b6b9b50da0f062 
  src/slave/containerizer/mesos/utils.hpp 
bfd07e28c78fc140e395ffccd11d65545bf007fc 
  src/slave/containerizer/mesos/utils.cpp 
30e76d1d91651975033078f5450e45f5f2fd8ba0 


Diff: https://reviews.apache.org/r/67996/diff/1/


Testing
---


Thanks,

Qian Zhang



Re: Review Request 66814: Added a test `FsAclTest.ManipulateAcl`.

2018-07-20 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66814/
---

(Updated July 20, 2018, 4:13 p.m.)


Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Changes
---

Rebased.


Bugs: MESOS-8809
https://issues.apache.org/jira/browse/MESOS-8809


Repository: mesos


Description
---

Added a test `FsAclTest.ManipulateAcl`.


Diffs (updated)
-

  3rdparty/stout/tests/os/filesystem_tests.cpp 
09d0a40a74a293dcf6eecde2a443281e4b8d9fe8 


Diff: https://reviews.apache.org/r/66814/diff/2/

Changes: https://reviews.apache.org/r/66814/diff/1-2/


Testing
---

sudo make check


Thanks,

Qian Zhang



Re: Review Request 67896: Added container-specific cgroups mount for freezer & systemd subsystems.

2018-07-19 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67896/
---

(Updated July 19, 2018, 5:10 p.m.)


Review request for mesos and Gilbert Song.


Changes
---

Addressed review comments.


Bugs: MESOS-9070
https://issues.apache.org/jira/browse/MESOS-9070


Repository: mesos


Description
---

Added container-specific cgroups mount for freezer & systemd subsystems.


Diffs (updated)
-

  src/slave/containerizer/mesos/constants.hpp 
5be39500828aecad01cbc0e27cb20493048f990e 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
8fba6f9d335cc43a7cd0fcb51ed047ba0e7027ed 
  src/slave/containerizer/mesos/linux_launcher.cpp 
3bddcece7028745cec6623ac33dbfcaced629629 


Diff: https://reviews.apache.org/r/67896/diff/2/

Changes: https://reviews.apache.org/r/67896/diff/1-2/


Testing
---

sudo make check


Thanks,

Qian Zhang



Re: Review Request 67896: Added container-specific cgroups mount for freezer & systemd subsystems.

2018-07-19 Thread Qian Zhang


> On July 19, 2018, 6:46 a.m., Gilbert Song wrote:
> > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp
> > Lines 628 (patched)
> > <https://reviews.apache.org/r/67896/diff/1/?file=2058953#file2058953line628>
> >
> > Should we also use `CGROUP_SEPARATOR` and move it to a common place?

Agree, let me move it to `src/slave/containerizer/mesos/constants.hpp`.


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67896/#review206219
---


On July 12, 2018, 10:16 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67896/
> ---
> 
> (Updated July 12, 2018, 10:16 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-9070
> https://issues.apache.org/jira/browse/MESOS-9070
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added container-specific cgroups mount for freezer & systemd subsystems.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
> 8fba6f9d335cc43a7cd0fcb51ed047ba0e7027ed 
> 
> 
> Diff: https://reviews.apache.org/r/67896/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>



Review Request 67897: Updated two tests to verfiy freezer subsystem.

2018-07-12 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67897/
---

Review request for mesos and Gilbert Song.


Bugs: MESOS-9070
https://issues.apache.org/jira/browse/MESOS-9070


Repository: mesos


Description
---

Updated two tests to verfiy freezer subsystem.


Diffs
-

  src/tests/containerizer/cgroups_isolator_tests.cpp 
3041640c795c8d934870476cf581d704fbcab8c1 


Diff: https://reviews.apache.org/r/67897/diff/1/


Testing
---

sudo make check


Thanks,

Qian Zhang



Review Request 67896: Added container-specific cgroups mount for freezer & systemd subsystems.

2018-07-12 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67896/
---

Review request for mesos and Gilbert Song.


Bugs: MESOS-9070
https://issues.apache.org/jira/browse/MESOS-9070


Repository: mesos


Description
---

Added container-specific cgroups mount for freezer & systemd subsystems.


Diffs
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
8fba6f9d335cc43a7cd0fcb51ed047ba0e7027ed 


Diff: https://reviews.apache.org/r/67896/diff/1/


Testing
---

sudo make check


Thanks,

Qian Zhang



Re: Review Request 67769: Made CNI isolator recovery waits until unknown orphan cleanup is done.

2018-06-29 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67769/
---

(Updated June 29, 2018, 10:40 p.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Changes
---

Addressed Jie's comments.


Bugs: MESOS-9039
https://issues.apache.org/jira/browse/MESOS-9039


Repository: mesos


Description
---

Made CNI isolator recovery waits until unknown orphan cleanup is done.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
dfa26c682333e19d246442def8482b782e7b0d24 


Diff: https://reviews.apache.org/r/67769/diff/3/

Changes: https://reviews.apache.org/r/67769/diff/2-3/


Testing
---

sudo make check


Thanks,

Qian Zhang



Re: Review Request 67737: Updated CNI slave recovery test.

2018-06-28 Thread Qian Zhang


> On June 26, 2018, 3:44 p.m., Qian Zhang wrote:
> > Do we still need to kill the task and wait for `TASK_KILLED`?
> 
> Qian Zhang wrote:
> And is it possible for CNI DEL command gets called after 
> `reregisterExecutorMessage` is received?
> 
> Jie Yu wrote:
> It's not possible. recover containerizer should happen first before 
> executors are allowed to re-register.
> 
> Qian Zhang wrote:
> Yes, agent will recover containerizer first before executors are allowed 
> to re-register, but CNI DEL command is called in an asynchronous way which 
> means it is possible that CNI DEL command gets called after executor 
> re-registers agent (if the CNI plugin need a bit long time to handle the DEL 
> command). I tried the following to prove it.
> 1. Revert the patch https://reviews.apache.org/r/67728/ .
> 2. Modify the mock CNI plugin used in this test to slow it down a bit.
> ```
> diff --git a/src/tests/containerizer/cni_isolator_tests.cpp 
> b/src/tests/containerizer/cni_isolator_tests.cpp
> index b282e1070..d266fcb40 100644
> --- a/src/tests/containerizer/cni_isolator_tests.cpp
> +++ b/src/tests/containerizer/cni_isolator_tests.cpp
> @@ -521,6 +521,7 @@ TEST_F(CniIsolatorTest, ROOT_SlaveRecovery)
>  echo '  }'
>  echo '}'
>else
> +sleep 0.1
>  touch %s
>fi
>)~",
> ```
> And then this test will succeed. That means this test may not be enough 
> to catch the regression described in MESOS-9025.

Created a ticket https://issues.apache.org/jira/browse/MESOS-9039 to fix the 
issue that I mentioned above.


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67737/#review205352
---


On June 26, 2018, 1:36 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67737/
> -------
> 
> (Updated June 26, 2018, 1:36 p.m.)
> 
> 
> Review request for mesos and Qian Zhang.
> 
> 
> Bugs: MESOS-9025
> https://issues.apache.org/jira/browse/MESOS-9025
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the test so that it can catch regression described in
> MESOS-9025. This test fails without the fix for MESOS-9025 and passes
> after the fix.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/cni_isolator_tests.cpp 
> b58a9caca136cfa42689159389bfdcb3f92f05ee 
> 
> 
> Diff: https://reviews.apache.org/r/67737/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>



Re: Review Request 67769: Made CNI isolator recovery waits until unknown orphan cleanup is done.

2018-06-28 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67769/
---

(Updated June 29, 2018, 9:41 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-9039
https://issues.apache.org/jira/browse/MESOS-9039


Repository: mesos


Description
---

Made CNI isolator recovery waits until unknown orphan cleanup is done.


Diffs
-

  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
dfa26c682333e19d246442def8482b782e7b0d24 


Diff: https://reviews.apache.org/r/67769/diff/2/


Testing
---

sudo make check


Thanks,

Qian Zhang



Re: Review Request 67769: Made CNI isolator recovery waits until unknown orphan cleanup is done.

2018-06-28 Thread Qian Zhang


> On June 29, 2018, 12:24 a.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp
> > Line 440 (original), 442 (patched)
> > <https://reviews.apache.org/r/67769/diff/1/?file=2046789#file2046789line442>
> >
> > I would use 'await' here so that the agent will still start if cleanup 
> > fails.

Do we need to change `collect` to `await` for 
`LinuxFilesystemIsolatorProcess::recover()` too?


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67769/#review205516
-------


On June 29, 2018, 9:20 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67769/
> ---
> 
> (Updated June 29, 2018, 9:20 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Made CNI isolator recovery waits until unknown orphan cleanup is done.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
> dfa26c682333e19d246442def8482b782e7b0d24 
> 
> 
> Diff: https://reviews.apache.org/r/67769/diff/2/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>



Re: Review Request 67769: Made CNI isolator recovery waits until unknown orphan cleanup is done.

2018-06-28 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67769/
---

(Updated June 29, 2018, 9:20 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Changes
---

Addressed comments.


Repository: mesos


Description
---

Made CNI isolator recovery waits until unknown orphan cleanup is done.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
dfa26c682333e19d246442def8482b782e7b0d24 


Diff: https://reviews.apache.org/r/67769/diff/2/

Changes: https://reviews.apache.org/r/67769/diff/1-2/


Testing
---

sudo make check


Thanks,

Qian Zhang



Review Request 67769: Made CNI isolator recovery waits until unknown orphan cleanup is done.

2018-06-28 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67769/
---

Review request for mesos, Gilbert Song and Jie Yu.


Repository: mesos


Description
---

Made CNI isolator recovery waits until unknown orphan cleanup is done.


Diffs
-

  src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
dfa26c682333e19d246442def8482b782e7b0d24 


Diff: https://reviews.apache.org/r/67769/diff/1/


Testing
---

sudo make check


Thanks,

Qian Zhang



Review Request 67767: Removed the isolators ordering check from `gpu/nvidia` isolator.

2018-06-28 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67767/
---

Review request for mesos, Gilbert Song and James Peach.


Repository: mesos


Description
---

We do not need to check the isolators ordering because we have made
the order of built-in isolators fixed in MESOS-7643.


Diffs
-

  src/slave/containerizer/mesos/isolators/gpu/isolator.cpp 
50668828a9167a2a190922a534c37b145cbfb784 


Diff: https://reviews.apache.org/r/67767/diff/1/


Testing
---

sudo make check


Thanks,

Qian Zhang



Re: Review Request 67737: Updated CNI slave recovery test.

2018-06-27 Thread Qian Zhang


> On June 26, 2018, 3:44 p.m., Qian Zhang wrote:
> > Do we still need to kill the task and wait for `TASK_KILLED`?
> 
> Qian Zhang wrote:
> And is it possible for CNI DEL command gets called after 
> `reregisterExecutorMessage` is received?
> 
> Jie Yu wrote:
> It's not possible. recover containerizer should happen first before 
> executors are allowed to re-register.

Yes, agent will recover containerizer first before executors are allowed to 
re-register, but CNI DEL command is called in an asynchronous way which means 
it is possible that CNI DEL command gets called after executor re-registers 
agent (if the CNI plugin need a bit long time to handle the DEL command). I 
tried the following to prove it.
1. Revert the patch https://reviews.apache.org/r/67728/ .
2. Modify the mock CNI plugin used in this test to slow it down a bit.
```
diff --git a/src/tests/containerizer/cni_isolator_tests.cpp 
b/src/tests/containerizer/cni_isolator_tests.cpp
index b282e1070..d266fcb40 100644
--- a/src/tests/containerizer/cni_isolator_tests.cpp
+++ b/src/tests/containerizer/cni_isolator_tests.cpp
@@ -521,6 +521,7 @@ TEST_F(CniIsolatorTest, ROOT_SlaveRecovery)
 echo '  }'
 echo '}'
   else
+sleep 0.1
 touch %s
   fi
   )~",
```
And then this test will succeed. That means this test may not be enough to 
catch the regression described in MESOS-9025.


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67737/#review205352
---


On June 26, 2018, 1:36 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67737/
> ---
> 
> (Updated June 26, 2018, 1:36 p.m.)
> 
> 
> Review request for mesos and Qian Zhang.
> 
> 
> Bugs: MESOS-9025
> https://issues.apache.org/jira/browse/MESOS-9025
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the test so that it can catch regression described in
> MESOS-9025. This test fails without the fix for MESOS-9025 and passes
> after the fix.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/cni_isolator_tests.cpp 
> b58a9caca136cfa42689159389bfdcb3f92f05ee 
> 
> 
> Diff: https://reviews.apache.org/r/67737/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>



Re: Review Request 67737: Updated CNI slave recovery test.

2018-06-26 Thread Qian Zhang


> On June 26, 2018, 3:44 p.m., Qian Zhang wrote:
> > Do we still need to kill the task and wait for `TASK_KILLED`?

And is it possible for CNI DEL command gets called after 
`reregisterExecutorMessage` is received?


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67737/#review205352
---


On June 26, 2018, 1:36 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67737/
> ---
> 
> (Updated June 26, 2018, 1:36 p.m.)
> 
> 
> Review request for mesos and Qian Zhang.
> 
> 
> Bugs: MESOS-9025
> https://issues.apache.org/jira/browse/MESOS-9025
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the test so that it can catch regression described in
> MESOS-9025. This test fails without the fix for MESOS-9025 and passes
> after the fix.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/cni_isolator_tests.cpp 
> b58a9caca136cfa42689159389bfdcb3f92f05ee 
> 
> 
> Diff: https://reviews.apache.org/r/67737/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>



Review Request 67743: Made `gpu/nvidia` isolator works with `cgroups/all` isolation option.

2018-06-26 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67743/
---

Review request for mesos and Gilbert Song.


Bugs: MESOS-9027
https://issues.apache.org/jira/browse/MESOS-9027


Repository: mesos


Description
---

Made `gpu/nvidia` isolator works with `cgroups/all` isolation option.


Diffs
-

  src/slave/containerizer/mesos/isolators/gpu/isolator.cpp 
d79c940498fe3cfeeaddad5f5e5e21fcdf4e04da 


Diff: https://reviews.apache.org/r/67743/diff/1/


Testing
---

sudo make check


Thanks,

Qian Zhang



Re: Review Request 67737: Updated CNI slave recovery test.

2018-06-26 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67737/#review205352
---


Ship it!




Do we still need to kill the task and wait for `TASK_KILLED`?

- Qian Zhang


On June 26, 2018, 1:36 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67737/
> ---
> 
> (Updated June 26, 2018, 1:36 p.m.)
> 
> 
> Review request for mesos and Qian Zhang.
> 
> 
> Bugs: MESOS-9025
> https://issues.apache.org/jira/browse/MESOS-9025
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the test so that it can catch regression described in
> MESOS-9025. This test fails without the fix for MESOS-9025 and passes
> after the fix.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/cni_isolator_tests.cpp 
> b58a9caca136cfa42689159389bfdcb3f92f05ee 
> 
> 
> Diff: https://reviews.apache.org/r/67737/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>



Review Request 67739: Documented the container-specific cgroups mounts feature.

2018-06-26 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67739/
---

Review request for mesos, Gilbert Song and Jason Lai.


Bugs: MESOS-8327
https://issues.apache.org/jira/browse/MESOS-8327


Repository: mesos


Description
---

Documented the container-specific cgroups mounts feature.


Diffs
-

  CHANGELOG 0e44277389e5a96c221d6c3d501da2bb93d27faa 
  docs/upgrades.md cc8a251945af27a432dbeb5585b998cd84e35b22 


Diff: https://reviews.apache.org/r/67739/diff/1/


Testing
---

Not a code change.


Thanks,

Qian Zhang



Re: Review Request 67728: Fixed orphan container cleanup issue in CNI isolator.

2018-06-25 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67728/#review205339
---


Ship it!




Ship It!

- Qian Zhang


On June 26, 2018, 3 a.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67728/
> ---
> 
> (Updated June 26, 2018, 3 a.m.)
> 
> 
> Review request for mesos, Qian Zhang and Sagar Patwardhan.
> 
> 
> Bugs: MESOS-9025
> https://issues.apache.org/jira/browse/MESOS-9025
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The bug was introduced in https://reviews.apache.org/r/65987/ when we
> want to allow nested container to have a separate network namespace than
> its parent (MESOS-8534).
> 
> The original code misses a `continue` statement after recovering regular
> containers.
> 
> I am surprised that the unit tests didn't catch the bug. We'll add a new
> unit test for catching the regression.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
> b6ad4fcf9f1596c07ddeb9bbb134f4619d189671 
> 
> 
> Diff: https://reviews.apache.org/r/67728/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>



Re: Review Request 67564: Added a test `ROOT_CGROUPS_NestedContainerSpecificCgroupsMount`.

2018-06-25 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67564/
---

(Updated June 25, 2018, 9:56 p.m.)


Review request for mesos, Gilbert Song and Jason Lai.


Changes
---

Addressed review comments.


Bugs: MESOS-8327
https://issues.apache.org/jira/browse/MESOS-8327


Repository: mesos


Description
---

Added a test `ROOT_CGROUPS_NestedContainerSpecificCgroupsMount`.


Diffs (updated)
-

  src/tests/containerizer/cgroups_isolator_tests.cpp 
d1028e351c2ff395adc48489169597adbb0ce857 


Diff: https://reviews.apache.org/r/67564/diff/3/

Changes: https://reviews.apache.org/r/67564/diff/2-3/


Testing
---

sudo make check


Thanks,

Qian Zhang



Re: Review Request 67526: Added container-specific cgroup FS mounts.

2018-06-25 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67526/
---

(Updated June 25, 2018, 9:56 p.m.)


Review request for mesos, Gilbert Song and Jason Lai.


Changes
---

Addressed review comments.


Bugs: MESOS-8327
https://issues.apache.org/jira/browse/MESOS-8327


Repository: mesos


Description
---

Added container-specific cgroup FS mounts.


Diffs (updated)
-

  src/launcher/executor.cpp 541ca5b9c4bfb33a6cf341b13007ee8e881a7d89 
  src/linux/fs.cpp 6b38b4a87984f8a62c64b74eb91c96b847b59643 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 
81c934318dcc2bcc9df594af0ee25f0334541a65 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
6d146729123b85e46f580a594fb9f9ac37b542f7 


Diff: https://reviews.apache.org/r/67526/diff/5/

Changes: https://reviews.apache.org/r/67526/diff/4-5/


Testing
---


Thanks,

Qian Zhang



Re: Review Request 67526: Added container-specific cgroup FS mounts.

2018-06-25 Thread Qian Zhang


> On June 23, 2018, 8:21 a.m., Gilbert Song wrote:
> > src/launcher/executor.cpp
> > Lines 1281 (patched)
> > <https://reviews.apache.org/r/67526/diff/4/?file=2042656#file2042656line1281>
> >
> > Just bring this up: 
> > 
> > why don't we just call it `container_launch_info`, or 
> > `task_launch_info`?
> > 
> > I may prefer `task_launch_info` more, wdyt?

Agree.


> On June 23, 2018, 8:21 a.m., Gilbert Song wrote:
> > src/linux/fs.cpp
> > Lines 784 (patched)
> > <https://reviews.apache.org/r/67526/diff/4/?file=2042657#file2042657line784>
> >
> > Could you remind me again how do we handle centos 6?

We will always do this mount for any supported platforms. So even cgroups are 
mounted under `/cgroup` in CentOS 6 host, we will still do the bind mount under 
`/sys/fs/cgroup` for the container launched on CentOS 6 host.


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67526/#review205256
---


On June 20, 2018, 10:48 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67526/
> ---
> 
> (Updated June 20, 2018, 10:48 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jason Lai.
> 
> 
> Bugs: MESOS-8327
> https://issues.apache.org/jira/browse/MESOS-8327
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added container-specific cgroup FS mounts.
> 
> 
> Diffs
> -
> 
>   src/launcher/executor.cpp 541ca5b9c4bfb33a6cf341b13007ee8e881a7d89 
>   src/linux/fs.cpp 6b38b4a87984f8a62c64b74eb91c96b847b59643 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 
> 81c934318dcc2bcc9df594af0ee25f0334541a65 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
> 6d146729123b85e46f580a594fb9f9ac37b542f7 
> 
> 
> Diff: https://reviews.apache.org/r/67526/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>



Re: Review Request 67662: Allowed mounts if the container is launched in a new mount namespace.

2018-06-25 Thread Qian Zhang


> On June 23, 2018, 8:07 a.m., Gilbert Song wrote:
> > src/slave/containerizer/mesos/launch.cpp
> > Lines 676-680 (original)
> > <https://reviews.apache.org/r/67662/diff/1/?file=2042649#file2042649line676>
> >
> > I just created https://issues.apache.org/jira/browse/MESOS-9023
> > 
> > Could we add a TODO which mention that we want to add this check back 
> > once MESOS-9023 is resolved?
> > 
> > The reason we need this check is mount propagation, see 
> > `MountPropagation` protobuf message in mesos.proto. Currently we do allow 
> > users to configure whether they want the mounts for a container to 
> > propagate back to the host filesystems. We don't want to allow it for 
> > command task.

If we do not want to allow the mounts for a container to propagate back to the 
host filesystems for command task, then we need to ensure there is no mounts 
with `MS_SHARED` rather than simply disallowing any mounts, right?


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67662/#review205255
-------


On June 20, 2018, 10:37 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67662/
> ---
> 
> (Updated June 20, 2018, 10:37 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jason Lai.
> 
> 
> Bugs: MESOS-8327
> https://issues.apache.org/jira/browse/MESOS-8327
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Allowed mounts if the container is launched in a new mount namespace.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/launch.cpp 
> cec6558d0ac61bf0fec87d2e101e8f84730a765a 
> 
> 
> Diff: https://reviews.apache.org/r/67662/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>



Re: Review Request 66875: Added an hourly timer for docker store pull latency.

2018-06-20 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66875/#review205144
---


Fix it, then Ship it!





src/slave/containerizer/mesos/provisioner/docker/store.cpp
Lines 40 (patched)
<https://reviews.apache.org/r/66875/#comment288106>

Why do we need this header file?



src/slave/containerizer/mesos/provisioner/docker/store.cpp
Lines 104-106 (patched)
<https://reviews.apache.org/r/66875/#comment288105>

A space missed between `)` and `:`.

And can we merge these 3 line codes into 2 lines?
```
Metrics() : image_pull(
  "containerizer/mesos/provisioner/docker_store/image_pull", 
Hours(1))
```



src/slave/containerizer/mesos/provisioner/docker/store.cpp
Lines 111 (patched)
<https://reviews.apache.org/r/66875/#comment288104>

    Kill this blank line.


- Qian Zhang


On June 21, 2018, 2:26 a.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66875/
> ---
> 
> (Updated June 21, 2018, 2:26 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jason Lai, Jie Yu, and Qian Zhang.
> 
> 
> Bugs: MESOS-6451
> https://issues.apache.org/jira/browse/MESOS-6451
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch added pull latency tracking for docker store, which can tell
> us both latency distribution of pull as well as number of pulls.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 
> 6e7dc44321bff3198e5ffe69be1ba329be3ee31e 
> 
> 
> Diff: https://reviews.apache.org/r/66875/diff/3/
> 
> 
> Testing
> ---
> 
> Ran agent in command line and trigger several launches through 
> `mesos-execute`, observed following metrics from agent endpoint:
> 
> ```
>   "containerizer/mesos/provisioner/docker_store/image_pull_ms": 3619.53408,
>   "containerizer/mesos/provisioner/docker_store/image_pull_ms/count": 2,
>   "containerizer/mesos/provisioner/docker_store/image_pull_ms/max": 
> 4208.662016,
>   "containerizer/mesos/provisioner/docker_store/image_pull_ms/min": 
> 3619.53408,
>   "containerizer/mesos/provisioner/docker_store/image_pull_ms/p50": 
> 3914.098048,
>   "containerizer/mesos/provisioner/docker_store/image_pull_ms/p90": 
> 4149.7492224,
>   "containerizer/mesos/provisioner/docker_store/image_pull_ms/p95": 
> 4179.2056192,
>   "containerizer/mesos/provisioner/docker_store/image_pull_ms/p99": 
> 4202.77073664,
>   "containerizer/mesos/provisioner/docker_store/image_pull_ms/p999": 
> 4208.072888064,
>   "containerizer/mesos/provisioner/docker_store/image_pull_ms/p": 
> 4208.6031032064,
> ```
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>



Re: Review Request 53105: Added an hourly timer for `containerizer/docker/image_pull`.

2018-06-20 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53105/#review205143
---


Fix it, then Ship it!





src/slave/containerizer/docker.hpp
Lines 177 (patched)
<https://reviews.apache.org/r/53105/#comment288103>

Better to change to:
```
  struct Metrics
  {
```


- Qian Zhang


On June 21, 2018, 2:25 a.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53105/
> ---
> 
> (Updated June 21, 2018, 2:25 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jason Lai, Jie Yu, and Qian Zhang.
> 
> 
> Bugs: MESOS-6451
> https://issues.apache.org/jira/browse/MESOS-6451
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added an hourly timer for `containerizer/docker/image_pull`.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.hpp 1ed47c85f765da6fb91a2a243fcc5030e9686190 
>   src/slave/containerizer/docker.cpp f83036aa5a212d1d88e6f5aa41023abc125f7116 
> 
> 
> Diff: https://reviews.apache.org/r/53105/diff/6/
> 
> 
> Testing
> ---
> 
> Ran `mesos-execute` with a docker image and docker containerizer twice, 
> observed the following metrics:
> ```
> curl -s localhost:5051/metrics/snapshot | jq .
>   "containerizer/docker/image_pull_ms": 6628.833024,
>   "containerizer/docker/image_pull_ms/count": 2,
>   "containerizer/docker/image_pull_ms/max": 8851.497216,
>   "containerizer/docker/image_pull_ms/min": 6628.833024,
>   "containerizer/docker/image_pull_ms/p50": 7740.16512,
>   "containerizer/docker/image_pull_ms/p90": 8629.2307968,
>   "containerizer/docker/image_pull_ms/p95": 8740.3640064,
>   "containerizer/docker/image_pull_ms/p99": 8829.27057408,
>   "containerizer/docker/image_pull_ms/p999": 8849.274551808,
>   "containerizer/docker/image_pull_ms/p": 8851.2749495808,
> ```
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>



Re: Review Request 67673: Removed an unused member variable `hierarchies` from cgroups isolator.

2018-06-20 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67673/
---

(Updated June 20, 2018, 10:33 p.m.)


Review request for mesos, Gilbert Song and Jason Lai.


Bugs: MESOS-8327
https://issues.apache.org/jira/browse/MESOS-8327


Repository: mesos


Description
---

Removed an unused member variable `hierarchies` from cgroups isolator.


Diffs
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 
81c934318dcc2bcc9df594af0ee25f0334541a65 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
6d146729123b85e46f580a594fb9f9ac37b542f7 


Diff: https://reviews.apache.org/r/67673/diff/1/


Testing (updated)
---

sudo make check


Thanks,

Qian Zhang



Review Request 67673: Removed an unused member variable `hierarchies` from cgroups isolator.

2018-06-20 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67673/
---

Review request for mesos, Gilbert Song and Jason Lai.


Bugs: MESOS-8327
https://issues.apache.org/jira/browse/MESOS-8327


Repository: mesos


Description
---

Removed an unused member variable `hierarchies` from cgroups isolator.


Diffs
-

  src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 
81c934318dcc2bcc9df594af0ee25f0334541a65 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
6d146729123b85e46f580a594fb9f9ac37b542f7 


Diff: https://reviews.apache.org/r/67673/diff/1/


Testing
---


Thanks,

Qian Zhang



Re: Review Request 66875: Added an hourly timer for docker store pull latency.

2018-06-20 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66875/#review205053
---




src/slave/containerizer/mesos/provisioner/docker/store.cpp
Lines 86 (patched)
<https://reviews.apache.org/r/66875/#comment287931>

I'd name it 
`image_pull("containerizer/mesos/provisioner/docker_store/image_pull", 
Hours(1))`


- Qian Zhang


On May 22, 2018, 1:16 a.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66875/
> ---
> 
> (Updated May 22, 2018, 1:16 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jason Lai, Jie Yu, and Qian Zhang.
> 
> 
> Bugs: MESOS-6451
> https://issues.apache.org/jira/browse/MESOS-6451
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch added pull latency tracking for docker store, which can tell
> us both latency distribution of pull as well as number of pulls.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/store.cpp 
> 8b3f07f5027cb90d4b4ed401960494709d3eda5f 
> 
> 
> Diff: https://reviews.apache.org/r/66875/diff/2/
> 
> 
> Testing
> ---
> 
> Ran agent in command line and trigger several launches through 
> `mesos-execute`, observed following metrics from agent endpoint:
> 
> ```
>   "containerizer/mesos/docker_store/pull_ms": 4084.254208,
>   "containerizer/mesos/docker_store/pull_ms/count": 2,
>   "containerizer/mesos/docker_store/pull_ms/max": 4084.254208,
>   "containerizer/mesos/docker_store/pull_ms/min": 3525.044736,
>   "containerizer/mesos/docker_store/pull_ms/p50": 3804.649472,
>   "containerizer/mesos/docker_store/pull_ms/p90": 4028.3332608,
>   "containerizer/mesos/docker_store/pull_ms/p95": 4056.2937344,
>   "containerizer/mesos/docker_store/pull_ms/p99": 4078.66211328,
>   "containerizer/mesos/docker_store/pull_ms/p999": 4083.694998528,
>   "containerizer/mesos/docker_store/pull_ms/p": 4084.1982870528,
> ```
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>



Re: Review Request 53105: Added an hourly timer for `slave/docker_containerizer/pull`.

2018-06-20 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53105/#review205049
---




src/slave/containerizer/docker.hpp
Lines 27-28 (original), 27-30 (patched)
<https://reviews.apache.org/r/53105/#comment287930>

Should be:
```
#include 
#include 

#include 
#include 

```



src/slave/containerizer/docker.hpp
Lines 140 (patched)
<https://reviews.apache.org/r/53105/#comment287927>

It seems the convention in Mesos is to implement a `struct Metrics` for all 
the metrics rather than directly adding the metric here. And the name of the 
metric should be in underscore_case instead of camelCase, so I would suggest to 
name it `image_pull("containerizer/docker/image_pull", Hours(1))`.

And is 1 hour too short for this metric?



src/slave/containerizer/docker.cpp
Lines 448-453 (original), 448-454 (patched)
<https://reviews.apache.org/r/53105/#comment287929>

Can we do it in this way?
```
  Future future = pullTimer.time(docker->pull(
container->containerWorkDir,
image,
container->forcePullImage()));
```


- Qian Zhang


On May 22, 2018, 1:16 a.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53105/
> ---
> 
> (Updated May 22, 2018, 1:16 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jason Lai, Jie Yu, and Qian Zhang.
> 
> 
> Bugs: MESOS-6451
> https://issues.apache.org/jira/browse/MESOS-6451
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added an hourly timer for `slave/docker_containerizer/pull`.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.hpp 6bdf4c7f60384473927de437a061fafe94170557 
>   src/slave/containerizer/docker.cpp a4c9c10e91e75f406329cbb2086f39b549cbeed0 
> 
> 
> Diff: https://reviews.apache.org/r/53105/diff/5/
> 
> 
> Testing
> ---
> 
> Ran `mesos-execute` with a docker image and docker containerizer, observed 
> the following metrics:
> ```
> curl -s localhost:5051/metrics/snapshot | jq . | grep pull
>   "containerizer/docker/pull_ms/p999": 26209.36173824,
>   "containerizer/docker/pull_ms/p90": 21036.405248,
>   "containerizer/docker/pull_ms/p": 26256.388615424,
>   "containerizer/docker/pull_ms/p50": 135.570944,
>   "containerizer/docker/pull_ms/max": 26261.613824,
>   "containerizer/docker/pull_ms/p95": 23649.009536,
>   "containerizer/docker/pull_ms/min": 103.215872,
>   "containerizer/docker/pull_ms/p99": 25739.0929664,
>   "containerizer/docker/pull_ms": 26261.613824,
>   "containerizer/docker/pull_ms/count": 3
> ```
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>



Re: Review Request 67526: Added container-specific cgroup FS mounts.

2018-06-19 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67526/
---

(Updated June 20, 2018, 10:48 a.m.)


Review request for mesos, Gilbert Song and Jason Lai.


Bugs: MESOS-8327
https://issues.apache.org/jira/browse/MESOS-8327


Repository: mesos


Description
---

Added container-specific cgroup FS mounts.


Diffs (updated)
-

  src/launcher/executor.cpp 541ca5b9c4bfb33a6cf341b13007ee8e881a7d89 
  src/linux/fs.cpp 6b38b4a87984f8a62c64b74eb91c96b847b59643 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 
81c934318dcc2bcc9df594af0ee25f0334541a65 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
6d146729123b85e46f580a594fb9f9ac37b542f7 


Diff: https://reviews.apache.org/r/67526/diff/4/

Changes: https://reviews.apache.org/r/67526/diff/3-4/


Testing
---


Thanks,

Qian Zhang



Re: Review Request 67565: Added a test `ROOT_CGROUPS_CommandTaskSpecificCgroupsMount`.

2018-06-19 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67565/
---

(Updated June 20, 2018, 10:40 a.m.)


Review request for mesos, Gilbert Song and Jason Lai.


Bugs: MESOS-8327
https://issues.apache.org/jira/browse/MESOS-8327


Repository: mesos


Description
---

Added a test `ROOT_CGROUPS_CommandTaskSpecificCgroupsMount`.


Diffs (updated)
-

  src/tests/containerizer/cgroups_isolator_tests.cpp 
d1028e351c2ff395adc48489169597adbb0ce857 


Diff: https://reviews.apache.org/r/67565/diff/3/

Changes: https://reviews.apache.org/r/67565/diff/2-3/


Testing
---

sudo make check


Thanks,

Qian Zhang



Review Request 67662: Allowed mounts if the container is launched in a new mount namespace.

2018-06-19 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67662/
---

Review request for mesos, Gilbert Song and Jason Lai.


Bugs: MESOS-8327
https://issues.apache.org/jira/browse/MESOS-8327


Repository: mesos


Description
---

Allowed mounts if the container is launched in a new mount namespace.


Diffs
-

  src/slave/containerizer/mesos/launch.cpp 
cec6558d0ac61bf0fec87d2e101e8f84730a765a 


Diff: https://reviews.apache.org/r/67662/diff/1/


Testing
---


Thanks,

Qian Zhang



Re: Review Request 67564: Added a test `ROOT_CGROUPS_NestedContainerSpecificCgroupsMount`.

2018-06-15 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67564/
---

(Updated June 15, 2018, 7:54 p.m.)


Review request for mesos, Gilbert Song and Jason Lai.


Bugs: MESOS-8327
https://issues.apache.org/jira/browse/MESOS-8327


Repository: mesos


Description
---

Added a test `ROOT_CGROUPS_NestedContainerSpecificCgroupsMount`.


Diffs (updated)
-

  src/tests/containerizer/cgroups_isolator_tests.cpp 
231e9588c0d831c05a1d84f35f0f68105900789c 


Diff: https://reviews.apache.org/r/67564/diff/2/

Changes: https://reviews.apache.org/r/67564/diff/1-2/


Testing
---

sudo make check


Thanks,

Qian Zhang



Re: Review Request 67565: Added a test `ROOT_CGROUPS_CommandTaskSpecificCgroupsMount`.

2018-06-15 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67565/
---

(Updated June 15, 2018, 7:55 p.m.)


Review request for mesos, Gilbert Song and Jason Lai.


Bugs: MESOS-8327
https://issues.apache.org/jira/browse/MESOS-8327


Repository: mesos


Description
---

Added a test `ROOT_CGROUPS_CommandTaskSpecificCgroupsMount`.


Diffs (updated)
-

  src/tests/containerizer/cgroups_isolator_tests.cpp 
231e9588c0d831c05a1d84f35f0f68105900789c 


Diff: https://reviews.apache.org/r/67565/diff/2/

Changes: https://reviews.apache.org/r/67565/diff/1-2/


Testing
---

sudo make check


Thanks,

Qian Zhang



Re: Review Request 67526: Added container-specific cgroup FS mounts.

2018-06-15 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67526/
---

(Updated June 15, 2018, 7:53 p.m.)


Review request for mesos, Gilbert Song and Jason Lai.


Changes
---

Only do container-specific cgroups mounts for container with rootfs.


Bugs: MESOS-8327
https://issues.apache.org/jira/browse/MESOS-8327


Repository: mesos


Description
---

Added container-specific cgroup FS mounts.


Diffs (updated)
-

  src/linux/fs.cpp 6b38b4a87984f8a62c64b74eb91c96b847b59643 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 
81c934318dcc2bcc9df594af0ee25f0334541a65 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
215e32461e851668247f9fae62aa656f5dd5e245 


Diff: https://reviews.apache.org/r/67526/diff/3/

Changes: https://reviews.apache.org/r/67526/diff/2-3/


Testing
---


Thanks,

Qian Zhang



Re: Review Request 67381: Added `cgroups/all` into CHANGELOG and upgrades.md.

2018-06-13 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67381/
---

(Updated June 14, 2018, 9:41 a.m.)


Review request for mesos and Gilbert Song.


Bugs: MESOS-7691
https://issues.apache.org/jira/browse/MESOS-7691


Repository: mesos


Description
---

Added `cgroups/all` into CHANGELOG and upgrades.md.


Diffs (updated)
-

  CHANGELOG 0c45af66cbe1c6feede328143d30dad4eaf1a4b3 
  docs/upgrades.md 18632edd20fcf943c6e7147aca3fec5b5521f14f 


Diff: https://reviews.apache.org/r/67381/diff/4/

Changes: https://reviews.apache.org/r/67381/diff/3-4/


Testing
---

Not a code change.


Thanks,

Qian Zhang



Re: Review Request 67358: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_AutoLoadSubsystems`.

2018-06-13 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67358/
---

(Updated June 13, 2018, 10:25 p.m.)


Review request for mesos and Gilbert Song.


Summary (updated)
-

Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_AutoLoadSubsystems`.


Bugs: MESOS-7691
https://issues.apache.org/jira/browse/MESOS-7691


Repository: mesos


Description (updated)
---

Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_AutoLoadSubsystems`.


Diffs (updated)
-

  src/tests/containerizer/cgroups_isolator_tests.cpp 
231e9588c0d831c05a1d84f35f0f68105900789c 


Diff: https://reviews.apache.org/r/67358/diff/3/

Changes: https://reviews.apache.org/r/67358/diff/2-3/


Testing
---

Ran this test repeatedly


Thanks,

Qian Zhang



Re: Review Request 67343: Automatically loaded all the local enabled cgroups subsystems.

2018-06-13 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67343/
---

(Updated June 13, 2018, 10:24 p.m.)


Review request for mesos and Gilbert Song.


Bugs: MESOS-7691
https://issues.apache.org/jira/browse/MESOS-7691


Repository: mesos


Description (updated)
---

When `cgroups/all` is specified in the agent flag `--isolation`, we
will automatically load all the local enabled cgroups subsystems in
the cgroups isolator.


Diffs (updated)
-

  src/slave/containerizer/mesos/containerizer.cpp 
17a1a3762b2012ff875e4da9c9d4622514e48051 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
215e32461e851668247f9fae62aa656f5dd5e245 


Diff: https://reviews.apache.org/r/67343/diff/5/

Changes: https://reviews.apache.org/r/67343/diff/4-5/


Testing
---

sudo make check


Thanks,

Qian Zhang



Re: Review Request 67381: Added `cgroups/all` into CHANGELOG and upgrades.md.

2018-06-13 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67381/
---

(Updated June 13, 2018, 10:26 p.m.)


Review request for mesos and Gilbert Song.


Bugs: MESOS-7691
https://issues.apache.org/jira/browse/MESOS-7691


Repository: mesos


Description
---

Added `cgroups/all` into CHANGELOG and upgrades.md.


Diffs (updated)
-

  CHANGELOG 0c45af66cbe1c6feede328143d30dad4eaf1a4b3 
  docs/upgrades.md 18632edd20fcf943c6e7147aca3fec5b5521f14f 


Diff: https://reviews.apache.org/r/67381/diff/3/

Changes: https://reviews.apache.org/r/67381/diff/2-3/


Testing
---

Not a code change.


Thanks,

Qian Zhang



Review Request 67574: Made `PerfEventSubsystemProcess` can be created without `--perf_events`.

2018-06-13 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67574/
---

Review request for mesos and Gilbert Song.


Bugs: MESOS-7691
https://issues.apache.org/jira/browse/MESOS-7691


Repository: mesos


Description
---

If the agent flag `--perf_events` is not specified, the `perf_event`
subsystem (i.e., `PerfEventSubsystemProcess`) can still be created, but
it will not do sampling at all. The reason that we want to do this is,
in some cases, even it is not required to sample any events, we still
want each container to have its own `perf_event` cgroup instead under
the root cgroup.


Diffs
-

  src/slave/containerizer/mesos/isolators/cgroups/subsystems/perf_event.cpp 
06eca0c008ca7ddb45e4d10e63fdc2c601de430b 


Diff: https://reviews.apache.org/r/67574/diff/1/


Testing
---


Thanks,

Qian Zhang



Re: Review Request 67381: Added `cgroups/all` into CHANGELOG and upgrades.md.

2018-06-13 Thread Qian Zhang


> On June 7, 2018, 7:50 a.m., Gilbert Song wrote:
> > docs/upgrades.md
> > Lines 451 (patched)
> > <https://reviews.apache.org/r/67381/diff/2/?file=2034251#file2034251line451>
> >
> > s/causes/allows/g?
> > 
> > Could you also emphasize that the default behavior does not change?

Did you mean the default behavior of the agent flag `--isolaton` does not 
change if the option `cgroups/all` is not specified?


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67381/#review204439
---


On June 1, 2018, 11:28 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67381/
> ---
> 
> (Updated June 1, 2018, 11:28 a.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-7691
> https://issues.apache.org/jira/browse/MESOS-7691
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added `cgroups/all` into CHANGELOG and upgrades.md.
> 
> 
> Diffs
> -
> 
>   CHANGELOG bdcf8e33b95f4bea04b64417aa73df44dd456afe 
>   docs/upgrades.md 18632edd20fcf943c6e7147aca3fec5b5521f14f 
> 
> 
> Diff: https://reviews.apache.org/r/67381/diff/2/
> 
> 
> Testing
> ---
> 
> Not a code change.
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>



Review Request 67565: Added a test `ROOT_CGROUPS_CommandTaskSpecificCgroupsMount`.

2018-06-12 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67565/
---

Review request for mesos, Gilbert Song and Jason Lai.


Bugs: MESOS-8327
https://issues.apache.org/jira/browse/MESOS-8327


Repository: mesos


Description
---

Added a test `ROOT_CGROUPS_CommandTaskSpecificCgroupsMount`.


Diffs
-

  src/tests/containerizer/cgroups_isolator_tests.cpp 
231e9588c0d831c05a1d84f35f0f68105900789c 


Diff: https://reviews.apache.org/r/67565/diff/1/


Testing
---

sudo make check


Thanks,

Qian Zhang



Review Request 67564: Added a test `ROOT_CGROUPS_NestedContainerSpecificCgroupsMount`.

2018-06-12 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67564/
---

Review request for mesos, Gilbert Song and Jason Lai.


Bugs: MESOS-8327
https://issues.apache.org/jira/browse/MESOS-8327


Repository: mesos


Description
---

Added a test `ROOT_CGROUPS_NestedContainerSpecificCgroupsMount`.


Diffs
-

  src/tests/containerizer/cgroups_isolator_tests.cpp 
231e9588c0d831c05a1d84f35f0f68105900789c 


Diff: https://reviews.apache.org/r/67564/diff/1/


Testing
---

sudo make check


Thanks,

Qian Zhang



  1   2   3   4   5   6   7   8   9   10   >