Re: Review Request 69721: Broke up `SSLTest.ProtocolMismatch` into smaller tests.

2019-01-15 Thread Till Toenshoff via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69721/#review212036 --- Ship it! Ship It! - Till Toenshoff On Jan. 14, 2019, 7:54

Re: Review Request 69720: Made `SSLTest` an unparameterized test suite.

2019-01-15 Thread Till Toenshoff via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69720/#review212037 --- Ship it! Ship It! - Till Toenshoff On Jan. 14, 2019, 7:54

Re: Review Request 69694: Tester.

2019-01-09 Thread Till Toenshoff via Review Board
--- Dont review - just a test! Thanks, Till Toenshoff

Re: Review Request 69694: Tester.

2019-01-09 Thread Till Toenshoff via Review Board
: mesos Description --- Tester. Diffs (updated) - configure.ac 6778f119570def1838e26cddf7b0192bfe6e37d4 Diff: https://reviews.apache.org/r/69694/diff/3/ Changes: https://reviews.apache.org/r/69694/diff/2-3/ Testing --- Dont review - just a test! Thanks, Till Toenshoff

Re: Review Request 69694: Tester.

2019-01-09 Thread Till Toenshoff via Review Board
! Thanks, Till Toenshoff

Re: Review Request 69701: Improved debuggability of `verify-reviews.py`.

2019-01-09 Thread Till Toenshoff via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69701/#review211778 --- Ship it! Ship It! - Till Toenshoff On Jan. 9, 2019, 3:46

Re: Review Request 69698: Added try/except for `shell()` calls in `verify-reviews.py`.

2019-01-09 Thread Till Toenshoff via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69698/#review211777 --- Ship it! Ship It! - Till Toenshoff On Jan. 9, 2019, 9:35

Re: Review Request 69697: Reverted cleanup step of `verify-reviews.py`.

2019-01-09 Thread Till Toenshoff via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69697/#review211776 --- Ship it! Ship It! - Till Toenshoff On Jan. 9, 2019, 9:30

Review Request 69694: Tester.

2019-01-08 Thread Till Toenshoff via Review Board
- just a test! Diffs - configure.ac 6778f119570def1838e26cddf7b0192bfe6e37d4 Diff: https://reviews.apache.org/r/69694/diff/1/ Testing --- Dont review - just a test! Thanks, Till Toenshoff

Re: Review Request 69608: Fixed a typo in module manager log message.

2018-12-21 Thread Till Toenshoff via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69608/#review211497 --- Ship it! Ship It! - Till Toenshoff On Dec. 21, 2018, 2:03

Re: Review Request 69591: Fixed allocator benchmark names to ensure proper filtering.

2018-12-19 Thread Till Toenshoff via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69591/#review211437 --- Ship it! Ship It! - Till Toenshoff On Dec. 19, 2018, 6:11

Re: Review Request 69590: Moves CNI root directory to a persistent location.

2018-12-18 Thread Till Toenshoff via Review Board
s seems to be the most relevant part of this test - checking with and without this flag enabled. Maybe we should add a comment here? src/tests/containerizer/cni_isolator_tests.cpp Lines 2569 (patched) <https://reviews.apache.org/r/69590/#comment296500> Either remove these two pleas

Re: Review Request 69559: Simplified verify-reviews.py to be more similar to the Python 2 script.

2018-12-18 Thread Till Toenshoff via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69559/#review211397 --- Ship it! Ship It! - Till Toenshoff On Dec. 17, 2018, 3:55

Re: Review Request 69559: Simplified verify-reviews.py to be more similar to the Python 2 script.

2018-12-17 Thread Till Toenshoff via Review Board
> On Dec. 17, 2018, 12:52 p.m., Till Toenshoff wrote: > > support/verify-reviews.py > > Lines 277 (patched) > > <https://reviews.apache.org/r/69559/diff/3/?file=2114076#file2114076line296> > > > > Python's way of `contains` for

Re: Review Request 69559: Simplified verify-reviews.py to be more similar to the Python 2 script.

2018-12-17 Thread Till Toenshoff via Review Board
omment296362> Does this mean that if a RR changed in the chain that was not the last one, that we wont run validate the chain? Can you please explain the consequences in the comment? - Till Toenshoff On Dec. 13, 2

Re: Review Request 69412: Fixed thread safety issue in jwt signature validation.

2018-11-30 Thread Till Toenshoff via Review Board
/tests/jwt_tests.cpp Lines 464 (patched) <https://reviews.apache.org/r/69412/#comment295729> s/Thread/thread/ - Till Toenshoff On Nov. 20, 2018, 2:51 p.m., Alexander Rojas wrote: > > --- > This is an automatically generated e-

Review Request 69444: Allowed for unbundled leveldb in CMake builds.

2018-11-25 Thread Till Toenshoff via Review Board
-DCMAKE_EXPORT_COMPILE_COMMANDS=1 -G Ninja && ninja tests -j12 ``` Thanks, Till Toenshoff

Re: Review Request 69442: Updated 'REPOSITORY_URL' in 'support/reviewboardrc' to use gitbox.

2018-11-24 Thread Till Toenshoff via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69442/#review210843 --- Ship it! Ship It! - Till Toenshoff On Nov. 24, 2018, 1:13

Re: Review Request 69441: Fixed sandbox creation chmod error handling in the agent.

2018-11-24 Thread Till Toenshoff via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69441/#review210842 --- Ship it! Ship It! - Till Toenshoff On Nov. 24, 2018, 5:22

Re: Review Request 67136: Added a function to get rlimits.

2018-11-23 Thread Till Toenshoff via Review Board
> On Nov. 24, 2018, 1:17 a.m., Till Toenshoff wrote: > > Thanks for adding this Benjamin - also thanks James for reviewing! Just realized that we should consider moving this into stout, no? - Till --- This is an automatically

Re: Review Request 67136: Added a function to get rlimits.

2018-11-23 Thread Till Toenshoff via Review Board
blank OR add more blsnks to the rest to make the entire picture a bit more consistent. Adjusting while committing - leaving this open for your entertainment. - Till Toenshoff On May 18, 2018, 12:36 p.m., Benjamin B

Review Request 69439: Added guards around convertStringToInt to prevent warning.

2018-11-23 Thread Till Toenshoff via Review Board
. Thanks, Till Toenshoff

Re: Review Request 69438: Skipped an rlimit test if the environment is incompatible.

2018-11-23 Thread Till Toenshoff via Review Board
/posix_rlimits_isolator_tests.cpp Lines 138-142 (patched) <https://reviews.apache.org/r/69438/#comment295595> Thanks, that will help others to understand the failure before going through debug-hell :) - Till Toenshoff On Nov. 23, 2018, 11 p.m., Benjamin Bannier

Re: Review Request 69311: Enabled parallel test runner to cmake build.

2018-11-20 Thread Till Toenshoff via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69311/#review210707 --- Ship it! Ship It! - Till Toenshoff On Nov. 14, 2018, 1:11

Re: Review Request 69312: Enabled parallel test runner to cmake build.

2018-11-20 Thread Till Toenshoff via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69312/#review210706 --- Ship it! Ship It! - Till Toenshoff On Nov. 11, 2018, 12:01

Re: Review Request 69313: Enabled parallel test runner to cmake build.

2018-11-20 Thread Till Toenshoff via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69313/#review210705 --- Ship it! - Till Toenshoff On Nov. 11, 2018, 12:01 a.m

Review Request 69405: Refactored createAuthorizationCallbacks into common/authorization.

2018-11-19 Thread Till Toenshoff via Review Board
2b351ca70d8e80008e49722aa7d46918b5ecd9b0 src/tests/logging_tests.cpp 30bcdc7f4aa9d6a39c5ef6e825357815bf4f9f19 Diff: https://reviews.apache.org/r/69405/diff/1/ Testing --- `make check` and internal CI Thanks, Till Toenshoff

Re: Review Request 69384: Introduced common/authorization and refactored collectAuthorizations.

2018-11-19 Thread Till Toenshoff via Review Board
ac6bf379c5906cf9612284911c121c9457f648a0 Diff: https://reviews.apache.org/r/69384/diff/2/ Changes: https://reviews.apache.org/r/69384/diff/1-2/ Testing --- make check and private ci Thanks, Till Toenshoff

Re: Review Request 69368: Added test reproducing crash on authorization failure.

2018-11-19 Thread Till Toenshoff via Review Board
) <https://reviews.apache.org/r/69368/#comment295376> Lacks period. - Till Toenshoff On Nov. 18, 2018, 10:48 p.m., Till Toenshoff wrote: > > --- > This is an automatically generated e-mail. To reply,

Review Request 69386: Added test for ACCESS_MESOS_LOG authorization.

2018-11-18 Thread Till Toenshoff via Review Board
: mesos Description --- Added test for ACCESS_MESOS_LOG authorization. Diffs - src/tests/authorization_tests.cpp ac52181aa29bb5a5e4197cd90f32330aeb59385f Diff: https://reviews.apache.org/r/69386/diff/1/ Testing --- `make check` and internal CI Thanks, Till Toenshoff

Review Request 69385: Refactored createSubject and authorizeLogAccess to common/authorization.

2018-11-18 Thread Till Toenshoff via Review Board
/slave/slave.cpp 74f6fb9036a9ac4f587f53ec2df04eeb4c167bfb Diff: https://reviews.apache.org/r/69385/diff/1/ Testing --- `make check` and internal CI validation Thanks, Till Toenshoff

Review Request 69384: Introduced common/authorization and refactored collectAuthorizations.

2018-11-18 Thread Till Toenshoff via Review Board
/ Testing --- make check and private ci Thanks, Till Toenshoff

Re: Review Request 69368: Added test reproducing crash on authorization failure.

2018-11-18 Thread Till Toenshoff via Review Board
--- `make check` before applying the fix for MESOS-9317 and after doing so. Thanks, Till Toenshoff

Re: Review Request 69369: Added collectAuthorizations helper to master.hpp.

2018-11-18 Thread Till Toenshoff via Review Board
--- `make check` and internal CI validation. Thanks, Till Toenshoff

Re: Review Request 69369: Added collectAuthorizations helper to master.hpp.

2018-11-17 Thread Till Toenshoff via Review Board
Diff: https://reviews.apache.org/r/69369/diff/2/ Changes: https://reviews.apache.org/r/69369/diff/1-2/ Testing --- `make check` and internal CI validation. Thanks, Till Toenshoff

Re: Review Request 69368: Added test reproducing crash on authorization failure.

2018-11-17 Thread Till Toenshoff via Review Board
/ Testing --- `make check` before applying the fix for MESOS-9317 and after doing so. Thanks, Till Toenshoff

Review Request 69369: Added collectAuthorizations helper to master.hpp.

2018-11-15 Thread Till Toenshoff via Review Board
222ec754e216da195250d1895a728294a076ee5d src/tests/master_tests.cpp ac6bf379c5906cf9612284911c121c9457f648a0 Diff: https://reviews.apache.org/r/69369/diff/1/ Testing --- `make check` and internal CI validation. Thanks, Till Toenshoff

Review Request 69368: Added test reproducing crash on authorization failure.

2018-11-15 Thread Till Toenshoff via Review Board
failed. Diffs - src/tests/master_tests.cpp ac6bf379c5906cf9612284911c121c9457f648a0 Diff: https://reviews.apache.org/r/69368/diff/1/ Testing --- `make check` before applying the fix for MESOS-9317 and after doing so. Thanks, Till Toenshoff

Re: Review Request 69324: Removed some unnecessary intermediate build variables.

2018-11-13 Thread Till Toenshoff via Review Board
.org/r/69324/ > --- > > (Updated Nov. 13, 2018, 5:30 a.m.) > > > Review request for mesos, Benjamin Bannier and Till Toenshoff. > > > Repository: mesos > > > Description > --- > > Removed some unnecessary intermediate build variables. > > > Diffs >

Re: Review Request 69323: Removed separate automake variables for header sources.

2018-11-13 Thread Till Toenshoff via Review Board
mistakes less likely, great improvement. - Till Toenshoff On Nov. 13, 2018, 5:01 a.m., James Peach wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 69224: Fixed a test flake in `HealthCheckTest.HealthyTaskNonShell`.

2018-11-01 Thread Till Toenshoff via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69224/#review210255 --- Ship it! Ship It! - Till Toenshoff On Nov. 1, 2018, 3:15

Re: Review Request 69140: Allowed for unbundled libarchive on cmake builds.

2018-10-30 Thread Till Toenshoff via Review Board
he.org/r/69140/#review209976 --- On Oct. 30, 2018, 8:20 p.m., Till Toenshoff wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Re: Review Request 69140: Allowed for unbundled libarchive on cmake builds.

2018-10-30 Thread Till Toenshoff via Review Board
one then as well... NOTED - Till --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69140/#review209976 --- On Oct. 30, 2018, 8:20 p.m., Till

Re: Review Request 69140: Allowed for unbundled libarchive on cmake builds.

2018-10-30 Thread Till Toenshoff via Review Board
=ON cmake .. -DUNBUNDLED_LIBARCHIVE=OFF cmake .. -DUNBUNDLED_LIBARCHIVE=ON -DLIBARCHIVE_ROOT_DIR=/usr/local/opt/libarchive cmake .. Thanks, Till Toenshoff

Review Request 69216: Added small style fix-ups for libevent unbundling on CMake builds.

2018-10-30 Thread Till Toenshoff via Review Board
/diff/1/ Testing --- ``` cmake .. -DUNBUNDLED_LIBEVENT=ON -DUNBUNDLED_LIBARCHIVE=ON -DENABLE_SSL=ON -DENABLE_LIBEVENT=ON -G Ninja ``` Thanks, Till Toenshoff

Re: Review Request 68812: Added example framework for inverse-offers.

2018-10-26 Thread Till Toenshoff via Review Board
a2c0dd12e34ae739be85885fd815514f7d3d59a5 src/examples/inverse_offer_framework.cpp PRE-CREATION Diff: https://reviews.apache.org/r/68812/diff/3/ Changes: https://reviews.apache.org/r/68812/diff/2-3/ Testing --- make check Thanks, Till Toenshoff

Re: Review Request 68812: Added example framework for inverse-offers.

2018-10-26 Thread Till Toenshoff via Review Board
/examples/CMakeLists.txt a2c0dd12e34ae739be85885fd815514f7d3d59a5 src/examples/inverse_offer_framework.cpp PRE-CREATION Diff: https://reviews.apache.org/r/68812/diff/2/ Changes: https://reviews.apache.org/r/68812/diff/1-2/ Testing --- make check Thanks, Till Toenshoff

Re: Review Request 69160: Included corresponding header file first.

2018-10-26 Thread Till Toenshoff via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69160/#review210096 --- Ship it! Ship It! - Till Toenshoff On Oct. 25, 2018, 10:54

Re: Review Request 69146: Made fetcher tests more robust by using the test sandbox.

2018-10-24 Thread Till Toenshoff via Review Board
> On Oct. 24, 2018, 11:31 p.m., Till Toenshoff wrote: > > src/tests/fetcher_tests.cpp > > Lines 105-106 (patched) > > <https://reviews.apache.org/r/69146/diff/2/?file=2102314#file2102314line105> > > > > While this solution appears to be the most

Re: Review Request 69146: Made fetcher tests more robust by using the test sandbox.

2018-10-24 Thread Till Toenshoff via Review Board
> On Oct. 24, 2018, 11:31 p.m., Till Toenshoff wrote: > > src/tests/fetcher_tests.cpp > > Lines 105-106 (patched) > > <https://reviews.apache.org/r/69146/diff/2/?file=2102314#file2102314line105> > > > > While this solution appears to be the most

Re: Review Request 69146: Made fetcher tests more robust by using the test sandbox.

2018-10-24 Thread Till Toenshoff via Review Board
ts job. ``` path::join(os::getcwd(), "fetcher"); path::join(os::getcwd(), "frameworks"); ``` would be consistent. Alternatively, we could at least do away with one `CHECK_NOTNONE` and pull it in front of these two uses of `sandbox`. - Till Toenshoff On Oct.

Re: Review Request 69140: Allowed for unbundled libarchive on cmake builds.

2018-10-24 Thread Till Toenshoff via Review Board
tps://reviews.apache.org/r/69140/#comment294607> Created https://issues.apache.org/jira/browse/MESOS-9351 for tracking this effort. Will tackle that soonish... - Till Toenshoff On Oct. 24, 2018, 12:25 p.m., Till Toenshoff

Re: Review Request 69140: Allowed for unbundled libarchive on cmake builds.

2018-10-24 Thread Till Toenshoff via Review Board
) <https://reviews.apache.org/r/69140/#comment294604> Am a bit unsure about this specific change and would appreciate a windows-feedback :) - Till Toenshoff On Oct. 24, 2018, 12:25 p.m., Till Toenshoff

Review Request 69140: Allowed for unbundled libarchive on cmake builds.

2018-10-24 Thread Till Toenshoff via Review Board
5d2be0adc55ac5302c2e0e62131feb65657466be Diff: https://reviews.apache.org/r/69140/diff/1/ Testing --- cmake .. -DUNBUNDLED_LIBARCHIVE=ON cmake .. -DUNBUNDLED_LIBARCHIVE=OFF cmake .. -DUNBUNDLED_LIBARCHIVE=ON -DLIBARCHIVE_ROOT_DIR=/usr/local/opt/libarchive cmake .. Thanks, Till Toenshoff

Re: Review Request 69075: Updated docker image fetcher to enforce HTTP 1.1.

2018-10-22 Thread Till Toenshoff via Review Board
://reviews.apache.org/r/69075/diff/4/ Changes: https://reviews.apache.org/r/69075/diff/3-4/ Testing --- `make check` `sudo ./bin/mesos-tests.sh --gtest_filter="ImageAlpine/ProvisionerDockerTest.ROOT_INTERNET_CURL_SimpleCommand/2"` on a system with curl 7.59.0 installed. Tha

Re: Review Request 69075: Updated docker image fetcher to enforce HTTP 1.x.

2018-10-22 Thread Till Toenshoff via Review Board
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69075/#review209868 --- On Oct. 22, 2018, 11:22 a.m., Till Toenshoff wrote: > > -

Re: Review Request 69075: Updated docker image fetcher to enforce HTTP 1.x.

2018-10-22 Thread Till Toenshoff via Review Board
/ Changes: https://reviews.apache.org/r/69075/diff/2-3/ Testing --- `make check` `sudo ./bin/mesos-tests.sh --gtest_filter="ImageAlpine/ProvisionerDockerTest.ROOT_INTERNET_CURL_SimpleCommand/2"` on a system with curl 7.59.0 installed. Thanks, Till Toenshoff

Re: Review Request 69075: Updated docker image fetcher to enforce HTTP1.0.

2018-10-18 Thread Till Toenshoff via Review Board
tps://reviews.apache.org/r/69075/#comment294339> As discussed with James, HTTP 1.0 may be introducing new imcompatibilities with certain proxy setups. We should instead use --http1.1 when available, fallback to --http1.0 if not. - Till Toenshoff On Oct. 18, 2018, 11:41 p.m., Till Toe

Re: Review Request 69075: Updated docker image fetcher to enforce HTTP1.0.

2018-10-18 Thread Till Toenshoff via Review Board
/ Testing (updated) --- `make check` `sudo ./bin/mesos-tests.sh --gtest_filter="ImageAlpine/ProvisionerDockerTest.ROOT_INTERNET_CURL_SimpleCommand/2"` on a system with curl 7.59.0 installed. Thanks, Till Toenshoff

Re: Review Request 69075: Updated docker image fetcher to enforce HTTP1.1.

2018-10-18 Thread Till Toenshoff via Review Board
- needs CENTOS 7 fixup - DO NOT COMMIT `make check` `sudo ./bin/mesos-tests.sh --gtest_filter="ImageAlpine/ProvisionerDockerTest.ROOT_INTERNET_CURL_SimpleCommand/2"` on a system with curl 7.59.0 installed. Thanks, Till Toenshoff

Review Request 69075: Updated docker image fetcher to enforce HTTP1.1.

2018-10-18 Thread Till Toenshoff via Review Board
lpine/ProvisionerDockerTest.ROOT_INTERNET_CURL_SimpleCommand/2"` on a system with curl 7.59.0 installed. Thanks, Till Toenshoff

Re: Review Request 68992: Added 'received' timestamp into `process::Request`.

2018-10-16 Thread Till Toenshoff via Review Board
/http.hpp Lines 568-569 (patched) <https://reviews.apache.org/r/68992/#comment294129> As discussed out of band, let's come up with a proper story here in a JIRA first and then get back to it. - Till Toenshoff On Oct. 11, 2018, 2:16 p.m., Alexander Rukletsov

Re: Review Request 68993: Introduced `logResponse` for http handlers.

2018-10-16 Thread Till Toenshoff via Review Board
t; --- > > (Updated Oct. 11, 2018, 2:16 p.m.) > > > Review request for mesos, Benjamin Hindman, Benno Evers, Benjamin Mahler, > Gastón Kleiman, and Till Toenshoff. > > > Repository: mesos > > > Desc

Re: Review Request 68993: Introduced `logResponse` for http handlers.

2018-10-16 Thread Till Toenshoff via Review Board
353-354 (patched) <https://reviews.apache.org/r/68993/#comment294139> Thanks for the TODO. - Till Toenshoff On Oct. 11, 2018, 2:16 p.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 68994: Logged request processing time for some endpoints.

2018-10-16 Thread Till Toenshoff via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68994/#review209611 --- Ship it! Ship It! - Till Toenshoff On Oct. 11, 2018, 2:16

Re: Review Request 68994: Logged request processing time for some endpoints.

2018-10-16 Thread Till Toenshoff via Review Board
On Oct. 11, 2018, 2:16 p.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68994/ > --- > > (Updated Oct. 11, 2018, 2:16 p.m.) > > > Review reque

Re: Review Request 68970: Fixed JSON object type error when using `support/apply-reviews.py`.

2018-10-10 Thread Till Toenshoff via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68970/#review209406 --- Ship it! Ship It! - Till Toenshoff On Oct. 10, 2018, 5:21

Re: Review Request 68951: Updated verify-reviews.py to use current interpreter in subprocesses.

2018-10-08 Thread Till Toenshoff via Review Board
) <https://reviews.apache.org/r/68951/#comment293632> IIUC, then `sys.executable` may be `None`. Shall we guard against that? - Till Toenshoff On Oct. 8, 2018, 6:06 p.m., Armand Grillet wrote: > > --- > This is an automatica

Re: Review Request 68939: Updated cpplint.py to be less verbose when there is no linting issue.

2018-10-05 Thread Till Toenshoff via Review Board
for the user. However, I also guess on the other hand that "Checking..." stuff is useful if the linting introduces a considerable delay - which in my experience actually can happen in cases where changes happened on our monster "master.cpp". Thanks again! - Till Toenshoff O

Re: Review Request 68937: Removed output in mesos-style.py when linting goes well.

2018-10-05 Thread Till Toenshoff via Review Board
> On Oct. 5, 2018, 2:24 p.m., Till Toenshoff wrote: > > Thanks a bunch Armand. Can we please have the same for "apple-reviews.py"? Jeez - sorry for this confusion - here some more orderly feedback: Before applying your patch: ``` Checking 1 C++ file Done processing 3rdparty

Re: Review Request 68937: Removed output in mesos-style.py when linting goes well.

2018-10-05 Thread Till Toenshoff via Review Board
for "apple-reviews.py"? - Till Toenshoff On Oct. 5, 2018, 10:28 a.m., Armand Grillet wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revi

Re: Review Request 68937: Removed output in mesos-style.py when linting goes well.

2018-10-05 Thread Till Toenshoff via Review Board
> On Oct. 5, 2018, 2:17 p.m., Till Toenshoff wrote: > > support/mesos-style.py > > Line 229 (original) > > <https://reviews.apache.org/r/68937/diff/1/?file=2094915#file2094915line230> > > > > Why is this not needed anymore? Ah, now understood -- so

Re: Review Request 68937: Removed output in mesos-style.py when linting goes well.

2018-10-05 Thread Till Toenshoff via Review Board
tps://reviews.apache.org/r/68937/#comment293559> Why is this not needed anymore? - Till Toenshoff On Oct. 5, 2018, 10:28 a.m., Armand Grillet wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 68936: Fixed libevent dependency.

2018-10-05 Thread Till Toenshoff via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68936/#review209254 --- Ship it! Ship It! - Till Toenshoff On Oct. 5, 2018, 9:10

Re: Review Request 68906: Fixed ssl build specific incompatiblity with libevent later than 2.1.5.

2018-10-03 Thread Till Toenshoff via Review Board
with and without bundled libevent. Tested combinations were: macOS 10.14.1 - libevent 2.2 macOS 10.14.1 - libevent 2.1.8 macOS 10.14.1 - libevent 2.0.22 Ubuntu 16.04 - libevent 2.1.8 Thanks, Till Toenshoff

Review Request 68919: Removed unbundling by default for libevent on macOS when using CMake.

2018-10-03 Thread Till Toenshoff via Review Board
ninja check -j12 Thanks, Till Toenshoff

Re: Review Request 68916: Moved libevent_openssl validation into libevent.m4.

2018-10-03 Thread Till Toenshoff via Review Board
3a7fcad7d0c2d967fb308714c4b1f631c988001b Diff: https://reviews.apache.org/r/68916/diff/1/ Testing --- make check Thanks, Till Toenshoff

Re: Review Request 68915: Moved libevent_openssl validation into libevent.m4.

2018-10-03 Thread Till Toenshoff via Review Board
://reviews.apache.org/r/68915/diff/1/ Testing --- make check Thanks, Till Toenshoff

Review Request 68915: Moved libevent_openssl validation into libevent.m4.

2018-10-03 Thread Till Toenshoff via Review Board
check Thanks, Till Toenshoff

Review Request 68916: Moved libevent_openssl validation into libevent.m4.

2018-10-03 Thread Till Toenshoff via Review Board
/r/68916/diff/1/ Testing --- make check Thanks, Till Toenshoff

Review Request 68914: Updated libevent linkage to adhere to best practices.

2018-10-03 Thread Till Toenshoff via Review Board
://reviews.apache.org/r/68914/diff/1/ Testing --- make check Thanks, Till Toenshoff

Review Request 68913: Updated libevent linkage to adhere to best practices.

2018-10-03 Thread Till Toenshoff via Review Board
://reviews.apache.org/r/68913/diff/1/ Testing --- make check Thanks, Till Toenshoff

Re: Review Request 67748: Added monitoring paragraph to high-availability.md.

2018-10-03 Thread Till Toenshoff via Review Board
rated e-mail. To reply, visit: https://reviews.apache.org/r/67748/#review205395 --- On June 26, 2018, 7:12 p.m., Till Toenshoff wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r

Review Request 68906: Fixed ssl build specific incompatiblity with libevent later than 2.1.5.

2018-10-02 Thread Till Toenshoff via Review Board
16.04 - libevent 2.1.8 Thanks, Till Toenshoff

Review Request 68905: Removed version check from libevent dependency tracking from libprocess.

2018-10-02 Thread Till Toenshoff via Review Board
3a7fcad7d0c2d967fb308714c4b1f631c988001b Diff: https://reviews.apache.org/r/68905/diff/1/ Testing --- make check on macOS 10.14.1 with and without bundled libevent. Thanks, Till Toenshoff

Review Request 68904: Removed version check from libevent dependency tracking.

2018-10-02 Thread Till Toenshoff via Review Board
://reviews.apache.org/r/68904/diff/1/ Testing --- make check on macOS 10.14.1 with and without bundled libevent. Thanks, Till Toenshoff

Review Request 68857: Fixed libevent M4 macro to be fully compatible with older autoconf.

2018-09-26 Thread Till Toenshoff via Review Board
. Repository: mesos Description --- Fixed libevent M4 macro to be fully compatible with older autoconf. Diffs - 3rdparty/libprocess/m4/libevent.m4 b8462f810a87b0144d479c37927fcb1a5f3475e8 Diff: https://reviews.apache.org/r/68857/diff/1/ Testing --- Thanks, Till Toenshoff

Review Request 68858: Fixed libevent M4 macro to be fully compatible with older autoconf.

2018-09-26 Thread Till Toenshoff via Review Board
. Repository: mesos Description --- Fixed libevent M4 macro to be fully compatible with older autoconf. Diffs - m4/libevent.m4 b8462f810a87b0144d479c37927fcb1a5f3475e8 Diff: https://reviews.apache.org/r/68858/diff/1/ Testing --- Thanks, Till Toenshoff

Re: Review Request 68856: Added missing python egg build extensions for libevent.

2018-09-26 Thread Till Toenshoff via Review Board
/ Changes: https://reviews.apache.org/r/68856/diff/1-2/ Testing --- CI and make check Thanks, Till Toenshoff

Re: Review Request 68856: Added missing python egg build extensions for libevent.

2018-09-26 Thread Till Toenshoff via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68856/#review209052 ------- On Sept. 26, 2018, 9:32 p.m., Till Toenshoff wrote: > > --

Re: Review Request 68856: Added missing python egg build extensions for libevent.

2018-09-26 Thread Till Toenshoff via Review Board
e-mail. To reply, visit: https://reviews.apache.org/r/68856/#review209048 --- On Sept. 26, 2018, 9:32 p.m., Till Toenshoff wrote: > > --- > This is an automatically generated e

Review Request 68856: Added missing python egg build extensions for libevent.

2018-09-26 Thread Till Toenshoff via Review Board
. Repository: mesos Description --- Added missing python egg build extensions for libevent. Diffs - src/python/native_common/ext_modules.py.in 7efbb8ec91b74c32ac629f1f2e7de82986d518db Diff: https://reviews.apache.org/r/68856/diff/1/ Testing --- CI and make check Thanks, Till

Re: Review Request 68816: Prevented leaking files in some stout tests.

2018-09-26 Thread Till Toenshoff via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68816/#review209026 --- Ship it! Ship It! - Till Toenshoff On Sept. 23, 2018, 7:32

Re: Review Request 68816: Prevented leaking files in some stout tests.

2018-09-26 Thread Till Toenshoff via Review Board
> On Sept. 26, 2018, 2:42 p.m., Till Toenshoff wrote: > > Ship It! Modulo CI issues. - Till --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68816/#rev

Re: Review Request 68817: Prevented leaking files in some libprocess tests.

2018-09-26 Thread Till Toenshoff via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68817/#review209025 --- Ship it! Ship It! - Till Toenshoff On Sept. 23, 2018, 7:32

Re: Review Request 68819: Asserted element exists before accessing it.

2018-09-26 Thread Till Toenshoff via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68819/#review209024 --- Ship it! Ship It! - Till Toenshoff On Sept. 23, 2018, 7:32

Re: Review Request 68641: Added version check and bundling of libevent within libprocess.

2018-09-23 Thread Till Toenshoff via Review Board
/ Testing --- Manual testing on macOS 10.14 as well as Ubuntu 18.04LTS. Additional testing is ongoing. CMake updates will follow. Thanks, Till Toenshoff

Review Request 68812: Added example framework for inverse-offers.

2018-09-22 Thread Till Toenshoff via Review Board
/ Testing --- make check Thanks, Till Toenshoff

Re: Review Request 68640: Added version check and bundling of libevent to autotools.

2018-09-22 Thread Till Toenshoff via Review Board
2089808#file2089808line94> > > > > Use `AS_IF` consistently here? Thanks! - Till ------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68640/#review208863 --

Re: Review Request 68640: Added version check and bundling of libevent to autotools.

2018-09-22 Thread Till Toenshoff via Review Board
ION Diff: https://reviews.apache.org/r/68640/diff/4/ Changes: https://reviews.apache.org/r/68640/diff/3-4/ Testing --- Manual testing on macOS 10.14 as well as Ubuntu 18.04LTS. CMake updates will follow soon. Thanks, Till Toenshoff

  1   2   3   4   5   6   7   8   9   10   >