Re: Review Request 67597: Fixed an issue where agent may fail to recover.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67597/ --- (Updated 六月 20, 2018, 8:17 p.m.) Review request for mesos and Gilbert Song. Bugs: MESOS-8871 https://issues.apache.org/jira/browse/MESOS-8871 Repository: mesos Description (updated) --- Fixed an issue where agent may fail to recover if the agent dies before image store cache to the checkpoint. when images file is empty, ignore it and continue. Diffs (updated) - src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp 98c8fc769f2525c66539f08e2aa82506912e8a59 src/tests/containerizer/provisioner_docker_tests.cpp 71247c308b205de3d20a41ceb06eed6aa70fb25d Diff: https://reviews.apache.org/r/67597/diff/3/ Changes: https://reviews.apache.org/r/67597/diff/2-3/ Testing --- Thanks, bin zheng
Re: Review Request 67597: Fixed an issue where agent may fail to recover.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67597/ --- (Updated 六月 15, 2018, 5:44 p.m.) Review request for mesos and Gilbert Song. Changes --- Ok, Updated according to new idea Bugs: MESOS-8871 https://issues.apache.org/jira/browse/MESOS-8871 Repository: mesos Description (updated) --- Fixed an issue where agent may fail to recover. Diffs (updated) - src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp 98c8fc769f2525c66539f08e2aa82506912e8a59 src/tests/containerizer/provisioner_docker_tests.cpp 71247c308b205de3d20a41ceb06eed6aa70fb25d Diff: https://reviews.apache.org/r/67597/diff/2/ Changes: https://reviews.apache.org/r/67597/diff/1-2/ Testing --- Thanks, bin zheng
Review Request 67597: Fixed an issue where agent may fail to recover.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67597/ --- Review request for mesos and Gilbert Song. Bugs: MESOS-8871 https://issues.apache.org/jira/browse/MESOS-8871 Repository: mesos Description --- Fixed an issue where agent may fail to recover if the agent dies before image store cache to the checkpoint. when images file is empty, remove it and continue. Diffs - src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp 98c8fc769f2525c66539f08e2aa82506912e8a59 src/tests/containerizer/provisioner_docker_tests.cpp 71247c308b205de3d20a41ceb06eed6aa70fb25d Diff: https://reviews.apache.org/r/67597/diff/1/ Testing --- Thanks, bin zheng
Re: Review Request 67567: Renamed variable names in slave.hpp to be more explicit.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67567/ --- (Updated 六月 13, 2018, 9:47 p.m.) Review request for mesos, Chun-Hung Hsiao and Gilbert Song. Changes --- Fixed code format error Summary (updated) - Renamed variable names in slave.hpp to be more explicit. Bugs: MESOS-8680 https://issues.apache.org/jira/browse/MESOS-8680 Repository: mesos Description (updated) --- Changed the variable name of the Class "Slave", "Executor" and "Framework" in Slave.hpp, eg: change "info" to "slaveInfo", "executorInfo" or "frameworkInfo". also change others in related files: http.cpp and slave.cpp. Diffs (updated) - src/slave/http.cpp a6739e12e55431a84844c747e584ef6420694076 src/slave/slave.hpp bf14d3569e677b2be6790ef774985df6937ebb29 src/slave/slave.cpp 8edd652f7f410dbadaf6c2ca3736349065e4340a Diff: https://reviews.apache.org/r/67567/diff/2/ Changes: https://reviews.apache.org/r/67567/diff/1-2/ Testing --- Thanks, bin zheng
Re: Review Request 67567: Rename variable names in slave.hpp to be more explicit.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67567/ --- (Updated 六月 13, 2018, 5:14 p.m.) Review request for mesos, Chun-Hung Hsiao and Gilbert Song. Bugs: MESOS-8680 https://issues.apache.org/jira/browse/MESOS-8680 Repository: mesos Description --- Changed the variable name of the Class "Slave", "Executor" and "Framework" in Slave.hpp, eg: change "info" to "slaveInfo", "executorInfo" or "frameworkInfo". also change others in related files: http.cpp and slave.cpp. Diffs - src/slave/http.cpp a6739e12e55431a84844c747e584ef6420694076 src/slave/slave.hpp bf14d3569e677b2be6790ef774985df6937ebb29 src/slave/slave.cpp 8edd652f7f410dbadaf6c2ca3736349065e4340a Diff: https://reviews.apache.org/r/67567/diff/1/ Testing --- Thanks, bin zheng
Review Request 67567: Rename variable names in slave.hpp to be more explicit.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67567/ --- Review request for mesos and Gilbert Song. Repository: mesos Description --- Changed the variable name of the Class "Slave", "Executor" and "Framework" in Slave.hpp, eg: change "info" to "slaveInfo", "executorInfo" or "frameworkInfo". also change others in related files: http.cpp and slave.cpp. Diffs - src/slave/http.cpp a6739e12e55431a84844c747e584ef6420694076 src/slave/slave.hpp bf14d3569e677b2be6790ef774985df6937ebb29 src/slave/slave.cpp 8edd652f7f410dbadaf6c2ca3736349065e4340a Diff: https://reviews.apache.org/r/67567/diff/1/ Testing --- Thanks, bin zheng
Re: Review Request 67538: Added Bin Zheng to the contributors list.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67538/ --- (Updated 六月 12, 2018, 6:36 a.m.) Review request for mesos and Gilbert Song. Summary (updated) - Added Bin Zheng to the contributors list. Repository: mesos Description (updated) --- Added Bin Zheng to the contributors list. Diffs (updated) - docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958 Diff: https://reviews.apache.org/r/67538/diff/2/ Changes: https://reviews.apache.org/r/67538/diff/1-2/ Testing --- Thanks, bin zheng
Re: Review Request 67538: Add zhengbin.
> On 六月 12, 2018, 5:49 a.m., Gilbert Song wrote: > > Could you re-phase the commit message as: > > `Added Bin Zheng to the contributors list.` Done,has been modified - bin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67538/#review204586 --- On 六月 12, 2018, 5:47 a.m., bin zheng wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67538/ > --- > > (Updated 六月 12, 2018, 5:47 a.m.) > > > Review request for mesos and Gilbert Song. > > > Repository: mesos > > > Description > --- > > Add zhengbin. > > > Diffs > - > > docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958 > > > Diff: https://reviews.apache.org/r/67538/diff/1/ > > > Testing > --- > > > Thanks, > > bin zheng > >
Re: Review Request 67538: Add zhengbin.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67538/ --- (Updated 六月 12, 2018, 5:47 a.m.) Review request for mesos and Gilbert Song. Repository: mesos Description --- Add zhengbin. Diffs - docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958 Diff: https://reviews.apache.org/r/67538/diff/1/ Testing --- Thanks, bin zheng
Review Request 67538: Add zhengbin.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67538/ --- Review request for mesos and Gilbert Song. Repository: mesos Description --- Add zhengbin. Diffs - docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958 Diff: https://reviews.apache.org/r/67538/diff/1/ Testing --- Thanks, bin zheng
