Re: Review Request 67601: Added field container_id in ResourceUsage to agent monitor endpoint.
> On 六月 21, 2018, 6:52 p.m., Gilbert Song wrote:
> > src/tests/slave_tests.cpp
> > Lines 2413 (patched)
> > <https://reviews.apache.org/r/67601/diff/2/?file=2041159#file2041159line2413>
> >
> > Instead of to string.find(), I would prefer:
> >
> > ```
> > ASSERT_TRUE(value->is());
> >
> > JSON::Object object = value->as();
> > EXPECT_SOME(object.find("container_id"));
> > ```
Got it!Let me fix.
- longfei
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67601/#review205196
---
On 六月 27, 2018, 3:03 a.m., longfei niu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67601/
> ---
>
> (Updated 六月 27, 2018, 3:03 a.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Bugs: MESOS-8816
> https://issues.apache.org/jira/browse/MESOS-8816
>
>
> Repository: mesos
>
>
> Description
> ---
>
> Added field container_id in ResourceUsage to agent monitor endpoint.
>
>
> Diffs
> -
>
> src/slave/http.cpp a6739e12e55431a84844c747e584ef6420694076
> src/tests/slave_tests.cpp 3d67511de5abd3466eeb5ad1daf318209bd69eed
>
>
> Diff: https://reviews.apache.org/r/67601/diff/3/
>
>
> Testing
> ---
>
> add unit test to src/tests/slave_tests.cpp line 2414 to test whether
> container_id field added sucessfully or not
>
>
> Thanks,
>
> longfei niu
>
>
Re: Review Request 67601: Added field container_id in ResourceUsage to agent monitor endpoint.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67601/ --- (Updated 六月 27, 2018, 3:03 a.m.) Review request for mesos and Gilbert Song. Bugs: MESOS-8816 https://issues.apache.org/jira/browse/MESOS-8816 Repository: mesos Description --- Added field container_id in ResourceUsage to agent monitor endpoint. Diffs (updated) - src/slave/http.cpp a6739e12e55431a84844c747e584ef6420694076 src/tests/slave_tests.cpp 3d67511de5abd3466eeb5ad1daf318209bd69eed Diff: https://reviews.apache.org/r/67601/diff/3/ Changes: https://reviews.apache.org/r/67601/diff/2-3/ Testing --- add unit test to src/tests/slave_tests.cpp line 2414 to test whether container_id field added sucessfully or not Thanks, longfei niu
Re: Review Request 67601: Added field container_id in ResourceUsage to agent monitor endpoint.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67601/ --- (Updated 六月 16, 2018, 1:20 a.m.) Review request for mesos and Gilbert Song. Changes --- Fixed questions Bugs: MESOS-8816 https://issues.apache.org/jira/browse/MESOS-8816 Repository: mesos Description (updated) --- Added field container_id in ResourceUsage to agent monitor endpoint. Diffs (updated) - src/slave/http.cpp a6739e12e55431a84844c747e584ef6420694076 src/tests/slave_tests.cpp 3d67511de5abd3466eeb5ad1daf318209bd69eed Diff: https://reviews.apache.org/r/67601/diff/2/ Changes: https://reviews.apache.org/r/67601/diff/1-2/ Testing --- add unit test to src/tests/slave_tests.cpp line 2414 to test whether container_id field added sucessfully or not Thanks, longfei niu
Review Request 67601: Added field container_id in ResourceUsage to agent monitor endpoint.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67601/ --- Review request for mesos and Gilbert Song. Summary (updated) - Added field container_id in ResourceUsage to agent monitor endpoint. Bugs: MESOS-8816 https://issues.apache.org/jira/browse/MESOS-8816 Repository: mesos Description --- Added field container_id in ResourceUsage to agent /monitor/statistics endpoint. Diffs (updated) - src/slave/http.cpp a6739e12e55431a84844c747e584ef6420694076 src/tests/slave_tests.cpp 3d67511de5abd3466eeb5ad1daf318209bd69eed Diff: https://reviews.apache.org/r/67601/diff/1/ Testing (updated) --- add unit test to src/tests/slave_tests.cpp line 2414 to test whether container_id field added sucessfully or not Thanks, longfei niu
Review Request 67552: Added LongFei Niu to contributors list.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67552/ --- Review request for mesos and Gilbert Song. Repository: mesos Description --- Added LongFei Niu to contributors list. Diffs - docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958 Diff: https://reviews.apache.org/r/67552/diff/1/ Testing --- Thanks, longfei niu
