Re: Review Request 32198: Added a not equal operator for json objects.

2015-05-07 Thread Alexander Rojas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32198/
---

(Updated May 7, 2015, 10:37 p.m.)


Review request for mesos, Benjamin Hindman, Bernd Mathiske, Joerg Schad, Marco 
Massenzio, Niklas Nielsen, and Till Toenshoff.


Changes
---

rebased


Bugs: MESOS-2510
https://issues.apache.org/jira/browse/MESOS-2510


Repository: mesos


Description
---

For consistency, adds a non equal operator to the json objects.

It also adds tests to the equality operators.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 
334c898906018be6e663f53815abbe047806b95c 
  3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 
f60d1bbe60f2e2b6460c06bba98e8b85ebb6a3f9 

Diff: https://reviews.apache.org/r/32198/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 32198: Added a not equal operator for json objects.

2015-05-07 Thread Joerg Schad 


> On May 7, 2015, 8:07 p.m., Joerg Schad wrote:
> > configure.ac, line 566
> > 
> >
> > How is this related to your change?

Looking at the review history could it be that this was added by mistake?


- Joerg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32198/#review82887
---


On May 7, 2015, 7:09 p.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32198/
> ---
> 
> (Updated May 7, 2015, 7:09 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, Joerg Schad, 
> Marco Massenzio, Niklas Nielsen, and Till Toenshoff.
> 
> 
> Bugs: MESOS-2510
> https://issues.apache.org/jira/browse/MESOS-2510
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> For consistency, adds a non equal operator to the json objects.
> 
> It also adds tests to the equality operators.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 
> 334c898906018be6e663f53815abbe047806b95c 
>   3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 
> f60d1bbe60f2e2b6460c06bba98e8b85ebb6a3f9 
>   configure.ac fa53bbd416dffc3987f8ec28bd9a8ce2b32d6831 
> 
> Diff: https://reviews.apache.org/r/32198/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 32198: Added a not equal operator for json objects.

2015-05-07 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32198/#review82887
---



configure.ac


How is this related to your change?


- Joerg Schad


On May 7, 2015, 7:09 p.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32198/
> ---
> 
> (Updated May 7, 2015, 7:09 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, Joerg Schad, 
> Marco Massenzio, Niklas Nielsen, and Till Toenshoff.
> 
> 
> Bugs: MESOS-2510
> https://issues.apache.org/jira/browse/MESOS-2510
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> For consistency, adds a non equal operator to the json objects.
> 
> It also adds tests to the equality operators.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 
> 334c898906018be6e663f53815abbe047806b95c 
>   3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 
> f60d1bbe60f2e2b6460c06bba98e8b85ebb6a3f9 
>   configure.ac fa53bbd416dffc3987f8ec28bd9a8ce2b32d6831 
> 
> Diff: https://reviews.apache.org/r/32198/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 32198: Added a not equal operator for json objects.

2015-05-07 Thread Alexander Rojas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32198/
---

(Updated May 7, 2015, 9:09 p.m.)


Review request for mesos, Benjamin Hindman, Bernd Mathiske, Joerg Schad, Marco 
Massenzio, Niklas Nielsen, and Till Toenshoff.


Changes
---

Added some const


Bugs: MESOS-2510
https://issues.apache.org/jira/browse/MESOS-2510


Repository: mesos


Description
---

For consistency, adds a non equal operator to the json objects.

It also adds tests to the equality operators.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 
334c898906018be6e663f53815abbe047806b95c 
  3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 
f60d1bbe60f2e2b6460c06bba98e8b85ebb6a3f9 
  configure.ac fa53bbd416dffc3987f8ec28bd9a8ce2b32d6831 

Diff: https://reviews.apache.org/r/32198/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 32198: Added a not equal operator for json objects.

2015-05-04 Thread Niklas Nielsen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32198/#review82407
---

Ship it!


Ship It!

- Niklas Nielsen


On May 1, 2015, 11:55 a.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32198/
> ---
> 
> (Updated May 1, 2015, 11:55 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, Joerg Schad, 
> Marco Massenzio, Niklas Nielsen, and Till Toenshoff.
> 
> 
> Bugs: MESOS-2510
> https://issues.apache.org/jira/browse/MESOS-2510
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> For consistency, adds a non equal operator to the json objects.
> 
> It also adds tests to the equality operators.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 
> 334c898906018be6e663f53815abbe047806b95c 
>   3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 
> f60d1bbe60f2e2b6460c06bba98e8b85ebb6a3f9 
> 
> Diff: https://reviews.apache.org/r/32198/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 32198: Added a not equal operator for json objects.

2015-05-01 Thread Alexander Rojas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32198/
---

(Updated May 1, 2015, 8:55 p.m.)


Review request for mesos, Benjamin Hindman, Bernd Mathiske, Joerg Schad, Marco 
Massenzio, Niklas Nielsen, and Till Toenshoff.


Changes
---

Adding tests for larger array.


Bugs: MESOS-2510
https://issues.apache.org/jira/browse/MESOS-2510


Repository: mesos


Description
---

For consistency, adds a non equal operator to the json objects.

It also adds tests to the equality operators.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 
334c898906018be6e663f53815abbe047806b95c 
  3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 
f60d1bbe60f2e2b6460c06bba98e8b85ebb6a3f9 

Diff: https://reviews.apache.org/r/32198/diff/


Testing
---

make check


Thanks,

Alexander Rojas

Re: Review Request 32198: Added a not equal operator for json objects.

2015-04-29 Thread Alexander Rojas 


> On April 20, 2015, 5:18 p.m., Niklas Nielsen wrote:
> > 3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp, line 258
> > 
> >
> > How about also checking for a larger array?
> 
> Alexander Rojas wrote:
> What can be considered larger? 5 elements, 10 elements, 100 elements? I 
> personally don't think it makes any difference for the equality operator, 
> since the comparison is still linear.
> 
> Till Toenshoff wrote:
> Niklas, do you have a suggestion here or shall we drop it?

He clarified the reason why to use 5 elements, I haven't had time to fix it 
however. Will do tomorrow.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32198/#review80559
---


On April 21, 2015, 2:06 p.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32198/
> ---
> 
> (Updated April 21, 2015, 2:06 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, Joerg Schad, 
> Marco Massenzio, Niklas Nielsen, and Till Toenshoff.
> 
> 
> Bugs: MESOS-2510
> https://issues.apache.org/jira/browse/MESOS-2510
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> For consistency, adds a non equal operator to the json objects.
> 
> It also adds tests to the equality operators.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 
> 334c898906018be6e663f53815abbe047806b95c 
>   3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 
> f60d1bbe60f2e2b6460c06bba98e8b85ebb6a3f9 
> 
> Diff: https://reviews.apache.org/r/32198/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Re: Review Request 32198: Added a not equal operator for json objects.

2015-04-29 Thread Till Toenshoff 


> On April 20, 2015, 3:18 p.m., Niklas Nielsen wrote:
> > 3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp, line 258
> > 
> >
> > How about also checking for a larger array?
> 
> Alexander Rojas wrote:
> What can be considered larger? 5 elements, 10 elements, 100 elements? I 
> personally don't think it makes any difference for the equality operator, 
> since the comparison is still linear.

Niklas, do you have a suggestion here or shall we drop it?


- Till


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32198/#review80559
---


On April 21, 2015, 12:06 p.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32198/
> ---
> 
> (Updated April 21, 2015, 12:06 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, Joerg Schad, 
> Marco Massenzio, Niklas Nielsen, and Till Toenshoff.
> 
> 
> Bugs: MESOS-2510
> https://issues.apache.org/jira/browse/MESOS-2510
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> For consistency, adds a non equal operator to the json objects.
> 
> It also adds tests to the equality operators.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp 
> 334c898906018be6e663f53815abbe047806b95c 
>   3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 
> f60d1bbe60f2e2b6460c06bba98e8b85ebb6a3f9 
> 
> Diff: https://reviews.apache.org/r/32198/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>