Re: Review Request 33263: Extended SlaveTest.ShutdownUnregisteredExecutor test with a reason check.

2015-06-23 Thread Bernd Mathiske
On April 23, 2015, 9:28 a.m., Till Toenshoff wrote: Ship It! Till Toenshoff wrote: When testing your patch, I noticed that it fails for me. ``` ../../src/tests/slave_tests.cpp:184: Failure Value of: status.get().reason() Actual: 8 Expected:

Re: Review Request 33263: Extended SlaveTest.ShutdownUnregisteredExecutor test with a reason check.

2015-06-23 Thread Bernd Mathiske
On April 23, 2015, 9:28 a.m., Till Toenshoff wrote: Ship It! Till Toenshoff wrote: When testing your patch, I noticed that it fails for me. ``` ../../src/tests/slave_tests.cpp:184: Failure Value of: status.get().reason() Actual: 8 Expected:

Re: Review Request 33263: Extended SlaveTest.ShutdownUnregisteredExecutor test with a reason check.

2015-04-26 Thread Till Toenshoff
On April 23, 2015, 4:28 p.m., Till Toenshoff wrote: Ship It! When testing your patch, I noticed that it fails for me. ``` ../../src/tests/slave_tests.cpp:184: Failure Value of: status.get().reason() Actual: 8 Expected: TaskStatus::REASON_COMMAND_EXECUTOR_FAILED Which is: 0 ``` - Till