Re: Review Request 34306: Added 'revocable_offers' field to FrameworkInfo.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34306/ --- (Updated May 21, 2015, 12:36 a.m.) Review request for mesos, Jie Yu and Niklas Nielsen. Changes --- Nik's comments. PTAL Bugs: MESOS-2654 https://issues.apache.org/jira/browse/MESOS-2654 Repository: mesos Description --- Currently setting this field is a no-op. Just wanted to send it out for feedback, esp whether a 'bool' type is enough. Diffs (updated) - include/mesos/mesos.proto 9cc5782256156ed59fd4640091413b76480d939f Diff: https://reviews.apache.org/r/34306/diff/ Testing (updated) --- make check Thanks, Vinod Kone
Re: Review Request 34306: Added 'revocable_offers' field to FrameworkInfo.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34306/#review84161 --- include/mesos/mesos.proto https://reviews.apache.org/r/34306/#comment135282 Should we make this a general 'Capability' message, such that we can announce that we can deal with revocable offers, optimistic offers, etc? - Niklas Nielsen On May 15, 2015, 5:24 p.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34306/ --- (Updated May 15, 2015, 5:24 p.m.) Review request for mesos, Jie Yu and Niklas Nielsen. Bugs: MESOS-2654 https://issues.apache.org/jira/browse/MESOS-2654 Repository: mesos Description --- Currently setting this field is a no-op. Just wanted to send it out for feedback, esp whether a 'bool' type is enough. Diffs - include/mesos/mesos.proto 9cc5782256156ed59fd4640091413b76480d939f Diff: https://reviews.apache.org/r/34306/diff/ Testing --- Thanks, Vinod Kone
Re: Review Request 34306: Added 'revocable_offers' field to FrameworkInfo.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34306/#review84016 --- Patch looks great! Reviews applied: [34304, 34306] All tests passed. - Mesos ReviewBot On May 16, 2015, 12:24 a.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34306/ --- (Updated May 16, 2015, 12:24 a.m.) Review request for mesos, Jie Yu and Niklas Nielsen. Bugs: MESOS-2654 https://issues.apache.org/jira/browse/MESOS-2654 Repository: mesos Description --- Currently setting this field is a no-op. Just wanted to send it out for feedback, esp whether a 'bool' type is enough. Diffs - include/mesos/mesos.proto 9cc5782256156ed59fd4640091413b76480d939f Diff: https://reviews.apache.org/r/34306/diff/ Testing --- Thanks, Vinod Kone
