---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34558/#review85511
---
Patch looks great!
Reviews applied: [34558]
All tests passed.
- M
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34558/#review85435
---
Ship it!
Ship It!
- Vinod Kone
On May 27, 2015, 7:05 p.m., Paul
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34558/
---
(Updated May 27, 2015, 7:05 p.m.)
Review request for mesos, Chi Zhang, Ian Down
> On May 27, 2015, 6:21 p.m., Vinod Kone wrote:
> > What's the motivation for pulling out these constatns to the file scope
> > instead of class scope as it was before? I don't follow what you mean by
> > "easier sharing".
I want to use them in later tests outside the PortMappingIsolatorTest s
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34558/#review85402
---
What's the motivation for pulling out these constatns to the file sc
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34558/
---
(Updated May 27, 2015, 6:05 p.m.)
Review request for mesos, Chi Zhang, Ian Down
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34558/
---
(Updated May 27, 2015, 5:23 p.m.)
Review request for mesos, Chi Zhang, Ian Down
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34558/#review85298
---
Ship it!
Thanks for the clean-up!
- Chi Zhang
On May 22, 2015, 1
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34558/
---
(Updated May 22, 2015, 11:16 p.m.)
Review request for mesos, Chi Zhang, Ian Dow
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34558/#review84881
---
bunch of grammatical stuff, much of it not actually yours but might
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34558/
---
(Updated May 21, 2015, 11:31 p.m.)
Review request for mesos, Chi Zhang, Ian Dow
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34558/#review84766
---
Bad patch!
Reviews applied: [34321, 34426, 34321]
Failed command:
12 matches
Mail list logo