Re: Review Request 34558: Move port mapping isolator configuration settings to file local scope for easier sharing.

2015-05-27 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34558/#review85511 --- Patch looks great! Reviews applied: [34558] All tests passed. - M

Re: Review Request 34558: Move port mapping isolator configuration settings to file local scope for easier sharing.

2015-05-27 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34558/#review85435 --- Ship it! Ship It! - Vinod Kone On May 27, 2015, 7:05 p.m., Paul

Re: Review Request 34558: Move port mapping isolator configuration settings to file local scope for easier sharing.

2015-05-27 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34558/ --- (Updated May 27, 2015, 7:05 p.m.) Review request for mesos, Chi Zhang, Ian Down

Re: Review Request 34558: Move port mapping isolator configuration settings to file local scope for easier sharing.

2015-05-27 Thread Paul Brett
> On May 27, 2015, 6:21 p.m., Vinod Kone wrote: > > What's the motivation for pulling out these constatns to the file scope > > instead of class scope as it was before? I don't follow what you mean by > > "easier sharing". I want to use them in later tests outside the PortMappingIsolatorTest s

Re: Review Request 34558: Move port mapping isolator configuration settings to file local scope for easier sharing.

2015-05-27 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34558/#review85402 --- What's the motivation for pulling out these constatns to the file sc

Re: Review Request 34558: Move port mapping isolator configuration settings to file local scope for easier sharing.

2015-05-27 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34558/ --- (Updated May 27, 2015, 6:05 p.m.) Review request for mesos, Chi Zhang, Ian Down

Re: Review Request 34558: Move port mapping isolator configuration settings to file local scope for easier sharing.

2015-05-27 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34558/ --- (Updated May 27, 2015, 5:23 p.m.) Review request for mesos, Chi Zhang, Ian Down

Re: Review Request 34558: Move port mapping isolator configuration settings to file local scope for easier sharing.

2015-05-26 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34558/#review85298 --- Ship it! Thanks for the clean-up! - Chi Zhang On May 22, 2015, 1

Re: Review Request 34558: Move port mapping isolator configuration settings to file local scope for easier sharing.

2015-05-22 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34558/ --- (Updated May 22, 2015, 11:16 p.m.) Review request for mesos, Chi Zhang, Ian Dow

Re: Review Request 34558: Move port mapping isolator configuration settings to file local scope for easier sharing.

2015-05-22 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34558/#review84881 --- bunch of grammatical stuff, much of it not actually yours but might

Re: Review Request 34558: Move port mapping isolator configuration settings to file local scope for easier sharing.

2015-05-21 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34558/ --- (Updated May 21, 2015, 11:31 p.m.) Review request for mesos, Chi Zhang, Ian Dow

Re: Review Request 34558: Move port mapping isolator configuration settings to file local scope for easier sharing.

2015-05-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34558/#review84766 --- Bad patch! Reviews applied: [34321, 34426, 34321] Failed command: