Re: Review Request 36837: Update gmock to 1.7.0.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/#review94974 --- 3rdparty/libprocess/3rdparty/CMakeLists.txt (line 166) https://reviews.apache.org/r/36837/#comment149713 This line breaks the build on my machine OS X 10.10, and I'm not sure how to fix it because CMake's weird string eval semantics make it hard to just pass a normal quoted string in. Does this break on your machien too? - Alex Clemmer On Aug. 7, 2015, 3:24 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/ --- (Updated Aug. 7, 2015, 3:24 a.m.) Review request for mesos and Michael Park. Bugs: MESOS-3141 https://issues.apache.org/jira/browse/MESOS-3141 Repository: mesos Description --- See summary. Diffs - 3rdparty/libprocess/3rdparty/CMakeLists.txt 711809e808ebd0ed95d62270220e016ba6f41dca 3rdparty/libprocess/3rdparty/gmock-1.6.0.tar.gz d45d9894b0214f5f02a88f6da5c258327110efd8 3rdparty/libprocess/3rdparty/gmock-1.7.0.tar.gz PRE-CREATION 3rdparty/libprocess/3rdparty/versions.am 97727537778511ca5a10be4f3c25cd21d919 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 3c1bb0bfed7e31440dc4be5ee9e3df4ae9152c5c 3rdparty/libprocess/configure.ac 40f344c6847424ea9b68e3d368497bf2763b4c6a Diff: https://reviews.apache.org/r/36837/diff/ Testing --- make check Thanks, haosdent huang
Re: Review Request 36837: Update gmock to 1.7.0.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/#review94503 --- Patch looks great! Reviews applied: [36837] All tests passed. - Mesos ReviewBot On Aug. 7, 2015, 3:24 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/ --- (Updated Aug. 7, 2015, 3:24 a.m.) Review request for mesos and Michael Park. Bugs: MESOS-3141 https://issues.apache.org/jira/browse/MESOS-3141 Repository: mesos Description --- See summary. Diffs - 3rdparty/libprocess/3rdparty/CMakeLists.txt 711809e808ebd0ed95d62270220e016ba6f41dca 3rdparty/libprocess/3rdparty/gmock-1.6.0.tar.gz d45d9894b0214f5f02a88f6da5c258327110efd8 3rdparty/libprocess/3rdparty/gmock-1.7.0.tar.gz PRE-CREATION 3rdparty/libprocess/3rdparty/versions.am 97727537778511ca5a10be4f3c25cd21d919 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 3c1bb0bfed7e31440dc4be5ee9e3df4ae9152c5c 3rdparty/libprocess/configure.ac 40f344c6847424ea9b68e3d368497bf2763b4c6a Diff: https://reviews.apache.org/r/36837/diff/ Testing --- make check Thanks, haosdent huang
Re: Review Request 36837: Update gmock to 1.7.0.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/#review94510 --- Ship it! Ship It! - Michael Park On Aug. 7, 2015, 3:24 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/ --- (Updated Aug. 7, 2015, 3:24 a.m.) Review request for mesos and Michael Park. Bugs: MESOS-3141 https://issues.apache.org/jira/browse/MESOS-3141 Repository: mesos Description --- See summary. Diffs - 3rdparty/libprocess/3rdparty/CMakeLists.txt 711809e808ebd0ed95d62270220e016ba6f41dca 3rdparty/libprocess/3rdparty/gmock-1.6.0.tar.gz d45d9894b0214f5f02a88f6da5c258327110efd8 3rdparty/libprocess/3rdparty/gmock-1.7.0.tar.gz PRE-CREATION 3rdparty/libprocess/3rdparty/versions.am 97727537778511ca5a10be4f3c25cd21d919 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 3c1bb0bfed7e31440dc4be5ee9e3df4ae9152c5c 3rdparty/libprocess/configure.ac 40f344c6847424ea9b68e3d368497bf2763b4c6a Diff: https://reviews.apache.org/r/36837/diff/ Testing --- make check Thanks, haosdent huang
Re: Review Request 36837: Update gmock to 1.7.0.
On Aug. 7, 2015, 8:43 a.m., Michael Park wrote: Ship It! Thank you for your great help. LoL - haosdent --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/#review94510 --- On Aug. 7, 2015, 3:24 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/ --- (Updated Aug. 7, 2015, 3:24 a.m.) Review request for mesos and Michael Park. Bugs: MESOS-3141 https://issues.apache.org/jira/browse/MESOS-3141 Repository: mesos Description --- See summary. Diffs - 3rdparty/libprocess/3rdparty/CMakeLists.txt 711809e808ebd0ed95d62270220e016ba6f41dca 3rdparty/libprocess/3rdparty/gmock-1.6.0.tar.gz d45d9894b0214f5f02a88f6da5c258327110efd8 3rdparty/libprocess/3rdparty/gmock-1.7.0.tar.gz PRE-CREATION 3rdparty/libprocess/3rdparty/versions.am 97727537778511ca5a10be4f3c25cd21d919 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 3c1bb0bfed7e31440dc4be5ee9e3df4ae9152c5c 3rdparty/libprocess/configure.ac 40f344c6847424ea9b68e3d368497bf2763b4c6a Diff: https://reviews.apache.org/r/36837/diff/ Testing --- make check Thanks, haosdent huang
Re: Review Request 36837: Update gmock to 1.7.0.
On Aug. 7, 2015, midnight, Michael Park wrote: 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake, line 36 https://reviews.apache.org/r/36837/diff/7/?file=1033437#file1033437line36 `s/1.6.0/1.7.0/` Thank you very much, let me update. - haosdent --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/#review94466 --- On Aug. 6, 2015, 9:20 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/ --- (Updated Aug. 6, 2015, 9:20 a.m.) Review request for mesos and Michael Park. Bugs: MESOS-3141 https://issues.apache.org/jira/browse/MESOS-3141 Repository: mesos Description --- See summary. Diffs - 3rdparty/libprocess/3rdparty/CMakeLists.txt 711809e808ebd0ed95d62270220e016ba6f41dca 3rdparty/libprocess/3rdparty/gmock-1.6.0.tar.gz d45d9894b0214f5f02a88f6da5c258327110efd8 3rdparty/libprocess/3rdparty/gmock-1.7.0.tar.gz PRE-CREATION 3rdparty/libprocess/3rdparty/versions.am 97727537778511ca5a10be4f3c25cd21d919 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 3c1bb0bfed7e31440dc4be5ee9e3df4ae9152c5c 3rdparty/libprocess/configure.ac 40f344c6847424ea9b68e3d368497bf2763b4c6a Diff: https://reviews.apache.org/r/36837/diff/ Testing --- make check Thanks, haosdent huang
Re: Review Request 36837: Update gmock to 1.7.0.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/ --- (Updated Aug. 7, 2015, 3:24 a.m.) Review request for mesos and Michael Park. Bugs: MESOS-3141 https://issues.apache.org/jira/browse/MESOS-3141 Repository: mesos Description --- See summary. Diffs (updated) - 3rdparty/libprocess/3rdparty/CMakeLists.txt 711809e808ebd0ed95d62270220e016ba6f41dca 3rdparty/libprocess/3rdparty/gmock-1.6.0.tar.gz d45d9894b0214f5f02a88f6da5c258327110efd8 3rdparty/libprocess/3rdparty/gmock-1.7.0.tar.gz PRE-CREATION 3rdparty/libprocess/3rdparty/versions.am 97727537778511ca5a10be4f3c25cd21d919 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 3c1bb0bfed7e31440dc4be5ee9e3df4ae9152c5c 3rdparty/libprocess/configure.ac 40f344c6847424ea9b68e3d368497bf2763b4c6a Diff: https://reviews.apache.org/r/36837/diff/ Testing --- make check Thanks, haosdent huang
Re: Review Request 36837: Update gmock to 1.7.0.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/#review94466 --- 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake (line 36) https://reviews.apache.org/r/36837/#comment149082 `s/1.6.0/1.7.0/` - Michael Park On Aug. 6, 2015, 9:20 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/ --- (Updated Aug. 6, 2015, 9:20 a.m.) Review request for mesos and Michael Park. Bugs: MESOS-3141 https://issues.apache.org/jira/browse/MESOS-3141 Repository: mesos Description --- See summary. Diffs - 3rdparty/libprocess/3rdparty/CMakeLists.txt 711809e808ebd0ed95d62270220e016ba6f41dca 3rdparty/libprocess/3rdparty/gmock-1.6.0.tar.gz d45d9894b0214f5f02a88f6da5c258327110efd8 3rdparty/libprocess/3rdparty/gmock-1.7.0.tar.gz PRE-CREATION 3rdparty/libprocess/3rdparty/versions.am 97727537778511ca5a10be4f3c25cd21d919 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 3c1bb0bfed7e31440dc4be5ee9e3df4ae9152c5c 3rdparty/libprocess/configure.ac 40f344c6847424ea9b68e3d368497bf2763b4c6a Diff: https://reviews.apache.org/r/36837/diff/ Testing --- make check Thanks, haosdent huang
Re: Review Request 36837: Update gmock to 1.7.0.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/ --- (Updated Aug. 6, 2015, 6:26 a.m.) Review request for mesos and Michael Park. Bugs: MESOS-3141 https://issues.apache.org/jira/browse/MESOS-3141 Repository: mesos Description --- See summary. Diffs (updated) - 3rdparty/libprocess/3rdparty/CMakeLists.txt 711809e808ebd0ed95d62270220e016ba6f41dca 3rdparty/libprocess/3rdparty/gmock-1.6.0.tar.gz d45d9894b0214f5f02a88f6da5c258327110efd8 3rdparty/libprocess/3rdparty/gmock-1.7.0.tar.gz PRE-CREATION 3rdparty/libprocess/3rdparty/versions.am 97727537778511ca5a10be4f3c25cd21d919 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 3c1bb0bfed7e31440dc4be5ee9e3df4ae9152c5c 3rdparty/libprocess/configure.ac 40f344c6847424ea9b68e3d368497bf2763b4c6a Diff: https://reviews.apache.org/r/36837/diff/ Testing --- make check Thanks, haosdent huang
Re: Review Request 36837: Update gmock to 1.7.0.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/ --- (Updated Aug. 6, 2015, 9:20 a.m.) Review request for mesos and Michael Park. Changes --- osx default tar would append some file have `_` prefix to package, this let distcheck failed. I use gnu tar to repackage it again. Bugs: MESOS-3141 https://issues.apache.org/jira/browse/MESOS-3141 Repository: mesos Description --- See summary. Diffs (updated) - 3rdparty/libprocess/3rdparty/CMakeLists.txt 711809e808ebd0ed95d62270220e016ba6f41dca 3rdparty/libprocess/3rdparty/gmock-1.6.0.tar.gz d45d9894b0214f5f02a88f6da5c258327110efd8 3rdparty/libprocess/3rdparty/gmock-1.7.0.tar.gz PRE-CREATION 3rdparty/libprocess/3rdparty/versions.am 97727537778511ca5a10be4f3c25cd21d919 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 3c1bb0bfed7e31440dc4be5ee9e3df4ae9152c5c 3rdparty/libprocess/configure.ac 40f344c6847424ea9b68e3d368497bf2763b4c6a Diff: https://reviews.apache.org/r/36837/diff/ Testing --- make check Thanks, haosdent huang
Re: Review Request 36837: Update gmock to 1.7.0 .
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/ --- (Updated Aug. 5, 2015, 9:24 p.m.) Review request for mesos and Michael Park. Bugs: MESOS-3141 https://issues.apache.org/jira/browse/MESOS-3141 Repository: mesos Description --- Update gmock to 1.7.0 . Diffs - 3rdparty/libprocess/3rdparty/gmock-1.6.0.tar.gz d45d9894b0214f5f02a88f6da5c258327110efd8 3rdparty/libprocess/3rdparty/gmock-1.7.0.tar.gz PRE-CREATION 3rdparty/libprocess/3rdparty/versions.am 97727537778511ca5a10be4f3c25cd21d919 Diff: https://reviews.apache.org/r/36837/diff/ Testing --- make check Thanks, haosdent huang
Re: Review Request 36837: Update gmock to 1.7.0 .
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/ --- (Updated Aug. 6, 2015, 4:22 a.m.) Review request for mesos and Michael Park. Bugs: MESOS-3141 https://issues.apache.org/jira/browse/MESOS-3141 Repository: mesos Description --- Update gmock to 1.7.0 . Diffs (updated) - 3rdparty/libprocess/3rdparty/CMakeLists.txt 711809e808ebd0ed95d62270220e016ba6f41dca 3rdparty/libprocess/3rdparty/gmock-1.6.0.tar.gz d45d9894b0214f5f02a88f6da5c258327110efd8 3rdparty/libprocess/3rdparty/gmock-1.7.0.tar.gz PRE-CREATION 3rdparty/libprocess/3rdparty/versions.am 97727537778511ca5a10be4f3c25cd21d919 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 3c1bb0bfed7e31440dc4be5ee9e3df4ae9152c5c 3rdparty/libprocess/configure.ac 40f344c6847424ea9b68e3d368497bf2763b4c6a Diff: https://reviews.apache.org/r/36837/diff/ Testing --- make check Thanks, haosdent huang
Re: Review Request 36837: Update gmock to 1.7.0.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/ --- (Updated Aug. 6, 2015, 5:08 a.m.) Review request for mesos and Michael Park. Bugs: MESOS-3141 https://issues.apache.org/jira/browse/MESOS-3141 Repository: mesos Description (updated) --- See summary. Diffs - 3rdparty/libprocess/3rdparty/CMakeLists.txt 711809e808ebd0ed95d62270220e016ba6f41dca 3rdparty/libprocess/3rdparty/gmock-1.6.0.tar.gz d45d9894b0214f5f02a88f6da5c258327110efd8 3rdparty/libprocess/3rdparty/gmock-1.7.0.tar.gz PRE-CREATION 3rdparty/libprocess/3rdparty/versions.am 97727537778511ca5a10be4f3c25cd21d919 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 3c1bb0bfed7e31440dc4be5ee9e3df4ae9152c5c 3rdparty/libprocess/configure.ac 40f344c6847424ea9b68e3d368497bf2763b4c6a Diff: https://reviews.apache.org/r/36837/diff/ Testing --- make check Thanks, haosdent huang
Re: Review Request 36837: Update gmock to 1.7.0 .
On Aug. 6, 2015, 3:27 a.m., Michael Park wrote: I'm also getting the following error when I run `distcheck`. Do you happen to know why? ``` ERROR: files left in build directory after distclean: ./3rdparty/libprocess/3rdparty/._gmock-1.7.0 make[1]: *** [distcleancheck] Error 1 make[1]: Leaving directory `/mesos/mesos-0.24.0/_build' make: *** [distcheck] Error 1 ``` Oh, let me check - haosdent --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/#review94344 --- On Aug. 6, 2015, 4:14 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/ --- (Updated Aug. 6, 2015, 4:14 a.m.) Review request for mesos and Michael Park. Bugs: MESOS-3141 https://issues.apache.org/jira/browse/MESOS-3141 Repository: mesos Description --- Update gmock to 1.7.0 . Diffs - 3rdparty/libprocess/3rdparty/gmock-1.6.0.tar.gz d45d9894b0214f5f02a88f6da5c258327110efd8 3rdparty/libprocess/3rdparty/gmock-1.7.0.tar.gz PRE-CREATION 3rdparty/libprocess/3rdparty/versions.am 97727537778511ca5a10be4f3c25cd21d919 Diff: https://reviews.apache.org/r/36837/diff/ Testing --- make check Thanks, haosdent huang
Re: Review Request 36837: Update gmock to 1.7.0.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/ --- (Updated Aug. 6, 2015, 5:07 a.m.) Review request for mesos and Michael Park. Summary (updated) - Update gmock to 1.7.0. Bugs: MESOS-3141 https://issues.apache.org/jira/browse/MESOS-3141 Repository: mesos Description --- Update gmock to 1.7.0 . Diffs - 3rdparty/libprocess/3rdparty/CMakeLists.txt 711809e808ebd0ed95d62270220e016ba6f41dca 3rdparty/libprocess/3rdparty/gmock-1.6.0.tar.gz d45d9894b0214f5f02a88f6da5c258327110efd8 3rdparty/libprocess/3rdparty/gmock-1.7.0.tar.gz PRE-CREATION 3rdparty/libprocess/3rdparty/versions.am 97727537778511ca5a10be4f3c25cd21d919 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 3c1bb0bfed7e31440dc4be5ee9e3df4ae9152c5c 3rdparty/libprocess/configure.ac 40f344c6847424ea9b68e3d368497bf2763b4c6a Diff: https://reviews.apache.org/r/36837/diff/ Testing --- make check Thanks, haosdent huang
Re: Review Request 36837: Update gmock to 1.7.0 .
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/ --- (Updated Aug. 6, 2015, 4:14 a.m.) Review request for mesos and Michael Park. Bugs: MESOS-3141 https://issues.apache.org/jira/browse/MESOS-3141 Repository: mesos Description --- Update gmock to 1.7.0 . Diffs (updated) - 3rdparty/libprocess/3rdparty/gmock-1.6.0.tar.gz d45d9894b0214f5f02a88f6da5c258327110efd8 3rdparty/libprocess/3rdparty/gmock-1.7.0.tar.gz PRE-CREATION 3rdparty/libprocess/3rdparty/versions.am 97727537778511ca5a10be4f3c25cd21d919 Diff: https://reviews.apache.org/r/36837/diff/ Testing --- make check Thanks, haosdent huang
Re: Review Request 36837: Update gmock to 1.7.0 .
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/#review94344 --- I'm also getting the following error when I run `distcheck`. Do you happen to know why? ``` ERROR: files left in build directory after distclean: ./3rdparty/libprocess/3rdparty/._gmock-1.7.0 make[1]: *** [distcleancheck] Error 1 make[1]: Leaving directory `/mesos/mesos-0.24.0/_build' make: *** [distcheck] Error 1 ``` - Michael Park On Aug. 5, 2015, 9:24 p.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/ --- (Updated Aug. 5, 2015, 9:24 p.m.) Review request for mesos and Michael Park. Bugs: MESOS-3141 https://issues.apache.org/jira/browse/MESOS-3141 Repository: mesos Description --- Update gmock to 1.7.0 . Diffs - 3rdparty/libprocess/3rdparty/gmock-1.6.0.tar.gz d45d9894b0214f5f02a88f6da5c258327110efd8 3rdparty/libprocess/3rdparty/gmock-1.7.0.tar.gz PRE-CREATION 3rdparty/libprocess/3rdparty/versions.am 97727537778511ca5a10be4f3c25cd21d919 Diff: https://reviews.apache.org/r/36837/diff/ Testing --- make check Thanks, haosdent huang
Re: Review Request 36837: Update gmock to 1.7.0.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/#review94356 --- Bad patch! Reviews applied: [36837] Failed command: ./support/apply-review.sh -n -r 36837 Error: 2015-08-06 05:20:52 URL:https://reviews.apache.org/r/36837/diff/raw/ [3271/3271] - 36837.patch [1] error: missing binary patch data for '3rdparty/libprocess/3rdparty/gmock-1.7.0.tar.gz' error: binary patch does not apply to '3rdparty/libprocess/3rdparty/gmock-1.7.0.tar.gz' error: 3rdparty/libprocess/3rdparty/gmock-1.7.0.tar.gz: patch does not apply Failed to apply patch - Mesos ReviewBot On Aug. 6, 2015, 5:08 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/ --- (Updated Aug. 6, 2015, 5:08 a.m.) Review request for mesos and Michael Park. Bugs: MESOS-3141 https://issues.apache.org/jira/browse/MESOS-3141 Repository: mesos Description --- See summary. Diffs - 3rdparty/libprocess/3rdparty/CMakeLists.txt 711809e808ebd0ed95d62270220e016ba6f41dca 3rdparty/libprocess/3rdparty/gmock-1.6.0.tar.gz d45d9894b0214f5f02a88f6da5c258327110efd8 3rdparty/libprocess/3rdparty/gmock-1.7.0.tar.gz PRE-CREATION 3rdparty/libprocess/3rdparty/versions.am 97727537778511ca5a10be4f3c25cd21d919 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 3c1bb0bfed7e31440dc4be5ee9e3df4ae9152c5c 3rdparty/libprocess/configure.ac 40f344c6847424ea9b68e3d368497bf2763b4c6a Diff: https://reviews.apache.org/r/36837/diff/ Testing --- make check Thanks, haosdent huang
Re: Review Request 36837: Update gmock to 1.7.0 .
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/#review94341 --- There are also `TODO` comments from @dhamon regarding `gmock-1.7.0` and passing `-DGTEST_LANG_CXX11`. Are they still relevant? - Michael Park On Aug. 5, 2015, 9:24 p.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/ --- (Updated Aug. 5, 2015, 9:24 p.m.) Review request for mesos and Michael Park. Bugs: MESOS-3141 https://issues.apache.org/jira/browse/MESOS-3141 Repository: mesos Description --- Update gmock to 1.7.0 . Diffs - 3rdparty/libprocess/3rdparty/gmock-1.6.0.tar.gz d45d9894b0214f5f02a88f6da5c258327110efd8 3rdparty/libprocess/3rdparty/gmock-1.7.0.tar.gz PRE-CREATION 3rdparty/libprocess/3rdparty/versions.am 97727537778511ca5a10be4f3c25cd21d919 Diff: https://reviews.apache.org/r/36837/diff/ Testing --- make check Thanks, haosdent huang
Re: Review Request 36837: Update gmock to 1.7.0 .
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/#review93066 --- Bad patch! Reviews applied: [36837] Failed command: ./support/apply-review.sh -n -r 36837 Error: 2015-07-27 03:46:17 URL:https://reviews.apache.org/r/36837/diff/raw/ [1085/1085] - 36837.patch [1] error: missing binary patch data for '3rdparty/libprocess/3rdparty/gmock-1.7.0.tar.gz' error: binary patch does not apply to '3rdparty/libprocess/3rdparty/gmock-1.7.0.tar.gz' error: 3rdparty/libprocess/3rdparty/gmock-1.7.0.tar.gz: patch does not apply Failed to apply patch - Mesos ReviewBot On July 27, 2015, 3:36 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/ --- (Updated July 27, 2015, 3:36 a.m.) Review request for mesos. Bugs: MESOS-3141 https://issues.apache.org/jira/browse/MESOS-3141 Repository: mesos Description --- Update gmock to 1.7.0 . Diffs - 3rdparty/libprocess/3rdparty/gmock-1.6.0.tar.gz d45d9894b0214f5f02a88f6da5c258327110efd8 3rdparty/libprocess/3rdparty/gmock-1.7.0.tar.gz PRE-CREATION 3rdparty/libprocess/3rdparty/versions.am 97727537778511ca5a10be4f3c25cd21d919 Diff: https://reviews.apache.org/r/36837/diff/ Testing --- Thanks, haosdent huang
Re: Review Request 36837: Update gmock to 1.7.0 .
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/#review93067 --- Bad patch! Reviews applied: [36837] Failed command: ./support/apply-review.sh -n -r 36837 Error: 2015-07-27 04:06:07 URL:https://reviews.apache.org/r/36837/diff/raw/ [1085/1085] - 36837.patch [1] error: missing binary patch data for '3rdparty/libprocess/3rdparty/gmock-1.7.0.tar.gz' error: binary patch does not apply to '3rdparty/libprocess/3rdparty/gmock-1.7.0.tar.gz' error: 3rdparty/libprocess/3rdparty/gmock-1.7.0.tar.gz: patch does not apply Failed to apply patch - Mesos ReviewBot On July 27, 2015, 4:03 a.m., haosdent huang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/ --- (Updated July 27, 2015, 4:03 a.m.) Review request for mesos. Bugs: MESOS-3141 https://issues.apache.org/jira/browse/MESOS-3141 Repository: mesos Description --- Update gmock to 1.7.0 . Diffs - 3rdparty/libprocess/3rdparty/gmock-1.6.0.tar.gz d45d9894b0214f5f02a88f6da5c258327110efd8 3rdparty/libprocess/3rdparty/gmock-1.7.0.tar.gz PRE-CREATION 3rdparty/libprocess/3rdparty/versions.am 97727537778511ca5a10be4f3c25cd21d919 Diff: https://reviews.apache.org/r/36837/diff/ Testing --- Thanks, haosdent huang
Re: Review Request 36837: Update gmock to 1.7.0 .
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/ --- (Updated July 27, 2015, 3:48 a.m.) Review request for mesos. Bugs: MESOS-3141 https://issues.apache.org/jira/browse/MESOS-3141 Repository: mesos Description --- Update gmock to 1.7.0 . Diffs (updated) - 3rdparty/libprocess/3rdparty/gmock-1.6.0.tar.gz d45d9894b0214f5f02a88f6da5c258327110efd8 3rdparty/libprocess/3rdparty/gmock-1.7.0.tar.gz PRE-CREATION 3rdparty/libprocess/3rdparty/versions.am 97727537778511ca5a10be4f3c25cd21d919 Diff: https://reviews.apache.org/r/36837/diff/ Testing --- Thanks, haosdent huang
Re: Review Request 36837: Update gmock to 1.7.0 .
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/ --- (Updated July 27, 2015, 4:03 a.m.) Review request for mesos. Bugs: MESOS-3141 https://issues.apache.org/jira/browse/MESOS-3141 Repository: mesos Description --- Update gmock to 1.7.0 . Diffs (updated) - 3rdparty/libprocess/3rdparty/gmock-1.6.0.tar.gz d45d9894b0214f5f02a88f6da5c258327110efd8 3rdparty/libprocess/3rdparty/gmock-1.7.0.tar.gz PRE-CREATION 3rdparty/libprocess/3rdparty/versions.am 97727537778511ca5a10be4f3c25cd21d919 Diff: https://reviews.apache.org/r/36837/diff/ Testing --- Thanks, haosdent huang
Re: Review Request 36837: Update gmock to 1.7.0 .
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/ --- (Updated July 27, 2015, 4:18 a.m.) Review request for mesos. Bugs: MESOS-3141 https://issues.apache.org/jira/browse/MESOS-3141 Repository: mesos Description --- Update gmock to 1.7.0 . Diffs - 3rdparty/libprocess/3rdparty/gmock-1.6.0.tar.gz d45d9894b0214f5f02a88f6da5c258327110efd8 3rdparty/libprocess/3rdparty/gmock-1.7.0.tar.gz PRE-CREATION 3rdparty/libprocess/3rdparty/versions.am 97727537778511ca5a10be4f3c25cd21d919 Diff: https://reviews.apache.org/r/36837/diff/ Testing (updated) --- make check Thanks, haosdent huang