Re: Review Request 38145: export additional message metrics from scheduler driver

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38145/#review141486
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Sept. 5, 2015, 11:41 p.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38145/
> ---
> 
> (Updated Sept. 5, 2015, 11:41 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-3022
> https://issues.apache.org/jira/browse/MESOS-3022
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> export additional message metrics from scheduler driver
> 
> 
> Diffs
> -
> 
>   src/sched/sched.cpp 012af05 
>   src/tests/scheduler_driver_tests.cpp 4963f5d 
> 
> Diff: https://reviews.apache.org/r/38145/diff/
> 
> 
> Testing
> ---
> 
> UT:
> 
> 1. make successfully!
> 2. make check successfuly!
> 3. Run the test framework to check the scheduler metrics:
> 
> #  curl -s localhost:47878/metrics/snapshot | python -m json.tool
> {
> "scheduler/event_queue_dispatches": 1,
> "scheduler/event_queue_exiteds": 0,
> "scheduler/event_queue_https": 0,
> "scheduler/event_queue_messages": 0,
> "scheduler/event_queue_terminates": 0,
> "system/cpus_total": 8,
> "system/load_15min": 0.57,
> "system/load_1min": 0,
> "system/load_5min": 0.26,
> "system/mem_free_bytes": 1120411648,
> "system/mem_total_bytes": 5071130624
> }
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 38145: export additional message metrics from scheduler driver

[Yong Qiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38145/
---

(Updated 九月 5, 2015, 2:06 p.m.)


Review request for mesos.


Bugs: MESOS-3022
https://issues.apache.org/jira/browse/MESOS-3022


Repository: mesos


Description
---

export additional message metrics from scheduler driver


Diffs (updated)
-

  src/sched/sched.cpp 012af05 
  src/tests/scheduler_driver_tests.cpp 4963f5d 

Diff: https://reviews.apache.org/r/38145/diff/


Testing
---

UT:

1. make successfully!
2. make check successfuly!
3. Run the test framework to check the scheduler metrics:

#  curl -s localhost:47878/metrics/snapshot | python -m json.tool
{
"scheduler/event_queue_dispatches": 1,
"scheduler/event_queue_exiteds": 0,
"scheduler/event_queue_https": 0,
"scheduler/event_queue_messages": 0,
"scheduler/event_queue_terminates": 0,
"system/cpus_total": 8,
"system/load_15min": 0.57,
"system/load_1min": 0,
"system/load_5min": 0.26,
"system/mem_free_bytes": 1120411648,
"system/mem_total_bytes": 5071130624
}


Thanks,

Yong Qiao Wang

Re: Review Request 38145: export additional message metrics from scheduler driver

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38145/#review97860
---


Patch looks great!

Reviews applied: [38145]

All tests passed.

- Mesos ReviewBot


On Sept. 5, 2015, 12:41 p.m., Yong Qiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38145/
> ---
> 
> (Updated Sept. 5, 2015, 12:41 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3022
> https://issues.apache.org/jira/browse/MESOS-3022
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> export additional message metrics from scheduler driver
> 
> 
> Diffs
> -
> 
>   src/sched/sched.cpp 012af0508eeceeccd168b29f36fa258d20b28c21 
>   src/tests/scheduler_driver_tests.cpp 
> 4963f5d672737e4bb8f173f0cbd6c504a5d91b71 
> 
> Diff: https://reviews.apache.org/r/38145/diff/
> 
> 
> Testing
> ---
> 
> UT:
> 
> 1. make successfully!
> 2. make check successfuly!
> 3. Run the test framework to check the scheduler metrics:
> 
> #  curl -s localhost:47878/metrics/snapshot | python -m json.tool
> {
> "scheduler/event_queue_dispatches": 1,
> "scheduler/event_queue_exiteds": 0,
> "scheduler/event_queue_https": 0,
> "scheduler/event_queue_messages": 0,
> "scheduler/event_queue_terminates": 0,
> "system/cpus_total": 8,
> "system/load_15min": 0.57,
> "system/load_1min": 0,
> "system/load_5min": 0.26,
> "system/mem_free_bytes": 1120411648,
> "system/mem_total_bytes": 5071130624
> }
> 
> 
> Thanks,
> 
> Yong Qiao Wang
> 
>

Re: Review Request 38145: export additional message metrics from scheduler driver

[Yong Qiao Wang]

> On 九月 5, 2015, 1:04 p.m., haosdent huang wrote:
> > src/sched/sched.cpp, line 102
> > 
> >
> > I think need change order to match dictionnary order here.

Thanks a million! I will update the order in the updated code diff.


- Yong Qiao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38145/#review97857
---


On 九月 5, 2015, 12:41 p.m., Yong Qiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38145/
> ---
> 
> (Updated 九月 5, 2015, 12:41 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3022
> https://issues.apache.org/jira/browse/MESOS-3022
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> export additional message metrics from scheduler driver
> 
> 
> Diffs
> -
> 
>   src/sched/sched.cpp 012af0508eeceeccd168b29f36fa258d20b28c21 
>   src/tests/scheduler_driver_tests.cpp 
> 4963f5d672737e4bb8f173f0cbd6c504a5d91b71 
> 
> Diff: https://reviews.apache.org/r/38145/diff/
> 
> 
> Testing
> ---
> 
> UT:
> 
> 1. make successfully!
> 2. make check successfuly!
> 3. Run the test framework to check the scheduler metrics:
> 
> #  curl -s localhost:47878/metrics/snapshot | python -m json.tool
> {
> "scheduler/event_queue_dispatches": 1,
> "scheduler/event_queue_exiteds": 0,
> "scheduler/event_queue_https": 0,
> "scheduler/event_queue_messages": 0,
> "scheduler/event_queue_terminates": 0,
> "system/cpus_total": 8,
> "system/load_15min": 0.57,
> "system/load_1min": 0,
> "system/load_5min": 0.26,
> "system/mem_free_bytes": 1120411648,
> "system/mem_total_bytes": 5071130624
> }
> 
> 
> Thanks,
> 
> Yong Qiao Wang
> 
>

Re: Review Request 38145: export additional message metrics from scheduler driver

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38145/#review97867
---

Ship it!


Ship It!

- haosdent huang


On Sept. 5, 2015, 2:06 p.m., Yong Qiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38145/
> ---
> 
> (Updated Sept. 5, 2015, 2:06 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3022
> https://issues.apache.org/jira/browse/MESOS-3022
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> export additional message metrics from scheduler driver
> 
> 
> Diffs
> -
> 
>   src/sched/sched.cpp 012af05 
>   src/tests/scheduler_driver_tests.cpp 4963f5d 
> 
> Diff: https://reviews.apache.org/r/38145/diff/
> 
> 
> Testing
> ---
> 
> UT:
> 
> 1. make successfully!
> 2. make check successfuly!
> 3. Run the test framework to check the scheduler metrics:
> 
> #  curl -s localhost:47878/metrics/snapshot | python -m json.tool
> {
> "scheduler/event_queue_dispatches": 1,
> "scheduler/event_queue_exiteds": 0,
> "scheduler/event_queue_https": 0,
> "scheduler/event_queue_messages": 0,
> "scheduler/event_queue_terminates": 0,
> "system/cpus_total": 8,
> "system/load_15min": 0.57,
> "system/load_1min": 0,
> "system/load_5min": 0.26,
> "system/mem_free_bytes": 1120411648,
> "system/mem_total_bytes": 5071130624
> }
> 
> 
> Thanks,
> 
> Yong Qiao Wang
> 
>

Re: Review Request 38145: export additional message metrics from scheduler driver

[haosdent huang]

> On Sept. 5, 2015, 3:27 p.m., haosdent huang wrote:
> > Ship It!

Looks good for me. But you need find a committer help you review and commit 
this patch. :-)


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38145/#review97867
---


On Sept. 5, 2015, 2:06 p.m., Yong Qiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38145/
> ---
> 
> (Updated Sept. 5, 2015, 2:06 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3022
> https://issues.apache.org/jira/browse/MESOS-3022
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> export additional message metrics from scheduler driver
> 
> 
> Diffs
> -
> 
>   src/sched/sched.cpp 012af05 
>   src/tests/scheduler_driver_tests.cpp 4963f5d 
> 
> Diff: https://reviews.apache.org/r/38145/diff/
> 
> 
> Testing
> ---
> 
> UT:
> 
> 1. make successfully!
> 2. make check successfuly!
> 3. Run the test framework to check the scheduler metrics:
> 
> #  curl -s localhost:47878/metrics/snapshot | python -m json.tool
> {
> "scheduler/event_queue_dispatches": 1,
> "scheduler/event_queue_exiteds": 0,
> "scheduler/event_queue_https": 0,
> "scheduler/event_queue_messages": 0,
> "scheduler/event_queue_terminates": 0,
> "system/cpus_total": 8,
> "system/load_15min": 0.57,
> "system/load_1min": 0,
> "system/load_5min": 0.26,
> "system/mem_free_bytes": 1120411648,
> "system/mem_total_bytes": 5071130624
> }
> 
> 
> Thanks,
> 
> Yong Qiao Wang
> 
>

Re: Review Request 38145: export additional message metrics from scheduler driver

[Yong Qiao Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38145/
---

(Updated 九月 5, 2015, 12:41 p.m.)


Review request for mesos.


Bugs: MESOS-3022
https://issues.apache.org/jira/browse/MESOS-3022


Repository: mesos


Description
---

export additional message metrics from scheduler driver


Diffs
-

  src/sched/sched.cpp 012af0508eeceeccd168b29f36fa258d20b28c21 
  src/tests/scheduler_driver_tests.cpp 4963f5d672737e4bb8f173f0cbd6c504a5d91b71 

Diff: https://reviews.apache.org/r/38145/diff/


Testing (updated)
---

UT:

1. make successfully!
2. make check successfuly!
3. Run the test framework to check the scheduler metrics:

#  curl -s localhost:47878/metrics/snapshot | python -m json.tool
{
"scheduler/event_queue_dispatches": 1,
"scheduler/event_queue_exiteds": 0,
"scheduler/event_queue_https": 0,
"scheduler/event_queue_messages": 0,
"scheduler/event_queue_terminates": 0,
"system/cpus_total": 8,
"system/load_15min": 0.57,
"system/load_1min": 0,
"system/load_5min": 0.26,
"system/mem_free_bytes": 1120411648,
"system/mem_total_bytes": 5071130624
}


Thanks,

Yong Qiao Wang

Re: Review Request 38145: export additional message metrics from scheduler driver

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38145/#review97857
---



src/sched/sched.cpp (line 102)


I think need change order to match dictionnary order here.


- haosdent huang


On Sept. 5, 2015, 12:41 p.m., Yong Qiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38145/
> ---
> 
> (Updated Sept. 5, 2015, 12:41 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3022
> https://issues.apache.org/jira/browse/MESOS-3022
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> export additional message metrics from scheduler driver
> 
> 
> Diffs
> -
> 
>   src/sched/sched.cpp 012af0508eeceeccd168b29f36fa258d20b28c21 
>   src/tests/scheduler_driver_tests.cpp 
> 4963f5d672737e4bb8f173f0cbd6c504a5d91b71 
> 
> Diff: https://reviews.apache.org/r/38145/diff/
> 
> 
> Testing
> ---
> 
> UT:
> 
> 1. make successfully!
> 2. make check successfuly!
> 3. Run the test framework to check the scheduler metrics:
> 
> #  curl -s localhost:47878/metrics/snapshot | python -m json.tool
> {
> "scheduler/event_queue_dispatches": 1,
> "scheduler/event_queue_exiteds": 0,
> "scheduler/event_queue_https": 0,
> "scheduler/event_queue_messages": 0,
> "scheduler/event_queue_terminates": 0,
> "system/cpus_total": 8,
> "system/load_15min": 0.57,
> "system/load_1min": 0,
> "system/load_5min": 0.26,
> "system/mem_free_bytes": 1120411648,
> "system/mem_total_bytes": 5071130624
> }
> 
> 
> Thanks,
> 
> Yong Qiao Wang
> 
>

Re: Review Request 38145: export additional message metrics from scheduler driver

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38145/#review97869
---


Patch looks great!

Reviews applied: [38145]

All tests passed.

- Mesos ReviewBot


On Sept. 5, 2015, 2:06 p.m., Yong Qiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38145/
> ---
> 
> (Updated Sept. 5, 2015, 2:06 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3022
> https://issues.apache.org/jira/browse/MESOS-3022
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> export additional message metrics from scheduler driver
> 
> 
> Diffs
> -
> 
>   src/sched/sched.cpp 012af05 
>   src/tests/scheduler_driver_tests.cpp 4963f5d 
> 
> Diff: https://reviews.apache.org/r/38145/diff/
> 
> 
> Testing
> ---
> 
> UT:
> 
> 1. make successfully!
> 2. make check successfuly!
> 3. Run the test framework to check the scheduler metrics:
> 
> #  curl -s localhost:47878/metrics/snapshot | python -m json.tool
> {
> "scheduler/event_queue_dispatches": 1,
> "scheduler/event_queue_exiteds": 0,
> "scheduler/event_queue_https": 0,
> "scheduler/event_queue_messages": 0,
> "scheduler/event_queue_terminates": 0,
> "system/cpus_total": 8,
> "system/load_15min": 0.57,
> "system/load_1min": 0,
> "system/load_5min": 0.26,
> "system/mem_free_bytes": 1120411648,
> "system/mem_total_bytes": 5071130624
> }
> 
> 
> Thanks,
> 
> Yong Qiao Wang
> 
>

Re: Review Request 38145: export additional message metrics from scheduler driver

[Yong Qiao Wang]

> On 九月 5, 2015, 3:27 p.m., haosdent huang wrote:
> > Ship It!
> 
> haosdent huang wrote:
> Looks good for me. But you need find a committer help you review and 
> commit this patch. :-)

Thanks again. That's very nice of you.


- Yong Qiao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38145/#review97867
---


On 九月 5, 2015, 11:41 p.m., Yong Qiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38145/
> ---
> 
> (Updated 九月 5, 2015, 11:41 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-3022
> https://issues.apache.org/jira/browse/MESOS-3022
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> export additional message metrics from scheduler driver
> 
> 
> Diffs
> -
> 
>   src/sched/sched.cpp 012af05 
>   src/tests/scheduler_driver_tests.cpp 4963f5d 
> 
> Diff: https://reviews.apache.org/r/38145/diff/
> 
> 
> Testing
> ---
> 
> UT:
> 
> 1. make successfully!
> 2. make check successfuly!
> 3. Run the test framework to check the scheduler metrics:
> 
> #  curl -s localhost:47878/metrics/snapshot | python -m json.tool
> {
> "scheduler/event_queue_dispatches": 1,
> "scheduler/event_queue_exiteds": 0,
> "scheduler/event_queue_https": 0,
> "scheduler/event_queue_messages": 0,
> "scheduler/event_queue_terminates": 0,
> "system/cpus_total": 8,
> "system/load_15min": 0.57,
> "system/load_1min": 0,
> "system/load_5min": 0.26,
> "system/mem_free_bytes": 1120411648,
> "system/mem_total_bytes": 5071130624
> }
> 
> 
> Thanks,
> 
> Yong Qiao Wang
> 
>