Re: Review Request 38145: export additional message metrics from scheduler driver

2016-07-09 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38145/#review141486 --- Closing this review due to inactivity. Please see our

Re: Review Request 38145: export additional message metrics from scheduler driver

2015-09-05 Thread Yong Qiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38145/ --- (Updated 九月 5, 2015, 2:06 p.m.) Review request for mesos. Bugs: MESOS-3022

Re: Review Request 38145: export additional message metrics from scheduler driver

2015-09-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38145/#review97860 --- Patch looks great! Reviews applied: [38145] All tests passed. -

Re: Review Request 38145: export additional message metrics from scheduler driver

2015-09-05 Thread Yong Qiao Wang
> On 九月 5, 2015, 1:04 p.m., haosdent huang wrote: > > src/sched/sched.cpp, line 102 > > > > > > I think need change order to match dictionnary order here. Thanks a million! I will update the order in the updated

Re: Review Request 38145: export additional message metrics from scheduler driver

2015-09-05 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38145/#review97867 --- Ship it! Ship It! - haosdent huang On Sept. 5, 2015, 2:06 p.m.,

Re: Review Request 38145: export additional message metrics from scheduler driver

2015-09-05 Thread haosdent huang
> On Sept. 5, 2015, 3:27 p.m., haosdent huang wrote: > > Ship It! Looks good for me. But you need find a committer help you review and commit this patch. :-) - haosdent --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 38145: export additional message metrics from scheduler driver

2015-09-05 Thread Yong Qiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38145/ --- (Updated 九月 5, 2015, 12:41 p.m.) Review request for mesos. Bugs: MESOS-3022

Re: Review Request 38145: export additional message metrics from scheduler driver

2015-09-05 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38145/#review97857 --- src/sched/sched.cpp (line 102)

Re: Review Request 38145: export additional message metrics from scheduler driver

2015-09-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38145/#review97869 --- Patch looks great! Reviews applied: [38145] All tests passed. -

Re: Review Request 38145: export additional message metrics from scheduler driver

2015-09-05 Thread Yong Qiao Wang
> On 九月 5, 2015, 3:27 p.m., haosdent huang wrote: > > Ship It! > > haosdent huang wrote: > Looks good for me. But you need find a committer help you review and > commit this patch. :-) Thanks again. That's very nice of you. - Yong Qiao