Re: Review Request 38529: CMake: Only compile proc_tests.cpp for Linux platforms.

2015-09-26 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38529/#review100722 --- Ship it! - Joris Van Remoortere On Sept. 20, 2015, 2:07 a.m.,

Re: Review Request 38529: CMake: Only compile proc_tests.cpp for Linux platforms.

2015-09-25 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38529/#review100591 --- LGTM. - Artem Harutyunyan On Sept. 19, 2015, 7:07 p.m., Alex

Re: Review Request 38529: CMake: Only compile proc_tests.cpp for Linux platforms.

2015-09-21 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38529/#review99778 --- Ship it! Ship It! This is required because `stout/proc.hpp` is

Re: Review Request 38529: CMake: Only compile proc_tests.cpp for Linux platforms.

2015-09-21 Thread Alex Clemmer
> On Sept. 21, 2015, 5:55 p.m., Joseph Wu wrote: > > Ship It! > > > > This is required because `stout/proc.hpp` is Linux-only, right? Correct! - Alex --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 38529: CMake: Only compile proc_tests.cpp for Linux platforms.

2015-09-19 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38529/ --- (Updated Sept. 20, 2015, 2:07 a.m.) Review request for mesos, Artem