Re: Review Request 38564: Add a new callback enabling custom attribute discovery logic

2015-10-13 Thread Guangya Liu 


> On 十月 13, 2015, 2:52 a.m., Guangya Liu wrote:
> > src/slave/slave.cpp, line 394
> > 
> >
> > I have one question for this after second review: I see that in 
> > slave.cpp, most APIs are calling HookManager::hooksAvailable() to check if 
> > there are hook managers. The problem is that if I have two hooks hookA and 
> > hookB, then the HookManager::hooksAvailable() will return True but the call 
> > in this code block is calling hookC which will be failed.
> > 
> > Do we need to enhance HookManager::hooksAvailable() by adding a 
> > parameter to check the availability for a specified hook manager?
> 
> Niklas Nielsen wrote:
> It is a best-effort short circuit: we know for sure that there won't be 
> anything to call if no hooks have been supplied. The hookC in your example 
> will have a default implementation and be a noop if not supplied by the user.
> 
> Does this make sense, or did you think of something else?
> If so, would you mind if we drop the issue here?

Hi Niklas, my orignal thinking is that we can enhance the API to 
HookManager::hooksAvailable(const string& hook), but the slave do not know each 
hook's real function, so we cannot check this in slave. Yes, your explanation 
does makse sense, thanks! ;-)


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38564/#review102380
---


On 十月 13, 2015, 1:39 a.m., Felix Abecassis wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38564/
> ---
> 
> (Updated 十月 13, 2015, 1:39 a.m.)
> 
> 
> Review request for mesos, Connor Doyle and Niklas Nielsen.
> 
> 
> Bugs: MESOS-3366
> https://issues.apache.org/jira/browse/MESOS-3366
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add a new callback enabling custom attribute discovery logic
> 
> 
> Diffs
> -
> 
>   include/mesos/hook.hpp 0c1042a 
>   src/examples/test_hook_module.cpp cd7c184 
>   src/hook/manager.hpp 3af1ff8 
>   src/hook/manager.cpp 108bd46 
>   src/slave/slave.cpp 01c5e42 
>   src/tests/hook_tests.cpp b35ce72 
> 
> Diff: https://reviews.apache.org/r/38564/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Felix Abecassis
> 
>

Re: Review Request 38564: Add a new callback enabling custom attribute discovery logic

2015-10-13 Thread Niklas Nielsen 


> On Oct. 12, 2015, 7:52 p.m., Guangya Liu wrote:
> > src/slave/slave.cpp, line 394
> > 
> >
> > I have one question for this after second review: I see that in 
> > slave.cpp, most APIs are calling HookManager::hooksAvailable() to check if 
> > there are hook managers. The problem is that if I have two hooks hookA and 
> > hookB, then the HookManager::hooksAvailable() will return True but the call 
> > in this code block is calling hookC which will be failed.
> > 
> > Do we need to enhance HookManager::hooksAvailable() by adding a 
> > parameter to check the availability for a specified hook manager?

It is a best-effort short circuit: we know for sure that there won't be 
anything to call if no hooks have been supplied. The hookC in your example will 
have a default implementation and be a noop if not supplied by the user.

Does this make sense, or did you think of something else?
If so, would you mind if we drop the issue here?


- Niklas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38564/#review102380
---


On Oct. 12, 2015, 6:39 p.m., Felix Abecassis wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38564/
> ---
> 
> (Updated Oct. 12, 2015, 6:39 p.m.)
> 
> 
> Review request for mesos, Connor Doyle and Niklas Nielsen.
> 
> 
> Bugs: MESOS-3366
> https://issues.apache.org/jira/browse/MESOS-3366
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add a new callback enabling custom attribute discovery logic
> 
> 
> Diffs
> -
> 
>   include/mesos/hook.hpp 0c1042a 
>   src/examples/test_hook_module.cpp cd7c184 
>   src/hook/manager.hpp 3af1ff8 
>   src/hook/manager.cpp 108bd46 
>   src/slave/slave.cpp 01c5e42 
>   src/tests/hook_tests.cpp b35ce72 
> 
> Diff: https://reviews.apache.org/r/38564/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Felix Abecassis
> 
>

Re: Review Request 38564: Add a new callback enabling custom attribute discovery logic

2015-10-13 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38564/#review102473
---

Ship it!


Ship It!

- Guangya Liu


On 十月 13, 2015, 1:39 a.m., Felix Abecassis wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38564/
> ---
> 
> (Updated 十月 13, 2015, 1:39 a.m.)
> 
> 
> Review request for mesos, Connor Doyle and Niklas Nielsen.
> 
> 
> Bugs: MESOS-3366
> https://issues.apache.org/jira/browse/MESOS-3366
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add a new callback enabling custom attribute discovery logic
> 
> 
> Diffs
> -
> 
>   include/mesos/hook.hpp 0c1042a 
>   src/examples/test_hook_module.cpp cd7c184 
>   src/hook/manager.hpp 3af1ff8 
>   src/hook/manager.cpp 108bd46 
>   src/slave/slave.cpp 01c5e42 
>   src/tests/hook_tests.cpp b35ce72 
> 
> Diff: https://reviews.apache.org/r/38564/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Felix Abecassis
> 
>

Re: Review Request 38564: Add a new callback enabling custom attribute discovery logic

2015-10-12 Thread Niklas Nielsen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38564/#review102362
---

Ship it!


Mind rebasing this, Felix? :) We can land this after fixing the few comments 
below


include/mesos/hook.hpp (lines 129 - 133)


Let's wrap at 80 cols here and in comments below



include/mesos/hook.hpp (line 134)


Let's rename this to 'slaveAttributesDecorator': here and in rest of patch



src/tests/hook_tests.cpp (line 659)


Should we rename this test as you are testing both decorators here?
If not, maybe create a seperate test for it.


- Niklas Nielsen


On Sept. 22, 2015, 9:32 a.m., Felix Abecassis wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38564/
> ---
> 
> (Updated Sept. 22, 2015, 9:32 a.m.)
> 
> 
> Review request for mesos, Connor Doyle and Niklas Nielsen.
> 
> 
> Bugs: MESOS-3366
> https://issues.apache.org/jira/browse/MESOS-3366
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add a new callback enabling custom attribute discovery logic
> 
> 
> Diffs
> -
> 
>   include/mesos/hook.hpp 2353602c8ac8b89e3fa86bda7d1e262a3debef80 
>   src/examples/test_hook_module.cpp 0dc74d60576af6f88cbdc1c9a6f82348c5761d2f 
>   src/hook/manager.hpp a517c05855b07831a9728c1191243d114781b70a 
>   src/hook/manager.cpp 691976e94d5ac9fe4f8ba583214f24900d14248c 
>   src/slave/slave.cpp 29865ece00fa8bff3054a7f8c87cbf93403405db 
>   src/tests/hook_tests.cpp b23a587c683c391ca860b3b7d876902987f4d158 
> 
> Diff: https://reviews.apache.org/r/38564/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Felix Abecassis
> 
>

Re: Review Request 38564: Add a new callback enabling custom attribute discovery logic

2015-10-12 Thread Felix Abecassis 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38564/
---

(Updated Oct. 13, 2015, 1:39 a.m.)


Review request for mesos, Connor Doyle and Niklas Nielsen.


Bugs: MESOS-3366
https://issues.apache.org/jira/browse/MESOS-3366


Repository: mesos


Description
---

Add a new callback enabling custom attribute discovery logic


Diffs (updated)
-

  include/mesos/hook.hpp 0c1042a 
  src/examples/test_hook_module.cpp cd7c184 
  src/hook/manager.hpp 3af1ff8 
  src/hook/manager.cpp 108bd46 
  src/slave/slave.cpp 01c5e42 
  src/tests/hook_tests.cpp b35ce72 

Diff: https://reviews.apache.org/r/38564/diff/


Testing
---


Thanks,

Felix Abecassis

Re: Review Request 38564: Add a new callback enabling custom attribute discovery logic

2015-10-12 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38564/#review102380
---



src/slave/slave.cpp (line 394)


I have one question for this after second review: I see that in slave.cpp, 
most APIs are calling HookManager::hooksAvailable() to check if there are hook 
managers. The problem is that if I have two hooks hookA and hookB, then the 
HookManager::hooksAvailable() will return True but the call in this code block 
is calling hookC which will be failed.

Do we need to enhance HookManager::hooksAvailable() by adding a parameter 
to check the availability for a specified hook manager?


- Guangya Liu


On 十月 13, 2015, 1:39 a.m., Felix Abecassis wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38564/
> ---
> 
> (Updated 十月 13, 2015, 1:39 a.m.)
> 
> 
> Review request for mesos, Connor Doyle and Niklas Nielsen.
> 
> 
> Bugs: MESOS-3366
> https://issues.apache.org/jira/browse/MESOS-3366
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add a new callback enabling custom attribute discovery logic
> 
> 
> Diffs
> -
> 
>   include/mesos/hook.hpp 0c1042a 
>   src/examples/test_hook_module.cpp cd7c184 
>   src/hook/manager.hpp 3af1ff8 
>   src/hook/manager.cpp 108bd46 
>   src/slave/slave.cpp 01c5e42 
>   src/tests/hook_tests.cpp b35ce72 
> 
> Diff: https://reviews.apache.org/r/38564/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Felix Abecassis
> 
>

Re: Review Request 38564: Add a new callback enabling custom attribute discovery logic

2015-10-12 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38564/#review102383
---


Patch looks great!

Reviews applied: [38279, 38517, 38564]

All tests passed.

- Mesos ReviewBot


On Oct. 13, 2015, 1:39 a.m., Felix Abecassis wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38564/
> ---
> 
> (Updated Oct. 13, 2015, 1:39 a.m.)
> 
> 
> Review request for mesos, Connor Doyle and Niklas Nielsen.
> 
> 
> Bugs: MESOS-3366
> https://issues.apache.org/jira/browse/MESOS-3366
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add a new callback enabling custom attribute discovery logic
> 
> 
> Diffs
> -
> 
>   include/mesos/hook.hpp 0c1042a 
>   src/examples/test_hook_module.cpp cd7c184 
>   src/hook/manager.hpp 3af1ff8 
>   src/hook/manager.cpp 108bd46 
>   src/slave/slave.cpp 01c5e42 
>   src/tests/hook_tests.cpp b35ce72 
> 
> Diff: https://reviews.apache.org/r/38564/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Felix Abecassis
> 
>

Re: Review Request 38564: Add a new callback enabling custom attribute discovery logic

2015-09-22 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38564/#review99934
---

Ship it!


Ship It!

- Guangya Liu


On 九月 22, 2015, 6:05 a.m., Felix Abecassis wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38564/
> ---
> 
> (Updated 九月 22, 2015, 6:05 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3366
> https://issues.apache.org/jira/browse/MESOS-3366
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add a new callback enabling custom attribute discovery logic
> 
> 
> Diffs
> -
> 
>   include/mesos/hook.hpp 2353602c8ac8b89e3fa86bda7d1e262a3debef80 
>   src/examples/test_hook_module.cpp 0dc74d60576af6f88cbdc1c9a6f82348c5761d2f 
>   src/hook/manager.hpp a517c05855b07831a9728c1191243d114781b70a 
>   src/hook/manager.cpp 691976e94d5ac9fe4f8ba583214f24900d14248c 
>   src/slave/slave.cpp 29865ece00fa8bff3054a7f8c87cbf93403405db 
>   src/tests/hook_tests.cpp b23a587c683c391ca860b3b7d876902987f4d158 
> 
> Diff: https://reviews.apache.org/r/38564/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Felix Abecassis
> 
>

Re: Review Request 38564: Add a new callback enabling custom attribute discovery logic

2015-09-22 Thread Guangya Liu 


> On 九月 21, 2015, 10:08 p.m., Guangya Liu wrote:
> > I think that you need make this patch depend on 
> > https://reviews.apache.org/r/38279/ to make this works.
> 
> Felix Abecassis wrote:
> Thank you, I hope it's fixed now.

I see that this patch is depending on https://reviews.apache.org/r/38279/ , but 
from review borad, I see that it is depending on 38517, is that right?


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38564/#review99841
---


On 九月 22, 2015, 1:40 a.m., Felix Abecassis wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38564/
> ---
> 
> (Updated 九月 22, 2015, 1:40 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3366
> https://issues.apache.org/jira/browse/MESOS-3366
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add a new callback enabling custom attribute discovery logic
> 
> 
> Diffs
> -
> 
>   include/mesos/hook.hpp 2353602c8ac8b89e3fa86bda7d1e262a3debef80 
>   src/examples/test_hook_module.cpp 0dc74d60576af6f88cbdc1c9a6f82348c5761d2f 
>   src/hook/manager.hpp a517c05855b07831a9728c1191243d114781b70a 
>   src/hook/manager.cpp 691976e94d5ac9fe4f8ba583214f24900d14248c 
>   src/slave/slave.cpp 29865ece00fa8bff3054a7f8c87cbf93403405db 
>   src/tests/hook_tests.cpp b23a587c683c391ca860b3b7d876902987f4d158 
> 
> Diff: https://reviews.apache.org/r/38564/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Felix Abecassis
> 
>

Re: Review Request 38564: Add a new callback enabling custom attribute discovery logic

2015-09-22 Thread Felix Abecassis 


> On Sept. 21, 2015, 10:08 p.m., Guangya Liu wrote:
> > I think that you need make this patch depend on 
> > https://reviews.apache.org/r/38279/ to make this works.
> 
> Felix Abecassis wrote:
> Thank you, I hope it's fixed now.
> 
> Guangya Liu wrote:
> I see that this patch is depending on https://reviews.apache.org/r/38279/ 
> , but from review borad, I see that it is depending on 38517, is that right?

Somehow, the post-review script deleted the dependency on 38279.


- Felix


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38564/#review99841
---


On Sept. 22, 2015, 6:05 a.m., Felix Abecassis wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38564/
> ---
> 
> (Updated Sept. 22, 2015, 6:05 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3366
> https://issues.apache.org/jira/browse/MESOS-3366
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add a new callback enabling custom attribute discovery logic
> 
> 
> Diffs
> -
> 
>   include/mesos/hook.hpp 2353602c8ac8b89e3fa86bda7d1e262a3debef80 
>   src/examples/test_hook_module.cpp 0dc74d60576af6f88cbdc1c9a6f82348c5761d2f 
>   src/hook/manager.hpp a517c05855b07831a9728c1191243d114781b70a 
>   src/hook/manager.cpp 691976e94d5ac9fe4f8ba583214f24900d14248c 
>   src/slave/slave.cpp 29865ece00fa8bff3054a7f8c87cbf93403405db 
>   src/tests/hook_tests.cpp b23a587c683c391ca860b3b7d876902987f4d158 
> 
> Diff: https://reviews.apache.org/r/38564/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Felix Abecassis
> 
>

Re: Review Request 38564: Add a new callback enabling custom attribute discovery logic

2015-09-22 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38564/#review99962
---


Bad review!

Reviews applied: []

Error:
 No reviewers specified. Please find a reviewer by asking on JIRA or the 
mailing list.

- Mesos ReviewBot


On Sept. 22, 2015, 6:05 a.m., Felix Abecassis wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38564/
> ---
> 
> (Updated Sept. 22, 2015, 6:05 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3366
> https://issues.apache.org/jira/browse/MESOS-3366
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add a new callback enabling custom attribute discovery logic
> 
> 
> Diffs
> -
> 
>   include/mesos/hook.hpp 2353602c8ac8b89e3fa86bda7d1e262a3debef80 
>   src/examples/test_hook_module.cpp 0dc74d60576af6f88cbdc1c9a6f82348c5761d2f 
>   src/hook/manager.hpp a517c05855b07831a9728c1191243d114781b70a 
>   src/hook/manager.cpp 691976e94d5ac9fe4f8ba583214f24900d14248c 
>   src/slave/slave.cpp 29865ece00fa8bff3054a7f8c87cbf93403405db 
>   src/tests/hook_tests.cpp b23a587c683c391ca860b3b7d876902987f4d158 
> 
> Diff: https://reviews.apache.org/r/38564/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Felix Abecassis
> 
>

Re: Review Request 38564: Add a new callback enabling custom attribute discovery logic

2015-09-21 Thread Felix Abecassis 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38564/
---

(Updated Sept. 22, 2015, 1:40 a.m.)


Review request for mesos.


Bugs: MESOS-3366
https://issues.apache.org/jira/browse/MESOS-3366


Repository: mesos


Description
---

Add a new callback enabling custom attribute discovery logic


Diffs (updated)
-

  include/mesos/hook.hpp 2353602c8ac8b89e3fa86bda7d1e262a3debef80 
  src/examples/test_hook_module.cpp 0dc74d60576af6f88cbdc1c9a6f82348c5761d2f 
  src/hook/manager.hpp a517c05855b07831a9728c1191243d114781b70a 
  src/hook/manager.cpp 691976e94d5ac9fe4f8ba583214f24900d14248c 
  src/slave/slave.cpp 29865ece00fa8bff3054a7f8c87cbf93403405db 
  src/tests/hook_tests.cpp b23a587c683c391ca860b3b7d876902987f4d158 

Diff: https://reviews.apache.org/r/38564/diff/


Testing
---


Thanks,

Felix Abecassis

Re: Review Request 38564: Add a new callback enabling custom attribute discovery logic

2015-09-21 Thread Felix Abecassis 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38564/
---

(Updated Sept. 21, 2015, 11:22 p.m.)


Review request for mesos.


Bugs: MESOS-3366
https://issues.apache.org/jira/browse/MESOS-3366


Repository: mesos


Description
---

Add a new callback enabling custom attribute discovery logic


Diffs
-

  include/mesos/hook.hpp 2353602c8ac8b89e3fa86bda7d1e262a3debef80 
  src/examples/test_hook_module.cpp 0dc74d60576af6f88cbdc1c9a6f82348c5761d2f 
  src/hook/manager.hpp a517c05855b07831a9728c1191243d114781b70a 
  src/hook/manager.cpp 691976e94d5ac9fe4f8ba583214f24900d14248c 
  src/slave/slave.cpp ad710d7b930a2f115d503ceb8f8fd7421ad30287 
  src/tests/hook_tests.cpp b23a587c683c391ca860b3b7d876902987f4d158 

Diff: https://reviews.apache.org/r/38564/diff/


Testing
---


Thanks,

Felix Abecassis

Re: Review Request 38564: Add a new callback enabling custom attribute discovery logic

2015-09-21 Thread Felix Abecassis 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38564/
---

(Updated Sept. 22, 2015, 12:16 a.m.)


Review request for mesos.


Bugs: MESOS-3366
https://issues.apache.org/jira/browse/MESOS-3366


Repository: mesos


Description
---

Add a new callback enabling custom attribute discovery logic


Diffs
-

  include/mesos/hook.hpp 2353602c8ac8b89e3fa86bda7d1e262a3debef80 
  src/examples/test_hook_module.cpp 0dc74d60576af6f88cbdc1c9a6f82348c5761d2f 
  src/hook/manager.hpp a517c05855b07831a9728c1191243d114781b70a 
  src/hook/manager.cpp 691976e94d5ac9fe4f8ba583214f24900d14248c 
  src/slave/slave.cpp ad710d7b930a2f115d503ceb8f8fd7421ad30287 
  src/tests/hook_tests.cpp b23a587c683c391ca860b3b7d876902987f4d158 

Diff: https://reviews.apache.org/r/38564/diff/


Testing
---


Thanks,

Felix Abecassis

Re: Review Request 38564: Add a new callback enabling custom attribute discovery logic

2015-09-21 Thread Kapil Arya 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38564/#review99890
---

Ship it!



include/mesos/hook.hpp (lines 25 - 27)


Alphabetize please.


- Kapil Arya


On Sept. 21, 2015, 9:27 p.m., Felix Abecassis wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38564/
> ---
> 
> (Updated Sept. 21, 2015, 9:27 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3366
> https://issues.apache.org/jira/browse/MESOS-3366
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add a new callback enabling custom attribute discovery logic
> 
> 
> Diffs
> -
> 
>   include/mesos/hook.hpp 53c9833 
>   src/examples/test_hook_module.cpp 6a9bf46 
>   src/hook/manager.hpp c2b41b3 
>   src/hook/manager.cpp cc0e74e 
>   src/slave/slave.cpp f1f1be2 
>   src/tests/hook_tests.cpp bd21c61 
> 
> Diff: https://reviews.apache.org/r/38564/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Felix Abecassis
> 
>

Re: Review Request 38564: Add a new callback enabling custom attribute discovery logic

2015-09-21 Thread Felix Abecassis 


> On Sept. 21, 2015, 10:08 p.m., Guangya Liu wrote:
> > I think that you need make this patch depend on 
> > https://reviews.apache.org/r/38279/ to make this works.

Thank you, I hope it's fixed now.


- Felix


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38564/#review99841
---


On Sept. 21, 2015, 11:22 p.m., Felix Abecassis wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38564/
> ---
> 
> (Updated Sept. 21, 2015, 11:22 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3366
> https://issues.apache.org/jira/browse/MESOS-3366
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add a new callback enabling custom attribute discovery logic
> 
> 
> Diffs
> -
> 
>   include/mesos/hook.hpp 2353602c8ac8b89e3fa86bda7d1e262a3debef80 
>   src/examples/test_hook_module.cpp 0dc74d60576af6f88cbdc1c9a6f82348c5761d2f 
>   src/hook/manager.hpp a517c05855b07831a9728c1191243d114781b70a 
>   src/hook/manager.cpp 691976e94d5ac9fe4f8ba583214f24900d14248c 
>   src/slave/slave.cpp ad710d7b930a2f115d503ceb8f8fd7421ad30287 
>   src/tests/hook_tests.cpp b23a587c683c391ca860b3b7d876902987f4d158 
> 
> Diff: https://reviews.apache.org/r/38564/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Felix Abecassis
> 
>

Re: Review Request 38564: Add a new callback enabling custom attribute discovery logic

2015-09-21 Thread Felix Abecassis 


> On Sept. 21, 2015, 11:27 p.m., Connor Doyle wrote:
> > include/mesos/hook.hpp, line 129
> > 
> >
> > Missing definite article: "within the slave".

I wanted to add it, but the hooks above don't. I know, that's not necessarily a 
good excuse :)


- Felix


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38564/#review99846
---


On Sept. 21, 2015, 11:22 p.m., Felix Abecassis wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38564/
> ---
> 
> (Updated Sept. 21, 2015, 11:22 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3366
> https://issues.apache.org/jira/browse/MESOS-3366
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add a new callback enabling custom attribute discovery logic
> 
> 
> Diffs
> -
> 
>   include/mesos/hook.hpp 2353602c8ac8b89e3fa86bda7d1e262a3debef80 
>   src/examples/test_hook_module.cpp 0dc74d60576af6f88cbdc1c9a6f82348c5761d2f 
>   src/hook/manager.hpp a517c05855b07831a9728c1191243d114781b70a 
>   src/hook/manager.cpp 691976e94d5ac9fe4f8ba583214f24900d14248c 
>   src/slave/slave.cpp ad710d7b930a2f115d503ceb8f8fd7421ad30287 
>   src/tests/hook_tests.cpp b23a587c683c391ca860b3b7d876902987f4d158 
> 
> Diff: https://reviews.apache.org/r/38564/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Felix Abecassis
> 
>

Re: Review Request 38564: Add a new callback enabling custom attribute discovery logic

2015-09-21 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38564/#review99841
---


I think that you need make this patch depend on 
https://reviews.apache.org/r/38279/ to make this works.

- Guangya Liu


On 九月 21, 2015, 6:30 p.m., Felix Abecassis wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38564/
> ---
> 
> (Updated 九月 21, 2015, 6:30 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3366
> https://issues.apache.org/jira/browse/MESOS-3366
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add a new callback enabling custom attribute discovery logic
> 
> 
> Diffs
> -
> 
>   include/mesos/hook.hpp 2353602c8ac8b89e3fa86bda7d1e262a3debef80 
>   src/examples/test_hook_module.cpp 0dc74d60576af6f88cbdc1c9a6f82348c5761d2f 
>   src/hook/manager.hpp a517c05855b07831a9728c1191243d114781b70a 
>   src/hook/manager.cpp 691976e94d5ac9fe4f8ba583214f24900d14248c 
>   src/slave/slave.cpp ad710d7b930a2f115d503ceb8f8fd7421ad30287 
>   src/tests/hook_tests.cpp b23a587c683c391ca860b3b7d876902987f4d158 
> 
> Diff: https://reviews.apache.org/r/38564/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Felix Abecassis
> 
>