Re: Review Request 39017: RegistryClient refactor: changed Manifest struct

2015-11-05 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39017/#review105355 --- Ship it! Ship It! - Timothy Chen On Nov. 5, 2015, 8:27 p.m., Jo

Re: Review Request 39017: RegistryClient refactor: changed Manifest struct

2015-11-05 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39017/ --- (Updated Nov. 5, 2015, 8:27 p.m.) Review request for mesos, Ben Mahler and Timo

Re: Review Request 39017: RegistryClient refactor: changed Manifest struct

2015-11-05 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39017/ --- (Updated Nov. 5, 2015, 7:15 p.m.) Review request for mesos, Ben Mahler and Timo

Re: Review Request 39017: RegistryClient refactor: changed Manifest struct

2015-11-05 Thread Jojy Varghese
> On Nov. 5, 2015, 6:35 p.m., Timothy Chen wrote: > > src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp, line > > 486 > > > > > > You need to check for errors in all the find JSON calls. Dropping

Re: Review Request 39017: RegistryClient refactor: changed Manifest struct

2015-11-05 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39017/#review105285 --- src/slave/containerizer/mesos/provisioner/docker/registry_client.c

Re: Review Request 39017: RegistryClient refactor: changed Manifest struct

2015-11-05 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39017/#review105284 --- src/slave/containerizer/mesos/provisioner/docker/registry_client.c

Re: Review Request 39017: RegistryClient refactor: changed Manifest struct

2015-11-05 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39017/ --- (Updated Nov. 5, 2015, 4:02 p.m.) Review request for mesos, Ben Mahler and Timo

Re: Review Request 39017: RegistryClient refactor: changed Manifest struct

2015-11-04 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39017/ --- (Updated Nov. 4, 2015, 11:23 p.m.) Review request for mesos and Ben Mahler. C

Re: Review Request 39017: RegistryClient refactor: changed Manifest struct

2015-11-01 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39017/ --- (Updated Nov. 1, 2015, 3:33 p.m.) Review request for mesos and Ben Mahler. Su