Re: Review Request 39493: Added `yum install nss` to CentOS 6.6 install docs.

2015-11-02 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39493/
---

(Updated Nov. 2, 2015, 7:52 p.m.)


Review request for mesos, Adam B and haosdent huang.


Changes
---

Addressed comment, changed to `yum install nss`.


Summary (updated)
-

Added `yum install nss` to CentOS 6.6 install docs.


Bugs: MESOS-3506
https://issues.apache.org/jira/browse/MESOS-3506


Repository: mesos


Description (updated)
---

Added `yum install nss` to CentOS 6.6 install docs.


Diffs (updated)
-

  docs/getting-started.md 35c8c566fff83abfcfcce177bfb9a35454f26494 

Diff: https://reviews.apache.org/r/39493/diff/


Testing
---

Viewed in the Mesos Website Container: 
https://github.com/mesosphere/mesos-website-container


Thanks,

Greg Mann

Re: Review Request 39493: Added `yum install nss` to CentOS 6.6 install docs.

2015-11-02 Thread Greg Mann 


> On Oct. 24, 2015, 5:12 a.m., haosdent huang wrote:
> > docs/getting-started.md, line 61
> > 
> >
> > How about add nss through install. Because install also would update if 
> > the package installed.

Thanks haosdent, this makes the instructions a bit more concise. I just 
confirmed that it works.


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39493/#review103894
---


On Nov. 2, 2015, 7:52 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39493/
> ---
> 
> (Updated Nov. 2, 2015, 7:52 p.m.)
> 
> 
> Review request for mesos, Adam B and haosdent huang.
> 
> 
> Bugs: MESOS-3506
> https://issues.apache.org/jira/browse/MESOS-3506
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added `yum install nss` to CentOS 6.6 install docs.
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md 35c8c566fff83abfcfcce177bfb9a35454f26494 
> 
> Diff: https://reviews.apache.org/r/39493/diff/
> 
> 
> Testing
> ---
> 
> Viewed in the Mesos Website Container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 39493: Added `yum install nss` to CentOS 6.6 install docs.

2015-11-02 Thread Adam B 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39493/#review104873
---

Ship it!


Ship It!


docs/getting-started.md (line 57)


Looks like we're wrapping the "script" comments in this file, but I can do 
that before I commit.


- Adam B


On Nov. 2, 2015, 12:54 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39493/
> ---
> 
> (Updated Nov. 2, 2015, 12:54 p.m.)
> 
> 
> Review request for mesos, Adam B and haosdent huang.
> 
> 
> Bugs: MESOS-3506
> https://issues.apache.org/jira/browse/MESOS-3506
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added `yum install nss` to CentOS 6.6 install docs.
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md 35c8c566fff83abfcfcce177bfb9a35454f26494 
> 
> Diff: https://reviews.apache.org/r/39493/diff/
> 
> 
> Testing
> ---
> 
> Viewed in the Mesos Website Container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 39493: Added `yum install nss` to CentOS 6.6 install docs.

2015-11-02 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39493/
---

(Updated Nov. 2, 2015, 8:54 p.m.)


Review request for mesos, Adam B and haosdent huang.


Changes
---

Updated comment in docs.


Bugs: MESOS-3506
https://issues.apache.org/jira/browse/MESOS-3506


Repository: mesos


Description
---

Added `yum install nss` to CentOS 6.6 install docs.


Diffs (updated)
-

  docs/getting-started.md 35c8c566fff83abfcfcce177bfb9a35454f26494 

Diff: https://reviews.apache.org/r/39493/diff/


Testing
---

Viewed in the Mesos Website Container: 
https://github.com/mesosphere/mesos-website-container


Thanks,

Greg Mann

Re: Review Request 39493: Added `yum install nss` to CentOS 6.6 install docs.

2015-11-02 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39493/#review104813
---


Patch looks great!

Reviews applied: [39493]

All tests passed.

- Mesos ReviewBot


On Nov. 2, 2015, 8:54 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39493/
> ---
> 
> (Updated Nov. 2, 2015, 8:54 p.m.)
> 
> 
> Review request for mesos, Adam B and haosdent huang.
> 
> 
> Bugs: MESOS-3506
> https://issues.apache.org/jira/browse/MESOS-3506
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added `yum install nss` to CentOS 6.6 install docs.
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md 35c8c566fff83abfcfcce177bfb9a35454f26494 
> 
> Diff: https://reviews.apache.org/r/39493/diff/
> 
> 
> Testing
> ---
> 
> Viewed in the Mesos Website Container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>